12278 Commits

Author SHA1 Message Date
Greg Spencer
9372f86149
Update the Dockerfile to use the master firebase-tools, tweak scripts (#23279) 2018-10-19 12:22:03 -07:00
Greg Spencer
fbb01eabae
Update dartdoc to use 0.24.1 (#23275) 2018-10-19 10:40:30 -07:00
Greg Spencer
2000583ed3
Revert "don't disable TODO issues in IDEs (#23274)" (#23297)
Devon asked me to revert commit c4d1b31b746955a28c05c959873a9e9eeebc042d.

Merging on red to fix the build.
2018-10-19 10:03:35 -07:00
Devon Carew
c4d1b31b74
don't disable TODO issues in IDEs (#23274)
* don't disable TODO issues in IDEs

* minor change to start cirrus
2018-10-19 08:01:05 -07:00
Siva
cf18d01e86
Disable unsafePackageSerialization as it causes issues when coverage is turned on (#23280)
* Disable unsafePackageSerialization as it causes issues when coverage is
used (see https://github.com/dart-lang/sdk/issues/34841)

* Restore Coverage.
2018-10-19 06:19:24 -07:00
Danny Tuppeny
f87a2a32fe
Switch to URIs for breakpoints and unskip tests on Windows (#22510)
* Switch to URIs for breakpoints and unskip tests on Windows

addBreakpointWithScriptUri expects Uris. By coincidence, FS paths work on Mac/Linux but they fail on Windows. One of the issues in the skip comment is fixed, the other one seems not relevant here.

* Apply symlink resolution to all integration tests

The default temp folders we get include symlinks which breaks breakpoints.

* Save 🙄

* Fix typo
2018-10-19 12:51:31 +01:00
Michael Goderbauer
bb0290a4dc
Revert "Remove all service extensions from release mode (#23038)" (#23290)
This reverts commit 8e2ca93f52d82d22df8b987cef74238ac53b4b28.

Fixes https://github.com/flutter/flutter/issues/23172
2018-10-19 11:48:15 +02:00
Danny Tuppeny
b357b55904
Use (processors-1) for test runs (test defaults to processors/2) (#22803)
* Use (processors-1) for test runs (test defaults to processors/2)

* Add missing import 🙄
2018-10-19 08:07:54 +01:00
Alexander Aprelev
be0dde4114
Remove optimization that was trying to bypass build process for iOS sim. (#23268)
This optimization resulted in app still running with old kernel file.
Fixes another source of https://github.com/flutter/flutter/issues/16604
2018-10-18 20:45:48 -07:00
Alexander Aprelev
dd789e645b
Handle escaped spaces in deps-file. (#23273) 2018-10-18 20:44:38 -07:00
engine-flutter-autoroll
6a3ff018b1 Roll engine 104f0572802c..3860a43379fa (5 commits) (#23271)
104f057280...3860a43379

git log 104f0572802c..3860a43379fa --no-merges --oneline
3860a4337 Re-revert wrong line_heights implementation (flutter/engine#6598)
09dcc3d5e Gate locale.getScript() behind version check for android  API < 21 (flutter/engine#6592)
c17624479 Provide an estimate of EngineLayer memory usage to the Dart GC (flutter/engine#6589)
2511dec76 Roll src/third_party/skia a64e4eeaa357..b4ae49937d83 (14 commits) (flutter/engine#6590)
0887dd58f Roll buildroot to 4ee38927dc45c46f2a1c74b1e3700b3cf953e747 (flutter/engine#6586)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-18 15:38:26 -07:00
Alexander Aprelev
51160b7d56
Revert "Handle escaped spaces in deps-file. (#23249)" (#23270)
This reverts commit 617e8f65b97013c5876cef9236582dffcbe2a469 as it
breaks deps-processing on Windows.
2018-10-18 15:13:40 -07:00
Alexander Aprelev
617e8f65b9
Handle escaped spaces in deps-file. (#23249)
Fixes https://github.com/flutter/flutter/issues/23236
2018-10-18 14:50:15 -07:00
Yegor
82d6589590
Revert "newly created apps / plugins should use latest gradle dependencies (#22790)" (#23263)
This reverts commit 751c083f7db339d4bca782f2f4d8232c0d9cdc10.

Our buildbots need to be upgraded to a newer version of the Android SDK.
2018-10-18 14:17:47 -07:00
Sebastian Roth
751c083f7d newly created apps / plugins should use latest gradle dependencies (#22790) 2018-10-18 12:56:18 -07:00
Jason Simmons
086cfcb133
Add a delay to the Gallery navigation memory test to give Dart an opportunity to GC (#23250)
See https://github.com/flutter/flutter/issues/23171
2018-10-18 12:30:16 -07:00
Dinesh Ahuja
7fbb5b9f32 Create WidgetTester.ensureVisible(Finder) (#22620)
This is just a shorthand for
Scrollable.ensureVisible(tester.element(finder))

Fixes #8185
2018-10-18 12:17:47 -07:00
Stanislav Baranov
d5777b6a9a
Implement correct orthographic projection (#22985) 2018-10-18 11:27:02 -07:00
Luan Nico
bbe8cf606e Improved readme (#23079)
Link to CONTRIBUTING.md in the flutter_tools README
2018-10-18 10:58:15 -07:00
Greg Spencer
f16b44be1c
Remove appveyor configuration (#23251)
We're no longer using Appveyor.
2018-10-18 10:57:18 -07:00
Greg Spencer
36983508ad
Update wrapping message (#23104)
Updating the --wrap-column help message to reflect reality.
2018-10-18 10:56:52 -07:00
Michael Klimushyn
20d0b282d1
Stop comparing modified timestamps in flutter.bat (#23176)
Fixes flutter/flutter#22062
2018-10-18 09:15:24 -07:00
Hans Muller
4f4050bf47
Support for disabling interactive TextField caret and selection (#22924)
Make it possible to disable TextField's default handlers for tap and long press. If enableInteractiveSelection is false then taps no longer move the text caret and long-press no longer selects text and shows the cut/copy/paste menu. Accessibility is similarly limited.
2018-10-18 09:14:27 -07:00
engine-flutter-autoroll
5d7938d6ec
Roll engine cc2ec365b738..104f0572802c (2 commits) (#23245)
cc2ec365b7...104f057280

git log cc2ec365b738..104f0572802c --no-merges --oneline
104f05728 Roll src/third_party/skia dd254486280d..a64e4eeaa357 (1 commits) (flutter/engine#6588)
9a981eace Roll src/third_party/skia 48ee86f818fb..dd254486280d (2 commits) (flutter/engine#6587)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-18 11:49:02 -04:00
Alexandre Ardhuin
7ce28d1277
use Duration.zero (#23218) 2018-10-18 13:57:52 +02:00
Michael Goderbauer
d28fa281f5
Add comma in doc (#23196) 2018-10-18 12:07:37 +02:00
engine-flutter-autoroll
5193affb27
Roll engine 8cc49cac3b4a..cc2ec365b738 (5 commits) (#23237)
8cc49cac3b...cc2ec365b7

git log 8cc49cac3b4a..cc2ec365b738 --no-merges --oneline
cc2ec365b Roll src/third_party/skia 5deda2e93055..48ee86f818fb (3 commits) (flutter/engine#6585)
31557d0c7 Roll src/third_party/skia 928db927f7fc..5deda2e93055 (6 commits) (flutter/engine#6584)
607c05c93 Run all supported host unit tests on Cirrus. (flutter/engine#6575)
979de076b Add a CountDownLatch to fml with tests. (flutter/engine#6574)
705738fd7 Roll src/third_party/skia 3a0c66da5fc2..928db927f7fc (5 commits) (flutter/engine#6573)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-18 04:15:02 -04:00
liyuqian
b0787b900f
Roll engine 04c860fa1dba..8cc49cac3b4a (3 commits) (#23223)
And update goldens.

git log 04c860fa1dba..8cc49cac3b4a --no-merges --oneline
8cc49cac3 Ensure that the isolate shutdown callback occurs in an isolate scope. (flutter/engine#6572)
04a1ffa42 Roll src/third_party/skia cb65ce7f77c9..3a0c66da5fc2 (10 commits) (flutter/engine#6571)
35340ceaf Pass full locale list with script and variant codes to framework (flutter/engine#6557)
2018-10-17 21:49:37 -07:00
Yegor
9524b611c0
skip coverage due to https://github.com/dart-lang/sdk/issues/34841 (#23224) 2018-10-17 17:56:07 -07:00
engine-flutter-autoroll
44c0080a3c
Roll engine 08272ee6aa33..04c860fa1dba (19 commits) (#23219)
08272ee6aa...04c860fa1d

git log 08272ee6aa33..04c860fa1dba --no-merges --oneline
04c860fa1 Revert "Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (#6549)" (flutter/engine#6568)
ef2ea1213 Roll src/third_party/skia 5b90b84085cf..cb65ce7f77c9 (8 commits) (flutter/engine#6567)
065246eed Roll src/third_party/skia 483536c242f3..5b90b84085cf (3 commits) (flutter/engine#6566)
b0008ca39 Roll src/third_party/skia 583161c09a3b..483536c242f3 (2 commits) (flutter/engine#6565)
e22da7c70 Roll src/third_party/skia 0a8faf3f557d..583161c09a3b (1 commits) (flutter/engine#6564)
915f5e01a Roll src/third_party/skia f831b64ed40e..0a8faf3f557d (5 commits) (flutter/engine#6563)
ad0fbd5d4 Roll src/third_party/skia c9092eb46754..f831b64ed40e (14 commits) (flutter/engine#6561)
6697d9dde Update @animation dartdoc directives to current api (flutter/engine#6552)
10f9cab4c Ensure that the platform view is created and destroyed when running the shell unittests. (flutter/engine#6560)
df5f4207a Roll src/third_party/skia 3d99b1e347be..c9092eb46754 (10 commits) (flutter/engine#6559)
215c14694 Roll src/third_party/skia 1349ec4de78c..3d99b1e347be (3 commits) (flutter/engine#6556)
fc376dd53 Roll src/third_party/skia a583a06f831e..1349ec4de78c (1 commits) (flutter/engine#6555)
2dbbb2a9a Roll src/third_party/skia 198b87e5be20..a583a06f831e (5 commits) (flutter/engine#6554)
126e61d34 Roll src/third_party/skia b3067e8e1b6e..198b87e5be20 (2 commits) (flutter/engine#6553)
2cd79d14a Roll src/third_party/skia 4b7b2ceb4ad9..b3067e8e1b6e (1 commits) (flutter/engine#6551)
62cd86c5a Advertise iOS Observatory port over mDNS/Bonjour (flutter/engine#6533)
26f437f37 Fix crash when removeViewImmediate invoked from platform view (flutter/engine#6266)
aed6b8c46 Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (flutter/engine#6549)
3ba6270b2 Roll src/third_party/skia 921ec976556c..4b7b2ceb4ad9 (14 commits) (flutter/engine#6550)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-17 16:45:03 -04:00
Yegor
3fbd140e77
Use new mixin syntax for super-mixins (#22870)
This re-lands 3c56e6c on top of a new Dart SDK that contains new mixin syntax fixes.
2018-10-17 13:10:05 -07:00
Sebastian Roth
b95b67a66b allow command line option "--project-name" in flutter create (#22022)
Simple convenience function if users create flutter projects in custom folder structures and but want to specify a custom project name.
2018-10-17 08:25:46 -07:00
Michael Klimushyn
4f8acd8462
Set FlutterDevice.viewFilter by CLI flag (#23026)
`FlutterDevice.views` is limited by a filter. Pipe this filter up as an
option for the commands that instantiate `FlutterDevice`s. This is the
first change necessary for the CLI tooling to target specific isolates
(#22009).

More work needs to be done after this patch.
* Isolate names are dynamically generated and change every restart.
* This just filters views, not background isolates (`VMService.isolates`).
2018-10-17 08:07:49 -07:00
Jacob Richman
e4c2c978a6
Dispatch a Flutter.Navigation event each time navigation occurs. (#23126)
Dispatch a Flutter.Navigation event each time navigation occurs.
2018-10-17 07:40:08 -07:00
Jacob Richman
f86bdf1aa2
Fix bug where gradle build rule would rerun on switching from (#23183)
--track-widget-creation=false to
--track-widget-creation=true
but not when switching from
--track-widget-creation=true
to
--track-widget-creation=false

due to the surprising behavior of Gradle @Optional inputs.
2018-10-17 07:39:20 -07:00
Alexandre Ardhuin
8b0de38ef8
fix upcoming lint avoid_returning_null_for_void (#23190) 2018-10-17 11:01:37 +02:00
Dwayne Slater
cab7ecb8e5 Fix out of range spring simulation in ClampingScrollSimulation (#22394)
If the scroll is out of range for any reason (for instance, changing scroll physics or manually messing with scroll position), the spring simulation causes the scroll position to slingshot towards the end. Also, before this change, `end` was unused.
2018-10-17 10:49:27 +02:00
Alexandre Ardhuin
936dea28da
enable lint prefer_void_to_null (#23174)
* enable lint prefer_void_to_null

* replace last Null by void
2018-10-17 08:09:29 +02:00
Hans Muller
7a63fac0a2
TextTheme.apply() should not assume non-null TextStyle fields (#23184) 2018-10-16 19:43:52 -07:00
Philip
a0010d391c Added sample code for BottomNavigationBar widget [#21136] (#21615)
* Added sample code for BottomNavigationBar widget [#21136]

* bottomnavigationbaritems made single line
2018-10-16 16:54:26 -07:00
Hans Muller
cef11417da
Added Mongolian (mn) translations (#23168) 2018-10-16 14:58:02 -07:00
Hans Muller
8521d6334f
Updated Khmer and Turkish translations (#23165) 2018-10-16 14:57:37 -07:00
Janice Collins
24717a3280
Update dartdoc to v0.24.0. (#23175) 2018-10-16 14:40:03 -07:00
Jonah Williams
c9ca7c4936
Add override frontend_server snapshot for fuchsia_reload command (#23162) 2018-10-16 14:27:22 -07:00
jslavitz
fd02bdf1b5
Fix disabled formfield validation (#23167)
* Fix form field validate method being called if form field is disabled
2018-10-16 14:03:49 -07:00
Francisco Magdaleno
d556d2117d Finalize editing when hitting the enter key on a single line TextField (#23015)
Behavior remains the same for multiline TextFields. This behavior already happens on iOS and Android, but not desktop. #23014
2018-10-16 14:02:00 -07:00
Dan Field
ffa8a1ebe8
Make it easier to use CocoaPods to Add2App for iOS (#23021)
* Make it easier to Add2App for iOS

* Use local engine if xcconfig says so

* newline
2018-10-16 13:50:20 -07:00
Max Bittker
25e40ba599 fix Curves.bounceInOut math (#22825)
* fix Curves.bounceInOut

* assert maximum slope
2018-10-16 13:49:18 -07:00
Alexandre Ardhuin
0fb84e96c7
Prefer void to null (#22977)
* Future<void> main

* Future<void>.delayed

* prefer_void_to_Null

* address review comments
2018-10-16 22:03:06 +02:00
Dan Field
5efe095895
Revert "Roll engine to aed6b8c46b05c7cee4506a9757dd9ea1b40583c2." (#23170)
This reverts commit a34488dd6743a42a20107f5917de628e81739305.
2018-10-16 12:57:07 -07:00