12278 Commits

Author SHA1 Message Date
Janice Collins
59f1f1b6e2
Update dartdoc to 0.23.1. (#22875) 2018-10-09 13:49:00 -07:00
Jonah Williams
9e51cc3e83
Add assert for null duration on snackbar (#22746) 2018-10-09 13:45:56 -07:00
jslavitz
8d545e9301
Add disabledThumbColor and other properties from Switch to SwitchListTile final (#22823)
* added missing properties
2018-10-09 13:43:15 -07:00
engine-flutter-autoroll
d954ae6850 Roll engine 289c6b1a1c27..bf377896ff0f (2 commits) (#22878)
289c6b1a1c...bf377896ff

git log 289c6b1a1c27..bf377896ff0f --no-merges --oneline
bf377896f Revert height (flutter/engine#6477)
ec103ad52 Roll src/third_party/skia a41a74ac7994..ef85d19100b1 (11 commits) (flutter/engine#6476)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-09 13:21:06 -07:00
Stanislav Baranov
570ae840f2
Remove unused deps and flags from flutter tool. (#22571) 2018-10-09 13:04:06 -07:00
engine-flutter-autoroll
e3ec1cc150 Roll engine 08af410d4ab5..289c6b1a1c27 (1 commits) (#22869)
08af410d4a...289c6b1a1c

git log 08af410d4ab5..289c6b1a1c27 --no-merges --oneline
289c6b1a1 Revert "Revert "Use single_root_scheme when compiling platform (#6402)" (#6431)" (flutter/engine#6473)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-09 12:51:04 -07:00
liyuqian
a5c161c13a
Revert "Add a profile build type to the app template" (#22872)
Reverts flutter/flutter#22837

Try to fix application_test

* Revert "Add a profile build type to the app template (#22837)"

This reverts commit 3b248fdc111d1b25014ed723ac4a0bc4225f6461.
2018-10-09 11:43:31 -07:00
Stanislav Baranov
9a22f5a117
Ensure that VM snapshot is copied from artifacts before gradle merges assets. (#22707)
Gradle plugin support for adding flutter as subproject to another Android app
2018-10-09 10:40:03 -07:00
engine-flutter-autoroll
bbc83022f8
Roll engine 69e9eb1cd1ce..08af410d4ab5 (2 commits) (#22866)
69e9eb1cd1...08af410d4a

git log 69e9eb1cd1ce..08af410d4ab5 --no-merges --oneline
08af410d4 [dart] Roll dart to a50dfd66980ed5c9aef9851fcc57557fb607769c. (flutter/engine#6472)
25b8bbfb2 Roll src/third_party/skia 817c01aecdc4..a41a74ac7994 (1 commits) (flutter/engine#6475)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-09 13:27:20 -04:00
Jason Simmons
3b248fdc11
Add a profile build type to the app template (#22837)
This is required in order to support "flutter run --profile"
2018-10-09 09:45:46 -07:00
engine-flutter-autoroll
3e08c1a5ea
Roll engine bfcdad855729..69e9eb1cd1ce (2 commits) (#22852)
bfcdad8557...69e9eb1cd1

git log bfcdad855729..69e9eb1cd1ce --no-merges --oneline
69e9eb1cd Roll src/third_party/skia 9b7bfd09106f..817c01aecdc4 (1 commits) (flutter/engine#6474)
c048bec5d Roll Dart to e4840ec239249ddc6b588fabfca57df2307e0634 (flutter/engine#6466)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-09 12:29:20 -04:00
engine-flutter-autoroll
e4111b804b
Roll engine 7ecc879ffd9a..bfcdad855729 (1 commits) (#22839)
7ecc879ffd...bfcdad8557

git log 7ecc879ffd9a..bfcdad855729 --no-merges --oneline
bfcdad855 Roll src/third_party/skia 00de965d0d31..9b7bfd09106f (11 commits) (flutter/engine#6471)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-08 23:27:20 -04:00
Greg Spencer
c81f4c71a2
Have runAsyncChecked throw a ProcessException instead of a String. (#22710) 2018-10-08 19:11:31 -07:00
engine-flutter-autoroll
052779d404
Roll engine 88facf405434..7ecc879ffd9a (1 commits) (#22835)
88facf4054...7ecc879ffd

git log 88facf405434..7ecc879ffd9a --no-merges --oneline
7ecc879ff Fix failing test on Cirrus (flutter/engine#6469)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-08 22:02:20 -04:00
engine-flutter-autoroll
6eac2d126c
Roll engine 572fa5646af7..88facf405434 (12 commits) (#22829)
572fa5646a...88facf4054

git log 572fa5646af7..88facf405434 --no-merges --oneline
88facf405 Roll src/third_party/skia 8ad991da4c04..00de965d0d31 (6 commits) (flutter/engine#6467)
647302a28 Correct issues in visible children determination (flutter/engine#6455)
0052733e5 Roll src/third_party/skia 95320ee01f5b..8ad991da4c04 (1 commits) (flutter/engine#6465)
7decce221 Roll src/third_party/skia 9aa3f9095622..95320ee01f5b (1 commits) (flutter/engine#6463)
2667780b9 Roll src/third_party/skia beb1559bc61f..9aa3f9095622 (1 commits) (flutter/engine#6462)
5d28dce5e Roll src/third_party/skia e9b61ef5aa34..beb1559bc61f (1 commits) (flutter/engine#6460)
54b709d3a Roll src/third_party/skia 71143d6cc039..e9b61ef5aa34 (1 commits) (flutter/engine#6459)
9fc5013eb Roll src/third_party/skia 623d2e4120c2..71143d6cc039 (1 commits) (flutter/engine#6458)
841454c8d Roll src/third_party/skia 29b11d605f25..623d2e4120c2 (1 commits) (flutter/engine#6457)
5331df8e4 Roll src/third_party/skia d037f4d204c2..29b11d605f25 (1 commits) (flutter/engine#6456)
6d4de7fc8 Roll src/third_party/skia 51c89e41c05b..d037f4d204c2 (9 commits) (flutter/engine#6454)
ba9b90766 Add `run_tests.sh` to cirrus (flutter/engine#6441)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-08 19:22:20 -04:00
matthew-carroll
4f298e6776
Publish make-host-app-editable command with CLI docs. (#22635)
Publish make-host-app-editable command with CLI docs.
2018-10-08 16:02:13 -07:00
Hans Muller
655bf6a290 Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)
* Update uses of ButtonTheme.bar

* updated gallery themes

* Remove unnecessary const

Fixes #22789
2018-10-08 15:53:35 -07:00
Ian Hickson
874df1ec21
Fix bug in AnimatedSwitcher (#22183)
* Refactor AnimatedSwitcher

This is mostly just a little bit of cleanup with hopefully no semantic
changes, done to teach me how the code works so that I could fix a bug.

* Add debugging information to AnimatedSwitcher

* Fix AnimatedSwitcher to handle the case of back-to-back changes

Previously, if a child was replaced the very next frame after it was
added, we'd get confused because we tried to reverse the controller,
which causes us to remove the child from the going-away list, before
we had added the child to the list in the first place.

The fix is just to move the reverse to after the add.
2018-10-08 14:06:18 -07:00
Yegor
8d643013b1
add AOT smoke tests to Cirrus (#22751) 2018-10-08 12:38:46 -07:00
liyuqian
c689c97d05
Remove mixin so we can roll Google3 (#22819)
We'll roll this back as soon as the Dart analyzer gets upgraded in
Google3.
2018-10-08 11:52:04 -07:00
xster
788bb2d4c2
Add first frame reporting to gallery's Play Store Console logging (#22579) 2018-10-08 11:51:37 -07:00
xster
9c080269a8
Add some missing voiceover labels in gallery (#22753) 2018-10-08 11:51:16 -07:00
MH Johnson
0e7b1adda2
[Typo] it it -> if it (#22743)
* [Typo] it it -> if it
2018-10-08 14:46:55 -04:00
Anthony Bullard
7038c3633b Fix typo in in raw_keyboard.dart (#22757)
Obviously a small change, looks like a little copy-paste accident.
2018-10-08 11:09:18 -07:00
Andrew Davies
9ceb9ab305
[flutter_driver] Adds fuchsia compat for connect() (#22633)
Adds a Fuchsia compatibility function that allows for connecting to a
specific Isolate by name when running Flutter Driver on a Fuchsia
device.  This will check over multiple Dart VM's in an attempt to find
an Isolate by its name.
2018-10-08 11:09:07 -07:00
Hans Muller
bbb080b3a3
Material Switch optionally adapts per platform: Switch.adaptive() (#22688) 2018-10-08 10:39:59 -07:00
jslavitz
d422e85f5b
Large Dropdown Menu Fix (#22594)
* Adds comments clarifying the procedure used to render the menu as well as tests verifying various dropdown menu button positioning and initial scroll states.
2018-10-08 10:39:39 -07:00
Greg Spencer
e0b182e61a
Fix gradle error in devicelab tests (#22814)
Fixes a gradle error where it was failing to find a plugin because of an absolute path in the .flutter-plugins file instead of a relative path.

I had originally removed this variable because I thought it was redundant with the projectDir, but apparently I was wrong about that (one resolves to a relative path, and one resolves to an absolute path).

This PR reverts that part of the change and reintroduces the (not really) redundant variable.
2018-10-08 09:38:37 -07:00
Michael Thomsen
2c063b7ca5
Clean up the examples readme (#22419)
A few changes:

* Remove the search tip (it relies on searching for the new keyword which we no longer use)
* Remove mentioning of examples that are either stale or only used for internal purposes (such as test)
* Cross-link to the samples repo
2018-10-08 08:45:24 +02:00
Greg Spencer
2d81adf74c
Revert "Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)" (#22759)
This reverts commit e438632165818fb06b7c58ea846fe781d9d17642
because it breaks 160 benchmarks, and several devicelab tests,
due to changing the format of the output.
2018-10-05 22:29:37 -07:00
Greg Spencer
e438632165
Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).

Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.

Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.

Since wrapping is now turned on, also removed many redundant '\n's in the code.
2018-10-05 20:00:11 -07:00
Jonah Williams
cdf1cec902
add ability to match child semantics data (#22001) 2018-10-05 17:44:26 -07:00
Greg Spencer
21a32fdd0c
Fixes the project detection logic when creating new projects over existing directories. (#22744)
This all happened because I was trying to be a little too helpful...

Part of the job of the "create" command is to recreate missing pieces of existing projects, and now that the default has changed, I wanted to make it so that if someone had created a default flutter create project before, that they could run a default flutter create there again, and not have it trashed by using the new default template (application) over the old one (app).

This meant I had to detect what type of project it was. Unfortunately, in the past we didn't write anything in the .metadata file to identify the type of project, and since the goal was regenerating missing files, I can't count on anything existing, so it's just a heuristic match.

This simplifies the heuristics down to just detecting the difference between "app" and "application" projects, and only detect the other types if they're explicitly listed in the .metadata file (I changed the code in my original PR to add the project type to the .metadata file). People used to have to specify the type for those anyhow, so it shouldn't be a surprise to users.

So, the main difference in the new heuristics from my last attempt is that if you have a directory that has some other stuff it (like maybe a "plugin" project), then we'll recreate (pronounced "mess up") the project using the "application" template, but that was true before (except it would use the "app" template).

Fixes #22726
2018-10-05 15:49:53 -07:00
Yegor
3184b7cb66
Revert "Use mixin syntax for Flutter's super-mixins (#22435)" (#22748)
This reverts commit 3c56e6c77dc5c351d610d5c2a11d86e8be88519f.

It breaks the AOT build.
2018-10-05 15:09:38 -07:00
Yegor
3c56e6c77d
Use mixin syntax for Flutter's super-mixins (#22435)
* first pass

* revert WidgetsBindingObserver

* disable prefer_mixin

* docs and more mixins

* newer engine; binding fixes

* upgrade dependencies

* fix test binding

* remove whitespace

* remove the obsolete `enableSuperMixins: true`

* upgrade dartdoc to 0.22.0

* temporarily use git version of dartdoc

* fix pub global activate syntax

* use dartdoc 0.23.0
2018-10-05 14:54:41 -07:00
Jason Simmons
9588946365
Do not continue a hot restart if _restartFromSources fails (#22645) 2018-10-05 13:48:41 -07:00
engine-flutter-autoroll
a6c5ec2e08
Roll engine 4eaf9ef4271a..572fa5646af7 (1 commits) (#22741)
4eaf9ef427...572fa5646a

git log 4eaf9ef4271a..572fa5646af7 --no-merges --oneline
572fa5646 Roll src/third_party/skia 032f2756df64..51c89e41c05b (16 commits) (flutter/engine#6453)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-05 16:46:19 -04:00
jslavitz
17c289531d
Updated InputDecorator Comment (#22689)
* updated comment
2018-10-05 13:43:53 -07:00
MH Johnson
ffb48c5ab6
[Documentation] Moved lerp macro definition to painting/ (#22388)
* [Documentation] Moved lerp macro def to painting/
2018-10-05 13:18:21 -07:00
engine-flutter-autoroll
124a636c54
Roll engine 90b1023c84c4..4eaf9ef4271a (5 commits) (#22739)
90b1023c84...4eaf9ef427

git log 90b1023c84c4..4eaf9ef4271a --no-merges --oneline
4eaf9ef42 Roll src/third_party/skia a6262495da48..032f2756df64 (2 commits) (flutter/engine#6450)
c5e52dc31 Roll src/third_party/skia 92d10833de63..a6262495da48 (1 commits) (flutter/engine#6449)
efb24f12b Roll src/third_party/skia 4f87e2255b8a..92d10833de63 (2 commits) (flutter/engine#6448)
28e513613 Roll src/third_party/skia d945698c5dfa..4f87e2255b8a (2 commits) (flutter/engine#6446)
a2ea59f2c Roll src/third_party/skia 4302eb9a6e14..d945698c5dfa (4 commits) (flutter/engine#6445)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-05 15:52:20 -04:00
Andrew Davies
39daab2900
[frdp] Add optional dart isolate filter. (#22590)
* [frdp] Add optional dart isolate filter.

It's now default to filter out non-flutter isolates when searching
across Dart VM's.  This is due to a possible issue wherein an Isolate
for testing might have the same name as the flutter Isolate.

In addition, logging messages have been added in dart_vm.dart for
debugging.
2018-10-05 12:31:05 -07:00
xster
f7e0f83678
Let MaterialApp/CupertinoApp provide default cupertino localization (#22706) 2018-10-05 10:41:09 -07:00
Danny Tuppeny
3ea4b44374
Increase timeout waiting for app to start (#22504)
https://github.com/flutter/flutter/issues/22338#issuecomment-425794734 shows almost 1 minute being spent on the `Resolving Dependencies` step alone. Possibly this needs to go higher still, but this should be a good start.
2018-10-05 17:02:08 +01:00
tonyzhao1
b04447d51c Split Android license checks into their own subvalidator (#22446) 2018-10-05 08:45:16 -07:00
Alexandre Ardhuin
2d3ff10d62
apply lint prefer_void_to_null in packages/flutter_tools (#22686) 2018-10-05 07:54:56 +02:00
Alexandre Ardhuin
c26b56cba3
apply lint prefer_void_to_null in packages/fuchsia_remote_debug_protocol (#22690) 2018-10-05 06:48:20 +02:00
engine-flutter-autoroll
3b8c534576
Roll engine cf0855e69fa8..90b1023c84c4 (2 commits) (#22708)
cf0855e69f...90b1023c84

git log cf0855e69fa8..90b1023c84c4 --no-merges --oneline
90b1023c8 Remove unused imports and variables (flutter/engine#6437)
1f98aa6df Add the isolate name server to the set of native APIs available on secondary isolates (flutter/engine#6444)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-04 23:01:02 -04:00
engine-flutter-autoroll
30222b7bee
Roll engine 45c5fe5613cb..cf0855e69fa8 (2 commits) (#22704)
45c5fe5613...cf0855e69f

git log 45c5fe5613cb..cf0855e69fa8 --no-merges --oneline
cf0855e69 Roll Dart to version  c6254163dc7a5f704d7609af65e4650ef0550ccd (flutter/engine#6439)
2fa1ab9de Roll src/third_party/skia d95303e10cbc..4302eb9a6e14 (12 commits) (flutter/engine#6443)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-04 22:17:01 -04:00
Greg Spencer
407ce13792
Temporarily disabling Docs deployment again. (#22705)
This reverts commit fef759f410ea00fee91aecf44e789ce4ba2c0dcc, because apparently
the service is still "unavailable".
2018-10-04 18:00:23 -07:00
engine-flutter-autoroll
5ae23849cf
Roll engine c8755d74c17e..45c5fe5613cb (2 commits) (#22700)
c8755d74c1...45c5fe5613

git log c8755d74c17e..45c5fe5613cb --no-merges --oneline
45c5fe561 Remove touch mapper and respect the UITouch phase when calculating the pointer data change type. (flutter/engine#6430)
234736801 Roll src/third_party/skia 66a973493468..d95303e10cbc (13 commits) (flutter/engine#6440)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-04 20:41:01 -04:00