firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
42,727 Commits 1 Branch 0 Tags
Commit Graph

42727 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
engine-flutter-autoroll
df62aeffb1
Roll Flutter Engine from 9306456e2532 to 8ec95fe63f2d (1 revision) (#156401) 
9306456e25...8ec95fe63f

2024-10-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 7b965fbaa954 to 85a7e014bea8 (2 revisions) (flutter/engine#55735)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-08 12:44:33 +00:00
engine-flutter-autoroll
51fb753e7f
Roll Flutter Engine from 7e8011f3cc8e to 9306456e2532 (1 revision) (#156398) 
7e8011f3cc...9306456e25

2024-10-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TTSSw-kHM8_h_tdX0... to TlU-It6X_ZLrNqMjW... (flutter/engine#55733)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from TTSSw-kHM8_h to TlU-It6X_ZLr

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-08 11:06:25 +00:00
Daco Harkes
e695cd6e9a
Migrator for android 35/16kb page size cmake flags for plugin_ffi (#156221) 
Migrates existing instantions of `--template plugin_ffi` to deal with Android 15 16kb memory pages.

Issue:

* https://github.com/flutter/flutter/issues/155933

@reidbaker I could only find migrations that run from the root application. However the file needing to be migrated is a plugin. The plugin is being referenced from the example in the example dir and that's where the migrator is run, so I wrote the code so that it walks up to find the plugin. Do you know of a way to run migrators to non-root projects? (Can we even safely do so, e.g. the non-root could be in the pub cache, could be a different project on the users' system etc. So maybe checking if we are in the examples dir is the only sane thing to do?)

Tests:

* Added unit tests in `test/general.shard/android/migrations/cmake_android_16k_pages_migration_test.dart`
 2024-10-08 08:41:09 +00:00
engine-flutter-autoroll
d768a72b85
Roll Flutter Engine from 33c1a6a16e81 to 7e8011f3cc8e (5 revisions) (#156392) 
33c1a6a16e...7e8011f3cc

2024-10-08 skia-flutter-autoroll@skia.org Roll Skia from 3866c52c4aa0 to d639ed5e570a (4 revisions) (flutter/engine#55732)
2024-10-08 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from ckCnIfKM2nOtYiVvK... to jCde9sMKJ3YAdG2DH... (flutter/engine#55731)
2024-10-08 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.8.4 to 1.9.0 (flutter/engine#55730)
2024-10-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.6 to 4.4.1 (flutter/engine#55728)
2024-10-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.2.0 to 4.2.1 (flutter/engine#55729)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-08 08:21:25 +00:00
Taha Tesser
44f7c6913f
Update flexible_space_bar_test.dart tests for Material 3 (#156226) 
Updated unit tests for `FlexibleSpaceBar` to have M2 and M3 versions.

More info in #139076
 2024-10-08 07:42:08 +00:00
engine-flutter-autoroll
e5cbed969c
Roll Flutter Engine from 012029ee19f3 to 33c1a6a16e81 (1 revision) (#156390) 
012029ee19...33c1a6a16e

2024-10-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 3c4726445ba5 to 7b965fbaa954 (1 revision) (flutter/engine#55726)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-08 07:22:39 +00:00
engine-flutter-autoroll
a6f3a1b8b4
Roll Flutter Engine from 5923a8b3e632 to 012029ee19f3 (1 revision) (#156388) 
5923a8b3e6...012029ee19

2024-10-08 skia-flutter-autoroll@skia.org Roll Skia from d0e49fde3765 to 3866c52c4aa0 (3 revisions) (flutter/engine#55723)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-08 06:15:14 +00:00
engine-flutter-autoroll
bd718ef93b
Roll Flutter Engine from fd1ccdb95e03 to 5923a8b3e632 (1 revision) (#156386) 
fd1ccdb95e...5923a8b3e6

2024-10-08 liama@google.com Delete DartIsolateTest.PlatformIsolateSendAndReceive (flutter/engine#55722)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-08 05:12:58 +00:00
engine-flutter-autoroll
9f7ac41292
Roll Flutter Engine from 07c702f2d79b to fd1ccdb95e03 (1 revision) (#156384) 
07c702f2d7...fd1ccdb95e

2024-10-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 94ae91747a0b to 3c4726445ba5 (1 revision) (flutter/engine#55718)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-08 03:07:26 +00:00
engine-flutter-autoroll
42aa02f4e3
Roll Flutter Engine from e096ddb3091e to 07c702f2d79b (2 revisions) (#156379) 
e096ddb309...07c702f2d7

2024-10-08 ditman@gmail.com [web] Warn users when picking a deprecated renderer. (flutter/engine#55709)
2024-10-08 jacksongardner@google.com Revert "Reland [skwasm] Scene builder optimizations for platform view placement (#55468)" (flutter/engine#55715)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-08 01:44:35 +00:00
David Iglesias
d744da18e5
[tool] Emit a deprecation warning for some values of --web-renderer. (#156376) 
This PR emits a blue warning text when using `flutter ... --web-renderer=html|auto`.

(The message is similar to the one that we emit at run-time)

## Issues

Fixes https://github.com/flutter/flutter/issues/154878
See also: https://github.com/flutter/engine/pull/55709
 2024-10-08 01:39:06 +00:00
engine-flutter-autoroll
4c3cd70e33
Roll Flutter Engine from 427302eafdda to e096ddb3091e (2 revisions) (#156372) 
427302eafd...e096ddb309

2024-10-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 902494bb4c8b to 94ae91747a0b (1 revision) (flutter/engine#55712)
2024-10-07 skia-flutter-autoroll@skia.org Roll Skia from 6afbd6253e66 to d0e49fde3765 (4 revisions) (flutter/engine#55710)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-08 00:08:19 +00:00
engine-flutter-autoroll
de33550ff0
Roll Flutter Engine from e84e30357ccc to 427302eafdda (3 revisions) (#156364) 
e84e30357c...427302eafd

2024-10-07 30870216+gaaclarke@users.noreply.github.com Speculative fix for memory issues related to retrying image decompression (flutter/engine#55704)
2024-10-07 jonahwilliams@google.com [Impeller] disable surface control on API 29. (flutter/engine#55708)
2024-10-07 jonahwilliams@google.com [Impeller] remove Vulkan command encoder abstraction, use command buffer vk. (flutter/engine#55680)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 22:25:22 +00:00
dependabot[bot]
99d04cf862
Bump actions/checkout from 4.2.0 to 4.2.1 (#156366) 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.0 to 4.2.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.2.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Check out other refs/* by commit if provided, fall back to ref by <a href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1924">actions/checkout#1924</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Jcambass"><code>@​Jcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1919">actions/checkout#1919</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.2.0...v4.2.1">https://github.com/actions/checkout/compare/v4.2.0...v4.2.1</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.2.1</h2>
<ul>
<li>Check out other refs/* by commit if provided, fall back to ref by <a href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1924">actions/checkout#1924</a></li>
</ul>
<h2>v4.2.0</h2>
<ul>
<li>Add Ref and Commit outputs by <a href="https://github.com/lucacome"><code>@​lucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li>
<li>Dependency updates by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>- <a href="https://redirect.github.com/actions/checkout/pull/1777">actions/checkout#1777</a>, <a href="https://redirect.github.com/actions/checkout/pull/1872">actions/checkout#1872</a></li>
</ul>
<h2>v4.1.7</h2>
<ul>
<li>Bump the minor-npm-dependencies group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1739">actions/checkout#1739</a></li>
<li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1697">actions/checkout#1697</a></li>
<li>Check out other refs/* by commit by <a href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1774">actions/checkout#1774</a></li>
<li>Pin actions/checkout's own workflows to a known, good, stable version. by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1776">actions/checkout#1776</a></li>
</ul>
<h2>v4.1.6</h2>
<ul>
<li>Check platform to set archive extension appropriately by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1732">actions/checkout#1732</a></li>
</ul>
<h2>v4.1.5</h2>
<ul>
<li>Update NPM dependencies by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703">actions/checkout#1703</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694">actions/checkout#1694</a></li>
<li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696">actions/checkout#1696</a></li>
<li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695">actions/checkout#1695</a></li>
<li>README: Suggest <code>user.email</code> to be <code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1707">actions/checkout#1707</a></li>
</ul>
<h2>v4.1.4</h2>
<ul>
<li>Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1692">actions/checkout#1692</a></li>
<li>Add dependabot config by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1688">actions/checkout#1688</a></li>
<li>Bump the minor-actions-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1693">actions/checkout#1693</a></li>
<li>Bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1643">actions/checkout#1643</a></li>
</ul>
<h2>v4.1.3</h2>
<ul>
<li>Check git version before attempting to disable <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1656">actions/checkout#1656</a></li>
<li>Add SSH user parameter by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1685">actions/checkout#1685</a></li>
<li>Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1650">actions/checkout#1650</a></li>
</ul>
<h2>v4.1.2</h2>
<ul>
<li>Fix: Disable sparse checkout whenever <code>sparse-checkout</code> option is not present <a href="https://github.com/dscho"><code>@​dscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1598">actions/checkout#1598</a></li>
</ul>
<h2>v4.1.1</h2>
<ul>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe"><code>@​peterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514">actions/checkout#1514</a></li>
</ul>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436">Update to node20</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="eef61447b9"><code>eef6144</code></a> Prepare 4.2.1 release (<a href="https://redirect.github.com/actions/checkout/issues/1925">#1925</a>)</li>
<li><a href="6b42224f41"><code>6b42224</code></a> Add workflow file for publishing releases to immutable action package (<a href="https://redirect.github.com/actions/checkout/issues/1919">#1919</a>)</li>
<li><a href="de5a000abf"><code>de5a000</code></a> Check out other refs/* by commit if provided, fall back to ref (<a href="https://redirect.github.com/actions/checkout/issues/1924">#1924</a>)</li>
<li>See full diff in <a href="d632683dd7...eef61447b9">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.2.0&new-version=4.2.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-10-07 22:09:36 +00:00
Loïc Sharma
ecf3d6c39a
Clarify when override: no versioning needed label should be applied (#156342) 
Follow-up to https://github.com/flutter/packages/pull/7796

Part of https://github.com/flutter/flutter/issues/156259
 2024-10-07 21:09:19 +00:00
engine-flutter-autoroll
504281c9e2
Roll Flutter Engine from 0c9d3f11f098 to e84e30357ccc (3 revisions) (#156356) 
0c9d3f11f0...e84e30357c

2024-10-07 jonahwilliams@google.com [Impeller] add parsing of known GPU models (flutter/engine#55196)
2024-10-07 jmccandless@google.com Path clarification in Setting-up-the-Engine-development-environment.md (flutter/engine#55529)
2024-10-07 skia-flutter-autoroll@skia.org Roll Skia from 89284b1d7eeb to 6afbd6253e66 (2 revisions) (flutter/engine#55702)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 21:03:27 +00:00
Mairramer
56a33efd73
Fixes an issue where onTapOutside was incorrectly triggered across routes in TapRegion (#155297) 
Fixes https://github.com/flutter/flutter/issues/153093

This PR fixes the issue of onTapOutside being triggered on other routes incorrectly.
 2024-10-07 20:48:00 +00:00
Nate Biggs
da71e6e93d
Update 'dump-info' usage for dart2js builds (#156187) 
Dart2js updated its CLI to support generating a 'dump-info' json file by passing a "--stage" option. The "dump-info-all" stage performs a full compilation (from the provided dill) and then also generates the dump info file.

Tested via the `flutter-dev` CLI locally. This results in the same output but with the addition of an extra `main.dart.js.info.json` file.
 2024-10-07 20:06:18 +00:00
engine-flutter-autoroll
86ce72d46d
Roll Flutter Engine from ffacad996f1f to 0c9d3f11f098 (2 revisions) (#156347) 
ffacad996f...0c9d3f11f0

2024-10-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e6945a72200 to 902494bb4c8b (1 revision) (flutter/engine#55700)
2024-10-07 chris@bracken.jp Revert "iOS: Migrate FlutterEngine to ARC (#55590)" (flutter/engine#55699)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 18:49:48 +00:00
Andrew Kolos
e96c47f953
handle any RPCError due to vm service disconnection in flutter run (#156346) 
Follow-up to https://github.com/flutter/flutter/pull/153714. While reading through run.dart, I noticed we missed a case.
 2024-10-07 18:48:22 +00:00
engine-flutter-autoroll
9583cc1267
Roll Flutter Engine from 683a14c1f1be to ffacad996f1f (1 revision) (#156339) 
683a14c1f1...ffacad996f

2024-10-07 codefu@google.com La Grande Fusion Notes - History Editing (flutter/engine#55667)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 17:52:32 +00:00
engine-flutter-autoroll
989c14d112
Roll Flutter Engine from 8e46a7670b94 to 683a14c1f1be (1 revision) (#156323) 
8e46a7670b...683a14c1f1

2024-10-07 skia-flutter-autoroll@skia.org Roll Skia from 52155a48ff8d to 89284b1d7eeb (3 revisions) (flutter/engine#55697)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 16:02:12 +00:00
engine-flutter-autoroll
a27afa04a0
Roll Packages from 05bf1d482dd9 to bb00d34a4280 (8 revisions) (#156322) 
05bf1d482d...bb00d34a42

2024-10-07 stuartmorgan@google.com [google_sign_in] Update Pigeon for non-nullable generics (flutter/packages#7785)
2024-10-07 stuartmorgan@google.com [path_provider] Update Android Pigeon for non-nullable generics  (flutter/packages#7783)
2024-10-07 victoreronmosele@gmail.com [rfw] Increase tolerance for material widget tests (flutter/packages#7148)
2024-10-05 stuartmorgan@google.com [various] Update Java compatibility version to 11 (flutter/packages#7795)
2024-10-04 stuartmorgan@google.com [video_player] Update Pigeon for non-nullable generics (flutter/packages#7790)
2024-10-04 tobias@leafnode.se [go_router] Added missing implementation for the routerNeglect parameter in GoRouter (flutter/packages#7752)
2024-10-04 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_platform_interface] Convert `BitmapDescriptor` to typesafe subclasses (flutter/packages#7699)
2024-10-04 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_platform_interface] Convert `PatternItem` and `Cap` to typesafe structures. (flutter/packages#7703)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 15:51:20 +00:00
Taha Tesser
b3de00ad54
Fix DropdownMenu with expandedInsets always aligned on top (#156214) 
Fixes [DropdownMenu can not be center aligned when using expandedInsets
](https://github.com/flutter/flutter/issues/155581)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    final List<DropdownMenuEntry<ShortMenu>> shortMenuItems =
        <DropdownMenuEntry<ShortMenu>>[];
    for (final ShortMenu value in ShortMenu.values) {
      final DropdownMenuEntry<ShortMenu> entry =
          DropdownMenuEntry<ShortMenu>(value: value, label: value.label);
      shortMenuItems.add(entry);
    }

    return MaterialApp(
      home: Scaffold(
        body: Row(
          children: <Widget>[
            Expanded(
              child: Center(
                child: DropdownMenu<ShortMenu>(
                  expandedInsets: const EdgeInsets.all(16),
                  initialSelection: ShortMenu.item0,
                  dropdownMenuEntries: shortMenuItems,
                  label: const Text('With expandedInsets'),
                ),
              ),
            ),
            Expanded(
              child: Center(
                child: DropdownMenu<ShortMenu>(
                  initialSelection: ShortMenu.item0,
                  dropdownMenuEntries: shortMenuItems,
                  label: const Text('Without expandedInsets'),
                ),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

enum ShortMenu {
  item0('Menu 0'),
  item1('Menu 1'),
  item2('Menu 2');

  const ShortMenu(this.label);
  final String label;
}
```

</details>

### Before 
(`DropdownMenu` without `expandedInsets` cannot be centered)
<img width="770" alt="Screenshot 2024-10-04 at 14 13 58" src="https://github.com/user-attachments/assets/c7520c12-d16a-4867-8fae-38b75dbc4225">

### After
(`DropdownMenu` with `expandedInsets` be centered)

<img width="770" alt="Screenshot 2024-10-04 at 14 13 49" src="https://github.com/user-attachments/assets/82e0b81e-5c85-4e59-99b8-df329459773b">
 2024-10-07 13:43:22 +00:00
engine-flutter-autoroll
ef4807b4cd
Roll Flutter Engine from a190ab54ce07 to 8e46a7670b94 (2 revisions) (#156311) 
a190ab54ce...8e46a7670b

2024-10-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from h5VOYlPZ-2eCtUR_z... to TTSSw-kHM8_h_tdX0... (flutter/engine#55692)
2024-10-07 skia-flutter-autoroll@skia.org Roll Skia from c3ff0dfeae73 to 52155a48ff8d (1 revision) (flutter/engine#55688)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from h5VOYlPZ-2eC to TTSSw-kHM8_h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 09:22:24 +00:00
engine-flutter-autoroll
8d19012346
Roll Flutter Engine from 2c25423ea618 to a190ab54ce07 (1 revision) (#156301) 
2c25423ea6...a190ab54ce

2024-10-06 skia-flutter-autoroll@skia.org Roll Skia from 6696c34a6816 to c3ff0dfeae73 (1 revision) (flutter/engine#55683)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 01:37:34 +00:00
Jatin Nagar
bae7971431
CheckboxListTile: add property to scale the checkbox (#154806) 
Added a property in the CheckboxListTile to scale the underlying Checkbox using `Transform.scale`.

Fixes: #81334
 2024-10-06 14:49:20 +00:00
engine-flutter-autoroll
672eebc55b
Roll Flutter Engine from ee9e0612b970 to 2c25423ea618 (1 revision) (#156286) 
ee9e0612b9...2c25423ea6

2024-10-06 skia-flutter-autoroll@skia.org Roll Skia from 702044e777a3 to 6696c34a6816 (1 revision) (flutter/engine#55681)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-06 04:29:30 +00:00
engine-flutter-autoroll
a890ffc852
Roll Flutter Engine from 01de9dcf6bbf to ee9e0612b970 (1 revision) (#156283) 
01de9dcf6b...ee9e0612b9

2024-10-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Izy4D5DB98t46Zoh9... to h5VOYlPZ-2eCtUR_z... (flutter/engine#55678)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Izy4D5DB98t4 to h5VOYlPZ-2eC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-05 23:43:31 +00:00
engine-flutter-autoroll
0917e9dfdc
Roll Flutter Engine from 2068577e510b to 01de9dcf6bbf (1 revision) (#156274) 
2068577e51...01de9dcf6b

2024-10-05 skia-flutter-autoroll@skia.org Roll Skia from 9145d1ef9638 to 702044e777a3 (1 revision) (flutter/engine#55675)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-05 14:29:23 +00:00
engine-flutter-autoroll
1c1003681c
Roll Flutter Engine from 6d6bc39fe8b1 to 2068577e510b (1 revision) (#156267) 
6d6bc39fe8...2068577e51

2024-10-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 9aa80e32947d to 5e6945a72200 (1 revision) (flutter/engine#55674)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-05 09:12:21 +00:00
engine-flutter-autoroll
3ae9063f68
Roll Flutter Engine from 92b5b318190b to 6d6bc39fe8b1 (4 revisions) (#156266) 
92b5b31819...6d6bc39fe8

2024-10-05 flar@google.com Honor blur tile mode in BackdropFilter widget on Skia backend (flutter/engine#55640)
2024-10-05 jonahwilliams@google.com [Impeller] remove aiks color_filter and image_filter types. (flutter/engine#55654)
2024-10-05 skia-flutter-autoroll@skia.org Roll Dart SDK from c1c971fd1b94 to 9aa80e32947d (1 revision) (flutter/engine#55673)
2024-10-05 bdero@google.com [Flutter GPU] Add WindingOrder. (flutter/engine#55413)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-05 06:32:20 +00:00
engine-flutter-autoroll
572b1d7b08
Roll Flutter Engine from fd6082ab6693 to 92b5b318190b (1 revision) (#156261) 
fd6082ab66...92b5b31819

2024-10-05 jonahwilliams@google.com [Impeller] remove usage of MaxBasisLength in favor of XY variant. (flutter/engine#55670)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-05 02:04:06 +00:00
engine-flutter-autoroll
6aea099475
Roll Flutter Engine from bc5f9fc80b06 to fd6082ab6693 (4 revisions) (#156258) 
bc5f9fc80b...fd6082ab66

2024-10-04 skia-flutter-autoroll@skia.org Roll Dart SDK from ecba03620fc8 to c1c971fd1b94 (2 revisions) (flutter/engine#55668)
2024-10-04 john@johnmccutchan.com Add --rbe-force-local flag to force rbe task execution to happen on the local machine (flutter/engine#55635)
2024-10-04 skia-flutter-autoroll@skia.org Roll Skia from 4aff9603622d to 9145d1ef9638 (2 revisions) (flutter/engine#55665)
2024-10-04 matanlurey@users.noreply.github.com Add support for `et test //flutter/path/to/dart_test` (flutter/engine#55638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-05 00:02:41 +00:00
engine-flutter-autoroll
cbe72af9e6
Roll Flutter Engine from eece6c3ec63a to bc5f9fc80b06 (2 revisions) (#156252) 
eece6c3ec6...bc5f9fc80b

2024-10-04 flar@google.com [Impeller] Use a squircle-sdf-based algorithm for fast blurs (flutter/engine#55604)
2024-10-04 skia-flutter-autoroll@skia.org Roll Skia from 59f512b47cc0 to 4aff9603622d (1 revision) (flutter/engine#55663)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 22:53:41 +00:00
flutter-pub-roller-bot
d6725e7c01
Roll pub packages (#156254) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2024-10-04 22:47:16 +00:00
engine-flutter-autoroll
4c9174f46d
Roll Flutter Engine from 9fa363bdde20 to eece6c3ec63a (1 revision) (#156250) 
9fa363bdde...eece6c3ec6

2024-10-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TnSpLq0S9XT2rHGl1... to Izy4D5DB98t46Zoh9... (flutter/engine#55662)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from TnSpLq0S9XT2 to Izy4D5DB98t4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 21:13:24 +00:00
engine-flutter-autoroll
7e4a7dab75
Roll Flutter Engine from d38f5e560a98 to 9fa363bdde20 (1 revision) (#156249) 
d38f5e560a...9fa363bdde

2024-10-04 skia-flutter-autoroll@skia.org Roll Skia from e8e0a8c46345 to 59f512b47cc0 (3 revisions) (flutter/engine#55660)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 20:18:07 +00:00
Andrew Kolos
514cf62d03
remove bringup from Windows tool_integration_tests_* (#156179) 
Follow up to
* https://github.com/flutter/flutter/pull/156121

Removes bringup status from these tasks.
 2024-10-04 19:49:14 +00:00
engine-flutter-autoroll
04d082b180
Roll Flutter Engine from 205484009711 to d38f5e560a98 (4 revisions) (#156239) 
2054840097...d38f5e560a

2024-10-04 jonahwilliams@google.com [Impeller] generate mipmaps for toImage. (flutter/engine#55655)
2024-10-04 chris@bracken.jp iOS: Migrate FlutterEngine to ARC (flutter/engine#55590)
2024-10-04 skia-flutter-autoroll@skia.org Roll Skia from 0dfa080b5d71 to e8e0a8c46345 (1 revision) (flutter/engine#55652)
2024-10-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 750b6e44b765 to ecba03620fc8 (1 revision) (flutter/engine#55650)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 19:12:56 +00:00
Qun Cheng
534adfbe02
Normalize ThemeData.cardTheme (#153254) 
Following https://github.com/flutter/flutter/pull/151914, this PR is to normalize `ThemeData.cardTheme`; change the `CardTheme cardTheme` property to `CardThemeData cardTheme` in `ThemeData`. In `ThemeData()` and `ThemeData.copyWith()`, the `cardTheme` parameter type is changed to `Object?` to accept both `CardTheme` and `CardThemeData` so that we won't cause immediate breaking change and make sure rolling is smooth. Once all component themes are normalized, these `Object?` types should be changed to `xxxThemeData`.

There's no way to create a dart fix because we can't add a "@deprecated" label for `CardTheme` because `CardTheme` is a new InheritedWidget subclass now.

Addresses the "theme normalization" sub project within https://github.com/flutter/flutter/issues/91772
 2024-10-04 18:59:05 +00:00
engine-flutter-autoroll
85abc1a3a4
Roll Packages from 429650f681c0 to 05bf1d482dd9 (5 revisions) (#156225) 
429650f681...05bf1d482d

2024-10-04 stuartmorgan@google.com [various] Update Swift plugins for non-nullable generics (flutter/packages#7742)
2024-10-04 stuartmorgan@google.com [url_launcher] Update Android Pigeon (flutter/packages#7744)
2024-10-04 22963120+Craftplacer@users.noreply.github.com [xdg_directories] Add `stateHome` property (flutter/packages#7766)
2024-10-03 stuartmorgan@google.com [file_selector] Update Android Pigeon for non-nullable generics (flutter/packages#7781)
2024-10-03 cedvandenbosch@gmail.com [go_router] Relax subroute path requirements (allow root and child routes to have the same path forms ) (flutter/packages#7647)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 15:40:23 +00:00
engine-flutter-autoroll
195f81e025
Roll Flutter Engine from e0109f0fd5b2 to 205484009711 (1 revision) (#156216) 
e0109f0fd5...2054840097

2024-10-04 skia-flutter-autoroll@skia.org Roll Dart SDK from b96383c6bddd to 750b6e44b765 (3 revisions) (flutter/engine#55649)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 12:07:38 +00:00
flutter-pub-roller-bot
1371d9d916
Roll pub packages (#156215) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2024-10-04 11:59:31 +00:00
engine-flutter-autoroll
e6e5ceda95
Roll Flutter Engine from c2a9fb051bd0 to e0109f0fd5b2 (1 revision) (#156213) 
c2a9fb051b...e0109f0fd5

2024-10-04 skia-flutter-autoroll@skia.org Roll Skia from cef6e8423365 to 0dfa080b5d71 (4 revisions) (flutter/engine#55648)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 11:12:23 +00:00
engine-flutter-autoroll
285b9b11ec
Roll Flutter Engine from 66d397dff87a to c2a9fb051bd0 (5 revisions) (#156206) 
66d397dff8...c2a9fb051b

2024-10-04 skia-flutter-autoroll@skia.org Roll Skia from e732cdf455c8 to cef6e8423365 (1 revision) (flutter/engine#55644)
2024-10-04 jonahwilliams@google.com [Impeller] clamp render target size at max texture size. (flutter/engine#55628)
2024-10-04 skia-flutter-autoroll@skia.org Roll Skia from 379139f0bebe to e732cdf455c8 (11 revisions) (flutter/engine#55642)
2024-10-04 jonahwilliams@google.com [Impeller] remove aiks color_source. (flutter/engine#55603)
2024-10-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 91d39199994c to b96383c6bddd (1 revision) (flutter/engine#55641)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 10:08:19 +00:00
engine-flutter-autoroll
389846308a
Roll Flutter Engine from 20369c5d2b93 to 66d397dff87a (5 revisions) (#156188) 
20369c5d2b...66d397dff8

2024-10-04 matanlurey@users.noreply.github.com Add missing license headers to `engine_tool`. (flutter/engine#55636)
2024-10-03 robert.ancell@canonical.com Refactor FlKeyboardHandler (flutter/engine#55601)
2024-10-03 matanlurey@users.noreply.github.com Add and use a `dart_test` rule. (flutter/engine#55630)
2024-10-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 4c767e0fae21 to 91d39199994c (1 revision) (flutter/engine#55631)
2024-10-03 jonahwilliams@google.com [Impeller] ensure one AiksContext per app. (flutter/engine#55629)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 01:52:22 +00:00
engine-flutter-autoroll
d93dadc24b
Roll Flutter Engine from de1762dbc5cc to 20369c5d2b93 (7 revisions) (#156174) 
de1762dbc5...20369c5d2b

2024-10-03 chinmaygarde@google.com [Impeller] A text layout and shaping API for the standalone library. (flutter/engine#55598)
2024-10-03 matanlurey@users.noreply.github.com Refactor `et run` (and friends). (flutter/engine#55537)
2024-10-03 jason-simmons@users.noreply.github.com [Impeller] Do not cull in TextFrameDispatcher::drawDisplayList if the transform has perspective (flutter/engine#55602)
2024-10-03 chris@bracken.jp iOS: Fix IOSSurfaceNoopTest (flutter/engine#55621)
2024-10-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] one aiks context per app. (#55393)" (flutter/engine#55625)
2024-10-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YKvfbpZ38daiwJ7H0... to TnSpLq0S9XT2rHGl1... (flutter/engine#55622)
2024-10-03 jonahwilliams@google.com [Impeller] one aiks context per app. (flutter/engine#55393)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from YKvfbpZ38dai to TnSpLq0S9XT2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-03 22:17:26 +00:00
Nate Wilson
5bfc3d43ae
Refactor devfs_web_ddc_modules_test.dart (#155609) 
This pull request adds a local function `runInTestbed()` to **devfs_web_ddc_modules_test.dart**, which wraps the `testbed.run()` method. Several whitespace adjustments have been made as well.

<br>

It's much easier to read after clicking "hide whitespace".

<br>

Relevant style guidelines:
- Prefer avoiding line breaks after assignment operators.
- If you have a newline after some opening punctuation, match it on the closing punctuation.
- Only use `=>` when everything, including the function declaration, fits on a single line.
 2024-10-03 21:10:03 +00:00
Tong Mu
59e57437db
Allow arrow keys to navigate MenuAnchor independently of global shortcut definition (#155728) 
This PR adjusts the implementation of handling navigational shortcuts (i.e. arrow keys) on `MenuAnchor` and `DropdownMenu`.

## Motivation
The direct outcome of this PR is to allow keyboard to enter submenus on Web: When the focus is on a `MenuAnchor` while the menu is open, pressing arrow keys should move the focus to the menu item.
* Before the PR, this works for all platforms but Web, a problem described in https://github.com/flutter/flutter/issues/119532#issuecomment-2274705565.

It is caused by the fact that `MenuAnchor` does not wrap itself with a `Shortcuts`, and therefore key events when the focus is on a `MenuAnchor` has been working only because the event falls back to the `Shortcuts` widget defined by `WidgetsApp`, whose default value happens to satisfy `MenuAnchor`'s needs - except on Web where arrow keys are defined to scroll instead of traverse. 

Instead of defining this problem as "just a patch for Web", I think it's better to define it as a problem of all platforms: `MenuAnchor`'s shortcuts should be independent of `WidgetsApp.shortcuts`. Because even if `WidgetsApp.shortcuts` is redefined as something else, people should probably still expect arrow keys to work on `MenuAnchor`.

Therefore this PR makes `MenuAnchor` produce a `Shortcuts` by itself.

### Dropdown menu
The fix above breaks `DropdownMenu`. `DropdownMenu` uses `MenuAnchor`, while defining its own shortcuts because, when filter is enabled:
* The left and right arrow keys need to move the text carets instead
* The up and down arrow keys need to "fake" directional navigation - the focus needs to stay on the text field, while some menu item is highlighted as if it is focused.

Before the PR, `DropdownMenu` defines these shortcuts out of `MenuAnchor`. In order for the `DropdownMenu`'s shortcuts to take priority, these shortcuts are moved to between `MenuAnchor` and the `Textfield`.

A test is added to verify that the left/right keys move text carets.

Below are psuedo-widget-trees after the PR:
```
MenuAnchor
 |- Shortcuts(arrows->DirectionalFocusIntent)
    |- MenuAnchor.child
    |- menu

DropdownMenu
 |- Actions(DirectionalFocusIntent->_dropdownMenuNavigation)
    |- MenuAnchor
        |- Shortcuts(arrows->DirectionalFocusIntent)
            |- Shortcuts(leftright->ExtendSelectionByCharacterIntent, updown->_dropdownMenuArrowIntent)
            |  |- TextField
            |     |- EditableText
            |        |- Actions(DirectionalFocusIntent->DirectionalFocusAction.forTextField)
            |- menu
```

## Known issues
After this PR, traversing the menu still have quite a few problems, which are left for other PRs.
 2024-10-03 20:09:19 +00:00