33513 Commits

Author SHA1 Message Date
Kevin Chisholm
dfe7f841b3
[Conductor] Add documentation to individual files (#121277)
* add documentation to files

* Update dev/conductor/core/lib/src/stdio.dart

Co-authored-by: Christopher Fujino <fujino@google.com>

* Update dev/conductor/core/lib/src/start.dart

Co-authored-by: Christopher Fujino <fujino@google.com>

* Update dev/conductor/core/lib/src/repository.dart

Co-authored-by: Christopher Fujino <fujino@google.com>

* Update dev/conductor/core/lib/src/next.dart

Co-authored-by: Christopher Fujino <fujino@google.com>

* Update dev/conductor/core/lib/src/git.dart

Co-authored-by: Christopher Fujino <fujino@google.com>

* Update dev/conductor/core/lib/src/git.dart

Co-authored-by: Christopher Fujino <fujino@google.com>

* Update stdio.dart

---------

Co-authored-by: Christopher Fujino <fujino@google.com>
2023-02-24 09:44:15 -06:00
Taha Tesser
219ff64574
Reland "Update ExpansionTile to support Material 3 & add an example" (#121212) 2023-02-24 06:30:33 -08:00
engine-flutter-autoroll
cab761d1d3
9f2470213 Roll Skia from e7ed04a6fb12 to aa36fbbd0c1d (3 revisions) (flutter/engine#39846) (#121396) 2023-02-24 12:35:39 +00:00
engine-flutter-autoroll
5db8faecfb
0d5b780b1 Create DlCanvas interface and implement with DisplayListBuilder and SkCanvasAdapter (flutter/engine#39762) (#121390) 2023-02-24 09:09:41 +00:00
engine-flutter-autoroll
306565916c
Manual roll Flutter Engine from 167c97bc3b49 to ba9a895313a9 (3 revisions) (#121388)
* f6af1ac52 Roll Skia from c23446d2da26 to 8fc2ded77979 (1 revision) (flutter/engine#39835)

* 85c66fe32 Roll Fuchsia Mac SDK from OCFfGKefENe8lYAwM... to O8Tsxg5k_mmhxYUTh... (flutter/engine#39837)

* ba9a89531 Roll Skia from 8fc2ded77979 to e7ed04a6fb12 (1 revision) (flutter/engine#39839)
2023-02-24 08:17:10 +00:00
engine-flutter-autoroll
4811269379
Manual roll Flutter Engine from cad5eec1b52c to 167c97bc3b49 (4 revisions) (#121383)
* 6a7ea36c8 Remove surface check when querying ExternalViewEmbedder (flutter/engine#39803)

* 8496df610 Fix referenes in docs (flutter/engine#39828)

* 2f4b81be1 Roll Skia from fff6c987d803 to c23446d2da26 (10 revisions) (flutter/engine#39831)

* 167c97bc3 Revert "Match PlatformConfiguration properties to PlatformDispatcher ones (#39685)" (flutter/engine#39833)
2023-02-23 22:47:48 -08:00
hellohuanlin
1155d2719d
[platform_view]integration test for platform view not tappable issue (#120844)
* [platform_view]integration test for platform view not tappable issue

* nit
2023-02-23 23:38:34 +00:00
engine-flutter-autoroll
56a54d6d10
Roll Flutter Engine from b4b4c15d3a60 to cad5eec1b52c (4 revisions) (#121365)
* 2bc07cac7 Roll Skia from a321a8750271 to 1b2d815e9778 (5 revisions) (flutter/engine#39821)

* 57cbf0858 Roll Skia from 1b2d815e9778 to fff6c987d803 (2 revisions) (flutter/engine#39823)

* 2d2b51d69 Remove obsolete references in ViewConfiguration documentation (flutter/engine#39708)

* cad5eec1b Match PlatformConfiguration properties to PlatformDispatcher ones (flutter/engine#39685)
2023-02-23 23:22:22 +00:00
Hans Muller
1c753635b1
Added identical(a,b) short circuit to painting Library lerp methods (#121346) 2023-02-23 14:23:39 -08:00
Qun Cheng
07b0252da4
Change mouse cursor to be SystemMouseCursors.click when not focusable (#121353)
Co-authored-by: Qun Cheng <quncheng@google.com>
2023-02-23 14:23:11 -08:00
Greg Spencer
b1d8a4e4c7
Modify focus traversal policy search to use focus tree instead of widget tree (#121186)
* Modify focus traversal policy search to use focus tree instead of widget tree

* Eliminate unnecessary inherited widget

* Remove unintentional change

* Look for focus nodes without creating a dependency.

* Add test

* Review Changes

* Fix debug_test.dart

* Rebase onto master
2023-02-23 21:15:54 +00:00
Flutter GitHub Bot
5d36cb77fb
roll packages (#121358) 2023-02-23 20:20:25 +00:00
Lioness100
26b6c1bedd
Fix typos (#121171)
* Fix typos

* lowercase animated & opacity

* Undo typo fix

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
David Neuy
3681b27a47
Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props. (#114338)
* Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props.

* Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props - add tests.

* Fix analysis errors

* Review changes.

* Add asserts for dataRowMinHeight and dataRowMaxHeight

* Add asserts for dataRowMinHeight and dataRowMaxHeight

* Make dataRowHeight a computed getter

* Remove get only dataRowHeight from hashCode...

* Update deprecated after

* Add new line at end of AUTHORS

* Apply suggestions from code review

* Update packages/flutter/test/material/data_table_test.dart

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 19:32:29 +00:00
Greg Price
97938859e0
Fix buggy formula for critically-damped springs (#120488)
Fixes #109675.

This formula would produce an initial velocity quite different
from the one specified as an argument.

To update the test, I computed the expected results separately
by using the physical formula.

Happily, the framework by default never ends up actually exercising
this code.  Of the four SpringDescription call sites within the
framework, two are explicitly overdamped; the other two are by
design critically damped, but due to rounding they end up being
treated as (very slightly) overdamped too.  Details here:
  https://github.com/flutter/flutter/issues/109675#issuecomment-1423674855

So the only way an app could be affected by this bug is if it called
a SpringDescription constructor itself, and managed to create a spring
description where the distinguishing formula in _SpringSolution comes
out exactly equal to zero.  It's likely nobody has ever shipped such
an app, because the behavior this produces would be so wildly wrong
that it'd be hard to miss when exercised.

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 19:29:32 +00:00
Flutter GitHub Bot
8080becadf
roll packages (#120951) 2023-02-23 19:21:53 +00:00
Flutter GitHub Bot
5dc569f148
Marks Linux run_debug_test_linux to be unflaky (#121237)
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-02-23 19:11:17 +00:00
engine-flutter-autoroll
c722ce419a
Roll Flutter Engine from 19cf8e363f78 to b4b4c15d3a60 (2 revisions) (#121341)
* e7d34e1e8 Roll Skia from 69f83e81ef3f to a321a8750271 (2 revisions) (flutter/engine#39819)

* b4b4c15d3 Roll Fuchsia Mac SDK from xFmgbl9L7nOoL8W-w... to OCFfGKefENe8lYAwM... (flutter/engine#39820)
2023-02-23 17:44:30 +00:00
chunhtai
660992a161
Fix text.rich to merge widget span (#113461)
* Fix text.rich to merge widget span

* migrate to new API

* update

* addressing comment

* addressing comments

* update

* addressing comment

* Update
2023-02-23 17:38:52 +00:00
Taha Tesser
56e1bddc59
Fix SliverAppBar.medium & SliverAppBar.large title overlap with leading/actions widgets, leading width, and title spacing (#120780)
* Fix `SliverAppBar.medium` & `SliverAppBar.large` title overlap with leading/actions widgets, leading width, and title spacing

* Add `titleSpacing` theme tests and consolidate multiple tests for the same widgets
2023-02-23 17:12:11 +00:00
engine-flutter-autoroll
af347d6677
19cf8e363 [web] Copy everything under the local canvaskit folder (flutter/engine#39799) (#121338) 2023-02-23 16:48:20 +00:00
engine-flutter-autoroll
19b2aa14c0
c87028288 Roll Fuchsia Linux SDK from 0RfFdaUCok_sFfUN1... to 69m3Jn73L34XwlsWH... (flutter/engine#39761) (#121332) 2023-02-23 14:03:39 +00:00
Eilidh Southren
0c1ed75915
Remove newline (#121090)
* remove newline

* update crswap

* add const constructor

* update const
2023-02-23 10:39:41 +00:00
engine-flutter-autoroll
0f69bc7b78
Roll Flutter Engine from 34794638c8b8 to d4bae2887e24 (2 revisions) (#121320)
* 952a89b4b [Impeller] Wire up a playground that can run Dart (flutter/engine#39805)

* d4bae2887 [Impeller] Add PolygonMode to render layer (flutter/engine#39810)
2023-02-23 10:03:28 +00:00
Bruno Leroux
046d907f53
Fix TextSelectionGestureDetectorBuilder wrong cause for onDoubleTapDown (#121093)
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2023-02-23 09:24:17 +00:00
engine-flutter-autoroll
114d93f832
34794638c Roll Skia from 149bb820e0c3 to 69f83e81ef3f (2 revisions) (flutter/engine#39815) (#121316) 2023-02-23 08:51:08 +00:00
engine-flutter-autoroll
02d5f2f648
b0248b199 Roll Skia from 29fc6cac02f5 to 149bb820e0c3 (1 revision) (flutter/engine#39813) (#121313) 2023-02-23 08:01:11 +00:00
engine-flutter-autoroll
7d0aa9eea9
74eb9be55 Roll Skia from fa36bb160826 to 29fc6cac02f5 (3 revisions) (flutter/engine#39812) (#121308) 2023-02-23 07:15:09 +00:00
engine-flutter-autoroll
3115993117
Roll Flutter Engine from c4577135b5b9 to 26971ae36c31 (2 revisions) (#121305)
* 41d6f3bb7 Roll Skia from f163f6ed5db0 to fa36bb160826 (2 revisions) (flutter/engine#39811)

* 26971ae36 Roll Fuchsia Mac SDK from cGa3bk2BmrHL_waB8... to xFmgbl9L7nOoL8W-w... (flutter/engine#39808)
2023-02-23 05:25:39 +00:00
engine-flutter-autoroll
1ba617a59c
Roll Flutter Engine from 137caa761540 to c4577135b5b9 (4 revisions) (#121303)
* 00f2a3861 Deprecate WindowPadding (flutter/engine#39775)

* 4c6c259ba Roll Skia from 335cabcf8b99 to 080897012390 (4 revisions) (flutter/engine#39802)

* e1c327750 Roll Skia from 080897012390 to f163f6ed5db0 (1 revision) (flutter/engine#39806)

* c4577135b [iOS][Text Input] Avoid crash when its UIViewController.view is nil. (flutter/engine#39768)
2023-02-23 04:33:22 +00:00
Todd Volkert
71c4570932
Add ResizeImage.policy (#121154)
* Add ResizeImage.policy

This adds a new `ResizeImage.policy` property that controls how `ResizeImage`
will interpret its `width` and `height` properties. The existing behavior is
preserved via `ResizeImagePolicy.exact` (default), but there is now the option
to use `ResizeImagePolicy.fit`, which satisfies the use case outlined in
flutter/flutter#118543.

The API doc assets were added in flutter/assets-for-api-docs#209

Fixes flutter/flutter#118543

* Docuemnt public member

* Remove protected annotation from overrides - was failing tests

* Fixed analysis of code in Dartdoc

* More dartdoc code analysis fixes

* One more fix

* Review comments
2023-02-23 03:53:05 +00:00
suragch
9619c33348
Remove obsolete comment (#120265)
* Remove obsolete comment

The method `_stopCursorTimer` no longer exists.

* Add edited comment back in

Addresses these comments:
- https://github.com/flutter/flutter/pull/120265#discussion_r1101673834
- https://github.com/flutter/flutter/pull/120265#discussion_r1102120022

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 02:46:16 +00:00
codiss
156c6614bf
Fix Material3 TabBarTheme.dividerColor not working (#119690)
* Fixed Material3 TabBarTheme.dividerColor not working

* Add 'Material3 - TabBar inherits the dividerColor of TabBarTheme' test

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 02:46:11 +00:00
Michael Goderbauer
4ef1fe4434
Work-around for channels flake (#121261) 2023-02-23 02:46:08 +00:00
Michael Goderbauer
1737233567
Fix typo (#121291) 2023-02-23 02:46:06 +00:00
Greg Spencer
a50bdcfd18
Add getInheritedWidgetOfExactType to BuildContext (#121276)
* Add getInheritedWidgetOfExactType to BuildContext

* Use the new API in all the places

* Fix doc error

* Review Changes
2023-02-23 01:09:51 +00:00
Christopher Fujino
048725981e
remove Christopher Fujino from codeowners of //dev/ci (#121281)
Co-authored-by: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com>
2023-02-23 01:09:48 +00:00
David Skelly
368537b910
Add padding to DropdownButton (#115806)
* add padding param to DropdownButton

* improve padding comment

* update test

* Add more context to documentation

* update padding documentation with more detail

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 01:07:51 +00:00
Tomasz Gucio
f85a75db25
Remove outdated TODO (#121200) 2023-02-23 01:02:52 +00:00
engine-flutter-autoroll
fede6d17e9
Roll Flutter Engine from 3aa112c75ccb to 137caa761540 (20 revisions) (#121286)
* 0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine#39727)

* f0e5c08f7 [platform_view] fix overlapping platform view not touchable (flutter/engine#39527)

* 03b5998b4 Roll Fuchsia Mac SDK from 25mb67G0L_sZ_OQCC... to dj-2XkYHvZUsqlZTc... (flutter/engine#39782)

* 2e5b1bf04 Updated the wide-gamut constant and added a unit test for it. (flutter/engine#39776)

* 1ce93ca0a Roll Dart SDK from 0db7573c6b70 to c9a4fd7fd7fa (1 revision) (flutter/engine#39783)

* 8368fb5b6 Roll Dart SDK from c9a4fd7fd7fa to 5003b952affb (1 revision) (flutter/engine#39787)

* ee5ea205b Roll Dart SDK from 5003b952affb to 6f5df63655ad (1 revision) (flutter/engine#39790)

* d9be356a8 Roll Fuchsia Mac SDK from dj-2XkYHvZUsqlZTc... to cGa3bk2BmrHL_waB8... (flutter/engine#39791)

* 50af61302 [web] Add `dart:js_interop` to BUILD.gn. (flutter/engine#39792)

* eb5e5624d [common] Use FML macro to prevent copy/assignment (flutter/engine#39786)

* 6acfddc78 Add more log when receiving semantics node not part of update (flutter/engine#39777)

* 336e7ce63 Roll Skia from 22b594afb4d3 to 78bad646fe78 (24 revisions) (flutter/engine#39793)

* e65391f8b [Impeller] Add root dockspace to playgrounds (flutter/engine#39789)

* 3848f6429 [Impeller] ensure glyph type contributes to FontGlyphPair hash/eq (flutter/engine#39794)

* cb1ef6f08 Roll Skia from 78bad646fe78 to 335cabcf8b99 (2 revisions) (flutter/engine#39795)

* ac6129db2 made opaque wide gamut images take up 32 bits per pixel (flutter/engine#39691)

* c74a4bc67 save/restore around clipping the (potentially cached) frame canvas (flutter/engine#39797)

* ed3f15d94 [Embedder API] Add CODEOWNERS (flutter/engine#39784)

* 1a3bddcc1 Fix a race in ShellTest.PushBackdropFilterToVisitedPlatformViews (flutter/engine#39798)

* 137caa761 Roll Dart SDK from 6f5df63655ad to 602941be8007 (2 revisions) (flutter/engine#39800)
2023-02-23 00:20:39 +00:00
Casey Hillers
8f7ccd4c41
Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution (#118782)" (#121220)
This reverts commit e3db0488adaf1ca1330c800bef9aa06749d30a7a.
2023-02-23 00:13:33 +00:00
Ricardo Amador
1168c2c8b9
Update jdk in cirrus dockerfile image. (#121251)
* Update jdk in cirrus dockerfile image.

* Update to install jaxb for jdk11. Hopefully this works.

* Add jaxb to classpath

* Classpath was not set in run

* Update to use newer tools

* typo

* Update path to commandline tools.

* Trying different approach

* Wrong path

* Wrong path

* Wrong path

* Wrong path

* Remove debug statements
2023-02-22 15:06:58 -08:00
Casey Hillers
9241426828
Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#119597)" (#119656)
This reverts commit 7ba440655a801e50e1c02117beedeb2923391b6c.
2023-02-22 13:51:03 -08:00
Michael Goderbauer
5ccb4d4b95
Rename WindowPadding to ViewPadding (#121152)
* Rename WindowPadding to ViewPadding

* dart fix

* typos
2023-02-22 21:32:40 +00:00
Mushaheed Syed
7d85a585da
Add ActionButtonIconsData for overriding action icons (#118229)
* Add ActionButtonIconsData for overriding action icons

* Fix formatting issues

* Add missing exports in material library and add copyWith method in ActionButtonIconsData

* Move all action buttons, and icons to action_buttons.dart

* Rename actionButtonIcons to actionIconTheme

* Refactor buttons in action_buttons.dart to extend a private class for common implementation

* Refactor icons in action_buttons

* Fix docs in action_buttons_theme

* Fix #107646 always use 'Icons.arrow_back' as a back_button icon in web

* Update documentation for action buttons and add style parameter to every action button

* Fix analyzer warnings

* Add missing style argument in IconButton of _ActionButton

* Add tests for action buttons, action icon theme, drawer buttons, and back buttons

* Add example (+test) for action icon button's action icon theme in examples/api

* Fix analysis errors

* Add missing license header in action_icon_theme.0.dart

* Fix deprecation notice in theme_data.dart

* Update theme data tests for actionIconTheme

* Remove iconSize parameter from ActionButtons and update docs

* Fix failing tests

* Update button color during backbutton tests to red

* Fix analytics issues

* Fix format
2023-02-22 09:22:44 -08:00
Ricardo Amador
d816e72f07
Do not swallow the error from the licenses acceptance (#121243) 2023-02-22 08:55:08 -08:00
gaaclarke
4c25587b71
Added negative test and blur test to the wide gamut tests. (#120914)
* Added negative test and blur test to the wide gamut tests.

* switched back to dstOver

* fixed blur test

* analysis warnings

* analyzer
2023-02-22 00:10:25 +00:00
suragch
dad9eb21f9
fix spelling typo (#120062)
* fix spelling typo

* _index not nullable

This address the comment here: https://github.com/flutter/flutter/pull/120062#issuecomment-1421424676
2023-02-21 23:16:23 +00:00
Jessica Pereira
aa29358c5e
Fix license page rtl (#120497)
* fix license page rtl

* fix editor spacings, tests to lateral view

* fix defaultSize and setSurfaceSize

* add validation for packageList position

* fix spacing

* simplify align
2023-02-21 21:54:39 +00:00
Kate Lovett
c6e1a4dc9a
Fix formatting (#121167) 2023-02-21 21:34:19 +00:00