firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
35,586 Commits 1 Branch 0 Tags
Commit Graph

35586 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
engine-flutter-autoroll
cef9a8c54b
Roll Flutter Engine from debee7cece49 to 63582320d20e (3 revisions) (#129563) 
debee7cece...63582320d2

2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from 7169dc5fe003 to 764f31be3228 (1 revision) (flutter/engine#43199)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 6d89bc1acb7e to 46dcf29e5dfe (2 revisions) (flutter/engine#43197)
2023-06-26 matej.knopp@gmail.com Implement union and intersection for DlRegion (flutter/engine#42620)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 17:20:48 +00:00
Taha Tesser
c8e42b47f5
Fix AnimatedList & AnimatedGrid doesn't apply MediaQuery padding (#129556) 
fixes [AnimatedList does not take SafeArea into account when building the list ](https://github.com/flutter/flutter/issues/129539)

### Description
This PR fixes an issue for `AnimatedList` & `AnimatedGrid` where `MediaQuery` padding isn't applied. See the [source](a20db068dd/packages/flutter/lib/src/widgets/scroll_view.dart (L803-L833)).

While the  `ListView` or `GridView` applies `MediaQuery` padding to its inner `SliverPadding`.  This is missing from `AnimatedList` & `AnimatedGrid`.

![Digram of ListView applying MediaQuery padding](https://github.com/flutter/flutter/assets/48603081/01917900-cd26-4ca1-8e51-b7dcd1241471)

The fix applies  `MediaQuery` padding to the inner `SliverPadding` in `AnimatedList` & `AnimatedGrid`.

![Digram of AnimatedList & AnimatedGrid applying MediaQuery padding](https://github.com/flutter/flutter/assets/48603081/75d0a0ad-539c-485e-b3c1-770ee187086b)

### Code sample
<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Row(
        children: <Widget>[
          Expanded(
            child: Column(
              children: <Widget>[
                const Text('ListView'),
                Expanded(
                  child: ListView.builder(
                    itemCount: 50,
                    itemBuilder: (_, int index) {
                      return ColoredBox(
                        color: Theme.of(context).colorScheme.primaryContainer,
                        child: Center(
                          child: Text('$index', textAlign: TextAlign.center),
                        ),
                      );
                    },
                  ),
                ),
              ],
            ),
          ),
          const VerticalDivider(width: 4),
          Expanded(
            child: Column(
              children: <Widget>[
                const Text('AnimatedList'),
                Expanded(
                  child: AnimatedList(
                    initialItemCount: 50,
                    itemBuilder: (_, int index, __) {
                      return ColoredBox(
                        color: Theme.of(context).colorScheme.primaryContainer,
                        child: Center(
                          child: Text('$index', textAlign: TextAlign.center),
                        ),
                      );
                    },
                  ),
                ),
              ],
            ),
          ),
          const VerticalDivider(width: 4),
          Expanded(
              child: Column(
            children: <Widget>[
              const Text('AnimatedGrid'),
              Expanded(
                child: AnimatedGrid(
                  initialItemCount: 50,
                  gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(
                    crossAxisCount: 2,
                  ),
                  itemBuilder: (_, int index, __) {
                    return ColoredBox(
                      color: Theme.of(context).colorScheme.primaryContainer,
                      child: Center(
                        child: Text('$index', textAlign: TextAlign.center),
                      ),
                    );
                  },
                ),
              ),
            ],
          ))
        ],
      ),
    );
  }
}

``` 
	
</details>

### Before
![Before preview image](https://github.com/flutter/flutter/assets/48603081/73954a8a-9d1d-4b9e-b6a3-cae8071f3462)

### After
![After preview image](https://github.com/flutter/flutter/assets/48603081/9f1dc48a-622f-4402-8d5e-8e6e3e150165)
 2023-06-26 16:19:02 +00:00
godofredoc
bac0589539
Process only specific labels. (#129475) 
To avoid trying to process all the open bugs in flutter/flutter.
 2023-06-26 16:02:07 +00:00
engine-flutter-autoroll
4871391dda
Roll Packages from d041934b296d to 6b70804799a9 (7 revisions) (#129559) 
d041934b29...6b70804799

2023-06-23 47866232+chunhtai@users.noreply.github.com [go_router] Reduces excessive rebuilds due to inherited look up. (flutter/packages#4227)
2023-06-23 stuartmorgan@google.com [image_picker] Update to 1.0 (flutter/packages#4285)
2023-06-23 stuartmorgan@google.com [tool] Consider comment-only changes to be dev-only (flutter/packages#4279)
2023-06-23 stuartmorgan@google.com [ci] Switch to LUCI for Android build-all (flutter/packages#4274)
2023-06-23 stuartmorgan@google.com [file_selector] Add file group to save return value (flutter/packages#4222)
2023-06-23 47866232+chunhtai@users.noreply.github.com [go_router] Adds onException to GoRouter constructor. (flutter/packages#4216)
2023-06-23 stuartmorgan@google.com [file_selector] Add file group to save return value - implementations (flutter/packages#4273)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 15:48:02 +00:00
Ian Hickson
a20db068dd
Make bug templates more consistent (#129460) 
* remove trailing periods in template titles
* tweak the design doc template a little based on testing it out
 2023-06-26 12:27:27 +00:00
engine-flutter-autoroll
da2b8723fd
Roll Flutter Engine from be46101e952d to debee7cece49 (1 revision) (#129544) 
be46101e95...debee7cece

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 5ea08db08587 to 6d89bc1acb7e (2 revisions) (flutter/engine#43194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 09:20:56 +00:00
engine-flutter-autoroll
fde3906307
Roll Flutter Engine from 88ff46e1efc1 to be46101e952d (2 revisions) (#129540) 
88ff46e1ef...be46101e95

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from a20d58872fbe to 5ea08db08587 (1 revision) (flutter/engine#43193)
2023-06-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from XnZWRj5iNXgOHlVNi... to 3Y8TbEFhQUKOJBLQ4... (flutter/engine#43192)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from XnZWRj5iNXgO to 3Y8TbEFhQUKO

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 07:58:35 +00:00
engine-flutter-autoroll
c7f82a1ca2
Roll Flutter Engine from 317673b3278a to 88ff46e1efc1 (1 revision) (#129534) 
317673b327...88ff46e1ef

2023-06-26 robert.ancell@canonical.com Allow event channels to reuse names (flutter/engine#41837)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 03:44:09 +00:00
engine-flutter-autoroll
8b6e1fdeac
Roll Flutter Engine from 593e1d9a9cf5 to 317673b3278a (3 revisions) (#129531) 
593e1d9a9c...317673b327

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from uh5om9qyypCToIllT... to GkEyRw1Q2qLZWxitD... (flutter/engine#43190)
2023-06-25 skia-flutter-autoroll@skia.org Roll Skia from 7866f2c6ba52 to a20d58872fbe (1 revision) (flutter/engine#43191)
2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from w-DJY4dBZWS7lxsxE... to XnZWRj5iNXgOHlVNi... (flutter/engine#43188)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from w-DJY4dBZWS7 to XnZWRj5iNXgO
  fuchsia/sdk/core/mac-amd64 from uh5om9qyypCT to GkEyRw1Q2qLZ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-26 01:38:21 +00:00
engine-flutter-autoroll
b2e9501317
Roll Flutter Engine from 5178e8ab7764 to 593e1d9a9cf5 (1 revision) (#129514) 
5178e8ab77...593e1d9a9c

2023-06-25 skia-flutter-autoroll@skia.org Roll Skia from 18a947ed2253 to 7866f2c6ba52 (1 revision) (flutter/engine#43187)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-25 15:39:29 +00:00
engine-flutter-autoroll
42d2c2d592
Roll Flutter Engine from 100f6fc854b4 to 5178e8ab7764 (1 revision) (#129508) 
100f6fc854...5178e8ab77

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from N0MQ5J5y_hQoiOYs9... to uh5om9qyypCToIllT... (flutter/engine#43185)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from N0MQ5J5y_hQo to uh5om9qyypCT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-25 10:40:12 +00:00
engine-flutter-autoroll
176f7e6382
Roll Flutter Engine from a9f446e25f0c to 100f6fc854b4 (1 revision) (#129498) 
a9f446e25f...100f6fc854

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bjQLnDu32Oj0KUbrW... to w-DJY4dBZWS7lxsxE... (flutter/engine#43184)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from bjQLnDu32Oj0 to w-DJY4dBZWS7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-25 04:00:25 +00:00
engine-flutter-autoroll
c0f76fc94a
Roll Flutter Engine from 5b1b98305768 to a9f446e25f0c (1 revision) (#129495) 
5b1b983057...a9f446e25f

2023-06-24 bdero@google.com [Impeller] Supply surface cull rect for Vulkan & GLES dispatchers (flutter/engine#43152)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-25 00:37:07 +00:00
engine-flutter-autoroll
c442c6d464
Roll Flutter Engine from 72c902ce3b81 to 5b1b98305768 (2 revisions) (#129493) 
72c902ce3b...5b1b983057

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JF0sJRpJH8KiyyqrR... to N0MQ5J5y_hQoiOYs9... (flutter/engine#43180)
2023-06-24 bdero@google.com [Impeller] Disable blending for Source blend mode (flutter/engine#43162)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JF0sJRpJH8Ki to N0MQ5J5y_hQo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 21:23:11 +00:00
engine-flutter-autoroll
96a9773d1b
Roll Flutter Engine from f2976add9414 to 72c902ce3b81 (1 revision) (#129489) 
f2976add94...72c902ce3b

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 1826cbacd4da to 18a947ed2253 (1 revision) (flutter/engine#43178)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 19:08:12 +00:00
engine-flutter-autoroll
6855b52779
Roll Flutter Engine from 76a5e971dc09 to f2976add9414 (1 revision) (#129487) 
76a5e971dc...f2976add94

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b5PDBUm8Hfx-y9Hsp... to bjQLnDu32Oj0KUbrW... (flutter/engine#43177)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from b5PDBUm8Hfx- to bjQLnDu32Oj0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 17:33:07 +00:00
engine-flutter-autoroll
fd9d13c28a
Roll Flutter Engine from 79fd6beea087 to 76a5e971dc09 (1 revision) (#129483) 
79fd6beea0...76a5e971dc

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 050d2ad6dda3 to 1826cbacd4da (2 revisions) (flutter/engine#43175)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 09:47:25 +00:00
engine-flutter-autoroll
afa4cf7e0e
Roll Flutter Engine from 30ac9107f2f9 to 79fd6beea087 (1 revision) (#129479) 
30ac9107f2...79fd6beea0

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from w-tUP3Ia2kfAaFNW1... to JF0sJRpJH8KiyyqrR... (flutter/engine#43174)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from w-tUP3Ia2kfA to JF0sJRpJH8Ki

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 08:19:14 +00:00
engine-flutter-autoroll
cc76ed95f2
Roll Flutter Engine from ee65380bf3fd to 30ac9107f2f9 (1 revision) (#129476) 
ee65380bf3...30ac9107f2

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from ef64a8c132c4 to 050d2ad6dda3 (2 revisions) (flutter/engine#43171)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 05:47:24 +00:00
engine-flutter-autoroll
a8c6842533
Roll Flutter Engine from 240a86f40781 to ee65380bf3fd (2 revisions) (#129474) 
240a86f407...ee65380bf3

2023-06-24 skia-flutter-autoroll@skia.org Roll ANGLE from f834ba7fdab9 to 7169dc5fe003 (1 revision) (flutter/engine#43169)
2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 3d9732b86456 to ef64a8c132c4 (6 revisions) (flutter/engine#43170)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 04:54:10 +00:00
godofredoc
0f006ea0dd
Fix issues with no response bot. (#129470) 
This is also increasing the number of items to be evaluated on each iteration.
 2023-06-24 04:03:59 +00:00
engine-flutter-autoroll
e058ceb616
Roll Flutter Engine from 5e6dcf959ea0 to 240a86f40781 (1 revision) (#129473) 
5e6dcf959e...240a86f407

2023-06-24 godofredoc@google.com Add docs for magic variables. (flutter/engine#43121)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 04:00:07 +00:00
engine-flutter-autoroll
1d5aeea47f
Roll Flutter Engine from 550bfedc8760 to 5e6dcf959ea0 (1 revision) (#129468) 
550bfedc87...5e6dcf959e

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 8818761fbc84 to 3d9732b86456 (4 revisions) (flutter/engine#43167)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 02:40:55 +00:00
engine-flutter-autoroll
c39bc1d940
Roll Flutter Engine from c1abd1f17ab1 to 550bfedc8760 (3 revisions) (#129466) 
c1abd1f17a...550bfedc87

2023-06-23 bdero@google.com [Impeller] Label present waiter command buffer in SurfaceMTL (flutter/engine#43165)
2023-06-23 tamird@google.com Add tmp storage capability to flutter runner (flutter/engine#43157)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from c53a952a2dab to 8818761fbc84 (5 revisions) (flutter/engine#43164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 01:56:05 +00:00
Brandon DeRosier
b898d1d270
[devicelab] Add platform view scroll benchmarks for Impeller on Android (#129455) 
For tracking perf improvements with changes like
https://github.com/flutter/engine/pull/43152.
 2023-06-23 18:40:17 -07:00
engine-flutter-autoroll
813fc3bbcd
Roll Flutter Engine from eca910dd5e3f to c1abd1f17ab1 (3 revisions) (#129456) 
eca910dd5e...c1abd1f17a

2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 566f1ee4657c to f834ba7fdab9 (1 revision) (flutter/engine#43158)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from d53ea1557b35 to c53a952a2dab (1 revision) (flutter/engine#43156)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VSKvLPB4DCIDvXzOA... to b5PDBUm8Hfx-y9Hsp... (flutter/engine#43155)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from VSKvLPB4DCID to b5PDBUm8Hfx-

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 23:50:59 +00:00
engine-flutter-autoroll
be803a7df7
Roll Flutter Engine from f8a39cb4dc56 to eca910dd5e3f (3 revisions) (#129451) 
f8a39cb4dc...eca910dd5e

2023-06-23 110993981+htoor3@users.noreply.github.com [web] - Fix for Safari partially autofilling form  (flutter/engine#43058)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from bc2d5ed01f27 to 566f1ee4657c (1 revision) (flutter/engine#43154)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 7b6aae68a11f to d53ea1557b35 (1 revision) (flutter/engine#43153)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 22:37:18 +00:00
engine-flutter-autoroll
80f8bf1191
Roll Flutter Engine from 74ef61859bdc to f8a39cb4dc56 (2 revisions) (#129445) 
74ef61859b...f8a39cb4dc

2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 2e285bb591f7 to bc2d5ed01f27 (1 revision) (flutter/engine#43151)
2023-06-23 chinmaygarde@google.com [Impeller] FenceWaiterVK: Move potentially slow calls out of wait set mutex critical section. (flutter/engine#43131)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 21:07:56 +00:00
Loïc Sharma
e1e2ebd176
Add CallbackShortcuts widget of the week video (#129296) 2023-06-23 20:16:28 +00:00
engine-flutter-autoroll
b136f5f951
Roll Flutter Engine from 060cd9c17df3 to 74ef61859bdc (3 revisions) (#129444) 
060cd9c17d...74ef61859b

2023-06-23 godofredoc@google.com Remove master mirroring workflow. (flutter/engine#42681)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 07vKo_Vaiy_Vw2xxb... to w-tUP3Ia2kfAaFNW1... (flutter/engine#43148)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 9635d54210dc to 7b6aae68a11f (5 revisions) (flutter/engine#43147)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 07vKo_Vaiy_V to w-tUP3Ia2kfA

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 20:15:50 +00:00
engine-flutter-autoroll
fb90a49efe
Roll Flutter Engine from cd30a48ef889 to 060cd9c17df3 (3 revisions) (#129440) 
cd30a48ef8...060cd9c17d

2023-06-23 chillers@google.com [impeller] Explicitly cast enum class to int before passing it to a formatted string (flutter/engine#43139)
2023-06-23 54558023+keyonghan@users.noreply.github.com Add osx_sdk context to mac_clang_tidy (flutter/engine#43115)
2023-06-23 jonahwilliams@google.com [Impeller] re-enable buffer to texture blit Vulkan. (flutter/engine#43129)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 18:44:10 +00:00
engine-flutter-autoroll
935652c34f
Roll Flutter Engine from 27f3498286ff to cd30a48ef889 (4 revisions) (#129437) 
27f3498286...cd30a48ef8

2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 04fa1c1ef69c to 9635d54210dc (2 revisions) (flutter/engine#43145)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 9211ebf1f2ac to 2e285bb591f7 (1 revision) (flutter/engine#43144)
2023-06-23 34871572+gmackall@users.noreply.github.com Add a note in ImeSyncDeferringInsetsCallback explaining the reason behind capturing the latest final inset state (flutter/engine#43109)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 6ab865ee1f65 to 04fa1c1ef69c (1 revision) (flutter/engine#43141)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 17:58:10 +00:00
godofredoc
929468e171
Add a devicelab test to recipes cq. (#129411) 
This is to ensure the devicelab_drone recipe is tested on presubmit.

Bug: https://github.com/flutter/flutter/issues/126111
 2023-06-23 17:38:38 +00:00
Paurakh Sharma Humagain
a9164a4d76
fix: Inconsistency of SelectionArea when scrolling (#128765) 
This PR fixes inconsistency of SelectionArea when scrolling by removing the `_clearSelection` on `longPressUpdate` gesture. This in turn makes the selection UX much better.

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes: https://github.com/flutter/flutter/issues/120892

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
 2023-06-23 16:47:47 +00:00
Kate Lovett
309e50173e
Run misc test shard when examples/api/** change (#129433) 
Fixes https://github.com/flutter/flutter/issues/129390

Found in https://github.com/flutter/flutter/pull/129381, changing sample code in `examples/api` did not trigger the misc test shard that executes the tests for `examples/api`.
 2023-06-23 16:46:04 +00:00
dependabot[bot]
fcb54add41
Bump ubuntu from b795f8e to db8bf6f in /dev/ci/docker_linux (#128740) 
Bumps ubuntu from `b795f8e` to `db8bf6f`.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ubuntu&package-manager=docker&previous-version=focal&new-version=focal)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2023-06-23 16:33:44 +00:00
godofredoc
11f1ae6f83
Add r: timeout label to bugs/pr closed by no response bot. (#129408) 
Adds r: timeout to bugs closed by inactivity.

Bug: https://github.com/flutter/flutter/issues/104962
 2023-06-23 16:27:51 +00:00
godofredoc
9fa4b53c6c
Remove .github/move.yml. (#129409) 
The file is not being used.

Bug: https://github.com/flutter/flutter/issues/129404
 2023-06-23 15:57:52 +00:00
engine-flutter-autoroll
837e8e0d0a
Roll Packages from 95bc1c6db547 to d041934b296d (6 revisions) (#129429) 
95bc1c6db5...d041934b29

2023-06-22 54558023+keyonghan@users.noreply.github.com Enforce Linux targets on VMs (flutter/packages#4268)
2023-06-22 engine-flutter-autoroll@skia.org Roll Flutter from c40baf47c5c8 to 042c0366c9a9 (20 revisions) (flutter/packages#4278)
2023-06-22 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.2.0 to 1.6.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#3331)
2023-06-22 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.mockito:mockito-core from 5.3.1 to 5.4.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4246)
2023-06-22 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20230227 to 20230618 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#4245)
2023-06-22 34871572+gmackall@users.noreply.github.com [in_app_purchase_android] Bump org.mockito:mockito-core from 4.7.0 to 5.3.1 (flutter/packages#4224)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 15:44:56 +00:00
engine-flutter-autoroll
ef2e00c819
Roll Flutter Engine from aca26b2afc27 to 27f3498286ff (16 revisions) (#129421) 
aca26b2afc...27f3498286

2023-06-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 7b30bcd6207e to 81cdbe69a16b (2 revisions) (flutter/engine#43138)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 16d65289e868 to 9211ebf1f2ac (1 revision) (flutter/engine#43137)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from a94abf80dd2f to 6ab865ee1f65 (1 revision) (flutter/engine#43135)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tcVndpnH_jzGm5LsJ... to VSKvLPB4DCIDvXzOA... (flutter/engine#43134)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from ac4f52c4f7ff to 16d65289e868 (1 revision) (flutter/engine#43133)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 450bc21cc836 to a94abf80dd2f (2 revisions) (flutter/engine#43132)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 4ed2d403a329 to ac4f52c4f7ff (2 revisions) (flutter/engine#43130)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from a989b6f1aec5 to 450bc21cc836 (2 revisions) (flutter/engine#43128)
2023-06-23 dnfield@google.com Removed outdated comment from lib/ui/canvas.h (flutter/engine#43112)
2023-06-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 05d99585adab to 7b30bcd6207e (1 revision) (flutter/engine#43123)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 6595192c8352 to a989b6f1aec5 (1 revision) (flutter/engine#43120)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Ylc35wOk0_j0NLzDv... to 07vKo_Vaiy_Vw2xxb... (flutter/engine#43119)
2023-06-23 bdero@google.com [Impeller] Include CPU blends + Flutter blend reference image in goldens (flutter/engine#43117)
2023-06-23 30870216+gaaclarke@users.noreply.github.com [Impeller] Fix and reland drawPaint collapsing optimization. (flutter/engine#43097)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 5265b5ee1afc to 6595192c8352 (1 revision) (flutter/engine#43116)
2023-06-22 skia-flutter-autoroll@skia.org Roll Dart SDK from ecca5857b3ba to 05d99585adab (4 revisions) (flutter/engine#43113)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from tcVndpnH_jzG to VSKvLPB4DCID
  fuchsia/sdk/core/mac-amd64 from Ylc35wOk0_j0 to 07vKo_Vaiy_V

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 11:57:21 +00:00
godofredoc
f582c0c573
Add comments to .ci.yaml that were removed from recipes. (#129321) 
Firebaselab recipe was cleaned up and comments removed. This is adding the still valid comments to the .ci.yaml file.
 2023-06-23 05:10:54 +00:00
godofredoc
3f90620ad0
Update no response to use core action. (#129405) 
This is to use a maintained version of the no-response action.

Bug: https://github.com/flutter/flutter/issues/127450
 2023-06-23 04:17:16 +00:00
Xilai Zhang
363e2f7e0b
Revert "[web] Migrate framework to fully use package:web" (#129400) 
Reverts flutter/flutter#128901

context: ([cl/542712088](https://critique.corp.google.com/542712088) , [b/288495136](https://b.corp.google.com/288495136))
 2023-06-23 04:11:55 +00:00
Oleh Prypin
71228e02c6
Prepare for making intl toBeginningOfSentenceCase non-nullable (#127488) 
I intend to edit `toBeginningOfSentenceCase`'s return value to be non-nullable because it really is never null. That will mean that non-null asserts around it will become flagged as unnecessary, although right now they are necessary. So, apply a workaround - instead use a function that does a non-null assert without triggering any lints even after it becomes unnecessary.
 2023-06-23 03:25:45 +00:00
David Iglesias
34b42acf1b
[web] Hides that Flutter uses requireJS in debug. (#129032) 
Flutter web uses requireJS in `debug` mode to assemble a DDC-compiled app from a bunch of small files ("modules").

This caused that `canvaskit.js` (and all other modules that used a browserify-like loading header) didn't work because they attempted to use the `define` function provided by Flutter's instance of `requireJS` (which kept the defined modules private, rather than as globals on the page, as the users of the JS expected).

A [fix](https://github.com/flutter/engine/pull/27342) was added to `flutter/engine` to trick loaders into *not* using the `requireJS` module loader, but a recent change in the fix's js-interop layer *subtly* changed its JS output on the page (objects went from `undefined` to `null`), causing this:

* https://github.com/flutter/flutter/issues/126131 (and others)

This PR hides a bit of code that is commonly used by module loaders to decide that they may use the `define` function provided by requireJS (so the engine workaround can be removed).

## Next steps

* https://github.com/flutter/engine/pull/42941

## Issues

Partially addresses: https://github.com/flutter/flutter/issues/126131 (and others)

## Tests

* Added a unit test to ensure the `delete` stays
* Manually tested with the Gallery app in `debug` mode with a bunch of user-supplied scripts that currently fail to load.
  * Also tested hot restart as suggested by @nshahan
 2023-06-23 02:09:12 +00:00
engine-flutter-autoroll
fcbc53bcb3
Roll Flutter Engine from 86820cbd40c5 to aca26b2afc27 (2 revisions) (#129393) 
86820cbd40...aca26b2afc

2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from cb44fca83da0 to 5265b5ee1afc (4 revisions) (flutter/engine#43114)
2023-06-22 godofredoc@google.com Add missing android lint to linux_unopt. (flutter/engine#43099)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 01:05:08 +00:00
Renzo Olivares
3c366b7011
_TapStatusTrackerMixin should wait until the next PointerDownEvent before resetting its state when the tap timer has elapsed (#129312) 
`_TapStatusTrackerMixin` used by `BaseTapAndDragGestureRecognizer` should wait until the next tap down before resetting its state when the `_consecutiveTapTimer` times out. This is because `BaseTapAndDragGestureRecognizer` may not have fired its tap down/tap up event before the state has been reset preventing it from firing the tap down/tap up callbacks at all because `currentDown` and `currentUp` are reset to `null`.

Fixes #129161
 2023-06-23 00:10:32 +00:00
engine-flutter-autoroll
3df1de4c80
Roll Flutter Engine from 7ff6a65b7183 to 86820cbd40c5 (1 revision) (#129388) 
7ff6a65b71...86820cbd40

2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 273f4cf92b7e to cb44fca83da0 (2 revisions) (flutter/engine#43107)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 00:07:36 +00:00
engine-flutter-autoroll
14eb1f4ce6
Roll Flutter Engine from ed477deba7c5 to 7ff6a65b7183 (2 revisions) (#129382) 
ed477deba7...7ff6a65b71

2023-06-22 43091780+utzcoz@users.noreply.github.com [android]: Make Robolectric tests work with SDK 33 (flutter/engine#42965)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 09b36b8ce0db to 273f4cf92b7e (1 revision) (flutter/engine#43106)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 23:11:50 +00:00
Kate Lovett
087377ea2f
Revert "Fix Material 3 Scrollable TabBar" (#129383) 
Reverts flutter/flutter#125974
 2023-06-22 22:34:06 +00:00