William Hesse
6ae22ef4e9
Fix detection that tests are running on monorepo bots ( #129173 )
...
Automatic CI testing runs on monorepo bots that tests the heads
of the Dart SDK, Flutter engine, and Flutter framework together.
These tests previously ran on bots called HHH (triple-headed),
and the logic for detecting this used the machine name of the test machine.
Extend that detection logic to cover the test machine hostnames that
run monorepo testing, that start with either 'dart-tests-' or 'luci-dart-'.
None of the machines used to run Flutter release builds have names
like this, even though they are in an internal Dart luci project.
Bug: b/231927187
2023-06-20 17:03:49 +00:00
Lau Ching Jun
3291750082
Use the new getIsolatePauseEvent method from VM service to check for pause event. ( #128834 )
...
The `getIsolate` method returns the full list of libraries which can be huge for large apps. Using the more speficic API to only fetch what we need improves hot reload performance.
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-06-20 16:42:28 +00:00
Swaroop S
80935ad984
Adding ScrollController support for Stepper widget ( #128814 )
...
This PR is to add **controller** property to the **Stepper** widget, so
that user has the flexibility to control the scroll offset for various
purposes(especially in case of scroll animations)!
Fixes #61207
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
2023-06-20 09:04:41 -07:00
engine-flutter-autoroll
ca6f08a306
Roll Packages from 59d93d64cb83 to 6e1918fa166c (6 revisions) ( #129176 )
...
59d93d64cb...6e1918fa16ychris@google.com [all] Update UIViewControllerBasedStatusBarAppearance to true (flutter/packages#4225 )
2023-06-17 31859944+LongCatIsLooong@users.noreply.github.com Add missing ignores for `textScaleFactor` deprecation (flutter/packages#4239 )
2023-06-17 goderbauer@google.com [url_launcher] Remove deprecated onPlatformMessage calls (flutter/packages#4233 )
2023-06-17 stuartmorgan@google.com [ci] Add LUCI version of build-all for web (flutter/packages#4232 )
2023-06-16 stuartmorgan@google.com [ci] Introduce LUCI version of Linux build-all-packages tests (flutter/packages#4229 )
2023-06-16 engine-flutter-autoroll@skia.org Roll Flutter from b0188cd18274 to fc8856eb80d3 (14 revisions) (flutter/packages#4231 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 15:51:29 +00:00
Tae Hyung Kim
48ba9c4193
Refactor generate_localizations_test.dart ( #128974 )
...
The file was becoming harder to deal with as it manually sets up a /lib/l10n directory with a `MemoryFileSystem` in every single test. This PR wraps this process in a helper function `setupLocalizations` and also provides a helper function `getGeneratedFileContent` which helps fetch the respective output file given the locale string.
2023-06-20 15:42:22 +00:00
Kevin Chisholm
e5ec07ba16
[process] Add a design doc issue template. ( #128361 )
...
Add a design doc issue template to streamline the proposal flow.
2023-06-20 13:42:34 +00:00
engine-flutter-autoroll
691e24c1dd
Roll Flutter Engine from bd6d3fc90462 to 4444ede34a9c (1 revision) ( #129169 )
...
bd6d3fc904...4444ede34askia-flutter-autoroll@skia.org Roll Skia from 1d6ca884ed77 to 6823d03cf2b2 (1 revision) (flutter/engine#42998 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 13:22:29 +00:00
engine-flutter-autoroll
fa99d44413
Roll Flutter Engine from 73c4ba4240cc to bd6d3fc90462 (1 revision) ( #129168 )
...
73c4ba4240...bd6d3fc904skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JewrT71vAzyDs8qRt... to fdtK_FqpscIVvbb_j... (flutter/engine#42997 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JewrT71vAzyD to fdtK_FqpscIV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 12:29:07 +00:00
engine-flutter-autoroll
5ffdd0f038
Roll Flutter Engine from 7ee874792067 to 73c4ba4240cc (1 revision) ( #129162 )
...
7ee8747920...73c4ba4240skia-flutter-autoroll@skia.org Roll Dart SDK from d87670619414 to dc6691ef755c (1 revision) (flutter/engine#42996 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 10:19:33 +00:00
engine-flutter-autoroll
7f5232f5d8
Roll Flutter Engine from 6a6c8fb591f5 to 7ee874792067 (1 revision) ( #129160 )
...
6a6c8fb591...7ee8747920skia-flutter-autoroll@skia.org Roll Skia from 60385192e512 to 1d6ca884ed77 (3 revisions) (flutter/engine#42995 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 09:23:39 +00:00
Leigha Jarett
b2c993cad3
Add to API docs to explain what Assist and Suggestion chips are ( #129034 )
...
Fixes https://github.com/flutter/flutter/issues/128028 .
It seems pretty straightforward so don't think it warrants the effort to add more samples.
2023-06-20 09:03:21 +00:00
engine-flutter-autoroll
63908a687b
Roll Flutter Engine from a91bb3f566b9 to 6a6c8fb591f5 (1 revision) ( #129158 )
...
a91bb3f566...6a6c8fb591skia-flutter-autoroll@skia.org Roll Skia from abcc292f8afe to 60385192e512 (1 revision) (flutter/engine#42993 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 08:37:27 +00:00
engine-flutter-autoroll
5182697c0d
Roll Flutter Engine from e0d456d9251b to a91bb3f566b9 (1 revision) ( #129148 )
...
e0d456d925...a91bb3f566skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lG2K667BLaS_haUZg... to jzCJwD297aRZtdakZ... (flutter/engine#42990 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from lG2K667BLaS_ to jzCJwD297aRZ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 01:37:33 +00:00
engine-flutter-autoroll
e661d01c2d
Roll Flutter Engine from 55418e648958 to e0d456d9251b (1 revision) ( #129146 )
...
55418e6489...e0d456d925skia-flutter-autoroll@skia.org Roll Skia from 9c2148cd1c82 to abcc292f8afe (1 revision) (flutter/engine#42989 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 00:33:37 +00:00
engine-flutter-autoroll
b8590b2315
Roll Flutter Engine from 84ecaa053ec6 to 55418e648958 (1 revision) ( #129145 )
...
84ecaa053e...55418e6489skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gX0QkT_dMBCTbiAHY... to JewrT71vAzyDs8qRt... (flutter/engine#42988 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from gX0QkT_dMBCT to JewrT71vAzyD
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 23:31:30 +00:00
engine-flutter-autoroll
c99540264b
Roll Flutter Engine from 23a2c246600f to 84ecaa053ec6 (2 revisions) ( #129142 )
...
23a2c24660...84ecaa053eskia-flutter-autoroll@skia.org Roll Skia from 41689ff01f97 to 9c2148cd1c82 (1 revision) (flutter/engine#42987 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 60adb12ffc30 to d87670619414 (1 revision) (flutter/engine#42986 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 22:43:35 +00:00
Taha Tesser
467c970bfb
Introduce MaterialState color property for chips ( #128584 )
...
fixes https://github.com/flutter/flutter/issues/115827
fixes https://github.com/flutter/flutter/issues/101325
### Description
1. This PR adds a new MaterialState `color` property to all the chips (this makes it possible to customize chips in all states from the M3 specs).
2. Updated defaults to use the new MaterialState `color` property.
3. Updated and added new tests to all the chip test classes.
<details>
<summary>code sample</summary>
```dart
import 'package:flutter/material.dart';
const Color disabledColor = Colors.black26;
const Color backgroundColor = Colors.cyan;
final Color disabledSelectedColor = Colors.red.shade100;
const Color selectedColor = Colors.amber;
final MaterialStateProperty<Color> color =
MaterialStateProperty.resolveWith((Set<MaterialState> states) {
if (states.contains(MaterialState.disabled) &&
states.contains(MaterialState.selected)) {
return disabledSelectedColor;
}
if (states.contains(MaterialState.disabled)) {
return disabledColor;
}
if (states.contains(MaterialState.selected)) {
return selectedColor;
}
return backgroundColor;
});
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
useMaterial3: true,
// chipTheme: ChipThemeData(color: color),
),
home: const Example(),
);
}
}
class Example extends StatefulWidget {
const Example({super.key});
@override
State<Example> createState() => _ExampleState();
}
class _ExampleState extends State<Example> {
bool enabled = false;
bool selected = true;
@override
Widget build(BuildContext context) {
const Widget verticalSpace = SizedBox(height: 20);
return Scaffold(
body: Center(
child: Column(
children: <Widget>[
const SizedBox(height: 25),
Row(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
const Card(
elevation: 0.0,
color: disabledColor,
child: Padding(
padding: EdgeInsets.all(8.0),
child: Text('disabledColor'),
),
),
const Card(
elevation: 0.0,
color: backgroundColor,
child: Padding(
padding: EdgeInsets.all(8.0),
child: Text('backgroundColor'),
),
),
Card(
elevation: 0.0,
color: disabledSelectedColor,
child: const Padding(
padding: EdgeInsets.all(8.0),
child: Text('disabledSelectedColor'),
),
),
const Card(
elevation: 0.0,
color: selectedColor,
child: Padding(
padding: EdgeInsets.all(8.0),
child: Text('selectedColor'),
),
),
],
),
const Spacer(),
Row(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
Column(
mainAxisSize: MainAxisSize.min,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
RawChip(
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('RawChip'),
isEnabled: enabled,
onSelected: enabled ? (bool value) {} : null,
),
verticalSpace,
InputChip(
isEnabled: enabled,
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('InputChip'),
onSelected: enabled ? (bool value) {} : null,
),
],
),
Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
FilterChip(
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('FilterChip'),
onSelected: enabled ? (bool value) {} : null,
),
verticalSpace,
FilterChip.elevated(
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('FilterChip.elevated'),
onSelected: enabled ? (bool value) {} : null,
),
],
),
Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
ChoiceChip(
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('ChoiceChip'),
onSelected: enabled ? (bool value) {} : null,
),
verticalSpace,
ChoiceChip.elevated(
selected: selected,
selectedColor: selectedColor,
color: color,
label: const Text('ChoiceChip.elevated'),
onSelected: enabled ? (bool value) {} : null,
),
],
),
],
),
const Spacer(),
Row(
children: <Widget>[
Flexible(
child: SwitchListTile(
title: const Text('Enabled'),
value: enabled,
onChanged: (bool value) {
setState(() => enabled = value);
},
),
),
Flexible(
child: SwitchListTile(
title: const Text('Selected'),
value: selected,
onChanged: (bool value) {
setState(() => selected = value);
},
),
),
],
)
],
),
),
);
}
}
```
</details>
### Before (not possible to customize disabled and selected chips)
### After (using disabled and selected chips using the new MaterialState `color` property)
2023-06-19 22:03:26 +00:00
engine-flutter-autoroll
62a1c8ee62
Roll Flutter Engine from 280491d4cc21 to 23a2c246600f (8 revisions) ( #129140 )
...
280491d4cc...23a2c24660skia-flutter-autoroll@skia.org Roll Skia from 455d7306b951 to 41689ff01f97 (1 revision) (flutter/engine#42983 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 3d07173415e8 to 60adb12ffc30 (1 revision) (flutter/engine#42982 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fgS2avQGq4x_sbZHU... to lG2K667BLaS_haUZg... (flutter/engine#42981 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from c90c7dec5c18 to 455d7306b951 (1 revision) (flutter/engine#42980 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from d182b694a670 to c90c7dec5c18 (1 revision) (flutter/engine#42979 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from b2ec326cc4f3 to 3d07173415e8 (1 revision) (flutter/engine#42978 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from 24f2336d87f2 to d182b694a670 (2 revisions) (flutter/engine#42977 )
2023-06-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from BuzniDS9u_hdghV5f... to gX0QkT_dMBCTbiAHY... (flutter/engine#42976 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fgS2avQGq4x_ to lG2K667BLaS_
fuchsia/sdk/core/mac-amd64 from BuzniDS9u_hd to gX0QkT_dMBCT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 20:52:10 +00:00
Jason Simmons
03d50d1f8a
Fix an ordering dependency in the flutter_tools upgrade test ( #129131 )
...
Cache.flutterRoot is set within testUsingContext and will be
uninitialized the first time test suite setup is invoked.
2023-06-19 11:18:16 -07:00
engine-flutter-autoroll
323c296922
Roll Flutter Engine from 164c6b49dfb5 to 280491d4cc21 (1 revision) ( #129102 )
...
164c6b49df...280491d4ccskia-flutter-autoroll@skia.org Roll Skia from f489be63a30a to 24f2336d87f2 (1 revision) (flutter/engine#42975 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 07:24:11 +00:00
Taha Tesser
165d237792
Fix InputDecoration.applyDefaults ignoring some properties ( #129010 )
...
fixes [`InputDecoration.applyDefaults` ignores some properties](https://github.com/flutter/flutter/issues/127330 )
<details>
<summary>code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(useMaterial3: true),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
const TextStyle textStyle = TextStyle(color: Color(0xFF00FFFF));
const Color color = Color(0xFF00FF00);
const InputBorder inputBorder = OutlineInputBorder(
borderSide: BorderSide(
color: Color(0xFF0000FF),
),
);
final InputDecoration appliedDefaults =
const InputDecoration().applyDefaults(
const InputDecorationTheme(
labelStyle: textStyle,
floatingLabelStyle: textStyle,
helperStyle: textStyle,
helperMaxLines: 2,
hintStyle: textStyle,
errorStyle: textStyle,
errorMaxLines: 2,
floatingLabelBehavior: FloatingLabelBehavior.never,
floatingLabelAlignment: FloatingLabelAlignment.center,
isDense: true,
contentPadding: EdgeInsets.all(1.0),
iconColor: color,
prefixStyle: textStyle,
prefixIconColor: color,
suffixStyle: textStyle,
suffixIconColor: color,
counterStyle: textStyle,
filled: true,
fillColor: color,
focusColor: color,
hoverColor: color,
errorBorder: inputBorder,
focusedBorder: inputBorder,
focusedErrorBorder: inputBorder,
disabledBorder: inputBorder,
enabledBorder: inputBorder,
border: InputBorder.none,
alignLabelWithHint: true,
constraints: BoxConstraints(
minWidth: 10, maxWidth: 20, minHeight: 30, maxHeight: 40),
),
);
return Scaffold(
appBar: AppBar(
title: const Text('InputDecoration().applyDefaults'),
),
// Centered FilledButton.
body: Center(
child: SingleChildScrollView(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
ColoredBox(
color: appliedDefaults.labelStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.labelStyle.toString()),
),
ColoredBox(
color: appliedDefaults.floatingLabelStyle
.toString()
.contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.floatingLabelStyle.toString()),
),
ColoredBox(
color: appliedDefaults.helperStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.helperStyle.toString()),
),
ColoredBox(
color: appliedDefaults.hintStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.hintStyle.toString()),
),
ColoredBox(
color: appliedDefaults.errorStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.errorStyle.toString()),
),
ColoredBox(
color: appliedDefaults.iconColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.iconColor.toString()),
),
ColoredBox(
color: appliedDefaults.prefixStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.prefixStyle.toString()),
),
ColoredBox(
color:
appliedDefaults.prefixIconColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.prefixIconColor.toString()),
),
ColoredBox(
color: appliedDefaults.suffixStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.suffixStyle.toString()),
),
ColoredBox(
color:
appliedDefaults.suffixIconColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.suffixIconColor.toString()),
),
ColoredBox(
color: appliedDefaults.counterStyle.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.counterStyle.toString()),
),
ColoredBox(
color: appliedDefaults.fillColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.fillColor.toString()),
),
ColoredBox(
color: appliedDefaults.focusColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.focusColor.toString()),
),
ColoredBox(
color: appliedDefaults.hoverColor.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.hoverColor.toString()),
),
ColoredBox(
color: appliedDefaults.errorBorder.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.errorBorder.toString()),
),
ColoredBox(
color: appliedDefaults.focusedBorder.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.focusedBorder.toString()),
),
ColoredBox(
color: appliedDefaults.focusedErrorBorder
.toString()
.contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.focusedErrorBorder.toString()),
),
ColoredBox(
color:
appliedDefaults.disabledBorder.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.disabledBorder.toString()),
),
ColoredBox(
color: appliedDefaults.enabledBorder.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.enabledBorder.toString()),
),
ColoredBox(
color: appliedDefaults.border.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.border.toString()),
),
ColoredBox(
color: appliedDefaults.constraints.toString().contains('null')
? Colors.red
: Colors.green,
child: Text(appliedDefaults.constraints.toString()),
),
],
),
),
),
);
}
}
```
</details>
### Before
### After
2023-06-19 07:06:19 +00:00
engine-flutter-autoroll
59e30ef421
Roll Flutter Engine from d298f0bf720c to 164c6b49dfb5 (1 revision) ( #129100 )
...
d298f0bf72...164c6b49dfskia-flutter-autoroll@skia.org Roll Dart SDK from 5a9e97eebbed to b2ec326cc4f3 (1 revision) (flutter/engine#42974 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 05:45:11 +00:00
engine-flutter-autoroll
0dadf4089b
Roll Flutter Engine from 7ffa1355f718 to d298f0bf720c (24 revisions) ( #129092 )
...
7ffa1355f7...d298f0bf72jonahwilliams@google.com Fix prefer_final_in_foreach analysis
errors (flutter/engine#42971 )
2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
xS5RzQLfpMEK1rNEd... to fgS2avQGq4x_sbZHU... (flutter/engine#42973 )
2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
aBEyk5N2HlwOqvpwo... to BuzniDS9u_hdghV5f... (flutter/engine#42970 )
2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from dc2e0ebbd045 to
f489be63a30a (1 revision) (flutter/engine#42968 )
2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from 85b4788bc3f1 to
dc2e0ebbd045 (1 revision) (flutter/engine#42967 )
2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
-PsA0LDB2FdS_4_vK... to xS5RzQLfpMEK1rNEd... (flutter/engine#42966 )
2023-06-18 bdero@google.com [Impeller] Use 32 bit for positional stuff
in the rrect blur (flutter/engine#42797 )
2023-06-18 jonahwilliams@google.com Revert "[Impeller] correct default
PSO pixel format and sample count." (flutter/engine#42962 )
2023-06-18 jonahwilliams@google.com [Impeller] dont use concurrent
runner to decode images on Android. (flutter/engine#42944 )
2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
I1G8Ll0KcxmAoMT8u... to aBEyk5N2HlwOqvpwo... (flutter/engine#42964 )
2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from c56f38d79fe0 to
85b4788bc3f1 (2 revisions) (flutter/engine#42963 )
2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
Au1gd3XLMuSt1Z4oh... to -PsA0LDB2FdS_4_vK... (flutter/engine#42959 )
2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
d1faf69c8253 to 5a9e97eebbed (1 revision) (flutter/engine#42958 )
2023-06-17 skia-flutter-autoroll@skia.org Roll Skia from 2a9e11fd9d37 to
c56f38d79fe0 (1 revision) (flutter/engine#42955 )
2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JMStJe6efcLuWMT_I... to I1G8Ll0KcxmAoMT8u... (flutter/engine#42954 )
2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
1a04f451a934 to d1faf69c8253 (1 revision) (flutter/engine#42953 )
2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
b3bcbdf7de8d to 1a04f451a934 (1 revision) (flutter/engine#42951 )
2023-06-17 skia-flutter-autoroll@skia.org Roll Skia from dc11c7ddb33f to
2a9e11fd9d37 (1 revision) (flutter/engine#42950 )
2023-06-17 bdero@google.com [Impeller] Print malioc errors on CI
(flutter/engine#42906 )
2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from
8eaed3382237 to b3bcbdf7de8d (10 revisions) (flutter/engine#42949 )
2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
-NW1eatBbmjvLaIcV... to Au1gd3XLMuSt1Z4oh... (flutter/engine#42948 )
2023-06-17 a-siva@users.noreply.github.com Fix analyzer warnings
(prefer_final_in_for_each is now the default) (flutter/engine#42943 )
2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
fXVcR5tdj5wSd_OUz... to JMStJe6efcLuWMT_I... (flutter/engine#42942 )
2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 64fa632d3b01 to
dc11c7ddb33f (3 revisions) (flutter/engine#42939 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from -NW1eatBbmjv to fgS2avQGq4x_
fuchsia/sdk/core/mac-amd64 from fXVcR5tdj5wS to BuzniDS9u_hd
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-18 19:06:20 -07:00
engine-flutter-autoroll
c29b570678
Roll Flutter Engine from 7483c8a533e3 to 7ffa1355f718 (3 revisions) ( #129047 )
...
7483c8a533...7ffa1355f7skia-flutter-autoroll@skia.org Roll Skia from 01f3be45e0d6 to 64fa632d3b01 (3 revisions) (flutter/engine#42937 )
2023-06-16 110993981+htoor3@users.noreply.github.com [web] Fix for Safari autofill flickering bug (flutter/engine#42830 )
2023-06-16 jonahwilliams@google.com [Impeller] correct default PSO pixel format and sample count. (flutter/engine#42902 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-17 00:07:25 +00:00
engine-flutter-autoroll
7b58de3b67
Roll Flutter Engine from 54990ac1bf95 to 7483c8a533e3 (1 revision) ( #129042 )
...
54990ac1bf...7483c8a533skia-flutter-autoroll@skia.org Roll Skia from 90dae91b2242 to 01f3be45e0d6 (4 revisions) (flutter/engine#42934 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-16 22:37:08 +00:00
engine-flutter-autoroll
3bb91580c3
Roll Flutter Engine from 28dc0c40ea54 to 54990ac1bf95 (1 revision) ( #129040 )
...
28dc0c40ea...54990ac1bfskia-flutter-autoroll@skia.org Roll Skia from 20e9cc928715 to 90dae91b2242 (5 revisions) (flutter/engine#42932 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-16 21:40:02 +00:00
engine-flutter-autoroll
b61d29d0ba
Roll Flutter Engine from aefe104cd067 to 28dc0c40ea54 (1 revision) ( #129031 )
...
aefe104cd0...28dc0c40easkia-flutter-autoroll@skia.org Roll Skia from a4ad5b369313 to 20e9cc928715 (3 revisions) (flutter/engine#42926 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-16 20:39:08 +00:00
engine-flutter-autoroll
5a7ab5a147
Roll Flutter Engine from fb5fed432e59 to aefe104cd067 (21 revisions) ( #129029 )
...
fb5fed432e...aefe104cd030870216+gaaclarke@users.noreply.github.com Revert "Add
deprecations to PlatformMessage stuff" (flutter/engine#42921 )
2023-06-16 jakemac@google.com add dart_internal override where necessary
(flutter/engine#42920 )
2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from d43262e90f25 to
a4ad5b369313 (3 revisions) (flutter/engine#42919 )
2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 9ab04a53b7be to
d43262e90f25 (5 revisions) (flutter/engine#42918 )
2023-06-16 mdebbar@google.com [web] Move webOnlyAssetManager to
`dart:ui_web` (flutter/engine#42642 )
2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
E5G7PwYbRA-u-ZJ9F... to -NW1eatBbmjvLaIcV... (flutter/engine#42915 )
2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
FJPPnZP9EcGLQ0OZa... to fXVcR5tdj5wSd_OUz... (flutter/engine#42912 )
2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from c29ecbe7fba7 to
9ab04a53b7be (1 revision) (flutter/engine#42910 )
2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 504a26e85fc6 to
c29ecbe7fba7 (1 revision) (flutter/engine#42909 )
2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from f0410a265d2b to
504a26e85fc6 (1 revision) (flutter/engine#42907 )
2023-06-16 godofredoc@google.com Set xcode explicitly on mac builds with
release_build. (flutter/engine#42898 )
2023-06-16 scheglov@google.com Fix prefer_final_in_for_each
(flutter/engine#42899 )
2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from abfa3505db23 to
f0410a265d2b (1 revision) (flutter/engine#42904 )
2023-06-16 godofredoc@google.com Remove release_build from clang_tidy
build. (flutter/engine#42900 )
2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
53EjCyuRu91oFTBf2... to E5G7PwYbRA-u-ZJ9F... (flutter/engine#42897 )
2023-06-15 chillers@google.com Revert "Roll Clang from 6d667d4b261e to
7f374b6902fa" (flutter/engine#42896 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 2ab2678058a3 to
abfa3505db23 (1 revision) (flutter/engine#42894 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
P7QA6bfO_Ij5dre7B... to FJPPnZP9EcGLQ0OZa... (flutter/engine#42892 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 794b6f9240a8 to
2ab2678058a3 (6 revisions) (flutter/engine#42889 )
2023-06-15 goderbauer@google.com Add deprecations to PlatformMessage
stuff (flutter/engine#42580 )
2023-06-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Joined
obligatory vulkan swapchain submits (flutter/engine#42865 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 53EjCyuRu91o to -NW1eatBbmjv
fuchsia/sdk/core/mac-amd64 from P7QA6bfO_Ij5 to fXVcR5tdj5wS
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-16 12:43:02 -07:00
Polina Cherkasova
9690394772
Update objectToDiagnosticsNode to stop failing. ( #129027 )
...
Prerequisite for https://github.com/flutter/devtools/pull/5918
2023-06-16 19:39:54 +00:00
engine-flutter-autoroll
3f73d2c484
Roll Packages from f9314a3b833a to 59d93d64cb83 (18 revisions) ( #129021 )
...
f9314a3b83...59d93d64cbstuartmorgan@google.com [tool] Add command aliases (flutter/packages#4207 )
2023-06-16 stuartmorgan@google.com [google_map_flutter] Fix map object regression due to async changes (flutter/packages#4171 )
2023-06-16 goderbauer@google.com [url_launcher] Add ignores for deprecated member to test (flutter/packages#4220 )
2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter from 95be76ab7e3d to b0188cd18274 (10 revisions) (flutter/packages#4221 )
2023-06-15 34871572+gmackall@users.noreply.github.com [camera_android] Upgrading roboelectric from 4.5 to 4.10.3 (flutter/packages#4018 )
2023-06-15 47866232+chunhtai@users.noreply.github.com [go_router] Fixes bug that GoRouterState in top level redirect doesn'⦠(flutter/packages#4173 )
2023-06-15 47866232+chunhtai@users.noreply.github.com [go_router]Updates documentations around GoRouter.of, GoRouter.maybeOf, and BuildContext extension. (flutter/packages#4176 )
2023-06-15 stuartmorgan@google.com [tool] Support code excerpts for any .md file (flutter/packages#4212 )
2023-06-15 baptiste.dupuch@gmail.com [webview_flutter] Add support for limitsNavigationsToAppBoundDomains (flutter/packages#4026 )
2023-06-15 yk3372@gmail.com [webview_flutter][webview_flutter_android] Add android support for handling geolocation permissions (flutter/packages#3795 )
2023-06-15 tarrinneal@gmail.com [image_picker] add getMedia method (flutter/packages#3892 )
2023-06-15 tarrinneal@gmail.com [image_picker] getMedia platform implementations (flutter/packages#4175 )
2023-06-14 31859944+LongCatIsLooong@users.noreply.github.com Ignore `textScaleFactor` deprecation (flutter/packages#4209 )
2023-06-14 stuartmorgan@google.com [pigeon] Enable Obj-C integration tests in CI (flutter/packages#4215 )
2023-06-14 63286031+ahmednfwela@users.noreply.github.com [flutter_adaptive_scaffold] Support RTL (flutter/packages#4204 )
2023-06-14 engine-flutter-autoroll@skia.org Manual roll Flutter from 09b7e5615761 to 95be76ab7e3d (14 revisions) (flutter/packages#4214 )
2023-06-14 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 682aa387cfe4 to 796c8ef79279 (5 revisions) (flutter/packages#4213 )
2023-06-14 engine-flutter-autoroll@skia.org Roll Flutter from 353b8bc87d29 to 09b7e5615761 (17 revisions) (flutter/packages#4206 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-16 18:50:11 +00:00
Christopher Fujino
3f68b25b46
[flutter_tools] fix cast error when dart-defines-json file includes null ( #128909 )
...
Fixes https://github.com/flutter/flutter/issues/128787
2023-06-16 18:12:22 +00:00
Danny Tuppeny
dc4541fa05
[flutter_tools] Add support for vmServiceFileInfo when attaching ( #128503 )
...
When building the new SDK DAPs, this functionality was missed from the Flutter adapter (but added to the Dart CLI adapter).
As well as passing a VM Service URI directly, we support passing a file that can be polled for it.
This uses the same mechanism we use to obtain the VM Service URI from a Dart debug session (we run `dart --write-service-info=foo.json my_file.dart` and then poll that file which the VM will write) and is useful for users that have their own mechanism for launching an app (for example using custom Flutter embedders - see https://github.com/Dart-Code/Dart-Code/issues/3353 ) to provide a VM Service URI once the app is up and running.
Fixes https://github.com/Dart-Code/Dart-Code/issues/4577 .
2023-06-16 18:00:21 +00:00
Polina Cherkasova
7214cb28be
Accept Diagnosticable as input in inspector API. ( #128962 )
2023-06-16 10:45:34 -07:00
Michael Goderbauer
5ab5d82a39
Remove AbstractNode from RenderObject and deprecate it ( #128973 )
...
It's time to say good bye to an old friend.
It has outlived its usefulness.
Farewell, AbstractNode! ð«¡
2023-06-16 16:16:36 +00:00
Mouad Debbar
fc8856eb80
[web] Don't crash on const HtmlElementView() ( #128965 )
...
Previously, when the code contained `const HtmlElementView()` it would break even if it's guarded by `if (kIsWeb)`.
This PR makes it such that `const HtmlElementView()` is allowed but it still throws if it gets inserted into the widget tree by mistake on non-web platforms.
One improvement we can make in the future is to have a conditional import:
- `_html_element_view_web.dart` that contains the real `HtmlElementView` that can only be instantiated on web.
- `_html_element_view_io.dart` that contains a stub with an unimplemented `build()` method.
Fixes https://github.com/flutter/flutter/issues/43532
2023-06-16 13:53:05 +00:00
engine-flutter-autoroll
5cb27998d3
Roll Packages from 050729760b25 to f9314a3b833a (3 revisions) ( #128878 )
...
050729760b...f9314a3b83stuartmorgan@google.com [tool] Support running main.dart
(flutter/packages#4208 )
2023-06-13 stuartmorgan@google.com [tool] Allow running from anywhere
(flutter/packages#4199 )
2023-06-13 62033170+Khalidm98@users.noreply.github.com [go_router]
#127016 preserved route name case when caching `_nameToPath`
(flutter/packages#4196 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-15 20:08:39 -07:00
Polina Cherkasova
dd4a8150a8
Update getProperties to handle Diagnosticable as input. ( #128897 )
2023-06-15 17:04:46 -07:00
engine-flutter-autoroll
e87b202160
Roll Flutter Engine from 48e0b4e66422 to fb5fed432e59 (1 revision) ( #128967 )
...
48e0b4e664...fb5fed432eskia-flutter-autoroll@skia.org Roll Skia from 2d531d020c26 to 794b6f9240a8 (3 revisions) (flutter/engine#42888 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-15 21:58:16 +00:00
Dery Rahman Ahaddienata
6b5766d41e
Fix dart pub cache clean command on pub.dart ( #128171 )
...
Command instruction for clearing dart pub cache is somewhat wrong. Instead of `clear`, `clean` is the correct one. Ref: https://dart.dev/tools/pub/cmd/pub-cache
Fixes https://github.com/flutter/flutter/issues/128663
(Edited by @andrewkolos. Changed "related to" issue to "fixes" to link this PR to the issue).
2023-06-15 20:38:04 +00:00
Christopher Fujino
cc83f03822
[flutter_tools] Migrate more integration tests to process result matcher ( #128737 )
...
Part of https://github.com/flutter/flutter/issues/127135
2023-06-15 13:25:32 -07:00
Christopher Fujino
735fc29622
[flutter_tools] refactor license collector ( #128748 )
...
Improve debugging for https://github.com/flutter/flutter/issues/128680
In the linked issue, I cannot explain how we are getting a type error. However, this refactor eliminates the null check operator (by iterating over `MapEntries` rather than the keys) in hopes that there will be a more descriptive error in the future. The correctness of this change is verified by the existing tests in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/license_collector_test.dart
2023-06-15 20:25:19 +00:00
Qun Cheng
f8e8d89b85
Set Semantics.button to true for date widget ( #128824 )
...
Fixes #127863
This PR is to set `Semantics.button` to true for date widget in `DatePicker`.
https://github.com/flutter/flutter/assets/36861262/b366f25a-6bf3-4e3f-b944-ab71197b73e5
2023-06-15 20:13:07 +00:00
Qun Cheng
c3b2175a40
Update golden tests ( #128914 )
2023-06-15 13:09:43 -07:00
engine-flutter-autoroll
c7167765d7
Roll Flutter Engine from 9934c0de738c to 48e0b4e66422 (26 revisions) ( #128959 )
...
9934c0de73...48e0b4e664skia-flutter-autoroll@skia.org Roll Skia from 0b66c6928dcf to 2d531d020c26 (3 revisions) (flutter/engine#42883 )
2023-06-15 matej.knopp@gmail.com Raster cache should preserve RTree for overlay layers (flutter/engine#42552 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from c0c74b433117 to 0b66c6928dcf (1 revision) (flutter/engine#42879 )
2023-06-15 leroux_bruno@yahoo.fr [Linux] Allow BasicMessageChannel sending and responding to null message (flutter/engine#42808 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 12375fb6f3c8 to c0c74b433117 (1 revision) (flutter/engine#42876 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from d62221bd33a6 to 12375fb6f3c8 (1 revision) (flutter/engine#42873 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from e2e0256d4c6a to d62221bd33a6 (1 revision) (flutter/engine#42871 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from c3abd540c7f9 to e2e0256d4c6a (1 revision) (flutter/engine#42869 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uvmDF7KM34dWGdsuK... to 53EjCyuRu91oFTBf2... (flutter/engine#42868 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from h3-8RUVrC889UXou7... to P7QA6bfO_Ij5dre7B... (flutter/engine#42867 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 2718866006d2 to c3abd540c7f9 (1 revision) (flutter/engine#42866 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 19051bc5fc90 to 2718866006d2 (33 revisions) (flutter/engine#42864 )
2023-06-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 922c315b2c34 to 8eaed3382237 (1 revision) (flutter/engine#42862 )
2023-06-15 godofredoc@google.com Add missing artifact to the android_arm64_profile config. (flutter/engine#42858 )
2023-06-14 hterkelsen@users.noreply.github.com Build skia with expat (flutter/engine#42859 )
2023-06-14 ychris@google.com [ios] use interfaceOrientation orientation on iOS 13 and above (flutter/engine#42846 )
2023-06-14 skia-flutter-autoroll@skia.org Manual roll Dart SDK from f1387834bfd9 to 922c315b2c34 (4 revisions) (flutter/engine#42855 )
2023-06-14 jonahwilliams@google.com [Impeller] Make interleaved layout (more) explicit in generated headers. (flutter/engine#42628 )
2023-06-14 30870216+gaaclarke@users.noreply.github.com Renamed validation layers build (flutter/engine#42826 )
2023-06-14 ychris@google.com [ios] view controller based status bar (flutter/engine#42643 )
2023-06-14 skia-flutter-autoroll@skia.org Roll Skia from 6d5dc31d88e2 to 19051bc5fc90 (25 revisions) (flutter/engine#42828 )
2023-06-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Xi3c5nti2LKnEOqYt... to uvmDF7KM34dWGdsuK... (flutter/engine#42842 )
2023-06-14 43091780+utzcoz@users.noreply.github.com Fix generateLockfiles running directory for documentation (flutter/engine#42734 )
2023-06-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Cld7-rm6ZmCOO8j-K... to h3-8RUVrC889UXou7... (flutter/engine#42839 )
2023-06-14 skia-flutter-autoroll@skia.org Roll ANGLE from 7e075469ff02 to 3a3a3c655a96 (8 revisions) (flutter/engine#42834 )
2023-06-14 skia-flutter-autoroll@skia.org Roll Dart SDK from c4e9794df8af to f1387834bfd9 (1 revision) (flutter/engine#42833 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Xi3c5nti2LKn to 53EjCyuRu91o
fuchsia/sdk/core/mac-amd64 from Cld7-rm6ZmCO to P7QA6bfO_Ij5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-15 19:33:37 +00:00
Ian Hickson
8c5a70f367
flutter update-packages --cherry-pick-package ( #128917 )
...
Fixes https://github.com/flutter/flutter/issues/101525
2023-06-15 19:26:53 +00:00
Christopher Fujino
d3e771c80b
add .pub-cache back to .gitignore ( #128894 )
...
Fixes https://github.com/flutter/flutter/issues/128635
In 1fd84f88e9
2023-06-15 19:21:05 +00:00
engine-flutter-autoroll
12f2cbcb21
Roll Flutter Engine from 2d8d5ecfe4a8 to 9934c0de738c (2 revisions) ( #128849 )
...
2d8d5ecfe4...9934c0de73skia-flutter-autoroll@skia.org Roll Dart SDK from
2465228c0c21 to c4e9794df8af (1 revision) (flutter/engine#42831 )
2023-06-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
kQbij6Tvqe7F9-PhR... to Xi3c5nti2LKnEOqYt... (flutter/engine#42832 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kQbij6Tvqe7F to Xi3c5nti2LKn
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-15 11:26:55 -07:00
Mouad Debbar
a162d7546a
flutter update-packages --force-upgrade ( #128908 )
...
- Bumps `vm_service` from `11.6.0` to `11.7.1`
- Bumps `web` from `0.1.3-beta` to `0.1.4-beta` and adds it everywhere.
- Moves `js` from `dependencies` to `dev_dependencies`
2023-06-15 18:17:09 +00:00
Mouad Debbar
b0188cd182
[web] Pass creation params to the platform view factory ( #128146 )
...
This concludes step 1 of the `HtmlElementView` improvements. It's now possible to pass creation params to platform view factories directly from `HtmlElementView`.
Here's a sample app using a single factory to render platform views in different colors:
<details>
<summary>Code sample</summary>
```dart
import 'dart:js_interop';
import 'dart:ui_web' as ui_web;
import 'package:flutter/material.dart';
import 'package:web/web.dart' as web;
void main() {
runApp(MyApp());
}
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Platform View Demo',
home: Scaffold(
appBar: AppBar(
title: Text('Platform View Demo'),
),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: [
BoxWrapper('red'),
BoxWrapper(null),
BoxWrapper('blue'),
],
),
),
),
);
}
}
bool isRegistered = false;
class BoxWrapper extends StatelessWidget {
const BoxWrapper(this.cssColor);
final String? cssColor;
void register() {
if (isRegistered) return;
isRegistered = true;
ui_web.platformViewRegistry.registerViewFactory('my-platform-view', (
id, {
Object? params,
}) {
params as String?;
final element = web.document.createElement('div'.toJS) as web.HTMLElement;
element.textContent = 'Platform View'.toJS;
element.style
..lineHeight = '100px'.toJS
..fontSize = '24px'.toJS
..backgroundColor = (params ?? 'pink').toJS
..textAlign = 'center'.toJS;
return element;
});
}
@override
Widget build(BuildContext context) {
register();
return SizedBox(
width: 200,
height: 100,
child: Card(
child: HtmlElementView(
viewType: 'my-platform-view',
creationParams: cssColor,
),
),
);
}
}
```
</details>
Depends on https://github.com/flutter/engine/pull/42255
Part of https://github.com/flutter/flutter/issues/127030
2023-06-15 18:00:25 +00:00
Christopher Fujino
3246808cd2
[flutter_tools] cache flutter sdk version to disk ( #124558 )
...
Fixes https://github.com/flutter/flutter/issues/112833
Most of the actual changes here are in [packages/flutter_tools/lib/src/version.dart](https://github.com/flutter/flutter/pull/124558/files#diff-092e00109d9e1589fbc7c6de750e29a6ae512b2dd44e85d60028953561201605 ), while the rest is largely just addressing changes to the constructor of `FlutterVersion` which now has different dependencies.
This change makes `FlutterVersion` an interface with two concrete implementations:
1. `_FlutterVersionGit` which is mostly the previous implementation, and
2. `_FlutterVersionFromFile` which will read a new `.version.json` file from the root of the repo
The [`FlutterVersion` constructor](https://github.com/flutter/flutter/pull/124558/files#diff-092e00109d9e1589fbc7c6de750e29a6ae512b2dd44e85d60028953561201605R70 ) is now a factory that first checks if `.version.json` exists, and if so returns an instance of `_FlutterVersionFromGit` else it returns the fallback `_FlutterVersionGit` which will end up writing `.version.json` so that we don't need to re-calculate the version on the next invocation.
`.version.json` will be deleted in the bash/batch entrypoints any time we need to rebuild he tool (this will usually be because the user did `flutter upgrade` or `flutter channel`, or manually changed the commit with git).
2023-06-15 00:20:30 +00:00
