Harry Terkelsen
13feba5852
[web] Re-enable text field test now that fix has landed in engine ( #140678 )
...
Re-enables skipped flaky test now that the underlying cause of flakiness (GPU memory leak) has been fixed in the engine and the fix has rolled into the framework.
The fix is here: https://github.com/flutter/engine/pull/49336
Fixes https://github.com/flutter/flutter/issues/137669
2023-12-27 21:45:18 +00:00
Flutter GitHub Bot
30c2346806
Marks Linux_pixel_7pro integration_ui_keyboard_resize to be flaky ( #140646 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro integration_ui_keyboard_resize"
}
-->
Issue link: https://github.com/flutter/flutter/issues/140645
2023-12-27 20:25:09 +00:00
Zachary Anderson
ddb8d1f670
Makes the flutter tool retry on a bad gateway network error from gradle ( #140670 )
...
Seen in https://github.com/flutter/flutter/issues/140643
2023-12-27 20:13:36 +00:00
Bruno Leroux
89f0c69e49
Add custom system-wide text selection toolbar buttons on Android ( #139738 )
...
## Description
This PR adds custom system-wide text selection toolbar buttons on Android.
~~This is a WIP until https://github.com/flutter/flutter/pull/139479 is merged (potential conflicts).~~
## Related Issue
Fixes https://github.com/flutter/flutter/issues/139361
## Tests
Adds 5 tests.
2023-12-27 19:03:29 +00:00
Zachary Anderson
6664dfec2f
Disable random test order in asset_bundle_test.dart ( #140666 )
...
For https://github.com/flutter/flutter/issues/140665
2023-12-27 18:06:31 +00:00
engine-flutter-autoroll
54db730e7a
Roll Flutter Engine from 2c04f3e2af11 to 8256eeb7386d (1 revision) ( #140638 )
...
2c04f3e2af...8256eeb738skia-flutter-autoroll@skia.org Roll Dart SDK from 5084fdc1d98a to a95d7384db93 (1 revision) (flutter/engine#49401 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-27 06:59:22 +00:00
engine-flutter-autoroll
f15364efe4
Roll Flutter Engine from 9c73cad6ae1a to 2c04f3e2af11 (1 revision) ( #140633 )
...
9c73cad6ae...2c04f3e2afskia-flutter-autoroll@skia.org Roll Dart SDK from add161c68e6d to 5084fdc1d98a (1 revision) (flutter/engine#49399 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-27 02:57:40 +00:00
engine-flutter-autoroll
0be1c490fc
Roll Flutter Engine from 38b9f3f96ff6 to 9c73cad6ae1a (1 revision) ( #140630 )
...
38b9f3f96f...9c73cad6ae737941+loic-sharma@users.noreply.github.com [Windows] Move DWM composition status to Windows proc table for mocking (flutter/engine#49397 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-27 00:24:23 +00:00
engine-flutter-autoroll
90c4218283
Roll Flutter Engine from bdf261b536bd to 38b9f3f96ff6 (1 revision) ( #140625 )
...
bdf261b536...38b9f3f96f737941+loic-sharma@users.noreply.github.com [Windows] Remove `PlatformWindow` and `RenderTarget` abstractions (flutter/engine#49312 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-26 20:51:25 +00:00
engine-flutter-autoroll
6c1e11ecc3
Roll Packages from 23d2d9c01366 to fa74d3e1e71a (1 revision) ( #140619 )
...
23d2d9c013...fa74d3e1e7flutter/packages#5747 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-26 15:50:38 +00:00
engine-flutter-autoroll
a86e91f3c4
Roll Flutter Engine from 8b839eda79d4 to bdf261b536bd (1 revision) ( #140611 )
...
8b839eda79...bdf261b536skia-flutter-autoroll@skia.org Roll Dart SDK from cf2d9652297b to add161c68e6d (1 revision) (flutter/engine#49390 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-26 02:47:35 +00:00
engine-flutter-autoroll
02d1d64e7f
Roll Flutter Engine from deac5607d000 to 8b839eda79d4 (1 revision) ( #140570 )
...
deac5607d0...8b839eda79skia-flutter-autoroll@skia.org Roll Dart SDK from c1f9520b30d7 to cf2d9652297b (1 revision) (flutter/engine#49382 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-23 15:02:06 +00:00
engine-flutter-autoroll
cd718db732
Roll Flutter Engine from 5981a3c68e70 to deac5607d000 (1 revision) ( #140555 )
...
5981a3c68e...deac5607d0skia-flutter-autoroll@skia.org Roll Dart SDK from 25961234c1bc to c1f9520b30d7 (1 revision) (flutter/engine#49376 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-23 02:40:08 +00:00
engine-flutter-autoroll
29d42dde2f
Roll Flutter Engine from 0476141a016f to 5981a3c68e70 (1 revision) ( #140552 )
...
0476141a01...5981a3c68eskia-flutter-autoroll@skia.org Roll Dart SDK from eec6568c209f to 25961234c1bc (1 revision) (flutter/engine#49373 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 22:48:25 +00:00
engine-flutter-autoroll
4bc7a44eb6
Roll Packages from 4c3bc496bed2 to 23d2d9c01366 (6 revisions) ( #140550 )
...
4c3bc496be...23d2d9c013flutter/packages#5737 )
2023-12-21 54558023+keyonghan@users.noreply.github.com Disable `presubmit: false` targets for recipes CQ (flutter/packages#5735 )
2023-12-21 47866232+chunhtai@users.noreply.github.com [go_router] Refactored RouteMatchList and imperative APIs (flutter/packages#5497 )
2023-12-21 54558023+keyonghan@users.noreply.github.com Add env_variables in ci.yaml (flutter/packages#5730 )
2023-12-21 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2e9cb0aa71a3 to 78666c8dc57e (1 revision) (flutter/packages#5734 )
2023-12-21 engine-flutter-autoroll@skia.org Roll Flutter from da0cd69659c5 to 11def8eff455 (16 revisions) (flutter/packages#5732 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 19:02:40 +00:00
engine-flutter-autoroll
bba4c1f937
Roll Flutter Engine from 5448105a76f7 to 0476141a016f (1 revision) ( #140549 )
...
5448105a76...0476141a01skia-flutter-autoroll@skia.org Roll Dart SDK from 151b363886f9 to eec6568c209f (1 revision) (flutter/engine#49369 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 18:20:38 +00:00
Reid Baker
48ae5ff6f6
Use double quotes over single quotes in gradle build files ( #140512 )
...
Following https://developer.android.com/build/migrate-to-kotlin-dsl
2/n Use double quotes instead of single quotes.
Should be a no-op change. If you see a behavioral change please flag it.
2023-12-22 16:25:06 +00:00
engine-flutter-autoroll
ede594f881
Roll Flutter Engine from a8da67fed23b to 5448105a76f7 (1 revision) ( #140540 )
...
a8da67fed2...5448105a76skia-flutter-autoroll@skia.org Roll Dart SDK from 69423a5dd254 to 151b363886f9 (1 revision) (flutter/engine#49357 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 10:11:17 +00:00
engine-flutter-autoroll
6126e4b4a4
Roll Flutter Engine from 1ba8fc0765f9 to a8da67fed23b (1 revision) ( #140536 )
...
1ba8fc0765...a8da67fed2skia-flutter-autoroll@skia.org Roll Dart SDK from fe94d9b88531 to 69423a5dd254 (1 revision) (flutter/engine#49354 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 06:14:20 +00:00
engine-flutter-autoroll
8024c5e4d4
Roll Flutter Engine from 737e6f8ce85e to 1ba8fc0765f9 (4 revisions) ( #140531 )
...
737e6f8ce8...1ba8fc0765dnfield@google.com Fix GetImpellerContext for ShellTestPlatformViewGL (flutter/engine#49337 )
2023-12-21 flar@google.com [Impeller] Remove use of private Rect fields from PathBuilder (flutter/engine#49334 )
2023-12-21 flar@google.com [Impeller] Do not skip rendering when mask blur is zero (flutter/engine#49342 )
2023-12-21 737941+loic-sharma@users.noreply.github.com [Windows] Fix incorrect surface manager comment (flutter/engine#49335 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 02:09:25 +00:00
godofredoc
c73bffe747
Migrate verify_codesigned. ( #139328 )
...
This is part of the migration of adhoc tests to shard tests.
Bug: https://github.com/flutter/flutter/issues/139153
2023-12-22 01:46:11 +00:00
Yegor
c02ace6b48
[web] unskip canvaskit tests that pass now ( #140480 )
...
Unskip a few CanvasKit tests that pass now.
2023-12-22 01:02:12 +00:00
engine-flutter-autoroll
08e58bab92
Roll Flutter Engine from 1b1b2a12a597 to 737e6f8ce85e (5 revisions) ( #140527 )
...
1b1b2a12a5...737e6f8ce8skia-flutter-autoroll@skia.org Roll Dart SDK from bcf68d22f0fa to fe94d9b88531 (1 revision) (flutter/engine#49343 )
2023-12-21 1961493+harryterkelsen@users.noreply.github.com Reland "[web] Enforce onDrawFrame/onBeginFrame render rule" (flutter/engine#49336 )
2023-12-21 magder@google.com Turn on scenario app screenshots (flutter/engine#49066 )
2023-12-21 chris@bracken.jp Revert onrender change (flutter/engine#49333 )
2023-12-21 yjbanov@google.com [web] autofocus in new routes (flutter/engine#47727 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-22 00:07:42 +00:00
engine-flutter-autoroll
b417fb828b
Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions) ( #140519 )
...
Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions)
c70f0a495a...1b1b2a12a5skia-flutter-autoroll@skia.org Roll Dart SDK from 4a10533a4dc8 to bcf68d22f0fa (1 revision) (flutter/engine#49329 )
2023-12-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1d0c3ecd1349 to 4a10533a4dc8 (1 revision) (flutter/engine#49326 )
2023-12-21 flar@google.com Ensure sorted rects in ui.Canvas for legacy compatibility (flutter/engine#49309 )
2023-12-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 63a452b45026 to 1d0c3ecd1349 (1 revision) (flutter/engine#49318 )
2023-12-21 dnfield@google.com [Impeller] Make IPLR files multi-platform (flutter/engine#49253 )
2023-12-21 ditman@gmail.com [web] Defer injection of platform views until needed. (flutter/engine#48960 )
2023-12-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1aef027ec953 to 63a452b45026 (2 revisions) (flutter/engine#49311 )
2023-12-21 skia-flutter-autoroll@skia.org Roll Skia from 29917d8c97ca to 4b16117e94b2 (4 revisions) (flutter/engine#49310 )
2023-12-21 737941+loic-sharma@users.noreply.github.com Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49262 )
2023-12-21 30870216+gaaclarke@users.noreply.github.com Reland `[Impeller] new blur: refactored math and fixed expanded padding size` (flutter/engine#49302 )
2023-12-20 dkwingsmt@users.noreply.github.com Multiview pipeline Pt. 1: Skip illegal render calls (flutter/engine#49266 )
2023-12-20 barpac02@gmail.com SemanticsUpdateBuilder: make all args non-null (flutter/engine#49148 )
2023-12-20 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed Rect::Contains (flutter/engine#49294 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 97c3b7e1885a to 1aef027ec953 (1 revision) (flutter/engine#49295 )
2023-12-20 30870216+gaaclarke@users.noreply.github.com Revert "[Impeller] new blur: refactored math and fixed expanded padding size" (flutter/engine#49298 )
2023-12-20 30870216+gaaclarke@users.noreply.github.com [Impeller] new blur: refactored math and fixed expanded padding size (flutter/engine#49206 )
2023-12-20 dkwingsmt@users.noreply.github.com Multi-view pointer event (flutter/engine#46213 )
2023-12-20 1961493+harryterkelsen@users.noreply.github.com [web:multiview] Only call `Renderer.clearFragmentProgramCache` on hot restart (flutter/engine#48758 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Skia from 9cb1bb1164ea to 29917d8c97ca (1 revision) (flutter/engine#49289 )
2023-12-20 bdero@google.com [Impeller] Add interactive Blur+Clip AiksTest. (flutter/engine#49283 )
2023-12-20 sergiy.dubovik@supercell.com [macos] FlutterKeyboardManager memory leak fix (flutter/engine#48824 )
2023-12-20 zanderso@users.noreply.github.com Don't guard Windows arm64 Dart SDK download on the release candidate flag (flutter/engine#49244 )
2023-12-20 15619084+vashworth@users.noreply.github.com Fix testAppExtensionLaunching for Xcode 15/iOS 17 (flutter/engine#49242 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Skia from 8060d6b36066 to 9cb1bb1164ea (2 revisions) (flutter/engine#49288 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from ed415d966d8a to 97c3b7e1885a (1 revision) (flutter/engine#49287 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Skia from d0f09ad481f7 to 8060d6b36066 (1 revision) (flutter/engine#49285 )
2023-12-20 kevinjchisholm@gmail.com [release] Update release config (flutter/engine#49254 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 1732c4c92ccd to ed415d966d8a (1 revision) (flutter/engine#49274 )
2023-12-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 4c59838945d9 to 1732c4c92ccd (1 revision) (flutter/engine#49269 )
2023-12-20 goderbauer@google.com Sync lints with flutter/flutter (flutter/engine#49192 )
2023-12-19 1961493+harryterkelsen@users.noreply.github.com [web] Enforce onDrawFrame/onBeginFrame render rule (flutter/engine#49214 )
2023-12-19 barpac02@gmail.com [Docs] Add more info about running tests on iOS (flutter/engine#48859 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
2023-12-21 22:55:07 +00:00
flutter-pub-roller-bot
9c2a756009
Roll pub packages ( #140525 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-12-21 22:13:24 +00:00
Victoria Ashworth
2da1ff2d93
Run mac staging tests with Xcode 15 ( #140518 )
...
Run macOS staging tests with Xcode 15 and macOS 13. Also, cleanup some comments.
2023-12-21 22:01:14 +00:00
Ian Hickson
62f1594908
Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal ( #140101 )
...
Originally landed in https://github.com/flutter/flutter/pull/139549
Originally reverted in https://github.com/flutter/flutter/pull/140085
- Remove all use of global variables.
- Always pass in all dependencies, only create them in main or in tests.
- Pass in the "print" primitive.
- Make all network traffic retry (except when run locally, when it just auto-passes).
- Enable tests to be run in random order.
- Better error messages
2023-12-21 21:35:07 +00:00
Andrew Kolos
9e104eb7c8
Fix flavor conditional asset bundling for macos ( #140433 )
...
Fixes https://github.com/flutter/flutter/issues/140430
Fixes https://github.com/flutter/flutter/issues/140432 while we are at it
2023-12-21 20:30:21 +00:00
Gray Mackall
a3e0fa56a3
Enable android_preview_tool_integration_tests check ( #140470 )
...
Enables the check that was added in https://github.com/flutter/flutter/pull/131901 .
Has been passing since https://github.com/flutter/flutter/pull/140099 (30 runs). Not sure what the normal number of successful runs we wait for is before enabling, let me know if we should wait for more data.
2023-12-21 19:20:43 +00:00
Christopher Fujino
674fbd26bc
[flutter_tools] Ensure flutter daemon clients can detect preview device ( #140112 )
...
Part of https://github.com/flutter/flutter/issues/130277
2023-12-21 19:01:16 +00:00
Non Vachara
90badf7050
Add send_text_input_action case to deserialization_factory to allow sendTextInputAction usages through flutter_driver. ( #139197 )
...
**As a follow up to https://github.com/flutter/flutter/pull/131776 .**
**Summary:**
Previously in https://github.com/flutter/flutter/pull/106561 , SendTextInputAction was added to Flutter Driver.
But it still cannot be used from flutter_driver tests. This PR intends to resolve that issue.
**Issue:**
An `DriverError: Unsupported command kind send_text_input_action` would be thrown from `flutter_driver/lib/src/common/deserialization_factory.dart` when a call to `driver.sendTextInputAction(TextInputAction.done);` was made despite the method `sendTextInputAction` is available for use since https://github.com/flutter/flutter/pull/106561 .
Previous works has been done in https://github.com/flutter/flutter/pull/131776 , I merely added tests.
Best regards.
2023-12-21 17:48:16 +00:00
auto-submit[bot]
cb50d4a804
Reverts "[web] Re-enable test now that source of flakiness is fixed" ( #140515 )
...
Reverts flutter/flutter#140462
Initiated by: cbracken
This change reverts the following previous change:
Original Description:
The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here https://github.com/flutter/engine/pull/49214
Fixes https://github.com/flutter/flutter/issues/137669
As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.
2023-12-21 17:46:16 +00:00
Gustl22
f5ac225c8d
Reland: "Fix how Gradle resolves Android plugin" ( #137115 )
...
Relands #97823
When the tool migrated to `.flutter-plugins-dependencies`, the Gradle plugin was never changed.
Until now, the plugin had the heuristic that a plugin with a `android/build.gradle` file supported the Android platform.
Also applies schema of `getPluginDependencies` to `getPluginList` which uses a `List` of Object instead of `Properties`.
Fixes #97729
Cause of the error: 5f105a6ca7/packages/flutter_tools/gradle/flutter.gradle (L421C25-L421C25)Fixes #98048
The deprecated line `include ":$name"` in `settings.gradle` (pluginEach) in old projects causes the `project.rootProject.findProject` to also find the plugin "project", so it is not failing on the `afterEvaluate` method. But the plugin shouldn't be included in the first place as it fails with `Could not find method implementation() for arguments` error in special cases.
Related to #48918 , see [_writeFlutterPluginsListLegacy](27bc1cf61a/packages/flutter_tools/lib/src/flutter_plugins.dart (L248)
2023-12-21 16:55:04 +00:00
engine-flutter-autoroll
430254e13b
Roll Packages from dc5b267f3cd1 to 4c3bc496bed2 (1 revision) ( #140511 )
...
dc5b267f3c...4c3bc496be15619084+vashworth@users.noreply.github.com Remove workarounds for `check_podspecs` needed for older version of Cocoapods (flutter/packages#5724 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-21 15:44:08 +00:00
Michael Thomsen
11def8eff4
Update README.md ( #140382 )
...
Update the "fast results" subsection of readme with recent developments.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Parker Lougheed <parlough@gmail.com>
2023-12-21 13:03:09 +01:00
Jim Graham
8407dd2d0e
Revert "Integrate testWidgets with leak tracking. ( #138057 )" ( #140502 )
...
The PR is breaking the `flutter_test_performance` test and making the
tree red.
2023-12-21 12:44:58 +01:00
Polina Cherkasova
d746007fcd
Integrate testWidgets with leak tracking. ( #138057 )
...
Contributes to: https://github.com/flutter/flutter/issues/135856
TODO:
2023-12-21 00:19:59 +00:00
Qun Cheng
c0acd8c45f
Fix import pattern ( #140425 )
...
This PR is just to fix the import pattern to follow the convention.
2023-12-21 00:18:09 +00:00
godofredoc
cf3760bce0
Update job permissions ( #140476 )
...
Updates to use contents: write and pull-requests: write.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-12-20 14:59:24 -08:00
flutter-pub-roller-bot
2d75f76b44
Roll pub packages ( #140472 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-12-20 22:57:21 +00:00
Michael Goderbauer
68e346e41c
Remove outdated ignores from tool ( #140467 )
...
These were not ignoring anything (anymore).
2023-12-20 22:14:32 +00:00
Michael Goderbauer
c4fda23393
Remove outdated ignores from framework ( #140465 )
...
These were not ignoring anything (anymore).
2023-12-20 22:05:29 +00:00
LongCatIsLooong
e2e8bcb1bc
Reland find.textRange.ofSubstring changes ( #140469 )
...
Extracted from https://github.com/flutter/flutter/pull/139717 as-is. Landing this change first so we can avoid doing a g3fix.
2023-12-20 22:00:55 +00:00
Reid Baker
d6e435a7ac
Part 1/n migration steps for kotlin migration ( #140452 )
...
Following https://developer.android.com/build/migrate-to-kotlin-dsl
1/n Add parentheses to method calls
Should be a no-op change. If you see a behavioral change please flag it.
2023-12-20 20:40:17 +00:00
auto-submit[bot]
9003f13803
Reverts "Make TextSpan hit testing precise." ( #140468 )
...
Reverts flutter/flutter#139717
Initiated by: LongCatIsLooong
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/131435 , #104594 , #43400
Needs https://github.com/flutter/engine/pull/48774 (to fix the web test failure).
Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.
The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds.
Potential issues:
1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference.
This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.
2023-12-20 19:32:10 +00:00
Harry Terkelsen
11bfb3c46a
[web] Re-enable test now that source of flakiness is fixed ( #140462 )
...
The test was flaky before due to overflowing GPU memory during the test.
The memory leak was fixed here
https://github.com/flutter/engine/pull/49214
Fixes https://github.com/flutter/flutter/issues/137669
As a side effect of the fix, this test also runs much faster, from about
3 minutes on my Macbook down to about 25 seconds.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-12-20 11:11:56 -08:00
Chris Bracken
7b0bfa8c61
Eliminate Cirrus build status badge ( #140461 )
...
We have no tasks running on Cirrus any more. This eliminates the "Build
Status - Cirrus" badge/link as well as the "Build status" link
reference, which was unused.
@CaseyHillers has filed a bug to add a Cocoon endpoint to replace it:
https://github.com/flutter/flutter/issues/140460
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-12-20 10:58:32 -08:00
Zachary Anderson
76c8e7387b
Move tests shifted to Pixel 7 from staging to prod ( #140438 )
2023-12-20 18:57:40 +00:00
engine-flutter-autoroll
0dc3b072c1
Roll Packages from be52ac86bb4f to dc5b267f3cd1 (5 revisions) ( #140450 )
...
be52ac86bb...dc5b267f3cengine-flutter-autoroll@skia.org Roll Flutter from 0eb788134051 to da0cd69659c5 (15 revisions) (flutter/packages#5729 )
2023-12-20 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5702 )
2023-12-19 jsharp83@gmail.com [webview_flutter] Implement platform interface for JavaScript dialog (flutter/packages#5670 )
2023-12-19 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (iOS) (flutter/packages#5455 )
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter from cdc83e5ebae4 to 0eb788134051 (17 revisions) (flutter/packages#5722 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-20 17:33:18 +00:00
Bruno Leroux
0d90014bae
_TabBarViewState should not recreate page controller ( #135500 )
...
## Description
This PR replaces the unconditional instantiation of `PageController` in `_TabBarViewState.didChangeDependencies` as suggested in https://github.com/flutter/flutter/pull/134091#discussion_r1319177744 .
## Related Issue
Fixes https://github.com/flutter/flutter/issues/134253 .
## Tests
Adds 1 test.
2023-12-20 17:04:29 +00:00
