Gustl22
da0cd69659
Revert automated changes made to deprecated settings.gradle (plugins.each) ( #140037 )
...
Restore testing deprecated settings.gradle (plugins.each).
Updated presumably by accident in #83067
Split from #137115
See also https://github.com/flutter/flutter/pull/137115#issuecomment-1781909865
2023-12-20 15:45:08 +00:00
Xilai Zhang
62d699961f
[github actions] change minimal example workflow to be manually dispatched ( #140435 )
...
This would allow easier testing of the minimal example.
Might need Github Admin power to trigger the manual dispatches.
2023-12-20 04:59:27 +00:00
LongCatIsLooong
ea5b97286e
Make TextSpan hit testing precise. ( #139717 )
...
Fixes https://github.com/flutter/flutter/issues/131435 , #104594 , #43400
Needs https://github.com/flutter/engine/pull/48774 (to fix the web test failure).
Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.
The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds.
Potential issues:
1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference.
This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.
2023-12-20 03:23:29 +00:00
Xilai Zhang
e86b825819
[github actions] add minimal workflow to test token ( #140363 )
...
Add a workflow that simply:
1. checkout repo
2. write a file
3. create a PR
This is used to verify the permissions and validity of the github token we use to create PR.
context: https://chat.google.com/room/AAAAc_4rqiI/Ck593Sg7mvs
If we think the triggering condition is complicated, I can also change this workflow to be manual dispatch, to make it truly minimal.
2023-12-20 01:18:07 +00:00
engine-flutter-autoroll
18db55b4e5
Roll Flutter Engine from 5279873a8635 to c70f0a495ace (2 revisions) ( #140431 )
...
5279873a86...c70f0a495askia-flutter-autoroll@skia.org Roll Skia from 48f959a857da to d0f09ad481f7 (3 revisions) (flutter/engine#49264 )
2023-12-19 dkwingsmt@users.noreply.github.com Revert "Reland 2: Multiview Pipeline (#47239 )" (flutter/engine#49238 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-20 00:55:24 +00:00
engine-flutter-autoroll
0ae9260111
Roll Flutter Engine from df1593e96a6b to 5279873a8635 (2 revisions) ( #140428 )
...
df1593e96a...5279873a86skia-flutter-autoroll@skia.org Roll Dart SDK from e8cdc554c598 to 4c59838945d9 (2 revisions) (flutter/engine#49261 )
2023-12-19 flar@google.com Make sure run_tests.py runs dart tests on Skia (flutter/engine#49260 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-20 00:16:15 +00:00
Christopher Fujino
ef1227f05d
[flutter_tools] handle FileSystemException trying to delete temp directory from core_devices.dart ( #140415 )
...
Fixes https://github.com/flutter/flutter/issues/140416 , the top crasher on stable/3.16.4
2023-12-20 00:08:54 +00:00
Zachary Anderson
ea6017ded8
Move hybrid_android_views_integration_test back to Moto G4 ( #140421 )
...
Related https://github.com/flutter/flutter/issues/140420
2023-12-19 23:44:10 +00:00
engine-flutter-autoroll
8316e8512f
Roll Flutter Engine from 3b156c8ce9bd to df1593e96a6b (2 revisions) ( #140422 )
...
3b156c8ce9...df1593e96azanderso@users.noreply.github.com Rolls clang to 725656bdd885483c39f482a01ea25d67acf39c46 (flutter/engine#49248 )
2023-12-19 aam@google.com Roll dart to 3.3.0-242.0.dev (flutter/engine#49239 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 23:36:20 +00:00
Fedor Blagodyr
2bb19a9501
Added onEnd callback into AnimatedSize ( #139859 )
...
close #106439
2023-12-19 22:59:46 +00:00
engine-flutter-autoroll
5a5683ddd7
Roll Flutter Engine from 3f45f9db4471 to 3b156c8ce9bd (1 revision) ( #140413 )
...
3f45f9db44...3b156c8ce9skia-flutter-autoroll@skia.org Roll Skia from df1a7ccbdc97 to 48f959a857da (1 revision) (flutter/engine#49255 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 22:37:56 +00:00
engine-flutter-autoroll
1fd5d87e54
Roll Flutter Engine from 187334c39b44 to 3f45f9db4471 (3 revisions) ( #140412 )
...
187334c39b...3f45f9db44skia-flutter-autoroll@skia.org Roll Skia from 541f16af8b3e to df1a7ccbdc97 (3 revisions) (flutter/engine#49250 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 0d39fb28b32d to 541f16af8b3e (1 revision) (flutter/engine#49246 )
2023-12-19 john@johnmccutchan.com Use new SurfaceProducer external texture class for rendering platform views (flutter/engine#49201 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 21:54:13 +00:00
Victoria Ashworth
6981fe6fd3
Remove workarounds for plugin_lint_mac needed for older version of Cocoapods ( #140395 )
...
CI has been updated to Cocoapods 1.13, which fixes previous issues with the `plugin_lint_mac` test. Remove workarounds added previously.
Fixes https://github.com/flutter/flutter/issues/125812 .
See also https://github.com/flutter/flutter/issues/133584 .
2023-12-19 20:19:52 +00:00
engine-flutter-autoroll
b14d7452ef
Roll Flutter Engine from b87a782ce3a3 to 187334c39b44 (2 revisions) ( #140398 )
...
b87a782ce3...187334c39bskia-flutter-autoroll@skia.org Roll Skia from 22dad95c218f to 0d39fb28b32d (2 revisions) (flutter/engine#49241 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 6496c9c5866a to 22dad95c218f (4 revisions) (flutter/engine#49237 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 19:26:05 +00:00
engine-flutter-autoroll
837ba40937
Roll Flutter Engine from 1d5a141917fa to b87a782ce3a3 (1 revision) ( #140390 )
...
1d5a141917...b87a782ce3skia-flutter-autoroll@skia.org Roll Skia from ed0148ab400d to 6496c9c5866a (6 revisions) (flutter/engine#49234 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 17:42:58 +00:00
Zachary Anderson
0eb7881340
Shift some Linux-hosted tests on moto g4 to pixel 7 ( #140389 )
2023-12-19 09:30:03 -08:00
Bartek Pacia
a1e1dc3f6c
Reland "Warn when Gradle plugins are applied using the legacy apply script method ( #140103 )
...
> This PR relands #139690 which was reverted in #140102
This PR adds a deprecation message when Android build is using the legacy "apply script method" way of applying Flutter's Gradle plugins (that is: [`flutter.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/flutter.gradle ) and [`app_plugin_loader.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/app_plugin_loader.gradle )).
See also:
- #121541
- in particular https://github.com/flutter/flutter/issues/121541#issuecomment-1836947311
- #135392
- and PR that add the migration guide: [#9857 ](https://github.com/flutter/website/pull/9857 )
- I think either `logger.error` or `logger.quiet` must be used, because all other error levels are not shown during `flutter build apk` (and that's what most people use).
2023-12-19 16:03:23 +00:00
engine-flutter-autoroll
df6781358e
Roll Packages from d7dee796f3c8 to be52ac86bb4f (1 revision) ( #140386 )
...
d7dee796f3...be52ac86bbengine-flutter-autoroll@skia.org Roll Flutter from 2407f699e935 to cdc83e5ebae4 (28 revisions) (flutter/packages#5715 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 15:44:24 +00:00
engine-flutter-autoroll
bbfe177dc9
Roll Flutter Engine from bde7c612f6ba to 1d5a141917fa (3 revisions) ( #140371 )
...
bde7c612f6...1d5a141917skia-flutter-autoroll@skia.org Roll Skia from c12c2a174327 to ed0148ab400d (1 revision) (flutter/engine#49222 )
2023-12-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.0.0 (flutter/engine#49220 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 27ab8a8d2a0d to c12c2a174327 (1 revision) (flutter/engine#49218 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 10:48:01 +00:00
engine-flutter-autoroll
51633fe95c
Roll Flutter Engine from 42af8f106206 to bde7c612f6ba (2 revisions) ( #140367 )
...
42af8f1062...bde7c612f6academy3746@gmail.com Makes PlatformViewsController view to use tracked event's action & pointer count (flutter/engine#47424 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 37a60129e019 to 27ab8a8d2a0d (1 revision) (flutter/engine#49213 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 07:35:27 +00:00
engine-flutter-autoroll
2ed0df8405
Roll Flutter Engine from bbfee6f59b42 to 42af8f106206 (1 revision) ( #140362 )
...
bbfee6f59b...42af8f1062skia-flutter-autoroll@skia.org Roll Skia from e5b0cdc11992 to 37a60129e019 (1 revision) (flutter/engine#49212 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 04:48:25 +00:00
Polina Cherkasova
6368d65622
Upgrade to version of leak tracker that does not depend on test_widgets. ( #140247 )
...
Contributes to: https://github.com/flutter/flutter/issues/135856
2023-12-19 04:28:09 +00:00
engine-flutter-autoroll
cc4b3293fb
Roll Flutter Engine from 632103f787ba to bbfee6f59b42 (4 revisions) ( #140359 )
...
632103f787...bbfee6f59bskia-flutter-autoroll@skia.org Roll Skia from fff421ff633e to e5b0cdc11992 (4 revisions) (flutter/engine#49210 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 63bed826008e to fff421ff633e (1 revision) (flutter/engine#49208 )
2023-12-19 godofredoc@google.com Double timeout on mac builds. (flutter/engine#49205 )
2023-12-18 flar@google.com [Impeller] Make Rect origin and size fields private (flutter/engine#49168 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 03:13:09 +00:00
engine-flutter-autoroll
0d775705e6
Roll Flutter Engine from 92d88c7e4e9a to 632103f787ba (9 revisions) ( #140350 )
...
92d88c7e4e...632103f787matej.knopp@gmail.com Convert chromium wheel delta to physical pixels on macOS (flutter/engine#49028 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 3de801338767 to 63bed826008e (1 revision) (flutter/engine#49200 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from ff7e92c7886d to b21443096387 (1 revision) (flutter/engine#49199 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 83f8fe8bbcee to 3de801338767 (2 revisions) (flutter/engine#49195 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 10e7ee119ea9 to 83f8fe8bbcee (1 revision) (flutter/engine#49193 )
2023-12-18 barpac02@gmail.com Delete `SemanticsUpdateBuilderNew` and all references and usages (flutter/engine#49139 )
2023-12-18 chinmaygarde@google.com Opt into unstable libcxx ABI and add a custom namespace. (flutter/engine#49002 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 4b2639427e7e to 10e7ee119ea9 (10 revisions) (flutter/engine#49191 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from e1a26302800d to ff7e92c7886d (1 revision) (flutter/engine#49185 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 23:22:26 +00:00
Bartek Pacia
a4388773bb
SemanticsProperties: default identifier and tooltip to null ( #140283 )
...
This PR applies [the suggestion made here](https://github.com/flutter/devtools/pull/6942#issuecomment-1852773200 ).
2023-12-18 19:38:05 +00:00
Simon Friis Vindum
b893884f50
Document difference between softWrap and maxLine ( #139363 )
...
This PR fixes #13631 through documentation as suggested in https://github.com/flutter/flutter/issues/13631#issuecomment-354902727 .
Since the documentation additions rely on new screenshots this PR will be accompanied by a PR in the assets repository.
2023-12-18 19:09:07 +00:00
engine-flutter-autoroll
008ecd8c9e
Roll Flutter Engine from 2dc18738167e to 92d88c7e4e9a (1 revision) ( #140332 )
...
2dc1873816...92d88c7e4eskia-flutter-autoroll@skia.org Roll Skia from 290fefdef726 to 4b2639427e7e (1 revision) (flutter/engine#49183 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 18:23:26 +00:00
Gray Mackall
bdfb56cee2
Only run dart files as a test in the Android preview tools test shard ( #140099 )
...
I added a README at the end of https://github.com/flutter/flutter/pull/131901 and did not realize that it was being run as a test, [leading to test failures (of course)](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8761789207346423409/+/u/run_test.dart_for_android_preview_tool_integration_tests_shard_and_subshard_None/test_stdout ). This makes it so we only run dart files as dart tests.
2023-12-18 18:17:25 +00:00
engine-flutter-autoroll
a17e2e0859
Roll Flutter Engine from e4fa972d70cb to 2dc18738167e (1 revision) ( #140328 )
...
e4fa972d70...2dc1873816skia-flutter-autoroll@skia.org Roll Skia from 276075b97567 to 290fefdef726 (1 revision) (flutter/engine#49180 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 17:29:21 +00:00
engine-flutter-autoroll
7b7aa6a9a3
Roll Flutter Engine from d7f0803dd6af to e4fa972d70cb (1 revision) ( #140324 )
...
d7f0803dd6...e4fa972d70mdebbar@google.com [web] Set cursor property on body (flutter/engine#49098 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 16:43:26 +00:00
engine-flutter-autoroll
63753d4a0e
Roll Packages from 3f2e16bf2b17 to d7dee796f3c8 (5 revisions) ( #140322 )
...
3f2e16bf2b...d7dee796f3tarrinneal@gmail.com Remove flutter api named and optional parameters (flutter/packages#5689 )
2023-12-15 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from b0366e0a3f08 to 2e9cb0aa71a3 (4 revisions) (flutter/packages#5692 )
2023-12-15 mikemcguiness@protonmail.com [extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in ⦠(flutter/packages#5496 )
2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter from a51e33ac76e4 to 2407f699e935 (30 revisions) (flutter/packages#5691 )
2023-12-15 davidmartos96@gmail.com [google_sign_in_ios] Move pigeon as a dev dependency (flutter/packages#5685 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 15:45:36 +00:00
engine-flutter-autoroll
83236fdf8f
Roll Flutter Engine from 7f1a81d5545a to d7f0803dd6af (2 revisions) ( #140320 )
...
7f1a81d554...d7f0803dd6skia-flutter-autoroll@skia.org Roll Skia from 74e6a355f208 to 276075b97567 (1 revision) (flutter/engine#49177 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from c8106261c9cd to e1a26302800d (1 revision) (flutter/engine#49178 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 15:08:42 +00:00
engine-flutter-autoroll
cdc83e5eba
Roll Flutter Engine from b3de65a6d3ea to 7f1a81d5545a (1 revision) ( #140309 )
...
b3de65a6d3...7f1a81d554skia-flutter-autoroll@skia.org Roll Skia from d4b1cc5122f9 to 74e6a355f208 (1 revision) (flutter/engine#49171 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 09:02:05 +00:00
raphire08
4659b0c402
refactored cli tool ipa method name to support --export-options-plist ( #138555 )
...
This PR changes the way the IPA method is read in the run command for `build ipa` command. If export options plist argument is provided it takes method name from plist, otherwise it uses the method name from export method argument.
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
fixes [#122179 ](https://github.com/flutter/flutter/issues/122179 )
2023-12-18 08:56:07 +00:00
Andrew Kolos
f8b9748661
Restore and fix flavors_test_macos ( #139841 )
...
Partially resolves[^1] https://github.com/flutter/flutter/issues/139774 .
Effectively reverts https://github.com/flutter/flutter/pull/125581 .
The main change here is that I deleted and recreated the macos Xcode project for this integration test (hence the large diff). I tried fixing the existing project first, but it was set up quite differently, andâfor whatever reasonâthe integration test would get stuck trying to load `dev/integration_tests/flavors/integration_test/integration_test.dart`.
I verified that this works locally, but I don't know if it's possible to run this on the devicelab try pool to verify that it works on devicelab hardware.
[^1]: I would not close the issue until 1) this PR lands, 2) the integration test consistently passes on CI, and 3) macOS support for flavors is publicly documented.
2023-12-18 08:52:22 +00:00
engine-flutter-autoroll
79bc6ded40
Roll Flutter Engine from 626c93260f79 to b3de65a6d3ea (1 revision) ( #140308 )
...
626c93260f...b3de65a6d3skia-flutter-autoroll@skia.org Roll Skia from e40b61c3dfef to d4b1cc5122f9 (2 revisions) (flutter/engine#49169 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 08:09:13 +00:00
engine-flutter-autoroll
32d42b63de
Roll Flutter Engine from f9c7aa27f13a to 626c93260f79 (1 revision) ( #140291 )
...
f9c7aa27f1...626c93260fskia-flutter-autoroll@skia.org Roll Skia from 6598d8b28c51 to e40b61c3dfef (1 revision) (flutter/engine#49154 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-17 12:39:25 +00:00
engine-flutter-autoroll
b167f065fd
Roll Flutter Engine from 726a137e3f99 to f9c7aa27f13a (1 revision) ( #140289 )
...
726a137e3f...f9c7aa27f1skia-flutter-autoroll@skia.org Roll Skia from 49cfb91d353f to 6598d8b28c51 (1 revision) (flutter/engine#49153 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-17 10:44:17 +00:00
engine-flutter-autoroll
7bacc5613a
Roll Flutter Engine from c5fc179cf0b3 to 726a137e3f99 (1 revision) ( #140280 )
...
c5fc179cf0...726a137e3fmatej.knopp@gmail.com Add FlutterMetalLayer as optional alternative to CAMetalLayer (flutter/engine#48226 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-16 22:24:07 +00:00
engine-flutter-autoroll
2e7412af92
Roll Flutter Engine from a8d8fbbcef22 to c5fc179cf0b3 (1 revision) ( #140277 )
...
a8d8fbbcef...c5fc179cf0skia-flutter-autoroll@skia.org Roll Skia from 35d0d7eb991c to 49cfb91d353f (1 revision) (flutter/engine#49141 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-16 19:23:13 +00:00
Bruno Leroux
596d9b6c1a
Center Floating Snackbar with custom width when direction is RTL ( #140215 )
...
## Description
This PR fixes the positionning of a floating snackbar when the text direction is RTL.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/140125 .
## Tests
Adds 1 test.
2023-12-16 19:23:11 +00:00
engine-flutter-autoroll
c1e207d6ac
Roll Flutter Engine from 6752398c2f54 to a8d8fbbcef22 (1 revision) ( #140274 )
...
6752398c2f...a8d8fbbcefskia-flutter-autoroll@skia.org Roll Skia from d231faf34f8a to 35d0d7eb991c (1 revision) (flutter/engine#49137 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-16 17:32:25 +00:00
Bartek Pacia
8c02a22403
Use SemanticsUpdateBuilder again, remove all references to temporary SemanticsUpdateBuilderNew ( #139942 )
...
This PR removes all usages of the temporary `SemanticsUpdateBuilderNew` API in favor of `SemanticsUpdateBuilder`. These two APIs are the same as of now.
This is mainly targeted at https://github.com/flutter/flutter/issues/17988
Steps:
part 1: [engine] add `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/47961
part 2: [flutter] use `SemanticsUpdateBuilderNew` https://github.com/flutter/flutter/pull/138331
part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/48882
**part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again** <-- we are here
part 5: [engine] remove `SemanticsBuilderNew`
2023-12-16 15:23:24 +00:00
engine-flutter-autoroll
3958b3d5ff
Roll Flutter Engine from 7d300e5b9587 to 6752398c2f54 (1 revision) ( #140270 )
...
7d300e5b95...6752398c2fskia-flutter-autoroll@skia.org Roll Skia from 01aa69c38af5 to d231faf34f8a (1 revision) (flutter/engine#49134 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-16 11:37:36 +00:00
engine-flutter-autoroll
0c6850dd78
Roll Flutter Engine from 832238a3b493 to 7d300e5b9587 (1 revision) ( #140268 )
...
832238a3b4...7d300e5b95skia-flutter-autoroll@skia.org Roll Dart SDK from 620976ef6b80 to c8106261c9cd (1 revision) (flutter/engine#49131 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-16 09:52:21 +00:00
engine-flutter-autoroll
8b4ece261b
Roll Flutter Engine from 34d427aa009c to 832238a3b493 (1 revision) ( #140265 )
...
34d427aa00...832238a3b4skia-flutter-autoroll@skia.org Roll Skia from 191943f9c43e to 01aa69c38af5 (4 revisions) (flutter/engine#49128 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-16 06:27:34 +00:00
engine-flutter-autoroll
42eebee831
Roll Flutter Engine from 74e4965a2845 to 34d427aa009c (1 revision) ( #140263 )
...
74e4965a28...34d427aa00skia-flutter-autoroll@skia.org Roll Dart SDK from d66f9c854db7 to 620976ef6b80 (2 revisions) (flutter/engine#49125 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-16 05:47:41 +00:00
engine-flutter-autoroll
445bd51bfa
Roll Flutter Engine from ca329dd84207 to 74e4965a2845 (4 revisions) ( #140262 )
...
ca329dd842...74e4965a28dnfield@google.com Statically link swiftshader into flutter_tester (flutter/engine#48708 )
2023-12-16 jason-simmons@users.noreply.github.com [Impeller] Do not pass the depfile flag when creating a shader bundle in ImpellerC (flutter/engine#49114 )
2023-12-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run tests on macOS 13 exclusively" (flutter/engine#49115 )
2023-12-15 dnfield@google.com Roll SwiftShader to 2fa7e9b99ae4e70ea5ae2cc9c8d3afb43391384f (flutter/engine#49112 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-16 04:07:19 +00:00
Xilai Zhang
c1762215ad
[github actions] minor PR to test latest github actions ( #140252 )
...
Minor fix of a typo.
A merged PR on flutter/flutter with a newer base commit is needed to test the latest version of https://github.com/flutter/flutter/blob/master/.github/workflows/easy-cp.yml . (more details in https://github.com/flutter/flutter/pull/140191#issuecomment-1857169933 ).
This PR has a base commit that includes the latest updates to easy-cp.yml, and would be a good candidate for testing purposes when merged
2023-12-16 03:31:21 +00:00
engine-flutter-autoroll
388ba451d7
Roll Flutter Engine from 6e3a04874be5 to ca329dd84207 (3 revisions) ( #140255 )
...
6e3a04874b...ca329dd842bdero@google.com [Impeller] Turn off Aiks bounds tracking for filtered SaveLayers. (flutter/engine#49076 )
2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from cf84bab13da3 to 191943f9c43e (1 revision) (flutter/engine#49105 )
2023-12-15 skia-flutter-autoroll@skia.org Roll Dart SDK from e6528d1b7997 to d66f9c854db7 (1 revision) (flutter/engine#49104 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-16 03:21:17 +00:00
