firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,534 Commits 1 Branch 0 Tags
Commit Graph

28674 Commits

Author SHA1 Message Date
skia-flutter-autoroll
d761b0691b Roll Skia from 70d479753d41 to e22a628e1ee0 (2 revisions) (flutter/engine#53301) 
https://skia.googlesource.com/skia.git/+log/70d479753d41..e22a628e1ee0

2024-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 0d6a48911a02 to 582b9b9916d9
2024-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from df52ea3d7148 to 0d6a48911a02 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-10 07:10:19 +00:00
Brandon DeRosier
32ca408292 [Impeller] Move SeparatedVector2 to impeller/geometry. (flutter/engine#53264) 
Follow-up for https://github.com/flutter/engine/pull/53210.

Also rename from `Ray` to `SeparatedVector2`, which is a more accurate name for what it is.
 2024-06-08 20:13:32 +00:00
skia-flutter-autoroll
2e5ecfa528 Roll Fuchsia Linux SDK from zpBZmUB_JC5AjG-f4... to 8-r8iw3r4h35XQ4GP... (flutter/engine#53291) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-08 19:31:21 +00:00
skia-flutter-autoroll
34f01981f6 Roll Dart SDK from 48c6249a5b97 to 235dc289e4bf (1 revision) (flutter/engine#53289) 
https://dart.googlesource.com/sdk.git/+log/48c6249a5b97..235dc289e4bf

2024-06-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-240.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-08 15:55:18 +00:00
skia-flutter-autoroll
24cbddee8f Roll Dart SDK from d4f17e0bf28b to 48c6249a5b97 (1 revision) (flutter/engine#53287) 
https://dart.googlesource.com/sdk.git/+log/d4f17e0bf28b..48c6249a5b97

2024-06-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-239.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-08 02:06:09 +00:00
gaaclarke
5c4ba91e54 [impeller] switches gaussian blur to a "source space" calculation (flutter/engine#53261) 
fixes https://github.com/flutter/flutter/issues/149781
fixes https://github.com/flutter/flutter/issues/149458
fixes https://github.com/flutter/flutter/issues/140890

This works by performing the blur in the axis aligned "source space" (as opposed to "global space").  The rotation and scaling then is applied to the result of the gaussian blur.  Previously the differences between rrect_blur and gaussian blur were "fixed" in https://github.com/flutter/engine/pull/53130 which worked for blurring content that had no signal.  This addresses that same problem but in a more correct way that is less prone to artifacts when translating a blur since the blur happens in "source space".

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-08 00:25:25 +00:00
Yegor
0068c531ee [web] add test for inefficient overlay allocation (flutter/engine#53284) 
Adding a test that demonstrates https://github.com/flutter/flutter/issues/149863. When the issue is fixed, this test can be adjusted to verify the optimal behavior.
 2024-06-07 23:38:10 +00:00
Jackson Gardner
7af7be3e5d Update Chrome to 125. (flutter/engine#53282) 
Just updating Chrome For Testing because we're about six versions out of date now.
 2024-06-07 22:02:21 +00:00
skia-flutter-autoroll
1846ecf57a Roll Dart SDK from 4b693b16eec1 to d4f17e0bf28b (1 revision) (flutter/engine#53283) 
https://dart.googlesource.com/sdk.git/+log/4b693b16eec1..d4f17e0bf28b

2024-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-238.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-07 21:57:01 +00:00
Jackson Gardner
24ca8a9440 Fixes a few issues in flutter_js (flutter/engine#53231) 
This addresses a couple things:
https://github.com/flutter/flutter/issues/147610 (Treat `auto` renderer properly)
https://github.com/flutter/flutter/issues/149443 (Add an entrypoint base url config option)

This also adds a `useLocalCanvasKit` configuration option on the build config, which the flutter tool can use to fix https://github.com/flutter/flutter/issues/148713
 2024-06-07 20:35:12 +00:00
skia-flutter-autoroll
bdd8fb686e Roll Fuchsia Linux SDK from aVohW_hnfDaE0smBX... to zpBZmUB_JC5AjG-f4... (flutter/engine#53279) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-07 18:22:23 +00:00
skia-flutter-autoroll
f2484a5183 Roll Dart SDK from 7b239d7f4578 to 4b693b16eec1 (1 revision) (flutter/engine#53277) 
https://dart.googlesource.com/sdk.git/+log/7b239d7f4578..4b693b16eec1

2024-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-237.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-07 17:52:28 +00:00
skia-flutter-autoroll
0b6aeed4d1 Roll Skia from b7f51dfcc342 to ad3c9f203f4e (1 revision) (flutter/engine#53276) 
https://skia.googlesource.com/skia.git/+log/b7f51dfcc342..ad3c9f203f4e

2024-06-07 jvanverth@google.com [graphite] Clean up the SDF shaders

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-07 17:42:13 +00:00
skia-flutter-autoroll
ad7a3f024d Roll Skia from 5fc83884a619 to b7f51dfcc342 (4 revisions) (flutter/engine#53275) 
https://skia.googlesource.com/skia.git/+log/5fc83884a619..b7f51dfcc342

2024-06-07 brianosman@google.com Fix scan converter bug causing low coverage slivers in strokes
2024-06-07 brianosman@google.com Remove unused includes from skslc and sksl-minify
2024-06-07 sky@google.com [graphite] Early out in mapping if transform is the identity
2024-06-07 kjlubick@google.com Remove public.bzl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-07 16:13:25 +00:00
Jonah Williams
d86d6c541d Revert "Widen CPU affinity set." (flutter/engine#53274) 
Reverts flutter/engine#53136

b/345642546 shows some massive performance regressions on this patch. i'll rework it so the conditions are only loosened on phones with one fast core.
 2024-06-07 15:55:08 +00:00
skia-flutter-autoroll
71245b4066 Roll Dart SDK from accb5c25c42a to 7b239d7f4578 (1 revision) (flutter/engine#53272) 
https://dart.googlesource.com/sdk.git/+log/accb5c25c42a..7b239d7f4578

2024-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-236.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-07 10:37:22 +00:00
skia-flutter-autoroll
b267efdf2e Roll Skia from 376b88815099 to d2e17d341305 (2 revisions) (flutter/engine#53270) 
https://skia.googlesource.com/skia.git/+log/376b88815099..d2e17d341305

2024-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8dccd812a00c to df52ea3d7148 (9 revisions)
2024-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c344e2837bbe to 2ff3212615da (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-07 07:11:19 +00:00
skia-flutter-autoroll
dbf541a93f Roll Dart SDK from 41acb19a67b5 to accb5c25c42a (1 revision) (flutter/engine#53269) 
https://dart.googlesource.com/sdk.git/+log/41acb19a67b5..accb5c25c42a

2024-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-235.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-07 06:36:14 +00:00
skia-flutter-autoroll
201c3c0ac7 Roll Dart SDK from ed2b917b266d to 41acb19a67b5 (1 revision) (flutter/engine#53266) 
https://dart.googlesource.com/sdk.git/+log/ed2b917b266d..41acb19a67b5

2024-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-234.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-07 02:28:05 +00:00
hellohuanlin
6ea5724ca1 Reland "[ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering #53072" (flutter/engine#53256) 
The previous PR was reverted because it was on top of an outdated commit prior to ARC. This PR rebases the main. The only change is removing the `[super dealloc]` call that caused the compiler error. 

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/142813
Fixes https://github.com/flutter/flutter/issues/142830

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-06 22:33:18 +00:00
skia-flutter-autoroll
21b03cd398 Roll Dart SDK from 8e05acb354f5 to ed2b917b266d (1 revision) (flutter/engine#53262) 
https://dart.googlesource.com/sdk.git/+log/8e05acb354f5..ed2b917b266d

2024-06-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-233.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-06 22:18:16 +00:00
Brandon DeRosier
70c3469143 [Impeller] Round out extreme angles between curve polyline segments. (flutter/engine#53210) 
Resolves https://github.com/flutter/flutter/issues/137956.

Detect when the angle between two curve segments is > 10 degrees and
insert smoothing geometry if so. See [this
comment](https://github.com/flutter/flutter/issues/137956#issuecomment-2148395911)
for the full rationale behind this change.

```dart
    Paint paint = Paint()
      ..color = Colors.white
      ..strokeWidth = 50
      ..strokeCap = StrokeCap.round
      ..strokeJoin = StrokeJoin.round
      ..style = PaintingStyle.stroke;

    Path path = Path();
    path.moveTo(0, 0);
    path.quadraticBezierTo(100, 100, 0, 0);
    canvas.drawPath(path, paint);
```

Before:
<img width="166" alt="image"
src="https://github.com/flutter/engine/assets/919017/bbca80fb-a928-42aa-9e85-ad8e345558de">

After:
<img width="145" alt="image"
src="https://github.com/flutter/engine/assets/919017/aab6ffc8-d03e-4c2f-af83-c125d7acc250">
 2024-06-06 15:00:12 -07:00
Jonah Williams
1bebb4bd87 [Impeller] Expand fast gradient to all shapes. (flutter/engine#53254) 
Part of https://github.com/flutter/flutter/issues/148651

allows the fast gradient to apply to non-rect shapes where the start/end are still on the coverage rect. Goldens are slightly different but seem close enough?
 2024-06-06 19:03:14 +00:00
skia-flutter-autoroll
cb86a49b9a Roll Dart SDK from 62e8607e1410 to 8e05acb354f5 (1 revision) (flutter/engine#53257) 
https://dart.googlesource.com/sdk.git/+log/62e8607e1410..8e05acb354f5

2024-06-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-232.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-06 18:12:55 +00:00
Victoria Ashworth
a7057a3f7a Run tests on macOS 13 or 14 (flutter/engine#53252) 
In preparation of upgrading our fleet to macOS 14, allow tests to run on either macOS 13 or 14.

Fixes https://github.com/flutter/flutter/issues/148879.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-06 17:40:15 +00:00
skia-flutter-autoroll
5eed10c64c Roll Skia from d5acbe6bb22d to 1211df22d135 (2 revisions) (flutter/engine#53255) 
https://skia.googlesource.com/skia.git/+log/d5acbe6bb22d..1211df22d135

2024-06-06 drott@chromium.org [Fontations-backend] No PathOps::Simplify() on overlap bit contours
2024-06-06 jvanverth@google.com [graphite] Add LCD support to SDF.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-06 17:31:53 +00:00
skia-flutter-autoroll
1b210b8053 Roll Fuchsia Linux SDK from 2xWubo2mRP_2_wXKJ... to aVohW_hnfDaE0smBX... (flutter/engine#53253) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-06 17:07:13 +00:00
skia-flutter-autoroll
df235f71bb Roll Skia from a3a32c107ddb to d5acbe6bb22d (3 revisions) (flutter/engine#53251) 
https://skia.googlesource.com/skia.git/+log/a3a32c107ddb..d5acbe6bb22d

2024-06-06 brianosman@google.com Update Tint dual-source-blending enum name
2024-06-06 lehoangquyen@google.com GraphiteDawn: fix compilation errors on Win
2024-06-06 robertphillips@google.com [graphite] Add blending ImageFilters to Precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-06 16:11:36 +00:00
skia-flutter-autoroll
5ea695436a Roll Skia from ee42535eb2b4 to a3a32c107ddb (5 revisions) (flutter/engine#53250) 
https://skia.googlesource.com/skia.git/+log/ee42535eb2b4..a3a32c107ddb

2024-06-06 robertphillips@google.com [graphite] Address some todos re the precompile colorfilter IF
2024-06-06 lehoangquyen@google.com GraphiteDawn: Use latest version future API.
2024-06-06 rmistry@google.com Revert "Bump the npm_and_yarn group across 8 directories with 11 updates"
2024-06-06 robertphillips@google.com [graphite] Convert Precompile Blur, Displacement and MatrixConvolution IFs to new system
2024-06-06 49699333+dependabot[bot]@users.noreply.github.com Bump the npm_and_yarn group across 8 directories with 11 updates

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-06 14:53:36 +00:00
skia-flutter-autoroll
2c1f09a8bf Roll Dart SDK from 7df5ccdf1c1b to 62e8607e1410 (2 revisions) (flutter/engine#53248) 
https://dart.googlesource.com/sdk.git/+log/7df5ccdf1c1b..62e8607e1410

2024-06-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-231.0.dev
2024-06-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-230.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-06 14:01:01 +00:00
skia-flutter-autoroll
a6a3d6df1d Roll Dart SDK from e5459bcecb9c to 7df5ccdf1c1b (1 revision) (flutter/engine#53245) 
https://dart.googlesource.com/sdk.git/+log/e5459bcecb9c..7df5ccdf1c1b

2024-06-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-229.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-06 09:53:07 +00:00
Tong Mu
48799ceebf Make pointer events ignore invalid views (flutter/engine#51925) 
With this PR, Flutter will now ignore pointer events for an invalid view, i.e. views that have not been add or have been removed.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-06 07:18:20 +00:00
skia-flutter-autoroll
41c9c1488f Roll Skia from 0062d519a9ad to 9f3289461e51 (1 revision) (flutter/engine#53242) 
https://skia.googlesource.com/skia.git/+log/0062d519a9ad..9f3289461e51

2024-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b157149cf60a to 8dccd812a00c (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-06 05:53:20 +00:00
skia-flutter-autoroll
a44ae94a7e Roll Dart SDK from 86b8aacb2609 to e5459bcecb9c (1 revision) (flutter/engine#53241) 
https://dart.googlesource.com/sdk.git/+log/86b8aacb2609..e5459bcecb9c

2024-06-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-228.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-06 05:41:11 +00:00
Yegor
6dc99dce8a [web] clean up dynamic calls, remove always_specify_types (flutter/engine#53228) 
Remove the `avoid_dynamic_calls` exception in `web_ui`, and clean up all dynamic calls.
 2024-06-06 02:16:55 +00:00
Jonah Williams
e0c56ae81b [Impeller] Reland Use Skia software renderer to draw stroked text. (flutter/engine#53238) 
We need to match the rounding of glyphs to fix https://github.com/flutter/flutter/issues/138670 . We also don't have sufficient AA quality with 4x MSAA for high quality strokes.

Fixes https://github.com/flutter/flutter/issues/138670
Fixes https://github.com/flutter/flutter/issues/136688
 2024-06-06 02:16:52 +00:00
auto-submit[bot]
50421b59ad Reverts "[Impeller] Use Skia software renderer to draw stroked text. (#53198)" (flutter/engine#53237) 
Reverts: flutter/engine#53198
Initiated by: jonahwilliams
Reason for reverting: oops.
Original PR Author: jonahwilliams

Reviewed By: {chinmaygarde}

This change reverts the following previous change:
We need to match the rounding of glyphs to fix https://github.com/flutter/flutter/issues/138670 . We also don't have sufficient AA quality with 4x MSAA for high quality strokes.

Fixes https://github.com/flutter/flutter/issues/138670
Fixes https://github.com/flutter/flutter/issues/136688
 2024-06-06 01:03:29 +00:00
Jonah Williams
ee3a8d0775 [Impeller] Use Skia software renderer to draw stroked text. (flutter/engine#53198) 
We need to match the rounding of glyphs to fix https://github.com/flutter/flutter/issues/138670 . We also don't have sufficient AA quality with 4x MSAA for high quality strokes.

Fixes https://github.com/flutter/flutter/issues/138670
Fixes https://github.com/flutter/flutter/issues/136688
 2024-06-05 23:54:48 +00:00
Chinmay Garde
b5bc4a3868 Remove the DBC interpreter flag. (flutter/engine#53204) 
Cleanup of unused flag.
 2024-06-05 23:29:16 +00:00
David Iglesias
6eacdf2be8 [web] Adds allowPlatformDefault for wheel signals. (flutter/engine#51566) 
Adds a function to each 'wheel' DataPacket sent to the framework so it can signal whether to `allowPlatformDefault` or not.

The current default is to always `preventDefault` on browser events that get sent to the framework.

This PR enables the framework to call a method on the `DataPacket`s to `allowPlatformDefault: true`, if the framework won't handle the Signal (signals are handled synchronously on the framework).

This lets the engine "wait" for the framework to decide whether to `preventDefault` on a `wheel` event or not.

## Issues

* Needed for: https://github.com/flutter/flutter/issues/139263

## Tests

* Added unit tests for the feature in the engine repo, veryfing whether the event has had its `defaultPrevented` or not.
* Manually tested in a demo app (see below)

## Demo

* https://dit-multiview-scroll.web.app

<details>
<summary>

## Previous approaches

</summary>

1. Add a `handled` bool property to `PointerDataPacket` that the framework can write to (brittle)
2. Modifications to the `PlatformDispatcher` so the framework can `acknowledgePointerData` with a `PointerDataResponse` (fffffatttt change)
3. `acknowledge` function in `PointerDataPacket`

</details>

> [!IMPORTANT]
> * Related: https://github.com/flutter/flutter/pull/145500

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-05 23:25:53 +00:00
Jonah Williams
8d062af40c [Impeller] fix emojis with non-solid color sources. (flutter/engine#53229) 
Fixes https://github.com/flutter/flutter/issues/142974

If a text is drawn with a color source but lacks a path, just draw the original text. This ensures emojis render like Skia.
 2024-06-05 23:24:14 +00:00
skia-flutter-autoroll
b183150d74 Roll Skia from 8448abc95867 to 89570a0a171e (1 revision) (flutter/engine#53236) 
https://skia.googlesource.com/skia.git/+log/8448abc95867..89570a0a171e

2024-06-05 nathanasanchez@google.com Deduplicate gradient stops

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-05 23:01:00 +00:00
skia-flutter-autoroll
9e71758061 Roll Dart SDK from f838a9a8d45f to 86b8aacb2609 (1 revision) (flutter/engine#53234) 
https://dart.googlesource.com/sdk.git/+log/f838a9a8d45f..86b8aacb2609

2024-06-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-227.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-05 22:42:04 +00:00
Jim Graham
9a169198ec [DisplayList] remove legacy DisplayListMatrixClipTracker (flutter/engine#53232) 
The MatrixClipTracker was nothing more than a vector of MatrixClipState objects and a whole lot of duplicate delegation methods. It provided little value since nearly every use of it already had a state stack that was kept in synch with it's internal stack and so it was just adding an extra layer of delegation and extra allocations.
 2024-06-05 22:28:15 +00:00
gaaclarke
2dc427b86f [Impeller] added test for bgra10xr png encoding (flutter/engine#53182) 
fixes: https://github.com/flutter/flutter/issues/148851
depends on: 
 - https://skia-review.googlesource.com/c/skcms/+/861638
 - https://skia-review.googlesource.com/c/skia/+/861516

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-06-05 14:41:05 -07:00
Jonah Williams
efd37f4fd2 [Impeller] correctly map DL non-mipmap sample mode to non-mipmap sample mode. (flutter/engine#53161) 
Match DL/Skia sampling defaults. This does not change the default SamplerDescriptor value, but that is irrelevant as any draws from the framework will pass through DL conversion.

The SamplerDescriptor default of nearest is generally a good idea.

Fixes https://github.com/flutter/flutter/issues/148253
 2024-06-05 21:38:24 +00:00
Christopher Fujino
0ed900a541 Update testing/skia_gold_client/README.md (flutter/engine#53233) 
Add warning that you must be logged in to triage with skia gold
 2024-06-05 21:27:05 +00:00
skia-flutter-autoroll
186e005083 Roll Skia from 37755d48cca3 to 8448abc95867 (7 revisions) (flutter/engine#53230) 
https://skia.googlesource.com/skia.git/+log/37755d48cca3..8448abc95867

2024-06-05 kjlubick@google.com Replace GrVkBackendContext with skgpu::VulkanBackendContext
2024-06-05 kjlubick@google.com Remove deprecated fields from GrVkBackendContext
2024-06-05 aaclarke@google.com Added support for encoding the pixel format BGRA10XR to PNG.
2024-06-05 nicolettep@google.com [graphite] Accommodate AHardwareBuffer-backed textures when checking validity
2024-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a58be9cfb9b6 to 5562cb7a09df (3 revisions)
2024-06-05 kjlubick@google.com Add gni filegroups for ports files
2024-06-05 jvanverth@google.com Increase precision in GrConvexPolyEffect.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jmbetancourt@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-05 19:20:23 +00:00
skia-flutter-autoroll
5d93067fd9 Roll Dart SDK from dac7c04c7342 to f838a9a8d45f (3 revisions) (flutter/engine#53225) 
https://dart.googlesource.com/sdk.git/+log/dac7c04c7342..f838a9a8d45f

2024-06-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-226.0.dev
2024-06-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-225.0.dev
2024-06-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-224.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-05 18:17:01 +00:00
skia-flutter-autoroll
7ce17170c0 Roll Skia from 337c3c4d1f1b to 37755d48cca3 (45 revisions) (flutter/engine#53224) 
Roll Skia from 337c3c4d1f1b to 37755d48cca3 (45 revisions)

https://skia.googlesource.com/skia.git/+log/337c3c4d1f1b..37755d48cca3

2024-06-05 brianosman@google.com Revert "Update SkSL docs to point to named Fiddles."
2024-06-05 kjlubick@google.com Remove PRESUBMIT to check public.bzl
2024-06-05 michaelludwig@google.com [skif] Clone Graphite's shader blur algorithm into src/core as SkShaderBlurAlgorithm
2024-06-05 brettos@google.com first commit
2024-06-05 johnstiles@google.com Update SkSL docs to point to named Fiddles.
2024-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from ac92078b096b to 4a267203bfb3 (5 revisions)
2024-06-05 robertphillips@google.com [graphite] Move Precompile Lighting and Morphology IFs to new system
2024-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from af72bf7f4270 to 6aad8a895bdf (11 revisions)
2024-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 31bee5b9c506 to b8cf5b3d2bce (1 revision)
2024-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2d509f23bc91 to b157149cf60a (7 revisions)
2024-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3c05043f3c07 to ac92078b096b (13 revisions)
2024-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 043d004fae18 to a58be9cfb9b6 (3 revisions)
2024-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 2c278bd78d54 to b157149cf60a
2024-06-05 jiawei.shao@intel.com Use "dual_source_blending" instead of the chromium internal one
2024-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 9478a634ff6d to 5d9221d28f9c (1 revision)
2024-06-04 michaelludwig@google.com [graphite] Use explicit key for analytic rrect blur masks
2024-06-04 michaelludwig@google.com [skif] Remove SK_DONT_PAD_LAYER_IMAGES legacy code
2024-06-04 jvanverth@google.com [graphite] Add stub for LCD version of SDFTextRenderStep.
2024-06-04 robertphillips@google.com [graphite] Add colorFilter ImageFilter to the Precompilation system
2024-06-04 johnstiles@google.com Migrate SkSL docs into named fiddles.
2024-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bdf2b85a2504 to 043d004fae18 (6 revisions)
2024-06-04 jvanverth@google.com [graphite] Don't reset GraphiteDawnMetalWindowContext vars on shutdown
2024-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4bb94d6c235c to 31bee5b9c506 (2 revisions)
2024-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 5e66633855fd to 2d509f23bc91 (11 revisions)
2024-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 42a61f6e70c9 to af72bf7f4270 (15 revisions)
2024-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6a0c7b1934e4 to 3c05043f3c07 (16 revisions)
2024-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 58aba434448b to 2c278bd78d54
2024-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a27561991332 to bdf2b85a2504 (11 revisions)
2024-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from edc6a51fe9de to 6abcfbb93857
2024-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from e9508b902e1a to cf5bc2e4a408
2024-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from c9b24124977b to dbe6ed71568e
2024-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 782eb674150d to 6cfa730ae00a
2024-06-03 johnstiles@google.com Add test to demonstrate minification error.
2024-06-03 michaelludwig@google.com [graphite] Use explicit key for analytic circle blur profile
2024-06-03 michaelludwig@google.com Fix call to CreateIntegralTable
2024-06-03 michaelludwig@google.com [skif] Remove SK_RESOLVE_FILTERS_BEFORE_RESTORE legacy code
2024-06-03 nicolettep@google.com [graphite] Move Vulkan YCbCr conversion creation into resource provider
2024-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 975bd14542a4 to a27561991332 (1 revision)
2024-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 67036978c265 to 42a61f6e70c9 (19 revisions)
2024-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 5e66633855fd to 701d7c082df7
2024-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 30e89cc94007 to 5e66633855fd (2 revisions)
2024-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 9bf7c8c67a58 to 6a0c7b1934e4 (24 revisions)
2024-06-02 ccameron@chromium.org SkExif: Allow truncated input
2024-06-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 4e5420fc5c0d to 5e66633855fd
2024-06-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0da3accd42f7 to 975bd14542a4 (1 revision)

...
 2024-06-05 18:06:34 +00:00