firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,534 Commits 1 Branch 0 Tags
Commit Graph

28674 Commits

Author SHA1 Message Date
Yegor
33f46701ba [web] enable always_specify_types for web_ui (flutter/engine#53226) 
`always_specify_types: false` and `avoid_dynamic_calls: false` is a dangerous combination. Let's clean up `avoid_dynamic_calls` before disabling `always_specify_types`.
 2024-06-05 18:05:24 +00:00
Matan Lurey
2565803818 Re-land #52859: Revamp the engine style guide, remove always_specify_types (flutter/engine#53223) 
Based on the (internal) discussion around converging on using the official Dart style guide, the design discussion https://flutter.dev/go/use-dart-style-in-flutter-engine, and with the exception of the code that gets published under `dart:ui` (as that is user-facing, and we'd like to evolve the code style in conjunction with the framework), we're going to be (gradually) adopting the Dart style guide in `flutter/engine`.

For now, we:
- Remove `always_specify_types` (except for `lib/ui`, i.e. `dart:ui`)
- Re-enable `type_annotate_public_apis` (which is now relevant since the above is disabled)
- Announce our _intent_ to re-format and apply the Dart formatter (which we'll land in the near future)

---

I also took the opportunity to specify more about our style guide use in general, mostly to make it easier to understand our conventions, and also call out known problem areas (notably, our over-use of `shared_ptr` and `auto` in some cases). I am happy to split those up, but it was easier to make the markdown changes at once.

I also took @cbracken and folks advice and clarified directly that explicit types in Dart are _not_ bad (with examples).
 2024-06-05 16:53:06 +00:00
skia-flutter-autoroll
b7bfb93c05 Roll Fuchsia Linux SDK from pagJoGS4kQ8Efa_if... to 2xWubo2mRP_2_wXKJ... (flutter/engine#53222) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-05 15:53:34 +00:00
Filip Filmar
2b043806f5 [icu] Manual roll of icu (flutter/engine#53199) 
Manual roll of the ICU library. This normally happens automatically, but this
time around, ICU folks changed their license, so that needs to be fixed up.
I wish they would stop doing that. :)

This manual change should enable us to turn the auto-roller back on.

https://github.com/flutter/flutter/issues/149684

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-05 15:11:17 +00:00
auto-submit[bot]
4c30aee50a Reverts "[ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering (#53072)" (flutter/engine#53220) 
Reverts: flutter/engine#53072
Initiated by: jason-simmons
Reason for reverting: compilation errors on iOS targets

```
FlutterPlatformViews_Internal.mm:277:10: error: ARC forbids explicit message send of 'dealloc'
  277 |   [super dealloc];
      |    ~~~~~ ^
 ```

(see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8746006425774972161/+/u/build_ci_ios_debug_unopt_sim_flutter_testing_scenario_app_flutter_shell_platform_darwin_ios:ios_test_flutter/st
Original PR Author: hellohuanlin

Reviewed By: {cbracken, jonahwilliams}

This change reverts the following previous change:
This PR uses `CAShapeLayer` as the mask to avoid software rendering. 

I kept `UIView` as the mask, so that we can measure just the improvement related to avoiding software rendering. This also allows me to land this change sooner. I created [a separate issue](https://github.com/flutter/flutter/issues/149212) to track removing UIView as the mask. 

Note: the previous behavior seems to be incorrect (or at least not pixel perfect). This PR fixed it. See comments. 

See design doc: https://docs.google.com/document/d/1TqG_N4GK_qctuk73Gk3zOdAiILUrwMqxoCMgroK_AeA/edit?resourcekey=0-jUiidfzIS642ngG2w9vSUA&tab=t.0

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes https://github.com/flutter/flutter/issues/142813
Fixes https://github.com/flutter/flutter/issues/142830

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-05 14:26:47 +00:00
hellohuanlin
d1f28a74ae [ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering (flutter/engine#53072) 
This PR uses `CAShapeLayer` as the mask to avoid software rendering. 

I kept `UIView` as the mask, so that we can measure just the improvement related to avoiding software rendering. This also allows me to land this change sooner. I created [a separate issue](https://github.com/flutter/flutter/issues/149212) to track removing UIView as the mask. 

Note: the previous behavior seems to be incorrect (or at least not pixel perfect). This PR fixed it. See comments. 

See design doc: https://docs.google.com/document/d/1TqG_N4GK_qctuk73Gk3zOdAiILUrwMqxoCMgroK_AeA/edit?resourcekey=0-jUiidfzIS642ngG2w9vSUA&tab=t.0

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes https://github.com/flutter/flutter/issues/142813
Fixes https://github.com/flutter/flutter/issues/142830

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-05 02:40:23 +00:00
skia-flutter-autoroll
1aa32aad67 Roll Dart SDK from 343c20614708 to dac7c04c7342 (1 revision) (flutter/engine#53209) 
https://dart.googlesource.com/sdk.git/+log/343c20614708..dac7c04c7342

2024-06-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-223.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-05 01:50:27 +00:00
Jonah Williams
840abd4317 [Impeller] Intel iOS Simulators must block on GPU completion. (flutter/engine#53073) 
See also: https://github.com/flutter/flutter/issues/148660

Intel iOS simulators do not seem to enforce any backpressure on drawable acquisition. Fix this via blocking on completion in the surface_mtl.
 2024-06-04 23:28:10 +00:00
victorgalo
2b309db996 Add support for setting the heading level for web semantics (#97894) (flutter/engine#41435) 
This change adds a new property in Semantics widget that would take an integer value corresponding to the heading levels defined by the ARIA heading role. This is necessary in order to get proper accessibility and usability in a website for users who rely on screen readers and other assistive technologies.

Issue fixed by this PR:
https://github.com/flutter/flutter/issues/97894

Framework part:
https://github.com/flutter/flutter/pull/125771
 2024-06-04 23:11:17 +00:00
skia-flutter-autoroll
04d170593e Roll Dart SDK from 2d7d6facc2b4 to 343c20614708 (2 revisions) (flutter/engine#53203) 
https://dart.googlesource.com/sdk.git/+log/2d7d6facc2b4..343c20614708

2024-06-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-222.0.dev
2024-06-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-221.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-04 21:45:19 +00:00
Chinmay Garde
fc0ca409de [Impeller] Clarify rendering backend fallback behavior on Android. (flutter/engine#53202) 2024-06-04 21:21:22 +00:00
Jonah Williams
b01c5c3002 [Impeller] wire up bdf and blend detection in experimental canvas. (flutter/engine#53151) 
Use the flags in https://github.com/flutter/engine/pull/53104 + context capabilities to determine if we need to begin the first pass as an offscreen.

Part of https://github.com/flutter/flutter/issues/142054
 2024-06-04 21:10:01 +00:00
Jonah Williams
aad95e521e [Impeller] tighten fast gradient condition. (flutter/engine#53195) 
If the start/end point are _inside_ the rectangle, we can't apply the fast gradient condition.
 2024-06-04 20:15:02 +00:00
Reid Baker
8829c96265 java fail on format missing (flutter/engine#53176) 
- **Make java formatter fail when it cant format**
- **re enable the test that ensures that java formatting works**
Fixes https://github.com/flutter/flutter/issues/149604
 2024-06-04 19:04:51 +00:00
Emmanuel Ferdman
6bee81e9b6 [web] update version-lock file location (flutter/engine#52842) 
PR #47573 renamed the version-lock file from `browser_lock.yaml` to `package_lock.yaml`. This PR adjusts sources to changes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-04 17:50:04 +00:00
Jim Graham
20b66be63c Separate layer-specific data in DisplayListBuilder::SaveInfo (flutter/engine#53186) 
Previously the SaveInfo structure contained data for both a regular Save and a SaveLayer call for each entry in the stack. This was not optimal in that it meant that data for the layers had to be copied back and forth on Save and Restore calls even if a layer was not involved.

Now Save stack entries share the data for their most recent enclosing layer and so updating that information does not require (error-prone and time-wasting) copying of the data between save stack entries. This should make new code that tracks new information for layers easier to add in the future.
 2024-06-04 17:26:06 +00:00
bufffun
507326a5f2 [macOS] Fix FlutterView cursor hit testing (flutter/engine#53171) 
fix cursor hit testing in platform view in #52159

We found that the mechanism of `[NSView hitTest: view] `will handle the
flip coordinate automatically. In the previous PR, because the superview
of FlutterView was not flipped, we should not convert the point using
`[self convertPoint:event.locationInWindow fromView:nil]` .The
FlutterView hit test should run under the window coordinate system;
otherwise, FlutterMutatorView will hit a wrong point.

Before the fix:
Actual mouse move: `event.locationInWindow (x = 47.45703125, y =
416.86328125)`
FlutterView HitTest: `(NSPoint) point = (x = 47.45703125, y =
203.13671875)`
FlutterMutatorView HitTest: `(NSPoint) point = (x = 47.45703125, y =
416.86328125)`

After the fix:
Actual mouse move: `event.locationInWindow (x = 47.45703125, y =
416.86328125)`
FlutterView HitTest: `(NSPoint) point = (x = 47.45703125, y =
416.86328125)`
FlutterMutatorView HitTest: `(NSPoint) point = (x = 47.45703125, y =
203.13671875)`


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-06-04 18:04:19 +02:00
skia-flutter-autoroll
b225910acf Roll Dart SDK from 9dce57c343ec to 2d7d6facc2b4 (1 revision) (flutter/engine#53193) 
https://dart.googlesource.com/sdk.git/+log/9dce57c343ec..2d7d6facc2b4

2024-06-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-220.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-04 13:19:31 +00:00
skia-flutter-autoroll
a678f6a64c Roll Fuchsia Linux SDK from lKBLxel8iBaHpT5q6... to pagJoGS4kQ8Efa_if... (flutter/engine#53192) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-04 12:07:22 +00:00
auto-submit[bot]
2608c55ad6 Reverts "[display_list] allow applying opacity peephole to single glyph. (#53160)" (flutter/engine#53189) 
Reverts: flutter/engine#53160
Initiated by: jonahwilliams
Reason for reverting: unexpected framework goldens https://flutter-gold.skia.org/search?issue=149634&crs=github&patchsets=4&corpus=flutter
Original PR Author: jonahwilliams

Reviewed By: {flar}

This change reverts the following previous change:
A single glyph can be opacity peepholed, this is common in the case of Icons.
 2024-06-04 03:52:26 +00:00
skia-flutter-autoroll
0874df9398 Roll Dart SDK from 49b5590c8d80 to 9dce57c343ec (1 revision) (flutter/engine#53187) 
https://dart.googlesource.com/sdk.git/+log/49b5590c8d80..9dce57c343ec

2024-06-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-219.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-04 02:07:28 +00:00
Jonah Williams
458cbdd473 [Impeller] Use varying interpolation to compute some linear gradients. (flutter/engine#53166) 
Create a fast gradient variant that assumes vertex interpolation is sufficient to compute the gradient color. This follows the approximate design from  https://github.com/flutter/flutter/issues/148651

This is only implemented for draws that are exactly horizontal or vertical gradients on a rectangle with an identity effect transform.  This could be easily extended to all horizontal or vertical gradients by extending the drawGeometry call to make the cover rect customizable. Handling diagonal gradients and effect transforms is more work but feasible.

this is sufficient to make https://github.com/flutter/flutter/issues/148496 about 2x as fast, at least for me. Applications with different gradients will not yet benefit.
 2024-06-04 00:28:29 +00:00
gaaclarke
e70587d920 [Impeller] match rrect_blur math to the gaussian math (flutter/engine#53130) 
fixes https://github.com/flutter/flutter/issues/149276

## before
<img width="626" alt="Screenshot 2024-05-30 at 1 29 11 PM" src="https://github.com/flutter/engine/assets/30870216/2777d55f-928f-4029-92d3-203e8ca669a0">

## after
<img width="622" alt="Screenshot 2024-05-31 at 11 07 58 AM" src="https://github.com/flutter/engine/assets/30870216/155a592c-90f0-486b-8131-2f66328a871a">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-03 23:43:55 +00:00
David Iglesias
ac58f0a9c2 [web] Add Ethiopic font fallback. (flutter/engine#53180) 
Adds `Noto Sans Ethiopic` font as a fallback so Flutter web can render text in ethiopic scripts (for languages like Tigrinya or Amharic)

## Issues

* Fixes https://github.com/flutter/flutter/issues/149616

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-03 23:24:50 +00:00
Robert Ancell
2eff476e2c Fix rendering corruption by Flutter and GDK sharing the same OpenGL context (flutter/engine#53103) 
Fix rendering corruption by Flutter and GDK sharing the same OpenGL
context

Solved by having three contexts - one for GDK and two for Flutter.

Regression introduced in https://github.com/flutter/engine/pull/50754

Fixes https://github.com/flutter/flutter/issues/148653
 2024-06-04 11:02:09 +12:00
Jonah Williams
d78b43ffb2 [display_list] allow applying opacity peephole to single glyph. (flutter/engine#53160) 
A single glyph can be opacity peepholed, this is common in the case of Icons.
 2024-06-03 22:15:40 +00:00
skia-flutter-autoroll
0cbae65d5d Roll Dart SDK from 53c41325c29f to 49b5590c8d80 (4 revisions) (flutter/engine#53181) 
https://dart.googlesource.com/sdk.git/+log/53c41325c29f..49b5590c8d80

2024-06-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-218.0.dev
2024-06-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-217.0.dev
2024-06-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-216.0.dev
2024-06-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-215.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-03 22:01:13 +00:00
Jonah Williams
34fba02f1d Widen CPU affinity set. (flutter/engine#53136) 
For devices with 1 fast core, the current affinity set is less idea because it forces UI and raster on the same thread. Widen this to exclude slow cores instead of including only the fast core.
 2024-06-03 21:41:21 +00:00
Jonah Williams
d012531b02 [Impeller] fix NPE caused by implicit sk_sp to fml::Status conversion. (flutter/engine#53177) 
nullptr is converted to fml::Status::OK(nullptr), which we don't null check. Change this to consistently use fml::Status

Discovered in https://github.com/flutter/flutter/issues/148851
 2024-06-03 20:43:07 +00:00
Kaylee Lubick
89547e5ba6 Migrate off deprecated GrVkBackendContext fields (flutter/engine#53122) 
Context: https://g-issues.skia.org/issues/309785258

Skia would like to remove these deprecated fields, so this updates
Flutter's use of them to use the new ways.

Note that `VulkanWindow` seems to be unused (or no longer used?) since
there was a mistyped define (`SK_VUKLAN` -> `SK_VULKAN`) causing the
code I am fixing to never be run.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-06-03 14:48:43 -04:00
skia-flutter-autoroll
09c0e09ec0 Roll Fuchsia Linux SDK from c-Sm5-fy8c2YM7Myk... to lKBLxel8iBaHpT5q6... (flutter/engine#53167) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-03 08:41:17 +00:00
Chinmay Garde
7bd28bc629 [Impeller] Revert support for multi-arch shader archives. (flutter/engine#53158) 
This was never fully wired up and we never ended up needing this as there is only still on backend per platform. Earlier, we expected to have both GLES and Vulkan on Android.

Reverts 4b9e25401962684e03ffb0f87f1381c26c7a8279 and a6ea96ab2042ff8ca918df9a75a6308cf685c22b with fixups.
 2024-06-01 00:09:12 +00:00
skia-flutter-autoroll
a911dc8069 Roll Dart SDK from 2976c1694eed to 53c41325c29f (5 revisions) (flutter/engine#53159) 
https://dart.googlesource.com/sdk.git/+log/2976c1694eed..53c41325c29f

2024-05-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-214.0.dev
2024-05-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-213.0.dev
2024-05-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-212.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-211.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-210.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 22:54:13 +00:00
Jonah Williams
07d9ac8172 [Impeller] make strokes < 0.5 physical pixels visually thinner. (flutter/engine#53154) 
Fixes https://github.com/flutter/flutter/issues/144313

Do scalling on the alpha of thin strokes to approximate skia's similar behavior.
 2024-05-31 22:16:07 +00:00
Jonah Williams
ba76c2f700 [Impeller] Replace Impeller opacity peephole delegate with DL variant. (flutter/engine#52707) 
Use the existing DL opacity peephole flags and remove the Impeller variant. Also wires up for experimental canvas.

Work towards https://github.com/flutter/flutter/issues/142054
 2024-05-31 22:12:16 +00:00
John McDole
edeabda41b Remove RBE crud compile_commands.json (flutter/engine#53135) 
Removes reported errors in VSCode when using `clangd`

* Parsing a 21MB json string is not performant
* RegExp replacing all occurrences in said 21MB string is (~61ms)
* Fixes #147767
 2024-05-31 21:20:51 +00:00
skia-flutter-autoroll
54818ec2d6 Roll Skia from f1f13534b0c2 to 7193eec6a492 (3 revisions) (flutter/engine#53153) 
https://skia.googlesource.com/skia.git/+log/f1f13534b0c2..7193eec6a492

2024-05-31 michaelludwig@google.com [graphite] Use explicit key for analytic rect blur table
2024-05-31 michaelludwig@google.com [graphite] Support explicit UniqueKeys in ProxyCache
2024-05-31 egdaniel@google.com Fix mag, min, chrome filters for Ganesh Ycbcr.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 20:44:21 +00:00
Michael Ludwig
90b9b7a455 Remove SK_RESOLVE_FILTERS_BEFORE_RESTORE flag (flutter/engine#49563) 
Update SaveLayerConsolidation unit tests to allow 1px differences due to rounding differences when Skia elides image filter passes and can calculate the CF and opacity in full float without an intermediate conversion to 8-bit color.

This is the last remaining use of the staging that will allow closing https://g-issues.skia.org/issues/40042615.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-31 20:38:32 +00:00
Jonah Williams
8613caf1d2 Remove complexity calculator with Slimpeller (flutter/engine#53140) 
Will it blend?
 2024-05-31 20:10:20 +00:00
skia-flutter-autoroll
40ff614a26 Roll Skia from 208469d270b7 to f1f13534b0c2 (1 revision) (flutter/engine#53152) 
https://skia.googlesource.com/skia.git/+log/208469d270b7..f1f13534b0c2

2024-05-31 robertphillips@google.com [graphite] Add matrix convolution ImageFilter to Precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 19:41:55 +00:00
skia-flutter-autoroll
070a66721e Roll Skia from ce975ddfd9fb to 208469d270b7 (1 revision) (flutter/engine#53150) 
https://skia.googlesource.com/skia.git/+log/ce975ddfd9fb..208469d270b7

2024-05-31 drott@chromium.org [Fontations-backend] Hinting mode switching compat for comparison test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 18:12:59 +00:00
Reid Baker
02d2b7c8e1 Google java format relocation and formatting update (flutter/engine#53118) 
Fixes https://github.com/flutter/flutter/issues/149319
Caused by https://github.com/flutter/engine/pull/52582

Follow up required to add a flag that fails on missing jar files instead of skipping missing jar files.
 2024-05-31 18:09:23 +00:00
skia-flutter-autoroll
f2471ff7d9 Manual roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53149) 
Manual roll requested by jacksongardner@google.com

https://dart.googlesource.com/sdk.git/+log/ef405fbe3917..2976c1694eed

2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-209.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-208.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-207.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-206.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-205.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-204.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 17:53:21 +00:00
skia-flutter-autoroll
f042e6bfa2 Roll Skia from b1e59e25696a to ce975ddfd9fb (1 revision) (flutter/engine#53147) 
https://skia.googlesource.com/skia.git/+log/b1e59e25696a..ce975ddfd9fb

2024-05-31 nathanasanchez@google.com Optimize conical gradient negations

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 16:58:15 +00:00
skia-flutter-autoroll
824adfbcc8 Roll Skia from ddc7ed3f0767 to b1e59e25696a (1 revision) (flutter/engine#53146) 
https://skia.googlesource.com/skia.git/+log/ddc7ed3f0767..b1e59e25696a

2024-05-31 jvanverth@google.com Re-reland: "Fix text 565 to RGBA conversion on BGRA-based systems."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 15:50:39 +00:00
skia-flutter-autoroll
2a04ff26b7 Roll Skia from 8cc93368482b to ddc7ed3f0767 (1 revision) (flutter/engine#53145) 
https://skia.googlesource.com/skia.git/+log/8cc93368482b..ddc7ed3f0767

2024-05-31 robertphillips@google.com [graphite] Add displacement ImageFilter to Precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 14:18:31 +00:00
skia-flutter-autoroll
6777433af2 Roll Skia from 9930cf1449fd to 47bbc9c6d5f5 (3 revisions) (flutter/engine#53142) 
https://skia.googlesource.com/skia.git/+log/9930cf1449fd..47bbc9c6d5f5

2024-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 30e89cc94007 to 4e5420fc5c0d
2024-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1c59100bb494 to 30e89cc94007 (3 revisions)
2024-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 80bb115da95a to 9bf7c8c67a58 (24 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 06:58:21 +00:00
Jonah Williams
8afa79a341 Remove assorted bad logs. (flutter/engine#53139) 
Fixes https://github.com/flutter/flutter/issues/149376
Fixes https://github.com/flutter/flutter/issues/147081

Lets not log Skia on macOS or anything about transfer queues.
 2024-05-31 04:28:19 +00:00
skia-flutter-autoroll
97b59fdbc5 Roll Skia from c6cf8be050c0 to b34e5dd89e9d (1 revision) (flutter/engine#53133) 
https://skia.googlesource.com/skia.git/+log/c6cf8be050c0..b34e5dd89e9d

2024-05-30 jvanverth@google.com Revert "Reland "Fix text 565 to RGBA conversion on BGRA-based systems.""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 00:12:22 +00:00
skia-flutter-autoroll
4f30aaeb61 Roll Skia from a058f601e1fb to c6cf8be050c0 (2 revisions) (flutter/engine#53132) 
https://skia.googlesource.com/skia.git/+log/a058f601e1fb..c6cf8be050c0

2024-05-30 egdaniel@google.com [Graphites] Use SkTo in recent Vulkan DescSet change.
2024-05-30 egdaniel@google.com [Graphite] Fix crashes in Dawn Viewer context destruction.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 23:02:00 +00:00