engine-flutter-autoroll
eb5d0a434e
Roll Packages from e4ea6bf72e1b to 29d8cc006b0e (5 revisions) ( #143161 )
...
e4ea6bf72e...29d8cc006btd@technodisaster.com [local_auth] fix: isDeviceSupported on ios (flutter/packages#5125 )
2024-02-07 jason-simmons@users.noreply.github.com [image_picker] Suppress analyzer warning about deprecation of UnmodifiableUint8ListView (flutter/packages#6076 )
2024-02-07 58767497+GiftShower@users.noreply.github.com Add transitionDuration parameter (flutter/packages#5854 )
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter from e6ba809b8a23 to 8431cae8843c (23 revisions) (flutter/packages#6075 )
2024-02-07 ltv.luongthevinh@gmail.com [webview_flutter_android][webview_flutter_wkwebview] Adds support for `setOnScrollPositionChange` for webview_flutter platform implementations (flutter/packages#5664 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 15:37:20 +00:00
engine-flutter-autoroll
004d96a1be
Roll Flutter Engine from 6d524588c0f9 to f53fbd8393ce (1 revision) ( #143160 )
...
6d524588c0...f53fbd8393skia-flutter-autoroll@skia.org Roll Skia from fe4aa8a3ea53 to 59943f4e92b9 (1 revision) (flutter/engine#50463 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 15:35:34 +00:00
engine-flutter-autoroll
92c7ba8191
Roll Flutter Engine from 22e1241e9823 to 6d524588c0f9 (3 revisions) ( #143147 )
...
22e1241e98...6d524588c0skia-flutter-autoroll@skia.org Roll Skia from 97f12df11af2 to fe4aa8a3ea53 (2 revisions) (flutter/engine#50462 )
2024-02-08 skia-flutter-autoroll@skia.org Roll Skia from 8e08ece134da to 97f12df11af2 (1 revision) (flutter/engine#50461 )
2024-02-08 xilaizhang@google.com [github actions] update license year (flutter/engine#50458 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 08:21:52 +00:00
engine-flutter-autoroll
720f73a4da
Roll Flutter Engine from 084bd0b8f5ac to 22e1241e9823 (1 revision) ( #143140 )
...
084bd0b8f5...22e1241e98skia-flutter-autoroll@skia.org Roll Skia from 91a9154d0dfa to 8e08ece134da (1 revision) (flutter/engine#50459 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 05:19:37 +00:00
engine-flutter-autoroll
be659e0b04
Roll Flutter Engine from 104804aa374e to 084bd0b8f5ac (1 revision) ( #143139 )
...
104804aa37...084bd0b8f5robert.ancell@canonical.com Clear objects before setting them. (flutter/engine#50344 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 04:40:15 +00:00
engine-flutter-autoroll
28904c0cd3
Roll Flutter Engine from 45137ea6ba29 to 104804aa374e (1 revision) ( #143138 )
...
45137ea6ba...104804aa3726625149+0xZOne@users.noreply.github.com [ios] Fix memory leak in ChildClippingView (flutter/engine#50389 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 03:51:25 +00:00
Jackson Gardner
71c6cd0cb9
Pass along web renderer into debugging options in the test command. ( #143128 )
...
We need to pass along the web renderer in the debugging options to make sure that the resident web runner sets up the targets correctly.
2024-02-08 01:21:07 +00:00
engine-flutter-autoroll
b586bd9188
Roll Flutter Engine from 4ea7bd07328b to 45137ea6ba29 (2 revisions) ( #143135 )
...
4ea7bd0732...45137ea6bagoderbauer@google.com Report display sizes in physical pixels on MacOS (flutter/engine#50221 )
2024-02-07 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run tests with multiple packages (flutter/engine#50219 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 01:07:20 +00:00
engine-flutter-autoroll
6af69544ab
Roll Flutter Engine from 322a461dc74f to 4ea7bd07328b (2 revisions) ( #143131 )
...
322a461dc7...4ea7bd0732skia-flutter-autoroll@skia.org Roll Skia from 8332438cbeb9 to 91a9154d0dfa (2 revisions) (flutter/engine#50452 )
2024-02-07 jonahwilliams@google.com [Impeller] move path out of PathBuilder in TakePath. (flutter/engine#50444 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-08 00:01:08 +00:00
Qun Cheng
d85497d91b
Add a unit test for NavigationRail ( #143108 )
...
Adding `SingleChildScrollView` to `NavigationRail` may cause exception if the nav rail has some expanded widgets inside, like the issue: https://github.com/flutter/flutter/issues/143061 . This PR is just to add a unit test to avoid causing this breaking again.
2024-02-07 23:14:56 +00:00
engine-flutter-autoroll
52f897be5f
Roll Flutter Engine from b1ba9f329f76 to 322a461dc74f (2 revisions) ( #143123 )
...
b1ba9f329f...322a461dc7skia-flutter-autoroll@skia.org Roll Skia from eacaa2d3600c to 8332438cbeb9 (6 revisions) (flutter/engine#50451 )
2024-02-07 dnfield@google.com [Impeller] Log non-default graphics backend usages, use IMPORTANT rather than ERROR (flutter/engine#50448 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 23:08:21 +00:00
auto-submit[bot]
cc4e07954d
Reverts "Improve build output for all platforms" ( #143125 )
...
Reverts flutter/flutter#128236
Initiated by: vashworth
Reason for reverting: Causing `Mac_pixel_7pro run_release_test` and `Mac_arm64_android run_release_test` to fail: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_pixel_7pro%20run_release_test/547/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_android%20run_release_test/10516/overview
Original PR Author: guidezpl
Reviewed By: {christopherfujino, loic-sharma}
This change reverts the following previous change:
Original Description:
Improves the build output:
1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained)
### `apk`, `appbundle`
<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d ">
<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436 ">
### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.
<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257 ">
<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50 ">
<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698 ">
### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).
<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b ">
<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2 ">
<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5 ">
### Size reporting
When applicable, the printed size matches the OS reported size.
- macOS
<img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce ">
- Windows
<img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7 ">
- Linux
<img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b ">
## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401
2024-02-07 22:44:19 +00:00
engine-flutter-autoroll
aeb87eb52e
Roll Flutter Engine from e4a5acc14b44 to b1ba9f329f76 (2 revisions) ( #143120 )
...
e4a5acc14b...b1ba9f329fskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kvEXgoydRYnW3UvX2... to CPiPDUwCrjHYf_lAR... (flutter/engine#50447 )
2024-02-07 matanlurey@users.noreply.github.com Fix Android `scenario_app` to actually run and block on CI (flutter/engine#50414 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kvEXgoydRYnW to CPiPDUwCrjHY
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 22:26:23 +00:00
Pierre-Louis
2fceeb0e3c
Improve build output for all platforms ( #128236 )
...
Improves the build output:
1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained)
### `apk`, `appbundle`
<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d ">
<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436 ">
### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.
<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257 ">
<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50 ">
<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698 ">
### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).
<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b ">
<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2 ">
<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5 ">
### Size reporting
When applicable, the printed size matches the OS reported size.
- macOS
<img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce ">
- Windows
<img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7 ">
- Linux
<img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b ">
## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401
2024-02-07 22:22:25 +00:00
engine-flutter-autoroll
515103270b
Roll Flutter Engine from 19ae46afed69 to e4a5acc14b44 (7 revisions) ( #143112 )
...
19ae46afed...e4a5acc14bflutter/engine#50450 )
2024-02-07 skia-flutter-autoroll@skia.org Roll Skia from a2fe78a31a14 to eacaa2d3600c (3 revisions) (flutter/engine#50445 )
2024-02-07 chinmaygarde@google.com [Impeller] Initialize the stencil reference value. (flutter/engine#50373 )
2024-02-07 skia-flutter-autoroll@skia.org Roll Skia from 9b103a4148e2 to a2fe78a31a14 (2 revisions) (flutter/engine#50441 )
2024-02-07 30870216+gaaclarke@users.noreply.github.com Fixed CONTRIBUTING.md markdown lints (flutter/engine#50439 )
2024-02-07 skia-flutter-autoroll@skia.org Roll Skia from 7777976cd518 to 9b103a4148e2 (1 revision) (flutter/engine#50438 )
2024-02-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 452dd17120b7 to 322c81160fa9 (1 revision) (flutter/engine#50437 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 21:46:07 +00:00
yim
16e7218cd4
Fixed cursor blinking during selection. ( #141380 )
...
The cursor now correctly stops blinking while it's being interacted with.
2024-02-07 13:39:30 -08:00
Jenn Magder
025d18d70a
Remove Cirrus check for web test concurrency ( #143046 )
...
Tests no longer run on Cirrus.
#40630
2024-02-07 21:36:24 +00:00
auto-submit[bot]
d60643e82f
Reverts "Enforce a policy on supported Gradle, Java, AGP, and KGP versions" ( #143114 )
...
Reverts flutter/flutter#142000
Initiated by: vashworth
Reason for reverting: Causing `Mac_pixel_7pro run_release_test` and `Mac_arm64_android run_debug_test_android` to fail: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_pixel_7pro%20run_release_test/539/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_android%20run_debug_test_android/6682/overview
Original PR Author: gmackall
Reviewed By: {reidbaker, camsim99, bartekpacia}
This change reverts the following previous change:
Original Description:
Policy per https://flutter.dev/go/android-dependency-versions .
https://github.com/flutter/flutter/issues/140913
~Still a WIP while I clean up some error handling, remove some prints, and figure out a Java test (more difficult than the others because I believe we can only install one java version per ci shard).~
~Also it looks like there are errors that I need to fix when this checking is applied to a project that uses the old way of applying AGP/KGP using the top-level `build.gradle` file (instead of the new template way of applying them in the `settings.gradle` file).~ Done, this is why [these lines exist](9af6bae6b9/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy (L72-L88)
2024-02-07 21:22:26 +00:00
Gray Mackall
337bc79b0c
Enforce a policy on supported Gradle, Java, AGP, and KGP versions ( #142000 )
...
Policy per https://flutter.dev/go/android-dependency-versions .
https://github.com/flutter/flutter/issues/140913
~Still a WIP while I clean up some error handling, remove some prints, and figure out a Java test (more difficult than the others because I believe we can only install one java version per ci shard).~
~Also it looks like there are errors that I need to fix when this checking is applied to a project that uses the old way of applying AGP/KGP using the top-level `build.gradle` file (instead of the new template way of applying them in the `settings.gradle` file).~ Done, this is why [these lines exist](9af6bae6b9/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy (L72-L88)
2024-02-07 20:56:07 +00:00
Jackson Gardner
2aef6c570c
Fix inputs and outputs for WebReleaseBundle ( #143023 )
...
Since `WebReleaseBundle` is responsible for copying over the outputs from the subtargets, so it needs to be reflected in inputs and outputs so that things will be recopied when something changes.
2024-02-07 20:00:02 +00:00
Ian Hickson
9fccb32a58
Various improvements to text-editing-related documentation. ( #142561 )
2024-02-07 19:58:06 +00:00
Michael Goderbauer
4becae25b0
Revert "Add SingleChildScrollView for NavigationRail" ( #143097 )
...
Reverts flutter/flutter#137415
Reverting due to https://github.com/flutter/flutter/issues/143061 . this is breaking some existing use cases, see also https://github.com/flutter/samples/pull/2157 . If we try this again, we need to add this in less breaking way.
Fixes https://github.com/flutter/flutter/issues/143061
2024-02-07 19:30:02 +00:00
Gray Mackall
120a01ccd2
Restore log dumps for gradle OOM crashes, and set a value for MaxMetaspaceSize ( #143085 )
...
Re-sets two jvmargs that were getting cleared because we set a value for `-Xmx`. Could help with https://github.com/flutter/flutter/issues/142957 . Copied from comment here https://github.com/flutter/flutter/issues/142957 :
>Two random things I ran into while looking into this that might help:
>
>1. Gradle has defaults for a couple of the jvmargs, and setting any one of them clears those defaults for the others (bug here https://github.com/gradle/gradle/issues/19750 ). This can cause the "Gradle daemon to consume more and more native memory until it crashes", though the bug typically has a different associated error. It seems worth it to re-set those defaults.
>2. There is a property we can set that will give us a heap dump on OOM ([-XX:HeapDumpOnOutOfMemoryError](https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/clopts001.html ))
Mostly just a find and replace from `find . -name gradle.properties -exec sed -i '' 's/\-Xmx4G/-Xmx4G\ \-XX:MaxMetaspaceSize=2G\ \-XX:+HeapDumpOnOutOfMemoryError/g' {} \;`, with the templates and the one test that writes from a string replaced by hand. I didn't set a value for `MaxMetaspaceSize` in the template files because I want to make sure this value doesn't cause problems in ci first (changes to the templates are essentially un-revertable for those who `flutter create` while the changes exist).
2024-02-07 19:25:39 +00:00
Victoria Ashworth
d60b681ef7
Move Mac_build_test flutter_gallery__transition_perf_e2e_ios out of staging ( #142987 )
...
Move test out of staging now that https://github.com/flutter/flutter/issues/142917 is fixed.
2024-02-07 19:24:44 +00:00
engine-flutter-autoroll
14a00dca38
Roll Flutter Engine from fafd8e55eb4b to 19ae46afed69 (1 revision) ( #143094 )
...
fafd8e55eb...19ae46afed68449066+zijiehe-google-com@users.noreply.github.com Redo "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds" (flutter/engine#50408 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 19:02:48 +00:00
Ian Hickson
1699ff38fe
Add a test for the isAvailableForEnvironment logic ( #142251 )
...
This is part 3 of a broken down version of the #140101 refactor.
There's some TODOs showing where I think we should change the behaviour, but in this PR the behaviour is unchanged.
A future PR will remove the tests that are redundant with these tests, but I wanted to make sure we had both sets in the codebase at the same time first.
This PR includes a change to the golden control test so that we can verify that these specific values do work on main. It would be extremely surprising if not, but in the interests of rigour...
2024-02-07 19:01:48 +00:00
Valentin Vignal
ab836a2db0
Add the number of mismatched pixels to golden tests output ( #142975 )
...
Fixes https://github.com/flutter/flutter/issues/141036
2024-02-07 18:59:57 +00:00
Michael Goderbauer
0202e3bf7a
Add indexInParent to SemanticsNode debug information ( #142826 )
...
https://github.com/flutter/flutter/issues/93232
2024-02-07 18:51:04 +00:00
Jenn Magder
01f81b322c
Remove unused devicelab task gradle_non_android_plugin_test ( #142742 )
...
I moved this test to integration.shard in https://github.com/flutter/flutter/pull/80161 . Remove the no-op task https://github.com/flutter/flutter/issues/85347 .
2024-02-07 18:41:55 +00:00
Gray Mackall
f130da46e0
Make generate_gradle_lockfiles also write the gradle wrapper file ( #142329 )
...
The `generate_gradle_lockfiles` script currently writes the top level `build.gradle` file and the `settings.gradle` file, and is the easiest way to batch update these files to, for example, increase the AGP version used in integration tests and examples across the framework repo.
This PR makes it also write the gradle version, so that we can do batch upgrades of our gradle version with it as well.
2024-02-07 18:40:00 +00:00
engine-flutter-autoroll
8acce3d420
Roll Flutter Engine from 6807342305e4 to fafd8e55eb4b (1 revision) ( #143086 )
...
6807342305...fafd8e55ebzanderso@users.noreply.github.com Update NDK to version 26 (flutter/engine#48254 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 18:13:19 +00:00
Andrew Kolos
34c2080b9d
Remove redundant rootDirectoryPath parameter in DevFS::update ( #143034 )
...
Resolves #143041
2024-02-07 18:04:31 +00:00
maRci002
8e2da8414c
Handle transitions to AppLifecycleState.detached in lifecycle state generation ( #142523 )
...
Generates the correct lifecycle state transitions in ServicesBinding when detaching.
2024-02-07 10:01:22 -08:00
engine-flutter-autoroll
8431cae884
Roll Flutter Engine from 1ac6beb8a3c2 to 6807342305e4 (6 revisions) ( #143082 )
...
1ac6beb8a3...6807342305skia-flutter-autoroll@skia.org Roll Skia from 0fb71bedffa2 to 7777976cd518 (3 revisions) (flutter/engine#50435 )
2024-02-07 satsrag@outlook.com Fix: On the Web, cannot support multiline inputting when registering customized TextInputControl (flutter/engine#45522 )
2024-02-07 skia-flutter-autoroll@skia.org Roll Skia from 3cc2a15196cb to 0fb71bedffa2 (1 revision) (flutter/engine#50429 )
2024-02-07 skia-flutter-autoroll@skia.org Roll Skia from 1b266b36a4c8 to 3cc2a15196cb (1 revision) (flutter/engine#50427 )
2024-02-07 bdero@google.com [Impeller] Always pop clips on restore. (flutter/engine#50419 )
2024-02-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 35269fa71956 to 452dd17120b7 (1 revision) (flutter/engine#50424 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 17:20:07 +00:00
engine-flutter-autoroll
900e060a1c
Manual roll Flutter Engine from 808886312e2b to 1ac6beb8a3c2 (22 revisions) ( #143039 )
...
Manual roll requested by zra@google.com
808886312e...1ac6beb8a3skia-flutter-autoroll@skia.org Roll Skia from fd55a6bd3580 to 1b266b36a4c8 (1 revision) (flutter/engine#50423 )
2024-02-06 skia-flutter-autoroll@skia.org Roll Skia from 44106ee8edea to fd55a6bd3580 (17 revisions) (flutter/engine#50420 )
2024-02-06 bdero@google.com [Impeller] Fix pipeline attachment layout in CanRenderToTexture. (flutter/engine#50413 )
2024-02-06 ian@hixie.ch Provide toStrings for Native objects (flutter/engine#50168 )
2024-02-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 29265c94a6e8 to 35269fa71956 (1 revision) (flutter/engine#50402 )
2024-02-06 54558023+keyonghan@users.noreply.github.com Add use_rbe to gclient variables for Framework Smoke Tests (flutter/engine#50403 )
2024-02-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Revert "Revert "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds""" (flutter/engine#50407 )
2024-02-06 matanlurey@users.noreply.github.com Skip flaking test on Windows nobody is fixing. (flutter/engine#50401 )
2024-02-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] Fix Scene clip bounds. Trigger resize on DPR Change." (flutter/engine#50404 )
2024-02-06 68449066+zijiehe-google-com@users.noreply.github.com Revert "Revert "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds"" (flutter/engine#50295 )
2024-02-06 chinmaygarde@google.com [Impeller] Specify if Angle or SwiftShader is being used in the title. (flutter/engine#50376 )
2024-02-06 matanlurey@users.noreply.github.com Run all Android `scenario_app` tests, not just the smoke test. (flutter/engine#50400 )
2024-02-06 skia-flutter-autoroll@skia.org Roll Dart SDK from b62066b42af0 to 29265c94a6e8 (10 revisions) (flutter/engine#50398 )
2024-02-06 matanlurey@users.noreply.github.com Capture `FAILURES!!!` when running Android `scenario_app` tests. (flutter/engine#50255 )
2024-02-06 jonnywang@google.com [fuchsia] Bump Fuchsia's API level to 16 (flutter/engine#50358 )
2024-02-06 skia-flutter-autoroll@skia.org Roll Skia from 9e68ed6caf6d to 44106ee8edea (1 revision) (flutter/engine#50393 )
2024-02-06 skia-flutter-autoroll@skia.org Roll Skia from c29a20702356 to 9e68ed6caf6d (1 revision) (flutter/engine#50392 )
2024-02-06 jonahwilliams@google.com [Impeller] Cache RenderPass/Framebuffer objects on the resolve texture sources. (flutter/engine#50142 )
2024-02-06 jason-simmons@users.noreply.github.com [Impeller] Do not skip the GLES render pass if the command list is empty (flutter/engine#50381 )
2024-02-06 skia-flutter-autoroll@skia.org Roll Skia from cdf214adfb4d to c29a20702356 (54 revisions) (flutter/engine#50382 )
2024-02-06 ditman@gmail.com [web] Fix Scene clip bounds. Trigger resize on DPR Change. (flutter/engine#50161 )
2024-02-06 xilaizhang@google.com [github actions] add cherry pick workflow for engine repo (flutter/engine#50265 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 16:22:42 +00:00
engine-flutter-autoroll
39d8df4f4f
Roll Packages from 1a5a7ce56e87 to e4ea6bf72e1b (4 revisions) ( #143076 )
...
1a5a7ce56e...e4ea6bf72eengine-flutter-autoroll@skia.org Manual roll Flutter from 0b5cd5073a3b to e6ba809b8a23 (12 revisions) (flutter/packages#6066 )
2024-02-06 stuartmorgan@google.com [tool] Update to Dart 3 (flutter/packages#6030 )
2024-02-06 stuartmorgan@google.com [ci] Move tool_runner.sh (flutter/packages#6038 )
2024-02-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.0 to 4.3.1 (flutter/packages#6063 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-07 15:41:39 +00:00
Bruno Leroux
6a7baf573e
Fix M3 text field height + initial step for input decorator M3 test migration ( #142981 )
...
## Description
This PR main purpose is to make progress on the M3 test migration for `InputDecorator` (see https://github.com/flutter/flutter/issues/139076 ).
Before this PR more than 80 of the 156 tests defined in `input_decorator_test.dart` fail on M3.
Migrating all those tests in one shot is not easy at all because many failures are related to wrong positionning due to M3 typography changes. Another reason is that several M3 specific changes are required in order to get a proper M3 compliant text field, for instance:
- https://github.com/flutter/flutter/issues/142972
- https://github.com/flutter/flutter/issues/141354
Most of the tests were relying on an helper function (`buildInputDecorator`) which had a `useMaterial3` parameter. Unfortunately when `useMaterial3: true `was passed to this function it forced `useMaterial3: false` at the top level but overrided it at a lower level, which was very misleading because people could assume that the tests are ok with M3 (but in fact they were run using M2 typography but have some M3 logic in use).
I considered various way to make this change and I finally decided to run all existing tests only on M2 for the moment. Next step will be to move most of those tests to M3. In this PR, I migrated two of these existing tests for illustration.
Because many of the existing tests are checking input decorator height, I think it would also make sense to fix https://github.com/flutter/flutter/issues/142972 first. That's why I choosed to include a fix to https://github.com/flutter/flutter/issues/142972 in this PR.
A M3 filled `TextField` on Android:
| Before this PR | After this PR |
|--------|--------|
|  |  |
## Related Issue
Fixes https://github.com/flutter/flutter/issues/142972
Related to https://github.com/flutter/flutter/issues/139076
## Tests
Updates many existing tests
+ adds 2 tests related to the fix for https://github.com/flutter/flutter/issues/142972
+ adds 1 tests for the M3 migration
+ move 1 tests related to M3
2024-02-07 13:57:21 +00:00
Taha Tesser
c539ded64b
[reland] Add AnimationStyle to showSnackBar ( #143052 )
...
[Original was reverted due to uncaught analysis failure
](https://github.com/flutter/flutter/pull/142825#issuecomment-1930620085 )
---
fixes [`showSnackBar` is always replacing `animation` parameter of `SnackBar`](https://github.com/flutter/flutter/issues/141646 )
### Code sample preview
2024-02-07 10:26:27 +00:00
Jenn Magder
fee1868d89
Run Mac x64 build tests in postsubmit only ( #142334 )
...
It shouldn't be very common for x64 example projects to not build if they built on arm64. We have other tool tests that would probably catch those issues in presubmit.
Instead run them on postsubmit only to free up limited x64 staging resources.
Follow up from #141206
2024-02-07 06:41:25 +00:00
Jason Simmons
db141ecd28
Copy the flutter version JSON file into the simulated Flutter SDK used by update_packages ( #143035 )
...
Dart pub now expects that file to be present in a Flutter SDK (see
https://dart.googlesource.com/pub/+/dce232ec195df802a730eb3a66163e28d2ec6444 )
2024-02-06 20:00:08 -08:00
Andrew Kolos
bf9aa556d2
Mark Windows_android hot_mode_dev_cycle_win__benchmark as no longer flaky ( #143016 )
...
Marked flaky in flutter/flutter#142609
Per the reasons I discuss in [this comment](https://github.com/flutter/flutter/issues/142608#issuecomment-1930868003 ) on the corresponding issue, I believe this test is probably not actually flaky.
Fixes https://github.com/flutter/flutter/issues/142608
2024-02-07 03:36:02 +00:00
Dan Field
7514c16a6a
Dispose precached image info ( #143017 )
...
`precacheImage` was failing to dipose the `ImageInfo` it receives. That's part of the contract of being an image listener.
I'm doing this in the frame callback for the same reason as evicting it from the cache.
2024-02-07 03:28:06 +00:00
Polina Cherkasova
ac5c3dec87
Instrument CurvedAnimation. ( #143007 )
2024-02-07 03:26:40 +00:00
Andrew Brampton
10f1e63579
Update _goldens_io.dart to generate failure images during a size mism… ( #142177 )
...
Update the `matchesGoldenFile()` / `LocalComparisonOutput` code to generate failure images for golden tests that fail when the image sizes do not match. This can make it far quicker to identify what is wrong with the test image.
Fixes https://github.com/flutter/flutter/issues/141488
- [ x I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
2024-02-07 03:23:29 +00:00
auto-submit[bot]
310a7edbca
Reverts "Activate InkSparkle on CanvasKit" ( #143036 )
...
Reverts flutter/flutter#138545
Initiated by: zanderso
Reason for reverting: Failing in post-submit: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/14975/overview
```
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
The following FormatException was thrown running a test:
Invalid Shader Data
When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.da
Original PR Author: bleroux
Reviewed By: {Piinks}
This change reverts the following previous change:
Original Description:
## Description
This PR activates the M3 `InkSparkle` splash animation on Android + CanvasKit.
Before it `InkSparkle` was only activated on native Android.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/138487
## Tests
Updates several existing tests.
2024-02-07 02:44:21 +00:00
Bruno Leroux
7f811fb444
Activate InkSparkle on CanvasKit ( #138545 )
...
## Description
This PR activates the M3 `InkSparkle` splash animation on Android + CanvasKit.
Before it `InkSparkle` was only activated on native Android.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/138487
## Tests
Updates several existing tests.
2024-02-07 00:28:04 +00:00
Chris Bracken
9f8fe3f04c
[Windows] Fix signed/unsigned int comparison ( #142341 )
...
Previously, we were comparing the signed int `target_length` (returned by WideCharToMultiByte) to a size_t string length, resulting in a signed/unsigned comparison warning as follows:
```
windows\runner\utils.cpp(54,43): warning C4018: '>': signed/unsigned mismatch
```
WideCharToMultiByte returns:
* 0 on error
* the number of bytes written to the buffer pointed to by its fifth parameter, lpMultiByteStr, on success.
As a result it's safe to store the return value in an unsigned int, which eliminates the warning.
No changes to tests since this is dependent on end-user project settings/modifications and does not trigger a warning with default project settings.
Fixes: https://github.com/flutter/flutter/issues/134227
2024-02-07 00:09:57 +00:00
auto-submit[bot]
ceca606662
Reverts "Move native assets to isolated/ directory" ( #143027 )
...
Reverts flutter/flutter#142709
Initiated by: vashworth
Reason for reverting: `Mac tool_tests_general` started failing on this commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_tests_general/15552/overview
Original PR Author: dcharkes
Reviewed By: {christopherfujino, chingjun, reidbaker}
This change reverts the following previous change:
Original Description:
Native assets in other build systems are not built with `package:native_assets_builder` invoking `build.dart` scripts. Instead all packages have their own blaze rules. Therefore we'd like to not depend on `package:native_assets_builder` from flutter tools in g3 at all.
This PR aims to move the imports of `native_assets_builder` and `native_assets_cli` into the `isolated/` directory and into the files with a `main` function that are not used in with other build systems.
In order to be able to remove all imports in files used by other build systems, two new interfaces are added `HotRunnerNativeAssetsBuilder` and `TestCompilerNativeAssetsBuilder`. New parameters are then piped all the way through from the entry points:
* bin/fuchsia_tester.dart
* lib/executable.dart
The build_system/targets dir is already excluded in other build systems.
So, after this PR only the two above files and build_system/targets import from `isolated/native_assets/` and only `isolated/native_assets/` import `package:native_assets_cli` and `package:native_assets_builder`.
Context:
* https://github.com/flutter/flutter/issues/142041
2024-02-07 00:01:18 +00:00
auto-submit[bot]
6b2397033c
Reverts "Roll Flutter Engine from 808886312e2b to 07cdaab7f531 (18 revisions)" ( #143025 )
...
Reverts flutter/flutter#143005
Initiated by: vashworth
Reason for reverting: `Linux technical_debt` started failing on this commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20technical_debt__cost/16684/overview
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
Original Description:
808886312e...07cdaab7f5skia-flutter-autoroll@skia.org Roll Dart SDK from 29265c94a6e8 to 35269fa71956 (1 revision) (flutter/engine#50402 )
2024-02-06 54558023+keyonghan@users.noreply.github.com Add use_rbe to gclient variables for Framework Smoke Tests (flutter/engine#50403 )
2024-02-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Revert "Revert "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds""" (flutter/engine#50407 )
2024-02-06 matanlurey@users.noreply.github.com Skip flaking test on Windows nobody is fixing. (flutter/engine#50401 )
2024-02-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] Fix Scene clip bounds. Trigger resize on DPR Change." (flutter/engine#50404 )
2024-02-06 68449066+zijiehe-google-com@users.noreply.github.com Revert "Revert "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds"" (flutter/engine#50295 )
2024-02-06 chinmaygarde@google.com [Impeller] Specify if Angle or SwiftShader is being used in the title. (flutter/engine#50376 )
2024-02-06 matanlurey@users.noreply.github.com Run all Android `scenario_app` tests, not just the smoke test. (flutter/engine#50400 )
2024-02-06 skia-flutter-autoroll@skia.org Roll Dart SDK from b62066b42af0 to 29265c94a6e8 (10 revisions) (flutter/engine#50398 )
2024-02-06 matanlurey@users.noreply.github.com Capture `FAILURES!!!` when running Android `scenario_app` tests. (flutter/engine#50255 )
2024-02-06 jonnywang@google.com [fuchsia] Bump Fuchsia's API level to 16 (flutter/engine#50358 )
2024-02-06 skia-flutter-autoroll@skia.org Roll Skia from 9e68ed6caf6d to 44106ee8edea (1 revision) (flutter/engine#50393 )
2024-02-06 skia-flutter-autoroll@skia.org Roll Skia from c29a20702356 to 9e68ed6caf6d (1 revision) (flutter/engine#50392 )
2024-02-06 jonahwilliams@google.com [Impeller] Cache RenderPass/Framebuffer objects on the resolve texture sources. (flutter/engine#50142 )
2024-02-06 jason-simmons@users.noreply.github.com [Impeller] Do not skip the GLES render pass if the command list is empty (flutter/engine#50381 )
2024-02-06 skia-flutter-autoroll@skia.org Roll Skia from cdf214adfb4d to c29a20702356 (54 revisions) (flutter/engine#50382 )
2024-02-06 ditman@gmail.com [web] Fix Scene clip bounds. Trigger resize on DPR Change. (flutter/engine#50161 )
2024-02-06 xilaizhang@google.com [github actions] add cherry pick workflow for engine repo (flutter/engine#50265 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-06 23:49:18 +00:00
Simon Friis Vindum
2911bfb84c
Make destructiveRed a CupertinoDynamicColor ( #141364 )
...
`destructiveRed` is an alias for `systemRed`, but, in the definition, the precise type information is lost.
This PR gives `destructiveRed` the type `CupertinoDynamicColor` (and not the superclass `Color`) like all the other colors defined in this file.
2024-02-06 21:26:52 +00:00
