Victoria Ashworth
e98d3929ca
Revert "Run Mac_arm64_ios run_debug_test_macos in presubmit" ( #133808 )
...
Reverts flutter/flutter#133788
Something is wrong with bot https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-38 , it's unable to open the project in Xcode. Failing consistently.
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8771213845302282993/+/u/ios_debug_symbol_doctor/recover_with_120_second_timeout/stdout
So reverting until we can get the bot fixed.
2023-08-31 21:34:48 +00:00
Andrew Kolos
c263c56dc6
give --task-args option in test_runner a help description ( #133791 )
...
Fixes https://github.com/flutter/flutter/issues/133790
Provides help text for the `--task-args` option of the `test_runner` devicelab command. The current help text is just copypasta from another option's help text
2023-08-31 21:08:59 +00:00
Christopher Fujino
1519553bed
[flutter_tools] print out the unzipping method used by update_dart_sdk.ps1 ( #133364 )
...
in case there are future issues with unzipping the dart sdk, such as https://github.com/flutter/flutter/issues/132592 , we should log out what tool we are using to try to extract the archive.
2023-08-31 21:06:47 +00:00
Renzo Olivares
acdcbae78a
Revert "Fixing memory leak in EditableTextState" ( #133804 )
...
Reverts flutter/flutter#131377
reverting because of internal google testing failures b/298310760
2023-08-31 20:42:52 +00:00
Taha Tesser
f32b6fed24
Fix cursorColor with an opacity is not respected ( #133548 )
...
fixes [`cursorColor` with an opacity is not respected](https://github.com/flutter/flutter/issues/132886 )
<details>
<summary>expand to view the code sample</summary>
```dart
import "package:flutter/material.dart";
// import "package:flutter/scheduler.dart";
// final color = Colors.red;
const color = Color(0x55ff0000);
void main() {
// timeDilation = 4;
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
debugShowCheckedModeBanner: false,
home: Example(),
);
}
}
class Example extends StatefulWidget {
const Example({super.key});
@override
State<Example> createState() => _ExampleState();
}
class _ExampleState extends State<Example> {
late FocusNode _focusNode;
late TextEditingController _controller;
@override
void initState() {
super.initState();
_focusNode = FocusNode();
_controller = TextEditingController(text: 'Hello World');
}
@override
void dispose() {
_focusNode.dispose();
_controller.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
const bool cursorOpacityAnimates = false;
double cursorWidth = 6;
return Scaffold(
body: Center(
child: Padding(
padding: const EdgeInsets.symmetric(
horizontal: 16,
),
child: Column(
children: <Widget>[
const Spacer(),
const Text('EditableText'),
const SizedBox(height: 8),
InputDecorator(
decoration: InputDecoration(
border: OutlineInputBorder(
borderRadius: BorderRadius.circular(8),
),
),
child: EditableText(
cursorColor: color,
cursorWidth: cursorWidth,
cursorOpacityAnimates: cursorOpacityAnimates,
focusNode: _focusNode,
controller: _controller,
style: Theme.of(context).textTheme.bodyLarge!,
backgroundCursorColor: Colors.amber,
onSubmitted: (String value) {
// Add your code here.
},
),
),
const Spacer(),
const Text('TextField'),
const SizedBox(height: 8),
TextField(
cursorColor: color,
cursorWidth: cursorWidth,
cursorOpacityAnimates: cursorOpacityAnimates,
controller: _controller,
focusNode: _focusNode,
onSubmitted: (String value) {
// Add your code here.
},
),
const Spacer(),
],
),
),
),
);
}
}
```
</details>
### Before
### After
2023-08-31 19:49:06 +00:00
Victoria Ashworth
8128b2e2f6
Run Mac_arm64_ios run_debug_test_macos in presubmit ( #133788 )
...
Fixes https://github.com/flutter/flutter/issues/118830 .
2023-08-31 19:41:07 +00:00
Jim Graham
b51859ec33
Add benchmark for scrolling very long pictures ( #133434 )
...
This benchmark will track the performance of the RTree implementation to cull very large pictures down to just the portion visible on the screen.
2023-08-31 19:03:14 +00:00
engine-flutter-autoroll
82ded60350
Roll Flutter Engine from e8de3dd63d47 to 51090e3cfe79 (2 revisions) ( #133784 )
...
e8de3dd63d...51090e3cfeskia-flutter-autoroll@skia.org Roll Skia from a295ff96782a to d113402de2ce (1 revision) (flutter/engine#45324 )
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from a13a9d6efbbc to a295ff96782a (2 revisions) (flutter/engine#45321 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 18:01:06 +00:00
Polina Cherkasova
127b90e1de
Test cover more tests with leak tracking. ( #133712 )
2023-08-31 10:19:13 -07:00
Polina Cherkasova
c1256d5353
_FocusTraversalGroupNode should communicate creation in constructor. ( #133717 )
2023-08-31 10:18:19 -07:00
Polina Cherkasova
54402ae375
_ResetNotifier should communicate creation in constructor. ( #133716 )
2023-08-31 10:18:04 -07:00
yusuf-goog
a14989b3bf
Tweaking CSS to make object docs more legible. ( #133711 )
...
Bug:None
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-08-31 17:16:05 +00:00
Victoria Ashworth
c57e4e79a2
Revert "Cover some test/widgets tests with leak tracking" ( #133779 )
...
Reverts flutter/flutter#133767
Causing failures to Mac framework_tests_widgets and Linux framework_tests_widgets
2023-08-31 16:46:02 +00:00
Pierrick Bouvier
792e26df95
[Windows] Add target architecture to build path ( #131843 )
...
To implement windows-arm64 support, it is needed to add architecture as a subdirectory (https://github.com/flutter/flutter/issues/129805 ).
In short, when performing a flutter windows build, we have:
- Before: build/windows/runner/Release/gallery.exe
- After: build/windows/x64/runner/Release/gallery.exe
This convention follows what flutter linux build does.
Addresses: https://github.com/flutter/flutter/issues/129805
Addresses: https://github.com/flutter/flutter/issues/116196
Design doc: [flutter.dev/go/windows-arm64](https://flutter.dev/go/windows-arm64 )
2023-08-31 09:09:02 -07:00
Kostia Sokolovskyi
be06151e7d
Cover some test/widgets tests with leak tracking ( #133767 )
2023-08-31 09:02:49 -07:00
Kostia Sokolovskyi
414bff1403
ScrollController creation dispatching for memory leaks tracking ( #133759 )
2023-08-31 08:52:06 -07:00
engine-flutter-autoroll
7fe4571af2
Roll Flutter Engine from 1809b05a37a3 to e8de3dd63d47 (1 revision) ( #133766 )
...
1809b05a37...e8de3dd63dskia-flutter-autoroll@skia.org Roll Skia from 47a7d27ceb93 to a13a9d6efbbc (2 revisions) (flutter/engine#45319 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 15:51:33 +00:00
engine-flutter-autoroll
28ec737d39
Roll Packages from 64af59e00bb7 to e7d812cefce0 (6 revisions) ( #133765 )
...
64af59e00b...e7d812cefc50271102+talhakhan1297@users.noreply.github.com [path_provider] Fix93198: Added getDownloadsDirectory() for Android (flutter/packages#4708 )
2023-08-30 stuartmorgan@google.com [in_app_purchase] Minor lint cleanup (flutter/packages#4818 )
2023-08-30 tarrinneal@gmail.com [local_auth] Update to pigeon 11 and remove enum wrappers (flutter/packages#4809 )
2023-08-30 vital@hey.com [image_picker] Fix link in README file. (flutter/packages#4775 )
2023-08-30 mouad.debbar@gmail.com [web] Use new APIs from `dart:ui_web` (flutter/packages#4168 )
2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter from 6c95737375db to 1fe24956ac46 (24 revisions) (flutter/packages#4817 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 15:45:49 +00:00
engine-flutter-autoroll
5a2b8dc4e6
Roll Flutter Engine from 772d5e996af8 to 1809b05a37a3 (1 revision) ( #133762 )
...
772d5e996a...1809b05a37skia-flutter-autoroll@skia.org Roll Skia from 1fae612aee7d to 47a7d27ceb93 (1 revision) (flutter/engine#45318 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 15:06:05 +00:00
Victoria Ashworth
c175cf87a6
Ignore macOS Cocoapods linting failure on DT_TOOLCHAIN_DIR error ( #133588 )
...
Xcode 15 introduced an [error](https://github.com/flutter/flutter/issues/132755 ) into Cocoapods when building macOS apps.
When `pod lib lint` runs, it under the covers is building the app with `xcodebuild`, which is why this error occurs when linting.
A fix has been made in Cocoapods, but is not in an official release so we can't upgrade Cocoapods yet. This is to temporarily ignore lint failure due to that error.
Fixes https://github.com/flutter/flutter/issues/132980 .
Tracking issue to upgrade Cocoapods when fix is in a release: https://github.com/flutter/flutter/issues/133584
Since Xcode 15 isn't in CI, I tested it in a one-off led test:
* [Pre-fix failure](https://chromium-swarm.appspot.com/task?id=6431f228ecf98e10 )
* [Post-fix success](https://chromium-swarm.appspot.com/task?id=645ba7ebdab97210 )
2023-08-31 14:57:07 +00:00
Delwin Mathew
dd1ee24fc2
InputDecorationTheme.isCollapsed doesn't work if InputDecoration.isCollapsed is not provided. (#133189 )
...
`appleDefault` method didn't include setting values for non-null (here `isCollapsed`) parameters initially, which has been updated and documented in this commit.
Existing and new tests are passing.
Fixes #133144
2023-08-31 13:29:18 +00:00
engine-flutter-autoroll
9e9aa810be
Roll Flutter Engine from 5156c03344eb to 772d5e996af8 (1 revision) ( #133752 )
...
5156c03344...772d5e996askia-flutter-autoroll@skia.org Roll Skia from 5f17219305ff to 1fae612aee7d (1 revision) (flutter/engine#45317 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 11:05:24 +00:00
engine-flutter-autoroll
5e16d2ca75
Roll Flutter Engine from 1917fa95ea55 to 5156c03344eb (2 revisions) ( #133745 )
...
1917fa95ea...5156c03344skia-flutter-autoroll@skia.org Roll Skia from 676a16152834 to 5f17219305ff (1 revision) (flutter/engine#45316 )
2023-08-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gWpPuUyuR_hmz9Xmg... to 7sFO_YvenNXCm6TdK... (flutter/engine#45315 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from gWpPuUyuR_hm to 7sFO_YvenNXC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 08:51:40 +00:00
engine-flutter-autoroll
0700801e23
Roll Flutter Engine from 1f1071d3f5ba to 1917fa95ea55 (2 revisions) ( #133739 )
...
1f1071d3f5...1917fa95easkia-flutter-autoroll@skia.org Roll Skia from adaad6716b2c to 676a16152834 (1 revision) (flutter/engine#45314 )
2023-08-31 matej.knopp@gmail.com [macOS] Implement unobstructed platform views (flutter/engine#42960 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 08:05:24 +00:00
engine-flutter-autoroll
5603935d75
Roll Flutter Engine from e88b21b6d4e8 to 1f1071d3f5ba (1 revision) ( #133737 )
...
e88b21b6d4...1f1071d3f5skia-flutter-autoroll@skia.org Roll Skia from af7fb958e7f7 to adaad6716b2c (1 revision) (flutter/engine#45312 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 07:09:23 +00:00
engine-flutter-autoroll
dd51bf0970
Roll Flutter Engine from 0559a733c888 to e88b21b6d4e8 (1 revision) ( #133735 )
...
0559a733c8...e88b21b6d4skia-flutter-autoroll@skia.org Roll Skia from 5f3ef5363dbd to af7fb958e7f7 (1 revision) (flutter/engine#45311 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 04:58:35 +00:00
engine-flutter-autoroll
cfdb91bfd6
Roll Flutter Engine from 3b75e3de7ef3 to 0559a733c888 (1 revision) ( #133734 )
...
3b75e3de7e...0559a733c8jonahwilliams@google.com [Impeller] CoverGeometry transforms its bounds. (flutter/engine#45308 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 04:06:26 +00:00
Jonah Williams
a0862f1c3f
[framework] use ImageFilter for stretch overscroll. ( #133613 )
...
Rather than changing the size of the child elements (relaying out text
and potentially changing glyph shape and position due to pixel
snapping), apply the stretch effect as a compositing effect - render the
children to a texture and stretch the texture. If we end up using an
image shader to apply an custom shader we'll need to do this anyway.
Fixes https://github.com/flutter/flutter/issues/129528
### Before
https://github.com/flutter/flutter/assets/8975114/16e9eb57-f864-4093-b4a4-461082b89b43
### After
https://github.com/flutter/flutter/assets/8975114/14cf0167-8922-4876-a325-e3bc154b084f
2023-08-30 18:58:42 -07:00
engine-flutter-autoroll
5296f8468f
Roll Flutter Engine from 73e86369614d to 3b75e3de7ef3 (2 revisions) ( #133724 )
...
73e8636961...3b75e3de7ednfield@google.com [Impeller] Reland DlAiksCanvas
(flutter/engine#45232 )
2023-08-31 matanlurey@users.noreply.github.com Add a
build_bucket_golden_scraper tool. (flutter/engine#45243 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 18:55:38 -07:00
engine-flutter-autoroll
2434a9d98b
Roll Flutter Engine from 8f1b77b1ac69 to 73e86369614d (1 revision) ( #133720 )
...
8f1b77b1ac...73e8636961matanlurey@users.noreply.github.com Add a `DlStopwatchVisualizer` and conditionally use it for Impeller (flutter/engine#45259 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 01:13:24 +00:00
engine-flutter-autoroll
4b0bbe9059
Roll Flutter Engine from d37cef84d40d to 8f1b77b1ac69 (1 revision) ( #133714 )
...
d37cef84d4...8f1b77b1acskia-flutter-autoroll@skia.org Roll Skia from 185fbe1a264d to 5f3ef5363dbd (9 revisions) (flutter/engine#45305 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 00:10:24 +00:00
Polina Cherkasova
be3e64abf1
Mark leak in _DraggableScrollableSheetState. ( #133693 )
2023-08-30 17:09:09 -07:00
Polina Cherkasova
2bc4c7a888
Mark routing test as leaking. ( #133697 )
2023-08-30 16:25:18 -07:00
engine-flutter-autoroll
784629c938
Roll Flutter Engine from b63eee2e31cc to d37cef84d40d (3 revisions) ( #133706 )
...
b63eee2e31...d37cef84d4jacksongardner@google.com [web] Roll to most recent fallback font data (flutter/engine#45301 )
2023-08-30 matanlurey@users.noreply.github.com Increase maximum length of function names from 30 to 60. (flutter/engine#45296 )
2023-08-30 jacksongardner@google.com Add an API in `ui_web` to create a `ui.Image` from an `ImageBitmap` (flutter/engine#45256 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 23:23:37 +00:00
Polina Cherkasova
95e197ba69
_RawAutocompleteState should dispose _highlightedOptionIndex. ( #133700 )
2023-08-30 16:07:35 -07:00
Matan Lurey
31600c829e
Forward-fix a test that will break with an engine roll. ( #133619 )
...
See https://github.com/flutter/engine/pull/44705 where it fails a framework smoke test.
Partial work towards https://github.com/flutter/flutter/issues/112498 .
2023-08-30 22:29:05 +00:00
Taha Tesser
d7a3a68275
Fix cancelButtonStyle & confirmButtonStyle properties from TimePickerTheme aren't working ( #132843 )
...
fixes [`TimePickerThemeData` action buttons styles aren't working](https://github.com/flutter/flutter/issues/132760 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
useMaterial3: true,
timePickerTheme: TimePickerThemeData(
cancelButtonStyle: TextButton.styleFrom(
shape: const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(4)),
side: BorderSide(color: Colors.red),
),
backgroundColor: Colors.white,
foregroundColor: Colors.red,
elevation: 3,
shadowColor: Colors.red,
),
confirmButtonStyle: TextButton.styleFrom(
shape: const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(4)),
),
backgroundColor: Colors.green[700],
foregroundColor: Colors.white,
elevation: 3,
shadowColor: Colors.green[700],
),
),
),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: TimePickerDialog(initialTime: TimeOfDay.now()),
),
);
}
}
```
</details>
### Before (action buttons don't use the style from the `TimePickerTheme`)
### After (action buttons use the style from the `TimePickerTheme`)
2023-08-30 22:21:29 +00:00
Hans Muller
336d60d29c
Updated DropdownMenu example and added a test ( #133592 )
2023-08-30 14:33:54 -07:00
Taha Tesser
1e770c3808
Add cancelButtonStyle & confirmButtonStyle to the DatePickerThemeData ( #132847 )
...
fixes [Unable to adjust the color for "Cancel" and "Ok" button in datePicker dialog](https://github.com/flutter/flutter/issues/127739 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
useMaterial3: true,
datePickerTheme: DatePickerThemeData(
cancelButtonStyle: TextButton.styleFrom(
shape: const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(16)),
side: BorderSide(color: Colors.red),
),
backgroundColor: Colors.white,
foregroundColor: Colors.red,
elevation: 3,
shadowColor: Colors.red,
),
confirmButtonStyle: TextButton.styleFrom(
shape: const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(16)),
),
backgroundColor: Colors.green[700],
foregroundColor: Colors.white,
elevation: 3,
shadowColor: Colors.green[700],
),
),
),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: DatePickerDialog(
initialDate: DateTime.now(),
firstDate: DateTime(2020),
lastDate: DateTime(2030),
),
),
);
}
}
```
</details>
### Before
Not possible to customize action buttons from the `DatePickerThemeData`.
### After
2023-08-30 21:16:13 +00:00
engine-flutter-autoroll
2f2a10d540
Roll Flutter Engine from 31d5662dcb53 to b63eee2e31cc (1 revision) ( #133692 )
...
31d5662dcb...b63eee2e31jason-simmons@users.noreply.github.com [Impeller] Reorganize the glyph atlas to improve efficiency when looking up runs of glyphs in the same font (flutter/engine#45191 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 21:06:25 +00:00
Renzo Olivares
4b89fce108
Fixing memory leak in EditableTextState ( #131377 )
2023-08-30 12:49:56 -07:00
engine-flutter-autoroll
d1410a11b6
Roll Flutter Engine from 69f04bdfe952 to 31d5662dcb53 (14 revisions) ( #133683 )
...
69f04bdfe9...31d5662dcbskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Y2xfuZM0ec5GQfHV8... to gWpPuUyuR_hmz9Xmg... (flutter/engine#45287 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 7a246c9eb086 to 185fbe1a264d (3 revisions) (flutter/engine#45289 )
2023-08-30 30870216+gaaclarke@users.noreply.github.com Revert "Roll Dart SDK from 0cea73a8d3c3 to 96d3a79547fc" (flutter/engine#45285 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 3489b6d1d613 to 7a246c9eb086 (4 revisions) (flutter/engine#45286 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from a58ccf8ae398 to 3489b6d1d613 (2 revisions) (flutter/engine#45283 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 6f4fd97d2f7e to a58ccf8ae398 (1 revision) (flutter/engine#45280 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from a2728a7ad2a3 to 6f4fd97d2f7e (2 revisions) (flutter/engine#45278 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 7492e29ad235 to a2728a7ad2a3 (1 revision) (flutter/engine#45273 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 80f4d2f303d0 to 7492e29ad235 (1 revision) (flutter/engine#45272 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 03289b20b5d3 to 80f4d2f303d0 (1 revision) (flutter/engine#45270 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 96d3a79547fc to 4352efd8497d (1 revision) (flutter/engine#45267 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from fde9fe141863 to 03289b20b5d3 (1 revision) (flutter/engine#45268 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from QKekosWnIY_ObKstn... to Y2xfuZM0ec5GQfHV8... (flutter/engine#45265 )
2023-08-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 0cea73a8d3c3 to 96d3a79547fc (1 revision) (flutter/engine#45262 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from QKekosWnIY_O to gWpPuUyuR_hm
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 19:41:23 +00:00
Bruno Leroux
b23105276f
Expose barrierDismissible in PageRoute constructor ( #133659 )
...
## Description
This PR exposes `barrierDismissible` in `PageRoute`, `MaterialPageRoute` and `CupertinoPageRoute` constructors.
Setting this property to true will enable the escape key binding.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/132138 .
## Tests
Adds one test.
2023-08-30 19:02:06 +00:00
Ricardo Amador
15048a6b04
Update the infrastructure issue template ( #133519 )
...
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-08-30 18:51:04 +00:00
LongCatIsLooong
7f3abea35a
Reland "Remove ImageProvider.load, DecoderCallback and PaintingBinding.instantiateImageCodec ( #132679 ) (reverted in #133482 ) ( #133605 )
...
Relanding the commit per
https://github.com/flutter/flutter/pull/133482#issuecomment-1698030976
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-30 11:28:10 -07:00
engine-flutter-autoroll
d49eb4afac
Roll Packages from d7d3150e5966 to 64af59e00bb7 (4 revisions) ( #133675 )
...
d7d3150e59...64af59e00bkatelovett@google.com [two_dimensional_scrollables] Fix repaint boundary override in builder delegate (flutter/packages#4814 )
2023-08-29 stuartmorgan@google.com [all] Add topics to pubspecs (flutter/packages#4771 )
2023-08-29 engine-flutter-autoroll@skia.org Roll Flutter from ec387a467a68 to 6c95737375db (24 revisions) (flutter/packages#4813 )
2023-08-29 panuj330@gmail.com Fixed AlertDialog Height of example in image_picker (flutter/packages#4800 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 16:41:01 +00:00
Taha Tesser
994aab4c78
Update & improve TabBar.labelColor tests ( #133668 )
...
fixes [Improve `TabBar.labelColor` tests](https://github.com/flutter/flutter/issues/133665 )
While working on a fix for https://github.com/flutter/flutter/issues/109484 , I found the existing test could use some improvement first.
2023-08-30 16:40:59 +00:00
Zachary Anderson
44a9b36461
Bump gradle heap size limits in templates ( #133671 )
...
For https://github.com/flutter/flutter/issues/133639
2023-08-30 15:40:14 +00:00
Flutter GitHub Bot
7368da037a
Marks Windows module_test to be flaky ( #133640 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows module_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/133639
2023-08-30 08:00:14 -07:00
Bruno Leroux
1fe24956ac
Update SelectableRegion test for M3 ( #129627 )
...
## Description
This PR fixes one selectable region test failure when switching to M3.
The failure is somewhat tricky because it is related to the M3 typography (line height set to 1.43).
## Related Issue
fixes https://github.com/flutter/flutter/issues/129626
## Tests
Updates 1 test.
2023-08-30 13:25:35 +00:00
