firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
83,011 Commits 1 Branch 0 Tags
Commit Graph

29915 Commits

Author SHA1 Message Date
Bryan Oltman
4eb0bd7d98 Cast ::GetLastError to int (flutter/engine#57113) 
`GetLastError` returns an unsigned 32 bit integer that was being
implicitly cast to an int for the std::variant<..., int>. This was
causing my build to fail with:

```
../../flutter/shell/platform/windows/platform_handler.cc(178,12): error: no viable conversion from returned value of type 'DWORD' (aka 'unsigned long') to function return type 'std::variant<std::wstring, int>' (aka 'variant<basic_string<wchar_t, char_traits<wchar_t>, allocator<wchar_t>>, int>')
  178 |     return ::GetLastError();
      |            ^~~~~~~~~~~~~~~~
../../../../../../../Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.42.34433/include\variant(923,7): note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'DWORD' (aka 'unsigned long') to 'const variant<basic_string<wchar_t>, int> &' for 1st argument
  923 | class variant : private _SMF_control<_Variant_destroy_layer<_Types...>, _Types...> { // discriminated union
      |       ^~~~~~~
```

Commands:

```
 ./flutter/tools/gn --runtime-mode release --no-rbe
ninja -C .\out\host_release windows gen_snapshot flutter/build/archives:windows_flutter
```

Explicitly casting `::GetLastError` to an int fixes this issue.

I'm running on Windows 11 (Version 10.0.26100 Build 26100) with VS 2022
Community Edition.

@loic-sharma

Co-authored-by: Eric Seidel <eric@shorebird.dev>
 2024-12-11 17:23:11 -08:00
Jonah Williams
b6064c9224 Manual Skia roll from 79a7b95e32fe to 0aec6f7bfbc8 (flutter/engine#57134) 
skia-flutter-autoroll
Member
[skia-flutter-autoroll](https://github.com/skia-flutter-autoroll) commented [1 hour ago](https://github.com/flutter/engine/pull/57131#issue-2733701367)
https://skia.googlesource.com/skia.git/+log/79a7b95e32fe..0aec6f7bfbc8

2024-12-11 [jvanverth@google.com](mailto:jvanverth@google.com) [graphite] Force ordered recordings in nanobench.
2024-12-11 [nicolettep@google.com](mailto:nicolettep@google.com) [graphite] Rename snippet requirement flag to more clearly express purpose
2024-12-11 [skia-autoroll@skia-public.iam.gserviceaccount.com](mailto:skia-autoroll@skia-public.iam.gserviceaccount.com) Roll Skia Infra from a42d0274444b to 0849df86a686 (7 revisions)
2024-12-11 [vigneshv@google.com](mailto:vigneshv@google.com) Revert "Reland "Reland "SkCodec: Remove the sysprop guard for SkCrabbyAvifCodec"""
2024-12-11 [fmalita@google.com](mailto:fmalita@google.com) Clamp index values in SkVertices factories
2024-12-11 [skia-autoroll@skia-public.iam.gserviceaccount.com](mailto:skia-autoroll@skia-public.iam.gserviceaccount.com) Manual roll vulkan-deps from b5e5616193ec to 769bd5140c26 (8 revisions)
2024-12-11 [skia-autoroll@skia-public.iam.gserviceaccount.com](mailto:skia-autoroll@skia-public.iam.gserviceaccount.com) Manual roll Dawn from 052be48b9a1a to 01d91c0571a2 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [jonahwilliams@google.com](mailto:jonahwilliams@google.com),[kjlubick@google.com](mailto:kjlubick@google.com),[maxhudnell@google.com](mailto:maxhudnell@google.com) on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-12 01:08:19 +00:00
gaaclarke
6aeeb645df Removed heap allocations for conical, radial and sweep gradients (flutter/engine#57143) 
fixes https://github.com/flutter/flutter/issues/154650

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/engine/blob/main/docs/testing/Testing-the-engine.md
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
 2024-12-11 15:45:13 -08:00
Jonah Williams
c576a7c716 [Impeller] remove std::vector usage in render pass vk. (flutter/engine#57132) 
Remove std::vector usage in vulkan render pass. Fixed size array + offsets, should be faster than heap allocations.
 2024-12-11 22:15:33 +00:00
Balint Rozgonyi
41009bcda1 [Linux] Add Multi-Touch Support for Linux (flutter/engine#54214) 
This draft PR aims to address the lack of multi-touch support under Linux, leveraging the existing implementation used for Windows. As I am not an expert in this domain, I would greatly appreciate feedback on the implementation.

https://github.com/flutter/flutter/issues/133239
https://github.com/flutter/flutter/issues/52202

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-11 22:05:04 +00:00
skia-flutter-autoroll
8cfbdd7174 Roll Dart SDK from be9c98daf9df to aa03dca5beb2 (1 revision) (flutter/engine#57136) 
https://dart.googlesource.com/sdk.git/+log/be9c98daf9df..aa03dca5beb2

2024-12-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-237.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 21:54:56 +00:00
Jason Simmons
381cd71316 Make Felt unzip Chrome into a temporary directory next to the final location of the files (flutter/engine#57109) 
The Web Felt script downloads a Chrome zip archive, extracts it to a temporary directory, and then moves the files to a location expected by the script.

Previously Felt used a temporary directory based on io.Directory.systemTemp.  This may not work because the FileSystemEntity.rename operation used to move the files can fail if the system temp directory is located in a different filesystem from the destination directory.
 2024-12-11 21:28:16 +00:00
Jonah Williams
f8a0105146 [engine] changes to DlVertices::Builder and Stopwatch visualizer. (flutter/engine#57031) 
Collection of changes to DlVertices::Builder and the stopwatch visualizer.

At a high level:

* improve performance of the stopwatch visualizer by pre-allocating storage (and sharing it across both visualizers), lookup up font once, and cache the debug frame rate used. Updates to use Dl types instead of SkTypes.

* Change DlVerticesBuilder to allow storing the bounds and use that in the visualizer, since we already know them. Make FML_CHECKS into dchecks, as the dart:ui vertices will already bounds check correctly - so these should only be necessary for debugging engine changes.
 2024-12-11 21:03:06 +00:00
Jonah Williams
7a2260956f [Impeller] avoid expensive texture labeling w/ no validation layers. (flutter/engine#57130) 
Labelling textures shows up in all of our profiles because of the cost to lock the context weak ptr and then call into both the image and image view. remove this if no layers are present that would read the label.
 2024-12-11 20:51:20 +00:00
Jonah Williams
68142a735d [Impeller] set UniformBlockBinding once. (flutter/engine#57094) 
gl.UniformBlockBinding only needs to be set once when the pipeline is linked, and not on every draw.
 2024-12-11 18:08:16 +00:00
skia-flutter-autoroll
9fd0734154 Roll Fuchsia Linux SDK from 5taAI9-tnFN84ZJvr... to HJ57Y3zxqDamI8qkY... (flutter/engine#57125) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 17:57:48 +00:00
gaaclarke
17b5cbe28d Removed linear gradient heap allocation for color conversions between dart and display list (flutter/engine#57108) 
issue: https://github.com/flutter/flutter/issues/154650

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/engine/blob/main/docs/testing/Testing-the-engine.md
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
 2024-12-11 09:32:04 -08:00
Jason Simmons
03acf8c635 Dispose pictures created in HtmlViewEmbedder.submitFrame (flutter/engine#57102) 
See https://github.com/flutter/flutter/issues/153678
 2024-12-11 17:14:14 +00:00
skia-flutter-autoroll
51d6f28c6a Roll Dart SDK from 4789a86f4d3f to be9c98daf9df (1 revision) (flutter/engine#57124) 
https://dart.googlesource.com/sdk.git/+log/4789a86f4d3f..be9c98daf9df

2024-12-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-236.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 17:02:18 +00:00
skia-flutter-autoroll
f613aeb267 Roll Dart SDK from d87b2f6d2b03 to 4789a86f4d3f (1 revision) (flutter/engine#57119) 
https://dart.googlesource.com/sdk.git/+log/d87b2f6d2b03..4789a86f4d3f

2024-12-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-235.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 08:00:33 +00:00
skia-flutter-autoroll
61de0da85f Roll Skia from b2f13d9a5678 to 830bc24e0b98 (1 revision) (flutter/engine#57118) 
https://skia.googlesource.com/skia.git/+log/b2f13d9a5678..830bc24e0b98

2024-12-11 kjlubick@google.com Remove SK_PDF_BASE85_BINARY and SK_PDF_LESS_COMPRESSION

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jonahwilliams@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 07:06:09 +00:00
skia-flutter-autoroll
81c898f771 Roll Dart SDK from f863f0b43625 to d87b2f6d2b03 (2 revisions) (flutter/engine#57110) 
https://dart.googlesource.com/sdk.git/+log/f863f0b43625..d87b2f6d2b03

2024-12-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-234.0.dev
2024-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-233.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 06:26:05 +00:00
skia-flutter-autoroll
8e4c32ad4b Roll Skia from 854eb19c722e to b2f13d9a5678 (1 revision) (flutter/engine#57114) 
https://skia.googlesource.com/skia.git/+log/854eb19c722e..b2f13d9a5678

2024-12-11 kjlubick@google.com Update IWYU map to make better suggestions around std::swap and std::move

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jonahwilliams@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-11 05:19:53 +00:00
Michael Goderbauer
e6cc4d48cb Add support for dart formatter (flutter/engine#57075) 
Currently it is off by default since we haven't migrated any files over to the new format. To try it out, run `dart ci/bin/format.dart -c dart -f`.

Once we turn it on by default `et` will automatically format dart files as it calls into `format.dart`.
 2024-12-11 00:02:05 +00:00
skia-flutter-autoroll
53b543cabf Roll Skia from d541f1aa0c9b to e4d2c3dbb848 (2 revisions) (flutter/engine#57106) 
https://skia.googlesource.com/skia.git/+log/d541f1aa0c9b..e4d2c3dbb848

2024-12-10 bungeman@google.com Roll FreeType from 83af801b to 59320b2d (16 commits)
2024-12-10 kjlubick@google.com Fix IWYU after recent change

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jonahwilliams@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 22:13:59 +00:00
skia-flutter-autoroll
30d4785501 Roll Dart SDK from dd92932823d1 to f863f0b43625 (1 revision) (flutter/engine#57104) 
https://dart.googlesource.com/sdk.git/+log/dd92932823d1..f863f0b43625

2024-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-232.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 22:08:04 +00:00
Robert Ancell
85b89155d5 Clean up key embedder responder tests (flutter/engine#57054) 
Remove global variable.
Rename function so doesn't look like provided by GLib.
Use g_autoptr to remove explicit unref.
Move type definition inline.
 2024-12-11 10:58:22 +13:00
Jonah Williams
e263222f14 [Impeller] reland: switch Pipeline to use raw ptr instead of shared ptr for recorded references. (flutter/engine#57086) 
Prev: https://github.com/flutter/engine/pull/57015

There is a unit test that is clearing out the pipeline storage, manually null out captured PipelineRef.
 2024-12-10 21:18:46 +00:00
skia-flutter-autoroll
d8cdd81d3e Roll Skia from bd7d952398d5 to d541f1aa0c9b (3 revisions) (flutter/engine#57098) 
https://skia.googlesource.com/skia.git/+log/bd7d952398d5..d541f1aa0c9b

2024-12-10 kjlubick@google.com Reapply "Move SkJSON.h to //modules/jsonreader"
2024-12-10 tikuta@google.com add missing includes for the build with use_libcxx_modules
2024-12-10 kjlubick@google.com Make SkAAClip not reject large paths if clip is small enough.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jonahwilliams@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 19:17:11 +00:00
Chris Bracken
721eec4d5b iOS: Add null checks on shell dereference (flutter/engine#57099) 
`FlutterEngine` at the `_shell` unique_ptr ivar it owns have different lifetimes. `_shell` is initialised transitively from `runWithEntrypoint`, and reset in `[FlutterEngine destroyContext]`, which is called transitively from `[FlutterviewController dealloc]` via `[FlutterEngine notifyViewControllerDeallocated]`.

As such, all uses of `_shell` should be checked either via an assertion, in cases we know the shell should be non-null, or via a runtime null check in cases where it's expected that it may be null.

Specifically, this guards against a crash that can occur if we get a CoreAnimation transaction commit callback for an inflight frame just as we're shutting down the app (or removing the FlutterView in an add-to-app scenario).

Example stack trace:
```
0  Flutter                        0x11b28 -[FlutterEngine platformView] + 53 (weak_ptr.h:53)
1  Flutter                        0x11994 -[FlutterEngine updateViewportMetrics:] + 186 (ref_ptr.h:186)
2  Flutter                        0x1f854 -[FlutterViewController updateViewportMetricsIfNeeded] + 427 (vector:427)
3  Flutter                        0x1f9b8 -[FlutterViewController viewDidLayoutSubviews] + 1411 (FlutterViewController.mm:1411)
4  UIKitCore                      0x8c864 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 2376
5  QuartzCore                     0x1fa0c CA::Layer::layout_if_needed(CA::Transaction*) + 516
6  QuartzCore                     0x1ae84c CA::Context::commit_transaction(CA::Transaction*, double, double*) + 516
7  QuartzCore                     0x2888 CA::Transaction::commit() + 648
```

Issue: https://github.com/flutter/flutter/issues/98735
Issue: https://github.com/flutter/flutter/issues/159639

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-10 19:06:13 +00:00
Brandon Castellano
9d726bb38e [engine] Migrate fuchsia.io Open functions to Open3 (flutter/engine#56818) 
Migrate the use of fuchsia.io open functions to the new open3 replacements (which also requires transitioning from OpenFlags -> Flags). Likewise, we update all uses of the SDK VFS library to use the new set of flags.

This work is being done as part of the ongoing io2 migration in https://fxbug.dev/378924259

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-10 19:02:01 +00:00
skia-flutter-autoroll
7df25145cc Roll Dart SDK from 1a28e6c86b09 to dd92932823d1 (1 revision) (flutter/engine#57096) 
https://dart.googlesource.com/sdk.git/+log/1a28e6c86b09..dd92932823d1

2024-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-231.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 17:44:29 +00:00
skia-flutter-autoroll
44532171ba Roll Dart SDK from d3a963b2f237 to 1a28e6c86b09 (3 revisions) (flutter/engine#57091) 
https://dart.googlesource.com/sdk.git/+log/d3a963b2f237..1a28e6c86b09

2024-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-230.0.dev
2024-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-229.0.dev
2024-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-228.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 13:31:31 +00:00
skia-flutter-autoroll
a2ffd3b55a Roll Fuchsia Linux SDK from tVShMDVFeKJFcDFHJ... to 5taAI9-tnFN84ZJvr... (flutter/engine#57090) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 13:07:14 +00:00
skia-flutter-autoroll
8d24e8a0c7 Roll Dart SDK from 9694974b6d41 to d3a963b2f237 (1 revision) (flutter/engine#57072) 
https://dart.googlesource.com/sdk.git/+log/9694974b6d41..d3a963b2f237

2024-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-227.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 07:52:24 +00:00
skia-flutter-autoroll
66c89e1b8e Roll Skia from 949557697922 to bd7d952398d5 (3 revisions) (flutter/engine#57087) 
https://skia.googlesource.com/skia.git/+log/949557697922..bd7d952398d5

2024-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ca6066d7097c to a42d0274444b (4 revisions)
2024-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d91e98d1aa3f to 7e54d43d6905 (1 revision)
2024-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 22a8762fea90 to 6f3bd8a864bf (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 07:33:07 +00:00
skia-flutter-autoroll
2e891742b6 Roll Skia from 3a58be4817a8 to e11d70745224 (2 revisions) (flutter/engine#57082) 
https://skia.googlesource.com/skia.git/+log/3a58be4817a8..e11d70745224

2024-12-09 lukasza@chromium.org [rust png] Support for encoding `tEXt` chunks.
2024-12-09 kylechar@chromium.org Set FragmentState::constants

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 04:01:17 +00:00
gaaclarke
33306239b4 Revert "[Impeller] switch Pipeline to use raw ptr instead of shared ptr for recorded references." (flutter/engine#57079) 
Reverts flutter/engine#57015
fixes https://github.com/flutter/flutter/issues/160004
 2024-12-09 17:30:26 -08:00
Jonah Williams
b425a87fd3 [Impeller] simplify render target size rounding up heuristics. (flutter/engine#57043) 
Remove the over-engineered "slide around round up" herusistic for the same heuristic used by the image filters: if the coverage size is within 30% of the cull rect size, just use the cull rect size.

This stabilizes allocations for the new android slide in page transition, but in a less complicated way than the old herustic.
 2024-12-10 01:16:23 +00:00
gaaclarke
2695e35d9d moved device buffer to an untracked handle (flutter/engine#57021) 
fixes: https://github.com/flutter/flutter/issues/159745

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-09 23:00:57 +00:00
Jonah Williams
81d3d7fbca [Impeller] switch Pipeline to use raw ptr instead of shared ptr for recorded references. (flutter/engine#57015) 
Fixes https://github.com/flutter/flutter/issues/159566

We don't need recorded commands to keep pipelines alive as the context does that already.
 2024-12-09 20:42:03 +00:00
Jonah Williams
5964dc2244 [Impeller] disable all Adrenos older than 630 (flutter/engine#57069) 
Fixes https://github.com/flutter/flutter/issues/159834

Disable all older Adreno GPUs
 2024-12-09 20:32:33 +00:00
Brandon DeRosier
4b87db55c6 Roll Skia to 14f8f6d984ff (flutter/engine#57068) 
Resolves https://github.com/flutter/engine/pull/57068.

Set args `skia_use_libpng_decode=true` and `skia_use_rust_png_decode=false`.

https://skia.googlesource.com/skia.git/+log/e78dd0265002..14f8f6d984ff

2024-12-09 kjlubick@google.com Update GN build to allow for rust PNG decoding only
2024-12-09 lukasza@chromium.org [rust png] Update Skia => `png` dependency to version 0.17.15.
2024-12-09 kjlubick@google.com Add placeholder files for jsonreader
 2024-12-09 20:29:19 +00:00
Robert Ancell
f3c1d7bab8 Make fl_key_channel_responder_handle_event async (flutter/engine#56959) 
Replace a callback with a more standard async call
 2024-12-10 09:06:22 +13:00
Jonah Williams
529d0d6757 [Impeller] use ES3 extension for external images. (flutter/engine#57018) 
The shader language level is 300 or more we need to use GL_OES_EGL_image_external_essl3 instead of GL_OES_EGL_image_external
 2024-12-09 18:25:00 +00:00
skia-flutter-autoroll
15af0c4f83 Roll Dart SDK from 264c0c6f5894 to 9694974b6d41 (1 revision) (flutter/engine#57066) 
https://dart.googlesource.com/sdk.git/+log/264c0c6f5894..9694974b6d41

2024-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-226.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-09 18:21:06 +00:00
skia-flutter-autoroll
4037bf256a Roll Skia from afa77852dcde to e78dd0265002 (1 revision) (flutter/engine#57063) 
https://skia.googlesource.com/skia.git/+log/afa77852dcde..e78dd0265002

2024-12-09 kjlubick@google.com Reland "Remove JSON output from public API of SkSLDebugTrace"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-09 16:50:27 +00:00
skia-flutter-autoroll
ffc8dad48b Roll Dart SDK from c7e47c6c5df6 to 264c0c6f5894 (1 revision) (flutter/engine#57060) 
https://dart.googlesource.com/sdk.git/+log/c7e47c6c5df6..264c0c6f5894

2024-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-225.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-09 14:02:38 +00:00
skia-flutter-autoroll
9ff9419e6d Roll Fuchsia Linux SDK from BFJjwUVtBDA2mqqpH... to tVShMDVFeKJFcDFHJ... (flutter/engine#57058) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-09 11:47:23 +00:00
skia-flutter-autoroll
01c681d9b1 Roll Skia from c80d6609b95b to ac432c094232 (1 revision) (flutter/engine#57056) 
https://skia.googlesource.com/skia.git/+log/c80d6609b95b..ac432c094232

2024-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 48b61740d60f to ca6066d7097c (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-09 07:33:32 +00:00
Robert Ancell
8cc75a926e Cleanup refactoring in FlKeyboardManager (flutter/engine#56956) 
Remove pending keyboard event ID and use the object directly.

Use references to make sure FlKeyboardManagerData is freed.

Refactor marking events as handled
 2024-12-09 09:53:58 +13:00
skia-flutter-autoroll
a9c77c889f Roll Fuchsia Linux SDK from __h1RRphItwU5H0tL... to BFJjwUVtBDA2mqqpH... (flutter/engine#57050) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-08 10:39:11 +00:00
skia-flutter-autoroll
fd266b33d7 Roll Skia from b37f1430f87a to d1e261ca7f6f (1 revision) (flutter/engine#57039) 
https://skia.googlesource.com/skia.git/+log/b37f1430f87a..d1e261ca7f6f

2024-12-07 jie.a.chen@intel.com [Graphite]: Use DawnTexelCopyBufferRowAlignment

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jvanverth@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-07 10:26:23 +00:00
skia-flutter-autoroll
d32d2ec609 Roll Dart SDK from 838ed940b056 to c7e47c6c5df6 (1 revision) (flutter/engine#57038) 
https://dart.googlesource.com/sdk.git/+log/838ed940b056..c7e47c6c5df6

2024-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-224.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-07 06:19:28 +00:00
skia-flutter-autoroll
99c5f6e7f2 Roll Dart SDK from 67ce49b905f7 to 838ed940b056 (2 revisions) (flutter/engine#57037) 
https://dart.googlesource.com/sdk.git/+log/67ce49b905f7..838ed940b056

2024-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-223.0.dev
2024-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-222.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-07 02:05:05 +00:00