Christopher Fujino
eb66d03350
Update conductor to write engine.version file ( #163350 )
...
This adds a new phase to the conductor after applying cherrypicks, to
update the engine.version file with the revision from the previous
commit. Note, this will produce a different PR, because it has to be in
a different commit after squash & merge.
Automates https://github.com/flutter/flutter/issues/162265
2025-02-27 22:24:40 +00:00
Reid Baker
89f1eba3c8
remove last usages of min/compile/target SdkVersion, align sourceCompatibility across repo and update android version documentation ( #164198 )
...
Related to #149836
- Remove last usages of minSdkVersion/compileSdkVersion/targetSdkVersion
in favor of minSdk/compileSdk/targetSdk. That do not also use
`flutter.minSdkVersion` etc. (that will happen in another pass)
- Update the files that used "SdkVersion" to use equals for setting new
values. [Not yet landed documentation
change](https://github.com/flutter/flutter/pull/164195/files#diff-ee6ec18be8d752e2696c8ccc8bec2f202dfc29a43b3b4f9d8041aa6bc3e852a1 )
- align sourceCompatibility and targetCompatibility across repo to use
JavaVersion.* and update android version documentation.
This pr updates `kotlinOptions jvmTarget` documentation but does not fix
all existing usages.
This pr is expected to cause no behavioral changes.
This pr makes logical sense after
https://github.com/flutter/flutter/pull/164195 but can be landed in any
order.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-27 22:00:49 +00:00
Matan Lurey
fe6c05b778
Update links to the flutter/engine repository for the monorepo. ( #164328 )
...
Just general cleanup while working on other things.
2025-02-27 21:57:59 +00:00
Gray Mackall
c9c3e74747
Add empty io.flutter.app.FlutterApplication to give deprecation notice, and un-break projects that have not migrated ( #164233 )
...
The removal of the v1 embedding missed that this class was not marked as
deprecated, and did not provide a notice in the breaking changes
section. V1 apps that needed the functionality of the old
`FlutterApplication` were all broken in the previous release, but some
V2 apps have been referencing the v1 `FlutterApplication`.
For these apps, this is the same as extending the base
`android.app.Application`. So we can provide an "empty extension" of
that base class, to provide these v2 apps a deprecation notice, and
avoid breaking them without warning (in 3.29.1).
Arbitrarily chose the `spell_checker` integration test to reference this
empty application, let me know if you think I should bring up an
entirely new devicelab test instead.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-02-27 21:47:12 +00:00
Alexander Aprelev
6ec7ae3a1c
Revert dart sdks that were causing dartaotruntime issues in g3 ( #164307 )
...
Revert four collateral rolls, one with offending change
https://dart-review.googlesource.com/c/sdk/+/410921
Revert "Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions)
(#164168 )"
Revert "Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions)
(#164226 )"
Revert "Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions)
(#164260 )"
Revert "Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision)
(#164276 )"
Revert "Roll Dart SDK from fcda71ce147b to d70b123c77d4 (1 revision)
(#164295 )"
2025-02-27 21:06:23 +00:00
Reid Baker
72c2447307
android_host_app_v2_embedding update dependencies and documentation ( #164195 )
...
Related to #149836
Last of the non api 35 references in flutter/flutter for targetSdk and
compileSdk.
`find . -type f -name "build.gradle" | xargs grep -e "targetSdk" | tr -d
'=' | tr -s ' ' | grep -v flutter\.targetSdkVersion | grep -v
engine/src/flutter/third_party/ | grep -v "targetSdk 35"`
`find . -type f -name "build.gradle" | xargs grep -e "compileSdk" | tr
-d '=' | tr -s ' ' | grep -v flutter\.compileSdkVersion | grep -v
engine/src/flutter/third_party/ | grep -v "compileSdk 35"`
rewrite of https://github.com/flutter/flutter/pull/163622 after this
test was updated to run against a newer version of gradle and agp in
https://github.com/flutter/flutter/pull/163849/files#diff-83b6ad7c016bffbb682664eb65c576a7ebf9c312fc60727c0e0e20f5641cbc2aR462
Android-API-And-Related-Versions.md was updated to reflect that after
further investigation that android is using "=" in their documentation
and that the space syntax is discouraged. Equals is setting a property
and space is the equivalent to a function call like `compileSdk(35)` and
assignment is prefered.
The use of equals for proprty assignment also aligns with
https://docs.gradle.org/current/userguide/migrating_from_groovy_to_kotlin_dsl.html#prepare_your_groovy_scripts
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-27 20:31:08 +00:00
flutter-pub-roller-bot
6a073ce605
Roll pub packages ( #164316 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2025-02-27 19:38:00 +00:00
Jay
25f2df623d
Fix korean cupertino datepicker datetime order ( #163850 )
...
Currently, in the Korean locale (`ko`), the `CupertinoDatePicker`
displays the time in the order of `hour : minute : AM/PM`.
However, the correct format for Korean conventions is `AM/PM : hour :
minute`.
This PR modifies the `CupertinoDatePicker` to display the time in the
correct order when the Korean locale is used.
## Changes
- Updated the time display order for the Korean (`ko`) locale in
`CupertinoDatePicker`.
- Previous format: `hour : minute : AM/PM`
- Updated format: `AM/PM : hour : minute`
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-27 19:36:21 +00:00
Kevin Moore
2bc40b39dc
[web_ui] dependency cleanup ( #164256 )
...
Update dependencies across 3 web engine packages
Remove unneeded dependencies
One set of associated code fixes
2025-02-27 19:21:18 +00:00
engine-flutter-autoroll
0c200c7a09
Roll Skia from e5a33102401c to c16b145749d4 (1 revision) ( #164314 )
...
https://skia.googlesource.com/skia.git/+log/e5a33102401c..c16b145749d4
2025-02-27 jamesgk@google.com Reland "[graphite] Require colorspaces for
precomp color xform objects"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-27 19:16:48 +00:00
Kevin Moore
671bcbe6d6
[web_ui] move several uses of (deprecated) pkg:js to js_interop_unsafe ( #164264 )
2025-02-27 18:46:01 +00:00
dependabot[bot]
1ecd9fcea1
Bump codecov/codecov-action from 5.3.1 to 5.4.0 in the all-github-actions group ( #164306 )
...
Bumps the all-github-actions group with 1 update:
[codecov/codecov-action](https://github.com/codecov/codecov-action ).
Updates `codecov/codecov-action` from 5.3.1 to 5.4.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's
releases</a>.</em></p>
<blockquote>
<h2>v5.4.0</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps): bump github/codeql-action from 3.28.1 to 3.28.5 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1753 ">codecov/codecov-action#1753</a></li>
<li>build(deps): bump github/codeql-action from 3.28.5 to 3.28.8 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1757 ">codecov/codecov-action#1757</a></li>
<li>Fix a typo in the example by <a
href="https://github.com/miranska "><code>@miranska</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1758 ">codecov/codecov-action#1758</a></li>
<li>build(deps): bump github/codeql-action from 3.28.8 to 3.28.9 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1765 ">codecov/codecov-action#1765</a></li>
<li>Fix description for report_type input by <a
href="https://github.com/craigscott-crascit "><code>@craigscott-crascit</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1770 ">codecov/codecov-action#1770</a></li>
<li>Fix use of safe.directory inside containers by <a
href="https://github.com/Flamefire "><code>@Flamefire</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1768 ">codecov/codecov-action#1768</a></li>
<li>Clarify in README that <code>use_pypi</code> bypasses integrity
checks too by <a
href="https://github.com/webknjaz "><code>@webknjaz</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1773 ">codecov/codecov-action#1773</a></li>
<li>build(deps): bump github/codeql-action from 3.28.9 to 3.28.10 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1777 ">codecov/codecov-action#1777</a></li>
<li>build(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1776 ">codecov/codecov-action#1776</a></li>
<li>build(deps): bump actions/upload-artifact from 4.6.0 to 4.6.1 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1775 ">codecov/codecov-action#1775</a></li>
<li>update wrapper submodule to 0.2.0, add recurse_submodules arg by <a
href="https://github.com/matt-codecov "><code>@matt-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1780 ">codecov/codecov-action#1780</a></li>
<li>chore(release): 5.4.0 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1781 ">codecov/codecov-action#1781</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/miranska "><code>@miranska</code></a>
made their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1758 ">codecov/codecov-action#1758</a></li>
<li><a
href="https://github.com/craigscott-crascit "><code>@craigscott-crascit</code></a>
made their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1770 ">codecov/codecov-action#1770</a></li>
<li><a href="https://github.com/Flamefire "><code>@Flamefire</code></a>
made their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1768 ">codecov/codecov-action#1768</a></li>
<li><a
href="https://github.com/matt-codecov "><code>@matt-codecov</code></a>
made their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1780 ">codecov/codecov-action#1780</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.3.1...v5.4.0 ">https://github.com/codecov/codecov-action/compare/v5.3.1...v5.4.0 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md ">codecov/codecov-action's
changelog</a>.</em></p>
<blockquote>
<h2>v5.4.0</h2>
<h3>What's Changed</h3>
<ul>
<li>update wrapper submodule to 0.2.0, add recurse_submodules arg by <a
href="https://github.com/matt-codecov "><code>@matt-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1780 ">codecov/codecov-action#1780</a></li>
<li>build(deps): bump actions/upload-artifact from 4.6.0 to 4.6.1 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1775 ">codecov/codecov-action#1775</a></li>
<li>build(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1776 ">codecov/codecov-action#1776</a></li>
<li>build(deps): bump github/codeql-action from 3.28.9 to 3.28.10 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1777 ">codecov/codecov-action#1777</a></li>
<li>Clarify in README that <code>use_pypi</code> bypasses integrity
checks too by <a
href="https://github.com/webknjaz "><code>@webknjaz</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1773 ">codecov/codecov-action#1773</a></li>
<li>Fix use of safe.directory inside containers by <a
href="https://github.com/Flamefire "><code>@Flamefire</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1768 ">codecov/codecov-action#1768</a></li>
<li>Fix description for report_type input by <a
href="https://github.com/craigscott-crascit "><code>@craigscott-crascit</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1770 ">codecov/codecov-action#1770</a></li>
<li>build(deps): bump github/codeql-action from 3.28.8 to 3.28.9 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1765 ">codecov/codecov-action#1765</a></li>
<li>Fix a typo in the example by <a
href="https://github.com/miranska "><code>@miranska</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1758 ">codecov/codecov-action#1758</a></li>
<li>build(deps): bump github/codeql-action from 3.28.5 to 3.28.8 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1757 ">codecov/codecov-action#1757</a></li>
<li>build(deps): bump github/codeql-action from 3.28.1 to 3.28.5 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1753 ">codecov/codecov-action#1753</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.3.1..v5.4.0 ">https://github.com/codecov/codecov-action/compare/v5.3.1..v5.4.0 </a></p>
<h2>v5.3.1</h2>
<h3>What's Changed</h3>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.3.0..v5.3.1 ">https://github.com/codecov/codecov-action/compare/v5.3.0..v5.3.1 </a></p>
<h2>v5.3.0</h2>
<h3>What's Changed</h3>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.2.0..v5.3.0 ">https://github.com/codecov/codecov-action/compare/v5.2.0..v5.3.0 </a></p>
<h2>v5.2.0</h2>
<h3>What's Changed</h3>
<ul>
<li>Fix typo in README by <a
href="https://github.com/tserg "><code>@tserg</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1747 ">codecov/codecov-action#1747</a></li>
<li>Th/add commands by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1745 ">codecov/codecov-action#1745</a></li>
<li>use correct audience when requesting oidc token by <a
href="https://github.com/juho9000 "><code>@juho9000</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1744 ">codecov/codecov-action#1744</a></li>
<li>build(deps): bump github/codeql-action from 3.27.9 to 3.28.1 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1742 ">codecov/codecov-action#1742</a></li>
<li>build(deps): bump actions/upload-artifact from 4.4.3 to 4.6.0 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1743 ">codecov/codecov-action#1743</a></li>
<li>chore(deps): bump wrapper to 0.0.32 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1740 ">codecov/codecov-action#1740</a></li>
<li>feat: add disable-telem feature by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1739 ">codecov/codecov-action#1739</a></li>
<li>fix: remove erroneous linebreak in readme by <a
href="https://github.com/Vampire "><code>@Vampire</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1734 ">codecov/codecov-action#1734</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.1.2..v5.2.0 ">https://github.com/codecov/codecov-action/compare/v5.1.2..v5.2.0 </a></p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="0565863a31https://redirect.github.com/codecov/codecov-action/issues/1781 ">#1781</a>)</li>
<li><a
href="c545d7bd45https://redirect.github.com/codecov/codecov-action/issues/1780 ">#1780</a>)</li>
<li><a
href="2488e996fahttps://redirect.github.com/codecov/codecov-action/issues/1775 ">#1775</a>)</li>
<li><a
href="a46c158416https://redirect.github.com/codecov/codecov-action/issues/1776 ">#1776</a>)</li>
<li><a
href="062ee7e02ehttps://redirect.github.com/codecov/codecov-action/issues/1777 ">#1777</a>)</li>
<li><a
href="1fecca8ce3https://redirect.github.com/codecov/codecov-action/issues/1773 ">#1773</a>)</li>
<li><a
href="2e6e9c5a74https://redirect.github.com/codecov/codecov-action/issues/1768 ">#1768</a>)</li>
<li><a
href="a5dc5a573ehttps://redirect.github.com/codecov/codecov-action/issues/1770 ">#1770</a>)</li>
<li><a
href="4898080f15https://redirect.github.com/codecov/codecov-action/issues/1765 ">#1765</a>)</li>
<li><a
href="5efa07bc17https://redirect.github.com/codecov/codecov-action/issues/1758 ">#1758</a>)</li>
<li>Additional commits viewable in <a
href="13ce06bfc6...0565863a31https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=5.3.1&new-version=5.4.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-27 18:42:10 +00:00
flutter-pub-roller-bot
0e9190505a
Roll pub packages ( #163567 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
---------
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2025-02-27 17:02:18 +00:00
Sam Rawlins
a321b25e6d
Remove as-clause in doc-import; they don't work yet ( #164234 )
...
I'll be adding a warning against using `@docImport as`, as it doesn't
yet work.
2025-02-27 16:54:10 +00:00
Matan Lurey
2f43dc3ead
Do not update patch versions for dependabot/github-actions. ( #164055 )
...
Towards https://github.com/flutter/flutter/issues/158350 .
2025-02-27 16:35:47 +00:00
Matan Lurey
d8856b9e50
Remove the last vestiges of null-unsafety in flutter_tools. ( #164026 )
...
The internal code using this was deleted in `cl/730558889`.
2025-02-27 16:31:22 +00:00
engine-flutter-autoroll
8c7e18612f
Roll Packages from c44c2282aad1 to 01d3d5c1dca3 (14 revisions) ( #164301 )
...
c44c2282aa...01d3d5c1dcengine-flutter-autoroll@skia.org Manual roll Flutter from
043b71954ce7 to 16592066d70b (19 revisions) (flutter/packages#8728 )
2025-02-27 stuartmorgan@google.com Manual roll Flutter from 911aa7547ed7
to 043b71954ce7 (flutter/packages#8693 )
2025-02-26 magder@google.com Dependabot to update major and minor
versions of test dependencies, ignore patch (flutter/packages#8712 )
2025-02-26 reidbaker@google.com [local_auth] Update to use
flutter.targetSdkVersion (flutter/packages#8695 )
2025-02-26 57854043+CaoGiaHieu-dev@users.noreply.github.com
[go_router_builder]: Handle invaild params (flutter/packages#8405 )
2025-02-26 stuartmorgan@google.com [pigeon] Timestamp test steps in CI
(flutter/packages#8716 )
2025-02-26 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Fix 90°-off preview rotation
(flutter/packages#8629 )
2025-02-26 108667553+aprzedecki@users.noreply.github.com [go_router]
Secured empty matches in canPop (flutter/packages#8557 )
2025-02-26 reidbaker@google.com [tool] Update targetsdk version to 35
from 32 (flutter/packages#8694 )
2025-02-26 stuartmorgan@google.com [various] Bump androidx.test:core to
1.4.0 (flutter/packages#8710 )
2025-02-26 stuartmorgan@google.com [camera] Disable flaky tests
(flutter/packages#8708 )
2025-02-26 mdebbar@google.com [url_launcher][web] Prevent browser from
navigating when followLink isn't called (flutter/packages#8675 )
2025-02-26 stuartmorgan@google.com [various] Remove plugin-level
`integration_test` dependencies (flutter/packages#8711 )
2025-02-26 stuartmorgan@google.com [ci] Lengthen custom tests timeout
(flutter/packages#8715 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-27 15:53:35 +00:00
engine-flutter-autoroll
7c0c98eb7b
Roll Dart SDK from fcda71ce147b to d70b123c77d4 (1 revision) ( #164295 )
...
https://dart.googlesource.com/sdk.git/+log/fcda71ce147b..d70b123c77d4
2025-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-149.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-27 15:22:06 +00:00
engine-flutter-autoroll
2e570ca393
Roll Skia from ac08df9c8d82 to e5a33102401c (1 revision) ( #164288 )
...
https://skia.googlesource.com/skia.git/+log/ac08df9c8d82..e5a33102401c
2025-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 8ed929b84efc to c1c31f4d17a9 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-27 12:46:29 +00:00
engine-flutter-autoroll
c07f4c3a3e
Roll Skia from 6018dff0233a to ac08df9c8d82 (1 revision) ( #164275 )
...
https://skia.googlesource.com/skia.git/+log/6018dff0233a..ac08df9c8d82
2025-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 8dbd2fe62ac3 to 96a1bda4c1b6 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-27 10:17:11 +00:00
engine-flutter-autoroll
458a1f2e00
Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision) ( #164276 )
...
https://dart.googlesource.com/sdk.git/+log/4a218fbffc80..fcda71ce147b
2025-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-148.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-27 10:11:34 +00:00
engine-flutter-autoroll
f1f463c767
Roll Skia from 0f2e106c9abc to 6018dff0233a (1 revision) ( #164266 )
...
https://skia.googlesource.com/skia.git/+log/0f2e106c9abc..6018dff0233a
2025-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 63deebde9085 to 2f85feff104d (19 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-27 06:56:39 +00:00
Robert Ancell
d8a57c61dd
Add windowing channel support to Linux embedder ( #163180 )
...
Implement flutter/windowing for the Linux embedder.
2025-02-27 04:14:20 +00:00
engine-flutter-autoroll
11d33f203e
Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions) ( #164260 )
...
https://dart.googlesource.com/sdk.git/+log/7fa5901bd8a3..4a218fbffc80
2025-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-147.0.dev
2025-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-146.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-27 03:58:33 +00:00
engine-flutter-autoroll
e6f4fa4204
Roll Skia from fdd97386193e to 0f2e106c9abc (4 revisions) ( #164259 )
...
https://skia.googlesource.com/skia.git/+log/fdd97386193e..0f2e106c9abc
2025-02-26 jamesgk@google.com [graphite] Remove guards for
RenderPassProperties field
2025-02-26 egdaniel@google.com Fix equality check in VulkanBuffer for
host access.
2025-02-26 robertphillips@google.com [graphite] Reduce
SkRuntimeEffect::Options overhead for KnownRuntimeEffects
2025-02-26 jvanverth@google.com [graphite] Remove most validation from
ClipAtlas.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-27 03:36:31 +00:00
John McDole
4b65ead926
Run more builds faster ( #164125 )
...
The following builds all download drone assets and run generators, and
thus could benefit from the flags.
- Linux linux_android_aot_engine
- Linux linux_android_debug_engine
- Linux linux_fuchsia
- Linux linux_host_engine
See #164069 for other builds
2025-02-27 03:10:42 +00:00
Loïc Sharma
796400744f
Increase customer test timeout to 60 minutes ( #164239 )
...
Customer test timeouts are a frequent source of tree closures.
This change should be reverted once
https://github.com/flutter/flutter/issues/164140 is completed.
2025-02-27 01:09:22 +00:00
Jason Simmons
1d25f6953d
Reland "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools" ( #164240 )
...
Relands https://github.com/flutter/flutter/pull/163890 and updates the
Ninja path used by the engine tool
2025-02-27 00:13:58 +00:00
Liam Appelbe
0f3b092a10
Use the Dart isolate ownership API on the root isolate ( #163703 )
...
The isolate ownership API was [introduced
recently](https://dart-review.googlesource.com/c/sdk/+/407700 ) to solve
[some deadlock bugs](https://github.com/dart-lang/native/issues/1908 ) in
native callbacks.
A native callback is a call from native code into a Dart function.
Currently all such callbacks must run that Dart function in the isolate
that created the callback (called the target isolate). The only native
callback primitives at the moment are `NativeCallable.isolateLocal`
(blocking, but must be invoked from the same thread as the target
isolate, and the target isolate must be currently entered on that
thread) and `NativeCallable.listener` (non-blocking, can be invoked from
any thread).
To build blocking callbacks that can be called from any thread, we can
use a `NativeCallable.listener`, and use a synchronization object like a
mutex or a condition variable to block until the callback is complete.
However, if we try to do this on the thread that is currently entered in
the target isolate, we will deadlock: we invoke the listener, a message
is sent to the target isolate, and we block waiting for the message to
be handled, so we never pass control flow back to the isolate to handle
the message, and never stop waiting.
To fix this deadlock, Ffigen and Jnigen both have a mechanism that
checks if we're on the target isolate's thread first:
- If the native caller is already on the same thread as the target
isolate, and the target isolate is entered:
- Call the Dart function directly using `NativeCallable.isolateLocal` or
similar
- Otherwise, if the native caller is coming from a different thread:
- Call the Dart function asynchronously using `NativeCallable.listener`
or similar
- Block until the callback finishes
However, this neglects the case where we're on the target isolate's
thread, but not entered into the isolate. This case happens in Flutter
when the callback is invoked from the UI thread (or the platform thread
when thread merging is enabled), and the target isolate is the root
isolate. When the native callback is invoked, the root isolate is not
entered, so we hit the second case: we send a message to the root
isolate, and block to wait for a response. Since the root isolate is
exclusively run on the UI thread, and we're blocking the UI thread, the
message will never be handled, and we deadlock.
The isolate ownership API fixes this by allowing the embedder to inform
the VM that it will run a particular isolate exclusively on a particular
thread, using `Dart_SetCurrentThreadOwnsIsolate`. Other native code can
then query that ownership using `Dart_GetCurrentThreadOwnsIsolate`. This
lets us add a third case to our conditional:
- If the native caller is on the thread that is currently entered in the
target isolate:
- Call the Dart function directly using `NativeCallable.isolateLocal` or
similar
- Otherwise, if the native caller is on the thread that owns the target
isolate
- Enter the target isolate
- Call the Dart function directly using `NativeCallable.isolateLocal `or
similar
- Exit the target isolate
- Otherwise, the native caller is coming from an unrelated thread:
- Call the Dart function asynchronously using `NativeCallable.listener`
or similar
- Block until the callback finishes
**Note:** We don't need to set the ownership of VM managed threads,
because they run in a thread pool exclusively used by the VM, so there's
no way for native code to be executed on the thread (except by FFI, in
which case we're entered into the isolate anyway). We only need this for
Flutter's root isolate because work can be sent to the UI
thread/platform thread using OS specific APIs like Android's
`Looper.getMainLooper()`.
2025-02-27 00:05:53 +00:00
engine-flutter-autoroll
59b3923a03
Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... ( #164243 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC matanl@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-26 23:40:08 +00:00
Robert Ancell
d64b8e29c3
Show Linux driver information in flutter doctor ( #163980 )
...
I have attempted to cherry pick some useful information from eglinfo
which is often requested when resolving issues with rendering.
This information is not required to compile an Flutter application, so
it is a little different to the other displayed information.
2025-02-26 23:40:07 +00:00
Gray Mackall
b287365b21
Implement opacity FlutterMutator for hcpp ( #164147 )
...
This is essentially a reland of
https://github.com/flutter/engine/pull/30264/ , except that it only
applies the opacity if the new alpha (alpha = 255*opacity, where
opacity∈[0,1]) is different from the current alpha.
Also adds a new opacity screenshot test. Need to figure out how to bring
up a new screenshot test... does the screenshot get uploaded
automatically? Do I need to manually upload somewhere?
Fixes https://github.com/flutter/flutter/issues/164212
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-02-26 23:12:19 +00:00
engine-flutter-autoroll
f0b08055e6
Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... ( #164232 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC matanl@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Co-authored-by: zijiehe@ <68449066+zijiehe-google-com@users.noreply.github.com>
2025-02-26 23:02:48 +00:00
engine-flutter-autoroll
f6e66cb27f
Roll Skia from 47b84f354604 to fdd97386193e (8 revisions) ( #164221 )
...
https://skia.googlesource.com/skia.git/+log/47b84f354604..fdd97386193e
2025-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 28db7e56a2ed to 8ed929b84efc (3 revisions)
2025-02-26 robertphillips@google.com [graphite] Minor cleanups
2025-02-26 robertphillips@google.com [graphite] Cleanup TestPrecompile
jobs
2025-02-26 michaelludwig@google.com Reland "Reland "[graphite] Remove
TextureInfoData and TextureSpec in TextureInfo""
2025-02-26 robertphillips@google.com [graphite] Add getPipelineLabel API
for serialized Pipeline keys
2025-02-26 aswolfers@google.com Add BGRA format support
2025-02-26 jamesgk@google.com [graphite] Add dst color space field to
RenderPassProperties
2025-02-26 jamesgk@google.com Attempt specialized blurred rrect draw for
arcs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-26 20:55:18 +00:00
Jonah Williams
04cc4b1f11
[Impeller] Reland: move AHB check into Flutter main, don't disable ImageReader on 29. ( #164201 )
...
Rather than conditionally disabling AHBs, just disable Vulkan on devices
where AHB imports don't work. FIx from last time is in the last commit,
I reversed the string check accidentally and disabled vulkan everywhere
🥺
https://github.com/flutter/flutter/issues/163473
https://github.com/flutter/flutter/issues/160854
2025-02-26 20:53:57 +00:00
engine-flutter-autoroll
05eb42f32d
Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions) ( #164226 )
...
https://dart.googlesource.com/sdk.git/+log/80865748abe0..7fa5901bd8a3
2025-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-145.0.dev
2025-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-144.0.dev
2025-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-143.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-26 20:53:56 +00:00
zijiehe@
eb3f171e13
Update fuchsia_test_scripts_version to the latest version ( #164123 )
...
The original roll failed for unrelated reason, and it's old, I cannot
restore it anymore.
https://github.com/flutter/flutter/pull/162766
The roll will unblock fuchsia-sdk roll as well which includes an
incompatible change.
b/399136476
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-26 20:05:27 +00:00
Navaron Bracke
d8100ac5ed
Guard against zero item extent for carousel ( #163310 )
...
This PR fixes a bug where the `CarouselView` would throw an error if the
itemExtent is zero.
Part of https://github.com/flutter/flutter/issues/160679
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-26 18:39:26 +00:00
Jonah Williams
0b96fa88fd
[Impeller] work around for crashy Nexus 5 Driver. ( #164040 )
...
Rewrites exp to work around crashes on Nexus 5.
2025-02-26 17:54:53 +00:00
auto-submit[bot]
52876a0b25
Reverts "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools ( #163890 )" ( #164209 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#163890
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jason-simmons
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: et and related packages in
https://github.com/flutter/flutter/tree/master/engine/src/flutter/tools
need to be updated for the new Ninja path
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jason-simmons
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {matanlurey, jtmcdole}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
The depot_tools Ninja wrapper looks for Ninja at specific paths within
the tree. The use of "name": "." in the engine's .gclient file is not
expected by the depot_tools logic for locating the engine's source
directory.
This PR creates an alternative layout that is supported by depot_tools.
If the project root directory contains a "buildtools" subdirectory, then
depot_tools will look for Ninja at "third_party/ninja" within the root.
Fixes https://github.com/flutter/flutter/issues/163487
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-02-26 17:53:36 +00:00
Mykhailo B
af15a1eb76
Add localization for Back and Cancel buttons in CupertinoNavigationBar ( #162581 )
...
### Description
This PR adds localization support for the **"Back"** and **"Cancel"**
buttons used in `CupertinoNavigationBar`.
#### Changes:
- Introduced `cancelButtonLabel` and `backButtonLabel` in
`CupertinoLocalizations`.
- ~Updated all ARB files with appropriate translations.~
- Modified `_NavigationBarStaticComponents` and `_BackLabel` to use
these labels.
- Ensured all localization tests pass.
- Fixed the test `Auto back/close button` in the
`packages/flutter/test/cupertino/localizations_test.dart`.
### Why is this needed?
Currently, the **"Back"** and **"Cancel"** (prev. **"Close"**) buttons
in `CupertinoNavigationBar` are hardcoded in English. This update
ensures they are properly localized across supported languages.
### Tests
One test failed (even before my changes): `Saturation is applied before
blur`
#### Manual Testing with the `modal_bottom_sheet` Package
I tested the change using [my custom mini
app](https://gist.github.com/Michae1Weiss/9afee8c425d03e3d41e331fdbf21344f )
and the `modal_bottom_sheet` package. I verified that the button is
correctly translated into German localization.
##### Before
##### After
### Button Name Change: From "Close" to "Cancel"
I have renamed the button from **"Close"** to **"Cancel"** to align with
the iOS native naming convention for buttons in modal dialogs.
#### Example:
### Related Issues
[CupertinoNavigationBar's "Close", "Back", and "Cancel" buttons are not
localized. **#48616** ](https://github.com/flutter/flutter/issues/48616 )
[CupertinoNavigationBar's "Back" button is not localized **#120722**
](https://github.com/flutter/flutter/issues/120722 )
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
2025-02-26 17:46:00 +00:00
gaaclarke
8b3f5f4a2f
Added compilation failure if a max ubo size is exceeded ( #164038 )
...
issue: https://github.com/flutter/flutter/issues/163580
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-26 17:36:00 +00:00
engine-flutter-autoroll
e039a911c5
Roll Skia from 5336e20498d9 to 47b84f354604 (2 revisions) ( #164188 )
...
https://skia.googlesource.com/skia.git/+log/5336e20498d9..47b84f354604
2025-02-26 robertphillips@google.com [graphite] Disable
UserDefinedStableKeyTest on Android Protected jobs
2025-02-26 robertphillips@google.com [graphite] Shorten shader names w/o
relying on auto-trimming
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-26 16:07:50 +00:00
Jason Simmons
3d018b5924
Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools ( #163890 )
...
The depot_tools Ninja wrapper looks for Ninja at specific paths within
the tree. The use of "name": "." in the engine's .gclient file is not
expected by the depot_tools logic for locating the engine's source
directory.
This PR creates an alternative layout that is supported by depot_tools.
If the project root directory contains a "buildtools" subdirectory, then
depot_tools will look for Ninja at "third_party/ninja" within the root.
Fixes https://github.com/flutter/flutter/issues/163487
2025-02-26 15:11:31 +00:00
engine-flutter-autoroll
80233283c3
Roll Skia from 3ce6f25dc13e to 5336e20498d9 (9 revisions) ( #164174 )
...
https://skia.googlesource.com/skia.git/+log/3ce6f25dc13e..5336e20498d9
2025-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 25a22decd766 to 8dbd2fe62ac3 (11 revisions)
2025-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from ce93f1f3a1f4 to 63deebde9085 (26 revisions)
2025-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7ee45b04303c to 28db7e56a2ed (13 revisions)
2025-02-25 kjlubick@google.com Minor cleanups in blitters
2025-02-25 jvanverth@google.com [graphite] Potential fix for clip atlas
crash
2025-02-25 robertphillips@google.com [graphite] Add unit tests for
user-defined known runtime effects
2025-02-25 ccameron@chromium.org SkJpegGainmapEncoder::MakeMPF: Move MP
parameters before StartOfScan
2025-02-25 jmbetancourt@google.com [MSKP] fix image serialization for
MSKPs using derived generators
2025-02-25 michaelludwig@google.com Revert "Reland "[graphite] Remove
TextureInfoData and TextureSpec in TextureInfo""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-26 10:03:03 +00:00
engine-flutter-autoroll
d4bdeb7c46
Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions) ( #164168 )
...
https://dart.googlesource.com/sdk.git/+log/b8292dfeaa67..80865748abe0
2025-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-142.0.dev
2025-02-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-141.0.dev
2025-02-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-140.0.dev
2025-02-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-139.0.dev
2025-02-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-138.0.dev
2025-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-137.0.dev
2025-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-136.0.dev
2025-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-135.0.dev
2025-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-134.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-26 10:01:10 +00:00
Tong Mu
a3e9df35aa
[Engine] Remove dead code for RoundedSuperellipse ( #164163 )
...
Remove dead code that occurred during development and I forgot to
remove.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-26 09:59:05 +00:00
Jonah Williams
ac9f68b12d
[Impeller] detect mediatek soc and fall back to GLES. ( #164126 )
...
If the device is _probably_ mediatek, then use OpenGL. We may relax this
check if the future if we find a mediatek soc that works well w/ Vulkan.
2025-02-26 05:07:59 +00:00
Jonah Williams
8bb34f2c20
[Impeller] make DLOG into LOG for startup errors. ( #164110 )
...
Make logs visible to help debug
https://github.com/flutter/flutter/issues/163532 . Right now we can't
see why context creation is failing.
It may be an EGL config issue.
2025-02-26 05:07:59 +00:00
Victoria Ashworth
aa113bd69c
Intercept error when iOS 18.4 crashes with JIT mode and give guided error ( #164072 )
...
Adds listener to device logs during launch (before Dart VM is found) and
check if iOS 18.4+ JIT crash log and give guided error message:
```
════════════════════════════════════════════════════════════════════════════════
A change to iOS has caused a temporary break in Flutter's debug mode on
physical devices.
See https://github.com/flutter/flutter/issues/163984 for details.
In the meantime, we recommend these temporary workarounds:
* When developing with a physical device, use one running iOS 18.3 or lower.
* Use a simulator for development rather than a physical device.
* If you must use a device updated to iOS 18.4+, use Flutter's release or
profile mode via --release or --profile flags.
════════════════════════════════════════════════════════════════════════════════
```
Fixes https://github.com/flutter/flutter/issues/164011 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-26 05:07:58 +00:00
