gmackall
eba2a520b4
Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected ( #124085 )
...
This PR adds an android project migrator that checks the version of android studio and the version of gradle for conflicts, and upgrades to 7.4 if a conflict is detected. For more detail about the particular conflict, see https://github.com/flutter/flutter/issues/122376 .
The PR also upgrades older gradle versions being used in integration testing to 7.4.
Fixes/related to: https://github.com/flutter/flutter/issues/122376 and https://github.com/flutter/flutter/issues/123636
2023-04-27 23:07:50 +00:00
Janice Collins
fb36bba366
Update dartdoc to v6.2.2. ( #125650 )
...
This PR updates the dartdoc version to v6.2.2.
Release notes: https://github.com/dart-lang/dartdoc/releases/tag/v6.2.2
The main impact for Flutter is to update dartdoc to add chips to class and/or mixin pages for class modifiers. See dart-lang/dartdoc#3391 , dart-lang/dartdoc#3402 . This will also be a cherry-pick candidate for 3.1 if it can land in time.
- [ test-exempt ] I added new tests to check the change I am making, or this PR is [test-exempt].
2023-04-27 22:30:06 +00:00
Taha Tesser
746cacc501
Add slider_perf_android task to ci.yaml ( #125540 )
...
This adds `devicelab` task `slider_perf_android` to `.ci.yaml`, which was added in https://github.com/flutter/flutter/pull/125296
2023-04-27 21:32:39 +00:00
engine-flutter-autoroll
215fa3557b
Roll Flutter Engine from 883bb7d5cb28 to 3d61e293cb96 (1 revision) ( #125645 )
...
883bb7d5cb...3d61e293cbskia-flutter-autoroll@skia.org Roll Skia from 8441d7a93942 to f7c8a58c2127 (10 revisions) (flutter/engine#41556 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-27 19:28:10 +00:00
Christopher Fujino
4ff505c861
[flutter_tools] more debugging for timeouts in break_on_framework_exceptions test ( #125584 )
...
Better debugging to investigate: https://github.com/flutter/flutter/issues/125241
When the `test/integration.shard/break_on_framework_exceptions_test.dart` test times out, log out verbose logging to give clues as to why it did not complete.
From one local run it looks like the test runner is failing to load a test file (when I checked the path locally, the file was there, and re-running the `flutter test ...` invocation succeeded--in that the app threw an exception):
```
14:12 +26 -1: breaks when StatefulWidget.build throws [E]
Timed out launching `flutter test`
package:matcher fail
test/integration.shard/break_on_framework_exceptions_test.dart 623:11 _timeoutAfter.<fn>
250s Spawning flutter [test, --disable-service-auth-codes, --machine, --start-paused, test/test.dart] in /tmp/flutter_break_on_framework_exceptions.GUJDAZ
251s <=stdout= {"protocolVersion":"0.1.1","runnerVersion":null,"pid":25763,"type":"start","time":0}
<=stdout= {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0}
<=stdout= {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0}
258s <=stdout= {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3 throwToolExit\npackage:flutter_tools/src/compile.dart 813:13 DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11 _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20 _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18 _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart...
<=stdout= {"testID":1,"error":"Failed to load \"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart\": Compilation failed for testPath=/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","stackTrace":"","isFailure":false,"type":"error","time":7518}
<=stdout= {"testID":1,"result":"error","skipped":false,"hidden":false,"type":"testDone","time":7521}
<=stdout= {"count":1,"time":7526,"type":"allSuites"}
<=stdout= {"success":false,"type":"done","time":7529}
259s Process exited (1)
371s Expecting test.startedProcess event
[+ 95] <=stdout= {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0}
[+ 95] <=stdout= {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0}
[+ 7600] <=stdout= {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3 throwToolExit\npackage:flutter_tools/src/compile.dart 813:13 DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11 _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20 _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18 _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24...
Expecting test.startedProcess event is taking longer than usual...
```
2023-04-27 18:37:59 +00:00
engine-flutter-autoroll
84e8d498a5
Roll Flutter Engine from 3d6d915cb74a to 883bb7d5cb28 (1 revision) ( #125641 )
...
3d6d915cb7...883bb7d5cbflutter/engine#41553 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-27 18:25:07 +00:00
Jenn Magder
28e17177fd
Mark module_test_ios tests unflaky ( #125498 )
...
[Dart workaround](https://dart-review.googlesource.com/c/sdk/+/297821 ) to prevent the flake has rolled into the framework. Mark the tests unflaky so we can detect if it happens again when a fix for the underlying issue lands.
https://github.com/flutter/flutter/issues/125425#issuecomment-1522142360
Reverts https://github.com/flutter/flutter/pull/125426
2023-04-27 18:09:25 +00:00
engine-flutter-autoroll
ea179fe033
Roll Flutter Engine from 381f714972d8 to 3d6d915cb74a (1 revision) ( #125637 )
...
381f714972...3d6d915cb7103135467+sealesj@users.noreply.github.com Refactor vuln scan into separate yaml (flutter/engine#41528 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-27 17:32:25 +00:00
Dan Field
fc20983686
Bump the default minSdkVersion to 19 ( #125515 )
...
See https://docs.flutter.dev/reference/supported-platforms
I don't expect this to break anything, but if it does we can revert and figure out what else needs to happen first.
Without this change, engine changes upstream will get flagged in default flutter created apps.
2023-04-27 17:26:28 +00:00
Taha Tesser
18e36dcb5d
Fix SnackBar material clip ( #125622 )
...
fixes https://github.com/flutter/flutter/issues/125619
### Before
### After
2023-04-27 16:48:27 +00:00
engine-flutter-autoroll
4dbeb3fb06
Roll Flutter Engine from 968413585768 to 381f714972d8 (1 revision) ( #125634 )
...
9684135857...381f714972skia-flutter-autoroll@skia.org Roll Dart SDK from 497a81b1af4f to c7160d4ea0b7 (1 revision) (flutter/engine#41550 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-27 15:19:34 +00:00
fzyzcjy
37c95a2853
fix: moreOrLessEquals does not allow actual to be integers ( #125599 )
...
Close https://github.com/flutter/flutter/issues/125600
2023-04-27 14:28:32 +00:00
engine-flutter-autoroll
b359f110fb
Roll Flutter Engine from 79237ad14354 to 968413585768 (1 revision) ( #125631 )
...
79237ad143...9684135857skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Du6g64Nirs3tZVK6i... to Rk2iPE0_H1vjuGV4e... (flutter/engine#41551 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Du6g64Nirs3t to Rk2iPE0_H1vj
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-27 14:25:54 +00:00
Pierre-Louis
1f602cb6ca
Provide default constraints for M3 bottom sheets ( #120065 )
...
This PR constrains M3 bottom sheets to 640dp max width by default.
`constraints` can be used to provide different `minWidth` and
`maxWidth`.
This is not a breaking change per the breaking change policy.
Part of https://github.com/flutter/flutter/issues/118619
Part of https://github.com/flutter/flutter/issues/111448
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-27 09:28:11 +02:00
engine-flutter-autoroll
9a68bffb7b
Roll Flutter Engine from 99b7fc1aa5b0 to 79237ad14354 (1 revision) ( #125606 )
...
99b7fc1aa5...79237ad143jonahwilliams@google.com Reland: [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. (flutter/engine#41538 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-27 06:39:45 +00:00
engine-flutter-autoroll
1459633486
Roll Flutter Engine from d9f91aadffd4 to 99b7fc1aa5b0 (1 revision) ( #125604 )
...
d9f91aadff...99b7fc1aa5jonahwilliams@google.com [Impeller] allow shader read for root resolve texture (flutter/engine#41543 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-27 05:35:24 +00:00
engine-flutter-autoroll
fdd6b87636
Roll Flutter Engine from 689eb6ee9047 to d9f91aadffd4 (1 revision) ( #125602 )
...
689eb6ee90...d9f91aadffskia-flutter-autoroll@skia.org Roll Skia from 3b14dcad64ef to 8441d7a93942 (1 revision) (flutter/engine#41542 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-27 04:29:23 +00:00
Kevin Moore
9565892a95
tools: Drop unused function ( #125590 )
...
Internal usage dropped in http://cl/527348621
2023-04-27 04:03:19 +00:00
engine-flutter-autoroll
3d2504951c
Roll Flutter Engine from 19045bb99c7a to 689eb6ee9047 (2 revisions) ( #125598 )
...
19045bb99c...689eb6ee90godofredoc@google.com reland "Migrate mac_host_engine to
engine v2 builds." (flutter/engine#41531 )
2023-04-27 zanderso@users.noreply.github.com Roll buildroot to
5708f2051772fd02c949e5dc9397e54f8c7a4478 (flutter/engine#41540 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 20:25:15 -07:00
engine-flutter-autoroll
4fb146e64b
Roll Flutter Engine from d4ca5240da52 to 19045bb99c7a (3 revisions) ( #125595 )
...
d4ca5240da...19045bb99cskia-flutter-autoroll@skia.org Roll Skia from d315ab065af3 to 3b14dcad64ef (1 revision) (flutter/engine#41539 )
2023-04-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 3d444bc30fc4 to 497a81b1af4f (1 revision) (flutter/engine#41537 )
2023-04-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rM9DAwmAeMc8pV11x... to Du6g64Nirs3tZVK6i... (flutter/engine#41536 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from rM9DAwmAeMc8 to Du6g64Nirs3t
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-27 02:24:04 +00:00
engine-flutter-autoroll
e454644dd5
Roll Flutter Engine from cf975417ce40 to d4ca5240da52 (11 revisions) ( #125593 )
...
cf975417ce...d4ca5240daskia-flutter-autoroll@skia.org Roll Skia from 20a1c61c5597 to
d315ab065af3 (5 revisions) (flutter/engine#41535 )
2023-04-26 jonahwilliams@google.com Revert "[Impeller] Use a device
buffer for SkBitmap allocation, use Linear texture on Metal backend."
(flutter/engine#41533 )
2023-04-26 xilaizhang@google.com [codesign] Add pinned xcode version as
property to mac android aot engine (flutter/engine#41518 )
2023-04-26 bdero@google.com [Impeller] Coerce opaque ColorSourceContents
to Source (flutter/engine#41525 )
2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 3fea88565a83 to
20a1c61c5597 (3 revisions) (flutter/engine#41530 )
2023-04-26 jonahwilliams@google.com [Impeller] partial repaint for
Impeller/iOS. (flutter/engine#40959 )
2023-04-26 30870216+gaaclarke@users.noreply.github.com Updated todo with
github issue link (flutter/engine#41517 )
2023-04-26 skia-flutter-autoroll@skia.org Roll Clang from 20d06c833d83
to 5344d8e10bb7 (flutter/engine#41524 )
2023-04-26 jonahwilliams@google.com [Impeller] Use a device buffer for
SkBitmap allocation, use Linear texture on Metal backend.
(flutter/engine#41374 )
2023-04-26 zanderso@users.noreply.github.com Manual clang roll to
5344d8e10bb7d8672d4bfae8adb010465470d51b (flutter/engine#41520 )
2023-04-26 zanderso@users.noreply.github.com Download and use the goma
client from cipd (flutter/engine#41488 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 18:32:34 -07:00
Jonah Williams
b3f3a0324a
Revert "Roll Flutter Engine from cf975417ce40 to fddd5add8b62 (3 revisions)" ( #125588 )
...
Reverts flutter/flutter#125583
Reverting to fix tree breakage caused by https://github.com/flutter/engine/pull/41533/files
2023-04-26 23:08:02 +00:00
engine-flutter-autoroll
2dda1297bb
Roll Flutter Engine from cf975417ce40 to fddd5add8b62 (3 revisions) ( #125583 )
...
cf975417ce...fddd5add8bjonahwilliams@google.com [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. (flutter/engine#41374 )
2023-04-26 zanderso@users.noreply.github.com Manual clang roll to 5344d8e10bb7d8672d4bfae8adb010465470d51b (flutter/engine#41520 )
2023-04-26 zanderso@users.noreply.github.com Download and use the goma client from cipd (flutter/engine#41488 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 21:31:07 +00:00
Zachary Anderson
1d30a1fc5a
Remove flavors_test_macos ( #125581 )
...
This test has been failing for the past >1000 runs, and is wedging a bot
for 30 minutes as the failure mode is a timeout.
Fixes https://github.com/flutter/flutter/issues/119782
2023-04-26 14:02:49 -07:00
engine-flutter-autoroll
06a6ba9675
Roll Flutter Engine from f2882afe0ec3 to cf975417ce40 (4 revisions) ( #125578 )
...
f2882afe0e...cf975417cegodofredoc@google.com Migrate Windows AOT Engine to Engine
V2. (flutter/engine#41515 )
2023-04-26 bdero@google.com [Impeller] Store the root stencil on iOS
(flutter/engine#41509 )
2023-04-26 bdero@google.com [Impeller] iOS/macOS: Only wait for command
scheduling prior to present (redux) (flutter/engine#41501 )
2023-04-26 30870216+gaaclarke@users.noreply.github.com [Impeller]
removed collisions of dead command pools between tests.
(flutter/engine#41490 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 13:10:18 -07:00
engine-flutter-autoroll
b03d6d65b8
Roll Flutter Engine from 40187bb9afac to f2882afe0ec3 (1 revision) ( #125576 )
...
40187bb9af...f2882afe0eskia-flutter-autoroll@skia.org Roll Skia from a0e3fa5aa947 to 3fea88565a83 (3 revisions) (flutter/engine#41516 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 19:02:09 +00:00
Tae Hyung Kim
5c44b1df0f
Refactor "gen-l10n" command to use same code path when "l10n.yaml" is present or not present ( #125429 )
...
I think this is a long needed change to the `gen-l10n` command.
Essentially, the arguments to `flutter gen-l10n` can be provided by two
different methods: via command line arguments or via the `l10n.yaml`
file. The existence of a `l10n.yaml` file causes the latter approach to
take precedence.
However, currently, there's several differences in how the two
approaches are handled, and most of the default arguments are all over
the place, causing unexpected issues such as #120457 or #120023 .
This PR refactors the command so that
* `LocalizationOptions` are more consistent with the actual argument
names/yaml options.
* All default values are determined in `LocalizationOptions`'s
constructor (or in `argParser.addOption(...)` in the case a boolean
value needs to be explicitly true).
* New `parseLocalizationsOptionsFromCommand` function to parse
arguments.
* Parse `LocalizationOptions` at the beginning of `runCommand()` and
pass it to `generateLocalizations`.
Fixes #120023 .
2023-04-26 11:49:25 -07:00
engine-flutter-autoroll
89c7698984
Roll Flutter Engine from f125a54f5a57 to 40187bb9afac (1 revision) ( #125566 )
...
f125a54f5a...40187bb9afskia-flutter-autoroll@skia.org Roll Skia from 47cfc5a2f0a0 to a0e3fa5aa947 (1 revision) (flutter/engine#41514 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 17:05:24 +00:00
Zachary Anderson
66fa4c5d30
Remove web compile benchmarks that specify an attached device ( #125559 )
...
Fixes https://github.com/flutter/flutter/issues/125492
2023-04-26 09:37:56 -07:00
engine-flutter-autoroll
c9d7bed421
Roll Flutter Engine from f75908135e10 to f125a54f5a57 (1 revision) ( #125560 )
...
f75908135e...f125a54f5askia-flutter-autoroll@skia.org Roll Dart SDK from b0dacad08d62 to 3d444bc30fc4 (1 revision) (flutter/engine#41513 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 15:30:21 +00:00
engine-flutter-autoroll
b0ae2e81ba
Roll Flutter Engine from c9db1587f207 to f75908135e10 (1 revision) ( #125558 )
...
c9db1587f2...f75908135eskia-flutter-autoroll@skia.org Roll Skia from 5085ba92075b to 47cfc5a2f0a0 (4 revisions) (flutter/engine#41512 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 14:36:35 +00:00
engine-flutter-autoroll
00d231c024
Roll Flutter Engine from 58a5a1e3f2c1 to c9db1587f207 (1 revision) ( #125555 )
...
58a5a1e3f2...c9db1587f2skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JKHSUjf-qEr0ZMdEi... to rM9DAwmAeMc8pV11x... (flutter/engine#41511 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JKHSUjf-qEr0 to rM9DAwmAeMc8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 13:04:13 +00:00
engine-flutter-autoroll
709d431f67
Roll Flutter Engine from 321f8015b9c2 to 58a5a1e3f2c1 (1 revision) ( #125552 )
...
321f8015b9...58a5a1e3f2skia-flutter-autoroll@skia.org Roll Dart SDK from f9d4d255c6e7 to b0dacad08d62 (4 revisions) (flutter/engine#41510 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 11:50:35 +00:00
engine-flutter-autoroll
11734dd91a
Roll Flutter Engine from 87f5f4e939cf to 321f8015b9c2 (1 revision) ( #125549 )
...
87f5f4e939...321f8015b9jiahaog@users.noreply.github.com Log dlopen errors in opt builds (flutter/engine#41477 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 09:53:06 +00:00
Michael Goderbauer
f6b9c4da23
Update prefer_final_parameters comment ( #125465 )
...
Per discusion in https://github.com/flutter/flutter/pull/125061 .
2023-04-26 07:36:19 +00:00
engine-flutter-autoroll
14be1af740
Roll Flutter Engine from 706c023df44b to 87f5f4e939cf (1 revision) ( #125539 )
...
706c023df4...87f5f4e939skia-flutter-autoroll@skia.org Roll Skia from 0f3c8eaf60b2 to 5085ba92075b (1 revision) (flutter/engine#41504 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 06:54:29 +00:00
engine-flutter-autoroll
75dd5da963
Roll Flutter Engine from 7b385abd18a2 to 706c023df44b (1 revision) ( #125536 )
...
7b385abd18...706c023df4dnfield@google.com Roll vulkan-deps and vs_toolchain (flutter/engine#41455 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 05:49:25 +00:00
engine-flutter-autoroll
b379af8be9
Roll Flutter Engine from 610c57781b47 to 7b385abd18a2 (1 revision) ( #125533 )
...
610c57781b...7b385abd18skia-flutter-autoroll@skia.org Roll Skia from 22132575fceb to 0f3c8eaf60b2 (1 revision) (flutter/engine#41499 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 04:53:24 +00:00
engine-flutter-autoroll
8de77e89b7
Roll Flutter Engine from b3cbf0678487 to 610c57781b47 (1 revision) ( #125531 )
...
b3cbf06784...610c57781bskia-flutter-autoroll@skia.org Roll Skia from 809bf518d4ab to 22132575fceb (2 revisions) (flutter/engine#41497 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 03:53:04 +00:00
Zachary Anderson
53cba8fd49
Add hostonly web compile size benchmarks ( #125518 )
...
First part of https://github.com/flutter/flutter/issues/125492
2023-04-25 19:11:12 -07:00
engine-flutter-autoroll
062f6c1dec
Roll Flutter Engine from 34ece7a4abac to b3cbf0678487 (6 revisions) ( #125529 )
...
34ece7a4ab...b3cbf06784godofredoc@google.com Migrate windows host engine to engine v2. (flutter/engine#41487 )
2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from f6f0c4b5ee98 to 809bf518d4ab (3 revisions) (flutter/engine#41494 )
2023-04-25 30870216+gaaclarke@users.noreply.github.com Made sure not to turn on wide gamut support without impeller. (flutter/engine#41460 )
2023-04-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 5bc9_eyVcLoMrWvdO... to JKHSUjf-qEr0ZMdEi... (flutter/engine#41493 )
2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 1bed4228ea3b to f6f0c4b5ee98 (7 revisions) (flutter/engine#41492 )
2023-04-25 30870216+gaaclarke@users.noreply.github.com [Impeller] Fixed blit command missing tracking and added mock vulkan for tests (flutter/engine#41408 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 5bc9_eyVcLoM to JKHSUjf-qEr0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 01:35:10 +00:00
Tae Hyung Kim
8be335f24c
Handle dollar signs properly when generating localizations ( #125514 )
...
Currently, the code doesn't properly handle strings which contain dollar signs. The return expression for the generated localization function is computed by `generateReturnExpr` which concatenates several strings, which are either interpolated placeholders, interpolated function calls, or normal strings, but we didn't properly escape dollar signs before sending normal strings to `generateReturnExpr`.
Fixes #125461 .
2023-04-25 22:52:24 +00:00
engine-flutter-autoroll
9a28f56e76
Roll Flutter Engine from 6d798393a15a to 34ece7a4abac (1 revision) ( #125516 )
...
6d798393a1...34ece7a4abgodofredoc@google.com Double zip FlutterMacOS.dSYM.zip. (flutter/engine#41425 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 22:36:42 +00:00
engine-flutter-autoroll
426e32fa0e
Roll Flutter Engine from 469e5b409686 to 6d798393a15a (2 revisions) ( #125513 )
...
469e5b4096...6d798393a1flar@google.com hide DisplayList::DisposeOps and other lint suggestions (flutter/engine#41464 )
2023-04-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 170137fc759b to f9d4d255c6e7 (1 revision) (flutter/engine#41486 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 21:39:06 +00:00
chunhtai
ef82f97fc0
Adds selected semantics flag to radio button for Apple devices ( #125499 )
...
fixes https://github.com/flutter/flutter/issues/125495
The iOS will announce 'Selected, \<label\>, button' for selected radio button after this change
2023-04-25 21:11:15 +00:00
engine-flutter-autoroll
9bf2cd3c3a
Roll Flutter Engine from 0e236982086b to 469e5b409686 (1 revision) ( #125510 )
...
0e23698208...469e5b409658529443+srujzs@users.noreply.github.com Remove package:js references and move to dart:js_interop (flutter/engine#41212 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 20:52:29 +00:00
Srujan Gaddam
829a2d07ce
Relabel JSFunction as JSExportedDartFunction ( #125453 )
...
toDart exists on the latter, not the former.
Fixing https://github.com/flutter/flutter/pull/125220 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
2023-04-25 12:19:33 -07:00
engine-flutter-autoroll
4dddac97f9
Roll Flutter Engine from 60c4e61416cd to 0e236982086b (2 revisions) ( #125504 )
...
60c4e61416...0e23698208linxunfeng@yeah.net [ios] Fix hold and drag spacebar does not move cursor when obscureText is true. (flutter/engine#40216 )
2023-04-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 337365e42613 to 170137fc759b (2 revisions) (flutter/engine#41483 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 19:16:01 +00:00
Justin McCandless
85ec874260
iOS TextField spell check style ( #125432 )
...
When using a Material TextField on iOS, the spell check selection style now defaults to the red iOS-style, not Android's blue.
2023-04-25 11:33:45 -07:00
engine-flutter-autoroll
8cd11e91fb
Roll Flutter Engine from 308bce499087 to 60c4e61416cd (1 revision) ( #125490 )
...
308bce4990...60c4e61416skia-flutter-autoroll@skia.org Roll Skia from c44f06399619 to 1bed4228ea3b (1 revision) (flutter/engine#41482 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 15:32:07 +00:00
