engine-flutter-autoroll
ebc80f0164
Roll Flutter Engine from b95da8106b98 to 4cb4478016b5 (1 revision) ( #157792 )
...
b95da8106b...4cb4478016skia-flutter-autoroll@skia.org Roll Dart SDK from 52af705f878b to fcc2bc69db3e (1 revision) (flutter/engine#56199 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 15:51:26 +00:00
Koji Wakamiya
94c537192f
Remove unused import from kt plugin template ( #157220 )
...
Remove import as `@NonNull` is no longer used by https://github.com/flutter/flutter/pull/129472 .
<img width="480" alt="code" src="https://github.com/user-attachments/assets/de45b396-995a-459f-8f36-f738d16cc229 ">
2024-10-29 15:42:20 +00:00
engine-flutter-autoroll
f935e53587
Roll Flutter Engine from 5fa7a123b14a to b95da8106b98 (1 revision) ( #157787 )
...
5fa7a123b1...b95da8106bskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RXUZ9eDc7cS4NpKoh... to zuDYsDZHnJMZVvrc8... (flutter/engine#56197 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RXUZ9eDc7cS4 to zuDYsDZHnJMZ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 13:36:17 +00:00
Taha Tesser
97596e5895
Fix TabBar tab icons not respecting custom IconTheme ( #157724 )
...
Fixes [TabBar ignores Theme's iconTheme.size](https://github.com/flutter/flutter/issues/155518 )
### Description
When `ThemeData.IconTheme` with color and size, is provided, it can override the default `Tab` icon color and size.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
iconTheme: const IconThemeData(color: Colors.amber, size: 40),
),
home: const Scaffold(
body: SafeArea(
child: DefaultTabController(
length: 2,
child: Column(
children: [
TabBar(
tabs: [
Tab(icon: Icon(Icons.backpack_outlined), text: 'Backpack'),
Tab(icon: Icon(Icons.map_outlined), text: 'Map'),
],
overlayColor: WidgetStatePropertyAll(Colors.transparent),
),
Expanded(
child: TabBarView(
children: [
Icon(Icons.backpack_outlined),
Icon(Icons.map_outlined),
],
),
),
],
),
),
),
),
);
}
}
```
</details>
---
<img width="666" alt="Screenshot 2024-10-28 at 16 25 06" src="https://github.com/user-attachments/assets/56d31115-7ee9-4378-9811-75a3a2a4ce0f ">
<img width="666" alt="Screenshot 2024-10-28 at 16 24 52" src="https://github.com/user-attachments/assets/ab8a3e4b-e912-40ac-b249-6358492581e0 ">
2024-10-29 10:51:38 +00:00
engine-flutter-autoroll
03c405a43f
Roll Flutter Engine from 0c8f0bf4d740 to 5fa7a123b14a (1 revision) ( #157780 )
...
0c8f0bf4d7...5fa7a123b1skia-flutter-autoroll@skia.org Roll Dart SDK from 6e55dfe77483 to 52af705f878b (2 revisions) (flutter/engine#56195 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 10:37:25 +00:00
aniq
c83cf967cf
Allow customizing entry mode icons in TimePicker ( #157151 )
...
This PR adds two new properties to the Material Design `TimePicker`: `switchToInputEntryModeIcon` and `switchToTimerEntryModeIcon`. These allow developers to customize the icons for toggling between dial and input modes, with default icons (`Icons.keyboard_outlined` and `Icons.access_time`) used if none are provided.
Fixes #156942
2024-10-29 10:25:20 +00:00
Valentin Vignal
2de487308a
Add test for focus_scope.0.dart ( #157772 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/focus_scope/focus_scope.0.dart`
2024-10-29 09:02:01 +00:00
Valentin Vignal
55fa5ae07f
Add test for page_storage.0.dart ( #157770 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/page_storage/page_storage.0.dart`
2024-10-29 09:01:59 +00:00
engine-flutter-autoroll
662bac8f37
Roll Flutter Engine from c05af6f939fc to 0c8f0bf4d740 (1 revision) ( #157774 )
...
c05af6f939...0c8f0bf4d7flutter/engine#56192 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 08:02:39 +00:00
engine-flutter-autoroll
4a8e2f983f
Roll Flutter Engine from b394e0c98fa0 to c05af6f939fc (1 revision) ( #157767 )
...
b394e0c98f...c05af6f939skia-flutter-autoroll@skia.org Roll Skia from bdd225968dab to 6d8a5ebeb76c (3 revisions) (flutter/engine#56185 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 03:06:38 +00:00
Valentin Vignal
88d992042c
Add test for nested_scroll_view_state.0.dart ( #157714 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/nested_scroll_view/nested_scroll_view_state.0.dart`
2024-10-29 02:40:41 +00:00
Zachary Anderson
1ab3c57ea4
Pin Mac tool_integration_test shards to arm64 ( #157760 )
...
Using `Mac_arm64` would require these to go through a `bringup: true`
dance, which would require not running in presubmit. Instead, this PR
just adds the `cpu` property to pin to `arm64` without changing the task
name.
Towards https://github.com/flutter/flutter/issues/157758
2024-10-28 19:32:32 -07:00
engine-flutter-autoroll
749c2368d2
Roll Flutter Engine from ed587dcf61fd to b394e0c98fa0 (4 revisions) ( #157766 )
...
ed587dcf61...b394e0c98fskia-flutter-autoroll@skia.org Roll Dart SDK from c9180e9de9e8 to 6e55dfe77483 (1 revision) (flutter/engine#56184 )
2024-10-28 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Deduplicate golden test file names (flutter/engine#56143 )
2024-10-28 bdero@google.com [Flutter GPU] Replace HostBuffer with Dart version. (flutter/engine#56054 )
2024-10-28 jonahwilliams@google.com [Impeller] add basic Impeller+Vulkan support to embedder API. (flutter/engine#55490 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 02:00:24 +00:00
engine-flutter-autoroll
6f9a476cd3
Roll Flutter Engine from 70671baabbba to ed587dcf61fd (10 revisions) ( #157751 )
...
70671baabb...ed587dcf61skia-flutter-autoroll@skia.org Roll Dart SDK from 69b50768d733 to c9180e9de9e8 (1 revision) (flutter/engine#56180 )
2024-10-28 jonahwilliams@google.com [Impeller] fix initial layout for loadOp load and incorrect usage of host visible textures. (flutter/engine#56148 )
2024-10-28 skia-flutter-autoroll@skia.org Roll Skia from 21035cd95b68 to bdd225968dab (1 revision) (flutter/engine#56178 )
2024-10-28 chris@bracken.jp iOS/macOS: migrate darwin/common to ARC (flutter/engine#56155 )
2024-10-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Pin local_engine mac builds to arm64 (#56172 )" (flutter/engine#56179 )
2024-10-28 chris@bracken.jp Migrate PlatformViewIOS to ARC (flutter/engine#55672 )
2024-10-28 skia-flutter-autoroll@skia.org Roll Skia from 35ad4e89212f to 21035cd95b68 (1 revision) (flutter/engine#56176 )
2024-10-28 aam@google.com Roll buildroot to pick up revert of debugging gen_snapshot prints (flutter/engine#56175 )
2024-10-28 zanderso@users.noreply.github.com Pin local_engine mac builds to arm64 (flutter/engine#56172 )
2024-10-28 zanderso@users.noreply.github.com Switch some mac_unopt tests from intel to arm hosts (flutter/engine#55882 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 22:08:56 +00:00
engine-flutter-autoroll
8990ed6538
Roll Flutter Engine from 23b2c6d3b3b1 to 70671baabbba (1 revision) ( #157740 )
...
23b2c6d3b3...70671baabbskia-flutter-autoroll@skia.org Roll Skia from f08fbc465888 to 35ad4e89212f (1 revision) (flutter/engine#56171 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 19:22:05 +00:00
engine-flutter-autoroll
3fb95c7dd2
Roll Flutter Engine from bf5bfeebf89f to 23b2c6d3b3b1 (3 revisions) ( #157736 )
...
bf5bfeebf8...23b2c6d3b3jonahwilliams@google.com [Impeller] dont increment shared_ptr when tracked object is already tracked. (flutter/engine#56153 )
2024-10-28 skia-flutter-autoroll@skia.org Roll Dart SDK from a75848f92210 to 69b50768d733 (2 revisions) (flutter/engine#56168 )
2024-10-28 skia-flutter-autoroll@skia.org Roll Skia from 263c3e2ecd30 to f08fbc465888 (1 revision) (flutter/engine#56170 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 18:18:07 +00:00
Jenn Magder
4a4664946b
Avoid labeling 'context' PRs as 'text-input' ( #157650 )
...
https://github.com/flutter/flutter/pull/157646 is being labeled by the PR labeler as "text-input" because it edited "con**text**_runner.dart".
```
##[debug] "**/*text*" pattern matched packages/flutter_tools/lib/src/context_runner.dart
```
https://github.com/flutter/flutter/actions/runs/11526508378/job/32090756495?pr=157646#step:2:134
Exclude the common "context" word from this label rule.
See negation example at https://github.com/actions/labeler/blob/main/README.md#basic-examples .
2024-10-28 17:34:56 +00:00
Valentin Vignal
ab256e5caf
Add test for restorable_route_future.0.dart ( #157708 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/navigator/restorable_route_future.0.dart`
2024-10-28 17:02:07 +00:00
Reid Baker
bac39a3899
Update .ci.yaml have android sdk be 35v1 ( #157621 )
...
Bump the android sdk to 35v1 to see if doing so helps android 35 emulator stability.
2024-10-28 16:01:23 +00:00
engine-flutter-autoroll
a1587bdf2f
Roll Flutter Engine from 2522789c4199 to bf5bfeebf89f (1 revision) ( #157713 )
...
2522789c41...bf5bfeebf8skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VJIEKDIuzhhloCBro... to RXUZ9eDc7cS4NpKoh... (flutter/engine#56166 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from VJIEKDIuzhhl to RXUZ9eDc7cS4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 12:21:32 +00:00
Valentin Vignal
e6e820d776
Add test for restoration_mixin.0.dart ( #157709 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/restoration/restoration_mixin.0.dart`
2024-10-28 11:37:15 +00:00
Valentin Vignal
b9f62f6f9f
Add test for navigator.restorable_push_replacement.0.dart ( #157704 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/navigator/navigator.restorable_push_replacement.0.dart`
2024-10-28 11:23:30 +00:00
Valentin Vignal
d9cb4b8c17
Add test for focus_node.unfocus.0.dart ( #157673 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/focus_manager/focus_node.unfocus.0.dart`
2024-10-28 10:47:23 +00:00
engine-flutter-autoroll
6143753ae1
Roll Flutter Engine from 9226b089d634 to 2522789c4199 (2 revisions) ( #157710 )
...
9226b089d6...2522789c41skia-flutter-autoroll@skia.org Roll Skia from 0e5cf5c5f5a3 to 263c3e2ecd30 (1 revision) (flutter/engine#56164 )
2024-10-28 skia-flutter-autoroll@skia.org Roll Skia from dd0158912c76 to 0e5cf5c5f5a3 (2 revisions) (flutter/engine#56163 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 10:41:31 +00:00
Valentin Vignal
8f5d032d78
Add tests for navigator_state.restorable_push.0.dart ( #157667 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/navigator/navigator_state.restorable_push.0.dart`
2024-10-28 08:10:19 +00:00
engine-flutter-autoroll
3abd2f3131
Roll Flutter Engine from 10e50bd42c42 to 9226b089d634 (1 revision) ( #157702 )
...
10e50bd42c...9226b089d6skia-flutter-autoroll@skia.org Roll Skia from cadf2538dcde to dd0158912c76 (3 revisions) (flutter/engine#56162 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 07:40:53 +00:00
Valentin Vignal
eef9f7129e
Add test for navigator_state.restorable_push_replacement.0.dart ( #157668 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/navigator/navigator_state.restorable_push_replacement.0.dart`
2024-10-28 06:56:39 +00:00
Sam Rawlins
5879a5cba1
Remove unsafe_html lint rule ( #157531 )
...
Fixes https://github.com/flutter/flutter/issues/157530
2024-10-28 01:09:20 +00:00
engine-flutter-autoroll
16c5c80867
Roll Flutter Engine from 3162aaad0086 to 10e50bd42c42 (1 revision) ( #157690 )
...
3162aaad00...10e50bd42cskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5osQdhk4W6CcWgjIg... to VJIEKDIuzhhloCBro... (flutter/engine#56154 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 5osQdhk4W6Cc to VJIEKDIuzhhl
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-27 14:05:23 +00:00
yim
04bcfe9281
Fix Scaffold extend body ( #157441 )
...
Fixes : #157316
2024-10-27 04:54:30 +00:00
engine-flutter-autoroll
030eea8617
Roll Flutter Engine from c9b8ac96f6ce to 3162aaad0086 (3 revisions) ( #157681 )
...
c9b8ac96f6...3162aaad00chris@bracken.jp Migrate FlutterViewController to ARC (flutter/engine#55669 )
2024-10-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Y4TdnTpLdkI107K42... to 5osQdhk4W6CcWgjIg... (flutter/engine#56152 )
2024-10-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 0257f458e40a to a75848f92210 (2 revisions) (flutter/engine#56150 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Y4TdnTpLdkI1 to 5osQdhk4W6Cc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-26 23:04:38 +00:00
gaaclarke
5a11904383
Relands "Wide gamut framework gradient test ( #153976 )" ( #157643 )
...
This was reverted because it failed to run. Colors were getting clamped
in the dithering fragment shader.
One change was made when relanding, i increased the epsilon for the
radial and conical gradients. They don't appear to give back the exact
color you asked for.
Do not land until https://github.com/flutter/engine/pull/56140 is rolled
into the framework.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-10-26 08:44:53 -07:00
engine-flutter-autoroll
9327c24d80
Roll Flutter Engine from 7c5c5fe5c84d to c9b8ac96f6ce (3 revisions) ( #157662 )
...
7c5c5fe5c8...c9b8ac96f6skia-flutter-autoroll@skia.org Roll Skia from da6c17329e0b to cadf2538dcde (3 revisions) (flutter/engine#56147 )
2024-10-25 30870216+gaaclarke@users.noreply.github.com Removed clamping from dithering (flutter/engine#56140 )
2024-10-25 jacksongardner@google.com Reland (x2) Skwasm overlay optimizations (flutter/engine#56067 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-26 13:37:42 +00:00
Valentin Vignal
2d09837ed0
Add test for navigator_state.restorable_push_and_remove_until.0.dart ( #157595 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/navigator/navigator_state.restorable_push_and_remove_until.0.dart`
2024-10-26 10:21:26 +00:00
Matan Lurey
3af8b0a4df
Tighten up throwToolExit, explain when to use it. ( #157561 )
...
Documents when to use `throwToolExit` and how to use it.
Replaces every invocation of `throw ToolExit` with `throwToolExit` and makes the former impossible; this is so that every user will at least (hypothetically) have the chance to read the documentation attached to `throwToolExit` (and if we change parameters in the future they will all flow through one place).
2024-10-26 03:17:24 +00:00
Matan Lurey
82a20e407e
Remove extraneous throw. ( #157658 )
...
h/t to @tvolkert for noticing this one!
2024-10-26 02:49:20 +00:00
Valentin Vignal
4e52defed4
Add tests for navigator.restorable_push.0.dart ( #157492 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/navigator/navigator.restorable_push.0.dart`
2024-10-26 02:39:13 +00:00
engine-flutter-autoroll
ece457ba74
Roll Flutter Engine from 43e4d9a30666 to 7c5c5fe5c84d (1 revision) ( #157644 )
...
43e4d9a306...7c5c5fe5c8jonahwilliams@google.com [Impeller] Lock access to descriptor
pool map. (flutter/engine#56113 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 16:01:12 -07:00
engine-flutter-autoroll
9b84dbed06
Roll Flutter Engine from 5061358e255f to 43e4d9a30666 (1 revision) ( #157637 )
...
5061358e25...43e4d9a306skia-flutter-autoroll@skia.org Roll Dart SDK from
3067d697ae26 to 0257f458e40a (4 revisions) (flutter/engine#56135 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 14:49:51 -07:00
engine-flutter-autoroll
1cc8a07ace
Roll Flutter Engine from eb867e055790 to 5061358e255f (2 revisions) ( #157623 )
...
eb867e0557...5061358e2530870216+gaaclarke@users.noreply.github.com renamed TextFrameDispatcher to FirstPassDispatcher (flutter/engine#56098 )
2024-10-25 30870216+gaaclarke@users.noreply.github.com Added retry mechanism for pipeline creation (flutter/engine#56071 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 20:31:21 +00:00
Polina Cherkasova
9cf98f7273
Create flutter specific leak troubleshooting guidance. ( #157396 )
2024-10-25 13:25:34 -07:00
Kate Lovett
2c20325af4
Update CupertinoNavigationBar to support large layout ( #157133 )
...
Fixes https://github.com/flutter/flutter/issues/149625
This adds a new constructor CupertinoNavigationBar.large for the large style navigation bar. CupertinoSliverNavigationBar enables dynamically changing between the smaller and larger layouts for native iOS headers in response to scrolling, this change makes it possible to configure the static navigation bar in one style or the other.
2024-10-25 19:08:12 +00:00
engine-flutter-autoroll
6337eb1a39
Roll Flutter Engine from 38e9be1f74fa to eb867e055790 (3 revisions) ( #157613 )
...
38e9be1f74...eb867e055730870216+gaaclarke@users.noreply.github.com Faster vulkan buffer tracking (flutter/engine#56099 )
2024-10-25 jonahwilliams@google.com [Impeller] Reland: hash less stuff per frame. (flutter/engine#55742 )
2024-10-25 skia-flutter-autoroll@skia.org Roll Skia from cc75472dedc2 to da6c17329e0b (3 revisions) (flutter/engine#56132 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 18:43:25 +00:00
auto-submit[bot]
add7e81f4f
Reverts "Wide gamut framework gradient test ( #153976 )" ( #157615 )
...
Reverts: flutter/flutter#153976
Initiated by: jonahwilliams
Reason for reverting: failing on postsubmit
Original PR Author: gaaclarke
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
issue: https://github.com/flutter/flutter/issues/127855
depends on https://github.com/flutter/engine/pull/54748 being rolled into the framework
2024-10-25 17:38:18 +00:00
gaaclarke
4f66f1333f
Wide gamut framework gradient test ( #153976 )
...
issue: https://github.com/flutter/flutter/issues/127855
depends on https://github.com/flutter/engine/pull/54748 being rolled into the framework
2024-10-25 17:04:57 +00:00
engine-flutter-autoroll
8252990e1b
Roll Flutter Engine from b413d9996c86 to 38e9be1f74fa (2 revisions) ( #157604 )
...
b413d9996c...38e9be1f74robert.ancell@canonical.com Clean up comments and names in FlView (flutter/engine#56084 )
2024-10-25 robert.ancell@canonical.com Move platform handler from FlView to FlEngine (flutter/engine#56024 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 16:39:58 +00:00
engine-flutter-autoroll
74a6613469
Roll Packages from a556f0f52825 to e0c4f55cd355 (2 revisions) ( #157605 )
...
a556f0f528...e0c4f55cd3stuartmorgan@google.com [path_parsing] Initial import (flutter/packages#7908 )
2024-10-24 stuartmorgan@google.com [video_player] Simplify Pigeon API on Android (flutter/packages#7909 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 16:35:57 +00:00
Jonah Williams
c4c545215a
Support backdrop key in flutter framework. ( #157278 )
...
The backdrop key functionality allows multiple backdrop filters to share the same input filter, dramatically improving raster performance. This is only supported on the Impeller backend.
The backdrop key class allocates a new int from a static and passes this to the engine layer. with 64 bit integers, we can allocate many backdrop filter ids per frame and never run out.
See also: https://github.com/flutter/flutter/issues/156455
```dart
import 'dart:math';
import 'dart:ui';
import 'package:flutter/material.dart';
final _random = Random();
void main() => runApp(const BackdropFilterDemo());
class BackdropFilterDemo extends StatelessWidget {
const BackdropFilterDemo({super.key});
static final listKey = BackdropKey();
static final overlayKey = BackdropKey();
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
backgroundColor: Colors.white,
body: Stack(
children: [
ListView.builder(
itemCount: 120, // 60 pairs of red and blue containers
itemBuilder: (context, index) {
return Container(
height: 100,
color: index % 2 == 0 ? Colors.red : Colors.blue,
);
},
),
Center(
child: Container(
width: 400,
height: 400,
decoration: BoxDecoration(
border: Border.all(color: Colors.black),
),
child: Image.network('https://picsum.photos/400 '),
),
),
ListView.separated(
separatorBuilder: (_, __) => const SizedBox(height: 8),
itemBuilder: (context, index) => BlurEffect(
backdropKey: listKey,
child: SizedBox(
height: 50,
child: Center(
child: Text(index.toString(),
style: const TextStyle(color: Colors.white)),
),
),
),
itemCount: 200,
),
Positioned.fill(
bottom: null,
child: BlurEffect(
backdropKey: overlayKey,
child: Padding(
padding: EdgeInsets.only(
top: MediaQuery.of(context).viewPadding.top,
),
child: const SizedBox(height: 45),
),
),
),
Positioned.fill(
top: null,
child: BlurEffect(
backdropKey: overlayKey,
child: Padding(
padding: EdgeInsets.only(
top: MediaQuery.of(context).viewPadding.bottom,
),
child: const SizedBox(height: 50),
),
),
),
],
),
),
);
}
}
class BlurEffect extends StatelessWidget {
final Widget child;
const BlurEffect({
required this.child,
required this.backdropKey,
super.key,
});
final BackdropKey backdropKey;
@override
Widget build(BuildContext context) {
return ClipRect(
child: BackdropFilter(
backdropKey: backdropKey,
filter: ImageFilter.blur(
sigmaX: 40,
sigmaY: 40,
// tileMode: TileMode.mirror,
),
child: DecoratedBox(
decoration: BoxDecoration(color: Colors.black.withOpacity(.65)),
child: child,
),
),
);
}
}
```
### Skia
<img src="https://github.com/user-attachments/assets/4c08e92d-f0ba-42b2-a4c4-fc44efbcfae0 " width="200"/>
### Impeller
<img src="https://github.com/user-attachments/assets/21e95efd-5e0c-4f41-8f84-af3f0e47d1aa " width="200"/>
2024-10-25 16:27:51 +00:00
Reid Baker
23274284a7
Add 3.24.4 changelog to master ( #157600 )
...
https://github.com/flutter/flutter/pull/157596/files
2024-10-25 15:36:01 +00:00
Mohellebi abdessalem
7e2a06657c
Update flutter.groovy to catch unknown task exception when finding api task ( #157282 )
...
see #147122 for context
and [this](https://github.com/flutter/flutter/pull/157221 ) for more
2024-10-25 14:51:12 +00:00
