12575 Commits

Author SHA1 Message Date
Hans Muller
ec4f22c17b
Revert "Restore Flutter Gallery Shrine Demo, again (round 3) (#24531)" (#24538)
This reverts commit 4ec8883b83c94a7ba55cdf94af18830074dc24f2.
2018-11-19 13:02:18 -08:00
Hans Muller
4ec8883b83
Restore Flutter Gallery Shrine Demo, again (round 3) (#24531) 2018-11-19 12:21:49 -08:00
engine-flutter-autoroll
af57ee5970
2f1b388f5 Roll src/third_party/skia f7376330d11e..f2a7a20b32ad (7 commits) (flutter/engine#6906) (#24530)
2e06da3df9...2f1b388f5a

git log 2e06da3df9cb..2f1b388f5ab5 --no-merges --oneline
2f1b388f5 Roll src/third_party/skia f7376330d11e..f2a7a20b32ad (7 commits) (flutter/engine#6906)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-19 15:06:05 -05:00
jslavitz
743960df27
Cupertino picker null color fix (#24529)
*null fix and test
2018-11-19 12:00:21 -08:00
Jonah Williams
9d81c67a3f
Pass correct physics instance to Scrollable semantics (#24416) 2018-11-19 10:31:02 -08:00
Todd Volkert
c793d43ee0
Slight doc change (#24526) 2018-11-19 09:11:40 -08:00
engine-flutter-autoroll
7a005e1dcd
Roll engine cebde437a1b1..2e06da3df9cb (4 commits) (#24521)
cebde437a1...2e06da3df9

git log cebde437a1b1..2e06da3df9cb --no-merges --oneline
2e06da3df Roll src/third_party/skia e7b1a13a1e2a..f7376330d11e (1 commits) (flutter/engine#6905)
46b2e1eed Roll src/third_party/skia 01979132133e..e7b1a13a1e2a (1 commits) (flutter/engine#6904)
dccbf9f41 Roll src/third_party/skia e22505b4f07f..01979132133e (1 commits) (flutter/engine#6902)
3114206a6 Roll src/third_party/skia def9bcecd994..e22505b4f07f (1 commits) (flutter/engine#6901)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-19 11:14:05 -05:00
Alexandre Ardhuin
79b5e5bc8a
Add missing lints (#24381)
* update lint list

* enable sort_pub_dependencies

* enable avoid_returning_null_for_void

* enable flutter_style_todos
2018-11-19 10:37:55 +01:00
Danny Tuppeny
15e3df25c5
Refactor Test Driver in preparation for flutter test integration tests (#24060)
* Refactor Test Driver in preperation for `flutter test` integration tests

* Fix indent
2018-11-19 08:25:42 +00:00
Danny Tuppeny
113f8f1a8d
Make FlutterTestDriver.stop() safe to call if it didn't spawn a process (#24393)
This means we can just always add it to test teardowns without having to add try/catches if there are any tests that don't spawn a process.
2018-11-19 07:16:32 +00:00
Danny Tuppeny
08e7f26510
Remove timeout waiting for app to start (#24336) 2018-11-19 07:15:52 +00:00
engine-flutter-autoroll
ef37e9d64b
Roll engine c02dd8f935a4..cebde437a1b1 (15 commits) (#24498)
c02dd8f935...cebde437a1

git log c02dd8f935a4..cebde437a1b1 --no-merges --oneline
cebde437a Guard the service protocol's global handlers list with a reader/writer lock. (flutter/engine#6900)
b6e93759f Revert "Guard the service protocol's global handlers list with a reader/writer lock (#6888) #6895" (flutter/engine#6899)
b44b94eea Roll src/third_party/skia 66b91e4afb88..def9bcecd994 (1 commits) (flutter/engine#6898)
25db6e082 Roll src/third_party/skia d017e5138c57..66b91e4afb88 (1 commits) (flutter/engine#6897)
fd0911cc0 Guard the service protocol's global handlers list with a reader/writer lock (#6888) (flutter/engine#6895)
fffcce47f Roll src/third_party/skia 1bfdd1adfa22..d017e5138c57 (1 commits) (flutter/engine#6896)
a01c82e9d Roll src/third_party/skia 7e9ea391cfce..1bfdd1adfa22 (1 commits) (flutter/engine#6894)
9ba556156 Revert "Guard the service protocol's global handlers list with a reader/writer lock (#6888)" (flutter/engine#6893)
517e52548 Roll src/third_party/skia 73b4a1f57254..7e9ea391cfce (1 commits) (flutter/engine#6892)
9352360c8 Guard the service protocol's global handlers list with a reader/writer lock (flutter/engine#6888)
9296d80c8 Roll src/third_party/skia 7fb30f11a055..73b4a1f57254 (3 commits) (flutter/engine#6891)
93cbf60b6 Roll src/third_party/skia 281224020a57..7fb30f11a055 (1 commits) (flutter/engine#6889)
aa9793f73 Roll src/third_party/skia a2187bf7629a..281224020a57 (5 commits) (flutter/engine#6887)
3978f0753 Keep a copy of each engine's description that can be accessed outside the engine's UI thread (flutter/engine#6885)
0870e3782 Roll src/third_party/skia 3b155a77c370..a2187bf7629a (11 commits) (flutter/engine#6884)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-18 19:48:05 -05:00
jslavitz
5385132c6b
Separate keep alive logic from SliverMultiBox classes (#24192)
* sliver separation and test
2018-11-16 16:53:59 -08:00
engine-flutter-autoroll
fc4f9b9e56
Roll engine 5a694c47738d..c02dd8f935a4 (2 commits) (#24452)
5a694c4773...c02dd8f935

git log 5a694c47738d..c02dd8f935a4 --no-merges --oneline
c02dd8f93 Don't load a splash screen by default (flutter/engine#6883)
8a42213d0 Remove unused examples targets. (flutter/engine#6882)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-16 19:11:59 -05:00
Greg Spencer
eddd06f1fe
Re-enable docs generation (#24453)
Hopefully Firebase is all done compacting now, so we're going to try and build docs again.
2018-11-16 16:08:16 -08:00
engine-flutter-autoroll
35279db114
Roll engine c622e563e764..5a694c47738d (3 commits) (#24451)
c622e563e7...5a694c4773

git log c622e563e764..5a694c47738d --no-merges --oneline
5a694c477 Roll src/third_party/skia c00e47054744..3b155a77c370 (2 commits) (flutter/engine#6881)
5ded3679e Roll src/third_party/skia a89316d8227b..c00e47054744 (4 commits) (flutter/engine#6880)
5c327e196 Roll src/third_party/skia c5df7cb3d9f7..a89316d8227b (10 commits) (flutter/engine#6878)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-16 18:08:59 -05:00
Fedor Korotkov
9ae2bad10d [ci] add more memory (#24445)
While investigating reports from @gspencergoog about unexpectedly failing tasks I've found out that `tool_tests` sometimes fails with Out Of Memory errors. I've also added detection of such issues to Cirrus CI.
2018-11-16 14:55:14 -08:00
Justin McCandless
a8552ca7ec
Switch list tile adaptive (#24437)
* SwitchListTile.adaptive for wrapping an adaptive Switch

* Test SwitchListTile.adaptive same as Switch.adaptive

* Remove TODO

* Comment and switch statement cleanup
2018-11-16 14:50:17 -08:00
jslavitz
265485033b
Fixes navigation page back drag area for iPhone X (#24375)
* nav fix and test
2018-11-16 12:47:50 -08:00
jslavitz
b3d9fb4dee
Scaffold Drawer pull out area fix for notched devices (#24367)
* Adds fix and test
2018-11-16 12:47:34 -08:00
engine-flutter-autoroll
4a79caf96b
Roll engine 04e716ff2cf3..c622e563e764 (2 commits) (#24439)
04e716ff2c...c622e563e7

git log 04e716ff2cf3..c622e563e764 --no-merges --oneline
c622e563e Roll src/third_party/skia 6e486cec6a10..c5df7cb3d9f7 (4 commits) (flutter/engine#6877)
61725486b Roll src/third_party/skia c735b4f9dc50..6e486cec6a10 (1 commits) (flutter/engine#6875)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-16 13:33:59 -05:00
engine-flutter-autoroll
2952b26d66
04e716ff2 Roll src/third_party/skia dcdb6042002f..c735b4f9dc50 (1 commits) (flutter/engine#6874) (#24438)
333c2c1ac4...04e716ff2c

git log 333c2c1ac41f..04e716ff2cf3 --no-merges --oneline
04e716ff2 Roll src/third_party/skia dcdb6042002f..c735b4f9dc50 (1 commits) (flutter/engine#6874)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-16 12:36:59 -05:00
Justin McCandless
c8ff617fd8
Text field border radius bug fix (#24414)
* Fix radius glitch by carrying over border when lerping outline borders

* Test that border doesn't change

* Regression comment
2018-11-16 09:32:24 -08:00
engine-flutter-autoroll
2d87b823bb
333c2c1ac Roll src/third_party/skia e5bb81f640a1..dcdb6042002f (2 commits) (flutter/engine#6871) (#24422)
d1ea3fe02f...333c2c1ac4

git log d1ea3fe02f62..333c2c1ac41f --no-merges --oneline
333c2c1ac Roll src/third_party/skia e5bb81f640a1..dcdb6042002f (2 commits) (flutter/engine#6871)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-16 11:38:59 -05:00
engine-flutter-autoroll
0ce68412d9
Roll engine 699f328df578..d1ea3fe02f62 (5 commits) (#24418)
699f328df5...d1ea3fe02f

git log 699f328df578..d1ea3fe02f62 --no-merges --oneline
d1ea3fe02 Roll src/third_party/skia 2791be403817..e5bb81f640a1 (2 commits) (flutter/engine#6870)
921eca92e Roll src/third_party/skia 5fb83f94c1f2..2791be403817 (5 commits) (flutter/engine#6869)
d8b52ef89 Reland "Clean up stale cache entries in Skia's GrContext" (flutter/engine#6867)
e6f22b74e Fix license headers (flutter/engine#6868)
6de0be2db Add presubmit check for license count (flutter/engine#6759)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-16 01:22:05 -05:00
xster
988bfc166d
iOS tap handling on CupertinoTextField (#24034) 2018-11-15 18:07:17 -08:00
Dan Field
0155ee7157
fix devicelab (#24404) 2018-11-15 17:55:01 -08:00
Dan Field
67a7361d95
Roll engine to 699f328df5787f4960808cd3bd729dcb741e6132 (#24409)
* Roll engine to 699f328df5787f4960808cd3bd729dcb741e6132 (#24409)
2018-11-15 17:52:45 -08:00
Dan Field
77237c0ed1
add missing entry to material_mr.arb (#24410)
* add missing entry to material_mr.arb
2018-11-15 16:37:14 -08:00
Dan Field
78c5bb2a8e
Make progress indicators accessible (#24275)
* Make progress indicators accessible
2018-11-15 15:54:56 -08:00
xster
567b31a716
Un-dirty git with debug gallery build (#24373) 2018-11-15 15:17:50 -08:00
Greg Spencer
f20adcc428
Add docset generation (#24322)
(re-land of #24244)

This generates a zip file containing all of the docs, and uploads it when we publish docs, as well as a
Dash/Zeal docset that contains a feed of the docs.

Addresses at least part of #9955
2018-11-15 15:05:57 -08:00
Justin McCandless
f9bccb0280
Handle a missing ListView separator as an error (#24312)
* Handle a missing ListView separator as an error

* Handle missing item, and errors in itemBuilder and separatorBuilder

* CR fixes and move error handling into sliver.dart to handle all ListView constructors

* Only show an error for null separatorBuilder value in debug mode
2018-11-15 14:40:13 -08:00
Jonah Williams
938dd5a4aa
Revert "Update driver script to execute test through test_core" (#24401)
* Revert "Add dashing config file for generating docset from flutter docs (#24374)"

This reverts commit ec8ca8606c9eec8b1ecc965f5045fd29130a7e16.

* Revert "Update driver script to execute test through test_core (#24168)"

This reverts commit 6c62cf337fb662684bb206e89018792eb68eb10a.
2018-11-15 11:17:00 -08:00
Daohan Chong
ec8ca8606c Add dashing config file for generating docset from flutter docs (#24374) 2018-11-15 10:57:02 -08:00
Jonah Williams
6c62cf337f
Update driver script to execute test through test_core (#24168) 2018-11-15 10:50:25 -08:00
engine-flutter-autoroll
c559f1def3
db5908815 Roll src/third_party/skia 7d2aae3165a2..2eccd58916ee (3 commits) (flutter/engine#6862) (#24387)
00e4abff84...db59088159

git log 00e4abff84a6..db59088159a5 --no-merges --oneline
db5908815 Roll src/third_party/skia 7d2aae3165a2..2eccd58916ee (3 commits) (flutter/engine#6862)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-15 13:09:04 -05:00
Diego Tori
9447be7370 Added support for passing in velocity and offset into Draggable.onDragCompleted (#22267)
* Added support for passing in velocity and offset into Draggable.onDragCompleted.

* Fixed documentation of DragCompletedCallback.

* Spun off previous onDragCompleted breaking changes into new callback called Draggable.onDragEnd.

* Revert "Fixed documentation of DragCompletedCallback."

This reverts commit 069051f5be0d4ec6a1f4b3f072e535ca87e5d740.

* Revert "Added support for passing in velocity and offset into Draggable.onDragCompleted."

This reverts commit 7ef744aa5645429b7bc92527226203ee8bff68ec.

* DraggableDetails constructor is now declared first as per Flutter code style.

* Draggable.onDragEnd will only call back if its widget is currently mounted to the tree.

* Moved "});" in DraggableDetails constructor to new line, vertically aligned with the constructor name, as per Flutter code style.

* Added space between if statement in drag_target.dart.

* widget.onDragEnd call is now formated as per flutter code style.

* Added more details to DraggableDetails documentation.

* Added brackets to if statement block as per Flutter code style.

* Fixed minor nits in DraggableDetails documentation.

* Made DraggableDetails constructor public. Also added documentation for its constructor.
2018-11-15 09:11:04 -08:00
engine-flutter-autoroll
33f8030b32
Roll engine 498bbd5ef9c1..00e4abff84a6 (2 commits) (#24372)
498bbd5ef9...00e4abff84

git log 498bbd5ef9c1..00e4abff84a6 --no-merges --oneline
00e4abff8 Roll src/third_party/skia 44764000b49c..7d2aae3165a2 (1 commits) (flutter/engine#6861)
2c6be93fa Clean up stale cache entries in Skia's GrContext (flutter/engine#6859)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-14 23:06:49 -05:00
Dan Field
091b73ab6f
fix variable check in xcode_backend.sh (#24368)
* fix test in xcode_backend.sh

* -n

* fix devicelab test

* uncomment good code, check for \"\"
2018-11-14 18:54:51 -08:00
Alexander Aprelev
64a8d44764
Fix test so it doesn't leak frontend_server process (#24360)
* Fix test so it doesn't leak frontend_server process

* Stop FlutterTestDriver even if expectation is not met
2018-11-14 18:50:18 -08:00
engine-flutter-autoroll
e8eea83472
Roll engine 289de46d3e55..498bbd5ef9c1 (3 commits) (#24364)
289de46d3e...498bbd5ef9

git log 289de46d3e55..498bbd5ef9c1 --no-merges --oneline
498bbd5ef Roll src/third_party/skia f152130ef910..44764000b49c (8 commits) (flutter/engine#6860)
f23862b25 Added delegate forwarding for didReceiveLocalNotification and willPresentNotification (flutter/engine#6858)
110a5f320 Reset a11y bridge state on hot restart (flutter/engine#6857)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-14 21:49:49 -05:00
Yegor
9c3754d92f
FlutterDriver: allow customizing timeouts using a multiplier (#24066)
FlutterDriver: allow customizing timeouts using a multiplier
2018-11-14 17:15:00 -08:00
Greg Spencer
eb35f8923b
Reland: Make the 'time to update' message depend up on the channel. (#24173) (#24321)
Fixes #24158
Re-lands #24173
2018-11-14 16:51:12 -08:00
S McDowall
87156df6d9 Optionally show the text field length but not the max (#24183)
If maxLength is set to TextField.noMaxLength then continue to show the character counter but do not display the max input length value.
2018-11-14 16:04:39 -08:00
Zachary Anderson
779c68f691
[fuchsia] Fix BUILD and metadata file for Fuchsia (#24294) 2018-11-14 15:43:06 -08:00
Hans Muller
70d83cc7ac
Add support for the Marathi language, locale mr_IN (#24353) 2018-11-14 15:42:51 -08:00
liyuqian
ba635a643a
Add golden tests for Opacity with offset (#24253)
See https://github.com/flutter/flutter/issues/23890
2018-11-14 15:00:39 -08:00
engine-flutter-autoroll
07c5c0ac1b
289de46d3e5598a265e2fd83c1d4004ec8a65f9b (#24359)
14ee957fb4...289de46d3e

git log 14ee957fb4d3..289de46d3e55 --no-merges --oneline
289de46d3 Return EngineLayer for all SceneBuilder pushXXX (flutter/engine#6814)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-11-14 17:30:50 -05:00
James D. Lin
26f94bdd49
Make examples/catalog instructions a bit less confusing (#24252)
Make the examples/catalog instructions a bit less confusing:
* Make the README.md file provide explicit instructions about how to
  run each example.
* Try to clarify that the lib/main.dart message is instructional and
  not an error message.

Additionally, adjust examples/layers/lib/main.dart to be consistent
with examples/catalog/lib/main.dart.

Fixes #22640.

Testing Done:
* Ran `flutter run` from examples/catalog and from examples/layers,
  saw the updated message.
2018-11-14 14:26:30 -08:00