firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,118 Commits 1 Branch 0 Tags
Commit Graph

29204 Commits

Author SHA1 Message Date
gaaclarke
fa68c30a0f Adds vscode workspace with impeller test runner (flutter/engine#55291) 
This PR removes our checked in .vscode files and instead starts a vscode
workspace for the engine. As a first step I've added build tasks for the
arm64 `impeller_unittests`. I also setup C++ TestMate so that we can
easily navigate to tests and execute them. The tests will be rebuilt
before each execution.

The goal would be that eventually all of our c++ tests can be listed
here. This is going to make external contribution much easier and make
it so I don't have to keep editing the "launch.json" file to run
specific tests.


![ezgif-2-bcd582b44e](https://github.com/user-attachments/assets/11cea32e-628f-4626-b87d-9d3ebfe11357)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-09-20 12:57:32 -07:00
skia-flutter-autoroll
6f38ea9b38 Roll Dart SDK from 21402561f6d3 to 419aef963b5a (1 revision) (flutter/engine#55320) 
https://dart.googlesource.com/sdk.git/+log/21402561f6d3..419aef963b5a

2024-09-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-270.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-20 18:24:20 +00:00
skia-flutter-autoroll
e7866ef4f1 Roll Skia from cde3d60ab3fe to 16f53694ec96 (1 revision) (flutter/engine#55319) 
https://skia.googlesource.com/skia.git/+log/cde3d60ab3fe..16f53694ec96

2024-09-20 jvanverth@google.com [graphite] Bump purge flush count up to 8.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-20 17:17:14 +00:00
skia-flutter-autoroll
d4e2954664 Roll Skia from c79d632de004 to cde3d60ab3fe (2 revisions) (flutter/engine#55318) 
https://skia.googlesource.com/skia.git/+log/c79d632de004..cde3d60ab3fe

2024-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 20cc91312e16 to f4340f83b2e5 (12 revisions)
2024-09-20 kjlubick@google.com Delete include/gpu shim files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-20 14:59:18 +00:00
skia-flutter-autoroll
3476a2d5f6 Roll Dart SDK from 4f89df941fbc to 21402561f6d3 (1 revision) (flutter/engine#55317) 
https://dart.googlesource.com/sdk.git/+log/4f89df941fbc..21402561f6d3

2024-09-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-269.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-20 14:09:10 +00:00
skia-flutter-autoroll
fd766979a7 Roll Skia from a1d882ec91e2 to c79d632de004 (3 revisions) (flutter/engine#55315) 
https://skia.googlesource.com/skia.git/+log/a1d882ec91e2..c79d632de004

2024-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 44b6203c43db to b682d8102f5c (12 revisions)
2024-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from a1fe8e600d77 to 20cc91312e16 (19 revisions)
2024-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 104350337eaa to 2f8a3a248b77 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-20 08:13:32 +00:00
skia-flutter-autoroll
dbe6f507a9 Roll Dart SDK from fb78ccd8c565 to 4f89df941fbc (1 revision) (flutter/engine#55311) 
https://dart.googlesource.com/sdk.git/+log/fb78ccd8c565..4f89df941fbc

2024-09-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-268.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-20 02:15:23 +00:00
skia-flutter-autoroll
726a6c6b3f Roll Skia from 9d16a74c860a to ca94a5369af5 (2 revisions) (flutter/engine#55302) 
https://skia.googlesource.com/skia.git/+log/9d16a74c860a..ca94a5369af5

2024-09-19 jlavrova@google.com Reland "Reland "Split FreeType & FontConfig, step #1""
2024-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e80717cdb17e to e4d224c16ab4 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-19 18:12:13 +00:00
skia-flutter-autoroll
4e6fc48df8 Roll Dart SDK from 6c85a403add7 to fb78ccd8c565 (1 revision) (flutter/engine#55303) 
https://dart.googlesource.com/sdk.git/+log/6c85a403add7..fb78ccd8c565

2024-09-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-267.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-19 18:06:55 +00:00
skia-flutter-autoroll
399b42acb6 Roll Skia from 8a2f85d16b94 to 5e9aa3211d90 (4 revisions) (flutter/engine#55299) 
https://skia.googlesource.com/skia.git/+log/8a2f85d16b94..5e9aa3211d90

2024-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 7bdd5f775df1 to 44b6203c43db (2 revisions)
2024-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e39719a1c0e7 to 104350337eaa (7 revisions)
2024-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d3e90db0af37 to a1fe8e600d77 (6 revisions)
2024-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 494b2918371c to e80717cdb17e (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-19 08:29:23 +00:00
skia-flutter-autoroll
278b9a4b84 Roll Skia from 8858f081d1e1 to 8a2f85d16b94 (1 revision) (flutter/engine#55294) 
https://skia.googlesource.com/skia.git/+log/8858f081d1e1..8a2f85d16b94

2024-09-19 michaelludwig@google.com [skif] Check for resolve failure/int overflows

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-19 03:26:31 +00:00
skia-flutter-autoroll
b2e4b53ed9 Roll Dart SDK from 379f0145421f to 6c85a403add7 (1 revision) (flutter/engine#55293) 
https://dart.googlesource.com/sdk.git/+log/379f0145421f..6c85a403add7

2024-09-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-266.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-19 02:54:01 +00:00
skia-flutter-autoroll
ee8f54bea4 Roll Skia from a60a52a11763 to 321d7750aa07 (2 revisions) (flutter/engine#55290) 
https://skia.googlesource.com/skia.git/+log/a60a52a11763..321d7750aa07

2024-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 31cb19d6c599 to d3e90db0af37 (16 revisions)
2024-09-18 nicolettep@google.com [graphite] Immutable sampler data appending + processing fixes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-18 23:47:20 +00:00
Callum Moffat
f20fea338e [ios] Update gesture position on every event (flutter/engine#55285) 
Previously, gesture origin position relied on hover events. But iOS 18 screen mirroring feature sends only pan/scale gestures, but doesn't hover. So we need to check the gesture location every time.

Fixes https://github.com/flutter/flutter/issues/153897
 2024-09-18 23:47:18 +00:00
skia-flutter-autoroll
a28fcdfe6b Roll Dart SDK from 9164e2c0e994 to 379f0145421f (1 revision) (flutter/engine#55289) 
https://dart.googlesource.com/sdk.git/+log/9164e2c0e994..379f0145421f

2024-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-265.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-18 22:41:09 +00:00
skia-flutter-autoroll
29a04396d9 Roll Skia from 760e37059fde to a60a52a11763 (2 revisions) (flutter/engine#55287) 
https://skia.googlesource.com/skia.git/+log/760e37059fde..a60a52a11763

2024-09-18 robertphillips@google.com [graphite] Plumb RenderPassDesc more fully through Precompilation system
2024-09-18 danieldilan@google.com Don't use the ImageGeneratorWIC when checking respect for origin.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-18 20:42:26 +00:00
skia-flutter-autoroll
addee06cbe Roll Dart SDK from 84f4d161ed50 to 9164e2c0e994 (1 revision) (flutter/engine#55284) 
https://dart.googlesource.com/sdk.git/+log/84f4d161ed50..9164e2c0e994

2024-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-264.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-18 18:26:34 +00:00
skia-flutter-autoroll
70161df374 Roll Skia from 178a30c1efcc to 760e37059fde (1 revision) (flutter/engine#55281) 
https://skia.googlesource.com/skia.git/+log/178a30c1efcc..760e37059fde

2024-09-18 jvanverth@google.com [graphite] Increase delay before we purge plots in DrawAtlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-18 17:38:51 +00:00
Chinmay Garde
e305ecf97a [Impeller] Expose a single-header C API to Impellers Display-List layer. (flutter/engine#55238) 
This (`impeller.h`) is a versioned, single-header, dependency-free, C API that exposes Display-Lists in almost their entirety.

The anticipated users of this API do not expect ABI or API stability guarantees at this time but those can be added between specific versions as the API matures.

Testing this API can be done via a playgrounds harness. One has been setup with rudimentary tests that will be filled out.

A simple C example (`example.c`) using GLFW with OpenGL ES has been setup. Only OpenGL ES has been exposed at this time but additional backend will be added.

This API is meant to be easy to bind to using automated tools for access in different languages and runtimes. Consequently, the API follows a strict convention for object naming, creating, and reference-counting.

* All typedefs and method names have the “Impeller” prefix.
* Most objects are reference counted. Methods ending with “New” return a new instance of the object with reference count of 1.
* Each object has a “Retain” and “Release” method to modify reference counts.

For instance, with Rust `bindgen`, the following invocation generates usable bindings:

```sh
bindgen impeller.h -o impeller.rs
  --no-layout-tests
  --rustified-enum “Impeller.*”
  --allowlist-item “Impeller.*”
```

It is expected that wrapped over these generated bindings will be written to make the usage more idiomatic. The C API itself is fairly verbose as well.

<img width="1107" alt="Screenshot 2024-09-12 at 2 55 14 PM" src="https://github.com/user-attachments/assets/e1532dba-487e-4af1-9442-1005a8f52d8d">
 2024-09-18 17:02:16 +00:00
skia-flutter-autoroll
e545a006f8 Roll Skia from e60181fbd809 to 178a30c1efcc (1 revision) (flutter/engine#55280) 
https://skia.googlesource.com/skia.git/+log/e60181fbd809..178a30c1efcc

2024-09-18 bungeman@google.com Remove call to SkScalerContextRec::setPaintGamma

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-18 16:18:15 +00:00
skia-flutter-autoroll
604e191471 Roll Dart SDK from b4bfea33ab1d to 84f4d161ed50 (1 revision) (flutter/engine#55279) 
https://dart.googlesource.com/sdk.git/+log/b4bfea33ab1d..84f4d161ed50

2024-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-263.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-18 14:16:20 +00:00
skia-flutter-autoroll
3847e0c904 Roll Dart SDK from 089ef90b6680 to b4bfea33ab1d (1 revision) (flutter/engine#55276) 
https://dart.googlesource.com/sdk.git/+log/089ef90b6680..b4bfea33ab1d

2024-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-262.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-18 10:05:32 +00:00
skia-flutter-autoroll
768f8deafc Roll Skia from 86abf2391374 to ae4e7753fa9b (4 revisions) (flutter/engine#55275) 
https://skia.googlesource.com/skia.git/+log/86abf2391374..ae4e7753fa9b

2024-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1b4d6185c4de to dbdc95515fb0 (13 revisions)
2024-09-18 jvanverth@google.com [graphite] Add updated purge() method to DrawAtlas.
2024-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from df2251eb6f2a to e39719a1c0e7 (10 revisions)
2024-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6a3f737c33c7 to 31cb19d6c599 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-18 08:11:40 +00:00
skia-flutter-autoroll
091658a052 Roll Dart SDK from 50f697183f25 to 089ef90b6680 (1 revision) (flutter/engine#55271) 
https://dart.googlesource.com/sdk.git/+log/50f697183f25..089ef90b6680

2024-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-261.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-18 02:43:39 +00:00
skia-flutter-autoroll
b14a184687 Roll Dart SDK from 84fac36df65a to 50f697183f25 (3 revisions) (flutter/engine#55268) 
https://dart.googlesource.com/sdk.git/+log/84fac36df65a..50f697183f25

2024-09-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-260.0.dev
2024-09-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-259.0.dev
2024-09-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-258.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-17 22:33:11 +00:00
Brandon DeRosier
a2fe41a763 [Flutter GPU] Remove the redundant smoketest. (flutter/engine#55267) 
This is placeholder stuff that I added before the rest of the API to prove that we can call the engine symbols.

Today this is totally redundant as Flutter GPU has a bunch of automated tests which exercise every FFI call.
 2024-09-17 22:24:07 +00:00
gaaclarke
c62d331944 Fixed solid blur style math (flutter/engine#55194) 
fixes https://github.com/flutter/flutter/issues/155075

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-17 22:24:05 +00:00
Brandon DeRosier
806cddf7d3 Remove tinygltf (flutter/engine#55264) 
This is another thing we were only using for Impeller Scene.
 2024-09-17 20:53:22 +00:00
Brandon DeRosier
025f3839d8 Update the Impeller Scene doc (flutter/engine#55265) 
Remove instructions for setting up Impeller Scene, and link to the continued Dart package.
 2024-09-17 20:31:53 +00:00
Brandon DeRosier
759d173073 [Flutter GPU] Add DeviceBuffer.flush & GpuContext.getMinimumUniformByteAlignment. (flutter/engine#53620) 
Part of https://github.com/flutter/flutter/issues/150953.

Provide a way to get the required minimum uniform byte alignment when referencing uniform blocks in a device buffer. Allow the user to explicitly flush DeviceBuffers (necessary for devices without shared memory).
 2024-09-17 20:31:50 +00:00
Brandon DeRosier
54b7424efd Remove scene GLB files (flutter/engine#55263) 
These aren't used anymore now that Impeller Scene has been removed.
 2024-09-17 20:02:02 +00:00
Brandon DeRosier
ea026548ce [Flutter GPU] Add golden test for rendering a triangle. (flutter/engine#55262) 
Resolves https://github.com/flutter/flutter/issues/144640.

New golden:
![flutter_gpu_test_triangle](https://github.com/user-attachments/assets/0b39380e-1aa5-4369-ae5b-a8764d5701cb)
 2024-09-17 20:00:33 +00:00
skia-flutter-autoroll
e2d27fca19 Roll Dart SDK from de4a3d63671c to 84fac36df65a (2 revisions) (flutter/engine#55255) 
https://dart.googlesource.com/sdk.git/+log/de4a3d63671c..84fac36df65a

2024-09-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-257.0.dev
2024-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-256.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-17 17:57:04 +00:00
skia-flutter-autoroll
4405e163f8 Roll Skia from ad08229fd016 to de3717fe550e (5 revisions) (flutter/engine#55261) 
https://skia.googlesource.com/skia.git/+log/ad08229fd016..de3717fe550e

2024-09-17 sharaks@google.com Merge 8 release notes into RELEASE_NOTES.md
2024-09-17 sharaks@google.com Update Skia milestone to 131
2024-09-17 jsimmons@google.com Handle premultiplied alpha in PNG encoding of images using kBGRA_10101010_XR_SkColorType
2024-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f6d9b179eb83 to 1b4d6185c4de (14 revisions)
2024-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 114623e12d3f to eb05ef4cb7a7 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-17 17:34:12 +00:00
Reid Baker
0f03db48fe FlutterViewTest add back part 4 and 5 (flutter/engine#55243) 
- **Add light and dark test back to FlutterView.java**
- **Migrate some but not all usages of Robolectric.setupActivity in FlutterViewTest.java**
- **Remove suppress warnings on tests that no longer need it, update documentation for ones that still need the suppression**
Fixes https://github.com/flutter/flutter/issues/154746 
Partial work on https://github.com/flutter/flutter/issues/133151
 2024-09-17 15:58:59 +00:00
skia-flutter-autoroll
740a3d2179 Roll Skia from 0409718f34c6 to be871a37a154 (1 revision) (flutter/engine#55250) 
https://skia.googlesource.com/skia.git/+log/0409718f34c6..be871a37a154

2024-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 656a4790c599 to df2251eb6f2a (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-17 06:18:24 +00:00
skia-flutter-autoroll
ce2f00fc26 Roll Skia from d78293574d12 to 0409718f34c6 (1 revision) (flutter/engine#55248) 
https://skia.googlesource.com/skia.git/+log/d78293574d12..0409718f34c6

2024-09-17 michaelludwig@google.com [graphite] Bind dstCopy texture in VulkanCommandBuffer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-17 03:34:32 +00:00
Robert Ancell
3443af6a5c Delay the window until the first frame is received from the Flutter engine (flutter/engine#54703) 
Fixes https://github.com/flutter/flutter/issues/151098
 2024-09-17 10:48:43 +12:00
Chinmay Garde
f64f4e4188 [Embedder] Warn when embedders try to enable an unsupported renderer. (flutter/engine#55240) 
Today, only a generic "internal inconsistency" error returned. But custom builds that selectively disable rendering backends may find this error to be too vague.
 2024-09-16 22:29:24 +00:00
Reid Baker
1030f3b153 flutter view add test 2 (flutter/engine#55188) 
- **add test back with no other changes**
- **Add legacy test and setup shadow**
2 and 3 of 5 flutter/flutter/issues/154746

Improved legacy testing by validating a fullscreen and non fullscreen codepaths. 

Added `.git-blame-ignore-revs` because git was failing to give blame values with that file missing. I dont think I added a global config anywhere but adding an empty file should not cause a problem.
 2024-09-16 20:40:19 +00:00
skia-flutter-autoroll
e91b8b8d60 Roll Skia from 87ba10cbfad3 to 68eeaa5e20dc (1 revision) (flutter/engine#55239) 
https://skia.googlesource.com/skia.git/+log/87ba10cbfad3..68eeaa5e20dc

2024-09-16 danieldilan@google.com Make SkImageGeneratorWIC apply encoded origin.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 20:36:11 +00:00
skia-flutter-autoroll
3a89f4d486 Roll Skia from ee5e413fe436 to 87ba10cbfad3 (5 revisions) (flutter/engine#55233) 
https://skia.googlesource.com/skia.git/+log/ee5e413fe436..87ba10cbfad3

2024-09-16 arthursonzogni@chromium.org Reland "MiraclePtr: Fetch partition_alloc."
2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 4a9e92f23d7f to 0417970a971e
2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4a69b8e2bcdd to 114623e12d3f (2 revisions)
2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 20f5d28635bd to 2814735474b8
2024-09-16 ashwinpv@google.com Create Bazel Toolchain for running iOS builds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 18:55:08 +00:00
skia-flutter-autoroll
0d4ad367bd Roll Skia from 3ebf0a14bbdd to ee5e413fe436 (1 revision) (flutter/engine#55229) 
https://skia.googlesource.com/skia.git/+log/3ebf0a14bbdd..ee5e413fe436

2024-09-16 drott@chromium.org [Fontations] Round advances when hinting is requested

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 17:01:05 +00:00
gaaclarke
1b7cc18cfc Added .vscode back to being ignored (flutter/engine#55195) 
https://github.com/flutter/engine/pull/53974 stopped ignoring the
.vscode directory, this created a situation where people's vscode
settings are prone to getting checked in or nuked. I added a specific
exception for the one file we did check in.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-09-16 09:35:56 -07:00
skia-flutter-autoroll
e0fd93ba23 Roll Skia from 80583104076d to 3ebf0a14bbdd (1 revision) (flutter/engine#55228) 
https://skia.googlesource.com/skia.git/+log/80583104076d..3ebf0a14bbdd

2024-09-16 drott@chromium.org [Fontations] Add suffix to comparison tests with none hint mode

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 15:32:37 +00:00
skia-flutter-autoroll
0a1dab16ef Roll Skia from 2d4c662c2cab to efd841820b09 (3 revisions) (flutter/engine#55221) 
https://skia.googlesource.com/skia.git/+log/2d4c662c2cab..efd841820b09

2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3239872f9c5f to 2afc8c97882a (1 revision)
2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ac44b70a9831 to 656a4790c599 (6 revisions)
2024-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 7c4fe83768b1 to 2e8afd5a4962 (16 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-16 06:22:22 +00:00
Robert Ancell
e3f49a5875 Match Windows logic for picking RGB/BGR textures. (flutter/engine#55121) 
The existing code had a lot of additional checks that didn't seem to
need to be there.

BGR could be passed back to Flutter, but this was never used in creating
the texture.

There has been a report of a Flutter app on Linux with swapped red and
blue color channels, so this seems like it is likely not working on some
drivers.

The original logic was introduced in
87509d8518cea0e90912cc30b08192b1dd4da760
 2024-09-16 12:17:57 +12:00
skia-flutter-autoroll
0c1cae9b0c Roll Dart SDK from c0f7e399ff4a to de4a3d63671c (1 revision) (flutter/engine#55199) 
https://dart.googlesource.com/sdk.git/+log/c0f7e399ff4a..de4a3d63671c

2024-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-255.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-14 05:49:23 +00:00
Brandon DeRosier
07fce2f8f4 [Impeller] desktop: Add missing dispatch for TextFrameDispatcher in embedder view. (flutter/engine#55197) 2024-09-13 22:34:55 -07:00
Jenn Magder
8706638baf Add xcprivacy privacy manifest to macOS framework (flutter/engine#55078) 
Create a `PrivacyInfo.xcprivacy` (this name is required) plist and move it to the top-level of the macOS framework bundle.  `NSPrivacyTracking*` and `NSPrivacyCollectedDataTypes` keys are required, but the values are blank.  macOS explicitly does not need the `NSPrivacyAccessedAPITypes` (see more info in https://github.com/flutter/flutter/issues/143381)

You can see on this PR it's copied to the correct path in the framework https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8737163270670636097/+/u/Global_generators/Release-FlutterMacOS.framework/stdout:

```
  adding: FlutterMacOS.xcframework/macos-arm64_x86_64/FlutterMacOS.framework/PrivacyInfo.xcprivacy (deflated 35%)
```

There's no way to test this except to submit a macOS app with this framework to TestFlight.

I can't find a good spot in the engine to validate the structure of the framework output.  I hereby pledge to add a macOS test to the framework post-roll https://github.com/flutter/flutter/pull/155189 ✋ 

iOS framework variant of this PR https://github.com/flutter/engine/pull/48951
Fixes https://github.com/flutter/flutter/issues/131494

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-14 02:44:18 +00:00