firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,118 Commits 1 Branch 0 Tags
Commit Graph

29204 Commits

Author SHA1 Message Date
Gray Mackall
fde6227383 Synthesize remove events on PointerChange.ACTION_UP and PointerChange.ACTION_POINTER_UP (flutter/engine#55157) 
... when the input device type is touch.

Fixes (partially) https://github.com/flutter/flutter/issues/154842 for touch events. Does not fix when using a stylus, that case will require a follow up PR.

Without fix:

https://github.com/user-attachments/assets/10a8ac73-7b27-498b-a76e-0f2cfc3050d7

With fix:

https://github.com/user-attachments/assets/18656f3a-d45a-4b08-9227-cc0abe8c73f7

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-14 01:02:23 +00:00
skia-flutter-autoroll
97078dd53a Roll Dart SDK from 302b6472b849 to c0f7e399ff4a (1 revision) (flutter/engine#55191) 
https://dart.googlesource.com/sdk.git/+log/302b6472b849..c0f7e399ff4a

2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-254.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 22:23:26 +00:00
auto-submit[bot]
86d1435a0d Reverts "[skwasm] Scene builder optimizations for platform view placement (#54949)" (flutter/engine#55193) 
Reverts: flutter/engine#54949
Initiated by: eyebrowsoffire
Reason for reverting: Incorrect golden diffs on engine roll, see https://github.com/flutter/flutter/pull/155181
Original PR Author: eyebrowsoffire

Reviewed By: {harryterkelsen}

This change reverts the following previous change:
This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: https://github.com/flutter/flutter/issues/149863

This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
 2024-09-13 22:21:47 +00:00
Jim Graham
7da9ad1862 Delete VolatilePathTracker in favor of Dispatch tracking (flutter/engine#55125) 
ui.Canvas and ui.SceneBuilder now use the DlPath object directly from the ui.Path object. This results in increased sharing of the wrapper objects which then increases the sharing of both the converted Impeller paths and Skia's volatile flag.

The VolatilePathTracker mechanism is deleted and rather than count the number of frames that a path is stable for, instead we count the number of times it is used for rendering. If a path is used 100 times in a single frame, it will become non-volatile and start being cached almost immediately. The cached Impeller paths are now also tracked for all instances of the same path, rather than for each call site that originated from a DisplayList dispatch.
 2024-09-13 21:49:09 +00:00
skia-flutter-autoroll
d066010b18 Roll Fuchsia Linux SDK from 3YH1DEYJ-s93fHBw5... to -kKh_AYzPh_iEmTxK... (flutter/engine#55190) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 21:47:02 +00:00
skia-flutter-autoroll
efa6ccfc58 Roll Skia from 9877f459399a to bdc5e73cb6c9 (1 revision) (flutter/engine#55189) 
https://skia.googlesource.com/skia.git/+log/9877f459399a..bdc5e73cb6c9

2024-09-13 jvanverth@google.com Revert "Reland "[graphite] Add purge() method to DrawAtlas.""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 21:43:12 +00:00
Jonah Williams
9235fbb695 [impeller] add Android flag for disabling surface control for debugging. (flutter/engine#55185) 
I've found a few instances where Vulkan worked correctly but surface control did not. lets add a debugging flag we can ask folks to try to narrow down the issue.
 2024-09-13 21:39:20 +00:00
skia-flutter-autoroll
ebd65bf755 Roll Skia from a5a6d12b3642 to 9877f459399a (2 revisions) (flutter/engine#55187) 
https://skia.googlesource.com/skia.git/+log/a5a6d12b3642..9877f459399a

2024-09-13 bungeman@google.com Rename our_vulkan_headers use_skia_vulkan_headers
2024-09-13 fmalita@google.com [bazel] Initial dm support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 20:23:23 +00:00
skia-flutter-autoroll
4786f5058f Roll Dart SDK from eb664303c5ff to 302b6472b849 (2 revisions) (flutter/engine#55182) 
https://dart.googlesource.com/sdk.git/+log/eb664303c5ff..302b6472b849

2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-253.0.dev
2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-252.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 18:05:55 +00:00
Jackson Gardner
0cc27b4e22 [skwasm] Scene builder optimizations for platform view placement (flutter/engine#54949) 
This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: https://github.com/flutter/flutter/issues/149863

This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
 2024-09-13 17:55:07 +00:00
Reid Baker
415f89e20a add back test itSendsTextShowPasswordToFrameworkOnAttach with new mock for display metrics (flutter/engine#55110) 
Part 1/5 for re adding tests documented in flutter/flutter/issues/154746

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-09-13 13:45:37 -04:00
skia-flutter-autoroll
bb9035e847 Roll Skia from 7cba76a07795 to a5a6d12b3642 (3 revisions) (flutter/engine#55179) 
https://skia.googlesource.com/skia.git/+log/7cba76a07795..a5a6d12b3642

2024-09-13 drott@chromium.org [Fontations] Activate usage of autohinting
2024-09-13 brianosman@google.com Remove brianosman references from OWNERS and TODO
2024-09-13 michaelludwig@google.com [graphite] Append DawnCommandBuffer's dstCopy intrinsic to BindGroup

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 17:13:55 +00:00
Reid Baker
f6b728f86f Add copyright notices to java test files (flutter/engine#55155) 
Fixes flutter/flutter/issues/155118
 2024-09-13 15:31:52 +00:00
skia-flutter-autoroll
3734302bfe Roll Dart SDK from 6c1e919a85f2 to eb664303c5ff (2 revisions) (flutter/engine#55173) 
https://dart.googlesource.com/sdk.git/+log/6c1e919a85f2..eb664303c5ff

2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-251.0.dev
2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-250.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 10:04:33 +00:00
skia-flutter-autoroll
34e82924a1 Roll Skia from c8a493c589d6 to abb4eeac59c2 (2 revisions) (flutter/engine#55172) 
https://skia.googlesource.com/skia.git/+log/c8a493c589d6..abb4eeac59c2

2024-09-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f0919be383d0 to e90de4b2873f (6 revisions)
2024-09-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from be2b58e20037 to ac44b70a9831 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 08:59:37 +00:00
skia-flutter-autoroll
a50401125b Roll Dart SDK from 23fc7751b8b2 to 6c1e919a85f2 (1 revision) (flutter/engine#55167) 
https://dart.googlesource.com/sdk.git/+log/23fc7751b8b2..6c1e919a85f2

2024-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-249.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-13 03:05:25 +00:00
Matan Lurey
c53db189c1 Remove now unused extra args/opts/env from run_tests.py. (flutter/engine#55164) 
As a result of https://github.com/flutter/flutter/issues/133569, Dart tests all use the standard `dart test` runner _or_ `engine_repo_tools` to find paths.
 2024-09-13 01:22:18 +00:00
Matan Lurey
02d5118165 Remove assert(() {... }) and other unnecessary patterns in dart:ui tests (flutter/engine#55165) 
Closes https://github.com/flutter/flutter/issues/155054, where we
decided this was correct to do.

As a bonus I improved an `assert` message :)
 2024-09-12 17:40:52 -07:00
Robert Ancell
420b1b5d44 Filter out bad locales returned by g_get_language_names (flutter/engine#55091) 
We're seeing issues with and "und" (undefined) locale and exceptions in
applications (see https://github.com/ubuntu/app-center/issues/1659). It
seems the GLib method for getting the language names doesn't clean up
invalid values, so we should do that.
 2024-09-13 11:40:52 +12:00
Matan Lurey
425e6c707d Remove all references to litetest from the engine repo. (flutter/engine#55163) 
Closes https://github.com/flutter/flutter/issues/133569.
 2024-09-12 16:26:25 -07:00
skia-flutter-autoroll
cf2deecf07 Roll Dart SDK from aa27c61f5859 to 23fc7751b8b2 (1 revision) (flutter/engine#55160) 
https://dart.googlesource.com/sdk.git/+log/aa27c61f5859..23fc7751b8b2

2024-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-248.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-12 22:39:55 +00:00
skia-flutter-autoroll
fcd1ed4bcd Roll Skia from bcbc3038a8ad to 515a23f3cbe1 (2 revisions) (flutter/engine#55161) 
https://skia.googlesource.com/skia.git/+log/bcbc3038a8ad..515a23f3cbe1

2024-09-12 lukasza@chromium.org [rust png] Handling interlaced images in `onIncrementalDecode`.
2024-09-12 jvanverth@google.com Reland "[graphite] Add analytic clip support."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-12 22:39:52 +00:00
Brandon DeRosier
16acb8258a Remove Impeller Scene 👋 (flutter/engine#55118) 
Impeller Scene has been fully rewritten as a Dart library for Flutter: https://pub.dev/packages/flutter_scene
 2024-09-12 14:56:08 -07:00
skia-flutter-autoroll
f7e96f81a9 Roll Skia from 26b048c6a53b to bcbc3038a8ad (3 revisions) (flutter/engine#55159) 
https://skia.googlesource.com/skia.git/+log/26b048c6a53b..bcbc3038a8ad

2024-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5a507062e158 to bc0954c735ac (6 revisions)
2024-09-12 bungeman@google.com Use implementation_deps to hide vulkan headers
2024-09-12 bungeman@google.com Add "git_revision:" to bin/fetch-sk desired_version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-12 21:21:27 +00:00
Matan Lurey
ca6c46441e Move zircon_tests from package:litetest to package:async_helper. (flutter/engine#55149) 
The engine has historically used `package:litetest`, a home grown invention that is a wrapper around the Dart SDK.

In https://github.com/flutter/flutter/issues/133569, we've moved over to the heavier weight `package:test`, which has been simplified since first evaluated by the Dart SDK vending the dependencies we need. The last user of `package:litetest` is a single test in the Fuchsia SDK, `zircon_tests`.

This PR migrates the test from `litetest` (which will be deleted) to the Dart SK vendored `async_minittest`. For this simple test case, there is only a 1-line behavioral change (`notEquals(foo)` becomes `!= foo, true`), and it allows us to remove dependencies from the tree.
 2024-09-12 21:10:52 +00:00
Gray Mackall
bc422dfe62 Add a note about re generating Gradle lockfiles (flutter/engine#55150) 
Adds a note that Gradle lockfile generation is necessary when updating the android embedding dependencies bundle.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-12 21:10:49 +00:00
gaaclarke
f9093e1b13 Revert "Update Color to do all calculations with floating point components" (flutter/engine#55153) 
Reverts flutter/engine#54981

This is causing failures in customer tests that need to be updated:
https://github.com/flutter/flutter/pull/155107/checks?check_run_id=30069840819
 2024-09-12 13:01:37 -07:00
Matan Lurey
37f629a23f Migrate more tests from litetest to package:test (flutter/engine#55119) 
Partial work towards https://github.com/flutter/flutter/issues/133569.

Commentary on removal of `assert`-conditionals here: https://github.com/flutter/flutter/issues/155054.
 2024-09-12 19:01:05 +00:00
skia-flutter-autoroll
894273cab7 Roll Skia from acff7f24ddbe to 26b048c6a53b (1 revision) (flutter/engine#55151) 
https://skia.googlesource.com/skia.git/+log/acff7f24ddbe..26b048c6a53b

2024-09-12 kjlubick@google.com Reland "Move SkMSec out of public API"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-12 18:43:21 +00:00
skia-flutter-autoroll
e1f762166b Roll Dart SDK from a438066d634f to aa27c61f5859 (8 revisions) (flutter/engine#55147) 
https://dart.googlesource.com/sdk.git/+log/a438066d634f..aa27c61f5859

2024-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-247.0.dev
2024-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-246.0.dev
2024-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-245.0.dev
2024-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-244.0.dev
2024-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-243.0.dev
2024-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-242.0.dev
2024-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-241.0.dev
2024-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-240.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-12 18:17:50 +00:00
bungeman
f0da23fb69 Update Skia build for Vulkan headers (flutter/engine#55143) 
Skia has its own set of Vulkan headers which Skia Vulkan sources expect
to be compiled against. This internal set of Vulkan headers should not
be seen by any users. Instead, users provide their own set of Vulkan
headers and Skia's public Vk headers will use the user's Vulkan headers
when included in user sources. Unfortunately, this has not been well
enforced and Skia is making changes to ensure that Skia's set of Vulkan
headers does not leak. This change updates Flutter's build of Skia to be
compatible with these Skia changes.

Skia-Change: https://skia-review.googlesource.com/c/skia/+/898139
 2024-09-12 12:51:59 -04:00
skia-flutter-autoroll
2e7368c9fc Roll Skia from 2b40b50ea423 to acff7f24ddbe (1 revision) (flutter/engine#55144) 
https://skia.googlesource.com/skia.git/+log/2b40b50ea423..acff7f24ddbe

2024-09-12 robertphillips@google.com Re-enable PaintParamsKeyTest on all Graphite_Dawn jobs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-12 16:44:20 +00:00
gaaclarke
c7d96a38bc Update Color to do all calculations with floating point components (flutter/engine#54981) 
This transforms the rest of Color to use the floating point parameters.  This will likely break existing tests very subtly.  For example, colors will be slightly different in golden tests if `lerp` was ever used.

issue: https://github.com/flutter/flutter/issues/127855

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-12 16:30:06 +00:00
skia-flutter-autoroll
35223f997d Roll Fuchsia Linux SDK from fKNT8lbGh8JzxjE6m... to 3YH1DEYJ-s93fHBw5... (flutter/engine#55142) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-12 16:24:05 +00:00
Matan Lurey
5aee88abfb Migrate const_finder_test to use package:test (flutter/engine#55132) 
... instead of some home-grown framework.

This is the last test in the engine that uses custom command line arguments to start. As of this PR, `dart test` including full debugging in an IDE works across all Dart tooling code.

I tried to make this idiomatic as much as possible without changing the logic.
 2024-09-12 15:30:33 +00:00
Jonah Williams
82224f9b11 [engine] make UI thread the platform thread for Android. Still allows opt out as g3 escape hatch. (flutter/engine#55111) 
Part of  https://github.com/flutter/flutter/issues/150525
 2024-09-12 15:21:19 +00:00
skia-flutter-autoroll
cd917d0e0f Roll Skia from b750cbedc114 to 2b40b50ea423 (1 revision) (flutter/engine#55141) 
https://skia.googlesource.com/skia.git/+log/b750cbedc114..2b40b50ea423

2024-09-12 jamesgk@google.com [ganesh] Avoid int overflow in DrawAtlasOpImpl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-12 15:19:53 +00:00
bungeman
2289895234 Ensure Vulkan when including Skia Vulkan headers (flutter/engine#55126) 
Skia is changing how it handles its internal copy of Vulkan headers to
prevent them from accidentally leaking to users and potentially
overriding the user's Vulkan headers. Users of Skia are responsible for
providing the Vulkan headers when including Skia's public Vk headers.
This change only includes Skia's public Vk headers when Flutter is
providing the Vulkan headers.
 2024-09-12 08:55:07 -04:00
Martin Kustermann
f469f967d8 [dart2wasm] Move web wasm embedder to new dart2wasm embedder API (flutter/engine#55037) 
This removes usages of the deprecated top-level `instantiate` and
`invoke` methods and replaces it by method calls to the embedder
objects.

See [0] for the change that introduce this embedder API.

[0] https://dart-review.googlesource.com/c/sdk/+/383242/6
 2024-09-12 14:27:05 +02:00
skia-flutter-autoroll
ac9e5a3fbf Roll Skia from e32486ebf787 to 1dd44e41b08c (4 revisions) (flutter/engine#55131) 
https://skia.googlesource.com/skia.git/+log/e32486ebf787..1dd44e41b08c

2024-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 5354a104db7a to be2b58e20037 (9 revisions)
2024-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 611fbcfa6d73 to 2f71cb364e4e (4 revisions)
2024-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 501887159116 to 1a5fee1063fc (18 revisions)
2024-09-11 jvanverth@google.com Revert "[graphite] Do a compact() step when we purge DrawAtlases."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-12 06:36:35 +00:00
Jim Graham
bc69788f05 [DisplayList] DlPath object provides auto-conversion from Skia to Impeller (flutter/engine#55055) 
Switch from using the clumsy manual CacheablePath object to a more automatic DlPath object for holding paths in DisplayLists and dispatching them to either Skia or Impeller with auto-conversion.

For now DlPath is just a wrapper around SkPath with an auto-generating Impeller Path object which is very similar in design from what was done with the CacheablePath object except that it manages the caching of the Impeller path internally without extra burden on Impeller or Skia. There is also no need to communicate with the Dispatch method as to which type of path you prefer, they're all "auto-converting" DlPath objects now.

For now, ui.Path still generates an SkPath and so we wrap it when we record it into a DisplayList, just like the former CacheablePath mechanism. It will be a simple conversion to create the DlPath wrapper in ui.Path, though, so as to maintain the cached Impeller paths across frames even if the DisplayList itself is not preserved.

Eventually DlPath will take on more of a role of hiding the construction and internal representation of the paths so that we could be using SkPath, impeller::Path, or some other internal storage. For now, SkPath will likely remain primary storage for a while so that we can deal with PathOps.
 2024-09-12 01:20:59 +00:00
Matan Lurey
bc84a70c7f Move most of the dart:ui tests to package:test. (flutter/engine#55090) 
Work towards https://github.com/flutter/flutter/issues/133569.

There are a couple with custom matchers I'd like to migrate in a follow-up PR.
 2024-09-11 23:46:07 +00:00
skia-flutter-autoroll
ef2f7a6a4c Roll Skia from c050337724c8 to 0b776ce0b8d6 (3 revisions) (flutter/engine#55112) 
https://skia.googlesource.com/skia.git/+log/c050337724c8..0b776ce0b8d6

2024-09-11 jmbetancourt@google.com consolidate runtime effect builder logic to base class
2024-09-11 michaelludwig@google.com [graphite] Bind dst copy texture automatically in MtlCommandBuffer
2024-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 49bb428cd451 to 6526c75bbc69 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-11 22:11:15 +00:00
Robert Ancell
2a10ec7c44 Fix crash quitting application due to iterating over a changing list. (flutter/engine#55062) 
Detected as the FlPlatformHandlerTest.ExitApplicationDispose was
crashing sometimes, valgrind showed invalid memory access.
 2024-09-12 09:40:45 +12:00
Robert Ancell
a89c2ae2a4 Use a signal for the pre-engine restart event (flutter/engine#55063) 
With multiple FlViews a callback doesn't scale.
 2024-09-12 09:25:52 +12:00
Gray Mackall
7a06558bd9 Replace System.loadLibrary with ReLinker.loadLibrary() in FlutterJNI.loadLibrary() (flutter/engine#55095) 
Could fix? https://github.com/flutter/flutter/issues/83596

The communication on https://issuetracker.google.com/issues/346717090#comment2 recommends using [ReLinker](https://github.com/KeepSafe/ReLinker) to avoid a bug in how library loading interacts with the [Play delivery feature](https://developer.android.com/guide/playcore/feature-delivery) (used in turn by Flutter's deferred components).

The ReLinker docs also suggest that if you have `minSdk` less than `23`, then you should be using ReLinker regardless, as `System.loadLibrary` is unreliable for other reasons.

I don't have any strong evidence to suggest that either one of these two root causes is the definitive cause of https://github.com/flutter/flutter/issues/83596, but it probably wouldn't hurt 🤷 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-11 21:05:52 +00:00
skia-flutter-autoroll
5589e2cba3 Roll Skia from fb0b2eb61b65 to c050337724c8 (5 revisions) (flutter/engine#55109) 
https://skia.googlesource.com/skia.git/+log/fb0b2eb61b65..c050337724c8

2024-09-11 nicolettep@google.com [graphite] Follow-up alignment fixes
2024-09-11 nicolettep@google.com [graphite] Align parameter name with updated utility
2024-09-11 kjlubick@google.com Speculative workaround for Bazel 7 and rules_docker issue on Louhi
2024-09-11 kjlubick@google.com Remove Bazel option for trivial ABI
2024-09-11 drott@chromium.org [Fontations-backend] Roll Fontations, Skrifa to 0.22

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-11 20:22:54 +00:00
Jenn Magder
b8bb6eff6b Zip and upload Xcode xcresults on scenario test failure (flutter/engine#55093) 
The `FLUTTER_ENGINE` has a `/` in it: `ci/ios_debug_unopt_sim`.  
```
path.join(storePath, '$iosEngineVariant.zip');
```
was resolving to `path_to_output/ci/ios_debug_unopt_sim.zip`.  `path_to_output` existed, but the `ci` directory didn't:

> zip error: Could not create output file (/Volumes/Work/s/w/ir/x/w/rc/flutter_logs_dir/ci/ios_debug_unopt_sim.zip)

Change the output zip path to `path_to_output/ci_ios_debug_unopt_sim.zip` with an underscore instead.

Fixes https://github.com/flutter/flutter/issues/154956

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-11 20:06:32 +00:00
Jonah Williams
a2faed00c7 [Impeller] hash less text stuff per frame for text rendering. (flutter/engine#55060) 
The Glyph color and stroke property are only required for stroked text or COLR text, in all other cases its a no-op. We can do the text hashing faster if we let these properties be optional.

~Also as an experiment switches to absl containers which should be more reasonably performant than std containers.~ required more changes, will try again later
 2024-09-11 18:14:05 +00:00
skia-flutter-autoroll
dd277de7d9 Roll Skia from 44b4a40178cc to fb0b2eb61b65 (1 revision) (flutter/engine#55104) 
https://skia.googlesource.com/skia.git/+log/44b4a40178cc..fb0b2eb61b65

2024-09-11 michaelludwig@google.com [graphite] SamplerDesc constructor is constexpr, has overloads

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,bwils@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-11 16:06:17 +00:00