skia-flutter-autoroll
a7d194933a
Roll Skia from 84e4a69da303 to 505fb55cd044 (1 revision) ( flutter/engine#54819 )
...
https://skia.googlesource.com/skia.git/+log/84e4a69da303..505fb55cd044
2024-08-27 lukasza@chromium.org [rust png] Reuse `png_select_xform_format` from `SkPngRustCodec`.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-28 00:21:25 +00:00
Jonah Williams
2e9cebebe1
[Impeller] Increase host buffer arena count to 4. ( flutter/engine#54808 )
...
It seems like on some ANdroid devices we can actually get 4 pending frames even with the 3 frame wait. I thought about this a lot but too hard. Lets bump it up one.
Also minor comment fixes in ahb swapchain.
2024-08-27 23:35:07 +00:00
Jim Graham
9f7b86f75a
Synchronize accounting for render op depths ( flutter/engine#54794 )
...
Experimental Canvas was getting depth assertion errors while trying to use the depth values supplied by DisplayList. This was mainly due to a difference in understanding as to how many depth values to allocate to a drawImageNine operation.
n case there are additional discrepancies, debugging code is added to assert the understanding of how many depth values the experimental canvas uses on each rendering operation. The depth debugging can be turned on and off with a #define
2024-08-27 23:31:00 +00:00
Gray Mackall
b01bfc77e5
Fix broken links in docs/ ( flutter/engine#54815 )
...
Fixes some links that were broken as a part of https://github.com/flutter/engine/pull/53595 , because it was pointed out on discord
Specifically, replaces `../../` with `https://github.com/flutter/flutter/blob/master/docs/ ` in the places that `grep` surfaced it.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-27 23:14:04 +00:00
Chinmay Garde
8856d9840c
[Impeller] Don't override user specification on Vulkan validation in unopt. ( flutter/engine#54816 )
...
This overrides the documented behavior silently but only in unopt. Make opt and unopt modes behave the same. Disabling validation is frequently necessary to test behavior on simulators or when connecting to Renderdoc.
2024-08-27 23:04:17 +00:00
skia-flutter-autoroll
17cb4979af
Manual roll Dart SDK from b81b344a194f to 8334290a421b (12 revisions) ( flutter/engine#54813 )
...
Manual roll requested by asiva@google.com
https://dart.googlesource.com/sdk.git/+log/b81b344a194f..8334290a421b
2024-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-187.0.dev
2024-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-186.0.dev
2024-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-185.0.dev
2024-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-184.0.dev
2024-08-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-183.0.dev
2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-182.0.dev
2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-181.0.dev
2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-180.0.dev
2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-179.0.dev
2024-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-178.0.dev
2024-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-177.0.dev
2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-176.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com ,dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 22:45:08 +00:00
skia-flutter-autoroll
d24ac985b1
Roll Skia from 77017d30a455 to 84e4a69da303 (3 revisions) ( flutter/engine#54812 )
...
https://skia.googlesource.com/skia.git/+log/77017d30a455..84e4a69da303
2024-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from bd38c7e8de61 to cbe956ba1c0b
2024-08-27 lukasza@chromium.org [rust png] Create `ICCProfile` from `cHRM`, `gAMA`, `iCCP`, `sRGB`.
2024-08-27 kjlubick@google.com Fix IWYU on some Ganesh ops headers
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 22:45:05 +00:00
Chinmay Garde
476ac3393b
[Impeller] Clarify where to put the metadata in the manifest. ( flutter/engine#54814 )
...
I made the mistake of putting it under the activity tag and was surprised it didn't hold.
2024-08-27 22:45:04 +00:00
Chinmay Garde
d66cb0fb29
[Impeller] Use infinite swapchain present timeouts to avoid logspam. ( flutter/engine#54810 )
...
The initial timeout of 1 second was chosen to model the Metal backend where the [default drawable timeout is the same](https://developer.apple.com/documentation/quartzcore/cametallayer/2887086-allowsnextdrawabletimeout?language=objc ).
2024-08-27 21:42:44 +00:00
skia-flutter-autoroll
fd4475bf10
Roll Skia from 2e1eea538014 to 77017d30a455 (2 revisions) ( flutter/engine#54809 )
...
https://skia.googlesource.com/skia.git/+log/2e1eea538014..77017d30a455
2024-08-27 brianosman@google.com Avoid potential overflow when allocating 3D mask from emboss filter
2024-08-27 bungeman@google.com Reland "[pdf] Emit bare CFF instead of OpenType CFF"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 20:32:16 +00:00
skia-flutter-autoroll
1996910320
Roll Skia from a2e2eb292492 to 2e1eea538014 (4 revisions) ( flutter/engine#54806 )
...
https://skia.googlesource.com/skia.git/+log/a2e2eb292492..2e1eea538014
2024-08-27 luisgrimaldo@me.com fixes custom iOS simulator version builds
2024-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7efe15073686 to 3546344d39d2 (1 revision)
2024-08-27 kjlubick@google.com Fix src/gpu/vk target
2024-08-27 jvanverth@google.com Reland "[graphite] Clean out unused Plot backing stores when purging DrawAtlas."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 18:53:50 +00:00
skia-flutter-autoroll
ce765b0e28
Roll Skia from 7d9054c4317d to a2e2eb292492 (2 revisions) ( flutter/engine#54804 )
...
https://skia.googlesource.com/skia.git/+log/7d9054c4317d..a2e2eb292492
2024-08-27 kjlubick@google.com Move and rename GR_MAKE_BITFIELD_CLASS_OPS
2024-08-27 robertphillips@google.com [graphite] Add RenderPassProperties SkSpan to Precompile API
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 15:55:27 +00:00
skia-flutter-autoroll
0b33d88bcd
Roll Fuchsia Linux SDK from QqRZlA9wVbeg4WoPz... to BCqzoTS_Sz6-AaSii... ( flutter/engine#54802 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 13:57:23 +00:00
Robert Ancell
3fc9ab6c1a
Store a set of layers per view. ( flutter/engine#54793 )
...
This means when rendering the correct layers are rendered for a view.
2024-08-27 20:28:05 +12:00
skia-flutter-autoroll
1819a10a97
Roll Skia from 56b353d1674a to 9460a3136627 (2 revisions) ( flutter/engine#54798 )
...
https://skia.googlesource.com/skia.git/+log/56b353d1674a..9460a3136627
2024-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1e4466d51783 to b53c019191d9 (8 revisions)
2024-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from dc27069e5d04 to 3c4bdf66d81d (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-27 07:24:23 +00:00
dependabot[bot]
754ff458f0
Bump google/osv-scanner-action from 1.8.3 to 1.8.4 ( flutter/engine#54797 )
...
Bumps [google/osv-scanner-action](https://github.com/google/osv-scanner-action ) from 1.8.3 to 1.8.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/osv-scanner-action/releases ">google/osv-scanner-action's releases</a>.</em></p>
<blockquote>
<h2>v1.8.4</h2>
<p>Bump OSV-Scanner version <a href="https://github.com/google/osv-scanner/releases/tag/v1.8.4 ">https://github.com/google/osv-scanner/releases/tag/v1.8.4 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="678a866dcbhttps://redirect.github.com/google/osv-scanner-action/issues/39 ">#39</a> from google/update-to-v1.8.4</li>
<li><a href="6a315dbacc712a57b5f0fa6b699964b756d11dcfhttps://redirect.github.com/google/osv-scanner-action/issues/30 ">#30</a> from google/update-script</li>
<li><a href="c63eeb74bcdd8ff8fe0e336764a25ahttps://redirect.github.com/google/osv-scanner-action/issues/38 ">#38</a> from google/renovate_ignore</li>
<li><a href="ff89c5797112abe438b3https://github.com/google/osv-scanner-action/compare/v1.8.3...v1.8.4 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-08-27 06:28:22 +00:00
Robert Ancell
4b992b898f
Use TRUE/FALSE consistently for gboolean values. ( flutter/engine#54768 )
...
Some code was using stbool true/false - use the gboolean values
consistently.
2024-08-27 15:43:13 +12:00
skia-flutter-autoroll
b48f2d30d3
Roll Skia from 50378c58b60c to c9f157b2cc4c (2 revisions) ( flutter/engine#54790 )
...
https://skia.googlesource.com/skia.git/+log/50378c58b60c..c9f157b2cc4c
2024-08-26 lukasza@chromium.org Reapply "[rust png] Extract minimal `SkPngCodecBase`."
2024-08-26 kjlubick@google.com Add shims for include/gpu/d3d, gl, mock, and vk headers
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-26 23:16:23 +00:00
Jim Graham
7f2d3e0cf5
Disable impeller cmake test until it is fixed ( flutter/engine#54788 )
...
This task is consistently failing (with 3 retries for every engine commit). There is an issue to fix the problem, but until that issue is addressed, the task is primarily wasting CI resources.
2024-08-26 23:08:06 +00:00
Chris Bracken
40ce12e1e1
macOS: Add @available check at macOS 12 workaround ( flutter/engine#54784 )
...
Use default mouse event handling behaviour on macOS 13.3.1 onwards. This has two positive effects:
* Avoids the workaround on newer macOS versions where it's unnecessary, thereby giving us confidence that the underlying AppKit issue is fixed and the whole method can later be removed.
* Will be caught by tooling when we drop support for versions of macOS prior to the fixed version.
Issue: https://github.com/flutter/flutter/issues/154063
Issue: https://github.com/flutter/flutter/issues/115015
No tests modified since there is no semantic change, either on versions of macOS where the issue is fixed (and thus the default event handler is correct) or on versions where it is not (and we still use the workaround).
Re-tested manually with the reduced transparency setting on macOS 14.6.1.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-26 22:04:24 +00:00
skia-flutter-autoroll
bd0e73d5b0
Roll Skia from a05dbd2a60f0 to 50378c58b60c (7 revisions) ( flutter/engine#54789 )
...
https://skia.googlesource.com/skia.git/+log/a05dbd2a60f0..50378c58b60c
2024-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 1e4466d51783 to b53c019191d9
2024-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from eba2fc680652 to 345313f563b8
2024-08-26 fmalita@google.com [bazel] Use platform fontmgrs in font_tool_utils
2024-08-26 michaelludwig@google.com [graphite] Split up universal blend shader snippet
2024-08-26 robertphillips@google.com [graphite] Remove static initializer in MtlCaps
2024-08-26 michaelludwig@google.com [ganesh] Fix signature of GrGLMemoryBarrierFn
2024-08-26 bungeman@google.com [pdf] Avoid known image/profile channel mismatch
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-26 21:56:05 +00:00
Chris Bracken
556b4ffc9c
macOS: Do not archive/upload FlutterMacOS.dSYM to cloud ( flutter/engine#54787 )
...
As of the following patches, we now bundle FlutterMacOS.framework.dSYM as part of FlutterMacOS.xcframework. The dSYM is automatically copied into the release build products directory, and bundled in the .xcarchive produced by Xcode's *Product > Archive* feature which produces bundles for upload to the App Store.
* https://github.com/flutter/engine/pull/54696
* https://github.com/flutter/flutter/pull/153975
The .dSYM bundle is now available both in the uploaded .xcarchive and in the xcframework in Flutter's internal artifact cache. For developers with CI toolchains that do additional manual handling or local archiving of .dSYMs, the dSYMs no longer need to be downloaded from cloud storage as previously detailed in `docs/Crashes.md`, but can instead be copied up from the appropriate dSYM subdirectory in the framework cache:
* `flutter/bin/cache/artifacts/engine/darwin-x64-release/FlutterMacOS.xcframework`
Also adds documentation for crash symbolication on macOS.
Issue: https://github.com/flutter/flutter/issues/153879
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-26 21:35:06 +00:00
Jonah Williams
7f1c113985
[Impeller] fix incorrect origins for mesh gradient computation. ( flutter/engine#54762 )
...
Fixes https://github.com/flutter/flutter/issues/153964
Changing the origin of the rect used to render a shader could break shaders that expect to render at particular coordinates based on the input vertices. The snapshot functionality correctly handles translating a texture, so the translation was never necessary to begin with.
2024-08-26 21:19:40 +00:00
Matan Lurey
d54ae5d4e3
Change the ci/analyze.sh script to analyze _all_ of the engine ( flutter/engine#54779 )
...
Closes https://github.com/flutter/flutter/issues/152636 .
As of this PR, we no longer cherry-pick specific directories to run `dart analyze` on.
A few trailing errors across the repo had to be fixed in this PR.
2024-08-26 20:35:08 +00:00
Lukasz Anforowicz
324705f6cb
Use GNI group instead of hardcoding PNG codecs source files. ( flutter/engine#54781 )
...
Fixes https://issues.skia.org/issues/362267329 . The indirection
introduced by this PR insulates Flutter from source-file-list changes in
Skia. See the linked bug for more details.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-26 16:06:13 -04:00
hellohuanlin
146e133c05
[ios] Fix text input edit rotor accessibility ( flutter/engine#54351 )
...
Fixes text input edit rotor accessibility missing edit actions.
It also fixes a few edit items that is displayed where it's not supposed to. (e.g. displaying select item while nothing to select).
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/151029
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-26 19:53:43 +00:00
Zachary Anderson
8c3652a74c
Ensure orchestrators aren't assigned to 32 core machines ( flutter/engine#54754 )
...
https://github.com/flutter/engine/pull/54747 worked, so I'm going to
apply that change to all builders on main, and then we can CP it into
the release branches.
For https://github.com/flutter/flutter/issues/152186
2024-08-26 12:53:29 -07:00
Jim Graham
c486a88876
Revert dart to b81b344a194f ( flutter/engine#54782 )
...
A recent Dart SDK change causes some customer repos tested in the framework to get "uninitialized field" errors. Backing off the SDK to before this happened so we can get the repos fixed.
2024-08-26 19:22:04 +00:00
Yegor
dce257d97f
[web] set the "dialog" ARIA role unconditionally ( flutter/engine#54761 )
...
Previously the "dialog" ARIA role was only set if the route or any of its descendants had the `namesRoute` flag. This PR sets the ARIA role unconditionally. Although it's always a good idea to have a label on the route, a missing label doesn't change the fact that the route is a route, so the ARIA role should still be set.
Fixes https://github.com/flutter/flutter/issues/153791
2024-08-26 18:36:32 +00:00
Jenn Magder
374cc27f5e
Revert "Test running the macOS engine has no stray logging" ( flutter/engine#54778 )
...
This reverts commit 7e82588c317d56a1fd106efe9e5fa840ff805442.
Revert https://github.com/flutter/engine/pull/54716 . This new check is flaking and isn't very high-value.
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8738562907128595441/+/u/test:_Host_Tests_for_host_profile/stdout
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-26 17:57:14 +00:00
Chris Bracken
d49826f5d2
clangd_check: write .clangd as part of test ( flutter/engine#54766 )
...
This eliminates the checked-in `.clangd` file at the root of the engine repository, which gets picked up by editors that rely on `clangd`. In particular, the `Remove: [-m*, -f*]` is problematic for iOS/macOS embedder developers since it removes the `-fobjc-arc` flag, which causes `clangd` to emit errors when using ARC features. Example:
Cannot create __weak reference in file using manual reference counting
This removes the checked-in file, and instead writes the file before running the test, then cleans it up afterwards. Unfortunately, `clangd` does not appear to have a mechanism to point to a config file elsewhere and run as though it were present in a specified directory.
Fixes: https://github.com/flutter/flutter/issues/154064
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-26 17:16:20 +00:00
skia-flutter-autoroll
f9bc640393
Roll Dart SDK from c7eb3230248a to 94c21ec02e28 (2 revisions) ( flutter/engine#54776 )
...
https://dart.googlesource.com/sdk.git/+log/c7eb3230248a..94c21ec02e28
2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-180.0.dev
2024-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-179.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-26 17:00:14 +00:00
chunhtai
47bc9a3abb
[Android] Drops semantics query when app is not attached ( flutter/engine#52040 )
...
Is seems automatic test may send a11y query before the engine is attached. Add a guard to guard against it.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-26 16:37:05 +00:00
Jonah Williams
c88eb87bd5
[ui] fix missing color conversion in drawAtlas. ( flutter/engine#54750 )
...
Ensure that int32 ui colors are correctly converted to Dl Colors (convert instead of reinterpret cast).
2024-08-26 16:28:21 +00:00
skia-flutter-autoroll
1e20113fe4
Roll Skia from ce0656c1d79c to a05dbd2a60f0 (3 revisions) ( flutter/engine#54774 )
...
https://skia.googlesource.com/skia.git/+log/ce0656c1d79c..a05dbd2a60f0
2024-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b1ee6973bca0 to 38174d6926f6 (1 revision)
2024-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 387d930f2e5e to 1e4466d51783 (4 revisions)
2024-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3f25662c1140 to b4c5e1b2a8d9 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,egdaniel@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-26 15:16:24 +00:00
skia-flutter-autoroll
3f21a1e6b5
Roll Fuchsia Linux SDK from CVnRW3RAZuTq0lVaw... to QqRZlA9wVbeg4WoPz... ( flutter/engine#54770 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-26 12:43:37 +00:00
Jonah Williams
5cfb3bbf9d
[Impeller] delete impeller image class. ( flutter/engine#54767 )
...
This class does nothing but wrap impeller::Texture. Lets just use impeller::Texture.
2024-08-26 00:20:32 +00:00
Jonah Williams
85442ec532
[Impeller] more test migration. ( flutter/engine#54763 )
...
Move more aiks tests to DL
Part of https://github.com/flutter/flutter/issues/142054
2024-08-25 21:49:53 +00:00
Chris Bracken
b105e9b1cd
[macOS] Add TODOs to remove AppKit bug workaround ( flutter/engine#54764 )
...
In https://github.com/flutter/engine/pull/40241 , I added a workaround for an AppKit bug wherein mouseDown/Up events were ignored when the *Reduced Transparency* accessibility setting was enabled, and the view was hosted in an `NSPopover`.
I filed a Radar and Apple reported the bug fixed in macOS 13.3.1.
When we drop support for macOS 12 in Flutter, we should remove the workaround.
So long as nothing else has been added to these methods at that time, the method overrides themselves should be removed, so that we fall back to the default behaviour.
See: http://www.openradar.me/FB12050037
See: https://developer.apple.com/documentation/appkit/nsresponder/1535349-mouseup
Issue: https://github.com/flutter/flutter/issues/154063
Issue: https://github.com/flutter/flutter/issues/115015
No tests modified since this only adds a comment.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-25 15:00:36 +00:00
skia-flutter-autoroll
b5e7036a72
Roll Fuchsia Linux SDK from 5uR6WvDV5FX-aZgKQ... to CVnRW3RAZuTq0lVaw... ( flutter/engine#54765 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-25 11:26:14 +00:00
skia-flutter-autoroll
b0e5d82f86
Roll Fuchsia Linux SDK from 0d2McFgsNwG-5r1Rb... to 5uR6WvDV5FX-aZgKQ... ( flutter/engine#54757 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-24 10:10:07 +00:00
skia-flutter-autoroll
5a039fcc0e
Roll Dart SDK from 586ba94c96a4 to c7eb3230248a (2 revisions) ( flutter/engine#54755 )
...
https://dart.googlesource.com/sdk.git/+log/586ba94c96a4..c7eb3230248a
2024-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-178.0.dev
2024-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-177.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-24 06:06:15 +00:00
skia-flutter-autoroll
a422eed480
Roll Skia from 0086a17e0d4c to 741972846fa2 (3 revisions) ( flutter/engine#54753 )
...
https://skia.googlesource.com/skia.git/+log/0086a17e0d4c..741972846fa2
2024-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d95811d4259d to 05f092235902 (4 revisions)
2024-08-23 kjlubick@google.com Remove GR_GL_CUSTOM_SETUP_HEADER
2024-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from c830bf291754 to f96615e73170 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-24 02:59:27 +00:00
skia-flutter-autoroll
80ee1f2ffd
Roll Dart SDK from b81b344a194f to 586ba94c96a4 (1 revision) ( flutter/engine#54752 )
...
https://dart.googlesource.com/sdk.git/+log/b81b344a194f..586ba94c96a4
2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-176.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-24 01:52:18 +00:00
Chris Bracken
e2264d0090
iOS: don't bundle simulator dSYMs in xcframework ( flutter/engine#54746 )
...
While we do produce a simulator slice in our iOS release framework binaries, this is actually an unsupported runtime mode, therefore there is no need to bundle dSYMs for this mode.
This saves roughly 1GB of cached debug info.
Issue: https://github.com/flutter/flutter/issues/116493
Fixes: https://github.com/flutter/flutter/issues/154019
Related issue: https://github.com/flutter/flutter/issues/11754
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-24 00:12:21 +00:00
skia-flutter-autoroll
c555158a02
Roll Dart SDK from ca8ee3f5f266 to b81b344a194f (3 revisions) ( flutter/engine#54738 )
...
https://dart.googlesource.com/sdk.git/+log/ca8ee3f5f266..b81b344a194f
2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-175.0.dev
2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-174.0.dev
2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-173.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-23 18:17:19 +00:00
Jonah Williams
1ba45ac86e
[Engine] Add no op surface ( flutter/engine#54694 )
...
Still needs to be tested in metalless environment. This should probably print out some kind of error message that tells folks that this is WAI, but I'm not sure if that would be too disruptive for g3.
Fixes https://github.com/flutter/flutter/issues/153883
2024-08-23 17:06:16 +00:00
Jonah Williams
c8fc2ff531
[engine] make Platform thread the UI thread for iOS Impeller. ( flutter/engine#54655 )
...
Does it blend?
2024-08-23 17:06:14 +00:00
Mouad Debbar
ff452d94a3
[web] Multi-view support for Skwasm ( flutter/engine#48893 )
...
Support multi-view mode in the Skwasm renderer.
Fixes https://github.com/flutter/flutter/issues/138925
2024-08-23 15:20:07 +00:00
skia-flutter-autoroll
25772c447e
Roll Dart SDK from f9e6abb21ac7 to ca8ee3f5f266 (1 revision) ( flutter/engine#54734 )
...
https://dart.googlesource.com/sdk.git/+log/f9e6abb21ac7..ca8ee3f5f266
2024-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-172.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-23 11:00:09 +00:00
