firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,118 Commits 1 Branch 0 Tags
Commit Graph

29204 Commits

Author SHA1 Message Date
gaaclarke
a6c6c50a25 Changes DlColor to support wide gamut colors (#54473) (flutter/engine#54648) 
relands https://github.com/flutter/engine/pull/54473
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with https://github.com/flutter/engine/pull/54415 when it lands in https://github.com/flutter/engine/pull/54567.

## Difference from last attempt

1) The default color is now opaque black, not transparent black (not the issue for revert)
1) Updated a test to send in valid numbers when constructing a color and added asserts to avoid those problems in the future.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-20 21:44:24 +00:00
skia-flutter-autoroll
a11c7c0aed Manual roll Dart SDK from c5264a1bd1d2 to 04c57423f90d (13 revisions) (flutter/engine#54649) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/c5264a1bd1d2..04c57423f90d

2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-162.0.dev
2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-161.0.dev
2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-160.0.dev
2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-159.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-158.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-157.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-156.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-155.0.dev
2024-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-154.0.dev
2024-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-153.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-152.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-151.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-150.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 18:44:07 +00:00
skia-flutter-autoroll
0c19856b76 Roll Skia from 6299c5744307 to a8160d808252 (6 revisions) (flutter/engine#54651) 
https://skia.googlesource.com/skia.git/+log/6299c5744307..a8160d808252

2024-08-20 nscobie@google.com [Android] Don't evaluate trace arguments if using ATrace but !ATRACE_ENABLED()
2024-08-20 bungeman@google.com Roll FreeType from 73720c7c to f92c9655 (23 commits)
2024-08-20 robertphillips@google.com Revert "[rust png] Extract minimal `SkPngCodecBase`."
2024-08-20 lukasza@chromium.org [rust png] Extract minimal `SkPngCodecBase`.
2024-08-20 sharaks@google.com Merge 5 release notes into RELEASE_NOTES.md
2024-08-20 sharaks@google.com Update Skia milestone to 130

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 18:42:19 +00:00
yaakovschectman
2f6952657d Use getBoundingRects to add support inset MediaQuery/SafeArea when in freeform mode controls are shown. (flutter/engine#54294) 
Original Title: Add FlutterViewDelegate and BoundingRect methods

Check the bounding rect for caption bar when sending viewport metrics to
Flutter to account for freeform mode. Use the more recent
`getBoundingRects` over `getInsets`.

Tests will need to be kept separate until Robolectric publishes a
version that supports API level 35.
Roboletric tests for this pr will be part of google testing until then. 
Pr for tests here https://critique.corp.google.com/cl/657302386. 

https://github.com/flutter/flutter/issues/146658

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-08-20 13:09:00 -04:00
skia-flutter-autoroll
149b1974f5 Manual roll Dart SDK from c5264a1bd1d2 to c22bf5aedbcf (2 revisions) (flutter/engine#54646) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/c5264a1bd1d2..c22bf5aedbcf

2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-151.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-150.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 16:43:21 +00:00
skia-flutter-autoroll
444b7b801c Roll Skia from d6548fdb78c1 to 6299c5744307 (1 revision) (flutter/engine#54643) 
https://skia.googlesource.com/skia.git/+log/d6548fdb78c1..6299c5744307

2024-08-20 kjlubick@google.com Delete old GLFW interface

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 14:24:24 +00:00
Jim Graham
ef6db0c87e Check return values for Sk[I]Rect::intersect (flutter/engine#54577) 
The `SkRect::intersect` and `SkIRect::intersect` methods return values that must be handled or the calling code might end up with a non-empty answer for non-intersecting rectangles. There were 3 or 4 places in our code that we weren't doing this so now we check them all, in some cases even if we believe that the answer will not be empty.

This is prep work so that Skia can add `[[nodiscard]]` directives to these 2 methods so that nobody else makes that mistake.
 2024-08-20 09:48:20 +00:00
skia-flutter-autoroll
616470db70 Roll Skia from 30a00629e135 to ada9a367c5f2 (4 revisions) (flutter/engine#54640) 
https://skia.googlesource.com/skia.git/+log/30a00629e135..ada9a367c5f2

2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 87111746e4cc to c71e16037f25
2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from da2e5cb8d546 to 87111746e4cc (5 revisions)
2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 65157d32945d to 7216df70d311 (1 revision)
2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from db1fa936ad0a to ae5dd592666e (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 06:52:24 +00:00
skia-flutter-autoroll
54ae1c04d5 Roll Fuchsia Linux SDK from hNxjRSbGnxD3IhdOm... to 3a16kOsyFmJh3lo7e... (flutter/engine#54638) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 04:53:04 +00:00
Srujan Gaddam
d16a9057a0 Update package:js version constraints to ^0.7.0 and update test versions to match (flutter/engine#54629) 
This removes the dependency on `dart:js` and allows that library to be removed from dart2wasm. Also updates `test` dependencies to work with the new `package:js` constraints.
 2024-08-20 02:58:58 +00:00
skia-flutter-autoroll
8f02ca0cbe Roll Skia from e65e02c50d66 to 30a00629e135 (3 revisions) (flutter/engine#54634) 
https://skia.googlesource.com/skia.git/+log/e65e02c50d66..30a00629e135

2024-08-20 brianosman@google.com Reland "Guard division in luminosity blend against overflow"
2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f8f75e8cc154 to b038f07b8faf (3 revisions)
2024-08-19 kschmi@microsoft.com Revert "Revert "Reland "Reduce size of linear SkMaskGamma LUT"""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 02:57:29 +00:00
auto-submit[bot]
8aabbdd12f Reverts "Changes DlColor to support wide gamut colors (#54473)" (flutter/engine#54636) 
Reverts: flutter/engine#54473
Initiated by: jonahwilliams
Reason for reverting: golden diffs like https://flutter-engine-gold.skia.org/detail?grouping=name%3Dimpeller_Play_AiksTest_BlendModeSrcAlphaLuminosity_OpenGLES%26source_type%3Dflutter-engine&digest=107ccd2cd1170746b1ffc4d31184e789 look incorrect, potentially an alpha issue
Original PR Author: gaaclarke

Reviewed By: {flar}

This change reverts the following previous change:
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with https://github.com/flutter/engine/pull/54415 when it lands in https://github.com/flutter/engine/pull/54567.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-20 02:19:47 +00:00
Jonah Williams
d6f4f4a66e [Impeller] account for negative scale in max basis xy. (flutter/engine#54630) 
Otherwise we get funky negative scales that break tessellation.
 2024-08-19 23:27:54 +00:00
gaaclarke
1fde0ad466 Changes DlColor to support wide gamut colors (flutter/engine#54473) 
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with https://github.com/flutter/engine/pull/54415 when it lands in https://github.com/flutter/engine/pull/54567.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-19 23:16:55 +00:00
skia-flutter-autoroll
d96f5fd76b Roll Skia from b6224c9e6611 to e65e02c50d66 (2 revisions) (flutter/engine#54628) 
https://skia.googlesource.com/skia.git/+log/b6224c9e6611..e65e02c50d66

2024-08-19 robertphillips@google.com Revert "GPU support for F16F16F16x SkColorType."
2024-08-19 robertphillips@google.com [graphite] Break DrawTypeFlags::kText into finer grained draw types

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 22:33:06 +00:00
Kevin Moore
28e7d0ec2a web_ui: bump min Dart SDK to 3.6.0-0 (flutter/engine#54626) 
Also removed two unused dev dependencies

Enables usage of `Since` in dart:js_interop
 2024-08-19 22:11:55 +00:00
Chinmay Garde
0ac477bb08 [Impeller] Add a note about Graphite to the FAQ. (flutter/engine#54623) 
Action item from go/impeller-faq-followups.
 2024-08-19 22:07:10 +00:00
Jackson Gardner
5e39c69831 [skwasm] Fix skwasm clip coverage algorithm. (flutter/engine#54572) 
This previously was basically assuming that two clip regions would be a union but instead it's actually an intersection. Also, for some reason I had forgotten to actually implement `boundingRect` for the rrect clip region. I changed this for a bit more clarity.
 2024-08-19 21:45:07 +00:00
skia-flutter-autoroll
f93445acce Roll Skia from 318b7958f748 to b6224c9e6611 (2 revisions) (flutter/engine#54625) 
https://skia.googlesource.com/skia.git/+log/318b7958f748..b6224c9e6611

2024-08-19 danieldilan@google.com GPU support for F16F16F16x SkColorType.
2024-08-19 brianosman@google.com Revert "Guard division in luminosity blend against overflow"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 21:15:15 +00:00
Robert Ancell
2bbc3b4b41 Allow the default background color to be changed (flutter/engine#54575) 
Fixes https://github.com/flutter/flutter/issues/149920
 2024-08-20 08:00:06 +12:00
skia-flutter-autoroll
11288f546d Roll Skia from d528658273db to 318b7958f748 (4 revisions) (flutter/engine#54620) 
https://skia.googlesource.com/skia.git/+log/d528658273db..318b7958f748

2024-08-19 kjlubick@google.com Apply clang-tidy suggestion to graphite files
2024-08-19 bungeman@google.com Add SK_USE_FREETYPE_EMBOLDEN to NativeFonts_FreeType
2024-08-19 danieldilan@google.com CPU support of F16F16F16x SkColorType.
2024-08-19 borenet@google.com [bazel] Fix defines for freetype on Windows

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 19:44:24 +00:00
Chinmay Garde
41c82cd7f9 [Impeller] use paragraphs instead of bullet points in the FAQ. (flutter/engine#54622) 
Fixes https://github.com/flutter/flutter/issues/153316

Other than one question that pointed to outdated links, its just the same as the old FAQ. Will submit the updates based on recent conversations in a followup patch.

It should now be possible to link to specific questions in the FAQ.
 2024-08-19 19:40:15 +00:00
Jonah Williams
8b7101800f [Impeller] finish experimental canvas changes. (flutter/engine#54569) 
Make sure the old dispatcher cannot be used if the new dispatcher is enabled. Migrate tests using old canvas to new canvas, mostly to make deleting the old one easier...
 2024-08-19 19:37:17 +00:00
skia-flutter-autoroll
b5881266a3 Roll Skia from d88bfe2939e8 to d528658273db (9 revisions) (flutter/engine#54619) 
https://skia.googlesource.com/skia.git/+log/d88bfe2939e8..d528658273db

2024-08-19 borenet@google.com [bazel] Fix skshaper build for Windows
2024-08-19 brianosman@google.com Guard division in luminosity blend against overflow
2024-08-19 kjlubick@google.com Remove unused gni file list
2024-08-19 borenet@google.com [bazel] Fix zlib defines for Windows
2024-08-19 borenet@google.com [bazel] Fix global compile options for Windows
2024-08-19 michaelludwig@google.com [ganesh] Fix MeshOp index combination logic
2024-08-19 robertphillips@google.com [graphite] Revise DrawTypeFlags
2024-08-19 michaelludwig@google.com Update $color_burn_component  to single flow of control
2024-08-19 michaelludwig@google.com Reland "Avoid branches and early returns in $color_dodge_component"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 18:09:22 +00:00
Reid Baker
859b18e112 Set download_jdk variable (flutter/engine#54584) 
Follow up from https://github.com/flutter/engine/pull/54450#issuecomment-2282244288
 2024-08-19 15:33:08 +00:00
Kaylee Lubick
b5ac6eafc9 Update gni filegroup when building Skia's codec files (flutter/engine#54588) 
This was added in https://skia-review.googlesource.com/c/skia/+/890319
and Skia plans to delete the old group.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-08-19 07:15:05 -07:00
skia-flutter-autoroll
4b47c0cf23 Roll Skia from 75bd296f9756 to 5274def7cf1f (2 revisions) (flutter/engine#54610) 
https://skia.googlesource.com/skia.git/+log/75bd296f9756..5274def7cf1f

2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from da2e5cb8d546 to db27834aff1f
2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 521d0157ce62 to da2e5cb8d546 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 07:18:38 +00:00
skia-flutter-autoroll
97d9479fd6 Roll Fuchsia Linux SDK from yKkNB9F8Hwnjq2AMW... to hNxjRSbGnxD3IhdOm... (flutter/engine#54608) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 03:30:32 +00:00
skia-flutter-autoroll
85e645fb6b Roll Fuchsia Linux SDK from a3zdjZKduabZSBN0B... to yKkNB9F8Hwnjq2AMW... (flutter/engine#54602) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-18 02:07:23 +00:00
Zachary Anderson
21fdc613b0 Shift linux_fuchsia_tests from staging to prod (flutter/engine#54597) 
Follow up to https://github.com/flutter/engine/pull/54591
 2024-08-16 22:21:26 -07:00
skia-flutter-autoroll
338ea8ebb6 Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-17 00:46:20 +00:00
skia-flutter-autoroll
f39d64edc2 Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595) 
https://skia.googlesource.com/skia.git/+log/219bd1032761..570b18e1afda

2024-08-16 michaelludwig@google.com Revert "Avoid branches and early returns in $color_dodge_component"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,michaelludwig@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-17 00:36:13 +00:00
Chris Bracken
53ded8b97b macOS: Extract framework creation to sky_utils (flutter/engine#54586) 
This refactors `create_mac_framework.py` to extract framework creation to `sky_utils.py`. The only other changes are minor variable renaming and extraction of functions to make the code more readable/easier to work with.

The resulting zip archives have been verified to be identical before and after.

This is refactoring to support embedding dSYM debug information in a follow-up patch.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-17 00:12:13 +00:00
skia-flutter-autoroll
03fefc7ee4 Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592) 
https://skia.googlesource.com/skia.git/+log/fc8769175d35..219bd1032761

2024-08-16 michaelludwig@google.com Avoid branches and early returns in $color_dodge_component
2024-08-16 michaelludwig@google.com Revert "[graphite] Add purge() method to DrawAtlas."
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dad70915c62f to 0ff16cd9feaa (5 revisions)
2024-08-16 briansalomon@gmail.com DropShadow image filters accept float colors and color spaces for the shadow color.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,michaelludwig@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-16 23:17:14 +00:00
Chris Bracken
398d81d82d [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593) 
Most framework tests perform a `flutter precache` or rely on the web SDK in some form. The Web SDK is not build in presubmit by default. As such, developers will need to manually comment out the `runIf` conditional block that prevents the web SDK from being built during presubmit, then later hope they uncomment it before landing their patch.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-16 23:15:13 +00:00
Zachary Anderson
ba0110c34f Move Fuchsia tests to a separate config file (flutter/engine#54591) 
Temporary workaround for https://github.com/flutter/flutter/issues/152186.
 2024-08-16 22:32:05 +00:00
skia-flutter-autoroll
9f1804cd2f Roll Skia from 7c0eeaf12413 to fc8769175d35 (58 revisions) (flutter/engine#54589) 
Roll Skia from 7c0eeaf12413 to fc8769175d35 (58 revisions)

https://skia.googlesource.com/skia.git/+log/7c0eeaf12413..fc8769175d35

2024-08-16 kjlubick@google.com Apply buildifier to modules/audioplayer
2024-08-16 fmalita@google.com [bazel] Add Viewer resources
2024-08-16 bungeman@google.com SkScalerContext implementation specific emboldening
2024-08-16 jvanverth@google.com [graphite] Add purge() method to DrawAtlas.
2024-08-16 brianosman@google.com Revert "[pdf] Emit bare CFF instead of OpenType CFF"
2024-08-16 borenet@google.com Reapply "[bazel] Remove symlinks for external files"
2024-08-16 lukasza@chromium.org Delete `DECODE_PNG_FILES` from `src/codec/BUILD.bazel`
2024-08-16 lukasza@chromium.org Depend only on public PNG headers from `ico_decode` target.
2024-08-16 lukasza@chromium.org Add GNI group for PNG and expand source list
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 97855a7c330f to dad70915c62f (5 revisions)
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2003e06230b1 to 83ca89e58cef (6 revisions)
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2918c4247f20 to 69433722b83b (16 revisions)
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 936d3406908e to 521d0157ce62 (7 revisions)
2024-08-16 jvanverth@google.com [graphite] Make DrawAtlas::compact() more aggressive.
2024-08-16 jvanverth@google.com [graphite] Avoid one ref when dealing with subRunStorage.
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 936d3406908e to 521d0157ce62
2024-08-16 michaelludwig@google.com Revert "[bazel] Remove symlinks for external files"
2024-08-16 michaelludwig@google.com Revert "Reland "Reduce size of linear SkMaskGamma LUT""
2024-08-16 michaelludwig@google.com Simplify Porter-Duff constant blend function
2024-08-15 brianosman@google.com Implement asAColorMode and asAColorMatrix for SkWorkingFormatColorFilter
2024-08-15 borenet@google.com [bazel] Remove symlinks for external files
2024-08-15 kschmi@microsoft.com Reland "Reduce size of linear SkMaskGamma LUT"
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 91058f2297c9 to 97855a7c330f (1 revision)
2024-08-15 lukasza@chromium.org [rust png] Avoiding newtype wrapper for `cxx::UniquePtr<ffi::ReadTrait>`
2024-08-15 lukasza@chromium.org [rust png] Expose `png::Reader` over the FFI boundary.
2024-08-15 fmalita@google.com [bazel] Enable SVG support in Viewer
2024-08-15 robertphillips@google.com Reland "[graphite] Add DawnCaps::extractGraphicsDescs"
2024-08-15 bungeman@google.com [pdf] Emit bare CFF instead of OpenType CFF
2024-08-15 jamesgk@google.com [graphite] Don't run GMs that test automatic image tiling
2024-08-15 geofflang@google.com Reland "Allow client arrays on ANGLE."
2024-08-15 fmalita@google.com [bazel] More viewer slides
2024-08-15 kjlubick@google.com Remove all references to legacy //:skia_public and //:skia_internal
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 087afc919eda to 2003e06230b1 (8 revisions)
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0d313c52316c to 91058f2297c9 (3 revisions)
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 60f8f34ea424 to 936d3406908e (8 revisions)
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 239f9139d016 to 2918c4247f20 (14 revisions)
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 60f8f34ea424 to 936d3406908e
2024-08-14 robertphillips@google.com Revert "[graphite] Add DawnCaps::extractGraphicsDescs"
2024-08-14 robertphillips@google.com Revert "[graphite] Fix static initializer problem wrt Caps Domains"
2024-08-14 robertphillips@google.com [graphite] Fix static initializer problem wrt Caps Domains
2024-08-14 fmalita@google.com [bazel] Enable Skottie support in Viewer
2024-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f084a55f96da to 0d313c52316c (1 revision)
2024-08-14 ccameron@chromium.org Add SkJpegMetadataDecoder::Make that takes SkData
2024-08-14 kjlubick@google.com Enforce IWYU on graphite/geom
2024-08-14 kjlubick@google.com Apply clang-tidy suggestion to UploadTask
2024-08-14 kjlubick@google.com Fix Bazel build of viewer after GPU_TEST_UTILS landed
...
 2024-08-16 21:38:09 +00:00
Michael Ludwig
5c6fc5db0c Remove SkOSLibrary files from build and license scripts (flutter/engine#54583) 
These are no longer under the `src/ports` directory in Skia and are in
`tools/`. But it appears that Flutter does not actually quire them.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-08-16 16:29:13 -04:00
Chris Bracken
7a8fde83b1 iOS: Add dSYM binaries to without_entitlements.txt (flutter/engine#54576) 
In flutter/engine#54414, we added dSYM files for physical and simulator binaries in both regular and extension-safe framework builds, but did not add the dSYMs to the without_entitlements.txt list.

This passed all engine pre/post-submit tests, as well as framework tests, but failed during release code signing in Cocoon in a test here:
d849b14bab/cipd_packages/codesign/lib/src/file_codesign_visitor.dart (L305-L313)

This adds the missing files to `without_entitlements.txt`, which fixes a code-signing error as seen in this build log:
https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20Production%20Engine%20Drone/13590/overview

A corresponding change was landed on the [flutter-3.24-candidate.1](https://github.com/flutter/engine/tree/flutter-3.24-candidate.1) branch:
https://github.com/flutter/engine/pull/54573

The build associated with that patch correctly completed code signing in this build:
https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20engine_release_builder/688/overview

And more specifically, this sub-build:
https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20Production%20Engine%20Drone/13650/overview

And even more specifically, this build step:
https://logs.chromium.org/logs/dart-internal/buildbucket/cr-buildbucket/8739493904842446705/+/u/Global_generators/Codesign__Volumes_Work_s_w_ir_cache_builder_src_out_release_unsigned_artifacts.zip/codesign_Apple_engine_binaries/stdout

Additionally, this patch adds `sky_utils.assert_valid_codesign_config()` which fails the script (and thus the build) with an error message if any file in scope for code signing (i.e. Mach-O binaries) is not listed in the code-signing config (`entitlements.txt`, `without_entitlements.txt`), or any listed file is not found on disk.

Issue: https://github.com/flutter/flutter/issues/116493
Issue: https://github.com/flutter/flutter/issues/153532

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-16 16:27:52 +00:00
Kevin Chisholm
46b12974c4 Manual roll Dart SDK from 44635f897535 to 8c02ad43e01a (3 revisions) (flutter/engine#54581) 
Manual roll requested by [kevinjchisholm@google.com](mailto:kevinjchisholm@google.com)

https://dart.googlesource.com/sdk.git/+log/44635f897535..8c02ad43e01a

2024-08-14 [dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com) Version 3.6.0-149.0.dev
2024-08-13 [dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com) Version 3.6.0-148.0.dev
2024-08-13 [dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com) Version 3.6.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [dart-vm-team@google.com](mailto:dart-vm-team@google.com),[kevinjchisholm@google.com](mailto:kevinjchisholm@google.com),[zra@google.com](mailto:zra@google.com) on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-16 16:26:17 +00:00
auto-submit[bot]
31de779cda Reverts "Manual roll Dart SDK from 44635f897535 to 790fcb755a0a (3 revisions) (#54558)" (flutter/engine#54578) 
Reverts: flutter/engine#54558
Initiated by: itsjustkevin
Reason for reverting: Dart revert was not properly applied.
Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot, zanderso}

This change reverts the following previous change:

Manual roll requested by kevinjchisholm@google.com

https://dart.googlesource.com/sdk.git/+log/44635f897535..790fcb755a0a

2024-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-149.0.dev
2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-148.0.dev
2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,kevinjchisholm@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-16 12:42:47 +00:00
skia-flutter-autoroll
1fd7178a48 Manual roll Dart SDK from 44635f897535 to 790fcb755a0a (3 revisions) (flutter/engine#54558) 
Manual roll requested by kevinjchisholm@google.com

https://dart.googlesource.com/sdk.git/+log/44635f897535..790fcb755a0a

2024-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-149.0.dev
2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-148.0.dev
2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,kevinjchisholm@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-16 01:08:23 +00:00
skia-flutter-autoroll
17cfcca682 Roll Fuchsia Linux SDK from qpfC-GAVZvOwAQU5f... to Z5hq3ZkPNCpZWRQnl... (flutter/engine#54574) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-15 23:34:23 +00:00
Jonah Williams
343fc75076 [Impeller] add support for superellipse. (flutter/engine#54562) 
This is an entity testing only implementation of a superellipse. rectellipse is a special case where degree = 4.

Part of https://github.com/flutter/flutter/issues/139321
 2024-08-15 22:40:58 +00:00
Harry Terkelsen
e0529ddd81 [canvaskit] Improve how overlays are optimized (flutter/engine#54547) 
Enhances the overlay optimization by pushing new pictures to the earliest RenderCanvas they can go into. This improvement is made especially clear in the new test case I added to `embedded_views_test.dart`, with the previous algorithm we would have used an overlay for each platform view even though all of the pictures could go into the base canvas with no issue.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-15 22:23:00 +00:00
Jonah Williams
9c6ec923c9 [Impeller] revert experimental canvas. (flutter/engine#54570) 
Revert due to framework crashes: https://github.com/flutter/flutter/pull/153521
 2024-08-15 21:30:01 +00:00
Oleg Magomedov
e55ebe1d32 Fix typo in AppLifecycleState documentation (flutter/engine#54544) 
Fixes small typo in AppLifecycleState enum documentation. Documentation to enum references iOS article about managing app lifecycle in UIKit. So, "IOKit" is a misspelled word "UIKit"

I found out Apple has [IOKit framework](https://developer.apple.com/documentation/iokit) but it is not related to app lifecycle

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-15 20:27:39 +00:00
John McDole
885d9f1054 Update RBE troubleshooting (flutter/engine#54568) 
Add `could not get valid Application Default Credentials token` troubleshooting
 2024-08-15 19:07:05 +00:00
Jonah Williams
67cc9696a8 [Impeller] Switch from AIKS canvas to DL based canvas implementation. (flutter/engine#53781) 
The first part of switching Impeller/Aiks to using the display list instead of re-recording rendering operations. This should eventually let us cut CPU overhead of the raster thread for complex applications, though it should have no impact on GPU performance.

This does introduce a GLES only rendering bug that I haven't had luck tracking down, but is almost certainly due to switching to DL computed depth values. I'd like to handle this as a follow up when we prioritize GLES. https://github.com/flutter/flutter/issues/153504

Part of https://github.com/flutter/flutter/issues/142054
 2024-08-15 19:03:43 +00:00
Jonah Williams
90dcf59597 [Impeller] convert aiks blur tests to new canvas. (flutter/engine#54565) 
Part of DL interop. Currently experiencing some ... issues with blur radius/sigma.
EDIT: was rrect_blur vs gaussian: fixed now.

Part of https://github.com/flutter/flutter/issues/142054

Reland because of CI issue?
 2024-08-15 17:39:18 +00:00