29204 Commits

Author SHA1 Message Date
auto-submit[bot]
eaca267327 Reverts "macOS: Refactor create_macos_framework.py (#54557)" (flutter/engine#54566)
Reverts: flutter/engine#54557
Initiated by: zanderso
Reason for reverting: Failing on framework tests on the roll https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20run_debug_test_macos/9841/overview
Original PR Author: cbracken

Reviewed By: {jmagman}

This change reverts the following previous change:
This is a refactoring with no semantic changes.

This refactors the macOS framework creation code to be more readable, and extracts it to `sky_utils.py`.

While I was pulling this out, also generalised the code to not hardcode `FlutterMacOS.framework` in case we one day manage to generate the iOS and macOS frameworks with the same name.

This is a reland of flutter/engine#54546 (reverted in flutter/engine#54549), the original was reverted in order to revert flutter/engine#54543 (reverted in flutter/engine#54550), which was reverted because it failed to preserve symlinks while zipping the macOS framework. That patch has been relanded with a fix in flutter/engine#54555. This patch has been rebased to tip-of-tree for attempt two.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-15 05:05:27 +00:00
auto-submit[bot]
23885e2486 Reverts "[Impeller] migrate blur tests to display list. (#54519)" (flutter/engine#54564)
Reverts: flutter/engine#54519
Initiated by: jonahwilliams
Reason for reverting: post submit golden issues.
Original PR Author: jonahwilliams

Reviewed By: {chinmaygarde}

This change reverts the following previous change:
Part of DL interop. Currently experiencing some ... issues with blur radius/sigma.
EDIT: was rrect_blur vs gaussian: fixed now.

Part of https://github.com/flutter/flutter/issues/142054
2024-08-15 04:22:28 +00:00
Jonah Williams
cd6fa47e91 [Impeller] migrate blur tests to display list. (flutter/engine#54519)
Part of DL interop. Currently experiencing some ... issues with blur radius/sigma.
EDIT: was rrect_blur vs gaussian: fixed now.
2024-08-15 03:35:24 +00:00
Chris Bracken
7693bd3e7f macOS: Refactor create_macos_framework.py (flutter/engine#54557)
This is a refactoring with no semantic changes.

This refactors the macOS framework creation code to be more readable, and extracts it to `sky_utils.py`.

While I was pulling this out, also generalised the code to not hardcode `FlutterMacOS.framework` in case we one day manage to generate the iOS and macOS frameworks with the same name.

This is a reland of flutter/engine#54546 (reverted in flutter/engine#54549), the original was reverted in order to revert flutter/engine#54543 (reverted in flutter/engine#54550), which was reverted because it failed to preserve symlinks while zipping the macOS framework. That patch has been relanded with a fix in flutter/engine#54555. This patch has been rebased to tip-of-tree for attempt two.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-14 22:15:17 +00:00
skia-flutter-autoroll
421e3d0b31 Roll Fuchsia Linux SDK from MeV5i7xXXFPHF5sBK... to qpfC-GAVZvOwAQU5f... (flutter/engine#54559)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 22:13:24 +00:00
Chris Bracken
385f23c545 macOS: Clean up create_macos_framework.py (#54543) (flutter/engine#54555)
Over time, this script and others in `sky/tools` have accumulated a lot of additional and sometimes duplicate code.

This is a first pass cleanup of `create_macos_framework.py` to extract common utility code to `sky/utils.py` and refactor for better readability.

The iOS analogue of this patch was flutter/engine#54500.

This is a reland of flutter/engine#54543 (reverted in flutter/engine#54550), which failed to set the `-y` option (preserve symlinks) when zipping `FlutterMacOS.xcframework` but did so for the other zip steps where required. Since there is no case where we *want* to archive dereferenced symlinks, and because it's required for macOS frameworks, we now set this option for all callers in the `sky_tools.create_zip()` function to avoid future cases where someone working on this code misses one. If we ever need it, we can extract a parameter. This patch also references the correct script in its description (the original incorrectly mentioned `create_ios_framework.py`).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-14 19:55:20 +00:00
Jonny Wang
846176d6db [fuchsia] Use Fuchsia API 22 (flutter/engine#54554)
b/359664512

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-14 17:42:32 +01:00
auto-submit[bot]
ceb940cdf7 Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (#54541)" (flutter/engine#54552)
Reverts: flutter/engine#54541
Initiated by: zanderso
Reason for reverting: Analyzer change incorrectly flags unused final field as uninitialized? https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8739656817167901393/+/u/run_test.dart_for_customer_testing_shard_and_subshard_None/stdout
Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

https://dart.googlesource.com/sdk.git/+log/44635f897535..733062367c2e

2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 05:23:17 +00:00
auto-submit[bot]
a8e7013009 Reverts "macOS: Clean up create_ios_framework.py (#54543)" (flutter/engine#54550)
Reverts: flutter/engine#54543
Initiated by: zanderso
Reason for reverting: Failing roll https://github.com/flutter/flutter/pull/153406
Original PR Author: cbracken

Reviewed By: {zanderso}

This change reverts the following previous change:
Over time, this script and others in sky/tools have accumulated a lot of additional and sometimes duplicate code.

This is a first pass cleanup of create_macos_framework.py to extract common utility code to utils.py and refactor for better readability.

The iOS analogue of this patch was flutter/engine#54500.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-14 02:02:47 +00:00
auto-submit[bot]
6c20b583d9 Reverts "macOS: refactor create_macos_framework.py (#54546)" (flutter/engine#54549)
Reverts: flutter/engine#54546
Initiated by: zanderso
Reason for reverting: Failing roll https://github.com/flutter/flutter/pull/153406
Original PR Author: cbracken

Reviewed By: {zanderso}

This change reverts the following previous change:
This is a refactoring with no semantic changes.

This refactors the macOS framework creation code to be more readable, and extracts it to sky_utils.py.

While I was pulling this out, also generalised the code to not hardcode FlutterMacOS.framework in case we one day manage to generate the iOS and macOS frameworks with the same name.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-14 01:52:25 +00:00
Chris Bracken
248a5ea77b macOS: refactor create_macos_framework.py (flutter/engine#54546)
This is a refactoring with no semantic changes.

This refactors the macOS framework creation code to be more readable, and extracts it to sky_utils.py.

While I was pulling this out, also generalised the code to not hardcode FlutterMacOS.framework in case we one day manage to generate the iOS and macOS frameworks with the same name.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-14 00:31:10 +00:00
Jim Graham
fa64542a6a [DisplayList] Allow random access to ops through indexing (flutter/engine#54484)
Being able to reorder rendering commands leads to optimization opportunities in the graphics package. A graphics package being fed from a DisplayList either has to take the commands in the order given or implement their own storage format for the rendering data.

With this new dispatching mechanism, the graphics package can both query basic information about the recorded ops and even dispatch them by the index into the list. Query information includes either the "category" of the op (clip/transform/render, etc.) or a specific op type enum. The package can dispatch some categories (or ops) immediately and remember other categories (or ops) along with their state for dispatching later.
2024-08-13 21:26:00 +00:00
Michael Thomsen
177a661383 Update dartdoc for gpu.dart (flutter/engine#54529)
Update dartdoc for package:flutter_gpu with:
1) details on how to use the sdk dep
2) the current docs link

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-13 21:16:15 +00:00
Chris Bracken
c22b0fdaa8 macOS: Clean up create_ios_framework.py (flutter/engine#54543)
Over time, this script and others in sky/tools have accumulated a lot of additional and sometimes duplicate code.

This is a first pass cleanup of create_macos_framework.py to extract common utility code to utils.py and refactor for better readability.

The iOS analogue of this patch was flutter/engine#54500.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-13 21:05:05 +00:00
skia-flutter-autoroll
b62af72fd7 Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541)
https://dart.googlesource.com/sdk.git/+log/44635f897535..733062367c2e

2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 21:03:05 +00:00
skia-flutter-autoroll
c9d9ad4e22 Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 21:01:00 +00:00
Harry Terkelsen
3c7746ee1f [canvaskit] Add animation detection for GIFs (flutter/engine#54483)
Detect if a GIF is animated to determine if we need to use Skia to decode it or if we can use <img> tag decoding.

Fixes https://github.com/flutter/flutter/issues/151911

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-13 21:00:58 +00:00
Matej Knopp
7a1fd055b8 Preserve background frame damage (flutter/engine#54540)
Fixes https://github.com/flutter/flutter/issues/153335

When platform views are present, we always repaint entire frame. We must pass the buffer damage all the way to `GPUSurfaceMetalSkia/GPUSurfaceMetalImpeller` so that they know that the other two surfaces are lagging behind front surface and need to be repainted.

This is currently not being done with platform view present, that's why we miss full frame repaint when removing platform view.

With this merged in, it should be safe to reland https://github.com/flutter/engine/pull/54537 without any changes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-13 20:55:36 +00:00
zijiehe@
ed3b8da5e8 [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404)
The BundledTestRunner has been moved to chromium already, flutter can now use it without needing to reimplement the same logic.

The logic of parsing yaml file is still flutter specific and keeps as-is.

Bug: http://crbug.com/356463343

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-13 20:55:33 +00:00
Jonah Williams
c20915566d [Impeller] fix drawPoints scaling factors. (flutter/engine#54368)
Fixes https://github.com/flutter/flutter/issues/152780
Fixes https://github.com/flutter/flutter/issues/152794

Problems:

* If point scale is < 1, we discarded it too early by computing circle divisions with the rounded scale. Since we multiply the scale by the transform _after_ rounding, we may end up generating too many points in some circumstances.
* Tessellator used max basis XYZ instead of max basis XY. The latter will never allow scaling factors less than 1 as Flutter canvas scale does not impact Z, only transform layers do. 
* Computation of max basis required squaring the scaling factor, which would cause us to hit float::inf too early. For translate scale just take the max of m[0] and m[5].
* Draw points minimum circumference is 1, so the min radius should be 0.5
2024-08-13 17:30:34 +00:00
Zachary Anderson
5e4bb72578 Move API level 34 scenario app tests back to prod (flutter/engine#54539)
These are passing consistently.
2024-08-13 09:31:50 -07:00
Zachary Anderson
2afd56d187 Revert "Reland: Partial repaint platform views" (flutter/engine#54537)
Reverts flutter/engine#54231

Speculatively reverting for
https://github.com/flutter/flutter/issues/153335
2024-08-13 08:20:10 -07:00
skia-flutter-autoroll
d97dd84081 Roll Dart SDK from 9a6ec6cc9627 to 44635f897535 (2 revisions) (flutter/engine#54536)
https://dart.googlesource.com/sdk.git/+log/9a6ec6cc9627..44635f897535

2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-146.0.dev
2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-145.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 14:44:10 +00:00
skia-flutter-autoroll
0ee1bb9e2a Roll Dart SDK from 966df41e7755 to 9a6ec6cc9627 (1 revision) (flutter/engine#54531)
https://dart.googlesource.com/sdk.git/+log/966df41e7755..9a6ec6cc9627

2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-144.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 09:37:38 +00:00
skia-flutter-autoroll
942ff8580a Roll Skia from 8dc4b2e92727 to 899762bba6fd (2 revisions) (flutter/engine#54528)
https://skia.googlesource.com/skia.git/+log/8dc4b2e92727..899762bba6fd

2024-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 5dfe34f67d5c to 7cdb9f62c381
2024-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from da60460a940c to 5dfe34f67d5c (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 07:40:02 +00:00
dependabot[bot]
935bed47dd Bump actions/upload-artifact from 4.3.4 to 4.3.6 (flutter/engine#54527)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.3.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.3.6</h2>
<h2>What's Changed</h2>
<ul>
<li>Revert to <code>@​actions/artifact</code> 2.1.8 by <a href="https://github.com/robherley"><code>@​robherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/594">actions/upload-artifact#594</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.3.6">https://github.com/actions/upload-artifact/compare/v4...v4.3.6</a></p>
<h2>v4.3.5</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump <code>@​actions/artifact</code> to v2.1.9 by <a href="https://github.com/robherley"><code>@​robherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/588">actions/upload-artifact#588</a>
<ul>
<li>Fixed artifact upload chunk timeout logic <a href="https://redirect.github.com/actions/toolkit/pull/1774">#1774</a></li>
<li>Use lazy stream to prevent issues with open file limits <a href="https://redirect.github.com/actions/toolkit/pull/1771">#1771</a></li>
</ul>
</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.4...v4.3.5">https://github.com/actions/upload-artifact/compare/v4.3.4...v4.3.5</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="834a144ee9"><code>834a144</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/594">#594</a> from actions/robherley/4.3.6</li>
<li><a href="134dcf33c0"><code>134dcf3</code></a> v4.3.6</li>
<li><a href="73a0b9c954"><code>73a0b9c</code></a> revert back to <code>@​actions/artifact</code> 2.1.8</li>
<li><a href="89ef406dd8"><code>89ef406</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/588">#588</a> from actions/robherley/4.3.5</li>
<li><a href="23d796df36"><code>23d796d</code></a> license updates</li>
<li><a href="e445c64bc2"><code>e445c64</code></a> bump <code>@​actions/artifact</code> to v2.1.9</li>
<li>See full diff in <a href="0b2256b8c0...834a144ee9">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.3.4&new-version=4.3.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-08-13 06:40:23 +00:00
dependabot[bot]
aff0c5989b Bump google/osv-scanner-action from 1.8.2 to 1.8.3 (flutter/engine#54526)
Bumps [google/osv-scanner-action](https://github.com/google/osv-scanner-action) from 1.8.2 to 1.8.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/osv-scanner-action/releases">google/osv-scanner-action's releases</a>.</em></p>
<blockquote>
<h2>v1.8.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Now uses OSV-Scanner v1.8.3, see <a href="https://github.com/google/osv-scanner/blob/main/CHANGELOG.md">https://github.com/google/osv-scanner/blob/main/CHANGELOG.md</a> for full changelog.</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/hogo6002"><code>@​hogo6002</code></a> made their first contribution in <a href="https://redirect.github.com/google/osv-scanner-action/pull/37">google/osv-scanner-action#37</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/google/osv-scanner-action/compare/v1.8.2...v1.8.3">https://github.com/google/osv-scanner-action/compare/v1.8.2...v1.8.3</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c615bb556a"><code>c615bb5</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/37">#37</a> from google/update-to-v1.8.3</li>
<li><a href="48885be852"><code>48885be</code></a> Update unified workflow example to point to v1.8.3 reusable workflows</li>
<li><a href="6bd271cb6a"><code>6bd271c</code></a> Update reusable workflows to point to v1.8.3 actions</li>
<li><a href="01ff5d1fb3"><code>01ff5d1</code></a> Update actions to use v1.8.3 osv-scanner image</li>
<li>See full diff in <a href="https://github.com/google/osv-scanner-action/compare/v1.8.2...v1.8.3">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google/osv-scanner-action&package-manager=github_actions&previous-version=1.8.2&new-version=1.8.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-08-13 06:32:05 +00:00
skia-flutter-autoroll
d00a9fe06b Roll Dart SDK from 21cde9d69d4e to 966df41e7755 (1 revision) (flutter/engine#54524)
https://dart.googlesource.com/sdk.git/+log/21cde9d69d4e..966df41e7755

2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-143.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 05:09:11 +00:00
skia-flutter-autoroll
068273c7ea Roll Skia from d6f85d7fa251 to d3cd0afd8f0d (1 revision) (flutter/engine#54523)
https://skia.googlesource.com/skia.git/+log/d6f85d7fa251..d3cd0afd8f0d

2024-08-13 michaelludwig@google.com Revert "Reduce size of linear SkMaskGamma LUT"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 04:04:55 +00:00
skia-flutter-autoroll
83faf00fad Roll Skia from cbd5898acbd8 to d6f85d7fa251 (1 revision) (flutter/engine#54522)
https://skia.googlesource.com/skia.git/+log/cbd5898acbd8..d6f85d7fa251

2024-08-13 michaelludwig@google.com [graphite] Consolidate one-time uploads to single task/blit encoder

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 02:38:33 +00:00
skia-flutter-autoroll
6ba9eb6dcb Roll Dart SDK from a6cd8099ff85 to 21cde9d69d4e (1 revision) (flutter/engine#54521)
https://dart.googlesource.com/sdk.git/+log/a6cd8099ff85..21cde9d69d4e

2024-08-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-142.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 00:29:01 +00:00
skia-flutter-autoroll
692b75ba13 Roll Skia from 7bed8fb6fae2 to cbd5898acbd8 (2 revisions) (flutter/engine#54520)
https://skia.googlesource.com/skia.git/+log/7bed8fb6fae2..cbd5898acbd8

2024-08-12 lukasza@chromium.org [rust png] Initial implementation of `SkPngRustCodec`.
2024-08-12 kschmi@microsoft.com Reduce size of linear SkMaskGamma LUT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 00:21:13 +00:00
skia-flutter-autoroll
8c66453351 Roll Skia from c9fd814b106a to 7bed8fb6fae2 (2 revisions) (flutter/engine#54516)
https://skia.googlesource.com/skia.git/+log/c9fd814b106a..7bed8fb6fae2

2024-08-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c95d5ac066d8 to 38c20f3a406b (8 revisions)
2024-08-12 bungeman@google.com [pdf] Bounds check in skia_alloc_func

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-12 23:00:24 +00:00
skia-flutter-autoroll
7d393e9fb1 Roll Skia from e232752d04c5 to c9fd814b106a (3 revisions) (flutter/engine#54515)
https://skia.googlesource.com/skia.git/+log/e232752d04c5..c9fd814b106a

2024-08-12 sunnyps@chromium.org graphite: Make Metal memoryless textures be zero-sized
2024-08-12 brianosman@google.com TArray: Remove some redundant ASAN unpoisoning
2024-08-12 sunnyps@chromium.org graphite: Expose currentPurgeableBytes on Context and Recorder

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-12 21:42:15 +00:00
Camille Simon
e8fddf9cef [Android] Update integration test AVD dependency to use Android 35 emulators (flutter/engine#54186)
Updates AVD dependency to use [latest available AVD dependency](https://chrome-infra-packages.appspot.com/p/chromium/tools/android/avd/linux-amd64/+/I7SIawD0okHpiEe8fKvI5NQrMEWDibsvOduVbbK5pDEC) (older at the time of publishing but the same I set in the framework -- https://github.com/flutter/flutter/pull/152498) so that engine integration tests run on emulators running Android 35, the current latest version of Android.

Does not change dependency of one test that is intended to run on Android 28.

Also adds tasks to run the same emulator tests on those running Android 34 since Android 35 emulators seem to crash off and on.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-12 21:33:11 +00:00
Jonah Williams
1fd6a547fb [iOS] keep threads merged when using Skia renderer on iOS (flutter/engine#54514)
Potential fix for money crasher.
2024-08-12 21:27:54 +00:00
Chris Bracken
a034d42a09 iOS,macOS: Clean up create_ios_framework.py (flutter/engine#54500)
Over time, this script and others in sky/tools have accumulated a lot of additional and sometimes duplicate code.

This is a first pass cleanup of create_ios_framework.py to extract common utility code to utils.py and refactor for better readability.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-12 21:07:07 +00:00
skia-flutter-autoroll
0915e215e8 Roll Skia from ec7558d41b34 to e232752d04c5 (3 revisions) (flutter/engine#54511)
https://skia.googlesource.com/skia.git/+log/ec7558d41b34..e232752d04c5

2024-08-12 kjlubick@google.com Refactor //tools/window/ in preparation of Bazel use
2024-08-12 sunnyps@chromium.org graphite: Do not skip memoryless textures in memory dumps
2024-08-12 scroggo@google.com Add a comment explaining the DEPS file

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-12 20:19:55 +00:00
skia-flutter-autoroll
c636d214c7 Roll Dart SDK from cfe2b63d3aca to a6cd8099ff85 (1 revision) (flutter/engine#54512)
https://dart.googlesource.com/sdk.git/+log/cfe2b63d3aca..a6cd8099ff85

2024-08-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-141.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-12 20:16:05 +00:00
Matej Knopp
70d8d63f6e macOS: Fix crash in attributedSubstringForProposedRange with out of bounds range (flutter/engine#54469)
Fixes https://github.com/flutter/flutter/issues/153157

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-12 20:00:46 +02:00
Loïc Sharma
5b06d21661 [Windows] Improve texture format logic (flutter/engine#54329)
This improves Flutter Window's texture format logic:

1. **If the device has extension `GL_EXT_texture_format_BGRA8888`**: backing stores' texture will be created with format `GL_BGRA_EXT` instead of `GL_RGBA8`. This is what fixes https://github.com/flutter/flutter/issues/150546.
2. **Otherwise**: backing stores' texture will be created with format `GL_RGBA` and the engine will use the color type `kRGBA_8888_SkColorType` when creating the `SkSurface`.

   Previously the engine always used color type `kN32_SkColorType`, which could be either RGBA or BGRA depending on the machine that compiled the engine. This caused Skia validation errors as the texture's format did not match the Skia surface's color type.

   I tested this by editing Flutter Windows to force it down this code path.

Huge kudos to @chinmaygarde for the OpenGL expertise!

Fixes: https://github.com/flutter/flutter/issues/150546

> [!WARNING]
> Unfortunately, we are unable to test this.
> This bug appears to only affect older devices; none of our devices reproduce this issue.
> We also do not have the infrastructure to do a native screenshot test on Windows. 
> I will get a test exemption for this change.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-12 17:51:48 +00:00
Brandon DeRosier
b19fe31562 Revert "[Impeller] remove scene3d support." (flutter/engine#54502)
Reverts flutter/engine#54453

Not quite ready to remove Impeller Scene yet because I'm still porting
the animation functionality. Keeping it around allows me to switch back
and forth to compare without having to recompile the engine.

Over a month ago I said something like "we can revert this a couple of
weeks from now" in one of the Impeller meetings. But for better or worse
(better, I think), I ended up spending a ton of time trying to make the
PBR good first (which doesn't exist in this C++ version).
2024-08-12 10:28:51 -07:00
skia-flutter-autoroll
b6d3607401 Roll Dart SDK from 35bc5c866149 to cfe2b63d3aca (6 revisions) (flutter/engine#54505)
https://dart.googlesource.com/sdk.git/+log/35bc5c866149..cfe2b63d3aca

2024-08-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-140.0.dev
2024-08-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-139.0.dev
2024-08-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-138.0.dev
2024-08-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-137.0.dev
2024-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-136.0.dev
2024-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-135.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-12 15:31:20 +00:00
skia-flutter-autoroll
e3f500b7e8 Roll Skia from a09a0d635b08 to f77adcef7c1c (4 revisions) (flutter/engine#54504)
https://skia.googlesource.com/skia.git/+log/a09a0d635b08..f77adcef7c1c

2024-08-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a5d4d42457c3 to c95d5ac066d8 (1 revision)
2024-08-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bacd3a7d70c1 to 6e248bcb44bf (5 revisions)
2024-08-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from da60460a940c to 5a1b60e09ad5
2024-08-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d7d6072b1cba to da60460a940c (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-12 08:23:42 +00:00
Jonah Williams
0af4dd27e0 [Impeller] delete unused aiks PictureRecorder. (flutter/engine#54495)
I cannot find any references to this class in the code base, and it doesn't seem used anywhere.
2024-08-11 23:20:21 +00:00
Chris Bracken
c3b9f26fad iOS,docs: Update iOS symbolication docs (flutter/engine#54494)
As of flutter/flutter#153215, end user app archives now include symbols for the Flutter framework by default. So manual symbolication is no longer required.

For engine developers and others who still need to deal with manual symbols, they can now be found in the Flutter tool cache and can thus be obtained from there if required.

Issue: https://github.com/flutter/flutter/issues/116493

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-10 19:17:23 +00:00
Chris Bracken
f05c793f26 [iOS] Rename create_{full_,}ios_framework.py (flutter/engine#54493)
This renames the iOS framework creation script for consistency with the analogous macOS script.

Previously, we had two iOS framework creation scripts:
* create_ios_framework.py
* create_full_ios_framework.py

The former was unused and was deleted in https://github.com/flutter/engine/pull/54227. The addition of "full" is no longer necessary to differentiate the two.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-10 17:23:18 +00:00
Jonah Williams
720cae8ed3 [Impeller] migrate blend tests to DL. (flutter/engine#54457)
Part of https://github.com/flutter/flutter/issues/142054
2024-08-10 16:49:19 +00:00
Chris Bracken
c96be54305 [iOS] Do not archive/upload Flutter.dSYM to cloud (flutter/engine#54492)
As of the following three patches, we now bundle Flutter.framework.dSYM as part of Flutter.xcframework and bundle them in the .xcarchive bundles produced by `flutter build ipa` / Xcode Product > Archive for upload to the iOS App Store.

* https://github.com/flutter/engine/pull/54414
* https://github.com/flutter/engine/pull/54458
* https://github.com/flutter/flutter/pull/153215

The .dSYM bundle is now available both in the uploaded .xcarchive and in the xcframework in Flutter's internal artifact cache. For developers with CI toolchains that do additional manual handling or local archiving of .dSYMs, the dSYMs no longer need to be downloaded from cloud storage as previously detailed in `docs/Crashes.md`, but can instead be copied up from the appropriate dSYM subdirectory in the framework cache:

* `flutter/bin/cache/artifacts/engine/ios-release/Flutter.xcframework`

Issue: https://github.com/flutter/flutter/issues/116493
Credo: [Embrace the yak shave](https://suno.com/song/37cb7c43-85ad-40f2-87e6-9aec7baa0419)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-10 16:20:57 +00:00
Jason Simmons
0ac4b4e4a9 Revert "Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (#54474)" (flutter/engine#54487)
This reverts commit c46243b66b0839aec421eed7e159dac2806b29cc.

https://dart.googlesource.com/sdk/+/1b1740e941c33d64ed1bbca4914d0e6ad6b22cbb is causing a regression when compiling Wasm with --extra-compiler-option=--no-source-maps
2024-08-10 01:59:21 +00:00