skia-flutter-autoroll
20a9d2e775
Roll Dart SDK from 52af705f878b to fcc2bc69db3e (1 revision) ( flutter/engine#56199 )
...
https://dart.googlesource.com/sdk.git/+log/52af705f878b..fcc2bc69db3e
2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-78.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 14:06:28 +00:00
skia-flutter-autoroll
fc5d069156
Roll Fuchsia Linux SDK from RXUZ9eDc7cS4NpKoh... to zuDYsDZHnJMZVvrc8... ( flutter/engine#56197 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 12:01:23 +00:00
skia-flutter-autoroll
3ae0ed5a7d
Roll Dart SDK from 6e55dfe77483 to 52af705f878b (2 revisions) ( flutter/engine#56195 )
...
https://dart.googlesource.com/sdk.git/+log/6e55dfe77483..52af705f878b
2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-77.0.dev
2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-76.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 09:00:18 +00:00
dependabot[bot]
68933d2e77
Bump actions/setup-python from 5.2.0 to 5.3.0 ( flutter/engine#56192 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.2.0 to 5.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases ">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>v5.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add workflow file for publishing releases to immutable action package by <a href="https://github.com/Jcambass "><code>@âJcambass</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/941 ">actions/setup-python#941</a></li>
<li>Upgrade IA publish by <a href="https://github.com/Jcambass "><code>@âJcambass</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/943 ">actions/setup-python#943</a></li>
</ul>
<h3>Bug Fixes:</h3>
<ul>
<li>Normalise Line Endings to Ensure Cross-Platform Consistency by <a href="https://github.com/priya-kinthali "><code>@âpriya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/938 ">actions/setup-python#938</a></li>
<li>Revise <code>isGhes</code> logic by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/963 ">actions/setup-python#963</a></li>
<li>Bump pillow from 7.2 to 10.2.0 by <a href="https://github.com/aparnajyothi-y "><code>@âaparnajyothi-y</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/956 ">actions/setup-python#956</a></li>
</ul>
<h3>Enhancements:</h3>
<ul>
<li>Enhance workflows and documentation updates by <a href="https://github.com/priya-kinthali "><code>@âpriya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/965 ">actions/setup-python#965</a></li>
<li>Bump default versions to latest by <a href="https://github.com/jeffwidman "><code>@âjeffwidman</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/905 ">actions/setup-python#905</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Jcambass "><code>@âJcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/941 ">actions/setup-python#941</a></li>
<li><a href="https://github.com/jww3 "><code>@âjww3</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/963 ">actions/setup-python#963</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v5...v5.3.0 ">https://github.com/actions/setup-python/compare/v5...v5.3.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0b93645e9f9c76e71650https://redirect.github.com/actions/setup-python/issues/956 ">#956</a>)</li>
<li><a href="f4c5a1183dhttps://redirect.github.com/actions/setup-python/issues/963 ">#963</a>)</li>
<li><a href="19dfb7b659https://redirect.github.com/actions/setup-python/issues/905 ">#905</a>)</li>
<li><a href="e9675cc634https://redirect.github.com/actions/setup-python/issues/943 ">#943</a> from actions/Jcambass-patch-1</li>
<li><a href="3226af69c070dcb22d26https://redirect.github.com/actions/setup-python/issues/941 ">#941</a> from actions/Jcambass-patch-1</li>
<li><a href="65b48c711529a37be0a3https://redirect.github.com/actions/setup-python/issues/938 ">#938</a>)</li>
<li>See full diff in <a href="f677139bbe...0b93645e9fhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=5.2.0&new-version=5.3.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-10-29 06:24:35 +00:00
skia-flutter-autoroll
2938ff0592
Roll Skia from bdd225968dab to 6d8a5ebeb76c (3 revisions) ( flutter/engine#56185 )
...
https://skia.googlesource.com/skia.git/+log/bdd225968dab..6d8a5ebeb76c
2024-10-29 lukasza@chromium.org [rust png] Explicitly handle unsupported `dstInfo` in `SkPngCodecBase`.
2024-10-28 lukasza@chromium.org [rust png] Implement `rust_png::BlendOp::Over` in `SkPngRustCodec`.
2024-10-28 jvanverth@google.com [graphite] Add CircularArcRenderStep.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 01:24:04 +00:00
skia-flutter-autoroll
dd00983844
Roll Dart SDK from c9180e9de9e8 to 6e55dfe77483 (1 revision) ( flutter/engine#56184 )
...
https://dart.googlesource.com/sdk.git/+log/c9180e9de9e8..6e55dfe77483
2024-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-75.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 00:25:01 +00:00
Harry Terkelsen
18214377a3
[canvaskit] Deduplicate golden test file names ( flutter/engine#56143 )
...
Two different golden tests produced output named `canvaskit_picture.png`. This PR deduplicates those.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-28 23:31:19 +00:00
Brandon DeRosier
40062dbfe5
[Flutter GPU] Replace HostBuffer with Dart version. ( flutter/engine#56054 )
...
Resolves https://github.com/flutter/flutter/issues/157431 .
2024-10-28 21:16:17 +00:00
Jonah Williams
23641d582a
[Impeller] add basic Impeller+Vulkan support to embedder API. ( flutter/engine#55490 )
...
Works on GLFW example app with no validation errors.
2024-10-28 20:20:17 +00:00
skia-flutter-autoroll
2c6a76e3d1
Roll Dart SDK from 69b50768d733 to c9180e9de9e8 (1 revision) ( flutter/engine#56180 )
...
https://dart.googlesource.com/sdk.git/+log/69b50768d733..c9180e9de9e8
2024-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-74.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 20:14:19 +00:00
Jonah Williams
e357d1899d
[Impeller] fix initial layout for loadOp load and incorrect usage of host visible textures. ( flutter/engine#56148 )
...
Both changes were required to get playground tests validation free with moltenvk. becuase an initial state of undefined means "I don't care what was in this texture before" but that doesn't make sense if we're setting "kLoad" since that explicitly asks vulkan to load the previous contents.
Fixes https://github.com/flutter/flutter/issues/157557
2024-10-28 20:10:10 +00:00
skia-flutter-autoroll
82c9184c2c
Roll Skia from 21035cd95b68 to bdd225968dab (1 revision) ( flutter/engine#56178 )
...
https://skia.googlesource.com/skia.git/+log/21035cd95b68..bdd225968dab
2024-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6bf0a68d2621 to 098ec4c2bd02 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 19:56:31 +00:00
Chris Bracken
aa5298b270
iOS/macOS: migrate darwin/common to ARC ( flutter/engine#56155 )
...
Migrates //flutter/shell/platform/darwin/common` targets to ARC. Most of
these were already ARC compatible.
This does add use of the `FLUTTER_ASSERT_ARC` define since that is
defined in a public framework header, but this code has no dependency on
the framework.
This removes `flutter_cflags_objc` and `flutter_cflags_objcc` compile
configs from `availability_version_check_unittests` since that target is
pure C++ and contains no Objective-C code.
No test changes since this there is no semantic change to the code.
Issue: https://github.com/flutter/flutter/issues/137801
2024-10-28 12:34:59 -07:00
auto-submit[bot]
d66f209f9e
Reverts "Pin local_engine mac builds to arm64 ( #56172 )" ( flutter/engine#56179 )
...
<!-- start_original_pr_link -->
Reverts: flutter/engine#56172
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: mysterious infra failures:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20local_engine_builds/2951/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: zanderso
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {chinmaygarde}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
No description provided.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2024-10-28 12:28:07 -07:00
Chris Bracken
dd8db914de
Migrate PlatformViewIOS to ARC ( flutter/engine#55672 )
...
Migrates PlatformViewIOS from manual reference counting to ARC. Eliminates use of scoped_nsobject, scoped_nsprotocol, and WeakNSObject.
Since this is the last non-ARC file in `flutter_framework_source`, this also eliminates the `flutter_framework_source` target, then also renames the `flutter_framework_source_arc` target to `flutter_framework_source` since... it's ALL ARC.
No semantic changes, therefore no semantic changes to tests.
Issue: https://github.com/flutter/flutter/issues/137801
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-28 19:23:48 +00:00
skia-flutter-autoroll
57167c8067
Roll Skia from 35ad4e89212f to 21035cd95b68 (1 revision) ( flutter/engine#56176 )
...
https://skia.googlesource.com/skia.git/+log/35ad4e89212f..21035cd95b68
2024-10-28 tikuta@google.com base: include minimum header for x86 SIMD
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 18:26:05 +00:00
Alexander Aprelev
21e4c09337
Roll buildroot to pick up revert of debugging gen_snapshot prints ( flutter/engine#56175 )
...
Changes since last roll
```
3f1a1f0 Revert "For --time'd failed gn_run_binary.py runs repeat failed command (#910 )" (#914 )
e256f5c Remove github actions from buildroot (#913 )
```
2024-10-28 18:20:13 +00:00
Zachary Anderson
314ea9eae7
Pin local_engine mac builds to arm64 ( flutter/engine#56172 )
2024-10-28 18:08:55 +00:00
Zachary Anderson
e09a2da889
Switch some mac_unopt tests from intel to arm hosts ( flutter/engine#55882 )
2024-10-28 18:06:55 +00:00
skia-flutter-autoroll
be07b4555d
Roll Skia from f08fbc465888 to 35ad4e89212f (1 revision) ( flutter/engine#56171 )
...
https://skia.googlesource.com/skia.git/+log/f08fbc465888..35ad4e89212f
2024-10-28 jamesgk@google.com Enable some tests on Dawn compat
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 17:02:05 +00:00
Jonah Williams
36789c6b19
[Impeller] dont increment shared_ptr when tracked object is already tracked. ( flutter/engine#56153 )
...
By passing the shared_ptrs to TrackedObjectsVK by value, we will always require at least a decrement of the shared_ptr count, and possibly an increment too.
Since for most cases the tracked object has already been tracked, passing by const ref results in no increment or decrement.
Ignoring the time value, since this is a flamegraph, we can see almost all time spent tracking is spent on shared_ptr decrement:
2024-10-28 16:24:16 +00:00
skia-flutter-autoroll
6b4ce9c67d
Roll Dart SDK from a75848f92210 to 69b50768d733 (2 revisions) ( flutter/engine#56168 )
...
https://dart.googlesource.com/sdk.git/+log/a75848f92210..69b50768d733
2024-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-73.0.dev
2024-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-72.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 09:08:15 -07:00
skia-flutter-autoroll
3092934b6f
Roll Skia from 263c3e2ecd30 to f08fbc465888 (1 revision) ( flutter/engine#56170 )
...
https://skia.googlesource.com/skia.git/+log/263c3e2ecd30..f08fbc465888
2024-10-28 michaelludwig@google.com Revert "Update Ganesh GL interface to look for timer query functionality."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 15:37:14 +00:00
skia-flutter-autoroll
7f829d6339
Roll Fuchsia Linux SDK from VJIEKDIuzhhloCBro... to RXUZ9eDc7cS4NpKoh... ( flutter/engine#56166 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 10:47:20 +00:00
skia-flutter-autoroll
d223977bcf
Roll Skia from 0e5cf5c5f5a3 to 263c3e2ecd30 (1 revision) ( flutter/engine#56164 )
...
https://skia.googlesource.com/skia.git/+log/0e5cf5c5f5a3..263c3e2ecd30
2024-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3a265f143be4 to fe99836c8bb8 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 09:01:37 +00:00
skia-flutter-autoroll
676f8ce56b
Roll Skia from dd0158912c76 to 0e5cf5c5f5a3 (2 revisions) ( flutter/engine#56163 )
...
https://skia.googlesource.com/skia.git/+log/dd0158912c76..0e5cf5c5f5a3
2024-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8bc4729c0325 to 98a334bd44af (5 revisions)
2024-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 809e420e990b to 9daf276e5f9a (22 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 07:33:49 +00:00
skia-flutter-autoroll
dc2951ba9e
Roll Skia from cadf2538dcde to dd0158912c76 (3 revisions) ( flutter/engine#56162 )
...
https://skia.googlesource.com/skia.git/+log/cadf2538dcde..dd0158912c76
2024-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 145112eea713 to 3aaa6784ca31 (1 revision)
2024-10-28 fmalita@chromium.org Range-check custom typeface glyph ids
2024-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e548898aa37c to 6bf0a68d2621 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-28 06:13:39 +00:00
skia-flutter-autoroll
7e3bd829de
Roll Fuchsia Linux SDK from 5osQdhk4W6CcWgjIg... to VJIEKDIuzhhloCBro... ( flutter/engine#56154 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-27 09:30:40 +00:00
Chris Bracken
90b5771184
Migrate FlutterViewController to ARC ( flutter/engine#55669 )
...
Migrates `FlutterViewController` from manual reference counting to ARC. Eliminates use of scoped_nsobject and scoped_nsprotocol, and migrates ivars to property syntax where possible.
No semantic changes, therefore no changes to tests.
Issue: https://github.com/flutter/flutter/issues/137801
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-26 17:39:25 +00:00
skia-flutter-autoroll
2c9be8a0a1
Roll Fuchsia Linux SDK from Y4TdnTpLdkI107K42... to 5osQdhk4W6CcWgjIg... ( flutter/engine#56152 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-26 08:17:25 +00:00
skia-flutter-autoroll
6f38597b20
Roll Dart SDK from 0257f458e40a to a75848f92210 (2 revisions) ( flutter/engine#56150 )
...
https://dart.googlesource.com/sdk.git/+log/0257f458e40a..a75848f92210
2024-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-71.0.dev
2024-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-70.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-26 05:11:17 +00:00
skia-flutter-autoroll
e89c082d73
Roll Skia from da6c17329e0b to cadf2538dcde (3 revisions) ( flutter/engine#56147 )
...
https://skia.googlesource.com/skia.git/+log/da6c17329e0b..cadf2538dcde
2024-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bf33950646b5 to e548898aa37c (9 revisions)
2024-10-25 egdaniel@google.com [Graphite] Use mappable buffers for Vulkan instrinsic uniforms.
2024-10-25 lukasza@chromium.org [rust png] Mark frames as fully received even without decoding them.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-26 02:17:33 +00:00
gaaclarke
06c1ec5374
Removed clamping from dithering ( flutter/engine#56140 )
...
tests: https://github.com/flutter/flutter/pull/157643
fixes revert from https://github.com/flutter/flutter/pull/153976
The pixel format will clamp if it needs to anyway so this isn't
necessary.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-25 16:59:21 -07:00
Jackson Gardner
45d8f6a4ed
Reland (x2) Skwasm overlay optimizations ( flutter/engine#56067 )
...
This is an attempt to reland https://github.com/flutter/engine/pull/55468
We now defer actually drawing the pictures until the build of the layer slices, so that we can calculate an accurate `cullRect` for the picture recorder
This also contains a further optimization for the "simple" rendering case (no platform views) where we don't actually do any unnecessary occlusion calculations.
2024-10-25 22:03:56 +00:00
Jonah Williams
368ca941eb
[Impeller] Lock access to descriptor pool map. ( flutter/engine#56113 )
...
Speculative fix for https://github.com/flutter/flutter/issues/157565
which looks like the kind of error that might happen if we concurrently
mutate this hashmap.
2024-10-25 13:30:17 -07:00
skia-flutter-autoroll
c025861523
Roll Dart SDK from 3067d697ae26 to 0257f458e40a (4 revisions) ( flutter/engine#56135 )
...
https://dart.googlesource.com/sdk.git/+log/3067d697ae26..0257f458e40a
2024-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-69.0.dev
2024-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-68.0.dev
2024-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-67.0.dev
2024-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-66.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 19:06:24 +00:00
gaaclarke
789bf0db15
renamed TextFrameDispatcher to FirstPassDispatcher ( flutter/engine#56098 )
...
fixes https://github.com/flutter/flutter/issues/157526
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-25 17:18:19 +00:00
gaaclarke
a5cc4c6dcb
Added retry mechanism for pipeline creation ( flutter/engine#56071 )
...
issue https://github.com/flutter/flutter/issues/157467
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-25 16:59:10 +00:00
gaaclarke
0b9801be54
Faster vulkan buffer tracking ( flutter/engine#56099 )
...
issue: https://github.com/flutter/flutter/issues/157538
This removes multiple instances of copying std::shared_ptr and hashing.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-25 09:06:25 -07:00
Jonah Williams
4da10c43b7
[Impeller] Reland: hash less stuff per frame. ( flutter/engine#55742 )
...
Reverted due to missing glyph when rolling into the framework. Problem was that we should be always using the unrounded rounded scale to compute subpixel position but we sometimes used the rounded scale.
---
Currently we have multiple stages of hashing while font rendering, which is relatively expensive for the actualy required workload. First, we hash the contents of all text frames to compute the unique set of glyphs per frame. Then we diff this hash set against the hashmap of glyphs within the atlas. Finally we hash and lookup the final rendered bounds for each glyph.
We can simplify this to 2. hash lookups for glyphs not yet in the atlas and 1. hash lookup for glyphs that are in the atlas. This is done by combing the step where we uniquely compute glyphs per frame with the diff against the current atlas. When this lookup is performed, we also store the glyph position (if found) in the text_frame itself - which allows text contents to skip the last hash, as long as the glyph has already been rendered.
See https://github.com/flutter/engine/pull/55092
2024-10-25 16:05:52 +00:00
skia-flutter-autoroll
39608491a5
Roll Skia from cc75472dedc2 to da6c17329e0b (3 revisions) ( flutter/engine#56132 )
...
https://skia.googlesource.com/skia.git/+log/cc75472dedc2..da6c17329e0b
2024-10-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dd7c0efb9d54 to bf33950646b5 (3 revisions)
2024-10-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f2315dbe32bd to 3a265f143be4 (3 revisions)
2024-10-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4fb594542104 to 8bc4729c0325 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 15:45:50 +00:00
Robert Ancell
6966cb21a0
Clean up comments and names in FlView ( flutter/engine#56084 )
...
Add/update comments for clarity and ensure naming matches other code
conventions.
2024-10-26 02:50:37 +13:00
Robert Ancell
d62ce043c5
Move platform handler from FlView to FlEngine ( flutter/engine#56024 )
...
There can only be one handler and multiple views.
2024-10-26 02:46:45 +13:00
skia-flutter-autoroll
bdab77e6da
Roll Skia from 53c9663c3b83 to cc75472dedc2 (10 revisions) ( flutter/engine#56121 )
...
https://skia.googlesource.com/skia.git/+log/53c9663c3b83..cc75472dedc2
2024-10-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from be9d992b58d8 to 809e420e990b (16 revisions)
2024-10-24 lukasza@chromium.org [rust png] Handle palette expansion on Skia side.
2024-10-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b0229dbd25db to dd7c0efb9d54 (12 revisions)
2024-10-24 briansalomon@gmail.com Update Ganesh GL interface to look for timer query functionality.
2024-10-24 michaelludwig@google.com Add factories for SkWorkingColorSpaceShader and SkColorFilterShader
2024-10-24 robertphillips@google.com [graphite] Add toggle to control aspects of Pipeline creation
2024-10-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9a4c7495f3cd to f2315dbe32bd (5 revisions)
2024-10-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from df0da6f45570 to 4fb594542104 (2 revisions)
2024-10-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6685fff40671 to be9d992b58d8 (9 revisions)
2024-10-23 lukasza@chromium.org [rust png] Discover frames more aggressively in `onGetFrameCount`.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-25 06:07:21 +00:00
Jim Graham
23187a652e
[DisplayList] Remove legacy size fields in DLOp records ( flutter/engine#56101 )
...
After landing https://github.com/flutter/engine/pull/54676 we had the DLBuilder using legacy size fields in the DLOp records to manage traversing the records, but we constructed a more direct "offset vector" for the DisplayList to enable random access to the ops. The offset vector was created on the fly during the `Build()` method and then the size fields in the DLOp records were largely unused and redundant.
This PR gets rid of the remaining uses of the DLOp size fields and has the Builder produce the offsets vector directly during recording.
2024-10-25 05:13:40 +00:00
Chinmay Garde
97be50d961
[Impeller] libImpeller: Respect the paragraph style line height specification. ( flutter/engine#56066 )
...
cc @lyceel
2024-10-25 00:19:24 +00:00
Jason Simmons
641814ad61
[web] Do not copy invalid images in the Skia test image collection ( flutter/engine#56102 )
...
A recent Skia commit added a test image that is used to check handling of invalid input. This is causing some web tests to fail because Firefox rejects the image.
(see https://skia.googlesource.com/skia.git/+/ff59ce65022d71f883b7e3be146bbd32facadaf8 )
2024-10-24 22:39:20 +00:00
Devon Carew
f233f9eaf4
[deps] update deps and pubspecs for the new locations of package:matcher, package:collection, and package:boolean_selector ( flutter/engine#56107 )
...
Update the deps and pubspec files for the new SoT locations for:
- package:matcher (dart-lang/test)
- package:collection (dart-lang/core)
- package:boolean_selector (dart-lang/tools)
See also issue https://github.com/dart-lang/sdk/issues/56591 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-24 22:37:01 +00:00
skia-flutter-autoroll
8531105702
Roll Dart SDK from 7d218a25e8bf to 3067d697ae26 (3 revisions) ( flutter/engine#56106 )
...
https://dart.googlesource.com/sdk.git/+log/7d218a25e8bf..3067d697ae26
2024-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-65.0.dev
2024-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-64.0.dev
2024-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-63.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-24 22:31:35 +00:00
Jonah Williams
88415da70b
[android] make failing to acquire a java image non-fatal. ( flutter/engine#56105 )
...
See failures in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8733165720607371809/+/u/step_is_flaky:_run_platform_views_scroll_perf__timeline_summary/stdout
If we fail to acquire the next image from the image reader, its ok to return null from this method as the engine already handles displaying nothing.
THe crashes are due to us ... choosing to crash, which isn't really meaningful.
2024-10-24 21:14:25 +00:00
