skia-flutter-autoroll
790d7cdb27
Roll Fuchsia Linux SDK from NxrFCTty8wV4-6Cpl... to Y4TdnTpLdkI107K42... ( flutter/engine#56096 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-24 18:34:23 +00:00
Jenn Magder
5686e3651a
Remove 'Linux mac_clangd' in favor of 'Mac clangd' ( flutter/engine#56082 )
...
Follow up to https://github.com/flutter/engine/pull/56014
`Mac clangd` is [passing as a standalone build](https://ci.chromium.org/ui/p/flutter/builders/staging/Mac%20clangd/60/overview ) (<10 minutes). Move it out of bringup and remove `Linux mac_clangd`.
https://github.com/flutter/flutter/issues/157275
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-24 17:38:18 +00:00
gaaclarke
2c204ddb54
Added thread name to pipeline validation error. ( flutter/engine#56074 )
...
issue: https://github.com/flutter/flutter/issues/148320
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-24 08:26:34 -07:00
skia-flutter-autoroll
7dad6ea340
Roll Dart SDK from 024c9570fae4 to 7d218a25e8bf (1 revision) ( flutter/engine#56085 )
...
https://dart.googlesource.com/sdk.git/+log/024c9570fae4..7d218a25e8bf
2024-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-62.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-24 09:54:27 +00:00
skia-flutter-autoroll
8e25952589
Roll Dart SDK from dd06a1e3002c to 024c9570fae4 (1 revision) ( flutter/engine#56079 )
...
https://dart.googlesource.com/sdk.git/+log/dd06a1e3002c..024c9570fae4
2024-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-61.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-24 05:40:30 +00:00
auto-submit[bot]
1b6e5c0329
Reverts "[display_list] grow display list backing store by power of two. ( #56004 )" ( flutter/engine#56078 )
...
Reverts: flutter/engine#56004
Initiated by: jonahwilliams
Reason for reverting: unexpected framework ui thread regression, no performance improvement
Original PR Author: jonahwilliams
Reviewed By: {flar, chinmaygarde}
This change reverts the following previous change:
Fixes https://github.com/flutter/flutter/issues/157108
Right now the DL is always growing by a minimum 4096 bytes at a time. On applications with large display lists, this can lead to hundreds of reallocations as the display list is build, as long as each draw op is small. For example, the framework benchmark long picture scrolling draws many lines, each of which is a pretty small op.
Update the code so that we grow by doubling, with a minimum increment of ~16K
2024-10-24 01:49:46 +00:00
LongCatIsLooong
f754c3d36e
Bare-bones iOS FKA implementation ( flutter/engine#55964 )
...
A bare-bones implementation for iOS focus engine support, to enable basic full keyboard access (FKA) (except for scrolling which will be implemented in a different patch).
Partially f1xes https://github.com/flutter/flutter/issues/76497
https://github.com/user-attachments/assets/427db87e-cc15-483a-85a1-56bf1c02c285
On iOS 15 and above, FKA, if enabled, always consumes relevant key events, so the Flutter framework can't see those key events as they won't be delivered via the `UIResponder` chain (https://developer.apple.com/documentation/uikit/uikeycommand/3780513-wantspriorityoversystembehavior ). This patch provides the basic focus-related information to the iOS focus engine, derived from the information already available in the accessibility tree, so the iOS focus engine can navigate the UI hierarchy and invoke `accessibilityActivate` on the current focus when the user presses the space key.
This at the moment seems to be the best option:
- There doesn't seem to be a way to reliably prevent FKA from consuming the key events and that seems to be by design.
- The user can remap the FKA keys in iOS system settings, but that key mapping isn't available to apps, so even if the framework can get the key events it won't be able to honor custom key maps.
- When FKA is on, `-[FlutterView isAccessibilityElement]` is called without user interaction (presumably it's called when the view appears), so when the user interacts with the app using FKA, it's likely that the accessibility is already enabled, we don't have to worry detecting whether FKA is on (at least for now).
Scrolling using FKA currently does not work despite `FlutterScrollableSemanticsObject` conforms to `UIFocusItemScrollableContainer`. `setContentOffset:` must be implemented using a new API that informs the framework of the new contentOffset in the scroll view. `accessibilityScroll` does not work because it scrolls too much in most cases, and it tells the framework "how much to scroll" instead of "where to scroll to" so it tends to be jumpy.
## What happens on iOS versions earlier than 15
I couldn't find iOS 14 runtime for simulators in xcode 16 so I couldn't test it. But since the key events will be delivered to the framework first regardless of whether FKA is enabled, the framework is supposed to handle keyboard focus navigation even when FKA is on.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-24 00:01:20 +00:00
Chinmay Garde
329ecc861e
[Impeller] libImpeller: Allow appending to the transformation stack. ( flutter/engine#56072 )
...
Currently @lyceel has a workaround where they get the transform, create a new one, and call SetTransform. They would like to avoid this.
Fixes https://github.com/flutter/flutter/issues/156604
2024-10-23 23:15:10 +00:00
Jenn Magder
f399131af6
Add standalone 'Mac clangd' builder to replace 'Linux mac_clangd' orchestrator ( flutter/engine#56014 )
...
"Orchestrator" builders are top-level builds that can perform some caching, kick off "drone" sub-builds, and then do things with those build artifacts like run tests, or "generators" that do work on those artifacts. See more details in https://flutter.dev/go/engine-build-definition-language . `Linux mac_clangd` is currently set up as an orchestrator builder, but it only kicks off one gn and one test that can be converted to a standalone build. `Linux mac_clangd` is confusingly named because the orchestrator is a Linux machine, but the drone is a Mac.
Copy `Linux mac_clangd` into [`ci/builders/standalone`](c17390e606/ci/builders/standalone9a7492dc88/ci/builders/mac_unopt_debug_no_rbe.jsonc17390e606/.ci.yaml (L26-L37)https://github.com/flutter/engine/pull/55988 ).
I repurposed non-bringup `Mac mac_unopt` to test the standalone config (and then reverted it) ([result](https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20mac_unopt/10479/infra )). Here's the passing clangd test: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8733402970006982913/+/u/test:_clangd/stdout
I also renamed linux_unopt_debug_no_rbe.json to linux_clangd.json to match and added cas_archive (see https://github.com/flutter/engine/pull/56014#pullrequestreview-2385392205 ).
Part of https://github.com/flutter/flutter/issues/155041
Fixes https://github.com/flutter/flutter/issues/157275
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-23 23:01:15 +00:00
skia-flutter-autoroll
4feca7ed3f
Roll Dart SDK from 75c42f30af7a to dd06a1e3002c (2 revisions) ( flutter/engine#56070 )
...
https://dart.googlesource.com/sdk.git/+log/75c42f30af7a..dd06a1e3002c
2024-10-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-60.0.dev
2024-10-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-59.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 22:04:18 +00:00
skia-flutter-autoroll
c35f8df302
Roll Skia from 42f9070e6625 to 53c9663c3b83 (1 revision) ( flutter/engine#56069 )
...
https://skia.googlesource.com/skia.git/+log/42f9070e6625..53c9663c3b83
2024-10-23 het@google.com Expose backdropFilterTileMode to saveLayer API
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 21:58:04 +00:00
Gray Mackall
c5d163fccb
Delete v1 android engine embedding ( flutter/engine#52022 )
...
Fixes https://github.com/flutter/flutter/issues/143531
Other failures from the initial attempt are fixed in https://github.com/flutter/flutter/pull/146523/
2024-10-23 21:12:52 +00:00
hellohuanlin
3e89cd79b5
[ios][platform_view]force reset forwarding recognizer state when its stuck ( flutter/engine#55958 )
...
This PR force reset forwarding recognizer state when it's stuck at failed state, by recreating the recognizer (we are not able to reset the state back to possible - it has to be reset by UIKit).
This is a tricky one since pencil and finger triggers exactly the same callbacks. It turns out that when pencil is involved after finger interaction, the platform view's "forwarding" gesture recognizer is stuck at failed state. This seems to be an iOS bug, because according to [the API doc](https://developer.apple.com/documentation/uikit/uigesturerecognizerstate/uigesturerecognizerstatefailed?language=objc ), it should be reset back to "possible" state:
> No action message is sent and the gesture recognizer is reset to [UIGestureRecognizerStatePossible](https://developer.apple.com/documentation/uikit/uigesturerecognizerstate/uigesturerecognizerstatepossible?language=objc ).
However, when iPad pencil is involved, the state is not reset. I tried to KVO the state property, and wasn't able to capture the change. This means the state change very likely happened internally within the recognizer via the backing ivar of the state property.
Fixes https://github.com/flutter/flutter/issues/136244
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-23 21:10:57 +00:00
Jason Simmons
57a7c7a5fe
Allow running the YAPF formatter using Python version 3.11 ( flutter/engine#56062 )
2024-10-23 21:10:55 +00:00
Jonah Williams
94ebc356cc
[Impeller] optimize clip rects by checking if integral coverage is sufficient. ( flutter/engine#56041 )
...
For non-aa axis aligned difference clip rects or aa axis aligned difference clips that are very nearly integral, just use the scissor update and don't perform the depth write at all.
2024-10-23 20:20:17 +00:00
Siva
4595712f73
Switch the web compilation step to use an AOT snapshot ( flutter/engine#56040 )
...
Switch the Dart Development Compiler compilation step to use the
dartdevc AOT snapshot.
2024-10-23 13:18:11 -07:00
skia-flutter-autoroll
7f5c576e6f
Roll Skia from 721bbd7c0340 to 42f9070e6625 (1 revision) ( flutter/engine#56064 )
...
https://skia.googlesource.com/skia.git/+log/721bbd7c0340..42f9070e6625
2024-10-23 arthursonzogni@chromium.org Reland "partition_alloc: Fix condition about sanitizers."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 19:15:23 +00:00
Devon Carew
7ffe338915
Update the engine deps to track new SoT git locations for several packages ( flutter/engine#56028 )
...
This PR updates the deps and pubspec overrides to track the new SoT of
several Dart core packages (these now live in dart-lang/core).
- `package:args`
- `package:async`
- `package:convert`
- `package:crypto`
- `package:fixnum`
- `package:logging`
- `package:path`
- `package:platform`
- `package:typed_data`
issues
- https://github.com/dart-lang/sdk/issues/56591
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-23 11:14:58 -07:00
skia-flutter-autoroll
00b2449396
Roll Skia from ad09ab099fe4 to 721bbd7c0340 (10 revisions) ( flutter/engine#56063 )
...
https://skia.googlesource.com/skia.git/+log/ad09ab099fe4..721bbd7c0340
2024-10-23 borenet@google.com [infra] Remove Debian11 RTX3060 jobs, fix dimension for Win RTX3060
2024-10-23 michaelludwig@google.com [graphite] Preserve PaintParamsKey structure on error cases
2024-10-23 kjlubick@google.com Expose SkRuntimeEffectBuilder via SK_API
2024-10-23 kjlubick@google.com Remove Pixel2XL jobs
2024-10-23 kjlubick@google.com Add example of making custom SkColorFilter using sksl
2024-10-23 kjlubick@google.com Skip compiling RustDecoderTest on WASM
2024-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6834fd1efef0 to b0229dbd25db (1 revision)
2024-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4bdcdf0deef5 to 9a4c7495f3cd (15 revisions)
2024-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from fc1fbc4105b0 to df0da6f45570 (11 revisions)
2024-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 8e9623dbadf3 to 6685fff40671 (14 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 17:44:36 +00:00
Alexander Aprelev
f51e0982e9
Reland copy gen snapshot ( flutter/engine#56061 )
...
Copy gen_snapshots using python's shutil.copy, avoid links
Default implementation of copy does it via hardlink, which seems to be
causing issues with Gatekeeper on mac.
This is reland of 63d8f5cb72d711871736b742a30a45106df21b9a with the fix
for the case when target is a link to the source, that was the cause for
revert c5ad234e11dd716cd8b136cdef8d1233c594c527
BUG=https://github.com/flutter/flutter/issues/154437
2024-10-23 10:26:31 -07:00
skia-flutter-autoroll
ddd055057d
Roll Dart SDK from 2a4b728f6a03 to 75c42f30af7a (1 revision) ( flutter/engine#56060 )
...
https://dart.googlesource.com/sdk.git/+log/2a4b728f6a03..75c42f30af7a
2024-10-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-58.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 17:13:19 +00:00
gaaclarke
d7182e6d40
Fixes crash in testTrackpadGesturesAreSentToFramework ( flutter/engine#55990 )
...
fixes https://github.com/flutter/flutter/issues/157205
This crashed because ocmock was storing references to rvalues for its
mocked arguments.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-23 10:11:35 -07:00
Jonah Williams
20528e2550
[display_list] grow display list backing store by power of two. ( flutter/engine#56004 )
...
Fixes https://github.com/flutter/flutter/issues/157108
Right now the DL is always growing by a minimum 4096 bytes at a time. On applications with large display lists, this can lead to hundreds of reallocations as the display list is build, as long as each draw op is small. For example, the framework benchmark long picture scrolling draws many lines, each of which is a pretty small op.
Update the code so that we grow by doubling, with a minimum increment of ~16K
2024-10-23 16:10:06 +00:00
skia-flutter-autoroll
b4e95e619a
Roll Fuchsia Linux SDK from xPbin_33tT-_omeQT... to NxrFCTty8wV4-6Cpl... ( flutter/engine#56056 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 14:07:22 +00:00
skia-flutter-autoroll
f309742a72
Roll Dart SDK from 20470aaa17be to 2a4b728f6a03 (3 revisions) ( flutter/engine#56055 )
...
https://dart.googlesource.com/sdk.git/+log/20470aaa17be..2a4b728f6a03
2024-10-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-57.0.dev
2024-10-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-56.0.dev
2024-10-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-55.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 12:57:47 +00:00
Robert Ancell
762302a69a
Move get_keyboard_state from FlKeyboardViewDelegate to FlKeyboardManager. ( flutter/engine#56021 )
...
Like the other associated changes, I've added
fl_keyboard_manager_set_get_get_pressed_state_handler for now to keep
the tests working.
2024-10-23 23:05:21 +13:00
Robert Ancell
bb8679e23f
Move send_key_event from FlKeyboardViewDelegate to FlKeyboardManager. ( flutter/engine#56020 )
...
Ideally the tests would mock FlEngine, but I wasn't able to get it
working so I've added fl_keyboard_manager_set_send_key_event_handler for
now.
2024-10-23 22:05:09 +13:00
Brandon DeRosier
026062f08b
[Flutter GPU] Fix assert failure in createDeviceBufferWithCopy. ( flutter/engine#56039 )
...
Resolves https://github.com/flutter/flutter/issues/157336
`DartByteData` gets raw pointers into the Dart heap via `Dart_TypedDataAcquireData`. So it must be destructed before `AssociateWithDartWrapper` is called, which mutates the heap.
Re-enables failing test for Linux unopt.
2024-10-23 05:08:03 +00:00
skia-flutter-autoroll
1fbd217c0e
Roll Dart SDK from 8de85635d731 to 20470aaa17be (4 revisions) ( flutter/engine#56038 )
...
https://dart.googlesource.com/sdk.git/+log/8de85635d731..20470aaa17be
2024-10-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-54.0.dev
2024-10-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-53.0.dev
2024-10-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-52.0.dev
2024-10-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-51.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 16:21:42 -07:00
David Iglesias
95ae8d46b5
[web] Remove old futureToPromise. ( flutter/engine#55847 )
...
This PR removes the old `futureToPromise` implementation (which was barely used), and replaces it by a more standard js_interop approach.
Fixes https://github.com/flutter/flutter/issues/155732
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-22 23:09:17 +00:00
Loïc Sharma
c0beb6bb71
[dart:ui] Improve Clip's docs ( flutter/engine#55978 )
2024-10-22 22:35:12 +00:00
Jonah Williams
ba956aac92
[Impeller] flush thread local resources during toImage/toImageSync. ( flutter/engine#56037 )
...
I suspect not flushing is related to occassionaly timeouts on flutter tester --enable impelller. because the flutter_tester never actually pumps a frame, it won't naturally flush these resources.
It shouldn't be harmful to otherwise flush.
2024-10-22 22:27:02 +00:00
K. P. Krasiński-Sroka
10f2a2ccd1
[canvaskit] Makes access to CkSurface null-safer ( flutter/engine#54895 )
...
Handles exceptions coming from `MakeSWCanvasSurface` and `MakeOffscreenSWCanvasSurface`.
Also makes surface size a member of `CkSurface` to make sure that it's always in sync with `surface`.
Fixes https://github.com/flutter/flutter/issues/154402
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-22 22:27:00 +00:00
Jonah Williams
7ebba40ad4
[Impeller] refactor clip rendering. ( flutter/engine#56030 )
...
Now that we don't have the entity pass structure, clips can be treated as a kind of structured data and not a generic entity. Doing so lets us simplify some of the clip management and remove some usage of raw pointers. This change also removes the ClipRestoreContents, which are only ever created and then immediately rendered - we can instead replace this with a function.
The ClipCoverageStack now has explicit Clip/Restore methods that internally apply the same logic, but without involving the entity object.
Redo of https://github.com/flutter/engine/pull/55784
2024-10-22 21:12:22 +00:00
Jenn Magder
2f467bae78
Fix macos xcprivacy manifest copy location ( flutter/engine#56010 )
...
Cherry-pick the beta branch privacy location fix https://github.com/flutter/engine/pull/55938 back to master so this doesn't regress in the next beta.
This is for https://github.com/flutter/flutter/issues/157016 on master. Can be merged once the framework test https://github.com/flutter/flutter/pull/157318 merges.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-22 20:46:12 +00:00
auto-submit[bot]
c5ad234e11
Reverts "Copy gen_snapshots using python's shutil.copy, avoid links ( #55830 )" ( flutter/engine#56034 )
...
Reverts: flutter/engine#55830
Initiated by: chinmaygarde
Reason for reverting: Incremental builds are broken. https://github.com/flutter/flutter/issues/157367
Original PR Author: aam
Reviewed By: {mraleph, cbracken}
This change reverts the following previous change:
Default implementation of copy does it via hardlink, which seems to be causing issues with Gatekeeper on mac.
BUG=https://github.com/flutter/flutter/issues/154437
2024-10-22 19:45:47 +00:00
skia-flutter-autoroll
759da79de8
Roll Skia from 3731c1f7cf29 to ad09ab099fe4 (2 revisions) ( flutter/engine#56033 )
...
https://skia.googlesource.com/skia.git/+log/3731c1f7cf29..ad09ab099fe4
2024-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d8276cfd24b7 to 6834fd1efef0 (1 revision)
2024-10-22 lukasza@chromium.org [rust png] Initial `SkPngRustDecoderTest.cpp`.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 19:41:11 +00:00
yaakovschectman
32d9706cec
Fix typo in testing script ( flutter/engine#56029 )
...
Just fix the spelling of `warning`.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-22 19:08:12 +00:00
Chinmay Garde
b121c24502
[Impeller] libImpeller: Document the entire API. ( flutter/engine#56003 )
...
I believe I got the entire API other than the enum values. Though most a straightforward, some could use some clarification.
The typography stuff should now be easier to use. The README describes the object model and reference counting conventions.
2024-10-22 18:43:23 +00:00
Jonah Williams
7da7f8b890
[Impeller] eagerly flip backdrop back to onscreen. ( flutter/engine#55983 )
...
Fixes https://github.com/flutter/flutter/issues/157112
We currently track the number of backdrop filters in a frame. When the end of the frame is reached, we do a blit from the offscreen texture to the onscreen texture. Howeever, this extra blit is unecessary once we know we've rendered the last backdrop - and we can instead start the last render pass with the onscreen. This cuts out a fairly expensive blit.
this can only be done on iOS physical devices, vulkan, and some GLES - as emulated blends also use the backdrop.
## Before
Shader time is lower but timeline claims about 2.8ms and about ~800ms of blit pass.
## After
Timeline is ~2.1 ms with no blit pass. Tracks with numbers above.
2024-10-22 17:54:38 +00:00
John McDole
51d2f1623d
Typo in engine_binary_hashing.md ( flutter/engine#55866 )
...
s/-R/-r
2024-10-22 09:25:20 -07:00
skia-flutter-autoroll
25af2569df
Roll Skia from b11804aaabbb to 3731c1f7cf29 (3 revisions) ( flutter/engine#56027 )
...
https://skia.googlesource.com/skia.git/+log/b11804aaabbb..3731c1f7cf29
2024-10-22 egdaniel@google.com [Graphite] Make sure not to use Protected Vertex/Index buffers.
2024-10-22 pkasting@chromium.org Add begin()/end() to SkString.
2024-10-22 bungeman@google.com [pdf] Change structure identifiers to match specification
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 16:14:18 +00:00
skia-flutter-autoroll
647ead52e9
Roll Skia from c89324dd8f6e to b11804aaabbb (1 revision) ( flutter/engine#56025 )
...
https://skia.googlesource.com/skia.git/+log/c89324dd8f6e..b11804aaabbb
2024-10-22 kjlubick@google.com Revert "partition_alloc: Fix condition about sanitizers."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 14:48:23 +00:00
Brandon DeRosier
3b568c8d68
[Flutter GPU] Fix conditional when checking DeviceBuffer bounds. ( flutter/engine#56017 )
...
Resolves https://github.com/flutter/flutter/issues/157324
Fix a silly off-by-one that I didn't catch because none of the tests are using `DeviceBuffer` directly. ð¤¦
2024-10-22 10:58:38 +00:00
skia-flutter-autoroll
94fac8afbe
Roll Dart SDK from 86ac62245577 to 8de85635d731 (3 revisions) ( flutter/engine#56019 )
...
https://dart.googlesource.com/sdk.git/+log/86ac62245577..8de85635d731
2024-10-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-50.0.dev
2024-10-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-49.0.dev
2024-10-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-48.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 09:07:38 +00:00
skia-flutter-autoroll
8f8170a5d3
Roll Skia from 64f4f1922946 to c89324dd8f6e (1 revision) ( flutter/engine#56018 )
...
https://skia.googlesource.com/skia.git/+log/64f4f1922946..c89324dd8f6e
2024-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4aa12e9e17f5 to 4bdcdf0deef5 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,codefu@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 08:30:19 +00:00
skia-flutter-autoroll
b1f0dcf32f
Roll Skia from 9c6cc020751d to 64f4f1922946 (3 revisions) ( flutter/engine#56016 )
...
https://skia.googlesource.com/skia.git/+log/9c6cc020751d..64f4f1922946
2024-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6c65601e5d77 to fc1fbc4105b0 (5 revisions)
2024-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0afe6a306dd2 to 145112eea713 (1 revision)
2024-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6a645bf6ebd6 to 8e9623dbadf3 (19 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 07:11:20 +00:00
skia-flutter-autoroll
e14b930196
Roll Skia from a71df7d9bc63 to 9c6cc020751d (1 revision) ( flutter/engine#56013 )
...
https://skia.googlesource.com/skia.git/+log/a71df7d9bc63..9c6cc020751d
2024-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4220684adef5 to d8276cfd24b7 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 05:53:23 +00:00
skia-flutter-autoroll
c17390e606
Roll Fuchsia Linux SDK from avSAUwQTf5xVGuZQU... to xPbin_33tT-_omeQT... ( flutter/engine#56011 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 04:21:23 +00:00
Alexander Aprelev
63d8f5cb72
Copy gen_snapshots using python's shutil.copy, avoid links ( flutter/engine#55830 )
...
Default implementation of copy does it via hardlink, which seems to be
causing issues with Gatekeeper on mac.
BUG=https://github.com/flutter/flutter/issues/154437
2024-10-22 04:48:02 +03:00
