Kaylee Lubick
f20d6dde9a
[skia] Use more GNI file lists ( flutter/engine#53685 )
...
In http://review.skia.org/862177 (and to a lesser extent,
http://review.skia.org/862416 ), Skia added more .gni file lists for code
in src/ports. This updates Flutter to use those lists instead of
hard-coding those file paths directly, making it easier for upstream
changes in Skia (e.g. file renames or relocations) to be pulled into
Flutter without a Flutter-side change.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-07-02 12:44:02 -04:00
skia-flutter-autoroll
1e6a8af9a7
Roll Skia from 7f2094d4cf43 to 42fad315c162 (1 revision) ( flutter/engine#53684 )
...
https://skia.googlesource.com/skia.git/+log/7f2094d4cf43..42fad315c162
2024-07-02 johnstiles@google.com Avoid emitting unnecessary stack_rewind SkRP ops.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 16:23:19 +00:00
skia-flutter-autoroll
9e30c975c9
Roll Skia from 7881ad4aae92 to 7f2094d4cf43 (1 revision) ( flutter/engine#53683 )
...
https://skia.googlesource.com/skia.git/+log/7881ad4aae92..7f2094d4cf43
2024-07-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bbcdf62c225f to 5faad80a00af (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 11:19:41 +00:00
skia-flutter-autoroll
8462e218a5
Roll Fuchsia Linux SDK from LkXpxHsQlkPT4mmJ7... to x5Sccm0dUoMVbnyed... ( flutter/engine#53682 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 10:03:22 +00:00
skia-flutter-autoroll
fa5a5a8084
Roll Skia from 4c1856aadb85 to 7881ad4aae92 (1 revision) ( flutter/engine#53681 )
...
https://skia.googlesource.com/skia.git/+log/4c1856aadb85..7881ad4aae92
2024-07-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4f23429a1f09 to d8700dc951b6 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 09:22:15 +00:00
skia-flutter-autoroll
5c672435f0
Roll Skia from d7a9375e86c1 to 4c1856aadb85 (2 revisions) ( flutter/engine#53680 )
...
https://skia.googlesource.com/skia.git/+log/d7a9375e86c1..4c1856aadb85
2024-07-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a06878f25d87 to a4c3d29a3f7c
2024-07-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ca190d337809 to a06878f25d87 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 07:06:32 +00:00
dependabot[bot]
702ad234d5
Bump github/codeql-action from 3.25.10 to 3.25.11 ( flutter/engine#53678 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.10 to 3.25.11.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md ">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases ">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.25.11 - 28 Jun 2024</h2>
<ul>
<li>Avoid failing the workflow run if there is an error while uploading debug artifacts. <a href="https://redirect.github.com/github/codeql-action/pull/2349 ">#2349</a></li>
<li>Update default CodeQL bundle version to 2.17.6. <a href="https://redirect.github.com/github/codeql-action/pull/2352 ">#2352</a></li>
</ul>
<h2>3.25.10 - 13 Jun 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.5. <a href="https://redirect.github.com/github/codeql-action/pull/2327 ">#2327</a></li>
</ul>
<h2>3.25.9 - 12 Jun 2024</h2>
<ul>
<li>Avoid failing database creation if the database folder already exists and contains some unexpected files. Requires CodeQL 2.18.0 or higher. <a href="https://redirect.github.com/github/codeql-action/pull/2330 ">#2330</a></li>
<li>The init Action will attempt to clean up the database cluster directory before creating a new database and at the end of the job. This will help to avoid issues where the database cluster directory is left in an inconsistent state. <a href="https://redirect.github.com/github/codeql-action/pull/2332 ">#2332</a></li>
</ul>
<h2>3.25.8 - 04 Jun 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.4. <a href="https://redirect.github.com/github/codeql-action/pull/2321 ">#2321</a></li>
</ul>
<h2>3.25.7 - 31 May 2024</h2>
<ul>
<li>We are rolling out a feature in May/June 2024 that will reduce the Actions cache usage of the Action by keeping only the newest TRAP cache for each language. <a href="https://redirect.github.com/github/codeql-action/pull/2306 ">#2306</a></li>
</ul>
<h2>3.25.6 - 20 May 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.3. <a href="https://redirect.github.com/github/codeql-action/pull/2295 ">#2295</a></li>
</ul>
<h2>3.25.5 - 13 May 2024</h2>
<ul>
<li>Add a compatibility matrix of supported CodeQL Action, CodeQL CLI, and GitHub Enterprise Server versions to the <a href="https://github.com/github/codeql-action/blob/main/README.md ">https://github.com/github/codeql-action/blob/main/README.md </a>. <a href="https://redirect.github.com/github/codeql-action/pull/2273 ">#2273</a></li>
<li>Avoid printing out a warning for a missing <code>on.push</code> trigger when the CodeQL Action is triggered via a <code>workflow_call</code> event. <a href="https://redirect.github.com/github/codeql-action/pull/2274 ">#2274</a></li>
<li>The <code>tools: latest</code> input to the <code>init</code> Action has been renamed to <code>tools: linked</code>. This option specifies that the Action should use the tools shipped at the same time as the Action. The old name will continue to work for backwards compatibility, but we recommend that new workflows use the new name. <a href="https://redirect.github.com/github/codeql-action/pull/2281 ">#2281</a></li>
</ul>
<h2>3.25.4 - 08 May 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.2. <a href="https://redirect.github.com/github/codeql-action/pull/2270 ">#2270</a></li>
</ul>
<h2>3.25.3 - 25 Apr 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.1. <a href="https://redirect.github.com/github/codeql-action/pull/2247 ">#2247</a></li>
<li>Workflows running on <code>macos-latest</code> using CodeQL CLI versions before v2.15.1 will need to either upgrade their CLI version to v2.15.1 or newer, or change the platform to an Intel MacOS runner, such as <code>macos-12</code>. ARM machines with SIP disabled, including the newest <code>macos-latest</code> image, are unsupported for CLI versions before 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/2261 ">#2261</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b611370bb5https://redirect.github.com/github/codeql-action/issues/2357 ">#2357</a> from github/update-v3.25.11-de945755c</li>
<li><a href="3e6431f3acde945755c9https://redirect.github.com/github/codeql-action/issues/2352 ">#2352</a> from github/update-bundle/codeql-bundle-v2.17.6</li>
<li><a href="a32d3058b89ccc99508a9b7c22c3b3https://redirect.github.com/github/codeql-action/issues/2351 ">#2351</a> from github/dependabot/npm_and_yarn/npm-6791eaa26c</li>
<li><a href="9cf3243b0b1895b29ac89dcfde966d8723b5be41https://redirect.github.com/github/codeql-action/issues/2350 ">#2350</a> from github/angelapwen/add-exclude-pr-check-param</li>
<li>Additional commits viewable in <a href="23acc5c183...b611370bb5https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.25.10&new-version=3.25.11 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-07-02 06:03:22 +00:00
dependabot[bot]
2888ed4faf
Bump google/osv-scanner-action from 1.7.4 to 1.8.1 ( flutter/engine#53677 )
...
Bumps [google/osv-scanner-action](https://github.com/google/osv-scanner-action ) from 1.7.4 to 1.8.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="3c399db9ddhttps://redirect.github.com/google/osv-scanner-action/issues/29 ">#29</a> from google/update-to-v1.8.1</li>
<li><a href="3ea235ac686d2b388dfdcd72c04b43f0e45d2960https://redirect.github.com/google/osv-scanner-action/issues/19 ">#19</a>)</li>
<li><a href="f92c263791https://redirect.github.com/google/osv-scanner-action/issues/25 ">#25</a>)</li>
<li>See full diff in <a href="https://github.com/google/osv-scanner-action/compare/v1.7.4...v1.8.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-07-02 05:57:23 +00:00
skia-flutter-autoroll
7b21eea826
Roll Skia from 8375bdc6e191 to d7a9375e86c1 (1 revision) ( flutter/engine#53676 )
...
https://skia.googlesource.com/skia.git/+log/8375bdc6e191..d7a9375e86c1
2024-07-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 7a9c12078546 to 49474af63de0 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 05:46:26 +00:00
Robert Ancell
e3b2d11dba
Restore creation of engine before Linux widget is realized. ( flutter/engine#53604 )
...
Due to changes in the renderer in fc560d4 the engine was created once a
widget is realized, not when the widget is created. If a Flutter
application changed the default my_application.cc template to show the
Flutter widget after plugins are run then these plugins would not be
able to access the engine.
Solved by removing the GdkWindow from the renderer constructor and
setting in later when the widget is realized. This works because the
renderer is not used until the widget is realized.
Fixes https://github.com/flutter/flutter/issues/144873
2024-07-02 17:18:07 +12:00
skia-flutter-autoroll
8998424bbc
Manual roll ICU from 98f2494518c2 to 43953f57b037 (1 revision) ( flutter/engine#53675 )
...
Manual roll requested by fmil@google.com
98f2494518..43953f57b0dayeung@chromium.org Fix a crash in locid.cpp.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC fmil@google.com ,fuchsia-ui-discuss@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 03:47:25 +00:00
auto-submit[bot]
10ed9bfd7a
Reverts "Output .js files as ES6 modules. ( #52023 )" ( flutter/engine#53674 )
...
Reverts: flutter/engine#52023
Initiated by: eyebrowsoffire
Reason for reverting: Causing issues in engine -> framework roll https://github.com/flutter/flutter/pull/151139
Original PR Author: eyebrowsoffire
Reviewed By: {ditman}
This change reverts the following previous change:
This changes CanvasKit and Skwasm to be compiled and loaded as ES6 modules instead of as vanilla script tags. Currently, the emscripten JS files try to register themselves with require.js or AMD module loading systems. We suspect this is causing issues (https://github.com/flutter/flutter/issues/149565 ) with DDC's module loading system, which itself uses require.js.
This is probably also the fix for https://github.com/flutter/flutter/issues/147731
2024-07-01 23:19:48 +00:00
skia-flutter-autoroll
e72254a08d
Roll Dart SDK from 21c08743ee4a to c23e58143793 (1 revision) ( flutter/engine#53670 )
...
https://dart.googlesource.com/sdk.git/+log/21c08743ee4a..c23e58143793
2024-07-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-321.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-01 22:27:35 +00:00
skia-flutter-autoroll
de64eb5cc3
Roll Skia from ae2b97d74812 to 8375bdc6e191 (3 revisions) ( flutter/engine#53669 )
...
https://skia.googlesource.com/skia.git/+log/ae2b97d74812..8375bdc6e191
2024-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4a2ff9e87700 to bbcdf62c225f (1 revision)
2024-07-01 armansito@google.com Roll vello 6938a2893d..3ee3bea021
2024-07-01 brianosman@google.com Revert "SkSLTest: Disable SwizzleIndexStore test on Samsung GPU"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-01 20:23:05 +00:00
Jackson Gardner
c91612ce11
Output .js files as ES6 modules. ( flutter/engine#52023 )
...
This changes CanvasKit and Skwasm to be compiled and loaded as ES6 modules instead of as vanilla script tags. Currently, the emscripten JS files try to register themselves with require.js or AMD module loading systems. We suspect this is causing issues (https://github.com/flutter/flutter/issues/149565 ) with DDC's module loading system, which itself uses require.js.
This is probably also the fix for https://github.com/flutter/flutter/issues/147731
2024-07-01 20:17:17 +00:00
skia-flutter-autoroll
86419809bb
Roll Skia from a62bf018429c to ae2b97d74812 (3 revisions) ( flutter/engine#53668 )
...
https://skia.googlesource.com/skia.git/+log/a62bf018429c..ae2b97d74812
2024-07-01 johnstiles@google.com Fix signedness of format string.
2024-07-01 brianosman@google.com Use LoadLibraryExW when loading system DLLs
2024-07-01 robertphillips@google.com [graphite] Reorganize code for public PrecompileImageFilter API
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-01 18:59:50 +00:00
Filip Filmar
06414a6725
[icu] Ignores the dir flutter/third_party/icu/patches ( flutter/engine#53667 )
...
This directory consistes of patches that Chromium's maintainers of the Chromium ICU fork have already applied to the ICU source code.
Usually these are fix-forwards that have been applied to the ICU library after it has been released.
The patch files are kept to ensure that the patches are applied if we ever need to create a new branch, or update the major ICU version.
The patch files specifically do *not* get used during the build process.
Issues: https://github.com/flutter/flutter/issues/151116
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-07-01 18:38:55 +00:00
Jonah Williams
aa7bf16b06
[Impeller] track the sizes of all outstanding MTLTexture allocations and report per frame in MB, matching Vulkan implementation. ( flutter/engine#53618 )
...
Does what it says!
Fixes https://github.com/flutter/flutter/issues/150936
2024-07-01 17:52:50 +00:00
skia-flutter-autoroll
5619a898c9
Roll Dart SDK from 338c6d4fd9c5 to 21c08743ee4a (1 revision) ( flutter/engine#53666 )
...
https://dart.googlesource.com/sdk.git/+log/338c6d4fd9c5..21c08743ee4a
2024-07-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-320.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-01 17:50:56 +00:00
skia-flutter-autoroll
4f68a687e3
Roll Skia from a67a67b7452b to a62bf018429c (2 revisions) ( flutter/engine#53665 )
...
https://skia.googlesource.com/skia.git/+log/a67a67b7452b..a62bf018429c
2024-07-01 brianosman@google.com Update etc1 README.google
2024-07-01 w2284938880@gmail.com Fix a spelling error in the document
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-01 17:40:16 +00:00
skia-flutter-autoroll
f6df3cf64d
Roll Skia from 8af866a56bce to a67a67b7452b (1 revision) ( flutter/engine#53664 )
...
https://skia.googlesource.com/skia.git/+log/8af866a56bce..a67a67b7452b
2024-07-01 kjlubick@google.com Remove assert of extensions from VulkanMemoryAllocators::Make
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-01 15:16:34 +00:00
skia-flutter-autoroll
77512d600b
Roll Fuchsia Linux SDK from DSPuQ9O6WejkIBUUh... to LkXpxHsQlkPT4mmJ7... ( flutter/engine#53663 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-01 08:51:33 +00:00
skia-flutter-autoroll
88290a1404
Roll Skia from e27104eaef37 to 8af866a56bce (4 revisions) ( flutter/engine#53661 )
...
https://skia.googlesource.com/skia.git/+log/e27104eaef37..8af866a56bce
2024-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e86ba9abe996 to 4f23429a1f09 (2 revisions)
2024-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ca190d337809 to 4a070666bf8e
2024-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 773555d3bd22 to 4a2ff9e87700 (1 revision)
2024-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 40eb79dec2d6 to ca190d337809 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-01 08:08:20 +00:00
skia-flutter-autoroll
f8670f49eb
Roll Skia from 34be7c830184 to e27104eaef37 (1 revision) ( flutter/engine#53659 )
...
https://skia.googlesource.com/skia.git/+log/34be7c830184..e27104eaef37
2024-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 66b3d4eee7e4 to 7a9c12078546 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-01 06:01:24 +00:00
skia-flutter-autoroll
f064220820
Roll Dart SDK from ab6a48438e07 to 338c6d4fd9c5 (1 revision) ( flutter/engine#53658 )
...
https://dart.googlesource.com/sdk.git/+log/ab6a48438e07..338c6d4fd9c5
2024-07-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-319.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-01 02:15:06 +00:00
skia-flutter-autoroll
1824412699
Roll Fuchsia Linux SDK from zU9wwHk8Oji6pArmw... to DSPuQ9O6WejkIBUUh... ( flutter/engine#53657 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-30 07:36:28 +00:00
skia-flutter-autoroll
0ca12dbe43
Roll Dart SDK from e1e2b16d509b to ab6a48438e07 (1 revision) ( flutter/engine#53655 )
...
https://dart.googlesource.com/sdk.git/+log/e1e2b16d509b..ab6a48438e07
2024-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-318.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-29 13:46:21 +00:00
skia-flutter-autoroll
50788b9cf8
Roll Skia from 2df28ce437cc to 34be7c830184 (1 revision) ( flutter/engine#53654 )
...
https://skia.googlesource.com/skia.git/+log/2df28ce437cc..34be7c830184
2024-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 9281ee0a120f to 66b3d4eee7e4 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-29 13:44:14 +00:00
skia-flutter-autoroll
9994664a90
Roll Skia from bc0e9542ce83 to 2df28ce437cc (1 revision) ( flutter/engine#53652 )
...
https://skia.googlesource.com/skia.git/+log/bc0e9542ce83..2df28ce437cc
2024-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 544502230988 to 773555d3bd22 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-29 11:14:31 +00:00
skia-flutter-autoroll
78d3124695
Roll Fuchsia Linux SDK from H_P7EHb4zXXV-Eiik... to zU9wwHk8Oji6pArmw... ( flutter/engine#53649 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-29 06:21:07 +00:00
David Iglesias
1b37c5441c
[web] Fixes drag scrolling in embedded mode. ( flutter/engine#53647 )
...
When Flutter web runs embedded in a page, scrolling by dragging is interrupted very early by the browser.
It turns out that our `pointer` events receive a `pointercancel` + `pointerleave` by the browser because they happen in an area (the flutter glasspane) that is not really scrollable. [See documentation](https://developer.mozilla.org/en-US/docs/Web/API/Element/pointercancel_event ).
> [!NOTE]
> After the pointercancel event is fired, the browser will also send [pointerout](https://developer.mozilla.org/en-US/docs/Web/API/Element/pointerout_event ) followed by [pointerleave](https://developer.mozilla.org/en-US/docs/Web/API/Element/pointerleave_event ).
(Firefox is a good browser to test this, because the browser will cancel our events **only if there's scrollable areas around the embedded flutter app**.)
There's several solutions, but one of them (used by PixiJS as well) is to cancel the `touchstart` event that fires with the `pointerdown` event.
(This PR also removes an unnecessary call to `addEventListener` in the `Listener` helper class, and adds some testing to it).
## Testing
* Added a happy case test for the fix (preventDefault on 'touchstart' events)
* Deployed demo app here: https://dit-multiview-scroll.web.app
## Issues
* Fixes https://github.com/flutter/flutter/issues/138985
* Fixes https://github.com/flutter/flutter/issues/146732
* Related to https://github.com/flutter/flutter/issues/139263
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-06-29 03:47:25 +00:00
skia-flutter-autoroll
d833c35591
Roll Dart SDK from 160ace00da8a to e1e2b16d509b (1 revision) ( flutter/engine#53646 )
...
https://dart.googlesource.com/sdk.git/+log/160ace00da8a..e1e2b16d509b
2024-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-317.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-29 02:15:21 +00:00
skia-flutter-autoroll
e311a7ec51
Roll Skia from 1ad84eb8e94f to bc0e9542ce83 (1 revision) ( flutter/engine#53644 )
...
https://skia.googlesource.com/skia.git/+log/1ad84eb8e94f..bc0e9542ce83
2024-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6583f5d23919 to 544502230988 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 22:06:23 +00:00
skia-flutter-autoroll
30b64f09ca
Roll Dart SDK from 89b164e3adeb to 160ace00da8a (1 revision) ( flutter/engine#53643 )
...
https://dart.googlesource.com/sdk.git/+log/89b164e3adeb..160ace00da8a
2024-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-316.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 22:01:02 +00:00
Yegor
c5a8a826ef
[web] switch from .didGain/LoseAccessibilityFocus to .focus ( flutter/engine#53360 )
...
This is a repeat of https://github.com/flutter/engine/pull/53134 , which was merged prematurely.
> [!WARNING]
> Only land this after:
> * https://github.com/flutter/flutter/pull/149840 lands in the framework.
> * You have personally manually tested the change together with the latest framework on all browsers.
## Original PR description
Stop using `SemanticsAction.didGain/LoseAccessibilityFocus` on the web, start using `SemanticsAction.focus`. This is because on the web, a11y focus is not observable, only input focus is. Sending `SemanticsAction.focus` will guarantee that the framework move focus to the respective widget. There currently is no "unfocus" signal, because it seems to be already covered: either another widget gains focus, or an HTML DOM element outside the Flutter view does, both of which have their respective signals already.
More details in the discussion in the issue https://github.com/flutter/flutter/issues/83809 .
Fixes https://github.com/flutter/flutter/issues/83809
Fixes https://github.com/flutter/flutter/issues/148285
Fixes https://github.com/flutter/flutter/issues/143337
2024-06-28 21:35:10 +00:00
Jim Graham
54c6058748
Reland [DisplayList] Add support for clipOval to leverage Impeller optimization ( flutter/engine#53642 )
...
Reland of https://github.com/flutter/engine/pull/53622 that checks the inverse fill flag of the paths.
2024-06-28 20:52:21 +00:00
Jonah Williams
d152d7632f
[Impeller] experimental canvas bdf support. ( flutter/engine#53597 )
...
Almost working bdf for experimentcal canvas.
Currently there are some problems with the clip depth, and positioning of the backdrop filter. I think I am not taking the blur transform into account at the very least.
FYI @bdero
2024-06-28 20:42:07 +00:00
skia-flutter-autoroll
59af5f6b64
Roll Skia from fc6f00bfacb5 to 1ad84eb8e94f (2 revisions) ( flutter/engine#53641 )
...
https://skia.googlesource.com/skia.git/+log/fc6f00bfacb5..1ad84eb8e94f
2024-06-28 jvanverth@google.com [graphite] Fix color text rendering, part 1.
2024-06-28 kjlubick@google.com Add jobs for Galaxy S24
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 20:40:00 +00:00
skia-flutter-autoroll
76f191ea13
Roll Skia from 3d5f5d546fb6 to fc6f00bfacb5 (1 revision) ( flutter/engine#53637 )
...
https://skia.googlesource.com/skia.git/+log/3d5f5d546fb6..fc6f00bfacb5
2024-06-28 sunnyps@chromium.org graphite: Expose maxTextureSize on Recorder
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 18:15:23 +00:00
skia-flutter-autoroll
244cd5d0e6
Roll Dart SDK from 341dbaf977a3 to 89b164e3adeb (2 revisions) ( flutter/engine#53636 )
...
https://dart.googlesource.com/sdk.git/+log/341dbaf977a3..89b164e3adeb
2024-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-315.0.dev
2024-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-314.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 17:50:03 +00:00
skia-flutter-autoroll
fdf2b36cbf
Roll Skia from 7a09d38fa7f8 to 3d5f5d546fb6 (1 revision) ( flutter/engine#53634 )
...
https://skia.googlesource.com/skia.git/+log/7a09d38fa7f8..3d5f5d546fb6
2024-06-28 kjlubick@google.com Delete unnecessary file
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 17:00:57 +00:00
skia-flutter-autoroll
8611c7274f
Roll Skia from 23a14cccc800 to 7a09d38fa7f8 (1 revision) ( flutter/engine#53633 )
...
https://skia.googlesource.com/skia.git/+log/23a14cccc800..7a09d38fa7f8
2024-06-28 michaelludwig@google.com [graphite] Consolidate expression/preamble generators
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 15:44:20 +00:00
skia-flutter-autoroll
66c2091121
Roll Skia from cd77153f20a8 to 23a14cccc800 (1 revision) ( flutter/engine#53631 )
...
https://skia.googlesource.com/skia.git/+log/cd77153f20a8..23a14cccc800
2024-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 40eb79dec2d6 to 5ae05e0e6a28
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 13:20:24 +00:00
Jim Graham
86ee502292
Revert "[DisplayList] Add support for clipOval to leverage Impeller optimization" ( flutter/engine#53629 )
...
Reverts flutter/engine#53622
There were some golden changes which might be minor, but they weren't expected. Also, I noticed a problem in reducing drawPath down to drawRect and drawOval - that should not be done if the path has the inverse fill flag set...
2024-06-28 11:07:21 +00:00
skia-flutter-autoroll
61dd39b2f8
Roll Dart SDK from 4005e5f1fb8e to 341dbaf977a3 (1 revision) ( flutter/engine#53630 )
...
https://dart.googlesource.com/sdk.git/+log/4005e5f1fb8e..341dbaf977a3
2024-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-313.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 10:55:38 +00:00
skia-flutter-autoroll
784caeb97a
Roll Skia from 6650fcc6d054 to cd77153f20a8 (1 revision) ( flutter/engine#53628 )
...
https://skia.googlesource.com/skia.git/+log/6650fcc6d054..cd77153f20a8
2024-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 117f1e2fcf1c to 6583f5d23919 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 10:49:36 +00:00
skia-flutter-autoroll
1b952e7807
Roll Skia from 2204428a75ca to 6650fcc6d054 (2 revisions) ( flutter/engine#53627 )
...
https://skia.googlesource.com/skia.git/+log/2204428a75ca..6650fcc6d054
2024-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 46dd6457f4bf to e86ba9abe996 (5 revisions)
2024-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 79660091faba to 40eb79dec2d6 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 08:23:39 +00:00
skia-flutter-autoroll
4a2783955d
Roll Dart SDK from 0820b0766ac9 to 4005e5f1fb8e (1 revision) ( flutter/engine#53626 )
...
https://dart.googlesource.com/sdk.git/+log/0820b0766ac9..4005e5f1fb8e
2024-06-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-312.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 06:02:10 +00:00
skia-flutter-autoroll
5d0988e485
Roll Skia from 1700e3962acd to 2204428a75ca (1 revision) ( flutter/engine#53625 )
...
https://skia.googlesource.com/skia.git/+log/1700e3962acd..2204428a75ca
2024-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 0a3b1b98cce7 to 9281ee0a120f (15 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 05:54:23 +00:00
skia-flutter-autoroll
9a4788d6b1
Roll Fuchsia Linux SDK from gBWzGuicxu76K82lg... to H_P7EHb4zXXV-Eiik... ( flutter/engine#53624 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 05:06:54 +00:00
