firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,844 Commits 1 Branch 0 Tags
Commit Graph

37844 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
4d14f8631b Roll Dart SDK from 902494bb4c8b to 94ae91747a0b (1 revision) (flutter/engine#55712) 
https://dart.googlesource.com/sdk.git/+log/902494bb4c8b..94ae91747a0b

2024-10-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-328.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 21:16:21 +00:00
skia-flutter-autoroll
9366a74fb8 Roll Skia from 6afbd6253e66 to d0e49fde3765 (4 revisions) (flutter/engine#55710) 
https://skia.googlesource.com/skia.git/+log/6afbd6253e66..d0e49fde3765

2024-10-07 vigneshv@google.com Enable CrabbyAvif for Android framework
2024-10-07 bungeman@google.com [pdf] Spanify SkPDFTagNode::fChildren
2024-10-07 bungeman@google.com Migrate Debian 11 builders
2024-10-07 bungeman@google.com Allow SkSpan<T> declarations with incomplete T

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 20:51:54 +00:00
gaaclarke
96b0bf0ce3 Speculative fix for memory issues related to retrying image decompression (flutter/engine#55704) 
b/371512414

This issue had no reproduction but the stacktrace was provided.  The theory of this fix is that the `ImageResult` type is capturing something that doesn't handle being copied and deallocated twice so instead of copying it, we std::move it into a shared_ptr so that it will only be deallocated once.

Also, I just avoid using a `std::move` when overflowing.  The idea here is maybe sometimes deleting the std::move'd item isn't kosher.  We know from the stacktrace that it has something to do with overflowing because that would be the only case where something is being deleted.

I've added 2 integration tests that exercises the code where the crash appears to be happening.  This is good coverage to have but neither of them reproduced the issue, even with MallocScribble enabled.  That's the best we can do without a reproduction.

```
Thread 7  (id: 0x0000a103)crashed
0x000000010a48ae8c(Flutter -function.h)std::_fl::allocator<impeller::ContextMTL::PendingTasks>::destroy[abi:v15000](impeller::ContextMTL::PendingTasks*)
0x000000010a48b9fc(Flutter -allocator_traits.h:309)impeller::ContextMTL::StoreTaskForGPU(std::_fl::function<void ()> const&, std::_fl::function<void ()> const&)
0x000000010a48b9fc(Flutter -allocator_traits.h:309)impeller::ContextMTL::StoreTaskForGPU(std::_fl::function<void ()> const&, std::_fl::function<void ()> const&)
0x000000010a4d49e4(Flutter -image_decoder_impeller.cc:422)std::_fl::__function::__func<flutter::ImageDecoderImpeller::UploadTextureToPrivate(std::_fl::function<void (sk_sp<flutter::DlImage>, std::_fl::basic_string<char, std::_fl::char_traits<char>, std::_fl::allocator<char>>)>, std::_fl::shared_ptr<impeller::Context> const&, std::_fl::shared_ptr<impeller::DeviceBuffer> const&, SkImageInfo const&, std::_fl::shared_ptr<SkBitmap> const&, std::_fl::optional<SkImageInfo> const&, std::_fl::shared_ptr<fml::SyncSwitch> const&)::$_1, std::_fl::allocator<flutter::ImageDecoderImpeller::UploadTextureToPrivate(std::_fl::function<void (sk_sp<flutter::DlImage>, std::_fl::basic_string<char, std::_fl::char_traits<char>, std::_fl::allocator<char>>)>, std::_fl::shared_ptr<impeller::Context> const&, std::_fl::shared_ptr<impeller::DeviceBuffer> const&, SkImageInfo const&, std::_fl::shared_ptr<SkBitmap> const&, std::_fl::optional<SkImageInfo> const&, std::_fl::shared_ptr<fml::SyncSwitch> const&)::$_1>, void ()>::operator()()
0x000000010a06c234(Flutter -function.h:512)fml::SyncSwitch::Execute(fml::SyncSwitch::Handlers const&) const
0x000000010a4d42f8(Flutter -image_decoder_impeller.cc:408)flutter::ImageDecoderImpeller::UploadTextureToPrivate(std::_fl::function<void (sk_sp<flutter::DlImage>, std::_fl::basic_string<char, std::_fl::char_traits<char>, std::_fl::allocator<char>>)>, std::_fl::shared_ptr<impeller::Context> const&, std::_fl::shared_ptr<impeller::DeviceBuffer> const&, SkImageInfo const&, std::_fl::shared_ptr<SkBitmap> const&, std::_fl::optional<SkImageInfo> const&, std::_fl::shared_ptr<fml::SyncSwitch> const&)
0x000000010a4d3838(Flutter -image_decoder_impeller.cc:538)std::_fl::__function::__func<flutter::ImageDecoderImpeller::Decode(fml::RefPtr<flutter::ImageDescriptor>, unsigned int, unsigned int, std::_fl::function<void (sk_sp<flutter::DlImage>, std::_fl::basic_string<char, std::_fl::char_traits<char>, std::_fl::allocator<char>>)> const&)::$_1, std::_fl::allocator<flutter::ImageDecoderImpeller::Decode(fml::RefPtr<flutter::ImageDescriptor>, unsigned int, unsigned int, std::_fl::function<void (sk_sp<flutter::DlImage>, std::_fl::basic_string<char, std::_fl::char_traits<char>, std::_fl::allocator<char>>)> const&)::$_1>, void ()>::operator()()
0x000000010a06dd1c(Flutter -function.h:512)fml::ConcurrentMessageLoopDarwin::ExecuteTask(std::_fl::function<void ()> const&)
0x000000010a06737c(Flutter -concurrent_message_loop.cc:101)void* std::_fl::__thread_proxy[abi:v15000]<std::_fl::tuple<std::_fl::unique_ptr<std::_fl::__thread_struct, std::_fl::default_delete<std::_fl::__thread_struct>>, fml::ConcurrentMessageLoop::ConcurrentMessageLoop(unsigned long)::$_0>>(void*)
0x000000021d4ff378(libsystem_pthread.dylib + 0x00006378)_pthread_start
```

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-07 20:46:16 +00:00
Jonah Williams
3f50f56235 [Impeller] disable surface control on API 29. (flutter/engine#55708) 
Fixes https://github.com/flutter/flutter/issues/155877

Technically SurfaceControl is supported on API 29 but I've observed enough reported bugs that I'm bumping the constraint to 30. If  we had more time to test all of these older devices maybe we could figure out if the problem is something that can be worked around.
 2024-10-07 20:10:16 +00:00
Jonah Williams
086e6a63f5 [Impeller] remove Vulkan command encoder abstraction, use command buffer vk. (flutter/engine#55680) 
The Vulkan command buffer wrapper delegates almost all of its functionality to the "CommandEncoderVK". I did not find that this separation was useful, as they have a 1-1 relationship and an identical lifecycle. Lets combine them to reduce the number of things to worry about.
 2024-10-07 19:52:55 +00:00
Jonah Williams
b4d91f9d68 [Impeller] add parsing of known GPU models (flutter/engine#55196) 
We will need to denylist certain Vulkan drivers. This is easier to do if we have some mechanism of determining which GPU model we're currently using. This doesn't add any new denylisting, it just ads a mechanism to parse the driver name into an enum. I mean, there are only so many SoCs, right?

See also https://github.com/flutter/flutter/issues/155185
 2024-10-07 19:18:03 +00:00
Justin McCandless
d24bc5a0ef Path clarification in Setting-up-the-Engine-development-environment.md (flutter/engine#55529) 
I thought that this was referring to the flutter/flutter repo, but it's actually in flutter/engine/src/flutter/bin. Updated to clarify.
 2024-10-07 18:16:04 +00:00
skia-flutter-autoroll
9b197d6b75 Roll Skia from 89284b1d7eeb to 6afbd6253e66 (2 revisions) (flutter/engine#55702) 
https://skia.googlesource.com/skia.git/+log/89284b1d7eeb..6afbd6253e66

2024-10-07 kjlubick@google.com Add compile-check for SkImage::RequiredProperties being a map key
2024-10-07 jvanverth@google.com [graphite] Correct sort order when using analytic and shader clips.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 17:40:00 +00:00
skia-flutter-autoroll
33ca2cbbb3 Roll Dart SDK from 5e6945a72200 to 902494bb4c8b (1 revision) (flutter/engine#55700) 
https://dart.googlesource.com/sdk.git/+log/5e6945a72200..902494bb4c8b

2024-10-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-327.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 17:05:20 +00:00
Chris Bracken
773c37ab82 Revert "iOS: Migrate FlutterEngine to ARC (#55590)" (flutter/engine#55699) 
Causing flakes on the _Mac mac_unopt (Cocoon)_ shard.

This reverts commit a2ac734e10115547d8c8ef34610ea6172e3cc98b.

Issue: https://github.com/flutter/flutter/issues/156177

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-07 16:29:24 +00:00
John McDole
342fc504a2 La Grande Fusion Notes - History Editing (flutter/engine#55667) 
AKA "Dude Where's My Files?"

Document the history editing that will occur during the monorepo merge.
`flutter/engine` will remain the source of truth of revisions older than
the merge.

---------

Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
 2024-10-07 09:13:46 -07:00
skia-flutter-autoroll
d580c10611 Roll Skia from 52155a48ff8d to 89284b1d7eeb (3 revisions) (flutter/engine#55697) 
https://skia.googlesource.com/skia.git/+log/52155a48ff8d..89284b1d7eeb

2024-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cd7f294923c7 to aacbf041f6cd (18 revisions)
2024-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 015479b2afc8 to 73d05ecd42e4 (12 revisions)
2024-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f8d389436d22 to 90b955a8bf93 (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 14:33:23 +00:00
skia-flutter-autoroll
ec02ceaeee Roll Fuchsia Linux SDK from h5VOYlPZ-2eCtUR_z... to TTSSw-kHM8_h_tdX0... (flutter/engine#55692) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 07:23:05 +00:00
skia-flutter-autoroll
eae88c4c09 Roll Skia from c3ff0dfeae73 to 52155a48ff8d (1 revision) (flutter/engine#55688) 
https://skia.googlesource.com/skia.git/+log/c3ff0dfeae73..52155a48ff8d

2024-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cfe779d31eee to dd729cf1f807 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-07 04:49:23 +00:00
skia-flutter-autoroll
4bf0a8203a Roll Skia from 6696c34a6816 to c3ff0dfeae73 (1 revision) (flutter/engine#55683) 
https://skia.googlesource.com/skia.git/+log/6696c34a6816..c3ff0dfeae73

2024-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 63d60d4b27f3 to cfe779d31eee (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-06 18:29:23 +00:00
skia-flutter-autoroll
f21edd831a Roll Skia from 702044e777a3 to 6696c34a6816 (1 revision) (flutter/engine#55681) 
https://skia.googlesource.com/skia.git/+log/702044e777a3..6696c34a6816

2024-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0f0002bea54e to 63d60d4b27f3 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-06 02:09:22 +00:00
skia-flutter-autoroll
233629fb66 Roll Fuchsia Linux SDK from Izy4D5DB98t46Zoh9... to h5VOYlPZ-2eCtUR_z... (flutter/engine#55678) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-05 22:01:36 +00:00
skia-flutter-autoroll
9ff3508189 Roll Skia from 9145d1ef9638 to 702044e777a3 (1 revision) (flutter/engine#55675) 
https://skia.googlesource.com/skia.git/+log/9145d1ef9638..702044e777a3

2024-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 31bccb45ea33 to 0f0002bea54e (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-05 09:50:40 +00:00
skia-flutter-autoroll
bf099905d2 Roll Dart SDK from 9aa80e32947d to 5e6945a72200 (1 revision) (flutter/engine#55674) 
https://dart.googlesource.com/sdk.git/+log/9aa80e32947d..5e6945a72200

2024-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-326.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-05 07:18:23 +00:00
Jim Graham
ab7af6ffb2 Honor blur tile mode in BackdropFilter widget on Skia backend (flutter/engine#55640) 
The blur ImageFilter has a tile mode that describes how to sample pixels near the edge of the source. When used as a BackdropFilter this behavior is important as the wrong tile mode can cause distracting flashing as app content is scrolled under foreground widgets that blur their background. Unfortunately the Skia backend used to default the tile mode for all backdrop filters to `clamp` mode with no way to update it and that mode was the one that produced the most distracting flashing.

Recently Skia opened up control over the tile mode used for backdrop filters and we now take advantage of that capability so that app developers can now set the tile mode to a nicer value.
 2024-10-05 04:58:30 +00:00
Jonah Williams
fd33d17487 [Impeller] remove aiks color_filter and image_filter types. (flutter/engine#55654) 
Like the color_source, these classes are just copies of the DL types. Use the DLTypes instead.

Part of https://github.com/flutter/flutter/issues/142054
 2024-10-05 04:32:08 +00:00
skia-flutter-autoroll
248c2a7062 Roll Dart SDK from c1c971fd1b94 to 9aa80e32947d (1 revision) (flutter/engine#55673) 
https://dart.googlesource.com/sdk.git/+log/c1c971fd1b94..9aa80e32947d

2024-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-325.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-05 03:10:09 +00:00
Brandon DeRosier
3b3ffcb8cd [Flutter GPU] Add WindingOrder. (flutter/engine#55413) 
Resolves https://github.com/flutter/flutter/issues/155636.

(Extends test in https://github.com/flutter/engine/pull/55409)
 2024-10-05 02:04:04 +00:00
Jonah Williams
767efe1ad7 [Impeller] remove usage of MaxBasisLength in favor of XY variant. (flutter/engine#55670) 
MaxBasisXYZ prevents usage of scaling factors less than one since Z is almost always 1.

Fixes https://github.com/flutter/flutter/issues/153451
 2024-10-05 00:16:37 +00:00
skia-flutter-autoroll
e1473c81a4 Roll Dart SDK from ecba03620fc8 to c1c971fd1b94 (2 revisions) (flutter/engine#55668) 
https://dart.googlesource.com/sdk.git/+log/ecba03620fc8..c1c971fd1b94

2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-324.0.dev
2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-323.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 22:33:19 +00:00
John McCutchan
1e3d251560 Add --rbe-force-local flag to force rbe task execution to happen on the local machine (flutter/engine#55635) 
`build`, `test`, and `run` commands all support the `--exec-strategy`
flag ('auto', 'local', 'remote').

This flag controls the RBE task execution strategy (when RBE is
enabled).

Closes #150877
 2024-10-04 14:59:37 -07:00
skia-flutter-autoroll
8b54d8e12f Roll Skia from 4aff9603622d to 9145d1ef9638 (2 revisions) (flutter/engine#55665) 
https://skia.googlesource.com/skia.git/+log/4aff9603622d..9145d1ef9638

2024-10-04 michaelludwig@google.com [graphite] Minor fixes to PaintParamsKey dumping/labels
2024-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from db76988ee4a3 to 31bccb45ea33 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 21:21:22 +00:00
Matan Lurey
9f49c8f4e3 Add support for et test //flutter/path/to/dart_test (flutter/engine#55638) 
Closes https://github.com/flutter/flutter/issues/147013.
Closes https://github.com/flutter/flutter/issues/147071.

/cc @reidbaker who I know wants to do this for the Java rules soon TM.
/cc @jtmcdole, @zanderso for visibility.
 2024-10-04 13:55:27 -07:00
Jim Graham
7f99da5b92 [Impeller] Use a squircle-sdf-based algorithm for fast blurs (flutter/engine#55604) 
Use a Squircle Signed Distance Field based algorithm to do a very fast approximation of rrect blurs.

This PR is to provide reference within the team to discuss the future of the algorithm compared to the Gaussian approximation functions that are currently in use. It isn't a complete solution, but can be completed easily with a little more work.

Notably, it doesn't handle elliptical round rects, only circular corners.
Could stand to include an attribution to the source (https://raphlinus.github.io/graphics/2020/04/21/blurred-rounded-rects.html)
 2024-10-04 20:24:15 +00:00
skia-flutter-autoroll
8973b6e97a Roll Skia from 59f512b47cc0 to 4aff9603622d (1 revision) (flutter/engine#55663) 
https://skia.googlesource.com/skia.git/+log/59f512b47cc0..4aff9603622d

2024-10-04 jamesgk@google.com [graphite] Use Dawn limits for buffer alignment caps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 19:51:05 +00:00
skia-flutter-autoroll
39ee68d618 Roll Fuchsia Linux SDK from TnSpLq0S9XT2rHGl1... to Izy4D5DB98t46Zoh9... (flutter/engine#55662) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 19:43:22 +00:00
skia-flutter-autoroll
49a546db67 Roll Skia from e8e0a8c46345 to 59f512b47cc0 (3 revisions) (flutter/engine#55660) 
https://skia.googlesource.com/skia.git/+log/e8e0a8c46345..59f512b47cc0

2024-10-04 danieldilan@google.com Reland "Write test for platform image generators."
2024-10-04 cwallez@chromium.org Remove wgpu::FeatureName::SurfaceCapabilities
2024-10-04 kjlubick@google.com Enforce IWYU on graphite's compute and render subdirectories

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 18:31:36 +00:00
Jonah Williams
9d8929af60 [Impeller] generate mipmaps for toImage. (flutter/engine#55655) 
Fixes https://github.com/flutter/flutter/issues/156161

Mips must be eagerly generated for Picture.toImage and friends so that filter quality (mip sampling) works as expected.
 2024-10-04 17:49:55 +00:00
Chris Bracken
a2ac734e10 iOS: Migrate FlutterEngine to ARC (flutter/engine#55590) 
Migrates `FlutterEnging` from manual reference counting to ARC. Migrates properties from `retain` to strong and `assign` to `weak` (where referencing an Obj-C object).

No semantic changes, therefore no changes to tests.

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-04 15:00:30 +00:00
skia-flutter-autoroll
e1a8f27e21 Roll Skia from 0dfa080b5d71 to e8e0a8c46345 (1 revision) (flutter/engine#55652) 
https://skia.googlesource.com/skia.git/+log/0dfa080b5d71..e8e0a8c46345

2024-10-04 cwallez@chromium.org WebGPU: Prepare for Dawn output struct WGPUStringView breaking change.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 14:44:22 +00:00
skia-flutter-autoroll
a67d772acb Roll Dart SDK from 750b6e44b765 to ecba03620fc8 (1 revision) (flutter/engine#55650) 
https://dart.googlesource.com/sdk.git/+log/750b6e44b765..ecba03620fc8

2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-322.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 14:12:06 +00:00
skia-flutter-autoroll
d4e4693b76 Roll Dart SDK from b96383c6bddd to 750b6e44b765 (3 revisions) (flutter/engine#55649) 
https://dart.googlesource.com/sdk.git/+log/b96383c6bddd..750b6e44b765

2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-321.0.dev
2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-320.0.dev
2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-319.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 10:06:40 +00:00
skia-flutter-autoroll
e42d01bc98 Roll Skia from cef6e8423365 to 0dfa080b5d71 (4 revisions) (flutter/engine#55648) 
https://skia.googlesource.com/skia.git/+log/cef6e8423365..0dfa080b5d71

2024-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6024e9c05548 to cd7f294923c7 (2 revisions)
2024-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 88a2d3572b41 to db76988ee4a3 (4 revisions)
2024-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3bf46a600a54 to 015479b2afc8 (16 revisions)
2024-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 72ca2005cd32 to 7a9a492a38b7 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 09:44:24 +00:00
skia-flutter-autoroll
e079bfc029 Roll Skia from e732cdf455c8 to cef6e8423365 (1 revision) (flutter/engine#55644) 
https://skia.googlesource.com/skia.git/+log/e732cdf455c8..cef6e8423365

2024-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 096f7148b5de to f8d389436d22 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 06:01:24 +00:00
Jonah Williams
959b7c6b60 [Impeller] clamp render target size at max texture size. (flutter/engine#55628) 
Part of https://github.com/flutter/flutter/issues/128912

If an intermediate render target would be larger than the max texture size, then clamp the texture.
 2024-10-04 03:39:14 +00:00
skia-flutter-autoroll
8571552076 Roll Skia from 379139f0bebe to e732cdf455c8 (11 revisions) (flutter/engine#55642) 
https://skia.googlesource.com/skia.git/+log/379139f0bebe..e732cdf455c8

2024-10-03 bungeman@google.com Remove initializer_list use from SkZip.h
2024-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 9edd74e2ff86 to 6024e9c05548 (7 revisions)
2024-10-03 jamesgk@google.com [graphite] Bring minimum uniform buffer size back down to 2kb
2024-10-03 michaelludwig@google.com Revert "Write test for platform image generators."
2024-10-03 danieldilan@google.com Write test for platform image generators.
2024-10-03 drott@chromium.org [Fontations-backend] Roll Fontations, Skrifa to 0.22.3
2024-10-03 lukasza@chromium.org [rust png] Hide stream from `SkCodec` parent class to prevent rewinding.
2024-10-03 nicolettep@google.com [graphite] Migrate dawn pipeline to consulting immutable sampler descriptions populated at graphite level
2024-10-03 robertphillips@google.com Reland "[ganesh] Add GrGLANGLEBackend::kVulkan"
2024-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d2712d5ff726 to 88a2d3572b41 (2 revisions)
2024-10-03 jamesgk@google.com [graphite] Avoid redundant de-duplication of uniform data

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 02:26:21 +00:00
Jonah Williams
1cdd8d06be [Impeller] remove aiks color_source. (flutter/engine#55603) 
Aiks color source is more or less a one to one copy of the impeller::DisplayListColorSource. We can rip it out, instead of flutter::DisplayList::ColorSource -> impeller::Aiks::ColorSource -> impelller:Entity::ColorSourceContents, just go directly flutter::DisplayList::ColorSource -> impelller:Entity::ColorSourceContents.

Part of https://github.com/flutter/flutter/issues/142054
 2024-10-04 02:20:33 +00:00
skia-flutter-autoroll
666a7b8747 Roll Dart SDK from 91d39199994c to b96383c6bddd (1 revision) (flutter/engine#55641) 
https://dart.googlesource.com/sdk.git/+log/91d39199994c..b96383c6bddd

2024-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-318.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-04 01:48:23 +00:00
Matan Lurey
92c9c99411 Add missing license headers to engine_tool. (flutter/engine#55636) 
Address post-submit feedback on https://github.com/flutter/engine/pull/55537#pullrequestreview-2346684376.
 2024-10-04 00:24:20 +00:00
Robert Ancell
971dbd79fb Refactor FlKeyboardHandler (flutter/engine#55601) 
Refactor FlKeyboardHandler to be more GObject and less C++.

Done as we will need to move the handler from FlView to FlEngine to
support multi-view.
 2024-10-04 12:00:00 +13:00
Matan Lurey
887fcf0563 Add and use a dart_test rule. (flutter/engine#55630) 
Work towards https://github.com/flutter/flutter/issues/147013.

I think I still need applicable metadata about the output, and then make
sure `et test` understands everything:

```sh
% et test //flutter/tools/engine_tool/...
[2024-10-03 13:26:42.657137] ERROR: No test targets found
```
 2024-10-03 14:41:25 -07:00
skia-flutter-autoroll
b0b41b90c6 Roll Dart SDK from 4c767e0fae21 to 91d39199994c (1 revision) (flutter/engine#55631) 
https://dart.googlesource.com/sdk.git/+log/4c767e0fae21..91d39199994c

2024-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-317.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-03 21:30:23 +00:00
Jonah Williams
0854e45692 [Impeller] ensure one AiksContext per app. (flutter/engine#55629) 
Reland of https://github.com/flutter/engine/pull/55393
 2024-10-03 20:54:04 +00:00
Chinmay Garde
592c393867 [Impeller] A text layout and shaping API for the standalone library. (flutter/engine#55598) 
This uses the same shaper as the rest of Flutter. The minimal ICU data configuration comes embedded in the dylib so there are no out-of-band packaging concerns.

<img width="1136" alt="Screenshot 2024-10-02 at 4 11 17 PM" src="https://github.com/user-attachments/assets/ce63dc99-7c3d-4b71-ac5d-926dffa5269b">

Fixes https://github.com/flutter/flutter/issues/156015
 2024-10-03 19:36:02 +00:00
Matan Lurey
6c9af1435d Refactor et run (and friends). (flutter/engine#55537) 
Does a few things:

- Refactors `run_command_test` significantly to reduce global fixtures
- Replaced stringly-typed things with enum-like objects
- Adds a lot stronger coverage for `run_command` to make future refactors safer
- Takes advantage of `package:test` having a workable matchers system and uses it
- Changes `return 1` into `throw FatalError(...)` where it makes sense in `run_command`

As a result of the refactoring work, I also fixed a bug: Closes https://github.com/flutter/flutter/issues/147646.
 2024-10-03 19:32:08 +00:00