firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,844 Commits 1 Branch 0 Tags
Commit Graph

37844 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
e0c85be826 Roll Skia from 44d45ac4de6f to 5fb36dd08a25 (5 revisions) (flutter/engine#55561) 
https://skia.googlesource.com/skia.git/+log/44d45ac4de6f..5fb36dd08a25

2024-10-01 danieldilan@google.com Optionally write the orientation when encoding a JPEG.
2024-10-01 robertphillips@google.com Reland "[graphite] Expand BlurMaskFilter Precompilation ..."
2024-10-01 drott@chromium.org [Fontations] Use Skrifa's NullPen instead of custom pen
2024-10-01 bungeman@google.com Emit StructElem ID only when referenced
2024-10-01 drott@chromium.org [Fontations-backend] Roll Fontations, Skrifa to 0.22.1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-01 16:36:06 +00:00
Matan Lurey
842e2fe8f1 Migrate off a global test fixture for build and lint. (flutter/engine#55540) 
Partial work towards https://github.com/flutter/flutter/issues/148420, unblocks https://github.com/flutter/engine/pull/55537.

These tests can now be more precise, and changing the fixtures no longer has side-effects on tests across the entire repository. There are about 11 other usages (there were ~50 in these) after this PR that I'll get to, as well as the hard-coded `gn desc` output, before retiring `fixtures.dart`
 2024-10-01 16:29:51 +00:00
Alexander Aprelev
bfd2fa3e8d Fix gen_dartcli_call in --no-prebuilt-dart-sdk. (flutter/engine#55558) 
Follow-up to https://github.com/flutter/engine/pull/55475

Test: `flutter/tools/gn --no-prebuilt-dart-sdk --unoptimized
--runtime-mode debug && ninja -C out/host_debug_unopt`
 2024-10-01 08:33:53 -07:00
skia-flutter-autoroll
347c1fc6a6 Roll Dart SDK from 23701722ca9e to 0e8b99c3154a (1 revision) (flutter/engine#55556) 
https://dart.googlesource.com/sdk.git/+log/23701722ca9e..0e8b99c3154a

2024-10-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-307.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-01 14:45:16 +00:00
skia-flutter-autoroll
da28ef4a0d Roll Skia from 5baca3730872 to 44d45ac4de6f (1 revision) (flutter/engine#55554) 
https://skia.googlesource.com/skia.git/+log/5baca3730872..44d45ac4de6f

2024-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cb6007a9d31d to fb8f0127fca4 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-01 13:12:52 +00:00
skia-flutter-autoroll
1ad3e88f82 Roll Skia from db59fb03ddd9 to 5baca3730872 (2 revisions) (flutter/engine#55553) 
https://skia.googlesource.com/skia.git/+log/db59fb03ddd9..5baca3730872

2024-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 7b0212b337ff to 572fd30ee239 (7 revisions)
2024-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a97dae4c20c1 to ff7821c285f9 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-01 11:48:05 +00:00
skia-flutter-autoroll
dfc27f23e9 Roll Dart SDK from bff9c6ff642d to 23701722ca9e (2 revisions) (flutter/engine#55551) 
https://dart.googlesource.com/sdk.git/+log/bff9c6ff642d..23701722ca9e

2024-10-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-306.0.dev
2024-10-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-305.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-01 10:27:11 +00:00
skia-flutter-autoroll
8d56ffab4c Roll Fuchsia Linux SDK from A8lL1H_6clgBKJXHK... to 8CL33jSvLCd1mPDg_... (flutter/engine#55549) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-01 08:33:24 +00:00
dependabot[bot]
72ed3a5b8c Bump actions/checkout from 4.1.7 to 4.2.0 (flutter/engine#55544) 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 4.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add Ref and Commit outputs by <a href="https://github.com/lucacome"><code>@​lucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li>
<li>Dependabot updates in <a href="https://redirect.github.com/actions/checkout/pull/1777">actions/checkout#1777</a> &amp; <a href="https://redirect.github.com/actions/checkout/pull/1872">actions/checkout#1872</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/yasonk"><code>@​yasonk</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1869">actions/checkout#1869</a></li>
<li><a href="https://github.com/lucacome"><code>@​lucacome</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.7...v4.2.0">https://github.com/actions/checkout/compare/v4.1.7...v4.2.0</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.2.0</h2>
<ul>
<li>Add Ref and Commit outputs by <a href="https://github.com/lucacome"><code>@​lucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li>
<li>Dependency updates by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>- <a href="https://redirect.github.com/actions/checkout/pull/1777">actions/checkout#1777</a>, <a href="https://redirect.github.com/actions/checkout/pull/1872">actions/checkout#1872</a></li>
</ul>
<h2>v4.1.7</h2>
<ul>
<li>Bump the minor-npm-dependencies group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1739">actions/checkout#1739</a></li>
<li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1697">actions/checkout#1697</a></li>
<li>Check out other refs/* by commit by <a href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1774">actions/checkout#1774</a></li>
<li>Pin actions/checkout's own workflows to a known, good, stable version. by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1776">actions/checkout#1776</a></li>
</ul>
<h2>v4.1.6</h2>
<ul>
<li>Check platform to set archive extension appropriately by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1732">actions/checkout#1732</a></li>
</ul>
<h2>v4.1.5</h2>
<ul>
<li>Update NPM dependencies by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703">actions/checkout#1703</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694">actions/checkout#1694</a></li>
<li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696">actions/checkout#1696</a></li>
<li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695">actions/checkout#1695</a></li>
<li>README: Suggest <code>user.email</code> to be <code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1707">actions/checkout#1707</a></li>
</ul>
<h2>v4.1.4</h2>
<ul>
<li>Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1692">actions/checkout#1692</a></li>
<li>Add dependabot config by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1688">actions/checkout#1688</a></li>
<li>Bump the minor-actions-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1693">actions/checkout#1693</a></li>
<li>Bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1643">actions/checkout#1643</a></li>
</ul>
<h2>v4.1.3</h2>
<ul>
<li>Check git version before attempting to disable <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1656">actions/checkout#1656</a></li>
<li>Add SSH user parameter by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1685">actions/checkout#1685</a></li>
<li>Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1650">actions/checkout#1650</a></li>
</ul>
<h2>v4.1.2</h2>
<ul>
<li>Fix: Disable sparse checkout whenever <code>sparse-checkout</code> option is not present <a href="https://github.com/dscho"><code>@​dscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1598">actions/checkout#1598</a></li>
</ul>
<h2>v4.1.1</h2>
<ul>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe"><code>@​peterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514">actions/checkout#1514</a></li>
</ul>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436">Update to node20</a></li>
</ul>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="d632683dd7"><code>d632683</code></a> Prepare 4.2.0 release (<a href="https://redirect.github.com/actions/checkout/issues/1878">#1878</a>)</li>
<li><a href="6d193bf280"><code>6d193bf</code></a> Bump braces from 3.0.2 to 3.0.3 (<a href="https://redirect.github.com/actions/checkout/issues/1777">#1777</a>)</li>
<li><a href="db0cee9a51"><code>db0cee9</code></a> Bump the minor-npm-dependencies group across 1 directory with 4 updates (<a href="https://redirect.github.com/actions/checkout/issues/1872">#1872</a>)</li>
<li><a href="b684943689"><code>b684943</code></a> Add Ref and Commit outputs (<a href="https://redirect.github.com/actions/checkout/issues/1180">#1180</a>)</li>
<li><a href="2d7d9f7ff5"><code>2d7d9f7</code></a> Provide explanation for where user email came from (<a href="https://redirect.github.com/actions/checkout/issues/1869">#1869</a>)</li>
<li><a href="9a9194f871"><code>9a9194f</code></a> Bump docker/build-push-action from 5.3.0 to 6.5.0 (<a href="https://redirect.github.com/actions/checkout/issues/1832">#1832</a>)</li>
<li><a href="dd960bd3c3"><code>dd960bd</code></a> Bump docker/login-action in the minor-actions-dependencies group (<a href="https://redirect.github.com/actions/checkout/issues/1831">#1831</a>)</li>
<li>See full diff in <a href="692973e3d9...d632683dd7">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.1.7&new-version=4.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-10-01 06:24:37 +00:00
skia-flutter-autoroll
f2581bc751 Roll Skia from 6fc00ce22452 to db59fb03ddd9 (1 revision) (flutter/engine#55543) 
https://skia.googlesource.com/skia.git/+log/6fc00ce22452..db59fb03ddd9

2024-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 690b037a7532 to caeda3b8046d (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-01 05:55:05 +00:00
skia-flutter-autoroll
e6dd7e805f Roll Skia from b851101c844a to 6fc00ce22452 (1 revision) (flutter/engine#55539) 
https://skia.googlesource.com/skia.git/+log/b851101c844a..6fc00ce22452

2024-10-01 jvanverth@google.com Revert "[graphite] Expand BlurMaskFilter Precompilation ..."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-01 02:28:23 +00:00
skia-flutter-autoroll
674ac40d77 Roll Dart SDK from d9fb41a4b5ee to bff9c6ff642d (2 revisions) (flutter/engine#55538) 
https://dart.googlesource.com/sdk.git/+log/d9fb41a4b5ee..bff9c6ff642d

2024-10-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-304.0.dev
2024-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-303.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-01 02:18:24 +00:00
skia-flutter-autoroll
08575be842 Roll Skia from d1d7deb68f9d to b851101c844a (1 revision) (flutter/engine#55535) 
https://skia.googlesource.com/skia.git/+log/d1d7deb68f9d..b851101c844a

2024-09-30 lukasza@chromium.org [rust png] Initial `onGetFrameCount()` and `getFrameHolder()`.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-01 00:07:15 +00:00
skia-flutter-autoroll
df88117922 Roll Skia from 534633fb4bd9 to d1d7deb68f9d (1 revision) (flutter/engine#55534) 
https://skia.googlesource.com/skia.git/+log/534633fb4bd9..d1d7deb68f9d

2024-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 223523f05dc0 to cb6007a9d31d (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 22:47:59 +00:00
skia-flutter-autoroll
18eef79b1b Roll Dart SDK from 79863e31de87 to d9fb41a4b5ee (1 revision) (flutter/engine#55533) 
https://dart.googlesource.com/sdk.git/+log/79863e31de87..d9fb41a4b5ee

2024-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-302.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 21:56:49 +00:00
Matan Lurey
ed6acfd197 Introduce a GN rule that (explicitly) generates a dart test wrapper (flutter/engine#55475) 
Closes https://github.com/flutter/flutter/issues/155769.

This is a variant of the approach in https://github.com/flutter/engine/pull/52241, based on feedback from @jakemac53 and @jonahwilliams (who originally sped up `dart test` significantly by using `frontend_server` under the scenes: https://github.com/dart-lang/test/pull/1399), in short:

```gn
# tools/engine_tool/BUILD.gn

import("//flutter/build/dart/internal/gen_dartcli_call.gni")

gen_dartcli_call("tests") {
  args = [ "test" ]
  cwd = "//flutter/tools/engine_tool"
}
```

This stanza, when built (`ninja -C ../out/host_debug flutter/tools/engine_tool:tests`) generates the following file:

```sh
# ../out/host_debug/gen/flutter/tools/engine_tool/tests

set -e

# Needed because if it is set, cd may print the path it changed to.
unset CDPATH

# Store the current working directory.
prev_cwd=$(pwd)

# Set a trap to restore the working directory.
trap 'cd "$prev_cwd"' EXIT

CD_PATH="/Users/matanl/Developer/engine/src/flutter/tools/engine_tool"
if [ -n "$CD_PATH" ]; then
  cd "$CD_PATH"
fi

/Users/matanl/Developer/engine/src/flutter/prebuilts/macos-arm64/dart-sdk/bin/dart "test"
```

In turn, when executed (`../out/host_debug/gen/flutter/tools/engine_tool/tests`) it just runs `dart test`:

```sh
flutter % ../out/host_debug/gen/flutter/tools/engine_tool/tests
Building package executable... 
Built test:test.
00:00 +0: test/test_command_test.dart: test command executes test                                                                                                                                                                                                          
00:00 +3: test/run_command_test.dart: run command invokes flutter run
...
00:00 +117: All tests passed!
```

There is no actual compilation performed by the tool (that is handled implicitly by `dart test`), and as a result neither a `depfile` is needed, nor generating a pre-compiled artifact like a snapshot or AOT elf/assembly. 

---

This work is incomplete, that is, we'd want to properly tag the executable so `et` can find it, and create a wrapper template (i.e. `dart_test`) that tightens things up a bit, but I wanted to show the work at this intermediate step to get feedback before moving forward.

/cc @jonahwilliams, @jtmcdole as well.
 2024-09-30 21:39:36 +00:00
Matan Lurey
a38103ac0e Remove the need to use runZoned by replacing print statements (flutter/engine#55530) 2024-09-30 21:33:21 +00:00
skia-flutter-autoroll
bdd730c32c Roll Skia from 6c89706638ee to 534633fb4bd9 (2 revisions) (flutter/engine#55531) 
https://skia.googlesource.com/skia.git/+log/6c89706638ee..534633fb4bd9

2024-09-30 lukasza@chromium.org [rust png] Support color transforms for (narrower) subframes.
2024-09-30 michaelludwig@google.com [graphite] Include intrinsic uniforms in the fragment shader

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 20:26:20 +00:00
Chinmay Garde
55cdf532e5 [Impeller] Create a libImpeller dylib and expose symbols. (flutter/engine#55526) 2024-09-30 20:04:15 +00:00
gaaclarke
74788642ea Added metal validation for `impeller_unittests (flutter/engine#55527) 
This turns on Metal validation for launching impeller_unittests from the tests panel.  This matches the default behavior of launching tests from XCode.  Without these assertions errors in Metal are completely silent.  In my case I just got a black screen until I tried running the tests through xcode.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-30 19:19:08 +00:00
skia-flutter-autoroll
05fc8c01db Roll Skia from dfeeb199b226 to 6c89706638ee (2 revisions) (flutter/engine#55528) 
https://skia.googlesource.com/skia.git/+log/dfeeb199b226..6c89706638ee

2024-09-30 robertphillips@google.com [graphite] Expand BlurMaskFilter Precompilation ...
2024-09-30 jamesgk@google.com Avoid segfault in BigImageTest, rearrange skip rules

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 19:02:05 +00:00
art-snake
405f673f7d fix use_of_uninitialized_value in message_loop_task_queues.cc (flutter/engine#55520) 
This issue was found with memory sanitizer.

    Commit 988c4ffb83398bf8511122d73f0f85010e0edeea introduced a change that leads to use-after-free condition.

    In function MessageLoopTaskQueues::GetNextTaskToRun:

        1) Call is made to PeekNextTaskUnlocked(queue_id);. Returned value contains a reference to to an object of const DelayedTask& taken from an std::queue container as returned by primary_task_queue_.top().
        2) Variable TaskSource::TopTask top now contains a reference to this object.
        3) Function queue_entries_.at(top.task_queue_id)->task_source->PopTask(...) which in turn calls pop() method on std::queue.
        4) Object of type DelayedTask on top of the queue gets deleted.
        5) top.task.GetTaskSourceGrade() is called later with top.task refering to an already deleted object.

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-30 18:17:05 +00:00
Chris Bracken
219d952197 iOS: Migrate FlutterEngineGroup to ARC (flutter/engine#55503) 
This migrates FlutterEngineGroup to automatic reference counting. It also migrates `enginesCreatedCount` from an ivar to property syntax.

I'll look at migrating engine from `NSMutableArray<NSValue*>` to a weak pointer array in a followup patch since it's orthogonal to ARC migration.

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-30 17:56:52 +00:00
Jackson Gardner
b99e758ee1 Reland [skwasm] Scene builder optimizations for platform view placement (flutter/engine#55468) 
This is an attempt to reland the overlay optimization for skwasm and fixing the golden diffs from the framework tests.

Original PR description:

This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: https://github.com/flutter/flutter/issues/149863

This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
 2024-09-30 17:42:58 +00:00
skia-flutter-autoroll
2482050afd Roll Dart SDK from c55ae50d619a to 79863e31de87 (1 revision) (flutter/engine#55525) 
https://dart.googlesource.com/sdk.git/+log/c55ae50d619a..79863e31de87

2024-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-301.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 17:41:54 +00:00
skia-flutter-autoroll
b512a689d0 Roll Skia from 06721a724831 to dfeeb199b226 (2 revisions) (flutter/engine#55524) 
https://skia.googlesource.com/skia.git/+log/06721a724831..dfeeb199b226

2024-09-30 michaelludwig@google.com Check for null child in SkWorkingFormatColorFilter
2024-09-30 fmalita@google.com Add bungeman to public API owners

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 17:35:13 +00:00
Chris Bracken
6a4e814a68 iOS: Migrate FlutterHeadlessDartRunner to ARC (flutter/engine#55502) 
This is a subclass of FlutterEngine, which is still manually reference counted, but that's not problematic since the headers have been migrated to ARC-safe syntax that preserves existing behaviour.

No test changes since this patch makes no semantic changes.

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-30 16:47:07 +00:00
skia-flutter-autoroll
eed2aa5d8e Roll Dart SDK from c2728b947e46 to c55ae50d619a (21 revisions) (flutter/engine#55522) 
https://dart.googlesource.com/sdk.git/+log/c2728b947e46..c55ae50d619a

2024-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-300.0.dev
2024-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-299.0.dev
2024-09-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-298.0.dev
2024-09-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-297.0.dev
2024-09-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-296.0.dev
2024-09-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-295.0.dev
2024-09-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-294.0.dev
2024-09-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-293.0.dev
2024-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-292.0.dev
2024-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-291.0.dev
2024-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-290.0.dev
2024-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-289.0.dev
2024-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-288.0.dev
2024-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-287.0.dev
2024-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-286.0.dev
2024-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-285.0.dev
2024-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-284.0.dev
2024-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-283.0.dev
2024-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-282.0.dev
2024-09-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-281.0.dev
2024-09-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-280.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 13:28:10 +00:00
skia-flutter-autoroll
67927a3432 Roll Skia from 80d141cf32ac to 06721a724831 (1 revision) (flutter/engine#55521) 
https://skia.googlesource.com/skia.git/+log/80d141cf32ac..06721a724831

2024-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 50ad0c468c61 to 223523f05dc0 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 10:45:08 +00:00
skia-flutter-autoroll
f6c0d5993b Roll Skia from 5f4740b998b3 to 80d141cf32ac (1 revision) (flutter/engine#55519) 
https://skia.googlesource.com/skia.git/+log/5f4740b998b3..80d141cf32ac

2024-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0ec8a7f1b588 to 7b0212b337ff (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 09:15:37 +00:00
skia-flutter-autoroll
42f10856aa Roll Skia from 333df70fbcdb to 5f4740b998b3 (1 revision) (flutter/engine#55518) 
https://skia.googlesource.com/skia.git/+log/333df70fbcdb..5f4740b998b3

2024-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3ba9cd40c151 to a97dae4c20c1 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 07:36:24 +00:00
skia-flutter-autoroll
f74abfe90b Roll Fuchsia Linux SDK from aD8sWPlmp-0Zh17vj... to A8lL1H_6clgBKJXHK... (flutter/engine#55517) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 06:20:31 +00:00
skia-flutter-autoroll
24be9d9b8b Roll Skia from 2f1e716bbe61 to 333df70fbcdb (1 revision) (flutter/engine#55516) 
https://skia.googlesource.com/skia.git/+log/2f1e716bbe61..333df70fbcdb

2024-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from cef41cc71c85 to 690b037a7532 (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-30 06:08:07 +00:00
skia-flutter-autoroll
1721780028 Roll Skia from f88a9ae4d9c1 to 2f1e716bbe61 (1 revision) (flutter/engine#55513) 
https://skia.googlesource.com/skia.git/+log/f88a9ae4d9c1..2f1e716bbe61

2024-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1f1860958df1 to 50ad0c468c61 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-29 05:01:11 +00:00
skia-flutter-autoroll
f623607382 Roll Fuchsia Linux SDK from yX_hiCzoio2mYXAA8... to aD8sWPlmp-0Zh17vj... (flutter/engine#55512) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-29 04:19:12 +00:00
Jonah Williams
c95afa281b Fix npe during skia dispatch of drawAtlas (flutter/engine#55497) 
Colors are optionally provided, so make sure to null check the array.

Fixes https://github.com/flutter/flutter/issues/155783
 2024-09-28 19:13:18 +00:00
skia-flutter-autoroll
88a7957f14 Roll Skia from 7efc11f2ea9e to f88a9ae4d9c1 (2 revisions) (flutter/engine#55511) 
https://skia.googlesource.com/skia.git/+log/7efc11f2ea9e..f88a9ae4d9c1

2024-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 180925851393 to 1f1860958df1 (1 revision)
2024-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7bd80578336d to 180925851393 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-28 19:03:23 +00:00
Chris Bracken
3a116a3647 Improved description for ios_debug_sim_unopt_arm64 (flutter/engine#55498) 
Make it explicit that it's an unopt engine for consistency with the
other unopt build descriptions.

Fixup to: https://github.com/flutter/engine/pull/55493
 2024-09-28 11:42:08 -07:00
skia-flutter-autoroll
5f0829a87a Roll Fuchsia Linux SDK from hMFizUI--VpyjP3ht... to yX_hiCzoio2mYXAA8... (flutter/engine#55505) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-28 03:02:22 +00:00
Harry Terkelsen
5c96bcbf1e Revert "Reland "[canvaskit] Further improve overlay optimization by splitting pictures"" (flutter/engine#55501) 
Reverts flutter/engine#55464

The PR caused a large regression in a web benchmark.
 2024-09-28 00:51:18 +00:00
Matan Lurey
2a0f911fef Migrate try/finally calls to addTearDown. (flutter/engine#55499) 
I also removed other no-longer-enforced cruft. No behavioral changes.
 2024-09-28 00:27:20 +00:00
Chris Bracken
faa6496380 iOS: Migrate FlutterAppDelegate to ARC (flutter/engine#55472) 
Migrates the FlutterAppDelegate.mm translation unit to be compiled with the `-fobjc-arc` compiler flag.

No test changes since no this change includes no semantic changes, and thus covered by existing tests such as [`testReleasesWindowOnDealloc`](f6e580d09a/shell/platform/darwin/ios/framework/Source/FlutterAppDelegateTest.mm (L139-L153)).

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-27 22:44:53 +00:00
Jason Simmons
faa865b425 [Impeller] Apply some recent color filter fixes to BlendFilterContents::CreateForegroundAdvancedBlend (flutter/engine#55470) 
Some recent changes affecting color filters (https://github.com/flutter/engine/pull/55411, https://github.com/flutter/engine/pull/55448) need to be done for both Porter-Duff and advanced blend modes
 2024-09-27 21:42:49 +00:00
gaaclarke
9e2746c137 updated Color docstring to address equality (flutter/engine#55496) 
issue: https://github.com/flutter/flutter/issues/155803

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-27 21:41:08 +00:00
Chris Bracken
1287ae153e Make arm64 iOS simulator local engine build unopt (flutter/engine#55493) 
Most iOS embedder developers rely on two simulator builds:
* ios_debug_sim_unopt (for simulators on x64 hosts)
* ios_debug_sim_unopt_arm64 (for simulators on arm64 hosts)

We specify these two builds, for example, in our iOS unit test Xcode project `testing/ios/IosUnitTests/Tests/FlutterEngineConfig.xcconfig`.

Currently `local_engine.json` specifies two simulator builds:
* ios_debug_sim_unopt (for simulators on x64 hosts)
* ios_debug_sim_arm64 (for simulators on arm64 hosts)

While the x64 build specifies the `--unoptimized` flag, the arm64 build does not, which is problematic for those wanting to use both `et` and run the iOS unit tests.

This adds the `--unoptimized` flag for consistency with prevailing practice among iOS embedder developers.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-27 21:41:05 +00:00
Zuckjet
7fb25cdc23 [docs] Fix broken links in docs/ (flutter/engine#55350) 
Fix broken links in docs/, specifically replaces ../ with https://github.com/flutter/flutter/blob/master/docs/

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-09-27 18:28:12 +00:00
skia-flutter-autoroll
e41b0f8c87 Roll Skia from e77818421e91 to 7efc11f2ea9e (6 revisions) (flutter/engine#55489) 
https://skia.googlesource.com/skia.git/+log/e77818421e91..7efc11f2ea9e

2024-09-27 borenet@google.com [infra] Add jobs for Pixel9
2024-09-27 robertphillips@google.com [ganesh] Add GrGLCaps setting to control GL/ANGLE Protectedness handling
2024-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 64d149df26fd to 7bd80578336d (2 revisions)
2024-09-27 bungeman@google.com Suppress function UBSan on macOS
2024-09-27 drott@chromium.org [Fontations] Optimize generateMetrics() color glyph search
2024-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 966739ac8b4c to 0ec8a7f1b588 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-09-27 17:31:57 +00:00
Jason Simmons
96d24ff033 Listen for uncaught exceptions during loading of a web test suite in Chrome (flutter/engine#55166) 
Without this the test runner will hang if the compiled test is invalid and unable to execute.
 2024-09-27 17:18:18 +00:00
auto-submit[bot]
fdbad460a5 Reverts "[Impeller] hash even less stuff per frame. (#55092)" (flutter/engine#55491) 
Reverts: flutter/engine#55092
Initiated by: jonahwilliams
Reason for reverting: framework golden failures.
Original PR Author: jonahwilliams

Reviewed By: {chinmaygarde, jtmcdole}

This change reverts the following previous change:
Follow up to https://github.com/flutter/engine/pull/55060

Currently we have multiple stages of hashing while font rendering, which is relatively expensive for the actualy required workload. First, we hash the contents of all text frames to compute the unique set of glyphs per frame. Then we diff this hash set against the hashmap of glyphs within the atlas. Finally we hash and lookup the final rendered bounds for each glyph.

We can simplify this to 2. hash lookups for glyphs not yet in the atlas and 1. hash lookup for glyphs that are in the atlas. This is done by combing the step where we uniquely compute glyphs per frame with the diff against the current atlas. When this lookup is performed, we also store the glyph position (if found) in the text_frame itself - which allows text contents to skip the last hash, as long as the glyph has already been rendered.

### Before

![flutter_03](https://github.com/user-attachments/assets/be9c4459-f0c8-426c-b152-38861acb207f)

### After

![flutter_04](https://github.com/user-attachments/assets/1aa7cbd1-6af7-4020-8966-7e3baaef102b)

Using this handy dandy test app:

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {

  Widget build(context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: Text('Platform View'),
        ),
        body: SafeArea(child: Stack(children: [
          SizedBox(
            width: 380,
            height: 380,
            child: LinearProgressIndicator(),
          ),
          Stack(
            children: List<Widget>.generate(1000, (index) {
              // The problem already happens with a small amount of widgets.
              // Using an excessive amount of widgets is just to make the problem more evident.
              return Text("Lots of Texts represent a Widget with complex components.");
            }),
          ),

          Align(
            alignment: Alignment.bottomCenter,
            child:
            TextButton(
              child: Text("Button"),
              onPressed: () {
                print("Tap ${DateTime.now()}");
              },
            ),
          ),
        ],
        ),
        ),
      ),
    );
  }
}
```
 2024-09-27 17:09:28 +00:00
Mouad Debbar
f6e580d09a [web] Update builder json generator to reflect recent changes (flutter/engine#55307) 
Recent [changes](https://github.com/flutter/engine/pull/54584) affected our builder configs, but the script that generates those builder configs wasn't updated.
 2024-09-27 16:05:17 +00:00