8398 Commits

Author SHA1 Message Date
Devon Carew
6957eabe2c tweak the doctor check for host compatibility (#9720) 2017-05-02 10:32:00 -07:00
Ian Hickson
e8c46927c4 Flush microtasks after transient callbacks are run. (#9702)
This splits the frame pipeline into two, beginFrame and drawFrame.

As part of making this change I added some debugging hooks that helped
debug the issues that came up:

 * I added debugPrintScheduleFrameStacks which prints a stack whenever
   a frame is actually scheduled, so you can see why frames are being
   scheduled.

 * I added some toString output to EditableText and RawKeyboardListener.

 * I added a scheduler_tester.dart library for scheduler library tests.

 * I changed the test framework to flush microtasks before pumping.

 * Some asserts that had the old string literal form were replaced by
   asserts with messages.

I also fixed a few subtle bugs that this uncovered:

 * setState() now calls `ensureVisualUpdate`, rather than
   `scheduleFrame`. This means that calling it from an
   AnimationController callback does not actually schedule an extra
   redundant frame as it used to.

 * I corrected some documentation.
2017-05-02 09:27:53 -07:00
Ian Hickson
89856c0e5b Adjust the defaults behaviour of scroll views. (#9679)
* Adjust the defaults behaviour of scroll views.

Now, primary scroll views scroll by default. Others only scroll if necessary.

* apply suggested changes
2017-05-02 09:14:50 -07:00
Ian Hickson
f739e9e022 Revert "Don't try to resolve CocoaPods unless project has plugins" (#9719)
* Revert "Document ScrollController (#9705)"

This reverts commit ff8609f27396c91f9ead5a560a19ec3d34d5f7b8.

* Revert "Fix channels integration test (#9713)"

This reverts commit aace622d3fcb96cce732c6feb1857baecdc4e86c.

* Revert "Fix flutter view project's automated tests (#9712)"

This reverts commit 1a4bf9b66db61ce195a6537935ee709def82653a.

* Revert "Update hello_world_memory_test package name (#9704)"

This reverts commit ffa8483f3b4d7be09e6d4e5076c580a7780e3b62.

* Revert "Increment the flutter package version (#9699)"

This reverts commit 3b237a8c62e767d399381ed4b94b3e0fb4647887.

* Revert "Don’t pod unless there are plugins (#9701)"

This reverts commit 732f79eed7753f724e9c8acfb15d56059b536975.
2017-05-02 08:57:05 -07:00
Adam Barth
ff8609f273 Document ScrollController (#9705) 2017-05-01 19:18:09 -07:00
xster
aace622d3f Fix channels integration test (#9713) 2017-05-01 18:43:17 -07:00
xster
1a4bf9b66d Fix flutter view project's automated tests (#9712)
Remove checked in .lock, remove checked in cocoapods scripts in xcode project, let the automated test run pod install specifically for this test
2017-05-01 18:23:06 -07:00
Chris Bracken
ffa8483f3b Update hello_world_memory_test package name (#9704)
Broken by 89af5ec8c7c6012746482256b9b7459727526f32.
2017-05-01 14:18:00 -07:00
Jason Simmons
3b237a8c62 Increment the flutter package version (#9699) 2017-05-01 14:06:52 -07:00
xster
732f79eed7 Don’t pod unless there are plugins (#9701) 2017-05-01 13:37:45 -07:00
Chris Bracken
89af5ec8c7 Update hello world example to latest template (#9697) 2017-05-01 13:08:52 -07:00
Hans Muller
7414e13423 AnimatedList sample app (#9685) 2017-05-01 12:57:34 -07:00
xster
9a61b8713c CocoaPods flow step 1 (#9687)
* Add cocoapods reason

* s/native/iOS
2017-05-01 12:47:25 -07:00
Adam Barth
48f2770e4e Add missing docs (#9696) 2017-05-01 12:18:30 -07:00
Jason Simmons
2ab631b702 Add space to the clipping region of physical model layers with shadows (#9654) 2017-05-01 11:32:09 -07:00
Todd Volkert
9c1aba2abe Skip adb server restarts during device discovery (#9693) 2017-05-01 10:10:16 -07:00
Adam Barth
c6b0f833af Document more scrolling classes (#9684) 2017-04-30 08:59:06 -07:00
Adam Barth
a4ba761bea Document remaining non-scrolling symbols (#9667)
This patch finishes documenting all the symbols except for those related to
scrolling.
2017-04-28 16:01:14 -07:00
Mikkel Nygaard Ravn
bba043bab3 Roll engine to da8ebf40bd5fc76774bc4d291094344074fa432c (#9680) 2017-04-29 00:53:32 +02:00
xster
f65fea8e2e Create a text validator/formatter mechanism (#9535)
* Add a text formatter interface used by EditingText. Provide some default implementations.

* self nits

* Handle -1 selection offsets

* review notes

* simplify regular expression

* Add whitelisting formatters. Use a custom phone number formatter in text demo.

* review notes

* not being able to addAll(null) is pretty annoying

* review notes

* partial tests

* Add tests

* didn’t end up needing mockito

* move to services
2017-04-28 15:33:38 -07:00
xster
b717963b43 Change Cupertino page transition box shadow to a simple custom gradient (#9673)
Creates another Decoration for drawing outside the decorated box with a gradient to emulate the shadow.

Lets the cupertino transition page's background be transparent.

Fixes #9321
2017-04-28 12:50:20 -07:00
Hans Muller
acf102be95 AnimatedList (#9649) 2017-04-28 11:37:36 -07:00
Devon Carew
6716904385 return the result from calling a service extension (#9636) 2017-04-28 07:39:14 -07:00
Ian Hickson
f2e89681d9 Mark microbenchmarks_ios as flaky (#9656)
...because it clearly is.
2017-04-27 19:55:54 -07:00
Chris Bracken
9da22bd92f Roll engine to 7c699ce7721b32d7893e68e260474a7eec811fd5 (#9660) 2017-04-27 16:51:09 -07:00
xster
3a0ce961ca lerp LinearGradient (#9628)
* Implement

* Don’t scale the fractional offsets since it’s easier to use

* review notes

* fix nit
2017-04-27 15:52:41 -07:00
xster
66ed8de745 Record flutter run success/fail, build mode, platform, start time in analytics (#9597)
FlutterCommand.runCommand subclasses can optionally return a FlutterCommandResult which is used to append additional analytics. 

Fix flutter run timing report and add a bunch of dimensional data
2017-04-27 15:28:15 -07:00
Jason Simmons
a4992f0eac Fix the sizing of the stack containing the Gallery preview banner (#9657) 2017-04-27 15:16:05 -07:00
Mikkel Nygaard Ravn
a33832617b Document channel message value conversions (#9635) 2017-04-28 00:04:51 +02:00
Ian Hickson
11fa80bb78 MediaQuery.of shouldn't give a default return value (#9596) 2017-04-27 15:02:59 -07:00
Michael Goderbauer
b432af51fd Don't crash when ADB exits with non-zero exit code (#9653) 2017-04-27 14:57:56 -07:00
Ian Hickson
36052e68dd BoxDecoration API changes: backgroundColor -> color et al (#9648)
backgroundColor -> color
backgroundImage -> image
BackgroundImage -> DecorationImage
2017-04-27 14:19:01 -07:00
Jason Simmons
1d6a8249f8 roll engine (#9650) 2017-04-27 13:34:48 -07:00
Todd Volkert
ffdca6f7e8 Fix getDevicesById() (#9646)
If the user specified a non-exact device id, it was producing
an exception whereby we were trying to listen to the
`getAllConnectedDevies()` stream twice.
2017-04-27 13:12:59 -07:00
Adam Barth
744c91265b Add NestedScrollView (#9640)
A NestedScrollView lets you implement patterns where you have a header, tabs,
and additional scrollers inside the tabs.

Fixes #8359
2017-04-27 12:29:40 -07:00
Jason Simmons
834c142d04 Fix the sizing of the image in Gallery/Contacts (#9625) 2017-04-27 11:32:53 -07:00
Jason Simmons
0439bf25d9 Fix an analyzer warning (#9643) 2017-04-27 11:16:00 -07:00
Adam Barth
4bac259617 Shift more code to ScrollPosition (#9637)
Previously, ScrollPosition did not know about ScrollActivities. However, all
the concrete subclasses of ScrollPosition that we know about need to use
ScrollActivities, so they ended up with a bunch of delegate boilerplate code.

This patch teaches ScrollPosition about ScrollActivities but doesn't have any
opinion about how to start or interact with those activities.

This patch is more refactoring to prepare for nested and linked scrolling.
2017-04-27 10:30:53 -07:00
Michael Goderbauer
36f7a26641 Disable AAPT cruncher on Windows for channel integration test (#9639)
It causes the test to be flaky, see https://github.com/flutter/flutter/issues/8986.
2017-04-27 09:59:31 -07:00
Adam Barth
2891772846 Refactor ScrollDragActivity into two pieces (#9629)
This will make it easier to implement nested scrolling.
2017-04-27 09:39:12 -07:00
Devon Carew
9ac2e44ee7 add a regression test for daemon device notification (#9618)
* add a regression test for daemon device notification

* revert event send simplification
2017-04-27 09:30:47 -07:00
P.Y. Laligand
d2c6b0a637 Get rid of unnecessary flutter_root argument. (#9622) 2017-04-27 09:10:48 -07:00
Mikkel Nygaard Ravn
23b8e1f115 Make profile provisioning manual for channel_integration_test_ios (#9633) 2017-04-27 12:14:43 +02:00
Mikkel Nygaard Ravn
60bc1cfde7 Remove personal dev team from ios code sigining (#9631)
* Mark channels_integration_test_ios flaky

* Removed personal dev team from ios code siging

* Removed provisioning profile diffs against other samples
2017-04-27 11:07:52 +02:00
Mikkel Nygaard Ravn
70ff50f929 Integration test for channel communication (#9621) 2017-04-27 08:44:28 +02:00
Zachary Anderson
0770c3c14f [flutter_tools] Adds some support for '-d all' (#9585) 2017-04-26 21:49:38 -07:00
Todd Volkert
9558ac7d55 Assert that url is non-null in NetworkImage (#9626) 2017-04-26 21:35:58 -07:00
Ian Hickson
2e194d5b44 Allow ChangeNotifiers to be CustomPainters (#9584)
Fixes https://github.com/flutter/flutter/issues/7648
2017-04-26 14:30:20 -07:00
Mehmet Fidanboylu
4e7a38b118 Add a tile scrolling test to complex_layout app (#9537)
* Add a tile scrolling test to complex_layout app

* - Review comments and fix analyzer failures.

* Use ListView.builder pattern.
2017-04-26 14:22:11 -07:00
xster
f645245ffd Add a convenience test task for vscode (#9570) 2017-04-26 13:48:28 -07:00