firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,398 Commits 1 Branch 0 Tags
Commit Graph

8398 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Todd Volkert
e2cd78358f Fix missing await (#9617) 
Fixes #9612
 2017-04-26 13:14:31 -07:00
Adam Barth
0f900116f0 Rename Stack.sizing to Stack.fit (#9615) 
The enum is called StackFit, so the property name "fit" makes more sense.
 2017-04-26 11:12:38 -07:00
Hans Muller
3c3b003f8b Handle ListView item size changes that cause underflow (#9586) 2017-04-26 10:44:35 -07:00
Michael Goderbauer
b7ec82014d move collection to dev dependency (#9613) 2017-04-26 10:38:11 -07:00
Michael Goderbauer
460561bad8 Make Flutter plugins usable from a Windows host (#9599) 
Note: In a cross-platform context `Uri.path` is not a valid file path. Allways use `fs.path.fromUri` to convert.
 2017-04-26 10:02:22 -07:00
Todd Volkert
aaaae265ae Run async when calling adb shell getprop (#9611) 
Also, add a timeout so a hung `adb` will not cause the
tools process to hang.

Fixes #9567
 2017-04-26 09:58:20 -07:00
Todd Volkert
21f57a85e8 Wait for stderr in runCommandAndStreamOutput() (#9598) 2017-04-25 17:40:28 -07:00
Todd Volkert
60c5ffc1a9 Switch many Device methods to be async (#9587) 
`adb` can sometimes hang, which will in turn hang the Dart isolate if
we're using `Process.runSync()`. This changes many of the `Device` methods
to return `Future<T>` in order to allow them to use the async process
methods. A future change will add timeouts to the associated calls so
that we can properly alert the user to the hung `adb` process.

This is work towards #7102, #9567
 2017-04-25 17:23:00 -07:00
Ian Hickson
596eb033c7 Loosen the constraints for Stack non-positioned children. (#9581) 
Also:

 * Add three explicit sizing modes to Stack for non-positioned
   children: loose, expand, and passthrough. (All three are used.)

 * Fix a bug whereby layers would try to paint in the same frame as
   they were removed from layout (but not detached).

 * Fix a bug whereby Offstage wasn't properly marking the parent dirty
   when changing its sizedByParent flag.

 * Explicitly make Overlay expand non-positioned children.

 * Explicitly have InputDecoration pass through the constraints from
   its Row to its Stack children.
 2017-04-25 15:06:02 -07:00
Ian Hickson
24b40d87d6 Make getVelocity never return null (#9583) 
Fixes https://github.com/flutter/flutter/issues/8425
 2017-04-25 12:23:43 -07:00
Michael Goderbauer
ad1c497c03 Do not lower-case paths during canonicalization. (#9571) 
* Do not lower-case paths during canonicalization.

This breaks hot reload on some platfroms with case insensitive file systems.

* Add unit tests
 2017-04-25 10:34:43 -07:00
Alexandre Ardhuin
31828609dc add @required (#9579) 2017-04-25 08:59:43 +02:00
Adam Barth
c288c7064f Refactor scrolling code to prepare for nested scrolling (#9575) 
This patch reworks some of the guts of scrolling to make it easier to
implement nested scrolling effects. The actually nested scrolling effect
will be included in a later patch.
 2017-04-24 23:32:55 -07:00
Ian Hickson
57648ba0e4 New Placeholder widget. (#9565) 2017-04-24 14:06:07 -07:00
Ian Hickson
3492350653 Remove Placeholder. It has no clients. (#9563) 2017-04-24 12:40:27 -07:00
Adam Barth
55f334681b FocusNode.requestFocus should show the keyboard (#9558) 
This patch introduces the notion of a keyboard token, which generalizes the
logic in EditableText for distinguishing between gaining focus by default and
gaining focus because of an explicit use action.

Fixes #7985
 2017-04-24 09:46:49 -07:00
Michael Thomsen
1de15bbb00 Remove Pods dir from examples that have it (#9550) 
* Remove Pods dir from layers example

* Remove Pods dir from flutter_view example
 2017-04-24 18:38:44 +02:00
Todd Volkert
db82f9ea7d Make travis script more verbose upon error (#9545) 
This will help us know for sure exactly which sub-script erred.
 2017-04-24 09:14:44 -07:00
Todd Volkert
a3f0f6911b Remove replay test (#9542) 
It's going to be replaced by #8963

Fixes #8947
 2017-04-24 08:47:38 -07:00
Michael Thomsen
f10326d28e Add app id to build.gradle template (#9552) 2017-04-24 17:13:04 +02:00
Michael Thomsen
c313984409 Exclude generated PluginRegistry files from git (#9555) 2017-04-24 15:23:18 +02:00
Michael Thomsen
2e10f61c5c Upgrade node version (#9549) 
* Upgrade node version

* Upgrade node version, but no further than 6 which is in LTS
 2017-04-24 13:14:44 +02:00
Michael Thomsen
f6a7fe0925 Upgrade firebase tools version (#9548) 2017-04-24 11:14:54 +02:00
Alexandre Ardhuin
83fce211a3 More const immutable classes (#9544) 
* more widget const constructors

* prefer const constructors

* address review comments
 2017-04-23 22:37:29 +02:00
Brian Slesinsky
054c937917 don't use curl progress bar since it looks bad in IDEA console window (#9538) 
Without this flag, it shows progress via increasing numbers instead of a progress bar. For some reason, the IDEA console seems to be okay with that.
 2017-04-23 10:30:27 -07:00
Alexandre Ardhuin
26c7411d66 unnecessary_override (#9540) 2017-04-22 22:58:21 +02:00
Alexandre Ardhuin
ad496e142b enable lint overridden_fields (#9527) 
* enable lint overridden_fields

* address review comment
 2017-04-22 10:27:03 +02:00
Adam Barth
0d0861b3ee The const will continue until morale improves (#9536) 2017-04-21 14:59:24 -07:00
xster
76ecb0b9a1 Remove InputField (#9520) 2017-04-21 14:12:14 -07:00
Alexandre Ardhuin
10099db4e2 try lint prefer_expression_function_bodies (#9494) 2017-04-21 23:10:37 +02:00
Adam Barth
a57018a4bb Add GridView.builder (#9522) 
This constructor makes it easier to use a GridView with a builder
callback.

Fixes #8952
 2017-04-21 14:09:53 -07:00
Alexandre Ardhuin
9541848272 make @immutable const classes (#9532) 
* make @immutable const

* fix build
 2017-04-21 23:09:42 +02:00
Adam Barth
1abb6f5d74 Explain why the Padding widget exists (#9523) 
Fixes #5166
 2017-04-21 14:09:35 -07:00
Adam Barth
930183916c Box/Sliver mismatches should have better error messages (#9525) 
We now attempt to explain what went wrong.

Fixes #9509
 2017-04-21 14:09:25 -07:00
Hans Muller
39d9bcdae8 ListView.Builder() handles appends when scrolled to the end (#9533) 2017-04-21 14:07:41 -07:00
Ian Hickson
df45aac166 Don't paint on unattached layers. (#9519) 2017-04-21 13:39:55 -07:00
Phil Quitslund
bd8f3f3a29 Bump Dart SDK to 1.23.0-dev.11.11. (#9530) 2017-04-21 13:25:04 -07:00
Ian Hickson
a591628cab Reorganise the drag related gesture files. (#9487) 
Move the Drag*Details classes into drag_details.dart.
Move the one-gesture drag recognizers into monodrag.dart.
Move Drag into drag.dart.

Adjust the comments to claim that Drag is used by other things than
MultiDragGestureRecognizer. (Right now this is a lie but it will
hopefully be true soon.)
 2017-04-21 13:13:20 -07:00
Adam Barth
31b1964a23 Document that you can call runApp again (#9526) 
This is such a fundamental property of the system that we forgot to
document it.

Fixes #6818
 2017-04-21 09:32:32 -07:00
jcollins-g
37fafeecb1 Dartdoc bot sanity flexibility (#9496) 
* Have sanity check pass on old and new versions of flutter
 2017-04-21 08:11:33 -07:00
Michael Thomsen
7a57d37195 Add Pods cache dir to ios/.gitignore (#9464) 
* Add Pods cache dir to ios/.gitngnore

* Add missing ending newlines
 2017-04-21 13:18:05 +02:00
Michael Thomsen
3510082ac9 Better separation between app and plugin main.dart and fix plugin main.dart issues. (#9491) 
* Make seperation between app and plugin main.dart more manageable.

* Jakob review feedback

* Remove empty line

* Add missing newline
 2017-04-21 12:49:42 +02:00
Alexandre Ardhuin
c794221f96 enable lint prefer_adjacent_string_concatenation (#9493) 2017-04-21 08:52:07 +02:00
Zachary Anderson
9b250cb6e8 [fuchsia_reload] More information from --list (#9503) 2017-04-20 15:06:56 -07:00
P.Y. Laligand
5b02aaabb4 Added a simple test runner for Fuchsia. (#9461) 2017-04-20 14:18:24 -07:00
Todd Volkert
ca2bf1efd0 Redirect curl's stderr to stdout, since it draws its progress bar to stderr (#9497) 2017-04-20 11:37:10 -07:00
John McCutchan
03d684be6d Fix a race in runFromSource. (#9495) 
There is a race where we could complete a future based on a stream event
and then before we cancel the stream subscription, we get another event
and try and complete the future again.
 2017-04-20 10:05:30 -07:00
Devon Carew
f29dd4f921 improve progress display when running apps; speed up startup (#9475) 
* improve progress display when running apps; speed up startup

* review comments
 2017-04-20 07:13:35 -07:00
Alexandre Ardhuin
35803c2297 comprehensive list of lints (#9330) 
* comprehensive list of lints
* add comments to commented out lint
* fix unnecessary_this lints
* exclude prefer_final_fields
 2017-04-20 09:38:57 +02:00
Ian Hickson
96d8a2a3ad Mark some tests as flaky (#9489) 
These tests have recently been turning the build red incorrectly. Until they are reliable, let's mark them flaky.
 2017-04-20 00:11:31 -07:00