32933 Commits

Author SHA1 Message Date
engine-flutter-autoroll
f78b1f3516
dfe67f4c7 Roll Skia from 1b3aa8b6e1cc to f6a5c806294d (11 revisions) (flutter/engine#39027) (#118874) 2023-01-20 09:07:55 +00:00
Taha Tesser
74645b43aa
Fix NavigationBar indicator ripple doesn't account for label height (#117473) 2023-01-20 08:48:06 +00:00
engine-flutter-autoroll
589f2eb9e2
d2436a536 Extract WideToUTF16String/UTF16StringToWide to FML (flutter/engine#39020) (#118873) 2023-01-20 08:23:09 +00:00
engine-flutter-autoroll
ee9c9b6927
3876320cb Roll Skia from aedfc8695954 to 1b3aa8b6e1cc (43 revisions) (flutter/engine#39024) (#118871) 2023-01-20 06:27:09 +00:00
engine-flutter-autoroll
52d1205b88
Roll Flutter Engine from 7d40e77d0035 to 730e88fb6787 (3 revisions) (#118869)
* 7bbe79e10 Extract WideToUTF16String/UTF16StringToWide to FML (flutter/engine#39006)

* acca56ce0 Revert "Extract WideToUTF16String/UTF16StringToWide to FML (#39006)" (flutter/engine#39019)

* 730e88fb6 [Impeller] Check the correct stencil coverage when deciding whether to elide a restore (flutter/engine#39023)
2023-01-20 04:50:24 +00:00
Michael Goderbauer
99b5262b21
Remove unnecessary null checks in dev/tools (#118845) 2023-01-20 04:06:09 +00:00
Michael Goderbauer
98c18ca93f
Remove unnecessary null checks in examples/ (#118848) 2023-01-20 04:06:04 +00:00
Michael Goderbauer
54217bd4b1
Remove unnecessary null checks in dev/benchmarks (#118840)
* Remove unnecessary null checks in dev/benchmarks

* empty
2023-01-20 04:04:11 +00:00
Michael Goderbauer
ec51d3271e
Remove unnecessary null checks in ‘dev/conductor’ (#118843)
* Remove unnecessary null checks in dev/conductor

* review
2023-01-20 04:04:08 +00:00
engine-flutter-autoroll
9acf34d0d9
Roll Flutter Engine from 26b6609c603b to 7d40e77d0035 (2 revisions) (#118852)
* 27f6bbcb3 Fix invalid Unix locale to Flutter locale (BCP-47) mapping (flutter/engine#36512)

* 7d40e77d0 Roll Skia from 69d8378097df to aedfc8695954 (4 revisions) (flutter/engine#38966)
2023-01-20 04:04:06 +00:00
Jenn Magder
030288d33b
Revert "[macos] add flavor options to commands in the flutter_tool (#118421)" (#118858)
This reverts commit 73096fd96ef53aacf47d8cfc606cc70126e88941.
2023-01-20 03:46:45 +00:00
Alex Wallen
73096fd96e
[macos] add flavor options to commands in the flutter_tool (#118421)
* Add new macos target configured for flavors

* Rename Free App copy-Info.plist to Free App Info.plist

* Remove bogus entitlements

* Remove Generated.xcconfig

* Audit project.pbxproj

* Remove unused configs

* share one info.plist

* Modify scheme so that paid app works

* Codesign automatic

* Pipe flavor as scheme into xcodebuild

* Ignore incoming flavor string

* pipe flavor for flutter run to work

* Add devicelab tests

* Error if host and target device are same for flutter install desktop

* Avoid bang (!) by promoting a local.

Co-authored-by: Jenn Magder <magder@google.com>

* Add supportsInstall property

* Override  in test classes

* Add install test on macOS

* Refactor application_package and add tests for package directory

Co-authored-by: a-wallen <stephenwallen@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
2023-01-19 23:52:16 +00:00
Danny Tuppeny
09bd0f6613
Support logging 'flutter run' communication to DAP clients (#118674)
* Support logging 'flutter run' communication to DAP clients

Fixes https://github.com/Dart-Code/Dart-Code/issues/4266.

* Fix test
2023-01-19 23:50:33 +00:00
engine-flutter-autoroll
818bb4e65e
Roll Flutter Engine from 78bbea005d27 to 26b6609c603b (3 revisions) (#118839)
* f2536ce8d Shader analysis with malioc (flutter/engine#39005)

* dd8c259bb [Impeller] Account for the transform in DLVerticesGeometry coverage (flutter/engine#38998)

* 26b6609c6 Remove unused variables and import (flutter/engine#38971)
2023-01-19 23:26:52 +00:00
David Landeros
c5ceff11dd
[flutter_tools] Ensure service worker starts caching assets since first load (#116833)
* [Flutter_tools] Ensure service worker starts caching assets since the first launch

* [flutter_tools] add comment to give some context on self.clients.claim()

* [flutter_tools] add comment to give some context on self.clients.claim()
2023-01-19 21:52:52 +00:00
engine-flutter-autoroll
99e4ca50c5
Roll Flutter Engine from 29a0582a1d5f to 78bbea005d27 (2 revisions) (#118829)
* a0e3c14d4 Merge MSAA alert functionality with UIA (flutter/engine#38745)

* 78bbea005 [web] dont look up webgl params if no GPU is available (flutter/engine#38948)
2023-01-19 21:45:17 +00:00
Alex Wallen
22520f54df
[macOS] Add timeline summary benchmarks (#118748)
* Add new task runner for impeller enabled complex layout test

* Add new target in .ci.yaml

* Claim ownership of complex_layout_scroll_perf_impeller_macos__timeline_summary

* Task runner for non-impeller enabled scroll test

* Add test target for non impeller complex layout scroll

* claim ownership of the last target

* mark as bringup

Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-19 21:29:19 +00:00
Alex Wallen
1dd7f45bfb
Add build macos --config-only option. (#118649)
Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-19 21:29:17 +00:00
Jenn Magder
2258590a82
Do not run Mac_arm64_ios run_debug_test_macos in presubmit during iPhone 11 migration (#118828) 2023-01-19 12:50:40 -08:00
Jenn Magder
cbf2e16892
Revert "Support iOS wireless debugging (#118104)" (#118826)
This reverts commit 5cd2d4c61eff43c4f8ca676b73eb342c49647c93.
2023-01-19 12:31:53 -08:00
Victoria Ashworth
5cd2d4c61e
Support iOS wireless debugging (#118104)
* setup wireless debugging to use device IP

* fix tests

* fix unused var and missing annotation

* remove unneeded try catch

* remove commented out line, change null to package id

* better way to get package id

* update mDNS lookup to continously check for server, add messaging if takes too long to find observatory url, update flutter drive to enable publish-port if using network device

* Refactor mDNS Discovery to poll for observatories and better handle multiple instances of the same app. Update drive command to make publish-port more stable. Update attach for iOS to only use Protocol Discovery if applicable, run mDNS and Protocol Discovery simultaneously, handle --debug-port/--debug-url/--device-vmservice-port, continously poll for obseravtories with mDNS, include port in error message when mutliple available

* add and update comments, use logger spinner intead of timer in flutter attach, other small improvements

* add newline to message so next log won't be on same line

* fix install/waiting for permission status progress so it doens't double print the time it took.

* only print backtrace if observatory times out on a physical usb connected device

* fix test

* Update related references from Observatory to Dart VM Service

* fix test
2023-01-19 20:00:21 +00:00
engine-flutter-autoroll
67ffaef253
29a0582a1 Roll Fuchsia Mac SDK from tlYMsnCv86Fjt5LfF... to 6oiZwMyNsjucSxTHJ... (flutter/engine#39004) (#118817) 2023-01-19 19:57:58 +00:00
yusuf-goog
9b5ea30a9c
Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807)
This will run tests on new iphone11 devicelab devices
which are running iOS-16.

Bug:https://github.com/flutter/flutter/issues/117237
2023-01-19 19:54:10 +00:00
Mitchell Goodwin
ea36b3a5a7
Add focus detector to CupertinoSwitch (#118345)
* Add focus detector to CupertinoSwitch

* Add comment

* Remove whitespace

* Add focusColor constructor to CupertinoSwitch

* Remove whitespace

* Add color type

* Remove gap in border

* Adjust color and line thickness
2023-01-19 18:30:06 +00:00
Mitchell Goodwin
b9ab640491
Remove incorrect statement in documentation (#118636) 2023-01-19 09:50:19 -08:00
engine-flutter-autoroll
46c7fd14da
88e61d8bd Remove references to Observatory (flutter/engine#38919) (#118793) 2023-01-19 15:55:24 +00:00
Danny Tuppeny
06909ccfa4
Update packages + fix tests for javascript mime change (#118617)
Update test expectations from application/javascript -> text/javascript

`package:mime` now uses `text/javascript` and not `application/javascript`.

See https://github.com/dart-lang/mime/pull/76.
See https://datatracker.ietf.org/doc/html/rfc9239.

> This document defines equivalent processing requirements for the various script media types. The most widely supported media type in use is `text/javascript`; all others are considered historical and obsolete aliases of `text/javascript`.
2023-01-19 09:54:40 -05:00
Mingyu
213b3cb3d8
Check whether slider is mounted before interaction, no-op if unmounted (#113556)
* Check whether slider is unmounted before interaction

* Update slider.dart

* Update Slider

* Add test

* Update slider_test.dart

* Update packages/flutter/test/material/slider_test.dart

Co-authored-by: Taha Tesser <tessertaha@gmail.com>

Co-authored-by: Taha Tesser <tessertaha@gmail.com>
2023-01-19 13:35:34 +00:00
Taha Tesser
3e71e0caf4
Updated ListTile documentation, add Material 3 example and other ListTile examples fixes. (#118705) 2023-01-19 11:05:30 +00:00
Alex Wallen
d53cc4a10f
[macOS] New e2e_summary benchmark fails without Cocoapods. (#118754)
* Add gems as a dep - fails without

* Add missing entitlements to run app on macos

Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-19 08:04:22 +00:00
engine-flutter-autoroll
0bbb5ec0c2
40f7f0f09 Roll Fuchsia Mac SDK from P5QcCJU8I71xVXuMT... to tlYMsnCv86Fjt5LfF... (flutter/engine#38994) (#118771) 2023-01-19 06:22:08 +00:00
engine-flutter-autoroll
6a9b2db4ac
95b0c151f Roll Dart SDK from 645fd748e79e to ddf70a598f27 (14 revisions) (flutter/engine#38990) (#118763) 2023-01-19 02:03:37 +00:00
Ricardo Amador
e5c9d065fc
Forgot to remove emulator flag. (#118762) 2023-01-19 01:49:50 +00:00
engine-flutter-autoroll
21fb443a3b
8ed6790b5 Bump chrome_and_driver version to 110. (flutter/engine#38986) (#118758) 2023-01-19 00:49:36 +00:00
engine-flutter-autoroll
2609212ca7
2a11023c7 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) (#118751) 2023-01-19 00:03:51 +00:00
Jenn Magder
ffcf63ae88
Add verbose flag to plugin_dependencies_test to debug flake (#118755) 2023-01-19 00:02:25 +00:00
dependabot[bot]
b3059d2c09
Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (#118745)
Bumps [activesupport](https://github.com/rails/rails) from 6.1.5 to 6.1.7.1.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v7.0.4.1/activesupport/CHANGELOG.md)
- [Commits](https://github.com/rails/rails/compare/v6.1.5...v6.1.7.1)

---
updated-dependencies:
- dependency-name: activesupport
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-18 23:27:27 +00:00
engine-flutter-autoroll
6f708305d5
Roll Flutter Engine from c52b290813bd to 290636c1cb6b (2 revisions) (#118743)
* 2722c548b Remove use of SkTAddOffset and sk_careful_memcpy (flutter/engine#38977)

* 290636c1c Get unit tests working with dart2wasm (flutter/engine#38784)
2023-01-18 23:02:23 +00:00
Eilidh Southren
7d9eaab014
Appbar iconTheme override fix (#118681)
* theme override fix

* add conditional centering
2023-01-18 23:00:09 +00:00
Michael Goderbauer
11d21e066b
Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments (#118738) 2023-01-18 22:56:24 +00:00
Justin McCandless
d07b88e4c7
Docs fix an=>a (#118652) 2023-01-18 22:52:24 +00:00
Alex Wallen
666dccc85e
[macOS] bringup new e2e_summary devicelab test (#118717)
* Add new task runner for animated_complex_opacity_perf_impeller e2e_summary on macos

* Register new target for macos e2e_summary task

* Claim ownership in TESTOWNERS

* Add task runner for animated complex opacity without impeller

* Register new target in .ci.yaml for non-impeller test

* Claim ownership of non-impeller task

Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-18 22:33:49 +00:00
dependabot[bot]
2b3ca0dc46
Bump github/codeql-action from 2.1.38 to 2.1.39 (#118735)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.38 to 2.1.39.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](515828d974...a34ca99b46)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-18 22:10:55 +00:00
Chris Yang
c83a698556
update uikit view documentation (#118715)
* update uikit view documentation

* fix
2023-01-18 22:09:10 +00:00
Nicholas Shahan
bb8b96a5d0
Fix path for require.js (#118722)
Matches new location in the Dart SDK.
https://dart-review.googlesource.com/c/sdk/+/275482

Includes fall back logic so the old file location will continue to be used
until the new location change lands. Then we can remove the logic and only
use the new location in a future change.

Issue: #118119
2023-01-18 17:03:55 -05:00
Michael Goderbauer
ae1cc18c4e
remove single-view assumption from paintImage (#118721)
* remove single-view assumption from paintImage

* dpr

* fix test for web
2023-01-18 21:22:36 +00:00
Christopher Fujino
374f09e1a6
[flutter_tools] No more implicit --no-sound-null-safety (#118491)
* remove implicit no-sound-null-safety

* add test

* bump sdk constraint in test file
2023-01-18 20:46:09 +00:00
engine-flutter-autoroll
8a58ec5c32
Roll Flutter Engine from f79030440948 to c52b290813bd (29 revisions) (#118720)
* 5aee7914c Roll Dart SDK from 645fd748e79e to 0097dcbada06 (3 revisions) (flutter/engine#38883)

* 78a68b9df Roll Skia from c64a10d525d1 to aa99fa0bdd31 (10 revisions) (flutter/engine#38886)

* 398af8c20 Roll Fuchsia Mac SDK from w0hr1ZMvYGJnWInwK... to nPbEqgIfE8TLOokQH... (flutter/engine#38889)

* 703502712 Roll Skia from aa99fa0bdd31 to 5a51583d09dd (2 revisions) (flutter/engine#38892)

* 2075cf3f8 Roll Fuchsia Mac SDK from nPbEqgIfE8TLOokQH... to SmEVvAFBC8oriPBou... (flutter/engine#38897)

* ef06ef602 Roll Skia from 5a51583d09dd to 34a14247bd4b (1 revision) (flutter/engine#38901)

* 0d374a919 Roll Skia from 34a14247bd4b to c727016cc09e (1 revision) (flutter/engine#38903)

* 31f2020d9 Roll Skia from c727016cc09e to 214411b09e92 (2 revisions) (flutter/engine#38907)

* a3006de27 Bump actions/setup-python from 4.4.0 to 4.5.0 (flutter/engine#38909)

* eacc09c47 Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter/engine#38910)

* c33c11c93 Roll Skia from 214411b09e92 to 3704033dd106 (1 revision) (flutter/engine#38908)

* afa093dbe [Impeller] Map UVs correctly for TiledTextureContents (flutter/engine#38894)

* 46ea2b3cc Roll Fuchsia Mac SDK from SmEVvAFBC8oriPBou... to bZfX8KCoI3CfxEzsG... (flutter/engine#38912)

* aadb97112 Roll Skia from 3704033dd106 to 58e745419425 (4 revisions) (flutter/engine#38936)

* 24b21a5b4 Roll Fuchsia Mac SDK from bZfX8KCoI3CfxEzsG... to iwCuzAuMgsk75hlT0... (flutter/engine#38938)

* e65558087 Roll Skia from 58e745419425 to 6afb97022fa7 (1 revision) (flutter/engine#38943)

* 5932badce Revert "Revert "[web] Don't overwrite editing state with semantic updates (#38271)" (#38562)" (flutter/engine#38854)

* 928772eba [web] Reduce code size impact of fallback font data (flutter/engine#38787)

* 88a8d9a36 Roll Skia from 6afb97022fa7 to 8ea9b39f7213 (18 revisions) (flutter/engine#38952)

* 3a479434b Roll Skia from 8ea9b39f7213 to 69d8378097df (6 revisions) (flutter/engine#38953)

* 641623a51 wrap focus() in a post update callback (flutter/engine#38958)

* 7d71ee3bf Roll Fuchsia Mac SDK from iwCuzAuMgsk75hlT0... to -1N2YUML8GqNhK8YP... (flutter/engine#38960)

* d762142bb reland fix canvas drawLine bugs (flutter/engine#38949)

* 0d7953387 [Impeller] Fix back-to-back clip restoration (flutter/engine#38964)

* 19fe86ca9 Update scenario screenshots to iOS 16 (flutter/engine#38962)

* eb18ac0a7 Fix iOS safari keyboard issue when semantics is enabled (flutter/engine#38822)

* 84a73d92f [Impeller Scene] Add SceneNodeValue for synchronously fetching loaded ipscenes (flutter/engine#38913)

* 7bff5dd11 Revert "Roll Dart SDK from 645fd748e79e to 0097dcbada06 (3 revisions) (#38883)" (flutter/engine#38973)

* c52b29081 Roll Fuchsia Mac SDK from -1N2YUML8GqNhK8YP... to P5QcCJU8I71xVXuMT... (flutter/engine#38976)
2023-01-18 20:38:27 +00:00
Paul Berry
997d43618d
Fix applyBoxFit's handling of fitWidth and fitHeight. (#117185)
* Fix applyBoxFit's handling of fitWidth and fitHeight.

Previously, in `fitWidth` mode, if the input size had a wider aspect
ratio than the output size, `applyBoxFit` would make the source rect
taller than the input size in order to match the aspect ratio of the
destination rect.  Similarly, in `fitHeight` mode, if the input size
had a taller aspect ratio than the output size, `applyBoxFit` would
make the source rect wider than the input size in to match the aspect
ratio of the destination rect.  This is in contrast to all the other
modes, which never output a source rect that's larger than the input
size.

Most of the time this worked as intended (since attempting to blit
pixels that are outside the source image has no effect), however it
meant that if a user attempted to create a `BoxDecoration` that used
both `fitWidth` and `repeatY` (e.g. in an attempt to tile a background
image), the image would not actually appear to repeat, since the logic
in `paintImage` for determining the proper tiling stride is based on
the destination image size, meaning that the entire destination rect
would be covered in a single tile.

This change modifies `applyBoxFit` so that in `fitWidth` mode, if the
input size has a wider aspect ratio than the output size, it uses
formulas that are equivalent to `contain`, whereas if the input size
has a taller aspect ratio than the output size, it uses formulas that
are equivalent to `cover`.  And vice versa for `fitHeight` mode.  This
produces source and destination rects that match the behaviour
specified in https://api.flutter.dev/flutter/painting/BoxFit.html.

* Apply suggestions from code review

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-01-18 18:06:18 +00:00
engine-flutter-autoroll
6277520646
Roll Plugins from 4e5cf2d2da27 to 11361d01099d (4 revisions) (#118682)
* 6ef1bc1da Roll Flutter from 8c2fdb803e49 to cc7845e71a9d (2 revisions) (flutter/plugins#6983)

* 56ab33fd1 [shared_pref]: Bump mockito-inline (flutter/plugins#6976)

* e85e0f28f [camera] Allow logical cameras to use all physical cameras via zoom on android 11+ (flutter/plugins#6150)

* 11361d010 [camera] Use startVideoCapturing and expose concurrent stream/record (flutter/plugins#6815)
2023-01-18 17:59:20 +00:00