11399 Commits

Author SHA1 Message Date
Viet Do
953db753ab
Adding multicolumn cupertino picker to the Gallery. (#19284)
* Add sample of multicolumn picker to Flutter Gallery
* Modify CupertinoPicker to be able to be rendered off-center.
2018-07-18 16:29:26 -07:00
Hans Muller
ba1a18f45c
Small update to the Text.rich API doc (#18721) 2018-07-18 16:10:58 -07:00
Chris Bracken
c0294e3a02
Eliminate Dart 1 benchmarks (#19430)
Flutter app development has been Dart 2 only for a significant amount of
time, and we're about to remove all support for Dart 1.
2018-07-18 15:56:51 -07:00
xster
d07d6ac36e
Fix sliver padding safe area for material gallery (#19497) 2018-07-18 15:46:51 -07:00
amirh
48f441723d
Introduce PlatformViewsService for controlling platform views. (#19325)
Currently only Android views are supported.

This also includes a FakePlatformViewsController which is a fake
implementation of the engine side for testing.
2018-07-18 15:45:54 -07:00
Matt Sullivan
cf83b790f5
Chevrons fade out completely on month picker scroll event (#19422) 2018-07-18 15:44:35 -07:00
Greg Spencer
2af2a08288
Turn on MacOS tests on Cirrus (#19424)
Cirrus CI has macOS VMs, so this turns on an instance for tests so that we can evaluate if we can use Cirrus for all three platforms or not.
2018-07-18 15:33:38 -07:00
Zachary Anderson
dae3959d47
[fuchsia] Add new package dep to BUILD.gn file (#19533) 2018-07-18 14:41:03 -07:00
Ian Hickson
089f59d2c5
Clean up golden files (#19440)
Makes them all be generated on Linux and fixes some to not be so large.
2018-07-18 12:01:56 -07:00
Michael Goderbauer
7a9dd709c6 mark flaky benchmarks as flaky (#19492) 2018-07-18 11:11:39 -07:00
Ryan Macnak
3840719987
Make initialSemanticsTreeCreation less sensitive to GC timing. (#19491)
Bug: https://github.com/flutter/flutter/issues/19435
2018-07-18 10:00:16 -07:00
Ryan Macnak
b8b6d4166c
Build snapshots with --sync-async to match the engine. (#19495)
Bug: https://github.com/flutter/flutter/issues/19494
2018-07-17 18:07:54 -07:00
Michael Goderbauer
4afc9f8930
Roll engine to 5557e3006e8346b2d3cccf3fa68859a00947641f (#19489) 2018-07-17 16:59:36 -07:00
Jason Simmons
ccdf078f98
Fix return types of commands that override verifyThenRunCommand (#19483)
Fixes https://github.com/flutter/flutter/issues/19465
2018-07-17 15:24:36 -07:00
xster
85f09f622e
Revert engine roll to 316b026807c50d65ba1b6724ac954711683f1b01
This reverts commit b0eb1632d37feaf835d76d75108940cb2269d25b.
2018-07-16 22:42:06 -07:00
xster
b0eb1632d3
roll engine to 316b026807c50d65ba1b6724ac954711683f1b01 (#19419) 2018-07-16 18:59:00 -07:00
Ian Hickson
f630f90d6d
Revert "enable lint unnecessary_const (#19342)" (#19423)
This reverts commit cc1cf13eec6752af992d3db0265cf04cc90bfd13.
2018-07-16 13:30:27 -07:00
Alexandre Ardhuin
cc1cf13eec
enable lint unnecessary_const (#19342) 2018-07-16 21:43:48 +02:00
Matt Sullivan
d10e46ea65
Chevrons in month picker are semi-transparent when the month is scrolled (#19363)
* Chevrons in month picker are semi-transparent when the month is scrolled

* Added type missing annotation
2018-07-16 11:57:25 -07:00
Sigurd Meldgaard
6a8f904104
Revert "Use FlutterProject to locate files (#18913)" (#19409)
This reverts commit 57d78cc739a1d21a981886d424a6a104c8d48e33.
2018-07-16 16:21:20 +02:00
Sigurd Meldgaard
f93a65a7f7
Extra debug information in run_release_test (#19405) 2018-07-16 15:46:19 +02:00
Sigurd Meldgaard
f6b234a0ea
Fix typo (#19402) 2018-07-16 14:23:25 +02:00
Sigurd Meldgaard
57d78cc739
Use FlutterProject to locate files (#18913) 2018-07-16 09:39:37 +02:00
amirh
e7832a3897
Revert "roll engine to 9af920ef22f311588b649ba876127993f5c1362c (#19365)" (#19376)
This reverts commit 44995dc42bc06ba9042f22707a3f9f78c21b7100.
2018-07-14 09:32:41 -07:00
amirh
44995dc42b
roll engine to 9af920ef22f311588b649ba876127993f5c1362c (#19365) 2018-07-14 08:14:46 -07:00
Jonah Williams
e4e8ab47a3
increase cache size if image is loaded that is larger than max size (#19352) 2018-07-13 21:51:00 -07:00
Greg Spencer
5d0d1b038f
Add Bash and Zsh command-line completion for flutter (#19243)
This uses @kevmoo's completion package to do command line completion for flutter, and a new command "bash-completion" (with alias "zsh-completion") that will output the necessary shell script setup code, and adds the hidden command "completion" that does the actual completion.

Because it adds a dependency, I also had to do flutter update-packages --force-upgrade.

Fixes #18988.
2018-07-13 21:24:36 -07:00
Jonah Williams
1b35cc2cc2
Support keyboardAppearance field for iOS (#19244) 2018-07-13 20:41:55 -07:00
Jonah Williams
2f0b4158ab
Add option to silence driver extension errors (#19247) 2018-07-13 19:13:10 -07:00
xster
e32e44799a
Add HeroController to CupertinoApp (#19326) 2018-07-13 16:46:01 -07:00
Jonah Williams
8359d99e48
have text finder convert Text.rich to plain text for comparison (#19270) 2018-07-13 13:00:58 -07:00
Hans Muller
698bda6ada
Correct contentPadding type in InputDecoration.debugFillProperties (#19318) 2018-07-13 10:37:55 -07:00
Gary Miguel
35f374036c Revert "Revert "Use runTests in fuchsia tester. (#19178)" (#19321)" (#19327)
This reverts commit e22f99743b4f0bea4a9b8e7703ce5ffbfda37a04.

Adding the exit(exitCode) fixes the hang.
Tested by running `fx run-host-tests` with a topaz checkout.
Verified the hang before, no hang after.
2018-07-13 10:37:44 -07:00
Jonah Williams
579d2fba99
Roll engine to c5a63d (#19288) 2018-07-13 10:35:23 -07:00
Alexander Aprelev
7ebf2728dc
Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295)" (#19322)
This reverts commit cc122f1672d4b7e0c0734be34a155997463e3b56.
2018-07-12 14:59:22 -07:00
Zachary Anderson
e22f99743b
Revert "Use runTests in fuchsia tester. (#19178)" (#19321)
This reverts commit 032f8cdb8b563bdc200acdce068945a834bf2271.

The test runner hangs on exit after all tests pass when trying
to roll this into Fuchsia.
2018-07-12 14:18:29 -07:00
Alexander Aprelev
b075229d85
Preserve original kernel file for isolate spawn requests. (#18127)
* Preserve original kernel file for isolate spawn requests.

This change gives incremental kernel files ".incremental.dill" extension thereby preserving original kernel file.

Bug: https://github.com/flutter/flutter/issues/16084
Bug: https://github.com/flutter/flutter/issues/17012
Bug: https://github.com/flutter/flutter/issues/17983

* Factor out naming logic into separate function

* Fix string vs uri
2018-07-12 13:41:15 -07:00
Danny Tuppeny
1363bd1795
Ensure timeouts in flutter_tools integration tests include all messages received (#19253)
* Allow a longer timeout for app launches

* Include timings in errors when waiting for events

* Extract a helper that adds a timeout and includes message logging

* Ensure all timeouts include messages

* Ensure logs are set up before we invoke actions

* Ensure all messages are logged during timeout periods

This adds a new stream _allMessages that collects all output (as routed through debugPrint) and updates _timeoutWithMessages to use that instead of stdin/out of only the flutter run process (since that was missing stdin - the sends, and both input/output to the VM service).
2018-07-12 18:17:33 +01:00
Danny Tuppeny
2e215fdfe4
Align expressions better (#19256) 2018-07-12 16:24:39 +01:00
Hans Muller
fbf9044867
Update translation descriptions: alertDialogLabel, searchFieldLabel (#19234) 2018-07-12 08:21:59 -07:00
Alexander Aprelev
cc122f1672
Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295)
This reverts commit 700cb767c9b41c9db1686e9999776bc9f4126b8f as it
breaks Windows tests.
2018-07-11 19:52:28 -07:00
Alexander Aprelev
700cb767c9
Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)
* Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276)"

This reverts commit cf932490b77c95841e8798e4864ac3e473a79e18 as it also
includes fix for type error that broke tests.

* Add type cast for dart2 type checks.

* Move up to latest goldens

* Make inDirectory() type-parameterized.

* Add typecasting to transitions_perf_test.dart and microbenchmarks.

* Add boolean flag initialization in save_catalog_screenshots.dart

* Add type conversion to gallery transition test
2018-07-11 19:26:33 -07:00
Chris Bracken
379a2d5654
Push /usr/bin to front of PATH for ios-deploy runs (#19281)
ios-deploy relies on LLDB.framework, which relies on /usr/bin/python and
the 'six' module that's installed on the system. However, it appears to
use the first version of Python on PATH, rather than explicitly
specifying the system install.  If a user has a custom install of Python
(e.g., via Homebrew or MacPorts) ahead of the system Python on their
PATH, LLDB.framework will pick up that version instead. If the user
hasn't installed the 'six' module, ios-deploy will fail with a
relatively cryptic error message.

This patch pushes /usr/bin to the front of PATH for the duration of the
ios-deploy run to avoid this scenario.

This patch also removes checks for package six.

Neither Flutter nor any of its direct dependencies/tooling relies on
package six. ios-deploy depends on LLDB.framework (included with Xcode),
which relies on a Python script that imports this package but uses
whichever Python is at the front of the path. Flutter now invokes
ios-deploy with a PATH with /usr/bin forced to the front in order to
avoid this problem.

We could have retained the check out of paranoia, but this seems
unnecessary since it's entirely possible LLDB.framework may one day drop
this dependency, in which case I'd expect the base system install of
Python would likely drop it as well.
2018-07-11 17:33:06 -07:00
xster
2c00e5f218
Add a doc describing where CupertinoSliverRefreshControl should be in a list of slivers (#19282) 2018-07-11 17:05:24 -07:00
jslavitz
94959a340c Fixed code sign error message width (#19026)
* Fixed codesign error message width

* Fixed mac_test

* Removed snackbar code
2018-07-11 16:51:25 -07:00
Ian Hickson
418b15354d
Update style for CupertinoRefreshControl. (#19025)
All slivers must start with Sliver (or CupertinoSliver).
All widgets must have a key argument.

Also, some minor tweaks here and there to style and docs.
2018-07-11 15:40:19 -07:00
Alexander Aprelev
cf932490b7
Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276)
This reverts commit f4a038da6328d437c9f0ca54d77ceb22779224a3 as it breaks microbenchmark tests.
2018-07-11 12:48:55 -07:00
Alexander Aprelev
f4a038da63
Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)
* Roll engine to rolled dart
Add connectionTimeout property to class that extends HttpOverrides.
Upgrade packages.
Add more type fixes.
Update goldens hash.
Add more type fixes.
Upgrade packages.
Fix tests.
Remove strong-mode from analysis options yaml file.
Increase dev/devicelab timeout from 2 to 10 seconds.
Added getVM to waitForViews. Fix type errors in compileExpression.

* Pick up engine revision with fix for microbenchmarks regression.
Increase default timeout from 20/30 to 60s.
2018-07-11 12:13:28 -07:00
Michael Goderbauer
36e16e7544
Do not assert when semantics are on and app draws on 0x0 surface (#19059)
Instead, if the surface is 0x0 semantics will just generate one root semantics node with size of 0x0. The node will have no children because all children are invisible and (except for the root node with this change) invisible children are dropped.
2018-07-11 09:46:24 -07:00
shrike69
2c070363c2
Use binary name to locate .packages file on Fuchsia (#19217) 2018-07-11 08:49:57 -07:00