11399 Commits

Author SHA1 Message Date
Danny Tuppeny
437731409e
Remove note about port being removed (#19263)
Some things require a port (eg. `flutter attach`) and will forward it on to the device, so we shouldn't force clients to parse it out of a uri.
2018-07-11 15:22:51 +01:00
Greg Spencer
2d76b465ef
Make HotRunner call pub get automatically if the pubspec is out of date. (#19183)
This adds a call to 'pub get' if the pubspec.yaml is out of date wrt the .packages file when a hot reload is requested.

Fixes #15879
2018-07-10 18:14:52 -07:00
Alexander Aprelev
acf3f3d839
Fix 'are there any views available' check (#19231) 2018-07-10 17:58:36 -07:00
Chris Bracken
02f4f32b5b
Revert "Roll engine to 4466d61a993fdbde2cb092b4da9bbef33d1962fe (#192… (#19233)
…30)"

Causes microbenchmarks to start failing. This included the following
engine PR, which appears to be the culprit:
* Remove vmservice_io.main from entry points. (flutter/engine#5625)

This reverts commit 3643790437f36a11e4ed19f76a1865ff3b0f3a4d.
2018-07-10 16:46:31 -07:00
Ian Hickson
b3a6eda2d1
Remove hacks that make macOs, Linux, and Windows not fail. (#19187)
They should fail, because we don't have real support yet.

Also, make the debug override work in release builds, so that people
on those platforms have a workaround.
2018-07-10 16:33:40 -07:00
Chris Bracken
3643790437
Roll engine to 4466d61a993fdbde2cb092b4da9bbef33d1962fe (#19230)
Includes:
* Remove vmservice_io.main from entry points. (flutter/engine#5625)
* Roll src/third_party/skia 7e2327b133db..723b1f6ef941 (1 commits) (flutter/engine#5642)
* Roll src/third_party/skia 24d18ced1ad7..7e2327b133db (6 commits) (flutter/engine#5641)
* Roll src/third_party/skia a1e5630183c1..24d18ced1ad7 (7 commits) (flutter/engine#5639)
2018-07-10 16:12:56 -07:00
liyuqian
160d92e350
Increase image cache to 100MB (#19220)
This should fix #18952 and #813
2018-07-10 15:28:47 -07:00
Chris Bracken
59d6527f07
Roll engine to ce06bbac58d7c68487dd09616864c904e2f71a72 (#19213)
* ensure a11y state is communicated back to flutter (flutter/engine#5631)
* Roll src/third_party/skia b1b87d9df81e..a1e5630183c1 (10 commits) (flutter/engine#5637)
* Roll src/third_party/skia 385804514edf..b1b87d9df81e (6 commits) (flutter/engine#5636)
* Roll src/third_party/skia e97bb26893a1..385804514edf (1 commits) (flutter/engine#5635)
* Roll src/third_party/skia e2e52e46ca63..e97bb26893a1 (1 commits) (flutter/engine#5634)
* Roll src/third_party/skia 14de25dfc7c4..e2e52e46ca63 (2 commits) (flutter/engine#5633)
* Roll src/third_party/skia 551dc3e91143..14de25dfc7c4 (2 commits) (flutter/engine#5630)
* libtxt: apply an offset to drawing operations instead of translating the canvas (flutter/engine#5628)
* Roll src/third_party/skia 059a9ab4bcd0..551dc3e91143 (5 commits) (flutter/engine#5629)
* Roll src/third_party/skia 45c9dab4c3ec..059a9ab4bcd0 (8 commits) (flutter/engine#5627)
* Remove some unused code from the Android host (flutter/engine#5619)
* Roll src/third_party/skia 37b7e4714558..45c9dab4c3ec (1 commits) (flutter/engine#5626)
* Roll src/third_party/skia c421ca1d6e41..37b7e4714558 (2 commits) (flutter/engine#5624)
* Roll src/third_party/skia 5b201e3b0ba8..c421ca1d6e41 (3 commits) (flutter/engine#5623)
* Roll src/third_party/skia d47fe095cf88..5b201e3b0ba8 (6 commits) (flutter/engine#5622)
* Roll src/third_party/skia 9c0ce41cf711..d47fe095cf88 (12 commits) (flutter/engine#5618
* Roll src/third_party/skia d4b2adeaa929..9c0ce41cf711 (7 commits) (flutter/engine#5617)
* Roll src/third_party/skia f46710802ad5..d4b2adeaa929 (1 commits) (flutter/engine#5616)
2018-07-10 15:16:53 -07:00
Chris Bracken
32af169946
Revert "Add segmented control to gallery (#19192)" (#19227)
This appears to trigger an error during AOT snapshot of the gallery as
follows:

```
stdout: [   +6 ms] Building AOT snapshot in release mode (ios-release)...
stdout: [  +15 ms] Extra gen_snapshot options: [--print_snapshot_sizes]
stdout: [   +7 ms] /usr/bin/arch -x86_64 /Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/gen_snapshot --await_is_keyword --causal_async_stacks --packages=.packages --url_mapping=dart:ui,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/lib/ui/ui.dart --url_mapping=dart:vmservice_io,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/sdk_ext/vmservice_io.dart --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_vm_entry_points.txt --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_io_entries.txt --print_snapshot_sizes --snapshot_kind=app-aot-assembly --assembly=build/aot/arm64/snapshot_assembly.S /Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/main.dart
stderr: [+9324 ms] Error: 'file:///Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/demo/cupertino/cupertino_segmented_control_demo.dart': error: line 19 pos 1: circular dependency for function _CupertinoSegmentedControlDemoState
stderr: [        ] class _CupertinoSegmentedControlDemoState extends State {
stderr: [        ] ^
stderr: [  +33 ms] Dart snapshot generator failed with exit code 254
stderr: [        ] Snapshotting (IOSArch.arm64) exited with non-zero exit code: 254
stdout: [        ] Built to build/aot/.
stdout: [  +10 ms] "flutter aot" took 9,485ms.
```

This reverts commit 9d49ee3bf06e634e53331b544dbb640453f81348.
2018-07-10 14:38:52 -07:00
Natalie Sampsell
9d49ee3bf0
Add segmented control to gallery (#19192)
* Adding segmented control to gallery
2018-07-10 11:17:47 -07:00
Leaf Petersen
3397338cdd
Fix use of Future<void> as a Future<bool> (#18843)
* Fix use of Future<void> as a Future<bool>
2018-07-10 11:10:48 -07:00
Danny Tuppeny
127d1f85dd
Improve error message in microbenchmarks when flutter run lives too long (#19200)
This should make it more obvious from the error what's gone wrong if we see a repeat of #19096 (previously the error was something like "Bad state: future already completed").
2018-07-10 17:09:39 +01:00
Danny Tuppeny
b931640c1d
Improve flutter tools integration tests (#18865)
* Rename util -> test_utils

* Rename flutter_test_driver -> test_driver

* Switch testWithContext -> test

* Remove unused import

* Move test project into a class to make it easier to have multiple of these

Each "TestProject" class can contain its files and things like named breakpoint locations.

* Split expression evaluation tests into own file

* Include last response in error messages

* Update expectations based on current bugs

* Fix async-ness in tests

* Fix incorrect expectation in test

* Fix incorrect evaluations

* Remove skips for tests that are now passing on master

* Expect pass on Linux

🤷‍♂️

* Call the code

* Skip expression evaluation tests on Windows

* Skip whole group, not just one test

* Remove duplicated method from merge

* Fix misplaced close of group

* Remove code that was duplicated from test we copied

Not sure how this ended up in here?

* Re-fix typo
2018-07-10 06:51:12 +01:00
Natalie Sampsell
236acb5219
Segmented control animation (#18811)
Added animation to segmented control widget.
2018-07-09 18:55:23 -07:00
Ian Hickson
03a1f4acb3
Remove bogus SDK constraint lines. (#19013) 2018-07-09 17:27:33 -07:00
Jonah Williams
35291ae3b9
Add ignoringFeedbackSemantics to Draggable/LongPressDraggable (#18643) 2018-07-09 17:02:21 -07:00
Hans Muller
d65acfc867
Updated the material localizations (#19174) 2018-07-09 16:47:45 -07:00
Hans Muller
8b5cbca765
Rebuilding BottomNavigationBar when items.length changes (#19179) 2018-07-09 16:47:12 -07:00
Gary Miguel
032f8cdb8b Use runTests in fuchsia tester. (#19178)
This allows us to collect code coverage for Fuchsia tests.
2018-07-09 16:13:10 -07:00
Jonah Williams
7dd265ff18
Add getSemanticsId command to flutter_driver (#19047) 2018-07-09 15:22:59 -07:00
Jonah Williams
41646c9579
Add new matcher and utility methods for testing semanics (#19046) 2018-07-09 15:21:46 -07:00
stuartmorgan
32941a8cc0 Add Windows support to defaultTargetPlatform (#19176)
A significant amonut of code uses defaultTargetPlatform, so it's
currently impossible to run most apps on Windows. This adds a mapping
from Windows as a host to Android as a target, paralleling the
macOS->iOS and Linux->Android mappings.

This allows more use of Windows as a host platform (e.g., for testing,
as in issue #17768).
2018-07-09 14:04:23 -07:00
Gary Miguel
66091f9696 Move collectCoverageData into CoverageCollector so it can be re-used. (#19055)
This will let us re-use that code from fuchsia_tester.dart.
Tested by running the stocks example tests with coverage collection before and after.
.lcov files are identical.
2018-07-09 12:52:41 -07:00
xster
17123f5312
Refer to Navigator.of(rootNavigator) in Cupertino tab widgets (#19130) 2018-07-09 12:31:43 -07:00
xster
e08177155e
Put the nav bar padding inside the CustomMultiChildLayout for correct centering and allow custom padding (#19129) 2018-07-09 12:27:24 -07:00
xster
5c8d7e3421
Adjust Cupertino controls's APIs to match Material (#19127) 2018-07-09 12:27:06 -07:00
Devon Carew
d3ad0729b7
remove an unused analysis options file (#19010) 2018-07-09 12:22:55 -07:00
Devon Carew
9d9836f080
adjust declared types to work with dart 2 typing at runtime (#19007)
* adjust declared types to work with dart 2 typing at runtime

* review comments

* update packages/flutter_tools/lib/src/ios/simulators.dart
2018-07-09 12:22:46 -07:00
Jonah Williams
77a528c417
Re-land #18369 (#19082) 2018-07-09 12:05:15 -07:00
Ralph Bergmann
779eea681f make tests in xcodeproj_test.dart and gradle_test.dart hermetic (#18093) (#18548) 2018-07-09 10:36:17 -07:00
Sigurd Meldgaard
5cbbd2831c
Fix path of ios module template files (#19037)
* Fix path of ios module template files

* Fix more paths
2018-07-09 11:56:39 +02:00
Danny Tuppeny
4630fa8e60
Additional integration test driver functionality (#19085)
* Add additional functionality to integration test driver

* Typo

* Remove delays we shouldn't need + comments

* Fix typos
2018-07-09 10:41:16 +01:00
Sigurd Meldgaard
064e40d803
Fix typo (#19160) 2018-07-09 10:55:18 +02:00
Hans Muller
7ac183794b
Deferred ListView.separator cleanups (#18720) 2018-07-06 15:21:29 -07:00
abykov2
e5d9feb59d Adding a setup function for hot restart (#18921)
* Adding a setup function for hot restart that can be overwritten to perform any necessary initialization before a restart is started.

* Adding a test for setupHotRestart

* Removing local pubspec change

* Fixing some type annotation errors

* Responding to comments
2018-07-06 15:18:57 -07:00
Alexander Aprelev
d5d129803a
Revert engine roll that caused microbenchmarks failures (#19123)
* Merge

* Update goldens
2018-07-06 13:53:30 -07:00
Danny Tuppeny
5413560415 Revert "Add temporary debug prints to identify devicelab failures (#19093)" (#19095)
This reverts commit edc16473bfdafc0f5fe546610d3b0fe0eecdd080.
2018-07-05 18:58:26 +02:00
Danny Tuppeny
edc16473bf
Add temporary debug prints to identify devicelab failures (#19093) 2018-07-05 14:16:44 +01:00
Danny Tuppeny
e1d396d5ca
Attempt to fix race in microbenchmark error handling code (#19092)
Await stream cancellations before trying to complete
2018-07-05 13:06:43 +01:00
Mikkel Nygaard Ravn
c34daae2d6
Avoid repeating microbenchmark (#19087) 2018-07-05 11:11:17 +02:00
xster
06f63aaa5a
Create a CupertinoApp (#18469) 2018-07-04 16:55:22 -07:00
matthew-carroll
aad1bb4b59
Roll engine to 21c7d6a5da47165d076928fbe460badbbead24cd (#19008)
* Roll engine to 21c7d6a5da47165d076928fbe460badbbead24cd

flutter/engine@21c7d6a Revert "Add antiAlias and saveCount to clipPath and restore (#5638)"
flutter/engine@70dcbb5 Roll src/third_party/skia d818ebf4a317..9aa30c6ee0e5 (11 commits)
flutter/engine@ad42324 Roll src/third_party/skia a219419c9d76..d818ebf4a317 (2 commits)
flutter/engine@f2eb83a Roll src/third_party/skia 00d2e8ebcb13..a219419c9d76 (1 commits)
flutter/engine@0ec7669 Roll src/third_party/skia 8451daabb23d..00d2e8ebcb13 (1 commits)
flutter/engine@061e899 Support all keyboard actions. (#11344)
flutter/engine@bc6b250 Roll src/third_party/skia 34024a7c478c..8451daabb23d (1 commits)
flutter/engine@df4dffb Roll src/third_party/skia 75e69028956d..34024a7c478c (1 commits)
flutter/engine@d8770d4 Roll src/third_party/skia cf863fb9b446..75e69028956d (1 commits)
flutter/engine@b88a8b3 Roll src/third_party/skia b7b9d02ac020..cf863fb9b446 (1 commits)
flutter/engine@2261ccf [fuchsia] Update scenic lib path.
flutter/engine@4c4ef98 [fuchsia] Rename scenic_lib => scenic
flutter/engine@f0c21f3 Roll src/third_party/skia 184d408b646b..b7b9d02ac020 (7 commits)
flutter/engine@a2bf805 Add antiAlias and saveCount to clipPath and restore
flutter/engine@9e450d1 Roll src/third_party/skia c91fe3ab1c5d..184d408b646b (10 commits)
flutter/engine@e663996 Roll src/third_party/skia eb8f8106f38c..c91fe3ab1c5d (5 commits)
flutter/engine@fecd66f Roll src/third_party/skia 723b1f6ef941..eb8f8106f38c (1 commits)
flutter/engine@4466d61 Remove vmservice_io.main from entry points.
flutter/engine@f279dfe Roll src/third_party/skia 7e2327b133db..723b1f6ef941 (1 commits)
flutter/engine@a885bd4 Roll src/third_party/skia 24d18ced1ad7..7e2327b133db (6 commits)
flutter/engine@ad1bd47 Roll src/third_party/skia a1e5630183c1..24d18ced1ad7 (7 commits)
flutter/engine@ce06bba ensure a11y state is communicated back to flutter
flutter/engine@c54a57e Roll src/third_party/skia b1b87d9df81e..a1e5630183c1 (10 commits)
flutter/engine@a9e5354 Roll src/third_party/skia 385804514edf..b1b87d9df81e (6 commits)
flutter/engine@2006e7d Roll src/third_party/skia e97bb26893a1..385804514edf (1 commits)
flutter/engine@2942061 Roll src/third_party/skia e2e52e46ca63..e97bb26893a1 (1 commits)
flutter/engine@e378811 Roll src/third_party/skia 14de25dfc7c4..e2e52e46ca63 (2 commits)
flutter/engine@48cc8f2 Roll src/third_party/skia 551dc3e91143..14de25dfc7c4 (2 commits)
flutter/engine@00ddf13 libtxt: apply an offset to drawing operations instead of translating the canvas
flutter/engine@2c5647c Roll src/third_party/skia 059a9ab4bcd0..551dc3e91143 (5 commits)
flutter/engine@9e44004 Roll src/third_party/skia 45c9dab4c3ec..059a9ab4bcd0 (8 commits)
flutter/engine@fbb3436 Remove some unused code from the Android host
flutter/engine@36f3f95 Roll src/third_party/skia 37b7e4714558..45c9dab4c3ec (1 commits)
flutter/engine@57e2e0c Roll src/third_party/skia c421ca1d6e41..37b7e4714558 (2 commits)
flutter/engine@ce417e2 Roll src/third_party/skia 5b201e3b0ba8..c421ca1d6e41 (3 commits)
flutter/engine@05f5a18 Roll src/third_party/skia d47fe095cf88..5b201e3b0ba8 (6 commits)
flutter/engine@33b70e0 Roll src/third_party/skia 9c0ce41cf711..d47fe095cf88 (12 commits)
flutter/engine@7dab419 Roll src/third_party/skia d4b2adeaa929..9c0ce41cf711 (7 commits)
flutter/engine@d3fa01a Roll src/third_party/skia f46710802ad5..d4b2adeaa929 (1 commits)
2018-07-04 15:51:26 -07:00
Mikkel Nygaard Ravn
5faac99d92
Fix typos (#19073) 2018-07-04 14:03:01 +02:00
Mikkel Nygaard Ravn
9b3f50b7bc
Fix typos (#19067) 2018-07-04 11:07:14 +02:00
Mikkel Nygaard Ravn
84e77ed20a
Fix typos (#19065) 2018-07-04 09:31:05 +02:00
Yun
34238f54eb make edit in README.md (#18981) 2018-07-03 15:50:58 -07:00
Jonah Williams
cabe09a532
Revert "Add flag to ThemeData to expand tap targets of certain material widgets (#18369)" (#19053)
This reverts commit 989f5741da9e4e8a9ae40d2ec9fbe33f11aba177.
2018-07-03 15:26:35 -07:00
sandrasandeep
581df52a86
Make EditableText cursor configurable (#18888)
* fixed segmented control golden test

* fixed segmented control golden test

* added cursorWidth, cursorRadius

* added default value for cursorWidth based on Apple specs

* test default cursorWidth

* removed cursorHeight stuff

* added functionality to keep cursor from blinking

* cursor width and radius is configurable + tests

* changed goldens repo version in goldens.version

* working version of configurable cursor (erased debugKeepCursorOn)

* minor changes

* docs

* changed textfield test that was failing due to new default cursorwidth

* added default value of cursorwidth in RenderEditable

* only run golden file tests on Mac

* cursor tests

* the tests are actually there now

* weak warning fixed

* switching to Linux

* changed default cursorWidth: 2.0 -> 1.0

* assorted changes, including changing text field test

* re-paint -> re-layout when changing cursorWidth
2018-07-03 14:02:00 -07:00
Jonah Williams
989f5741da
Add flag to ThemeData to expand tap targets of certain material widgets (#18369) 2018-07-03 10:55:43 -07:00
Danny Tuppeny
6172e23c21
Upgrade node on travis (#18994)
* Upgrade to current LTS version of Node

The version of NPM with Node 6 is over a year old and frequently hangs trying to install Firebase tools.

* Temporarily comment out this condition so the install runs on Travis

* Revert "Temporarily comment out this condition so the install runs on Travis"

This reverts commit 74db9366b4b1b094369388ef50fb26f3b7fd3104.

* Pin to nodejs v8.1
2018-07-03 15:34:55 +01:00