engine-flutter-autoroll
99dcbf80f9
Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) ( #148441 )
...
cd150986ae...f6195e9d4bskia-flutter-autoroll@skia.org Roll Dart SDK from f773d45634ed to a9651de827d8 (1 revision) (flutter/engine#52861 )
2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from 0f737206b709 to 2d0d1f7833bb (1 revision) (flutter/engine#52860 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-16 00:17:27 +00:00
Polina Cherkasova
86eecd3b04
Fix leaky tests. ( #148434 )
2024-05-15 16:52:17 -07:00
engine-flutter-autoroll
cc2bc89aa8
Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) ( #148430 )
...
41b86b59f0...cd150986aeskia-flutter-autoroll@skia.org Roll Skia from b9a304eb05d2 to 0f737206b709 (3 revisions) (flutter/engine#52858 )
2024-05-15 matanlurey@users.noreply.github.com Short-circuit crawling all targets in `et {build|test|query}` (flutter/engine#52832 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 22:28:09 +00:00
engine-flutter-autoroll
3b92ff1156
Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) ( #148428 )
...
bf1c6da0dd...41b86b59f0skia-flutter-autoroll@skia.org Roll Skia from 475559da107d to b9a304eb05d2 (1 revision) (flutter/engine#52857 )
2024-05-15 magder@google.com Migrate TextInputSemanticsObject to ARC (flutter/engine#52785 )
2024-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from NbCi2ETfLHPLLB-JV... to Ftw7GopnudHydGS1y... (flutter/engine#52853 )
2024-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 7d9de0c0b231 to f773d45634ed (2 revisions) (flutter/engine#52854 )
2024-05-15 zanderso@users.noreply.github.com Roll buildroot (flutter/engine#52826 )
2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from 4a7419d662d5 to 475559da107d (5 revisions) (flutter/engine#52848 )
2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from a9ba7411d4b2 to 4a7419d662d5 (1 revision) (flutter/engine#52844 )
2024-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 1eec9de2f9c6 to 7d9de0c0b231 (1 revision) (flutter/engine#52841 )
2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from b3aadd56d187 to a9ba7411d4b2 (1 revision) (flutter/engine#52839 )
2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from c0caf10486ce to b3aadd56d187 (3 revisions) (flutter/engine#52837 )
2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from fad584324d85 to c0caf10486ce (1 revision) (flutter/engine#52835 )
2024-05-15 magder@google.com Migrate SemanticsObject and FlutterSemanticsScrollView to ARC (flutter/engine#52824 )
2024-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b77fbab8cf5 to 1eec9de2f9c6 (1 revision) (flutter/engine#52833 )
2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from d0d87c26b489 to fad584324d85 (1 revision) (flutter/engine#52831 )
2024-05-15 matanlurey@users.noreply.github.com Re-add `MipFilter::kBase`, but keep `kNearest` as the default. (flutter/engine#52779 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from NbCi2ETfLHPL to Ftw7GopnudHy
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 21:49:40 +00:00
hangyu
6826fc08fa
Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not ( #147901 )
...
follow up on comments on https://github.com/flutter/engine/pull/52350
2024-05-15 20:57:18 +00:00
Valentin Vignal
8b129b9b89
Fix memory leaks in _PopupMenuRoute ( #148373 )
2024-05-15 13:50:03 -07:00
Valentin Vignal
ffae7c60c2
Add clipBehavior to DrawerThemeData ( #148061 )
...
Fixes https://github.com/flutter/flutter/issues/148060
2024-05-15 18:37:07 +00:00
Justin McCandless
8e35cf5125
Reland Native ios context menu ( #143002 ) ( #148238 ) ( #148265 )
...
Reverting https://github.com/flutter/flutter/pull/148238 which was relanded in https://github.com/flutter/flutter/pull/148237 which was originally from https://github.com/flutter/flutter/pull/143002 .
This time post-submit I saw a failure of a wasm version of a test added by this PR.
2024-05-15 18:37:05 +00:00
engine-flutter-autoroll
95f0c0d8f9
Roll Packages from fd714bd7d516 to 87a02e393be0 (8 revisions) ( #148419 )
...
fd714bd7d5...87a02e393bengine-flutter-autoroll@skia.org Roll Flutter from d2da1b280b51 to 39651e84ea12 (18 revisions) (flutter/packages#6738 )
2024-05-15 stuartmorgan@google.com Update the repo for the 3.22 stable release (flutter/packages#6730 )
2024-05-15 linxunfeng@yeah.net [webview_flutter_wkwebview] Fixes JSON.stringify() cannot serialize cyclic structures (flutter/packages#6274 )
2024-05-14 louisehsu@google.com [in_app_purchase_storekit] migrate main plugin class to swift in preperation to storekit 2 (flutter/packages#6561 )
2024-05-14 34871572+gmackall@users.noreply.github.com [image_picker_android] Refactor getting of paths from intent to single helper (flutter/packages#5009 )
2024-05-14 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 54e66469a933 to 5dcb86f68f23 (1402 revisions) (flutter/packages#6727 )
2024-05-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Skip `withWeakReferenceTo` integration test (flutter/packages#6731 )
2024-05-14 engine-flutter-autoroll@skia.org Roll Flutter from 125543505d26 to d2da1b280b51 (26 revisions) (flutter/packages#6729 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 18:34:48 +00:00
Jenn Magder
57890e5aa7
Stop running module_test_ios in devicelab and x64 Macs ( #148264 )
...
As of https://github.com/flutter/flutter/pull/147934 `module_test_ios` is passing on non-devicelab machines. Remove the devicelab build and mark the arm non-devicelab build as not flaky.
@vashworth's summary from https://github.com/flutter/flutter/issues/112033#issuecomment-2108671235 :
> So I believe [the idea](https://github.com/flutter/flutter/pull/141910 ) was to move `Mac_arm64_ios module_test_ios` to `Mac_arm64 module_test_ios` so it doesn't run on a devicelab bot.
>
> However, it fails when running on a chromium bot due to a `Trying to load an unsigned library` issue, even though it's using a simulator:
> https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_arm64%20module_test_ios
>
> It's unclear why, but it seemed that removing the [lines](https://github.com/flutter/flutter/issues/112033#issuecomment-1652268832 ) that force disabling of codesigning allowed it to run. [@godofredoc was going to do a follow up PR to fix it](https://github.com/flutter/flutter/pull/141910#discussion_r1462346593 ), but it was probably forgotten.
Also remove the x64 version of this test, since there's nothing arch-specific going on here and it happens to be flaky due to an infrastructure issues.
Fixes https://github.com/flutter/flutter/issues/112033
Fixes https://github.com/flutter/flutter/issues/144680
2024-05-15 18:33:03 +00:00
engine-flutter-autoroll
39651e84ea
Roll Flutter Engine from d35a1a603c80 to bf1c6da0dd31 (1 revision) ( #148369 )
...
d35a1a603c...bf1c6da0ddjonahwilliams@google.com [Impeller] make default glyph atlas size much bigger. (flutter/engine#52787 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 14:43:27 +00:00
engine-flutter-autoroll
ddd6c86950
Roll Flutter Engine from 55c62ff82c7e to d35a1a603c80 (4 revisions) ( #148367 )
...
55c62ff82c...d35a1a603cjason-simmons@users.noreply.github.com Roll FreeType from af4c2d86 to bfc3453f (flutter/engine#52829 )
2024-05-14 jonahwilliams@google.com [Impeller] immediately encode blit commands for Vulkan. (flutter/engine#52794 )
2024-05-14 34871572+gmackall@users.noreply.github.com Fix non-vd android platform view input event offsets (flutter/engine#52532 )
2024-05-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 0380354e2448 to 0b77fbab8cf5 (1 revision) (flutter/engine#52827 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 02:00:17 +00:00
engine-flutter-autoroll
dafce76ff8
Roll Flutter Engine from a1d930a3a84d to 55c62ff82c7e (3 revisions) ( #148365 )
...
a1d930a3a8...55c62ff82cjonahwilliams@google.com [Impeller] reland: directly encode blit commands for Metal. (flutter/engine#52819 )
2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from 81ba2eea7b42 to d0d87c26b489 (2 revisions) (flutter/engine#52825 )
2024-05-14 chris@bracken.jp [docs] Suggest using same Xcode version as bots (flutter/engine#52821 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 00:39:36 +00:00
engine-flutter-autoroll
ea85c561fe
Roll Flutter Engine from dfb5871260a6 to a1d930a3a84d (2 revisions) ( #148360 )
...
dfb5871260...a1d930a3a8zanderso@users.noreply.github.com [et] Print reproxy stats when RBE shuts down (flutter/engine#52818 )
2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from e26aee36345f to 81ba2eea7b42 (3 revisions) (flutter/engine#52820 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 23:58:25 +00:00
engine-flutter-autoroll
f9afa8f7fe
Roll Flutter Engine from 1b508a071c96 to dfb5871260a6 (1 revision) ( #148356 )
...
1b508a071c...dfb5871260jason-simmons@users.noreply.github.com Migrate third_party/gradle to flutter/third_party/gradle (flutter/engine#52814 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 22:40:21 +00:00
dependabot[bot]
cbc51f15eb
Bump codecov/codecov-action from 4.3.1 to 4.4.0 ( #148355 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.3.1 to 4.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v4.4.0</h2>
<h2>What's Changed</h2>
<ul>
<li>chore: Clarify isPullRequestFromFork by <a href="https://github.com/jsoref "><code>@âjsoref</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1411 ">codecov/codecov-action#1411</a></li>
<li>build(deps): bump actions/checkout from 4.1.4 to 4.1.5 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1423 ">codecov/codecov-action#1423</a></li>
<li>build(deps): bump github/codeql-action from 3.25.3 to 3.25.4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1421 ">codecov/codecov-action#1421</a></li>
<li>build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1420 ">codecov/codecov-action#1420</a></li>
<li>feat: remove GPG and run on spawn by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1426 ">codecov/codecov-action#1426</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 7.8.0 to 7.9.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1428 ">codecov/codecov-action#1428</a></li>
<li>chore(release): 4.4.0 by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1430 ">codecov/codecov-action#1430</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.3.1...v4.4.0 ">https://github.com/codecov/codecov-action/compare/v4.3.1...v4.4.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="6d798873dfhttps://redirect.github.com/codecov/codecov-action/issues/1430 ">#1430</a>)</li>
<li><a href="37364fa731https://redirect.github.com/codecov/codecov-action/issues/1428 ">#1428</a>)</li>
<li><a href="2791a5c4fehttps://redirect.github.com/codecov/codecov-action/issues/1426 ">#1426</a>)</li>
<li><a href="b71af43c1ehttps://redirect.github.com/codecov/codecov-action/issues/1420 ">#1420</a>)</li>
<li><a href="29f97fc54fhttps://redirect.github.com/codecov/codecov-action/issues/1421 ">#1421</a>)</li>
<li><a href="645d2a5926https://redirect.github.com/codecov/codecov-action/issues/1423 ">#1423</a>)</li>
<li><a href="f691d469fbhttps://redirect.github.com/codecov/codecov-action/issues/1411 ">#1411</a>)</li>
<li>See full diff in <a href="5ecb98a3c6...6d798873dfhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.3.1&new-version=4.4.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-05-14 22:35:49 +00:00
Valentin Vignal
f335145529
Fix memory leaks in SnackBar ( #147212 )
2024-05-14 15:26:10 -07:00
Valentin Vignal
b23f34657e
Fix memory leaks in open upwards page transition ( #148046 )
2024-05-14 15:25:58 -07:00
chunhtai
de9ca5c1c8
Fixes semantics ordering when there are multiple TextFields with pref… ( #148267 )
...
â¦ix and suffix
fixes https://github.com/flutter/flutter/issues/148248
2024-05-14 22:22:51 +00:00
engine-flutter-autoroll
2d3e55da28
Roll Flutter Engine from ae9ff69a0840 to 1b508a071c96 (2 revisions) ( #148351 )
...
ae9ff69a08...1b508a071c#52795 )" (flutter/engine#52816 )
2024-05-14 jonahwilliams@google.com [Impeller] immediately encode blit commands for Metal. (flutter/engine#52795 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 21:39:22 +00:00
Bruno Leroux
ced962d870
Add missing InputDecorator.hintText tests ( #148113 )
...
## Description
This PR reorganized some `InputDecorator.hintText` tests and add many of them (theses tests are organized similarly to the M3 spec, see https://m3.material.io/components/text-fields/specs ).
This is somewhat repetitive but it helped me to catch two hint styling issues (wrong colors and font), I added TODOs because I will file the fixes once this PR is merged (just in case the fixes break some Google tests). The test I added are from lines 2779 to 3952 (below it is existing tests that I moved).
## Related Issue
Part of https://github.com/flutter/flutter/issues/139076
2024-05-14 21:29:53 +00:00
Kate Lovett
4a1e3eaaa2
Fix abi key for local golden file testing ( #148072 )
...
Fixes https://github.com/flutter/flutter/issues/148022
2024-05-14 20:58:18 +00:00
yim
e2ef38d19f
Maintain the same layout constraints for item in the ReorderableList during dragging as before dragging. ( #147863 )
...
Fixes #147419
2024-05-14 20:52:59 +00:00
derdilla
4ecc1b092b
test material text field example ( #147864 )
...
Adds simple tests to the last two [TextField](https://api.flutter.dev/flutter/material/TextField-class.html ) examples as part of fixing #130459 .
2024-05-14 20:46:46 +00:00
Victor Sanni
7d92700042
Move toggleable to widget layer ( #148272 )
...
Currently, toggleable exists independently in the material and cupertino
libraries. Cupertino's toggleable is a minimal copy of material's, and
so it makes sense to have only one toggleable in the widgets layer.
This change makes it easier for cupertino's toggleables (switch, radio,
checkbox) to potentially have as many capabilities as material
toggleables (for example, resolving in different widget states), thus
increasing support for the cupertino library.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
---------
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
2024-05-14 13:46:35 -07:00
engine-flutter-autoroll
a24b764a11
Roll Flutter Engine from 08b44d906fab to ae9ff69a0840 (1 revision) ( #148341 )
...
08b44d906f...ae9ff69a08skia-flutter-autoroll@skia.org Roll Skia from 7dad6da92119 to e26aee36345f (1 revision) (flutter/engine#52810 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 19:35:59 +00:00
Andrew Kolos
c7574be4a3
add another print trace to runInView ( #148337 )
...
In service of https://github.com/flutter/flutter/issues/146879 . See https://github.com/flutter/flutter/issues/146879#issuecomment-2110781156 . I wonder if something is going wrong in the process of subscribing to the isolate event stream in the VM service. This adds a print trace to the `catch` clause of this subscription call.
2024-05-14 19:34:04 +00:00
engine-flutter-autoroll
034aa2f760
Roll Flutter Engine from 7bf865774d06 to 08b44d906fab (4 revisions) ( #148338 )
...
7bf865774d...08b44d906f30870216+gaaclarke@users.noreply.github.com [Impeller] migrated one test over from aiks to dl (flutter/engine#52786 )
2024-05-14 jason-simmons@users.noreply.github.com [Impeller] Create framebuffer blend vertices based on the snapshot's texture size instead of coverage (flutter/engine#52790 )
2024-05-14 magder@google.com Refactor Semantics in preparation for ARC migration (flutter/engine#52729 )
2024-05-14 zanderso@users.noreply.github.com Rolls in buildroot with stack protection flag (flutter/engine#52774 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 18:50:07 +00:00
engine-flutter-autoroll
d2da1b280b
Roll Flutter Engine from 491f460a25fb to 7bf865774d06 (1 revision) ( #148325 )
...
491f460a25...7bf865774dskia-flutter-autoroll@skia.org Roll Dart SDK from fe75fa5f7dc0 to 0380354e2448 (1 revision) (flutter/engine#52808 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 15:59:37 +00:00
engine-flutter-autoroll
2e11854da1
Roll Packages from 1412041fa3fe to fd714bd7d516 (1 revision) ( #148324 )
...
1412041fa3...fd714bd7d532538273+ValentinVignal@users.noreply.github.com [go_router] Use the correct configuration to build the state passed to the `onExit` (flutter/packages#6623 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 15:48:25 +00:00
engine-flutter-autoroll
a39555d4fe
Roll Flutter Engine from c381b852605f to 491f460a25fb (1 revision) ( #148319 )
...
c381b85260...491f460a25skia-flutter-autoroll@skia.org Roll Skia from 421d8d034e6e to 7dad6da92119 (1 revision) (flutter/engine#52806 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 15:12:10 +00:00
engine-flutter-autoroll
cb656c21f0
Roll Flutter Engine from b4b798d2e706 to c381b852605f (1 revision) ( #148303 )
...
b4b798d2e7...c381b85260skia-flutter-autoroll@skia.org Roll Skia from 7045b90f1ef8 to 421d8d034e6e (1 revision) (flutter/engine#52803 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 10:02:26 +00:00
engine-flutter-autoroll
e62b6ea39e
Roll Flutter Engine from 0de6701b537a to b4b798d2e706 (2 revisions) ( #148299 )
...
0de6701b53...b4b798d2e7skia-flutter-autoroll@skia.org Roll Skia from 19153175a79b to 7045b90f1ef8 (3 revisions) (flutter/engine#52801 )
2024-05-14 jonahwilliams@google.com [Impeller] use render pass to clear glyph atlas texture to transparent black. (flutter/engine#52791 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 08:59:26 +00:00
engine-flutter-autoroll
ff8e06dc7b
Roll Flutter Engine from 764c33c3c773 to 0de6701b537a (2 revisions) ( #148297 )
...
764c33c3c7...0de6701b53flutter/engine#52798 )
2024-05-14 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/engine#52799 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 08:13:02 +00:00
engine-flutter-autoroll
d1b8ae7827
Roll Flutter Engine from 797eab742925 to 764c33c3c773 (1 revision) ( #148290 )
...
797eab7429...764c33c3c7skia-flutter-autoroll@skia.org Roll Skia from 349fdd5f0b69 to 19153175a79b (1 revision) (flutter/engine#52797 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 07:26:25 +00:00
engine-flutter-autoroll
08adc90589
Roll Flutter Engine from 84687fe0f199 to 797eab742925 (1 revision) ( #148288 )
...
84687fe0f1...797eab7429skia-flutter-autoroll@skia.org Roll Skia from 93912d50850d to 349fdd5f0b69 (2 revisions) (flutter/engine#52796 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 06:23:10 +00:00
engine-flutter-autoroll
21177cced4
Roll Flutter Engine from bee398d95abe to 84687fe0f199 (3 revisions) ( #148282 )
...
bee398d95a...84687fe0f1matanlurey@users.noreply.github.com Replace `json_utils` with a modern `extension type`, add tests. (flutter/engine#52769 )
2024-05-14 jason-simmons@users.noreply.github.com Move libcxx to //flutter/third_party (flutter/engine#52773 )
2024-05-14 dustingreen@google.com [fuchsia][sysmem2] route fuchsia.sysmem2.Allocator (flutter/engine#52708 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 05:06:32 +00:00
engine-flutter-autoroll
c8b0c9acec
Roll Flutter Engine from a1cdcb6a6687 to bee398d95abe (2 revisions) ( #148280 )
...
a1cdcb6a66...bee398d95askia-flutter-autoroll@skia.org Roll Dart SDK from 7c7767ecc3d7 to fe75fa5f7dc0 (1 revision) (flutter/engine#52792 )
2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from 400c6fbeace8 to 93912d50850d (1 revision) (flutter/engine#52788 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 04:03:55 +00:00
engine-flutter-autoroll
1484d09103
Roll Flutter Engine from 13a561cb6d5a to a1cdcb6a6687 (1 revision) ( #148276 )
...
13a561cb6d...a1cdcb6a66chinmaygarde@google.com Delete Settings::msaa_samples. (flutter/engine#52780 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 01:58:26 +00:00
engine-flutter-autoroll
2e23114d1a
Roll Flutter Engine from 7dcbd93e5c1a to 13a561cb6d5a (6 revisions) ( #148274 )
...
7dcbd93e5c...13a561cb6djonahwilliams@google.com [Impeller] rectangle packer actually packs. (flutter/engine#52781 )
2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from 75b3286ecaac to 400c6fbeace8 (6 revisions) (flutter/engine#52783 )
2024-05-13 magder@google.com ios_external_view_embedder to ARC (flutter/engine#52782 )
2024-05-13 skia-flutter-autoroll@skia.org Roll Dart SDK from a0a940f07d56 to 7c7767ecc3d7 (2 revisions) (flutter/engine#52777 )
2024-05-13 chinmaygarde@google.com Remove outdated comment. (flutter/engine#52778 )
2024-05-13 chinmaygarde@google.com [Impeller] Prepare a SkiaGPU-less iOS build. (flutter/engine#52748 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 01:16:25 +00:00
engine-flutter-autoroll
13cd57a7ee
Roll Flutter Engine from aeff9b174c84 to 7dcbd93e5c1a (1 revision) ( #148266 )
...
aeff9b174c...7dcbd93e5cmagder@google.com Remove -[NSNotificationCenter removeObserver:] in deallocs (flutter/engine#52772 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 23:55:05 +00:00
Jenn Magder
51d99e79d0
Mark platform_views_scroll_perf_ad_banners__timeline_summary not flaky ( #148263 )
...
New build been consistently passing
https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_ios%20platform_views_scroll_perf_ad_banners__timeline_summary/960
2024-05-13 23:07:05 +00:00
Andrew Kolos
7d263507fb
add more print traces in hot runner workflow ( #148258 )
...
In service of https://github.com/flutter/flutter/issues/146879 . See https://github.com/flutter/flutter/issues/146879#issuecomment-2108784673 in particular for the purpose of this PR. This adds a few more `printTrace` calls to try to see where we are getting stuck.
2024-05-13 22:51:48 +00:00
chunhtai
a36ff80cf6
Refactors page API ( #137792 )
...
fixes https://github.com/flutter/flutter/issues/137458
Chagnes:
1. Navigator.pop will always pop page based route
2. add a onDidRemovePage callback to replace onPopPage
3. Page.canPop and Page.onPopInvoked mirrors the PopScope, but in Page class.
migration guide https://github.com/flutter/website/pull/10523
2024-05-13 22:45:51 +00:00
dependabot[bot]
27f683d6c3
Bump github/codeql-action from 3.25.3 to 3.25.5 ( #148262 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.3 to 3.25.5.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md ">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases ">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.25.5 - 13 May 2024</h2>
<ul>
<li>Add a compatibility matrix of supported CodeQL Action, CodeQL CLI, and GitHub Enterprise Server versions to the <a href="https://github.com/github/codeql-action/blob/main/README.md ">https://github.com/github/codeql-action/blob/main/README.md </a>. <a href="https://redirect.github.com/github/codeql-action/pull/2273 ">#2273</a></li>
<li>Avoid printing out a warning for a missing <code>on.push</code> trigger when the CodeQL Action is triggered via a <code>workflow_call</code> event. <a href="https://redirect.github.com/github/codeql-action/pull/2274 ">#2274</a></li>
<li>The <code>tools: latest</code> input to the <code>init</code> Action has been renamed to <code>tools: linked</code>. This option specifies that the Action should use the tools shipped at the same time as the Action. The old name will continue to work for backwards compatibility, but we recommend that new workflows use the new name. <a href="https://redirect.github.com/github/codeql-action/pull/2281 ">#2281</a></li>
</ul>
<h2>3.25.4 - 08 May 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.2. <a href="https://redirect.github.com/github/codeql-action/pull/2270 ">#2270</a></li>
</ul>
<h2>3.25.3 - 25 Apr 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.1. <a href="https://redirect.github.com/github/codeql-action/pull/2247 ">#2247</a></li>
<li>Workflows running on <code>macos-latest</code> using CodeQL CLI versions before v2.15.1 will need to either upgrade their CLI version to v2.15.1 or newer, or change the platform to an Intel MacOS runner, such as <code>macos-12</code>. ARM machines with SIP disabled, including the newest <code>macos-latest</code> image, are unsupported for CLI versions before 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/2261 ">#2261</a></li>
</ul>
<h2>3.25.2 - 22 Apr 2024</h2>
<p>No user facing changes.</p>
<h2>3.25.1 - 17 Apr 2024</h2>
<ul>
<li>We are rolling out a feature in April/May 2024 that improves the reliability and performance of analyzing code when analyzing a compiled language with the <code>autobuild</code> <a href="https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages#codeql-build-modes ">build mode</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2235 ">#2235</a></li>
<li>Fix a bug where the <code>init</code> Action would fail if <code>--overwrite</code> was specified in <code>CODEQL_ACTION_EXTRA_OPTIONS</code>. <a href="https://redirect.github.com/github/codeql-action/pull/2245 ">#2245</a></li>
</ul>
<h2>3.25.0 - 15 Apr 2024</h2>
<ul>
<li>
<p>The deprecated feature for extracting dependencies for a Python analysis has been removed. <a href="https://redirect.github.com/github/codeql-action/pull/2224 ">#2224</a></p>
<p>As a result, the following inputs and environment variables are now ignored:</p>
<ul>
<li>The <code>setup-python-dependencies</code> input to the <code>init</code> Action</li>
<li>The <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION</code> environment variable</li>
</ul>
<p>We recommend removing any references to these from your workflows. For more information, see the release notes for CodeQL Action v3.23.0 and v2.23.0.</p>
</li>
<li>
<p>Automatically overwrite an existing database if found on the filesystem. <a href="https://redirect.github.com/github/codeql-action/pull/2229 ">#2229</a></p>
</li>
<li>
<p>Bump the minimum CodeQL bundle version to 2.12.6. <a href="https://redirect.github.com/github/codeql-action/pull/2232 ">#2232</a></p>
</li>
<li>
<p>A more relevant log message and a diagnostic are now emitted when the <code>file</code> program is not installed on a Linux runner, but is required for Go tracing to succeed. <a href="https://redirect.github.com/github/codeql-action/pull/2234 ">#2234</a></p>
</li>
</ul>
<h2>3.24.10 - 05 Apr 2024</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b7cec75265https://redirect.github.com/github/codeql-action/issues/2287 ">#2287</a> from github/update-v3.25.5-4a5197247</li>
<li><a href="6778fe45534a51972477https://redirect.github.com/github/codeql-action/issues/2280 ">#2280</a> from github/henrymercer/on-demand-ffs</li>
<li><a href="a8c32fd278https://redirect.github.com/github/codeql-action/issues/2283 ">#2283</a> from github/henrymercer/disable-fail-fast</li>
<li><a href="f73b0b70ebc59e05245f33e416c05667f8a36bdb4995c49010https://redirect.github.com/github/codeql-action/issues/2282 ">#2282</a> from github/henrymercer/no-build-mode-tracing-improv...</li>
<li><a href="def4d2cd4ehttps://redirect.github.com/github/codeql-action/issues/2273 ">#2273</a> from github/aeisenberg/specify-versions</li>
<li>Additional commits viewable in <a href="d39d31e687...b7cec75265https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.25.3&new-version=3.25.5 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-05-13 22:26:41 +00:00
engine-flutter-autoroll
f76cb2204b
Roll Flutter Engine from 11502404a52a to aeff9b174c84 (2 revisions) ( #148260 )
...
11502404a5...aeff9b174cmagder@google.com Migrate FlutterDartProject and FlutterPluginAppLifeCycleDelegate to ARC (flutter/engine#52719 )
2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from dde1f5dba183 to 75b3286ecaac (1 revision) (flutter/engine#52763 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 22:22:06 +00:00
Ellet
876aa48ea5
Use super.key instead of manually passing the Key parameter to the parent class ( #147621 )
...
*Use `super.key` instead of manually passing the `Key` parameter using super(key: key) in the constructors.*
Since if you create a widget the new default will use `super.key` instead of `Key? key : super(key: key)` this small change is to maintain the consistency, it has no semantic change
also there are some other places that might need to be updated:
this file for example generate l10n project and it has all the dart code as String, it might have tests that validate the output somewhere that I might miss, also there are some other places like the `_Segment` class where it require `ValueKey` instead if `Key` so I didn't update them (even though it's possible)
2024-05-13 22:12:49 +00:00
Daco Harkes
3391ddf55d
Try fix module test ( #147934 )
...
Issue
* https://github.com/flutter/flutter/issues/112033
Suggested in https://github.com/flutter/flutter/issues/112033#issuecomment-1652268832 , and makes the test pass for me locally on the M1 Macbook.
2024-05-13 21:30:01 +00:00
auto-submit[bot]
45e80fd63b
Reverts "Reland Native ios context menu ( #143002 ) ( #148238 )" ( #148254 )
...
Reverts: flutter/flutter#148238
Initiated by: zanderso
Reason for reverting: Failures in post submit https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8748025189669617649/+/u/run_test.dart_for_web_canvaskit_tests_shard_and_subshard_3/stdout
Original PR Author: justinmc
Reviewed By: {hellohuanlin}
This change reverts the following previous change:
Reland of https://github.com/flutter/flutter/pull/143002 , which was reverted in https://github.com/flutter/flutter/pull/148237 due to unresolved docs references. Not sure why those weren't caught in presubmit.
```
dartdoc:stdout: Generating docs for package flutter...
dartdoc:stderr: error: unresolved doc reference [TextInput.showSystemContextMenu]
dartdoc:stderr: from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/widgets/media_query.dart:579:14)
dartdoc:stderr: in documentation inherited from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/widgets/media_query.dart:579:14)
dartdoc:stderr: error: unresolved doc reference [showSystemContextMenu]
dartdoc:stderr: from services.SystemContextMenuController.hide: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/services/text_input.dart:2554:16)
dartdoc:stderr: error: unresolved doc reference [hideSystemContextMenu]
dartdoc:stderr: from services.SystemContextMenuController.show: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/services/text_input.dart:2509:16)
```
2024-05-13 20:50:26 +00:00
Justin McCandless
42b3d9eb7f
Reland Native ios context menu ( #143002 ) ( #148238 )
...
It's now possible to use the native-rendered text selection context menu on iOS. This sacrifices customizability in exchange for avoiding showing a notification when the user presses "Paste". It's off by default, but to enable, see the example system_context_menu.0.dart.
2024-05-13 12:53:36 -07:00
