41126 Commits

Author SHA1 Message Date
engine-flutter-autoroll
4c567a98b8
Roll Flutter Engine from 636374fd00ee to 11502404a52a (1 revision) (#148242)
636374fd00...11502404a5

2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from 2a7830d74a8b to dde1f5dba183 (1 revision) (flutter/engine#52762)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 18:50:08 +00:00
engine-flutter-autoroll
f3949685e0
Roll Packages from 6c4482a64492 to 1412041fa3fe (16 revisions) (#148239)
6c4482a644...1412041fa3

2024-05-13 stuartmorgan@google.com [in_app_purchase] Update country code Android example (flutter/packages#6722)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter from 1dfb46e9c087 to 125543505d26 (6 revisions) (flutter/packages#6723)
2024-05-13 43054281+camsim99@users.noreply.github.com [camera] Change default Android implementation from `camera_android` to `camera_android_camerax` (flutter/packages#6629)
2024-05-13 15619084+vashworth@users.noreply.github.com [image_picker_ios] Make all headers public for SwiftPM to keep inline with CocoaPods (flutter/packages#6707)
2024-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 2aa05c16509b to 1dfb46e9c087 (3 revisions) (flutter/packages#6715)
2024-05-11 engine-flutter-autoroll@skia.org Roll Flutter from 2bfb1b0e2f61 to 2aa05c16509b (26 revisions) (flutter/packages#6713)
2024-05-10 stuartmorgan@google.com [quick_actions] Add Swift Package Manager support (flutter/packages#6682)
2024-05-10 stuartmorgan@google.com [url_launcher] Add Swift Package Manager support (flutter/packages#6677)
2024-05-10 43054281+camsim99@users.noreply.github.com [Android][webview_flutter] Run integration tests on emulators running Android 34 (flutter/packages#6499)
2024-05-10 50643541+Mairramer@users.noreply.github.com [image_picker_android] - will fix crash on Android 12+ devices (flutter/packages#6691)
2024-05-10 43054281+camsim99@users.noreply.github.com [camerax] Make fixes required to swap camera_android_camerax for camera_android (flutter/packages#6697)
2024-05-10 737941+loic-sharma@users.noreply.github.com Update .gitignore for Swift Package Manager (flutter/packages#6705)
2024-05-10 34871572+gmackall@users.noreply.github.com [quick_actions_android] Switch to `Compat` version of `ShortcutManager` to support Google surfaces (flutter/packages#6638)
2024-05-10 737941+loic-sharma@users.noreply.github.com [local_auth_darwin] Adds Swift Package Manager compatibility (flutter/packages#6708)
2024-05-10 engine-flutter-autoroll@skia.org Roll Flutter from 00f40667c16a to 2bfb1b0e2f61 (9 revisions) (flutter/packages#6706)
2024-05-09 38299943+VictorOhashi@users.noreply.github.com [go_router] Feat add route redirect shellroutes (#114559) (flutter/packages#6432)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 18:36:12 +00:00
engine-flutter-autoroll
f77d6463a2
Roll Flutter Engine from 0050bf9a8094 to 636374fd00ee (1 revision) (#148216)
0050bf9a80...636374fd00

2024-05-13 skia-flutter-autoroll@skia.org Roll Dart SDK from f1a6336d2147 to a0a940f07d56 (1 revision) (flutter/engine#52761)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 18:11:08 +00:00
auto-submit[bot]
14d88ee0c8
Reverts "Native ios context menu (#143002)" (#148237)
Reverts: flutter/flutter#143002
Initiated by: cbracken
Reason for reverting: unresolved docs links. See failure here: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20docs_test/16540/overview

```
dartdoc:stdout: Generating docs for package flutter...
dartdoc:stderr:   error: unresolved doc reference [TextInput.showSystemContextMenu]
dartdoc:stderr:     from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutt
Original PR Author: justinmc

Reviewed By: {Renzo-Olivares, hellohuanlin}

This change reverts the following previous change:
In order to work around the fact that iOS 15 shows a notification on pressing Flutter's paste button (https://github.com/flutter/flutter/issues/103163), this PR allows showing the iOS system context menu in text fields.

<img width="385" alt="Screenshot 2024-02-06 at 11 52 25 AM" src="https://github.com/flutter/flutter/assets/389558/d82e18ee-b8a3-4082-9225-cf47fa7f3674">

It is currently opt-in, which a user would typically do like this (also in example system_context_menu.0.dart):

```dart
      contextMenuBuilder: (BuildContext context, EditableTextState editableTextState) {
        // If supported, show the system context menu.
        if (SystemContextMenu.isSupported(context)) {
          return SystemContextMenu.editableText(
            editableTextState: editableTextState,
          );
        }
        // Otherwise, show the flutter-rendered context menu for the current
        // platform.
        return AdaptiveTextSelectionToolbar.editableText(
          editableTextState: editableTextState,
        );
      },
```

Requires engine PR https://github.com/flutter/engine/pull/50095.

## API changes

### SystemContextMenu
A widget that shows the system context menu when built, and removes it when disposed. The main high-level way that most users would use this PR. Only works on later versions of iOS.

### SystemContextMenuController
Used under the hood to hide and show a system context menu. There can only be one visible at a time.

### MediaQuery.supportsShowingSystemContextMenu
Sent by the iOS embedder to tell the framework whether or not the platform supports showing the system context menu. That way the framework, or Flutter developers, can decide to show a different menu.

### `flutter/platform ContextMenu.showSystemContextMenu`
Sent by the framework to show the menu at a given `targetRect`, which is the current selection rect.

### `flutter/platform ContextMenu.hideSystemContextMenu`
Sent by the framework to hide the menu. Typically not needed, because the platform will hide the menu when the user taps outside of it and after the user presses a button, but it handles edge cases where the user programmatically rebuilds the context menu, for example.

### `flutter/platform System.onDismissSystemContextMenu`
Sent by the iOS embedder to indicate that the system context menu has been hidden by the system, such as when the user taps outside of the menu.  This is useful when there are multiple instances of SystemContextMenu, such as with multiple text fields.
2024-05-13 17:43:36 +00:00
Justin McCandless
125543505d
Native ios context menu (#143002)
It's now possible to use the native-rendered text selection context menu on iOS. This sacrifices customizability in exchange for avoiding showing a notification when the user presses "Paste". It's off by default, but to enable, see the example system_context_menu.0.dart.
2024-05-13 08:48:56 -07:00
derdilla
708fe97f9e
test sliver fill remaining examples (#148041)
Par of #130459. Adds tests all `SliverFillRemaining` examples.
2024-05-13 15:30:49 +00:00
engine-flutter-autoroll
e5f7800171
Roll Flutter Engine from fab7a7417888 to 0050bf9a8094 (1 revision) (#148211)
fab7a74178...0050bf9a80

2024-05-13 skia-flutter-autoroll@skia.org Roll Dart SDK from ff786d99b517 to f1a6336d2147 (1 revision) (flutter/engine#52758)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 11:37:27 +00:00
engine-flutter-autoroll
9abde3e615
Roll Flutter Engine from e568e5db9391 to fab7a7417888 (1 revision) (#148207)
e568e5db93...fab7a74178

2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from 4bc37d0feedb to 2a7830d74a8b (1 revision) (flutter/engine#52756)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 08:47:24 +00:00
engine-flutter-autoroll
d09e37afed
Roll Flutter Engine from 57e74a1b3860 to e568e5db9391 (2 revisions) (#148204)
57e74a1b38...e568e5db93

2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from cbe627d5ba15 to 4bc37d0feedb (1 revision) (flutter/engine#52754)
2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from 4e9362762a0f to cbe627d5ba15 (1 revision) (flutter/engine#52752)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 08:02:46 +00:00
engine-flutter-autoroll
c336c2a44e
Roll Flutter Engine from 34fd28e8c7bd to 57e74a1b3860 (1 revision) (#148196)
34fd28e8c7...57e74a1b38

2024-05-12 chinmaygarde@google.com Detail a gotcha about reproxystatus (flutter/engine#52714)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 05:47:29 +00:00
engine-flutter-autoroll
1dfb46e9c0
Roll Flutter Engine from a9e1a2c478d3 to 34fd28e8c7bd (1 revision) (#148183)
a9e1a2c478...34fd28e8c7

2024-05-12 skia-flutter-autoroll@skia.org Roll Skia from d78564aad21d to 4e9362762a0f (1 revision) (flutter/engine#52739)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-12 09:09:26 +00:00
engine-flutter-autoroll
aef390a054
Roll Flutter Engine from 38a6ef7548f5 to a9e1a2c478d3 (2 revisions) (#148176)
38a6ef7548...a9e1a2c478

2024-05-11 skia-flutter-autoroll@skia.org Roll Skia from 709deddd904f to d78564aad21d (2 revisions) (flutter/engine#52732)
2024-05-11 skia-flutter-autoroll@skia.org Roll Skia from b6186e1b3995 to 709deddd904f (1 revision) (flutter/engine#52727)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-11 20:08:40 +00:00
engine-flutter-autoroll
630519f1b7
Roll Flutter Engine from 558a81dd8b08 to 38a6ef7548f5 (1 revision) (#148172)
558a81dd8b...38a6ef7548

2024-05-11 skia-flutter-autoroll@skia.org Roll Dart SDK from cbfaae24852c to ff786d99b517 (1 revision) (flutter/engine#52731)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-11 17:54:00 +00:00
engine-flutter-autoroll
2aa05c1650
Roll Flutter Engine from fad88cb16d03 to 558a81dd8b08 (3 revisions) (#148163)
fad88cb16d...558a81dd8b

2024-05-11 skia-flutter-autoroll@skia.org Roll Dart SDK from de30a5dbf169 to cbfaae24852c (2 revisions) (flutter/engine#52730)
2024-05-11 chinmaygarde@google.com [Impeller] Followup feedback on "Baby's First Triangle". (flutter/engine#52718)
2024-05-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 13fc7db956c7 to de30a5dbf169 (1 revision) (flutter/engine#52728)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-11 16:17:12 +00:00
engine-flutter-autoroll
839ba6b3e3
Roll Flutter Engine from ba8e0d3e2f23 to fad88cb16d03 (9 revisions) (#148156)
ba8e0d3e2f...fad88cb16d

2024-05-10 skia-flutter-autoroll@skia.org Roll Skia from f69e8967610e to b6186e1b3995 (2 revisions) (flutter/engine#52726)
2024-05-10 zanderso@users.noreply.github.com Simplify GN pools, use in more places (flutter/engine#52721)
2024-05-10 matanlurey@users.noreply.github.com Write `dart:ui` golden-file tests testing `FilterQuality.*` (flutter/engine#52687)
2024-05-10 flar@google.com Revert "DisplayListBuilder internal reorganization with better rendering op overlap detection" (flutter/engine#52725)
2024-05-10 30870216+gaaclarke@users.noreply.github.com deletes canvas recorder (flutter/engine#52722)
2024-05-10 skia-flutter-autoroll@skia.org Roll Skia from d1118d56853c to f69e8967610e (1 revision) (flutter/engine#52723)
2024-05-10 jonahwilliams@google.com [Impeller] treat glyph atlas texture as source of truth, remove copy of SkBitmap. (flutter/engine#52567)
2024-05-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 01121c008f4d to 13fc7db956c7 (2 revisions) (flutter/engine#52716)
2024-05-10 skia-flutter-autoroll@skia.org Roll Skia from 11d892ce49b6 to d1118d56853c (1 revision) (flutter/engine#52717)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-11 03:01:23 +00:00
Valentin Vignal
4af4cb89d5
Add test for scaffold.1.dart (#147966)
Contributes to https://github.com/flutter/flutter/issues/130459

It adds test for `examples/api/lib/material/scaffold/scaffold.1.dart`
2024-05-11 00:37:04 +00:00
Taha Tesser
c386acca54
Fix MaterialStateBorderSide lerp in the Checkbox and chips (#148124)
fixes [`Checkbox` and Chips side with `MaterialStateBorderSide` doesn't lerp in their theme](https://github.com/flutter/flutter/issues/135136)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  testWidgets('test', (WidgetTester tester) async {
    late ColorScheme colorScheme;

    Widget buildCheckbox({required Color seedColor}) {
      colorScheme = ColorScheme.fromSeed(seedColor: seedColor);
      return MaterialApp(
        theme: ThemeData(
          colorScheme: colorScheme,
          checkboxTheme: CheckboxThemeData(
            side: MaterialStateBorderSide.resolveWith(
                (Set<MaterialState> states) {
              return BorderSide(
                color: colorScheme.primary,
                width: 4.0,
              );
            }),
          ),
        ),
        home: Scaffold(
          body: Center(
            child: Checkbox(
              value: false,
              onChanged: (_) {},
            ),
          ),
        ),
      );
    }

    await tester.pumpWidget(buildCheckbox(seedColor: Colors.red));
    await tester.pumpAndSettle();

    RenderBox getCheckboxRenderer() {
      return tester.renderObject<RenderBox>(find.byType(Checkbox));
    }

    expect(getCheckboxRenderer(), paints..drrect(color: colorScheme.primary));

    await Future<void>.delayed(const Duration(seconds: 3));

    await tester.pumpWidget(buildCheckbox(seedColor: Colors.blue));
    await tester.pump();

    await Future<void>.delayed(const Duration(seconds: 3));

    expect(getCheckboxRenderer(), paints..drrect(color: colorScheme.primary));
  });
}
```

</details>

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/6df34104-37ba-4a82-b5cb-7ed4f887992a" /> | <img src="https://github.com/flutter/flutter/assets/48603081/44359248-a101-46eb-a85a-77f976da5f0f"  /> |
2024-05-10 23:37:05 +00:00
Justin McCandless
3e14f18178
Docs on TextField disposed by a scrollable (#148149)
Includes docs about the need to manually maintain a TextEditingController when using TextField in a ListView.builder (which was already documented on TextFormField).
2024-05-10 16:08:13 -07:00
engine-flutter-autoroll
1d6ab6f7a2
Roll Flutter Engine from d4f705ccb695 to ba8e0d3e2f23 (8 revisions) (#148147)
d4f705ccb6...ba8e0d3e2f

2024-05-10 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Clip before applying ColorFilter so it doesn't filter beyond child bounds (flutter/engine#52704)
2024-05-10 magder@google.com Migrate FlutterView, FlutterPlatformViews, FlutterOverlayView to ARC (flutter/engine#52535)
2024-05-10 matanlurey@users.noreply.github.com Infer `--rbe` based on the existence of `//flutter/build/rbe` (flutter/engine#52700)
2024-05-10 jonahwilliams@google.com [Impeller] Disable AHB swapchain. (flutter/engine#52713)
2024-05-10 skia-flutter-autoroll@skia.org Roll Skia from c7cd1e9690d1 to 11d892ce49b6 (25 revisions) (flutter/engine#52712)
2024-05-10 chinmaygarde@google.com [Impeller] Document how to do basic rendering in Impeller. (flutter/engine#52703)
2024-05-10 30870216+gaaclarke@users.noreply.github.com [impeller] adds experimental canvas docstring (flutter/engine#52710)
2024-05-10 daniel.l@hpcnt.com Roll third_party/freetype2 from 3bea27612 to af4c2d86d (2 revisions) (flutter/engine#52689)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 22:26:20 +00:00
flutter-pub-roller-bot
3c26c56ffa
Roll pub packages (#148148)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-05-10 22:24:27 +00:00
Valentin Vignal
8e53ad917c
Add clipBehavior to DialogTheme (#147635)
Fixes https://github.com/flutter/flutter/issues/147634
2024-05-10 22:08:59 +00:00
LongCatIsLooong
a8a9b9bea3
bump cupertino_icons to 1.08 (#146806)
And fix the incorrect codepoint for `square_pencil_fill`
2024-05-10 21:55:52 +00:00
Kostia Sokolovskyi
65e8c615b4
Add test for animated_size.0.dart API example. (#147828)
This PR contributes to https://github.com/flutter/flutter/issues/130459

### Description
- Updates `examples/api/lib/widgets/animated_size/animated_size.0.dart` API example by using `SizedBox` to size the surrounding of the `FlutterLogo` while setting the constant `FlutterLogo` size. This was done because `FlutterLogo` already has size animation under the hood, and the main goal of this example is to show `AnimatedSize` usage
- Adds test for `examples/api/lib/widgets/animated_size/animated_size.0.dart`
2024-05-10 21:55:51 +00:00
PurplePolyhedron
fdfc408fd7
Fix DropdownMenu keyboard navigation (#147294)
Fix https://github.com/flutter/flutter/issues/147253
Fix https://github.com/flutter/flutter/issues/147516

Resubmitted https://github.com/flutter/flutter/pull/147285 because I accidentally added reviewer as contributor in a commit by using Github "add suggestion to batch". Which causing CLA check to fail and I cannot revert it.

I use exact match of label instead of contains to minimise possible change in actual user search.
I added the new test after the original keyboard navigation test to avoid merge conflict with another incoming PR.
Let me know if I need to make any changes.

Sorry for the inconvenience, I am new to the process.
2024-05-10 21:55:49 +00:00
Kostia Sokolovskyi
da9712f76f
Add test for draggable.0.dart API example. (#147941)
This PR contributes to https://github.com/flutter/flutter/issues/130459

### Description
- Adds test for `examples/api/lib/widgets/drag_target/draggable.0.dart`
2024-05-10 21:54:16 +00:00
Jenn Magder
3223f1c11d
Update TESTOWNERS (#148108)
Update TESTOWNERS
2024-05-10 21:54:14 +00:00
Kostia Sokolovskyi
456d176a70
Add tests for stream_builder.0.dart API example. (#147832)
This PR contributes to https://github.com/flutter/flutter/issues/130459

### Description
- Updates `examples/api/lib/widgets/async/stream_builder.0.dart`
- Adds test for `examples/api/lib/widgets/async/stream_builder.0.dart`
2024-05-10 21:48:35 +00:00
engine-flutter-autoroll
1128eabec6
Roll Flutter Engine from 1ccd0c308b3a to d4f705ccb695 (2 revisions) (#148142)
1ccd0c308b...d4f705ccb6

2024-05-10 skia-flutter-autoroll@skia.org Roll Skia from 2813bc21202e to
c7cd1e9690d1 (6 revisions) (flutter/engine#52701)
2024-05-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
RDVdjRvCxkJh2NLxS... to NbCi2ETfLHPLLB-JV... (flutter/engine#52702)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from RDVdjRvCxkJh to NbCi2ETfLHPL

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 13:25:56 -07:00
engine-flutter-autoroll
2832ab6f4a
Roll Packages from 8de142d33b88 to 6c4482a64492 (8 revisions) (#148079)
8de142d33b...6c4482a644

2024-05-09 15619084+vashworth@users.noreply.github.com [image_picker_ios] Adds Swift Package Manager compatibility  (flutter/packages#6696)
2024-05-09 goderbauer@google.com [flutter_lints] Rev to 4.0.0; prepare for publishing (flutter/packages#6695)
2024-05-09 10687576+bparrishMines@users.noreply.github.com [pointer_interceptor] Remove `implements` from app-facing package (flutter/packages#6699)
2024-05-08 15619084+vashworth@users.noreply.github.com Temporarily add empty header files to video_player_avfoundation so include directory is downloaded (flutter/packages#6694)
2024-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[image_picker_ios] Adds Swift Package Manager compatibility to image_picker_ios (#6617)" (flutter/packages#6693)
2024-05-08 15619084+vashworth@users.noreply.github.com [image_picker_ios] Adds Swift Package Manager compatibility to image_picker_ios (flutter/packages#6617)
2024-05-08 15619084+vashworth@users.noreply.github.com [video_player_avfoundation] Adds Swift Package Manager compatibility (flutter/packages#6675)
2024-05-08 737941+loic-sharma@users.noreply.github.com [ios_platform_images] Add Swift Package Manager support (flutter/packages#6684)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 20:21:18 +00:00
engine-flutter-autoroll
9c881ce4c5
Roll Flutter Engine from c0917b14fc36 to 1ccd0c308b3a (10 revisions) (#148137)
c0917b14fc...1ccd0c308b

2024-05-10 30870216+gaaclarke@users.noreply.github.com Fixed constness
of display list storage. (flutter/engine#52705)
2024-05-10 zanderso@users.noreply.github.com Revert "Various
documentation improvements (#52600)" (flutter/engine#52709)
2024-05-10 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
b7cad2edae4b to 01121c008f4d (3 revisions) (flutter/engine#52706)
2024-05-10 gray@tacck.net [iOS] Fix App crash when use WebView with iOS
VoiceOver (flutter/engine#52484)
2024-05-09 ian@hixie.ch Various documentation improvements (#52600)
(flutter/engine#52623)
2024-05-09 yjbanov@google.com [web] scale semantic text elements to
match the desired focus ring size (flutter/engine#52586)
2024-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Adds
impeller display list golden tests (flutter/engine#52690)
2024-05-09 zanderso@users.noreply.github.com Roll buildroot to
70a42312a688 (flutter/engine#52675)
2024-05-09 matanlurey@users.noreply.github.com When `et` is not attached
to a terminal, still split lines for status updates.
(flutter/engine#52681)
2024-05-09 30870216+gaaclarke@users.noreply.github.com updated analysis
exclusion (flutter/engine#52699)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-10 11:36:36 -07:00
Nate
4734d80f22
if chains → switch expressions (#147793)
Previous "if-chains" pull requests:
- https://github.com/flutter/flutter/pull/144905
- https://github.com/flutter/flutter/pull/144977
- https://github.com/flutter/flutter/pull/145194
- https://github.com/flutter/flutter/pull/146293
- https://github.com/flutter/flutter/pull/147472

<br>

I think this one should be enough to wrap things up!

fixes https://github.com/flutter/flutter/issues/144903

---------

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2024-05-10 00:55:48 -06:00
dependabot[bot]
c90e18c6f5
Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (#148091)
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action)
from 2.3.1 to 2.3.3.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="dc50aa9510"><code>dc50aa9</code></a>
🌱 Bump docker tag for v2.3.3 release (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1368">#1368</a>)</li>
<li><a
href="8ff5700173"><code>8ff5700</code></a>
🌱 Bump github.com/ossf/scorecard/v5 from v5.0.0-rc2 to
v5.0.0-rc2.0....</li>
<li><a
href="8ba5e73d11"><code>8ba5e73</code></a>
update api links to new scorecard.dev site (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1376">#1376</a>)</li>
<li><a
href="92ddde3eaf"><code>92ddde3</code></a>
Bump github.com/ossf/scorecard/v5 from v5.0.0-rc1 to v5.0.0-rc2 (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1374">#1374</a>)</li>
<li><a
href="6c55905542"><code>6c55905</code></a>
🌱 Bump golang.org/x/net from 0.24.0 to 0.25.0 (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1373">#1373</a>)</li>
<li><a
href="09bb953b6a"><code>09bb953</code></a>
🌱 Bump distroless/base in the docker-images group (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1372">#1372</a>)</li>
<li><a
href="1511e1305b"><code>1511e13</code></a>
🌱 Bump the github-actions group across 1 directory with 6
updates (#...</li>
<li><a
href="df66cd8fd8"><code>df66cd8</code></a>
🌱 Bump the docker-images group with 2 updates (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1370">#1370</a>)</li>
<li><a
href="fad9a3cc53"><code>fad9a3c</code></a>
🌱 Bump distroless/base in the docker-images group (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1364">#1364</a>)</li>
<li><a
href="1e01a309c1"><code>1e01a30</code></a>
🌱 Bump the github-actions group with 3 updates (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1365">#1365</a>)</li>
<li>Additional commits viewable in <a
href="0864cf1902...dc50aa9510">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.3.1&new-version=2.3.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-09 20:32:11 -07:00
LongCatIsLooong
1b0e86cf02
Reland "Implement computeDryBaseline for RenderWrap (#146260)" (#148086)
This reverts commit 706f39b0a0090738cc5bb25bdb8f49db10a2304a.

Relanding the original PR with no code changes. Running partial TGP now
(couldn't run full TGP because of throttling).
Fixes https://github.com/flutter/flutter/issues/71687

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-05-09 20:20:48 -07:00
Jenn Magder
5a663e6ef8
Update dependabot reviewers (#148101)
Update dependabot reviewers.
2024-05-09 19:59:27 -07:00
engine-flutter-autoroll
ac317a45a6
Roll Flutter Engine from 6e722ae213bd to c0917b14fc36 (1 revision) (#148084)
6e722ae213...c0917b14fc

2024-05-09 jonahwilliams@google.com [Impeller] Size AHB swapchain based
on vk surface properties. (flutter/engine#52692)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-09 17:29:57 -07:00
Christopher Fujino
730d6d44b7
Don't pin package:macros (#148087)
Full context https://github.com/flutter/flutter/issues/148004

TL;DR

1. Because `package:macros` depends on `package:_macros` via [a Dart SDK
dependency](https://github.com/dart-lang/sdk/blob/main/pkg/macros/pubspec.yaml#L13);
and
2. `package:macros` exactly pins `package:_macros`; and
3. Each new version of `package:macros` will increment its exact pin of
`package:_macros`
([comment](https://github.com/flutter/flutter/issues/148004#issuecomment-2103099893));
and
4. The [flutter/flutter](https://github.com/flutter/flutter) repository
exactly pins the Dart SDK (via its exact pin on the
[flutter/engine](https://github.com/flutter/engine) repository

Therefore, the [flutter/flutter](https://github.com/flutter/flutter)
repository effectively pins both `package:macros` and `package:_macros`
already (as in, there exists only a single version of each that pub will
successfully be able to solve within the context of a particular Flutter
SDK).

Therefore, it is safe for
[flutter/flutter](https://github.com/flutter/flutter) repository to
*not* pin `package:macros`, which will allow engine -> framework rolls
that contain a new Dart SDK that contains a new `package:_macros`
version to land automatically, provided all tests pass.
2024-05-09 16:28:49 -07:00
Ian Hickson
e1e742ac35
Remove hidden dependencies on the default LocalPlatform (#147342)
This is part 13 of a broken down version of the #140101 refactor.

This only makes one dependency explicit. Further PRs will do the same
for other dependencies, until these APIs have no hidden dependencies.
2024-05-09 15:33:55 -07:00
Nate
94a7151eb8
Getting rid of containers (#147432)
This pull request aims to make the Flutter framework more efficient,
based on issue #147431.
2024-05-09 16:31:54 -06:00
engine-flutter-autoroll
77427f6608
Roll Flutter Engine from c0fd3386d018 to 6e722ae213bd (2 revisions) (#148070)
c0fd3386d0...6e722ae213

2024-05-09 skia-flutter-autoroll@skia.org Roll Skia from 2a368794c73e to 2813bc21202e (2 revisions) (flutter/engine#52697)
2024-05-09 skia-flutter-autoroll@skia.org Roll Skia from aa82350f9cf4 to 2a368794c73e (1 revision) (flutter/engine#52696)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-09 18:16:19 +00:00
Michael Goderbauer
2bfb1b0e2f
Bump flutter_lints to 4.0 (#148020)
Follow-up to https://github.com/flutter/packages/pull/6695.
2024-05-09 18:07:51 +00:00
huycozy
bd44399865
Add Badge example (#148053)
### Demo screenshot

![Screenshot 2024-05-09 at 18 47 21](https://github.com/flutter/flutter/assets/104349824/9ca4c89f-0d0a-48b2-8149-3fae73f54212)

### Related issue
Fixes https://github.com/flutter/flutter/issues/144336
2024-05-09 16:47:16 +00:00
Benji Farquhar
a5e0c2ffe7
Fix ExpandIcon color when ExpansionPanel.canTapOnHeader true (#147097) (#147098)
Fixes https://github.com/flutter/flutter/issues/147097. The expand/collapse icon should not be the disabled color when ExpansionPanel.canTapOnHeader is true because the ExpansionPanel is active, and we may want to keep the icon there as a visual indicator to the user that it is expandable/collapsable.
2024-05-09 15:35:07 +00:00
engine-flutter-autoroll
607a3dad76
Roll Flutter Engine from c2e874fdc164 to c0fd3386d018 (1 revision) (#148040)
c2e874fdc1...c0fd3386d0

2024-05-09 skia-flutter-autoroll@skia.org Roll Skia from 68ab865c016f to aa82350f9cf4 (2 revisions) (flutter/engine#52695)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-09 08:39:07 +00:00
engine-flutter-autoroll
9f7b4e8424
Roll Flutter Engine from fe08238f5a52 to c2e874fdc164 (1 revision) (#148038)
fe08238f5a...c2e874fdc1

2024-05-09 skia-flutter-autoroll@skia.org Roll Skia from f4e251cc8407 to 68ab865c016f (2 revisions) (flutter/engine#52694)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-09 07:42:31 +00:00
engine-flutter-autoroll
54fec08643
Roll Flutter Engine from 69f2d9610a18 to fe08238f5a52 (1 revision) (#148034)
69f2d9610a...fe08238f5a

2024-05-09 skia-flutter-autoroll@skia.org Roll Skia from 91088addfbd9 to f4e251cc8407 (1 revision) (flutter/engine#52693)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-09 06:00:14 +00:00
flutter-pub-roller-bot
076e701f46
Roll pub packages (#148011)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-05-09 04:45:28 +00:00
engine-flutter-autoroll
972dcd7c65
Roll Flutter Engine from bd58d2b2d655 to 69f2d9610a18 (7 revisions) (#148030)
bd58d2b2d6...69f2d9610a

2024-05-08 skia-flutter-autoroll@skia.org Roll Skia from 4e83fac12783 to 91088addfbd9 (1 revision) (flutter/engine#52691)
2024-05-08 skia-flutter-autoroll@skia.org Roll Skia from df446841e3cd to 4e83fac12783 (2 revisions) (flutter/engine#52688)
2024-05-08 magder@google.com Fix UIVisualEffectView leak in platform view filter (flutter/engine#52591)
2024-05-08 jonahwilliams@google.com [Impeller] initialize ahb swapchain with max entries. (flutter/engine#52670)
2024-05-08 skia-flutter-autoroll@skia.org Roll Skia from 76f88de905be to df446841e3cd (3 revisions) (flutter/engine#52686)
2024-05-08 chinmaygarde@google.com Reland "Add host_profile_arm64 and host_release_arm64 local engine configurations." (flutter/engine#52633)
2024-05-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 27ZAbzJkEopmu0Emp... to RDVdjRvCxkJh2NLxS... (flutter/engine#52685)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 27ZAbzJkEopm to RDVdjRvCxkJh

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-09 02:41:26 +00:00
Kevin Moore
4e81abe85f
[web] Update wasm CLI details to be clear JavaScript is ALSO compiled (#147944)
At the moment, we ALWAYS compile JS with Wasm. The CLI flags should be clear on this!
2024-05-09 01:33:26 +00:00
Kate Lovett
00f40667c1
Exclude abi key in local golden file testing (#148023)
Part of https://github.com/flutter/flutter/issues/148022
2024-05-08 23:39:13 +00:00
Michael Goderbauer
26030557b1
Fix semantic debugger (#147953)
This was broken in https://github.com/flutter/flutter/pull/122452. The culprit is that `PipelineOwner.ensureSemantics` doesn't turn on semantics for the entire app, it pretends to only turn it on for the local `PipelineOwner`. Unfortunately, that local `PipelineOwner` is never informed that it should produce semantics when semantics are not turned on globally. So, `PipelineOwner.ensureSemantics` is essentially without effect if semantics are not already turned on globally.

I can't think of a use case where it would be useful to only turn on semantics for a particular pipeline owner and fixing `PipelineOwner.ensureSemantics` would get pretty messy with performance implications even if semantics are turned off. So, this PR deprecates that functionality and moves the `SemanticsDebugger` to the global semantics API.

Fixes https://github.com/flutter/flutter/issues/147665.
2024-05-08 23:12:47 +00:00