firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,238 Commits 1 Branch 0 Tags
Commit Graph

37238 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Zachary Anderson
67bceb8185 Split tests out of Linux Android artifact creation builds (flutter/engine#54683) 
Towards https://github.com/flutter/flutter/issues/145842.

Mostly a note to self: I'll need to write a lint at some point that this
does not regress. Possibly part of
https://github.com/flutter/engine/blob/main/tools/pkg/engine_build_configs/bin/check.dart,
but it will also need to query the ci.yaml to ask whether a build config
json is part of a `release_build: "true"` build.
 2024-08-21 15:14:03 -07:00
skia-flutter-autoroll
ca3518ac1a Roll Skia from 249d3f07c4d5 to 69f4bd859025 (5 revisions) (flutter/engine#54691) 
https://skia.googlesource.com/skia.git/+log/249d3f07c4d5..69f4bd859025

2024-08-21 fmalita@google.com [skottie] Fix Shift Channels effect coverage with FullOn alpha
2024-08-21 kjlubick@google.com Delete all filegroups that supported legacy (non-buffet) Bazel build
2024-08-21 cwallez@chromium.org Replace deprecated wgpu::SwapChain with wgpu::Surface
2024-08-21 kjlubick@google.com Move utils/SkTestCanvas -> tools/gpu/TestCanvas
2024-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 86508e2014f8 to 36f7e03a3578 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 21:28:22 +00:00
Chinmay Garde
74861200d4 [iOS] Tweak note about OpenGL support on mac in a user facing log. (flutter/engine#54690) 
We don't have an OpenGL backend on iOS.
 2024-08-21 20:46:04 +00:00
Jonah Williams
02a6c7a676 [Impeller] use blit pass to resize decoded images. (flutter/engine#54606) 
Fixes https://github.com/flutter/flutter/issues/153623
Fixes https://github.com/flutter/flutter/issues/153788

* Avoids slow CPU resizer
* Avoids us having to write any code at all to resize these images
* Avoids reading from the GPU staging buffers that are not read cached (similar to Glyph cache performance issues).

Also changes the single frame codec upload to either use the device private storage path or to defer upload until the GPU returns. This allows us to ensure that mips are always constructed and makes sure that we don't need to keep around the CPU texture reisze that depends on the Skia software backend.

Separately, I updated the deferred task system to allow separate success/failure tasks to make it easier to track the final state.
 2024-08-21 20:22:09 +00:00
Matan Lurey
7279070455 Remove spammy warning message on FlutterView (flutter/engine#54686) 
@matanlurey:

> As of 2f6952657d, we are now printing a `W/FlutterView( 7775): API level 34 is too low to query bounding rects.` message which is not user actionable. Was this intended to stay in the merged PR? What value is it supposed to have?

@yaakovschectman:

> You might be right about that
 2024-08-21 19:57:52 +00:00
Chinmay Garde
ee63d2a233 [Impeller] Perform integrity checks for Vulkan pipeline caches. (flutter/engine#54654) 
Fixes https://github.com/flutter/flutter/issues/128126

I scared myself looking into the recent Vulkan driver issues and decided to fix this to follow best-practices.

In addition to the comments, see the linked issue for the article on how this works. I didn't perform the data hashing because we use ::rename in fml::WriteAtomically and I am not as concerned about that. But we can add it later if needed. We also don't have a good utility to hash data.

This also gets rid of one intermediate allocation. We could also write directly into the file mapping but FML has no utilities to msync. Something to fix later if needed.
 2024-08-21 19:48:05 +00:00
Chris Bracken
635332a0dc docs: use test: all rather than editing .ci.yaml (flutter/engine#54667) 
Rather than editing `.ci.yaml` to enable the `linux_web_engine` shard, instead suggest tagging with the `test: all` label, which avoids the risk of accidentally committing an unwanted change to `.ci.yaml` and having to revert the change before landing.

This is also more future-proof against further `runIf` additions to `.ci.yaml`.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-21 19:06:49 +00:00
Jim Graham
28ee6cf0bb Reland "[DisplayList] Allow random access to ops through indexing" (flutter/engine#54676) 
Now also fixes: https://github.com/flutter/flutter/issues/153737

Being able to reorder rendering commands leads to optimization opportunities in the graphics package. A graphics package being fed from a DisplayList either has to take the commands in the order given or implement their own storage format for the rendering data.

With this new dispatching mechanism, the graphics package can both query basic information about the recorded ops and even dispatch them by the index into the list. Query information includes either the "category" of the op (clip/transform/render, etc.) or a specific op type enum. The package can dispatch some categories (or ops) immediately and remember other categories (or ops) along with their state for dispatching later.
 2024-08-21 18:20:24 +00:00
skia-flutter-autoroll
606b1fc4bf Roll Skia from 51ac9d93850c to 249d3f07c4d5 (2 revisions) (flutter/engine#54684) 
https://skia.googlesource.com/skia.git/+log/51ac9d93850c..249d3f07c4d5

2024-08-21 brianosman@google.com Remove SkSL program size limit
2024-08-21 nscobie@google.com [graphite] Update createGraphicsPipeline trace slice to _ALWAYS variant

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 18:12:06 +00:00
Chris Bracken
ae6c96511e iOS,macOS: Don't archive extra framework metadata (flutter/engine#54674) 
By default, zip archives don't just archive the files themselves, but also bundle extra metadata such as unix owner/group and unix timestamps. None of these is particularly important in the case of Flutter: owner/group information is likely to differ across machines and thus be overridden on the unarchiver's end. The tool checks for file presence and occasionally content hashes.

This change results in more reproducible zip archives across runs/machines.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-21 17:49:21 +00:00
skia-flutter-autoroll
1c8e23a8fb Roll Dart SDK from 48f9b96d71e7 to 060e40916514 (1 revision) (flutter/engine#54682) 
https://dart.googlesource.com/sdk.git/+log/48f9b96d71e7..060e40916514

2024-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-166.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 17:44:48 +00:00
Yegor
79a6989314 [web] annotate obscured text fields as passwords (flutter/engine#54664) 
The `type` attribute is needed for screen readers to tell the user whether the text field is a password or a plain text field.

Use `-webkit-text-security` for multi-line fields as a best effort (it's non-standard but is supported by all major browsers).

Fixes https://github.com/flutter/flutter/issues/153801
 2024-08-21 17:40:04 +00:00
skia-flutter-autoroll
de582e9145 Roll Skia from c31e2ca59bd9 to 51ac9d93850c (2 revisions) (flutter/engine#54681) 
https://skia.googlesource.com/skia.git/+log/c31e2ca59bd9..51ac9d93850c

2024-08-21 jvanverth@google.com [graphite] Add inverse fill support to circular rrect clip.
2024-08-21 jamesgk@google.com [ganesh] Avoid int overflow when combining RegionOps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 16:41:39 +00:00
Jonah Williams
248dfb2334 [engine] reland weaken affinity of raster/ui to non-e core instead of only fast core (flutter/engine#54616) 
Some android devices have only a single fast core. We set the threading affinity for UI/Raster to the fast core, which can lead to the UI/Raster being serialized on this thread. Instead, we should weaken /invert the affinity to "Not slow cores".

FIxes https://github.com/flutter/flutter/issues/153690

Customer money will see some benchmark regressions but they can deal.
 2024-08-21 16:31:55 +00:00
skia-flutter-autoroll
aa26fa1254 Roll Skia from c00866df101a to c31e2ca59bd9 (2 revisions) (flutter/engine#54680) 
https://skia.googlesource.com/skia.git/+log/c00866df101a..c31e2ca59bd9

2024-08-21 nicolettep@google.com [graphite] Enable Vulkan dual-source blending when device supports it
2024-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b36cd71bb7c9 to 4bf3eeb31636 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 15:25:18 +00:00
skia-flutter-autoroll
5e0c4dffc0 Roll Skia from 39e5118034f4 to c00866df101a (1 revision) (flutter/engine#54678) 
https://skia.googlesource.com/skia.git/+log/39e5118034f4..c00866df101a

2024-08-21 borenet@google.com [bazel] More fixes for Windows build

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 14:06:30 +00:00
skia-flutter-autoroll
2946f17921 Roll Skia from 221ada80b174 to 39e5118034f4 (1 revision) (flutter/engine#54677) 
https://skia.googlesource.com/skia.git/+log/221ada80b174..39e5118034f4

2024-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1a191b1d5dc8 to 86508e2014f8 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 11:10:18 +00:00
skia-flutter-autoroll
8365126b21 Roll Skia from d576296091e0 to 221ada80b174 (2 revisions) (flutter/engine#54675) 
https://skia.googlesource.com/skia.git/+log/d576296091e0..221ada80b174

2024-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 244b54c99d6e to b4341e24cfa5
2024-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 87111746e4cc to 244b54c99d6e (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 07:20:30 +00:00
skia-flutter-autoroll
71063c1ea0 Roll Dart SDK from 49f655b526c7 to 48f9b96d71e7 (1 revision) (flutter/engine#54672) 
https://dart.googlesource.com/sdk.git/+log/49f655b526c7..48f9b96d71e7

2024-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-165.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 06:06:27 +00:00
skia-flutter-autoroll
cf4021a2dd Roll Fuchsia Linux SDK from 3a16kOsyFmJh3lo7e... to XGzE3idakwfQZ68pb... (flutter/engine#54671) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 06:06:25 +00:00
skia-flutter-autoroll
ad7a7ba7a1 Roll Skia from a3388794e06e to d576296091e0 (1 revision) (flutter/engine#54670) 
https://skia.googlesource.com/skia.git/+log/a3388794e06e..d576296091e0

2024-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 40d470c73393 to 7ee30f5d2f5a (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 06:02:21 +00:00
Jason Simmons
164eb442db Remove unnecessary breaks in default clauses of switch statements (flutter/engine#54669) 
See https://dart.googlesource.com/sdk.git/+/045d26bc74209f5acc6466669f89686344e83de2
 2024-08-21 04:31:26 +00:00
Chinmay Garde
bc6d7fa164 [Impeller] Remove unused ColorHSB. (flutter/engine#54659) 
I didn't realize I hadn't cleaned this up. We've never needed it in Impeller.
 2024-08-21 03:47:19 +00:00
skia-flutter-autoroll
3452638b57 Roll Skia from 90671d1b342c to a3388794e06e (1 revision) (flutter/engine#54666) 
https://skia.googlesource.com/skia.git/+log/90671d1b342c..a3388794e06e

2024-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3fa5bf77e2bf to b36cd71bb7c9 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-21 01:58:29 +00:00
Chris Bracken
d18ba04282 Clean up macOS framework creation scripts (flutter/engine#54658) 
This refactors `create_fat_macos_framework`, `_regenerate_symlinks` and
`_set_framework_permissions` to be more generic and not hardcode "FlutterMacOS"
as a framework name. Further, it reuses several utility functions from the iOS
code in `sky_utils` to improve readability and eliminate duplication.

This is refactoring prior to embedding dSYMs in FlutterMacOS.xcframework in a
followup patch.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-21 00:46:15 +00:00
skia-flutter-autoroll
950352ab04 Roll Skia from 51d7e221fef0 to 90671d1b342c (1 revision) (flutter/engine#54663) 
https://skia.googlesource.com/skia.git/+log/51d7e221fef0..90671d1b342c

2024-08-20 robertphillips@google.com Revert "Add [[nodiscard]] to Sk[I]Rect::intersect"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 23:53:05 +00:00
Brandon DeRosier
28f75263ff Revert "[DisplayList] Allow random access to ops through indexing" (flutter/engine#54661) 
Reverts flutter/engine#54484

Fixes https://github.com/flutter/flutter/issues/153737
 2024-08-20 23:16:05 +00:00
skia-flutter-autoroll
d109230b49 Roll Dart SDK from 04c57423f90d to 49f655b526c7 (2 revisions) (flutter/engine#54660) 
https://dart.googlesource.com/sdk.git/+log/04c57423f90d..49f655b526c7

2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-164.0.dev
2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-163.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 23:08:20 +00:00
skia-flutter-autoroll
76a55c1355 Roll Skia from b472cacb48d6 to 51d7e221fef0 (2 revisions) (flutter/engine#54656) 
https://skia.googlesource.com/skia.git/+log/b472cacb48d6..51d7e221fef0

2024-08-20 michaelludwig@google.com Add [[nodiscard]] to Sk[I]Rect::intersect
2024-08-20 jvanverth@google.com Reland "[graphite] Add purge() method to DrawAtlas."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 21:48:04 +00:00
gaaclarke
a6c6c50a25 Changes DlColor to support wide gamut colors (#54473) (flutter/engine#54648) 
relands https://github.com/flutter/engine/pull/54473
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with https://github.com/flutter/engine/pull/54415 when it lands in https://github.com/flutter/engine/pull/54567.

## Difference from last attempt

1) The default color is now opaque black, not transparent black (not the issue for revert)
1) Updated a test to send in valid numbers when constructing a color and added asserts to avoid those problems in the future.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-20 21:44:24 +00:00
skia-flutter-autoroll
e256163e94 Roll Skia from a8160d808252 to b472cacb48d6 (1 revision) (flutter/engine#54653) 
https://skia.googlesource.com/skia.git/+log/a8160d808252..b472cacb48d6

2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from ae5dd592666e to 40d470c73393 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 20:21:12 +00:00
skia-flutter-autoroll
a11c7c0aed Manual roll Dart SDK from c5264a1bd1d2 to 04c57423f90d (13 revisions) (flutter/engine#54649) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/c5264a1bd1d2..04c57423f90d

2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-162.0.dev
2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-161.0.dev
2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-160.0.dev
2024-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-159.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-158.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-157.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-156.0.dev
2024-08-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-155.0.dev
2024-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-154.0.dev
2024-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-153.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-152.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-151.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-150.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 18:44:07 +00:00
skia-flutter-autoroll
0c19856b76 Roll Skia from 6299c5744307 to a8160d808252 (6 revisions) (flutter/engine#54651) 
https://skia.googlesource.com/skia.git/+log/6299c5744307..a8160d808252

2024-08-20 nscobie@google.com [Android] Don't evaluate trace arguments if using ATrace but !ATRACE_ENABLED()
2024-08-20 bungeman@google.com Roll FreeType from 73720c7c to f92c9655 (23 commits)
2024-08-20 robertphillips@google.com Revert "[rust png] Extract minimal `SkPngCodecBase`."
2024-08-20 lukasza@chromium.org [rust png] Extract minimal `SkPngCodecBase`.
2024-08-20 sharaks@google.com Merge 5 release notes into RELEASE_NOTES.md
2024-08-20 sharaks@google.com Update Skia milestone to 130

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 18:42:19 +00:00
yaakovschectman
2f6952657d Use getBoundingRects to add support inset MediaQuery/SafeArea when in freeform mode controls are shown. (flutter/engine#54294) 
Original Title: Add FlutterViewDelegate and BoundingRect methods

Check the bounding rect for caption bar when sending viewport metrics to
Flutter to account for freeform mode. Use the more recent
`getBoundingRects` over `getInsets`.

Tests will need to be kept separate until Robolectric publishes a
version that supports API level 35.
Roboletric tests for this pr will be part of google testing until then. 
Pr for tests here https://critique.corp.google.com/cl/657302386. 

https://github.com/flutter/flutter/issues/146658

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-08-20 13:09:00 -04:00
skia-flutter-autoroll
149b1974f5 Manual roll Dart SDK from c5264a1bd1d2 to c22bf5aedbcf (2 revisions) (flutter/engine#54646) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/c5264a1bd1d2..c22bf5aedbcf

2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-151.0.dev
2024-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-150.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 16:43:21 +00:00
skia-flutter-autoroll
444b7b801c Roll Skia from d6548fdb78c1 to 6299c5744307 (1 revision) (flutter/engine#54643) 
https://skia.googlesource.com/skia.git/+log/d6548fdb78c1..6299c5744307

2024-08-20 kjlubick@google.com Delete old GLFW interface

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 14:24:24 +00:00
skia-flutter-autoroll
916f7e5ec0 Roll Skia from cc9c81d7fc4d to d6548fdb78c1 (1 revision) (flutter/engine#54642) 
https://skia.googlesource.com/skia.git/+log/cc9c81d7fc4d..d6548fdb78c1

2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b038f07b8faf to 3fa5bf77e2bf (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 12:40:34 +00:00
Jim Graham
ef6db0c87e Check return values for Sk[I]Rect::intersect (flutter/engine#54577) 
The `SkRect::intersect` and `SkIRect::intersect` methods return values that must be handled or the calling code might end up with a non-empty answer for non-intersecting rectangles. There were 3 or 4 places in our code that we weren't doing this so now we check them all, in some cases even if we believe that the answer will not be empty.

This is prep work so that Skia can add `[[nodiscard]]` directives to these 2 methods so that nobody else makes that mistake.
 2024-08-20 09:48:20 +00:00
skia-flutter-autoroll
e2a19f2099 Roll Skia from ada9a367c5f2 to cc9c81d7fc4d (1 revision) (flutter/engine#54641) 
https://skia.googlesource.com/skia.git/+log/ada9a367c5f2..cc9c81d7fc4d

2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 579a58552fa6 to 1a191b1d5dc8 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 08:33:21 +00:00
skia-flutter-autoroll
616470db70 Roll Skia from 30a00629e135 to ada9a367c5f2 (4 revisions) (flutter/engine#54640) 
https://skia.googlesource.com/skia.git/+log/30a00629e135..ada9a367c5f2

2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 87111746e4cc to c71e16037f25
2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from da2e5cb8d546 to 87111746e4cc (5 revisions)
2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 65157d32945d to 7216df70d311 (1 revision)
2024-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from db1fa936ad0a to ae5dd592666e (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 06:52:24 +00:00
skia-flutter-autoroll
54ae1c04d5 Roll Fuchsia Linux SDK from hNxjRSbGnxD3IhdOm... to 3a16kOsyFmJh3lo7e... (flutter/engine#54638) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 04:53:04 +00:00
skia-flutter-autoroll
64e5de4381 Roll Fuchsia Test Scripts from -XDS8eBA0Le-zCEfW... to 2fOjXGNxdSoRSGCL7... (flutter/engine#54635) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC chrome-fuchsia-engprod@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 02:59:01 +00:00
Srujan Gaddam
d16a9057a0 Update package:js version constraints to ^0.7.0 and update test versions to match (flutter/engine#54629) 
This removes the dependency on `dart:js` and allows that library to be removed from dart2wasm. Also updates `test` dependencies to work with the new `package:js` constraints.
 2024-08-20 02:58:58 +00:00
skia-flutter-autoroll
8f02ca0cbe Roll Skia from e65e02c50d66 to 30a00629e135 (3 revisions) (flutter/engine#54634) 
https://skia.googlesource.com/skia.git/+log/e65e02c50d66..30a00629e135

2024-08-20 brianosman@google.com Reland "Guard division in luminosity blend against overflow"
2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f8f75e8cc154 to b038f07b8faf (3 revisions)
2024-08-19 kschmi@microsoft.com Revert "Revert "Reland "Reduce size of linear SkMaskGamma LUT"""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-20 02:57:29 +00:00
auto-submit[bot]
8aabbdd12f Reverts "Changes DlColor to support wide gamut colors (#54473)" (flutter/engine#54636) 
Reverts: flutter/engine#54473
Initiated by: jonahwilliams
Reason for reverting: golden diffs like https://flutter-engine-gold.skia.org/detail?grouping=name%3Dimpeller_Play_AiksTest_BlendModeSrcAlphaLuminosity_OpenGLES%26source_type%3Dflutter-engine&digest=107ccd2cd1170746b1ffc4d31184e789 look incorrect, potentially an alpha issue
Original PR Author: gaaclarke

Reviewed By: {flar}

This change reverts the following previous change:
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with https://github.com/flutter/engine/pull/54415 when it lands in https://github.com/flutter/engine/pull/54567.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-20 02:19:47 +00:00
Jonah Williams
d6f4f4a66e [Impeller] account for negative scale in max basis xy. (flutter/engine#54630) 
Otherwise we get funky negative scales that break tessellation.
 2024-08-19 23:27:54 +00:00
gaaclarke
1fde0ad466 Changes DlColor to support wide gamut colors (flutter/engine#54473) 
issue: https://github.com/flutter/flutter/issues/127855
integration test: https://github.com/flutter/engine/pull/54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with https://github.com/flutter/engine/pull/54415 when it lands in https://github.com/flutter/engine/pull/54567.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-08-19 23:16:55 +00:00
skia-flutter-autoroll
d96f5fd76b Roll Skia from b6224c9e6611 to e65e02c50d66 (2 revisions) (flutter/engine#54628) 
https://skia.googlesource.com/skia.git/+log/b6224c9e6611..e65e02c50d66

2024-08-19 robertphillips@google.com Revert "GPU support for F16F16F16x SkColorType."
2024-08-19 robertphillips@google.com [graphite] Break DrawTypeFlags::kText into finer grained draw types

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-08-19 22:33:06 +00:00
Kevin Moore
28e7d0ec2a web_ui: bump min Dart SDK to 3.6.0-0 (flutter/engine#54626) 
Also removed two unused dev dependencies

Enables usage of `Since` in dart:js_interop
 2024-08-19 22:11:55 +00:00
Chinmay Garde
0ac477bb08 [Impeller] Add a note about Graphite to the FAQ. (flutter/engine#54623) 
Action item from go/impeller-faq-followups.
 2024-08-19 22:07:10 +00:00