Jackson Gardner
5e39c69831
[skwasm] Fix skwasm clip coverage algorithm. ( flutter/engine#54572 )
...
This previously was basically assuming that two clip regions would be a union but instead it's actually an intersection. Also, for some reason I had forgotten to actually implement `boundingRect` for the rrect clip region. I changed this for a bit more clarity.
2024-08-19 21:45:07 +00:00
skia-flutter-autoroll
f93445acce
Roll Skia from 318b7958f748 to b6224c9e6611 (2 revisions) ( flutter/engine#54625 )
...
https://skia.googlesource.com/skia.git/+log/318b7958f748..b6224c9e6611
2024-08-19 danieldilan@google.com GPU support for F16F16F16x SkColorType.
2024-08-19 brianosman@google.com Revert "Guard division in luminosity blend against overflow"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 21:15:15 +00:00
Robert Ancell
2bbc3b4b41
Allow the default background color to be changed ( flutter/engine#54575 )
...
Fixes https://github.com/flutter/flutter/issues/149920
2024-08-20 08:00:06 +12:00
skia-flutter-autoroll
11288f546d
Roll Skia from d528658273db to 318b7958f748 (4 revisions) ( flutter/engine#54620 )
...
https://skia.googlesource.com/skia.git/+log/d528658273db..318b7958f748
2024-08-19 kjlubick@google.com Apply clang-tidy suggestion to graphite files
2024-08-19 bungeman@google.com Add SK_USE_FREETYPE_EMBOLDEN to NativeFonts_FreeType
2024-08-19 danieldilan@google.com CPU support of F16F16F16x SkColorType.
2024-08-19 borenet@google.com [bazel] Fix defines for freetype on Windows
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 19:44:24 +00:00
Chinmay Garde
41c82cd7f9
[Impeller] use paragraphs instead of bullet points in the FAQ. ( flutter/engine#54622 )
...
Fixes https://github.com/flutter/flutter/issues/153316
Other than one question that pointed to outdated links, its just the same as the old FAQ. Will submit the updates based on recent conversations in a followup patch.
It should now be possible to link to specific questions in the FAQ.
2024-08-19 19:40:15 +00:00
Jonah Williams
8b7101800f
[Impeller] finish experimental canvas changes. ( flutter/engine#54569 )
...
Make sure the old dispatcher cannot be used if the new dispatcher is enabled. Migrate tests using old canvas to new canvas, mostly to make deleting the old one easier...
2024-08-19 19:37:17 +00:00
skia-flutter-autoroll
b5881266a3
Roll Skia from d88bfe2939e8 to d528658273db (9 revisions) ( flutter/engine#54619 )
...
https://skia.googlesource.com/skia.git/+log/d88bfe2939e8..d528658273db
2024-08-19 borenet@google.com [bazel] Fix skshaper build for Windows
2024-08-19 brianosman@google.com Guard division in luminosity blend against overflow
2024-08-19 kjlubick@google.com Remove unused gni file list
2024-08-19 borenet@google.com [bazel] Fix zlib defines for Windows
2024-08-19 borenet@google.com [bazel] Fix global compile options for Windows
2024-08-19 michaelludwig@google.com [ganesh] Fix MeshOp index combination logic
2024-08-19 robertphillips@google.com [graphite] Revise DrawTypeFlags
2024-08-19 michaelludwig@google.com Update $color_burn_component to single flow of control
2024-08-19 michaelludwig@google.com Reland "Avoid branches and early returns in $color_dodge_component"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 18:09:22 +00:00
Reid Baker
859b18e112
Set download_jdk variable ( flutter/engine#54584 )
...
Follow up from https://github.com/flutter/engine/pull/54450#issuecomment-2282244288
2024-08-19 15:33:08 +00:00
skia-flutter-autoroll
a5bad33fbc
Roll Skia from e49cd5f3cffb to d88bfe2939e8 (1 revision) ( flutter/engine#54613 )
...
https://skia.googlesource.com/skia.git/+log/e49cd5f3cffb..d88bfe2939e8
2024-08-19 borenet@google.com [bazel] Fix copy and patch commands for Windows
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 15:00:24 +00:00
Kaylee Lubick
b5ac6eafc9
Update gni filegroup when building Skia's codec files ( flutter/engine#54588 )
...
This was added in https://skia-review.googlesource.com/c/skia/+/890319
and Skia plans to delete the old group.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-19 07:15:05 -07:00
skia-flutter-autoroll
8cf4bf7e56
Roll Skia from 3896447e3531 to e49cd5f3cffb (1 revision) ( flutter/engine#54612 )
...
https://skia.googlesource.com/skia.git/+log/3896447e3531..e49cd5f3cffb
2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 99bced033e05 to f8f75e8cc154 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 09:59:29 +00:00
skia-flutter-autoroll
9f734ce281
Roll Skia from 5274def7cf1f to 3896447e3531 (1 revision) ( flutter/engine#54611 )
...
https://skia.googlesource.com/skia.git/+log/5274def7cf1f..3896447e3531
2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 83ca89e58cef to 579a58552fa6 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 08:49:29 +00:00
skia-flutter-autoroll
4b47c0cf23
Roll Skia from 75bd296f9756 to 5274def7cf1f (2 revisions) ( flutter/engine#54610 )
...
https://skia.googlesource.com/skia.git/+log/75bd296f9756..5274def7cf1f
2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from da2e5cb8d546 to db27834aff1f
2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 521d0157ce62 to da2e5cb8d546 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 07:18:38 +00:00
skia-flutter-autoroll
d89be06f16
Roll Skia from 7025ec4bff25 to 75bd296f9756 (1 revision) ( flutter/engine#54609 )
...
https://skia.googlesource.com/skia.git/+log/7025ec4bff25..75bd296f9756
2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 69433722b83b to db1fa936ad0a (23 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 06:01:27 +00:00
skia-flutter-autoroll
97d9479fd6
Roll Fuchsia Linux SDK from yKkNB9F8Hwnjq2AMW... to hNxjRSbGnxD3IhdOm... ( flutter/engine#54608 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-19 03:30:32 +00:00
skia-flutter-autoroll
72f1100cb0
Roll Skia from ac7149e315ec to 7025ec4bff25 (1 revision) ( flutter/engine#54605 )
...
https://skia.googlesource.com/skia.git/+log/ac7149e315ec..7025ec4bff25
2024-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d8208b108762 to 99bced033e05 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-18 06:26:23 +00:00
skia-flutter-autoroll
85e645fb6b
Roll Fuchsia Linux SDK from a3zdjZKduabZSBN0B... to yKkNB9F8Hwnjq2AMW... ( flutter/engine#54602 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-18 02:07:23 +00:00
skia-flutter-autoroll
4bc75e7bd6
Roll Skia from 570b18e1afda to ac7149e315ec (1 revision) ( flutter/engine#54600 )
...
https://skia.googlesource.com/skia.git/+log/570b18e1afda..ac7149e315ec
2024-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0ff16cd9feaa to d8208b108762 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,michaelludwig@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-17 18:05:17 +00:00
Zachary Anderson
21fdc613b0
Shift linux_fuchsia_tests from staging to prod ( flutter/engine#54597 )
...
Follow up to https://github.com/flutter/engine/pull/54591
2024-08-16 22:21:26 -07:00
skia-flutter-autoroll
338ea8ebb6
Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... ( flutter/engine#54596 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-17 00:46:20 +00:00
skia-flutter-autoroll
f39d64edc2
Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) ( flutter/engine#54595 )
...
https://skia.googlesource.com/skia.git/+log/219bd1032761..570b18e1afda
2024-08-16 michaelludwig@google.com Revert "Avoid branches and early returns in $color_dodge_component"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,michaelludwig@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-17 00:36:13 +00:00
Chris Bracken
53ded8b97b
macOS: Extract framework creation to sky_utils ( flutter/engine#54586 )
...
This refactors `create_mac_framework.py` to extract framework creation to `sky_utils.py`. The only other changes are minor variable renaming and extraction of functions to make the code more readable/easier to work with.
The resulting zip archives have been verified to be identical before and after.
This is refactoring to support embedding dSYM debug information in a follow-up patch.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-17 00:12:13 +00:00
skia-flutter-autoroll
03fefc7ee4
Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) ( flutter/engine#54592 )
...
https://skia.googlesource.com/skia.git/+log/fc8769175d35..219bd1032761
2024-08-16 michaelludwig@google.com Avoid branches and early returns in $color_dodge_component
2024-08-16 michaelludwig@google.com Revert "[graphite] Add purge() method to DrawAtlas."
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dad70915c62f to 0ff16cd9feaa (5 revisions)
2024-08-16 briansalomon@gmail.com DropShadow image filters accept float colors and color spaces for the shadow color.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,michaelludwig@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 23:17:14 +00:00
Chris Bracken
398d81d82d
[docs] Add missing steps to Testing Presubmit Engine PRs ( flutter/engine#54593 )
...
Most framework tests perform a `flutter precache` or rely on the web SDK in some form. The Web SDK is not build in presubmit by default. As such, developers will need to manually comment out the `runIf` conditional block that prevents the web SDK from being built during presubmit, then later hope they uncomment it before landing their patch.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-16 23:15:13 +00:00
Zachary Anderson
ba0110c34f
Move Fuchsia tests to a separate config file ( flutter/engine#54591 )
...
Temporary workaround for https://github.com/flutter/flutter/issues/152186 .
2024-08-16 22:32:05 +00:00
skia-flutter-autoroll
9f1804cd2f
Roll Skia from 7c0eeaf12413 to fc8769175d35 (58 revisions) ( flutter/engine#54589 )
...
Roll Skia from 7c0eeaf12413 to fc8769175d35 (58 revisions)
https://skia.googlesource.com/skia.git/+log/7c0eeaf12413..fc8769175d35
2024-08-16 kjlubick@google.com Apply buildifier to modules/audioplayer
2024-08-16 fmalita@google.com [bazel] Add Viewer resources
2024-08-16 bungeman@google.com SkScalerContext implementation specific emboldening
2024-08-16 jvanverth@google.com [graphite] Add purge() method to DrawAtlas.
2024-08-16 brianosman@google.com Revert "[pdf] Emit bare CFF instead of OpenType CFF"
2024-08-16 borenet@google.com Reapply "[bazel] Remove symlinks for external files"
2024-08-16 lukasza@chromium.org Delete `DECODE_PNG_FILES` from `src/codec/BUILD.bazel`
2024-08-16 lukasza@chromium.org Depend only on public PNG headers from `ico_decode` target.
2024-08-16 lukasza@chromium.org Add GNI group for PNG and expand source list
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 97855a7c330f to dad70915c62f (5 revisions)
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2003e06230b1 to 83ca89e58cef (6 revisions)
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2918c4247f20 to 69433722b83b (16 revisions)
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 936d3406908e to 521d0157ce62 (7 revisions)
2024-08-16 jvanverth@google.com [graphite] Make DrawAtlas::compact() more aggressive.
2024-08-16 jvanverth@google.com [graphite] Avoid one ref when dealing with subRunStorage.
2024-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 936d3406908e to 521d0157ce62
2024-08-16 michaelludwig@google.com Revert "[bazel] Remove symlinks for external files"
2024-08-16 michaelludwig@google.com Revert "Reland "Reduce size of linear SkMaskGamma LUT""
2024-08-16 michaelludwig@google.com Simplify Porter-Duff constant blend function
2024-08-15 brianosman@google.com Implement asAColorMode and asAColorMatrix for SkWorkingFormatColorFilter
2024-08-15 borenet@google.com [bazel] Remove symlinks for external files
2024-08-15 kschmi@microsoft.com Reland "Reduce size of linear SkMaskGamma LUT"
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 91058f2297c9 to 97855a7c330f (1 revision)
2024-08-15 lukasza@chromium.org [rust png] Avoiding newtype wrapper for `cxx::UniquePtr<ffi::ReadTrait>`
2024-08-15 lukasza@chromium.org [rust png] Expose `png::Reader` over the FFI boundary.
2024-08-15 fmalita@google.com [bazel] Enable SVG support in Viewer
2024-08-15 robertphillips@google.com Reland "[graphite] Add DawnCaps::extractGraphicsDescs"
2024-08-15 bungeman@google.com [pdf] Emit bare CFF instead of OpenType CFF
2024-08-15 jamesgk@google.com [graphite] Don't run GMs that test automatic image tiling
2024-08-15 geofflang@google.com Reland "Allow client arrays on ANGLE."
2024-08-15 fmalita@google.com [bazel] More viewer slides
2024-08-15 kjlubick@google.com Remove all references to legacy //:skia_public and //:skia_internal
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 087afc919eda to 2003e06230b1 (8 revisions)
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0d313c52316c to 91058f2297c9 (3 revisions)
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 60f8f34ea424 to 936d3406908e (8 revisions)
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 239f9139d016 to 2918c4247f20 (14 revisions)
2024-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 60f8f34ea424 to 936d3406908e
2024-08-14 robertphillips@google.com Revert "[graphite] Add DawnCaps::extractGraphicsDescs"
2024-08-14 robertphillips@google.com Revert "[graphite] Fix static initializer problem wrt Caps Domains"
2024-08-14 robertphillips@google.com [graphite] Fix static initializer problem wrt Caps Domains
2024-08-14 fmalita@google.com [bazel] Enable Skottie support in Viewer
2024-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f084a55f96da to 0d313c52316c (1 revision)
2024-08-14 ccameron@chromium.org Add SkJpegMetadataDecoder::Make that takes SkData
2024-08-14 kjlubick@google.com Enforce IWYU on graphite/geom
2024-08-14 kjlubick@google.com Apply clang-tidy suggestion to UploadTask
2024-08-14 kjlubick@google.com Fix Bazel build of viewer after GPU_TEST_UTILS landed
...
2024-08-16 21:38:09 +00:00
Michael Ludwig
5c6fc5db0c
Remove SkOSLibrary files from build and license scripts ( flutter/engine#54583 )
...
These are no longer under the `src/ports` directory in Skia and are in
`tools/`. But it appears that Flutter does not actually quire them.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-16 16:29:13 -04:00
Chris Bracken
7a8fde83b1
iOS: Add dSYM binaries to without_entitlements.txt ( flutter/engine#54576 )
...
In flutter/engine#54414 , we added dSYM files for physical and simulator binaries in both regular and extension-safe framework builds, but did not add the dSYMs to the without_entitlements.txt list.
This passed all engine pre/post-submit tests, as well as framework tests, but failed during release code signing in Cocoon in a test here:
d849b14bab/cipd_packages/codesign/lib/src/file_codesign_visitor.dart (L305-L313)https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20Production%20Engine%20Drone/13590/overview
A corresponding change was landed on the [flutter-3.24-candidate.1](https://github.com/flutter/engine/tree/flutter-3.24-candidate.1 ) branch:
https://github.com/flutter/engine/pull/54573
The build associated with that patch correctly completed code signing in this build:
https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20engine_release_builder/688/overview
And more specifically, this sub-build:
https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20Production%20Engine%20Drone/13650/overview
And even more specifically, this build step:
https://logs.chromium.org/logs/dart-internal/buildbucket/cr-buildbucket/8739493904842446705/+/u/Global_generators/Codesign__Volumes_Work_s_w_ir_cache_builder_src_out_release_unsigned_artifacts.zip/codesign_Apple_engine_binaries/stdout
Additionally, this patch adds `sky_utils.assert_valid_codesign_config()` which fails the script (and thus the build) with an error message if any file in scope for code signing (i.e. Mach-O binaries) is not listed in the code-signing config (`entitlements.txt`, `without_entitlements.txt`), or any listed file is not found on disk.
Issue: https://github.com/flutter/flutter/issues/116493
Issue: https://github.com/flutter/flutter/issues/153532
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-16 16:27:52 +00:00
Kevin Chisholm
46b12974c4
Manual roll Dart SDK from 44635f897535 to 8c02ad43e01a (3 revisions) ( flutter/engine#54581 )
...
Manual roll requested by [kevinjchisholm@google.com ](mailto:kevinjchisholm@google.com)
https://dart.googlesource.com/sdk.git/+log/44635f897535..8c02ad43e01a
2024-08-14 [dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com) Version 3.6.0-149.0.dev
2024-08-13 [dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com) Version 3.6.0-148.0.dev
2024-08-13 [dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com) Version 3.6.0-147.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [dart-vm-team@google.com ](mailto:dart-vm-team@google.com),[kevinjchisholm@google.com ](mailto:kevinjchisholm@google.com),[zra@google.com ](mailto:zra@google.com) on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 16:26:17 +00:00
auto-submit[bot]
31de779cda
Reverts "Manual roll Dart SDK from 44635f897535 to 790fcb755a0a (3 revisions) ( #54558 )" ( flutter/engine#54578 )
...
Reverts: flutter/engine#54558
Initiated by: itsjustkevin
Reason for reverting: Dart revert was not properly applied.
Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot, zanderso}
This change reverts the following previous change:
Manual roll requested by kevinjchisholm@google.com
https://dart.googlesource.com/sdk.git/+log/44635f897535..790fcb755a0a
2024-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-149.0.dev
2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-148.0.dev
2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-147.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,kevinjchisholm@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 12:42:47 +00:00
skia-flutter-autoroll
1fd7178a48
Manual roll Dart SDK from 44635f897535 to 790fcb755a0a (3 revisions) ( flutter/engine#54558 )
...
Manual roll requested by kevinjchisholm@google.com
https://dart.googlesource.com/sdk.git/+log/44635f897535..790fcb755a0a
2024-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-149.0.dev
2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-148.0.dev
2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-147.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,kevinjchisholm@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 01:08:23 +00:00
skia-flutter-autoroll
17cfcca682
Roll Fuchsia Linux SDK from qpfC-GAVZvOwAQU5f... to Z5hq3ZkPNCpZWRQnl... ( flutter/engine#54574 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-15 23:34:23 +00:00
Jonah Williams
343fc75076
[Impeller] add support for superellipse. ( flutter/engine#54562 )
...
This is an entity testing only implementation of a superellipse. rectellipse is a special case where degree = 4.
Part of https://github.com/flutter/flutter/issues/139321
2024-08-15 22:40:58 +00:00
Harry Terkelsen
e0529ddd81
[canvaskit] Improve how overlays are optimized ( flutter/engine#54547 )
...
Enhances the overlay optimization by pushing new pictures to the earliest RenderCanvas they can go into. This improvement is made especially clear in the new test case I added to `embedded_views_test.dart`, with the previous algorithm we would have used an overlay for each platform view even though all of the pictures could go into the base canvas with no issue.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-15 22:23:00 +00:00
Jonah Williams
9c6ec923c9
[Impeller] revert experimental canvas. ( flutter/engine#54570 )
...
Revert due to framework crashes: https://github.com/flutter/flutter/pull/153521
2024-08-15 21:30:01 +00:00
Oleg Magomedov
e55ebe1d32
Fix typo in AppLifecycleState documentation ( flutter/engine#54544 )
...
Fixes small typo in AppLifecycleState enum documentation. Documentation to enum references iOS article about managing app lifecycle in UIKit. So, "IOKit" is a misspelled word "UIKit"
I found out Apple has [IOKit framework](https://developer.apple.com/documentation/iokit ) but it is not related to app lifecycle
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-15 20:27:39 +00:00
John McDole
885d9f1054
Update RBE troubleshooting ( flutter/engine#54568 )
...
Add `could not get valid Application Default Credentials token` troubleshooting
2024-08-15 19:07:05 +00:00
Jonah Williams
67cc9696a8
[Impeller] Switch from AIKS canvas to DL based canvas implementation. ( flutter/engine#53781 )
...
The first part of switching Impeller/Aiks to using the display list instead of re-recording rendering operations. This should eventually let us cut CPU overhead of the raster thread for complex applications, though it should have no impact on GPU performance.
This does introduce a GLES only rendering bug that I haven't had luck tracking down, but is almost certainly due to switching to DL computed depth values. I'd like to handle this as a follow up when we prioritize GLES. https://github.com/flutter/flutter/issues/153504
Part of https://github.com/flutter/flutter/issues/142054
2024-08-15 19:03:43 +00:00
Jonah Williams
90dcf59597
[Impeller] convert aiks blur tests to new canvas. ( flutter/engine#54565 )
...
Part of DL interop. Currently experiencing some ... issues with blur radius/sigma.
EDIT: was rrect_blur vs gaussian: fixed now.
Part of https://github.com/flutter/flutter/issues/142054
Reland because of CI issue?
2024-08-15 17:39:18 +00:00
auto-submit[bot]
eaca267327
Reverts "macOS: Refactor create_macos_framework.py ( #54557 )" ( flutter/engine#54566 )
...
Reverts: flutter/engine#54557
Initiated by: zanderso
Reason for reverting: Failing on framework tests on the roll https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20run_debug_test_macos/9841/overview
Original PR Author: cbracken
Reviewed By: {jmagman}
This change reverts the following previous change:
This is a refactoring with no semantic changes.
This refactors the macOS framework creation code to be more readable, and extracts it to `sky_utils.py`.
While I was pulling this out, also generalised the code to not hardcode `FlutterMacOS.framework` in case we one day manage to generate the iOS and macOS frameworks with the same name.
This is a reland of flutter/engine#54546 (reverted in flutter/engine#54549 ), the original was reverted in order to revert flutter/engine#54543 (reverted in flutter/engine#54550 ), which was reverted because it failed to preserve symlinks while zipping the macOS framework. That patch has been relanded with a fix in flutter/engine#54555 . This patch has been rebased to tip-of-tree for attempt two.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-15 05:05:27 +00:00
auto-submit[bot]
23885e2486
Reverts "[Impeller] migrate blur tests to display list. ( #54519 )" ( flutter/engine#54564 )
...
Reverts: flutter/engine#54519
Initiated by: jonahwilliams
Reason for reverting: post submit golden issues.
Original PR Author: jonahwilliams
Reviewed By: {chinmaygarde}
This change reverts the following previous change:
Part of DL interop. Currently experiencing some ... issues with blur radius/sigma.
EDIT: was rrect_blur vs gaussian: fixed now.
Part of https://github.com/flutter/flutter/issues/142054
2024-08-15 04:22:28 +00:00
Jonah Williams
cd6fa47e91
[Impeller] migrate blur tests to display list. ( flutter/engine#54519 )
...
Part of DL interop. Currently experiencing some ... issues with blur radius/sigma.
EDIT: was rrect_blur vs gaussian: fixed now.
2024-08-15 03:35:24 +00:00
skia-flutter-autoroll
dfe2e37dfc
Roll Fuchsia Test Scripts from J1EXQ2ozMIQEa6F7H... to -XDS8eBA0Le-zCEfW... ( flutter/engine#54561 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC chrome-fuchsia-engprod@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 22:25:39 +00:00
Chris Bracken
7693bd3e7f
macOS: Refactor create_macos_framework.py ( flutter/engine#54557 )
...
This is a refactoring with no semantic changes.
This refactors the macOS framework creation code to be more readable, and extracts it to `sky_utils.py`.
While I was pulling this out, also generalised the code to not hardcode `FlutterMacOS.framework` in case we one day manage to generate the iOS and macOS frameworks with the same name.
This is a reland of flutter/engine#54546 (reverted in flutter/engine#54549 ), the original was reverted in order to revert flutter/engine#54543 (reverted in flutter/engine#54550 ), which was reverted because it failed to preserve symlinks while zipping the macOS framework. That patch has been relanded with a fix in flutter/engine#54555 . This patch has been rebased to tip-of-tree for attempt two.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-14 22:15:17 +00:00
skia-flutter-autoroll
421e3d0b31
Roll Fuchsia Linux SDK from MeV5i7xXXFPHF5sBK... to qpfC-GAVZvOwAQU5f... ( flutter/engine#54559 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 22:13:24 +00:00
Chris Bracken
385f23c545
macOS: Clean up create_macos_framework.py ( #54543 ) ( flutter/engine#54555 )
...
Over time, this script and others in `sky/tools` have accumulated a lot of additional and sometimes duplicate code.
This is a first pass cleanup of `create_macos_framework.py` to extract common utility code to `sky/utils.py` and refactor for better readability.
The iOS analogue of this patch was flutter/engine#54500 .
This is a reland of flutter/engine#54543 (reverted in flutter/engine#54550 ), which failed to set the `-y` option (preserve symlinks) when zipping `FlutterMacOS.xcframework` but did so for the other zip steps where required. Since there is no case where we *want* to archive dereferenced symlinks, and because it's required for macOS frameworks, we now set this option for all callers in the `sky_tools.create_zip()` function to avoid future cases where someone working on this code misses one. If we ever need it, we can extract a parameter. This patch also references the correct script in its description (the original incorrectly mentioned `create_ios_framework.py`).
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-14 19:55:20 +00:00
Jonny Wang
846176d6db
[fuchsia] Use Fuchsia API 22 ( flutter/engine#54554 )
...
b/359664512
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-14 17:42:32 +01:00
skia-flutter-autoroll
1239fdb0c6
Roll Fuchsia Test Scripts from Kq699Ii76C_pozQ9Y... to J1EXQ2ozMIQEa6F7H... ( flutter/engine#54551 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC chrome-fuchsia-engprod@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 05:55:39 +00:00
auto-submit[bot]
ceb940cdf7
Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) ( #54541 )" ( flutter/engine#54552 )
...
Reverts: flutter/engine#54541
Initiated by: zanderso
Reason for reverting: Analyzer change incorrectly flags unused final field as uninitialized? https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8739656817167901393/+/u/run_test.dart_for_customer_testing_shard_and_subshard_None/stdout
Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/44635f897535..733062367c2e
2024-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-147.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 05:23:17 +00:00
auto-submit[bot]
a8e7013009
Reverts "macOS: Clean up create_ios_framework.py ( #54543 )" ( flutter/engine#54550 )
...
Reverts: flutter/engine#54543
Initiated by: zanderso
Reason for reverting: Failing roll https://github.com/flutter/flutter/pull/153406
Original PR Author: cbracken
Reviewed By: {zanderso}
This change reverts the following previous change:
Over time, this script and others in sky/tools have accumulated a lot of additional and sometimes duplicate code.
This is a first pass cleanup of create_macos_framework.py to extract common utility code to utils.py and refactor for better readability.
The iOS analogue of this patch was flutter/engine#54500 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-14 02:02:47 +00:00
