17030 Commits

Author SHA1 Message Date
Jim Graham
fcaf9c4070 Support for ImageFiltered widget to apply ImageFilter to children. (#47489) 2019-12-21 14:03:01 -08:00
Alexandre Ardhuin
49c7845907
fix analysis (#47594) 2019-12-21 20:53:14 +01:00
Greg Spencer
924efae96c
Add visual density to the gallery options (#46090)
This PR adds an option to the gallery options that sets the visual density to one of "standard" (the default), "comfortable", or "compact".
2019-12-20 20:36:29 -08:00
Lau Ching Jun
ef398d9e87 Disable most screenshot tests for web until we understand the flakes. (#47554) 2019-12-20 18:43:01 -08:00
Jenn Magder
85e9be36bf
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266)" (#47568)
This reverts commit 648a5d8a1ebbe95a6f0fa1c41ed34195c11c4d64.
2019-12-20 17:45:16 -08:00
Shi-Hao Hong
88cd1135bf
Handle plural gen_l10n regular placeholders and DateTime placeholders (#47483)
* Handle simple placeholders in plurals

* Handle Date plural placeholders

* Improve variable names

* Turn assert into exceptions, add tests
2019-12-20 16:22:44 -08:00
engine-flutter-autoroll
0db0299907 Roll engine 854d5f8e9e74..33813929e3cd (10 commits) (#47549)
* 399a29eed Roll src/third_party/dart 141fcfa61092..4681868aaf77 (9 commits) (flutter/engine#14590)

* 97fd705a4 Roll src/third_party/skia 7e2dea568299..dcac29b02d02 (3 commits) (flutter/engine#14591)

* 6d9288740 Roll src/third_party/dart 4681868aaf77..b92fefdfe971 (1 commits) (flutter/engine#14592)

* 4d7313ffc Roll fuchsia/sdk/core/mac-amd64 from f51Q_... to VC7eE... (flutter/engine#14593)

* fac66c28d [web] Long press fix on Safari on IOS (flutter/engine#14588)

* 32eb6e922 Roll src/third_party/skia dcac29b02d02..088913a63b7e (1 commits) (flutter/engine#14597)

* ede1b6b20 Roll fuchsia/sdk/core/linux-amd64 from 25LzW... to TUoVa... (flutter/engine#14596)

* cce5afd48 Roll src/third_party/dart b92fefdfe971..886615d0f95b (2 commits) (flutter/engine#14595)

* 9b299f2c2 fix editable placement in a11y mode (flutter/engine#14581)

* 33813929e [web] implement pushImageFilter (flutter/engine#14599)
2019-12-20 16:12:30 -08:00
Greg Spencer
19b9206add
Add variant testing to testWidgets (#45646)
This adds the ability to define variants of tests with different environmental values for a particular testWidgets test.

This allows you to run the same test multiple times with a different test environment. One test variant has been implemented that allows running a test with different settings of the TargetPlatform.
2019-12-20 15:00:16 -08:00
engine-flutter-autoroll
cb98f7222f Roll engine 472197a8e932..854d5f8e9e74 (20 commits) (#47503)
* bb118c655 Roll src/third_party/dart 8d11c1dce64a..642f8d052fd7 (1 commits) (flutter/engine#14574)

* 09c434d26 Use ELF for Dart AOT snapshots on Fuchsia. (flutter/engine#13896)

* e1e78512a Roll fuchsia/sdk/core/linux-amd64 from VdBKA... to uFFWW... (flutter/engine#14575)

* f317f8f7f Roll src/third_party/skia c76ac8e325c7..77742c350371 (1 commits) (flutter/engine#14576)

* 2ba563336 instructions for running firefox/safari tests (flutter/engine#14562)

* 9cf1e46b9 Roll src/third_party/dart 642f8d052fd7..7113fc79a83c (3 commits) (flutter/engine#14578)

* f5b877af9 [web] Run engine tests on Safari locally by launching safari installed on MacOS (flutter/engine#14555)

* 68d919670 Fix DOM-based ParagraphRuler.hitTest() (flutter/engine#14504)

* bb65df884 Roll src/third_party/skia 77742c350371..a8352ccaae37 (8 commits) (flutter/engine#14579)

* ad1ab564b Roll src/third_party/dart 7113fc79a83c..e50d98cd5651 (8 commits) (flutter/engine#14580)

* 22413efc4 Update formatting in web_ui scene bulder to match flutter style and dartfmt. (flutter/engine#14539)

* 6e825e7bd Roll fuchsia/sdk/core/mac-amd64 from Ykb4b... to f51Q_... (flutter/engine#14584)

* 1d3bb8c27 Fix message_loop_fuchsia and thus enable fml_tests and flow_tests for Fuchsia (flutter/engine#14583)

* 1f7bb9d0c Wire up OpacityLayer to Scenic (flutter/engine#14577)

* 11db035ca Roll src/third_party/skia a8352ccaae37..87e9ddb675b6 (11 commits) (flutter/engine#14585)

* bd58af743 Roll src/third_party/dart e50d98cd5651..141fcfa61092 (3 commits) (flutter/engine#14586)

* 929b1edff Engine support for ImageFiltered widget (flutter/engine#14491)

* 40b84fc19 Fix lint warnings across web_ui, add missing browserEngine case in text field. (flutter/engine#14535)

* ea1d330d8 Roll fuchsia/sdk/core/linux-amd64 from uFFWW... to 25LzW... (flutter/engine#14587)

* 854d5f8e9 Roll src/third_party/skia 87e9ddb675b6..7e2dea568299 (1 commits) (flutter/engine#14589)
2019-12-20 13:33:55 -08:00
gaaclarke
72a3d914ee
Added a code sample for replacing the image cache. (#47467) 2019-12-20 08:50:42 -08:00
Dan Field
93f718b386 Fix requestExistingInputState response (#47472) 2019-12-20 03:33:01 -08:00
Angjie Li
cc1c9649c4 Flutter Web Driver Support (#47470) 2019-12-19 19:53:01 -08:00
Matt Sullivan
f6922d57fc Fixed incorrect offsetting when applying ShaderMasks (#45654) 2019-12-19 19:48:01 -08:00
engine-flutter-autoroll
275a2f133d Roll engine 0f90e6546bf3..472197a8e932 (3 commits) (#47442)
* ffb497de2 Roll src/third_party/skia 9e0afb791ac2..c76ac8e325c7 (4 commits) (flutter/engine#14571)

* da08f4ce2 Roll src/third_party/dart aa6709974dea..8d11c1dce64a (2 commits) (flutter/engine#14572)

* 472197a8e Roll fuchsia/sdk/core/mac-amd64 from NHgyx... to Ykb4b... (flutter/engine#14573)
2019-12-19 18:43:35 -08:00
LongCatIsLooong
e3c8ecaf7f
Reland "Fix sliver geometry assert (#47027)" 2019-12-19 14:27:35 -08:00
Jenn Magder
648a5d8a1e
Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266) 2019-12-19 14:18:10 -08:00
Dan Field
41a911099b comments (#47473) 2019-12-19 13:48:02 -08:00
Gary Qian
b011ea5468
Pass _caretPrototype to prevent cache miss (#46720) 2019-12-20 06:46:49 +09:00
Jonah Williams
3fe6668849
[flutter_tool] ensure extraGenSnapshotArguments are forwarded to gen_snapshot from Android builds (#47059) 2019-12-19 13:44:21 -08:00
Dan Field
4ad8271bf5 Reland text state (#47464) 2019-12-19 13:43:02 -08:00
Janice Collins
bd25f70c66
Upgrade dartdoc to 0.29.3. (#47246) 2019-12-19 09:45:02 -08:00
Justin McCandless
92c21a5701
Fix a typo in the docs (#47391)
Just a docs text change.
2019-12-19 09:40:01 -08:00
Alexandre Ardhuin
78db965642 Reland implicit-casts: false (#47431) 2019-12-19 02:23:01 -08:00
engine-flutter-autoroll
4af66e335f Roll engine 1e1f37107a07..0f90e6546bf3 (14 commits) (#47429)
* 988b8f149 Fix FontLoader does not remove the cache in web engine (flutter/engine#14536)

* 0aacac72d Roll src/third_party/skia 21df075cab00..e6a2ad81ab40 (1 commits) (flutter/engine#14552)

* 417dd7e8e Roll fuchsia/sdk/core/mac-amd64 from esDH2... to NHgyx... (flutter/engine#14554)

* f2e841d50 [Web] Fix pointer binding  (flutter/engine#14378)

* 105eb66b9 Roll src/third_party/skia e6a2ad81ab40..8fec4140f614 (17 commits) (flutter/engine#14557)

* 1ecfdcb94 [web] Calculate align offset for each paragraph line (LineMetrics.left) (flutter/engine#14537)

* dda3619aa Roll src/third_party/dart 270966b16044..171059d27689 (19 commits) (flutter/engine#14558)

* 9c1bd8aee Fixes Objective-C objects memory leaks (flutter/engine#14326)

* f2dbeb8aa Reland Wire up Opacity on Fuchsia (flutter/engine#14559)

* 2f536e537 Roll fuchsia/sdk/core/linux-amd64 from jsuQq... to VdBKA... (flutter/engine#14560)

* 4312d37eb Revert "[fuchsia] Add diagnostics directory to the set of remote dirs (#14470)" (flutter/engine#14566)

* 5c77ea149 Roll src/third_party/skia 8fec4140f614..9e0afb791ac2 (4 commits) (flutter/engine#14563)

* a09ff7c42 Roll src/third_party/dart 171059d27689..aa6709974dea (11 commits) (flutter/engine#14567)

* 0f90e6546 Revert "[web] Calculate align offset for each paragraph line (LineMetrics.left) (#14537)" (flutter/engine#14569)
2019-12-19 00:53:27 -08:00
Lau Ching Jun
a4858782da
Revert "implicit-casts: false (#47199)" (#47428)
This reverts commit c235998acf17206c6ce411af235faf439d9ff7b2.
2019-12-18 23:53:00 -08:00
Alexandre Ardhuin
c235998acf implicit-casts: false (#47199) 2019-12-18 23:23:01 -08:00
engine-flutter-autoroll
2b4b6eef5d Roll engine 866b158c4b13..1e1f37107a07 (3 commits) (#47374)
* fa1adf4f2 Roll src/third_party/dart c9d89d55a60e..6fcd1de98c2c (8 commits) (flutter/engine#14551)

* 6ea69a0d4 Revert "Wire up Opacity on Fuchsia, round 2 (#14024)" (flutter/engine#14543)

* 1e1f37107 Roll src/third_party/dart 6fcd1de98c2c..270966b16044 (7 commits) (flutter/engine#14553)
2019-12-18 20:52:07 -08:00
Dan Field
0a9ff388bf Revert "Use platform appropriate filepaths" (#47395) 2019-12-18 18:08:02 -08:00
Lau Ching Jun
d51956a9ea
Revert "Call setEditingState when text changes. (#47177)" (#47397)
This reverts commit d4b49ce9fc47885b1f634aad6b124a48917a81dc.
2019-12-18 18:03:24 -08:00
Lau Ching Jun
2df964581f
Revert "Flutter Web Driver Support (#45951)" (#47389)
This reverts commit 1ef0eadb45835dc438fe0120521c01c8b055b41e.
2019-12-18 17:02:31 -08:00
Lau Ching Jun
f32dee6e30
Revert "Fix sliver geometry assert (#47027)" (#47390)
This reverts commit 117dfaf2871908d55f73e390c6a3ce4b70010fc8.
2019-12-18 17:02:11 -08:00
Kate Lovett
c281369356 Fix subdirectory output (#47256) 2019-12-18 16:33:01 -08:00
Gary Qian
f05ab50370
Detect and dump flaky LineMetrics test data (#46213) 2019-12-19 09:28:02 +09:00
Jenn Magder
9184f4d6fb
Build iOS frameworks with relative output path (#47369) 2019-12-18 15:31:54 -08:00
Michael Goderbauer
beb86d2cc4 Revert "Simplify Chip slightly (#47254)" (#47353) 2019-12-18 14:03:01 -08:00
Dan Field
b23238890a Pipe through test-randomize-ordering-seed (#47243) 2019-12-18 13:58:01 -08:00
KalilDev
b39ebcb55f Fix CupertinoContextMenuAction color behavior (#47151)
"destructive" color wasn't working for ContextMenuAction, this PR fixes it.
2019-12-18 13:57:40 -08:00
Lau Ching Jun
bc67d22449
Revert "iOS UITextInput autocorrection prompt (#45354)" (#47373)
This reverts commit 0f8c0da0a9ded2a9b7aa3bd01fcc29db80bbab0a.
2019-12-18 13:56:44 -08:00
Shi-Hao Hong
bde351eea2
Make AlertDialog scrollable through AlertDialog.scrollable parameter (#45079)
* Add AlertDialog.scrollable

* Add deprecation notice

* Ignore deprecation warning in dialog.dart with TODO
2019-12-18 12:31:16 -08:00
Lau Ching Jun
7850e2525f
Is executable doesn't mean a+x (#47359) 2019-12-18 12:21:46 -08:00
engine-flutter-autoroll
1967a36e80 Roll engine c327cae7ab5e..866b158c4b13 (2 commits) (#47362)
* f1b0b82e2 Roll src/third_party/skia 37a88b43637e..21df075cab00 (2 commits) (flutter/engine#14549)

* 866b158c4 Roll fuchsia/sdk/core/linux-amd64 from WSlsF... to jsuQq... (flutter/engine#14550)
2019-12-18 10:57:41 -08:00
Angjie Li
1ef0eadb45 Flutter Web Driver Support (#45951)
* Support Flutter Driver test for Flutter Web application.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation issues.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation.

* Remove unused file from dartdoc check.

* Sync to date.

* Revert change to dartdoc.

* Address comments.

* Apply suggestions from code review

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* Update copyrights.

* Update allowed list for browsers.

* Verify command line arguments for Drive command is correctly parsed.

* Make waitUntilFirstFrameRasterized throw unimplementedError for Flutter Web Driver.

* Add comment for why sync WebDriver is used.

* Update documentations.

* Add more unit tests and update documentation.

* Configure test.dart so that web_extension_test will be executed with --platform=chrome.

* Revert unnecessary changes.

* Add new file path for Windows to blacklist.

* Reconstruct the structure of flutter_driver/test/src folder to remove filtering logic in dev/bots/test.dart/

* Fix path to web_extension_test.dart.

* Add instructions for how to use WebFlutterDriver.

* Update getLayerTree to use sendCommand instead of _sendCommand.

* Update pubspec files.
2019-12-18 10:45:39 -08:00
Alex Vincent
f546aa7def Fix buildCounter returns a widget when set to return null. (#45749)
When buildCounter returns null it no longer produces a widget that takes up space.
2019-12-18 10:45:28 -08:00
Zachary Anderson
d328e0cea0 [flutter_tool] Improve iOS mDNS failure error message (#47348) 2019-12-18 09:23:00 -08:00
engine-flutter-autoroll
54fa1a5a69 Roll engine 500f9cedf652..c327cae7ab5e (9 commits) (#47323)
* ee92285ab Roll src/third_party/skia fdb2b7d53038..cbeabd969bbe (1 commits) (flutter/engine#14530)

* 9b369ad19 Rename 'test_vsync_waiters' to 'vsync_waiters_test' for consistency. (flutter/engine#14519)

* 0f97a1e83 Roll src/third_party/skia cbeabd969bbe..3794db84e141 (8 commits) (flutter/engine#14532)

* ac42640fd Roll src/third_party/dart f10fa3df28a8..44da51fc720d (20 commits) (flutter/engine#14533)

* c216ba42b Calling onConnectionClosed when the input element is blurred (flutter/engine#14484)

* 44f075779 Manual roll of Dart to revision 8a4cac1ddb141d4a1e395f6e0a7d5bbf2247eb63 (flutter/engine#14542)

* 995c4a786 Roll src/third_party/dart 8a4cac1ddb14..b6e051e2c87a (2 commits) (flutter/engine#14545)

* c5683085d Roll src/third_party/skia 190b82d67ce1..37a88b43637e (1 commits) (flutter/engine#14546)

* c327cae7a Revert "Fix off-by-one fromRGBO alpha value calculation (#13777)" (flutter/engine#14548)
2019-12-18 08:47:31 -08:00
Scott Hyndman
ceef460a64 Correct name in DecorationImage error string (#47260) 2019-12-18 00:23:02 -08:00
Emmanuel Garcia
9884f9980f Change meaning of a plugin not supporting the android platform (#47015) 2019-12-17 19:48:01 -08:00
engine-flutter-autoroll
b3e14cc664 Roll engine bdd4e4d9488e..500f9cedf652 (34 commits) (#47223)
* c2600574f Roll src/third_party/dart fe9f30c3896e..8ad8abfb7463 (19 commits) (flutter/engine#14480)

* 47c1dde9c Roll src/third_party/skia d0840ecf5831..ea47b0e65802 (9 commits) (flutter/engine#14481)

* 35adf37ce [web] Implement Paragraph.getLineBoundary (flutter/engine#14479)

* 00cbfd3f7 [web] Remove Paragraph._lines which isn't necessary anymore (flutter/engine#14485)

* d6172fdcf libtxt: cache fallback fonts found by a Minikin font collection (flutter/engine#14482)

* 19124783c adding firefox unit tests to font loading (flutter/engine#14487)

* 6c71f89fb Introduce an auto-deletable SkiaObject; make SkPaint a SkiaObject (flutter/engine#14486)

* 2026b83d7 Roll src/third_party/dart 8ad8abfb7463..83eeab1e63d9 (13 commits) (flutter/engine#14488)

* b43d3fe38 Roll src/third_party/skia ea47b0e65802..cd9ad409a90d (7 commits) (flutter/engine#14490)

* 3c85b828e Roll fuchsia/sdk/core/linux-amd64 from QZVxo... to q0tup... (flutter/engine#14494)

* 3e3eb9c0a Roll src/third_party/dart 83eeab1e63d9..6c99171686be (5 commits) (flutter/engine#14492)

* cbe0e6c1e Roll src/third_party/skia cd9ad409a90d..cf0e3c63fd22 (1 commits) (flutter/engine#14495)

* a653bd8b4 Roll fuchsia/sdk/core/mac-amd64 from 5t09i... to esDH2... (flutter/engine#14493)

* 17d8882a7 Roll src/third_party/dart 6c99171686be..09a0b040dd9b (1 commits) (flutter/engine#14497)

* be9c7c9f6 Roll src/third_party/skia cf0e3c63fd22..9e7199561fc8 (1 commits) (flutter/engine#14499)

* c504b8fab Roll src/third_party/skia 9e7199561fc8..ef363a9ce692 (1 commits) (flutter/engine#14500)

* cf20f87b7 Roll src/third_party/dart 09a0b040dd9b..ae3973da4023 (1 commits) (flutter/engine#14501)

* bb3166bce Roll src/third_party/dart ae3973da4023..24b99838f433 (3 commits) (flutter/engine#14502)

* 87c1110df Roll src/third_party/skia ef363a9ce692..187cd367d388 (1 commits) (flutter/engine#14503)

* 45c6c3a5d Roll src/third_party/skia 187cd367d388..706eb5788e8b (1 commits) (flutter/engine#14505)

* d2923801b Fix comments of iOS status bar height constant (flutter/engine#14496)

* 1ed724718 Roll src/third_party/dart 24b99838f433..2e1dd98e5e7f (1 commits) (flutter/engine#14507)

* 871246172 Allow custom embedders to post low memory notifications. (flutter/engine#14506)

* 1d1eae2ed Roll fuchsia/sdk/core/linux-amd64 from q0tup... to O6ELR... (flutter/engine#14512)

* 8b478862d Roll src/third_party/dart c5c469088697..44ba80053396 (1 commits) (flutter/engine#14510)

* ca799fa8b Roll src/third_party/skia 706eb5788e8b..9b59953e77b9 (3 commits) (flutter/engine#14511)

* 84564111f Roll src/third_party/dart 44ba80053396..2eba06d26f71 (32 commits) (flutter/engine#14515)

* 46d76eb8e Roll src/third_party/skia 9b59953e77b9..d78a9b45b9e5 (23 commits) (flutter/engine#14516)

* 5f9e558a9 Forward low memory notifications from the shell to DartVM. (flutter/engine#14517)

* dc597584e Apply SmoothPointerDataDispatcher to Fuchsia (flutter/engine#14514)

* 9556f2c82 Roll src/third_party/dart 2eba06d26f71..b1afe2d0ebc1 (6 commits) (flutter/engine#14523)

* e829384a2 Roll fuchsia/sdk/core/linux-amd64 from O6ELR... to ZHhOi... (flutter/engine#14525)

* 0fbdeb8d2 Roll src/third_party/dart b1afe2d0ebc1..2d332ee1d3f1 (1 commits) (flutter/engine#14526)

* 500f9cedf Roll src/third_party/skia 6153165d78f2..fdb2b7d53038 (2 commits) (flutter/engine#14528)
2019-12-17 19:46:09 -08:00
Shouichi Kamiya
0764548231 s/v-sync/Vsync/g (#46660) 2019-12-17 19:43:03 -08:00
神楽坂花火
0ec73510ec Add textScaleFactor to SelectableText (#44682) 2019-12-17 19:38:01 -08:00