This attempts to re-land #22656.
There are two changes from the original:
I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text.
I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences.
As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor.
* Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
Since wrapping is now turned on, also removed many redundant '\n's in the code.
We decided that redefining the default for templates was premature. We're going to go back to having "module" in experimental land again, and we'll try again when we have the feature set fully baked.
This keeps the writing of the .metadata files, and writing the template type to them, because that was a good improvement, and there are still a bunch of added tests that improve our coverage.
* Allow passing a restart reason through to analytics
* Update to avoid overlaps with other code
* Remove TODO as this is the real live value
* Improve formatting + constant name
Reverts flutter/flutter#22837
Try to fix application_test
* Revert "Add a profile build type to the app template (#22837)"
This reverts commit 3b248fdc111d1b25014ed723ac4a0bc4225f6461.
572fa5646a...88facf4054
git log 572fa5646af7..88facf405434 --no-merges --oneline
88facf405 Roll src/third_party/skia 8ad991da4c04..00de965d0d31 (6 commits) (flutter/engine#6467)
647302a28 Correct issues in visible children determination (flutter/engine#6455)
0052733e5 Roll src/third_party/skia 95320ee01f5b..8ad991da4c04 (1 commits) (flutter/engine#6465)
7decce221 Roll src/third_party/skia 9aa3f9095622..95320ee01f5b (1 commits) (flutter/engine#6463)
2667780b9 Roll src/third_party/skia beb1559bc61f..9aa3f9095622 (1 commits) (flutter/engine#6462)
5d28dce5e Roll src/third_party/skia e9b61ef5aa34..beb1559bc61f (1 commits) (flutter/engine#6460)
54b709d3a Roll src/third_party/skia 71143d6cc039..e9b61ef5aa34 (1 commits) (flutter/engine#6459)
9fc5013eb Roll src/third_party/skia 623d2e4120c2..71143d6cc039 (1 commits) (flutter/engine#6458)
841454c8d Roll src/third_party/skia 29b11d605f25..623d2e4120c2 (1 commits) (flutter/engine#6457)
5331df8e4 Roll src/third_party/skia d037f4d204c2..29b11d605f25 (1 commits) (flutter/engine#6456)
6d4de7fc8 Roll src/third_party/skia 51c89e41c05b..d037f4d204c2 (9 commits) (flutter/engine#6454)
ba9b90766 Add `run_tests.sh` to cirrus (flutter/engine#6441)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
* Refactor AnimatedSwitcher
This is mostly just a little bit of cleanup with hopefully no semantic
changes, done to teach me how the code works so that I could fix a bug.
* Add debugging information to AnimatedSwitcher
* Fix AnimatedSwitcher to handle the case of back-to-back changes
Previously, if a child was replaced the very next frame after it was
added, we'd get confused because we tried to reverse the controller,
which causes us to remove the child from the going-away list, before
we had added the child to the list in the first place.
The fix is just to move the reverse to after the add.
Adds a Fuchsia compatibility function that allows for connecting to a
specific Isolate by name when running Flutter Driver on a Fuchsia
device. This will check over multiple Dart VM's in an attempt to find
an Isolate by its name.
* Adds comments clarifying the procedure used to render the menu as well as tests verifying various dropdown menu button positioning and initial scroll states.
Fixes a gradle error where it was failing to find a plugin because of an absolute path in the .flutter-plugins file instead of a relative path.
I had originally removed this variable because I thought it was redundant with the projectDir, but apparently I was wrong about that (one resolves to a relative path, and one resolves to an absolute path).
This PR reverts that part of the change and reintroduces the (not really) redundant variable.
A few changes:
* Remove the search tip (it relies on searching for the new keyword which we no longer use)
* Remove mentioning of examples that are either stale or only used for internal purposes (such as test)
* Cross-link to the samples repo
This reverts commit e438632165818fb06b7c58ea846fe781d9d17642
because it breaks 160 benchmarks, and several devicelab tests,
due to changing the format of the output.
This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
Since wrapping is now turned on, also removed many redundant '\n's in the code.
