31971 Commits

Author SHA1 Message Date
Naud Ghebre
1725a26e29
Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114834) 2022-11-08 17:54:18 +00:00
Zachary Anderson
a84e369bd2
Revert "Allow Flutter golden file tests to be flaky (#114450)" (#114902)
This reverts commit 53e6876226a7729531be7be4fa7321363c5a3b30.
2022-11-08 09:26:55 -08:00
Kate Lovett
a1432a9c5d
Refactor fix_data.yaml (#114192)
* Refactor fix_data.yaml

* ++

* lib, not lib/src

* Nit

* Nit

* Update packages/flutter/test_fixes/material/app_bar_theme.dart

Co-authored-by: Alexander Dahlberg <dustbin4ever@gmail.com>

* Fix copy paste errors

Co-authored-by: Alexander Dahlberg <dustbin4ever@gmail.com>
2022-11-08 01:17:03 +00:00
Kate Lovett
53e6876226
Allow Flutter golden file tests to be flaky (#114450)
* allow marking a golden check as flaky

* add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib

* Pause

* ++

* ++

* Analyzer therapy

* Once more with feeling

* Nits

* Review feedback

* Silly oops

* Test progress

* More tests

* Finish

* Nits

* Analyzer

* Review feedback

Co-authored-by: Yegor Jbanov <yjbanov@google.com>
2022-11-08 01:14:03 +00:00
engine-flutter-autoroll
139b8f458d
Roll Flutter Engine from 004a305166d5 to e7d7edab98ad (2 revisions) (#114855)
* 55ed37fb4 Roll Skia from dec7a930c0b7 to aef6d301c0b5 (4 revisions) (flutter/engine#37393)

* e7d7edab9 clang-tidy: Added an environment variable that allows fix to print the (flutter/engine#37024)
2022-11-08 00:51:14 +00:00
engine-flutter-autoroll
2e85e745d7
004a30516 [fuchsia] embedding-flutter test (flutter/engine#37052) (#114854) 2022-11-07 23:55:24 +00:00
Greg Spencer
1ca2e0b5b2
Fix CastError in StadiumBorder.lerpTo and StadiumBorder.lerpFrom when using BorderRadiusDirectional (#114826)
* Fix casting in StadiumBorder lerp

* Add tests

* Fix made-up names
2022-11-07 23:29:52 +00:00
engine-flutter-autoroll
585d4457d1
Roll Flutter Engine from a81a715ce6b2 to df602070ac4b (3 revisions) (#114847)
* 3d9f48580 [Embedder API] Introduce new semantics update callback (flutter/engine#37129)

* b673ce3c3 Roll Skia from da9fad017aee to dec7a930c0b7 (10 revisions) (flutter/engine#37390)

* df602070a [Web] Synthesize modifiers key up based on known logical key (flutter/engine#37280)
2022-11-07 22:52:18 +00:00
engine-flutter-autoroll
7640f315db
a81a715ce Revert "Remove deprecated calls to updateSemantics in PlatformDispatcher (#36673)" (flutter/engine#37388) (#114842) 2022-11-07 21:27:37 +00:00
Jonah Williams
e4e902dced
[flutter_tools] add compilation failure tests for new cases added in impellerc (#114757) 2022-11-07 20:59:13 +00:00
Bruno Leroux
f1cdfa289d
Use AppBar.systemOverlayStyle to style system navigation bar (#104827)
* Use upper AnnotatedRegion properties when no bottom one found (and vice versa)

* Update comments

Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2022-11-07 20:42:56 +00:00
Bruno Leroux
5628ebf662
[RawKeyboard] Allow inconsistent modifiers for Web (#114499)
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2022-11-07 20:41:09 +00:00
engine-flutter-autoroll
fe5eb2db75
ee48c0392 Roll Fuchsia Mac SDK from 5XOj9l5e2wkSpMKT1... to sa5bVGimNo3JwLV27... (flutter/engine#37386) (#114836) 2022-11-07 20:16:22 +00:00
Pedro Massango
e1adc96d5e
feat: provide a way to set the initial child's alignment (#114745)
InteractiveViewer.alignment parameter
2022-11-07 12:08:22 -08:00
Justin McCandless
3cde69e8d9
Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)
Relands the "Scribble mixin" PR, which was reverted due to breaking a Google test in the last roll.
Breaks the Scribble feature out of TextInputClient in order to avoid breaking changes.
2022-11-07 11:28:27 -08:00
engine-flutter-autoroll
e901832333
4e03d059d [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) (#114833) 2022-11-07 19:27:07 +00:00
Victoria Ashworth
378387b139
when getting xcworkspace, exclude hidden files (#114099)
* exclude xcworkspace that begins with a period

* fix if spacing, add comment

* add unit test for when no xcworkspace found

* update to use xcodeWorkspace, make it nullable and refactor

* check if hostAppRoot exists before trying to get xcworkspace

* use local variables to take advantage of type promotion

* only check if not null, don't need to check if exists

* readd exist check for migrate

* readd missing line at end of file
2022-11-07 18:48:52 +00:00
engine-flutter-autoroll
77c06c2ca4
0075e10bc Move gclient var property to ci.yaml (flutter/engine#37351) (#114828) 2022-11-07 18:48:49 +00:00
Justin McCandless
7e36cf17e7
Mac Page Up / Page Down in text fields (#105497)
Adds support for Mac/iOS's behavior of scrolling (but not moving the cursor) when using page up/down in a text field.
2022-11-07 10:43:09 -08:00
陈昱
497a52809d
Fix TextField/CupertinoTextField hint style overflow not work. (#114335)
* fix text field hint style overflow not work, keep default ellipsis.

* fix cupertino text field hint style overflow not work, keep default ellipsis.

* add Cupertino placeholder style test.
2022-11-07 17:45:56 +00:00
Jason Simmons
496cf627e6
Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (#114733)
This restores the updateSemantics capability in TestWindow that had been
removed in https://github.com/flutter/flutter/pull/113382
2022-11-07 17:27:50 +00:00
engine-flutter-autoroll
7de60bbce8
334549704 Roll buildroot to d13d64086f5e301bd0415eede895b34af220ef42 (flutter/engine#37380) (#114821) 2022-11-07 17:21:18 +00:00
Hans Muller
d6a8e92cd6
Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (#114819)
This reverts commit a6da1042a819f7a93eb655d493db914561f93f83.
2022-11-07 08:50:56 -08:00
engine-flutter-autoroll
151c83191a
92d9ad27f Roll Skia from 513f0fd34590 to da9fad017aee (2 revisions) (flutter/engine#37379) (#114816) 2022-11-07 16:33:11 +00:00
engine-flutter-autoroll
04d6fd2a0d
Roll Plugins from a279b9dd839a to 3ca34103db0f (4 revisions) (#114813)
* 3ec3cc1e2 Add `Mac_x64 darwin_lint_podspecs` to LUCI (flutter/plugins#6637)

* 0e5e90f6c [webview_flutter] Fix typo (flutter/plugins#6650)

* f04ef7309 Roll Flutter from 55e8cd178621 to e0e7027b6263 (20 revisions) (flutter/plugins#6673)

* 3ca34103d Roll Flutter from e0e7027b6263 to 5ea5a5330169 (7 revisions) (flutter/plugins#6675)
2022-11-07 15:46:26 +00:00
engine-flutter-autoroll
a1289a4135
891d4a357 Roll Skia from c3c31be8729b to 513f0fd34590 (2 revisions) (flutter/engine#37377) (#114802) 2022-11-07 11:46:25 +00:00
Chris Bracken
3c9288c6d3
Increase minimum supported macOS version from 10.13 to 10.14 (#114713)
Increases the minimum macOS deployment target from macOS 10.13 (High Sierra) to 10.14 (Mojave) in the macOS app templates.

Includes:
* Update migration for macOS 10.11 apps to upgrade to 10.14
* Adds migration for macOS 10.13 apps to upgrade to 10.14
* Apply migration to all examples, and integration tests

This does not increase version in the plugin templates since those will need to wait until the 10.14 framework rolls to stable channel, so new plugins can build with apps created with `flutter create` on stable channel.

Issue: https://github.com/flutter/flutter/issues/114445
See RFC: http://flutter.dev/go/flutter-drop-macOS-10.13-2022-q4
See previous patch: https://github.com/flutter/flutter/pull/107689
2022-11-07 11:32:42 +01:00
engine-flutter-autoroll
a54a46df40
6b57fddd1 Bump github/codeql-action from 2.1.29 to 2.1.31 (flutter/engine#37374) (#114798) 2022-11-07 10:31:23 +00:00
engine-flutter-autoroll
c551fe3de1
4e45cfb4a Roll Fuchsia Mac SDK from 9Jb1-3tRPQ2ZhpTQC... to 5XOj9l5e2wkSpMKT1... (flutter/engine#37369) (#114789) 2022-11-07 06:32:24 +00:00
engine-flutter-autoroll
19c5fc50d9
0cbdf464c Add Matrix::LookAt (flutter/engine#37361) (#114786) 2022-11-07 04:09:10 +00:00
Hans Muller
a6da1042a8
Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560) 2022-11-06 17:21:08 -08:00
engine-flutter-autoroll
5280135882
ecd3c4857 Roll Fuchsia Mac SDK from sNXsQVxntMX8f42LE... to 9Jb1-3tRPQ2ZhpTQC... (flutter/engine#37363) (#114772) 2022-11-06 17:24:25 +00:00
engine-flutter-autoroll
5ea5a53301
6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (#114765) 2022-11-06 13:05:25 +00:00
engine-flutter-autoroll
b45e628595
b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (#114760) 2022-11-06 02:37:37 +00:00
engine-flutter-autoroll
b1509ed64f
36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (#114759) 2022-11-06 01:53:24 +00:00
Chris Bracken
5bc50c136b
Fix macOS migration nothing-to-upgrade test (#114703)
When testing whether a macOS deployment target version migration is
unnecessary due to already being at the target version, we were
previously checking the iOS deployment target version rather than the
macOS version. This updates it to test MACOSX_DEPLOYMENT_TARGET instead.
2022-11-05 17:02:46 -07:00
Chris Bracken
cf0cd067a0
Mark new_gallery__transition_perf as non-flaky (#114694)
These were marked flaky due to a timeout switching between items in the
Studies list at the top of the screen, which had snap-to-item scroll
physics.

The same flake also affected new_gallery_impeller__transition_perf which
was failing with the same flake, though was separately marked flaky due
to a separate (engine crash) flake documented in:
* https://github.com/flutter/flutter/issues/112577
* https://github.com/flutter/flutter/issues/112438

Leaving the latter marked flaky for the time being while that separate
issue is investigated.

Issue: https://github.com/flutter/flutter/issues/114025
2022-11-05 17:02:38 -07:00
engine-flutter-autoroll
07d3a64b5d
0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (#114751) 2022-11-05 18:23:24 +00:00
Tae Hyung Kim
cef4c2aac8
ICU Message Syntax Parser (#112390)
* init

* code generation

* improve syntax error, add tests

* add tests and fix bugs

* code generation fix

* fix all tests :)

* fix bug

* init

* fix all code gen issues

* FIXED ALL TESTS :D

* add license

* remove trailing spaces

* remove print

* tests fix

* specify type annotation

* fix test

* lint

* fix todos

* fix subclass issues

* final fix; flutter gallery runs

* escaping for later pr

* fix comment

* address PR comments

* more

* more descriptive errors

* last fixes
2022-11-05 10:26:46 -07:00
engine-flutter-autoroll
e0e7027b62
9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (#114746) 2022-11-05 11:02:24 +00:00
engine-flutter-autoroll
06ded49f7a
Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (#114735)
* b74471702 Roll Fuchsia Linux SDK from 7e3H7isxOF6vqMDTT... to mDzQK4ZUk_Y4wfZa_... (flutter/engine#37337)

* 2af329fa2 Roll Skia from 7a98accb20d5 to a34882309d04 (7 revisions) (flutter/engine#37334)

* cf56eb556 32 cores (flutter/engine#37339)
2022-11-05 03:30:55 +00:00
engine-flutter-autoroll
140a57e960
Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (#114732)
* aeae6afb7 Roll Dart SDK from b2aad7caafc9 to d97d5ad98893 (1 revision) (flutter/engine#37333)

* 396be860f [Impeller] Remove cached pipelines when RuntimeStage is hot reloaded (flutter/engine#37307)

* 223a485ce Handle include paths the same way as output paths (flutter/engine#37335)
2022-11-05 02:44:21 +00:00
engine-flutter-autoroll
6265610b05
Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (#114728)
* 24c3a9f51 fix recursive self calls (flutter/engine#37321)

* 2a1be6d4d Roll Skia from dc49f35e1ac6 to 7a98accb20d5 (6 revisions) (flutter/engine#37328)

* ba390f2a7 [web] Unify JS configuration. Make it available from initEngine. (flutter/engine#37187)
2022-11-05 01:50:38 +00:00
xubaolin
1aada6fc5c
[New Feature]Support mouse wheel event on the scrollbar widget (#109659)
* rebase master and add a test

* fix the test

* fix the test

* fix the test
2022-11-05 00:57:52 +00:00
engine-flutter-autoroll
96f9ca8302
Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (#114720)
* d413cc511 Add unreachable for vulkan switches (flutter/engine#37324)

* e32bff47e Copy Windows gen_snapshot to a standard location (flutter/engine#37318)

* af1a2da13 Increase Win32 trackpad polling rate, fix repeated swipes issue (flutter/engine#37154)

* 28e1ea0cc Roll Fuchsia Mac SDK from JKfnEvEVIL_Cg3_9f... to jAKH68TYoKUA5HNS2... (flutter/engine#37325)
2022-11-05 00:11:49 +00:00
godofredoc
4fd0a92532
Remove auto_cleanup of xcode caches. (#114719)
After all the caches have been cleaned and the logic to cleanup runtimes
has landed we may not need to always delete the caches.

Bug: https://github.com/flutter/flutter/issues/114656
2022-11-05 00:08:15 +00:00
engine-flutter-autoroll
d68af26ae3
Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (#114714)
* cf22fc23f Revert "reland "Migrate darwin common "framework_shared" target to ARC #37049" (#37219)" (flutter/engine#37320)

* 3c5712bef Roll Dart SDK from 35b0cc8ac48b to b2aad7caafc9 (1 revision) (flutter/engine#37322)

* 0933ca485 Revert "Roll Clang from a93d03310e2c to bca75abc01f3 (#37076)" (flutter/engine#37323)
2022-11-04 22:30:01 +00:00
Flutter GitHub Bot
91a56cf15f
roll packages (#114366) 2022-11-04 22:27:56 +00:00
Chris Bracken
01507bab56
Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (#114715)
Causes analysis errors:

```
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:513:5 • always_specify_types
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:514:10 • always_specify_types
   info • Avoid method calls or property accesses on a "dynamic" target • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:515:11 • avoid_dynamic_calls
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:515:48 • always_specify_types
   info • Separate the control structure expression from its statement • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:515:77 • always_put_control_body_on_new_line
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:516:7 • always_specify_types
   info • Avoid method calls or property accesses on a "dynamic" target • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:518:11 • avoid_dynamic_calls
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:518:51 • always_specify_types
   info • Separate the control structure expression from its statement • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:518:77 • always_put_control_body_on_new_line
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:519:7 • always_specify_types
   info • Avoid method calls or property accesses on a "dynamic" target • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:521:11 • avoid_dynamic_calls
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:522:21 • always_specify_types
   info • Separate the control structure expression from its statement • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:522:58 • always_put_control_body_on_new_line
  error • The argument type 'dynamic' can't be assigned to the parameter type 'String' • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:524:38 • argument_type_not_assignable
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:540:5 • always_specify_types
   info • Avoid escaping inner quotes by converting surrounding quotes • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:541:14 • avoid_escaping_inner_quotes
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:542:5 • always_specify_types
  error • The argument type 'dynamic' can't be assigned to the parameter type 'List<dynamic>' • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:544:45 • argument_type_not_assignable
   info • Remove unnecessary backslashes in strings • packages/fuchsia_remote_debug_protocol/test/fuchsia_remote_connection_test.dart:114:55 • unnecessary_string_escapes
   info • Remove unnecessary backslashes in strings • packages/fuchsia_remote_debug_protocol/test/fuchsia_remote_connection_test.dart:204:55 • unnecessary_string_escapes
   info • Remove unnecessary backslashes in strings • packages/fuchsia_remote_debug_protocol/test/fuchsia_remote_connection_test.dart:289:55 • unnecessary_string_escapes
```

This reverts commit b187bc474e93aa9b0d58cd194b8d67b2bdf5eeec.
2022-11-04 14:00:16 -07:00
Naud Ghebre
b187bc474e
Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)
* [fuchsia_remote_debug_protocol] Switch the way we retrieve the vm_service_port from /hub to iquery, on device.

* [fuchsia_remote_debug_protocol] Switch the way we retrieve the vm_service_port from /hub to iquery, on device.
2022-11-04 16:39:53 -04:00