hangyu
1aba3a66f5
[GAR] [a11y] Update text button page in a11y assessment app ( #148905 )
...
internal: b/317125569
If the text button label contains its role and state, it will be confusing for tester.
it will be announced like "xxx button button" :
<img src="https://github.com/flutter/flutter/assets/108393416/16f5a996-b0f1-4f04-bd99-caa3cacd4182 " width=50% height=50%>
updated screen and label:
<img src="https://github.com/flutter/flutter/assets/108393416/1de55cec-8a18-4c36-9dac-84ae7d151fd6 " width=50% height=50%>
2024-05-30 18:34:07 +00:00
Mitchell Goodwin
54573bc875
Have Material widgets in a Cupertino App partially use Cupertino theme ( #139253 )
...
Fixes #138621
Fixes and issue where if a Material widget is used in a Cupertino App, then some parts of it's default Material 3 theming would show up as purplish. This could be fixed by wrapping your app with a Material theme, but that's a little awkward.
Material and Cupertino themes interact with each other a little oddly. If a theme of either is searched for but does not exist, then a default one is generated. So if a Material widget is in a Cupertino app that does not already have a Material theme, then a fallback Material theme will be created. This PR makes it so that, in this case when that Material theme is created, it's default colors will be based on the Cupertino theme.
Another oddity is that a Material theme always wraps itself with a Cupertino theme that's values are based on the Material theme. So before this change, a Material widget would theoretically add a new Material based Cupertino theme to the tree. So I added logic that would have the Material theme check to see if a Cupertino theme exists, before it overwrites it.
Before:
After:
<img width="386" alt="Screenshot 2023-11-29 at 10 37 09â¯AM" src="https://github.com/flutter/flutter/assets/58190796/959ccfd9-3439-438e-ad36-20597334837a ">
Update:
I changed it to not rely on the Material 3 flag. Instead, if a Material theme is searched for and there is already a Cupertino theme in the tree, then it will use that Cupertino theme instead of generating a new. Also, if a Material theme is searched for, and it does not find one already in the tree, but does find a Cupertino theme, then it will generate one with a color palette based off of that Cupertino theme's colors.
After with this change:
<img width="390" alt="Screenshot 2024-05-09 at 10 16 22â¯AM" src="https://github.com/flutter/flutter/assets/58190796/79765d04-a7a3-4eb5-9477-11668ed138e5 ">
We should still probably suggest for developers to include a Material theme in their Cupertino app if they wish to use widgets from both packages.
2024-05-30 17:54:53 +00:00
Nate
ee3557afe0
Refactor Material build method ( #147430 )
...
Only a code quality change, improves readability using `switch`.
2024-05-30 10:54:17 -07:00
MajdSallora
df95cb2984
Add locale in DatePickerThemeData ( #148292 )
...
*This PR changes the date picker were add locale in DatePickerThemeData*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Fixes #148202
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-05-30 17:53:03 +00:00
auto-submit[bot]
3d4fd550c2
Reverts "Enable explicitChildNodes for the AlertDialog content ( #149130 )" ( #149333 )
...
Reverts: flutter/flutter#149130
Initiated by: Piinks
Reason for reverting: Google testing did not run on this PR and multiple semantics screen shots from internal testing look incorrect.
Original PR Author: TahaTesser
Reviewed By: {goderbauer}
This change reverts the following previous change:
fixes [AlertDialog content semantics merged](https://github.com/flutter/flutter/issues/147574 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
// showSemanticsDebugger: true,
home: Scaffold(
body: SafeArea(
child: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
const Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text('Some text'),
Text('More text'),
],
),
Builder(builder: (BuildContext context) {
return ElevatedButton(
onPressed: () {
showDialog<void>(
context: context,
builder: (BuildContext context) {
return AlertDialog(
title: const Text('Dialog Title'),
content: const Column(
children: <Widget>[
Text('Some text'),
Text('More text'),
],
),
actions: <Widget>[
TextButton(
onPressed: () {
Navigator.of(context).pop();
},
child: const Text('Close'),
),
],
);
},
);
},
child: const Text('Open Dialog'),
);
}),
],
),
),
),
),
);
}
}
```
</details>
### Before vs After
2024-05-30 17:43:26 +00:00
John Angelo Cordero
11cbe41555
allow changing textAlign of TextField in DropdownMenu ( #148074 )
...
PR for #147991
2024-05-30 16:57:00 +00:00
engine-flutter-autoroll
02739d737b
Roll Flutter Engine from 2fedfd3cc6e5 to de07179371f8 (1 revision) ( #149324 )
...
2fedfd3cc6...de07179371skia-flutter-autoroll@skia.org Roll Skia from 8da05c8d40af to 949b8cefbf87 (3 revisions) (flutter/engine#53113 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 16:52:03 +00:00
engine-flutter-autoroll
7eebe2992a
Roll Packages from 31d332900d98 to 910fabb4886b (11 revisions) ( #149321 )
...
31d332900d...910fabb48858529443+srujzs@users.noreply.github.com Amend package:web tweaks to allow package:web roll (flutter/packages#6793 )
2024-05-29 matanlurey@users.noreply.github.com Migrate `video_player/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6456 )
2024-05-29 joonas.kerttula@codemate.com [google_maps_flutter] Undeprecate BitmapDescriptor methods (flutter/packages#6832 )
2024-05-29 matanlurey@users.noreply.github.com Migrate CameraX from SurfaceTexture to SurfaceProducer. (flutter/packages#6462 )
2024-05-29 matanlurey@users.noreply.github.com Migrate `camera/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6461 )
2024-05-29 katelovett@google.com [dynamic_layouts] Remove the dynamic_layouts package (flutter/packages#6830 )
2024-05-29 43054281+camsim99@users.noreply.github.com [camerax] Add notes about Android permissions (flutter/packages#6741 )
2024-05-29 43054281+camsim99@users.noreply.github.com [Re-land] Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 (flutter/packages#6742 )
2024-05-29 engine-flutter-autoroll@skia.org Roll Flutter from a1a33e63b911 to c85fa6abf4ff (20 revisions) (flutter/packages#6829 )
2024-05-29 katelovett@google.com [rfw] Migrate deprecated doc references (flutter/packages#6744 )
2024-05-29 katelovett@google.com [flutter_adaptive_scaffold] Migrate MaterialStateProperty to WidgetStateProperty (flutter/packages#6743 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 16:39:06 +00:00
engine-flutter-autoroll
421c8c5ef5
Roll Flutter Engine from fb64b9a4e6f2 to 2fedfd3cc6e5 (2 revisions) ( #149320 )
...
fb64b9a4e6...2fedfd3cc6skia-flutter-autoroll@skia.org Roll Skia from e256482ed29c to 8da05c8d40af (1 revision) (flutter/engine#53112 )
2024-05-30 kjlubick@users.noreply.github.com Replace several calls to GrGLMakeNativeInterface with more direct APIs (flutter/engine#53064 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 15:45:24 +00:00
flyboy
db5c1434e6
Fix Slider throws an error when _labelPainter text is null ( #148462 )
...
*Fix #148159*
2024-05-30 14:49:13 +00:00
engine-flutter-autoroll
d4e9b78161
Roll Flutter Engine from 5500c1a3969a to fb64b9a4e6f2 (1 revision) ( #149307 )
...
5500c1a396...fb64b9a4e6skia-flutter-autoroll@skia.org Roll Skia from e63ddcabadc6 to e256482ed29c (1 revision) (flutter/engine#53110 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 11:17:37 +00:00
Taha Tesser
6a0e0bfdc5
Enable explicitChildNodes for the AlertDialog content ( #149130 )
...
fixes [AlertDialog content semantics merged](https://github.com/flutter/flutter/issues/147574 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
// showSemanticsDebugger: true,
home: Scaffold(
body: SafeArea(
child: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
const Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text('Some text'),
Text('More text'),
],
),
Builder(builder: (BuildContext context) {
return ElevatedButton(
onPressed: () {
showDialog<void>(
context: context,
builder: (BuildContext context) {
return AlertDialog(
title: const Text('Dialog Title'),
content: const Column(
children: <Widget>[
Text('Some text'),
Text('More text'),
],
),
actions: <Widget>[
TextButton(
onPressed: () {
Navigator.of(context).pop();
},
child: const Text('Close'),
),
],
);
},
);
},
child: const Text('Open Dialog'),
);
}),
],
),
),
),
),
);
}
}
```
</details>
### Before vs After
2024-05-30 09:59:22 +00:00
engine-flutter-autoroll
d71f4eb685
Roll Flutter Engine from 0c95e85dfbf4 to 5500c1a3969a (1 revision) ( #149304 )
...
0c95e85dfb...5500c1a396skia-flutter-autoroll@skia.org Roll Skia from 59dc6975523c to e63ddcabadc6 (1 revision) (flutter/engine#53109 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 09:43:28 +00:00
engine-flutter-autoroll
d54d8ab10f
Roll Flutter Engine from 19707e811b60 to 0c95e85dfbf4 (1 revision) ( #149300 )
...
19707e811b...0c95e85dfbskia-flutter-autoroll@skia.org Roll Skia from f23183f041fe to 59dc6975523c (3 revisions) (flutter/engine#53106 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 08:33:22 +00:00
engine-flutter-autoroll
b295c86b2e
Roll Flutter Engine from 4adf453b6d68 to 19707e811b60 (1 revision) ( #149291 )
...
4adf453b6d...19707e811bjonahwilliams@google.com [Impeller] enable Impeller by default on Android. (flutter/engine#53099 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 04:29:41 +00:00
Jonah Williams
d3beaae07f
disable Impeller on external texture test. ( #149292 )
...
This is failing with Impeller:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android_emu%20external_textures_integration_test/1414/overview
Needs investigation.
2024-05-29 20:43:48 -07:00
engine-flutter-autoroll
c787dc99bd
Roll Flutter Engine from 8d5d14a1db95 to 4adf453b6d68 (12 revisions) ( #149290 )
...
8d5d14a1db...4adf453b6dskia-flutter-autoroll@skia.org Roll Skia from aecf76e8eb9a to f23183f041fe (1 revision) (flutter/engine#53102 )
2024-05-29 john@mcdole.org Update CONTRIBUTING.md links (flutter/engine#53043 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from 32746679f7be to aecf76e8eb9a (1 revision) (flutter/engine#53100 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from b18b7d6af6e8 to 32746679f7be (2 revisions) (flutter/engine#53097 )
2024-05-29 jonahwilliams@google.com [Impeller] revert changes to IO thread upload scheduling. (flutter/engine#53096 )
2024-05-29 jonahwilliams@google.com [Impeller] fix barriers prior to mip generation. (flutter/engine#53082 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from e11a5c5b402e to b18b7d6af6e8 (2 revisions) (flutter/engine#53095 )
2024-05-29 goderbauer@google.com Switch to FilterQuality.medium for images (flutter/engine#52984 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from a4f58c9dabc3 to e11a5c5b402e (1 revision) (flutter/engine#53092 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from ca77972f659e to a4f58c9dabc3 (2 revisions) (flutter/engine#53091 )
2024-05-29 jonahwilliams@google.com [Impeller] relax conditions for SkRRect.isSimple conversion to impeller::RRect. (flutter/engine#53083 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from d1a6967c48a5 to ca77972f659e (1 revision) (flutter/engine#53090 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 02:28:10 +00:00
Kevin Chisholm
07c256f026
Update 3.22.1 release notes to include missing fix. ( #148999 )
...
Update changelog to include
https://github.com/flutter/flutter/pull/148580 in the list of fixes.
2024-05-30 09:15:37 +07:00
engine-flutter-autoroll
697d99fae8
Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revision) ( #149263 )
...
Manual roll requested by jacksongardner@google.com
60968ee3bd...8d5d14a1dbskia-flutter-autoroll@skia.org Manual roll Dart SDK from 641d61332238 to ef405fbe3917 (12 revisions) (flutter/engine#53089 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-30 00:53:23 +00:00
auto-submit[bot]
ebc414337d
Reverts "Prevent LayoutBuilder from rebuilding more than once ( #147856 )" ( #149279 )
...
Reverts: flutter/flutter#147856
Initiated by: loic-sharma
Reason for reverting: tree is closed with errors like:
```
test/integration.shard/break_on_framework_exceptions_test.dart: breaks when rebuilding dirty elements throws [E]
Expected: <45>
Actual: <2756>
package:matcher expect
test\integration.shard\break_on_framework_exceptions_test.dart 56:5 main.expectException
===== asynchronous gap ===
Original PR Author: LongCatIsLooong
Reviewed By: {goderbauer}
This change reverts the following previous change:
Fixes https://github.com/flutter/flutter/issues/146379 : introduces `Element.buildScope` which `BuildOwner.buildScope` uses to identify subtrees that need skipping (those with different `BuildScope`s). If `Element.update` calls `updateChild` then dirty children will still be rebuilt regardless of their build scopes.
This also introduces `LayoutBuilder.applyDoubleRebuildFix` migration flag which should only live for a week or less.
Caveats:
`LayoutBuilder`'s render object calls `markNeedsLayout` if a descendant Element is dirty. Since `markNeedsLayout` also implies `markNeedsPaint`, the render object is going to be very repaint/relayout-happy.
Tests:
Presubmits with the migration flag set to true: https://github.com/flutter/flutter/pull/147856/checks?check_run_id=24629865893
2024-05-29 23:29:19 +00:00
Danny Tuppeny
182c1e6a36
Unskip expression evaluation test ( #149253 )
...
This test was skipped in https://github.com/flutter/flutter/pull/148737
because it had became flaky because instances created in expression
evaluation were being collected quickly. The change in
ffbbdb5a10https://github.com/flutter/flutter/issues/148704
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-05-29 23:24:36 +01:00
Yegor
35543e9117
temporarily disable SemanticsAction tests to unblock engine change ( #149274 )
...
These tests essentially count the number of values in the engine enums. https://github.com/flutter/engine/pull/53094 is adding a new value, which causes these tests to fail. Temporarily disabling these tests so that the engine change can proceed.
2024-05-29 22:22:25 +00:00
gaaclarke
ba5a4d8c09
Adds benchmark for rrect_blur. ( #149261 )
...
issue: https://github.com/flutter/flutter/issues/148496
(I slightly tweaked the animation to make sure the large radius blurs aren't always at the bottom of the screen).
2024-05-29 22:19:10 +00:00
LongCatIsLooong
bafdb124c7
Prevent LayoutBuilder from rebuilding more than once ( #147856 )
...
Fixes https://github.com/flutter/flutter/issues/146379 : introduces `Element.buildScope` which `BuildOwner.buildScope` uses to identify subtrees that need skipping (those with different `BuildScope`s). If `Element.update` calls `updateChild` then dirty children will still be rebuilt regardless of their build scopes.
This also introduces `LayoutBuilder.applyDoubleRebuildFix` migration flag which should only live for a week or less.
Caveats:
`LayoutBuilder`'s render object calls `markNeedsLayout` if a descendant Element is dirty. Since `markNeedsLayout` also implies `markNeedsPaint`, the render object is going to be very repaint/relayout-happy.
Tests:
Presubmits with the migration flag set to true: https://github.com/flutter/flutter/pull/147856/checks?check_run_id=24629865893
2024-05-29 22:03:20 +00:00
Valentin Vignal
bc097c619a
Add test for inherited_theme.0.dart ( #149120 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/inherited_theme/inherited_theme.0_test.dart`
2024-05-29 20:05:25 +00:00
Ellet
e553bbc2ba
Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS ( #145246 )
...
Since we are using The `CupertinoScrollBar` for both macOS and iOS, it's a good idea to update the description of the `adaptive` function to indicate it will be used for macOS and iOS
*Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS.*
2024-05-29 19:06:07 +00:00
LinXunFeng
d424b64229
_ModalScopeStatus as InheritedModel ( #149022 )
...
According to previous discussion at https://github.com/flutter/flutter/pull/145389#discussion_r1561564845 , this change makes `_ModalScopeStatus` an `InheritedModel` rather than an `InheritedWidget`, and provides the following methods.
- `isCurrentOf`
- `canPopOf`
- `settingsOf`
For example, `ModalRoute.of(context)!.settings` could become `ModalRoute.settingsOf(context)` as a performance optimization.
2024-05-29 18:46:04 +00:00
Valentin Vignal
2e275032d5
Add test for radio.toggleable.0.dart ( #149153 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/material/radio/radio.toggleable.0.dart`
2024-05-29 18:30:57 +00:00
LongCatIsLooong
557fca4582
Add a sentinel value for TextStyle.height ( #149049 )
...
Fixes: https://github.com/flutter/flutter/issues/58765
The rationale for the choice of the sentinel value: https://github.com/flutter/engine/pull/52940
The exact value of `kTextHeightNone` should be kept as an implementation detail. It's unfortunate that the current value `0` is dangerously close to `TextStyle.height`'s valid domain. If we ever allow `TextStyle.height == 0` (which totally makes sense) then it shouldn't be difficult to change the const.
2024-05-29 18:24:16 +00:00
Kate Lovett
90937b02eb
Remove dynamic_layouts from issue template ( #149252 )
...
Part of https://github.com/flutter/flutter/issues/148979
The package is being removed from flutter/packages, and so this removes it from the issue template.
2024-05-29 17:28:03 +00:00
engine-flutter-autoroll
10557babf9
Roll Flutter Engine from 30aa720d4999 to 60968ee3bde7 (1 revision) ( #149255 )
...
30aa720d49...60968ee3bdskia-flutter-autoroll@skia.org Roll Skia from 2fe794827c51 to d1a6967c48a5 (1 revision) (flutter/engine#53088 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 17:16:16 +00:00
engine-flutter-autoroll
6b05c462c7
Roll Flutter Engine from b26e1b023cdb to 30aa720d4999 (7 revisions) ( #149249 )
...
b26e1b023c...30aa720d49skia-flutter-autoroll@skia.org Roll Skia from 99966843c23f to 2fe794827c51 (1 revision) (flutter/engine#53087 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from d2469aaf5ab1 to 99966843c23f (1 revision) (flutter/engine#53086 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from 9ea5a1dd5270 to d2469aaf5ab1 (2 revisions) (flutter/engine#53085 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from eedef8763102 to 9ea5a1dd5270 (1 revision) (flutter/engine#53084 )
2024-05-29 skia-flutter-autoroll@skia.org Roll Skia from 0026a6047133 to eedef8763102 (1 revision) (flutter/engine#53081 )
2024-05-29 flar@google.com DisplayList forward opacity incompatibility through deferred saves (flutter/engine#53078 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from ac454b80130c to 0026a6047133 (1 revision) (flutter/engine#53076 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 16:15:16 +00:00
engine-flutter-autoroll
a00bba82bd
Roll Packages from a933c3016f6c to 31d332900d98 (6 revisions) ( #149246 )
...
a933c3016f...31d332900dflutter/packages#6815 )
2024-05-28 22373191+Hari-07@users.noreply.github.com [google_maps_flutter] Implement polyline patterns in google maps ios (flutter/packages#5757 )
2024-05-28 34871572+gmackall@users.noreply.github.com [many] Remove references to v1 embedding (flutter/packages#6494 )
2024-05-28 48729942+altynbek132@users.noreply.github.com [go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart (flutter/packages#6670 )
2024-05-28 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.10.0 to 1.11.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#6805 )
2024-05-28 engine-flutter-autoroll@skia.org Roll Flutter from 0b31ffc125e9 to a1a33e63b911 (6 revisions) (flutter/packages#6822 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 15:52:20 +00:00
Polina Cherkasova
c85fa6abf4
Clean leak in editable_text_test.dart. ( #149223 )
...
Introduced by https://github.com/flutter/flutter/pull/149042
<img width="145" alt="Screenshot 2024-05-28 at 6 25 22â¯PM" src="https://github.com/flutter/flutter/assets/12115586/5eb32012-b1c4-4188-8e9b-a6631483960c ">
2024-05-29 15:41:18 +00:00
Kostia Sokolovskyi
60d32e4534
Add tests for animated_switcher.0.dart API example. ( #149180 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds tests for `examples/api/lib/widgets/animated_switcher/animated_switcher.0.dart`
2024-05-29 12:10:34 +00:00
engine-flutter-autoroll
35ae519140
Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) ( #149220 )
...
Manual roll requested by jacksongardner@google.com
d0323905fc...b26e1b023c34871572+gmackall@users.noreply.github.com Manual revert of #53001 (flutter/engine#53075 )
2024-05-28 chinmaygarde@google.com Remove --ios-cpu flag. Only the arm64 variant is supported. (flutter/engine#53044 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 229d94a8807e to ac454b80130c (1 revision) (flutter/engine#53074 )
2024-05-28 jonahwilliams@google.com [Impeller] make strokes slightly lighter. (flutter/engine#53067 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 23ddbb590e44 to 229d94a8807e (2 revisions) (flutter/engine#53071 )
2024-05-28 jmccandless@google.com FlutterFragment predictive back (flutter/engine#52302 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 02c359cf8233 to 23ddbb590e44 (2 revisions) (flutter/engine#53070 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 4f91b3865441 to 02c359cf8233 (1 revision) (flutter/engine#53069 )
2024-05-28 30870216+gaaclarke@users.noreply.github.com [Impeller] shrunk the buffer for the rrect_blur (flutter/engine#53068 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 91cd2b48377a to 4f91b3865441 (4 revisions) (flutter/engine#53066 )
2024-05-28 34871572+gmackall@users.noreply.github.com Upgrade all[most] androidx dependencies to latest (flutter/engine#53001 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 0c2c490021b7 to 91cd2b48377a (3 revisions) (flutter/engine#53065 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 545203f95d4e to 0c2c490021b7 (2 revisions) (flutter/engine#53063 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 74b4d97be6ab to 545203f95d4e (1 revision) (flutter/engine#53062 )
2024-05-28 skia-flutter-autoroll@skia.org Roll Skia from 848d9498fd68 to 74b4d97be6ab (1 revision) (flutter/engine#53061 )
2024-05-28 johnniwinther@google.com Remove use of --nnbd-agnostic (flutter/engine#53055 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 04:33:07 +00:00
Hany Mohamed
9ea9726b21
Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null ( #148568 )
...
The PR changes the default value of hitTestBehavior in snack bars to `HitTestBehavior.deferToChild` when snackBarTheme.insetPadding is not null, so that widgets behind snack bars affected by the value set to insetPadding, remain interactive even while a snack bar is visible. This PR can be considered as an extension to what have been done in PR #127959 which fixes the same problem but for individual snack bars with margin not being null. This PR works on the theme level.
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
#148566
2024-05-29 04:31:32 +00:00
auto-submit[bot]
886de22182
Reverts "sliverGridDelegate mainAxisExtent add assert ( #148470 )" ( #149224 )
...
Reverts: flutter/flutter#148470
Initiated by: eyebrowsoffire
Reason for reverting: Unit test failures closing the tree.
Original PR Author: hello-coder-xu
Reviewed By: {QuncCccccc, Piinks}
This change reverts the following previous change:
* sliverGridDelegate mainAxisExtent add assert,Avoid incorrect use *
Fixes https://github.com/flutter/flutter/issues/138871
2024-05-29 02:33:16 +00:00
flyboy
af5a1a9e11
sliverGridDelegate mainAxisExtent add assert ( #148470 )
...
* sliverGridDelegate mainAxisExtent add assert,Avoid incorrect use *
Fixes https://github.com/flutter/flutter/issues/138871
2024-05-29 00:26:08 +00:00
Luis
b1540324e5
Fix SearchAnchor suggestions not refreshing after long API call ( #148767 )
...
Fixes https://github.com/flutter/flutter/issues/148765 .
## Fix Demo
https://github.com/flutter/flutter/assets/28322469/ad76ac8b-5e84-4fee-b04c-fbc9fa919450
2024-05-29 00:20:18 +00:00
Loïc Sharma
1f4e378de1
Add link to golden file test docs in the framework gardener guide ( #149207 )
...
This also adds a link from the Framework gardener guide.
2024-05-28 23:55:58 +00:00
Polina Cherkasova
65e3007687
Remove opt out for CurvedAnimation. ( #147594 )
2024-05-28 16:35:29 -07:00
LongCatIsLooong
0214afb40b
Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline ( #149062 )
...
Per Hixie's comment [here](https://github.com/flutter/flutter/issues/145739#issuecomment-2128006146 ), keep the current behavior
2024-05-28 23:21:08 +00:00
Polina Cherkasova
c109b3cb02
Clean leaky test. ( #149199 )
...
Introduced by https://github.com/flutter/flutter/pull/149006
To repro run:
`flutter test /Users/polinach/_/flutter_dev/packages/flutter/test/material/text_button_test.dart --dart-define LEAK_TR`
<img width="268" alt="Screenshot 2024-05-28 at 11 50 33â¯AM" src="https://github.com/flutter/flutter/assets/12115586/c1a1bf5e-4df4-4819-b897-b09021d3a07a ">
2024-05-28 23:06:10 +00:00
Gray Mackall
df64ca0b11
Change android_plugin_new_output_dir_test.dart test description ( #149198 )
...
Changes the test description to what I understand it is testing.
Context at https://discord.com/channels/608014603317936148/846507907876257822/1245077048599515157 .
cc @chunfengyao as the original author, as I see you are still active on Github ð
2024-05-28 23:04:10 +00:00
Bruno Leroux
fdca33c5b1
fix M2 InputDecorator suffix icon doesn't turn red on error ( #149161 )
...
The suffixIcon of a TextField with an error now turns red like it should (on Material 2).
2024-05-28 11:27:55 -07:00
Varun Kamani
e2e68c047c
Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer… ( #143079 )
...
It's now possible to override the default selection overlay with CupertinoDatePicker.selectionOverlayBuilder and CupertinoTimerPicker.selectionOverlayBuilder.
2024-05-28 11:24:57 -07:00
Justin McCandless
980b5a1976
Mouse onEnter and onExit now support hovering stylus ( #149006 )
...
Hovering with a stylus will now behave similarly to hovering with a mouse. For example, hovering a button will show the button's hovered styling.
2024-05-28 10:39:30 -07:00
LongCatIsLooong
b1221a92dc
Remove TextEditingController private member access ( #149042 )
...
Fixes https://github.com/flutter/flutter/issues/148692
I intend to CP this.
2024-05-28 17:37:25 +00:00
engine-flutter-autoroll
6543a2155e
Roll Packages from b7bcb4bd1267 to a933c3016f6c (1 revision) ( #149184 )
...
b7bcb4bd12...a933c3016fengine-flutter-autoroll@skia.org Roll Flutter from 656447127360 to 0b31ffc125e9 (7 revisions) (flutter/packages#6820 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 15:46:17 +00:00
