engine-flutter-autoroll
509cb43e9d
Roll Flutter Engine from 7207a8fbec93 to f56401062e42 (1 revision) ( #158169 )
...
7207a8fbec...f56401062eskia-flutter-autoroll@skia.org Roll Dart SDK from 695831e9a70b to b39c729740eb (1 revision) (flutter/engine#56372 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-05 11:51:26 +00:00
Valentin Vignal
86fc1fd479
Add test for raw_scrollbar.shape.0.dart ( #158094 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/scrollbar/raw_scrollbar.shape.0.dart`
2024-11-05 08:21:20 +00:00
engine-flutter-autoroll
2a2a1dea8f
Roll Flutter Engine from 418609dd5b58 to 7207a8fbec93 (1 revision) ( #158156 )
...
418609dd5b...7207a8fbecskia-flutter-autoroll@skia.org Roll Dart SDK from 0addd35215d0 to 695831e9a70b (3 revisions) (flutter/engine#56371 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-05 07:47:24 +00:00
Bruno Leroux
338555b764
Refactor DropdownMenu tests ( #157913 )
...
## Description
This PR introduces some utility functions to simplify some DropdownMenu tests.
The main purpose is to centralize and document how tests should find menu items, because it is tricky as there are two occurrences of each widgets and using '.last' is mandatory:
```dart
Finder findMenuItemButton(String label) {
// For each menu items there are two MenuItemButton widgets.
// The last one is the real button item in the menu.
// The first one is not visible, it is part of _DropdownMenuBody
// which is used to compute the dropdown width.
return find.widgetWithText(MenuItemButton, label).last;
}
```
## Related Issue
This is extracted from https://github.com/flutter/flutter/pull/157496 .
## Tests
Refactors many existing tests.
2024-11-05 06:11:32 +00:00
engine-flutter-autoroll
47723f67dc
Roll Flutter Engine from 6271a92a376f to 418609dd5b58 (3 revisions) ( #158152 )
...
6271a92a37...418609dd5bjonahwilliams@google.com remove mock vulkan memory test. (flutter/engine#56367 )
2024-11-05 ditman@gmail.com [web] injectPlatformView into correct flutterView (flutter/engine#56334 )
2024-11-05 devoncarew@google.com [deps] removed unused deps (dart-lang browser_launcher, clock, bazel_worker, cli_util, csslib, html, json_rpc_2 (flutter/engine#56359 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-05 05:21:21 +00:00
Flutter GitHub Bot
48385ca016
Marks Linux_pixel_7pro flavors_test to be flaky ( #156956 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro flavors_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/156955
2024-11-05 04:53:08 +00:00
Matan Lurey
08ff061d13
Further remove web-only considerations that are no longer necessary ( #158143 )
...
... to mention because without HTML they work the same as the native renderer! Yay!
Post-submit follow-up cleanups to https://github.com/flutter/flutter/pull/158035#pullrequestreview-2414359559 (https://github.com/flutter/flutter/issues/157547 ).
2024-11-05 04:31:12 +00:00
Polina Cherkasova
33f7137aeb
Add optional parameter to FlutterTesterDevices. ( #158133 )
...
This is to handle Google testing failures for https://github.com/flutter/flutter/pull/158126 .
We want to update G3 to provide this parameter before merging the full change.
Testing is not needed because the change is no-op.
2024-11-05 02:09:35 +00:00
engine-flutter-autoroll
0f4cc64d9a
Roll Flutter Engine from 75acceedca41 to 6271a92a376f (2 revisions) ( #158148 )
...
75acceedca...6271a92a37matanlurey@users.noreply.github.com Add and document `et cleanup`. (flutter/engine#56327 )
2024-11-04 jonahwilliams@google.com [Impeller] check if memory type is host coherent, avoid flush. (flutter/engine#56350 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-05 02:03:10 +00:00
Matan Lurey
cc90a424c9
Extract and restore a test that a blank native assets project still builds ( #158141 )
...
Closes https://github.com/flutter/flutter/issues/158120 .
This PR restores the skipped test, moving it (and the test utility only used by the test) into a standalone file that can be more easily understood. As part of the change the version of `native_assets_cli` is now derived from the (checked-in) `package_ffi/pubspec.yaml.tmpl`, meaning that it should be hard to get into a bad state again.
/cc @christopherfujino (You are welcome to review, but otherwise will defer to Brandon and Victor).
2024-11-05 01:39:25 +00:00
Matan Lurey
abcdcee57a
Remove references to the HTML renderer in public docs. ( #158035 )
...
Closes https://github.com/flutter/flutter/issues/157547 .
2024-11-04 23:28:38 +00:00
engine-flutter-autoroll
29ff2e8c26
Roll Flutter Engine from f880b56b6ede to 75acceedca41 (1 revision) ( #158137 )
...
f880b56b6e...75acceedcaskia-flutter-autoroll@skia.org Roll Dart SDK from f238183cf168 to 0addd35215d0 (1 revision) (flutter/engine#56357 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-04 22:35:15 +00:00
Nate Wilson
43bd9482d0
Fix WidgetStateProperty documentation ( #154298 )
...
Changes:
- Remove 2<sup>nd</sup> person language from docs ([relevant style guideline](https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#use-the-passive-voice-recommend-do-not-require-never-say-things-are-simple ))
- Update a bunch of spots to be more explicit about `WidgetStateMouseCursor`.
- `WidgetStateFoo` constructors now accurately describe what happens when used incorrectly.
- Gave `WidgetStateProperty` a little section about equality checks.
2024-11-04 22:35:13 +00:00
engine-flutter-autoroll
97a4db9396
Roll Flutter Engine from 25c7e471e2ef to f880b56b6ede (5 revisions) ( #158132 )
...
25c7e471e2...f880b56b6e30870216+gaaclarke@users.noreply.github.com Made it so angle builds on linux (flutter/engine#56328 )
2024-11-04 jonahwilliams@google.com [Impeller] combine translate* scale mat mul when computing shader transform. (flutter/engine#56352 )
2024-11-04 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.2.1 to 4.2.2 (flutter/engine#56191 )
2024-11-04 chris@bracken.jp iOS: Eliminate fml::scoped_nsobject pointer use (flutter/engine#56295 )
2024-11-04 skia-flutter-autoroll@skia.org Roll Skia from e2ad60ea8039 to b2bb3af36da3 (1 revision) (flutter/engine#56355 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-04 21:31:16 +00:00
engine-flutter-autoroll
76e81eb5e6
Roll Flutter Engine from 05cb5d7f7939 to 25c7e471e2ef (12 revisions) ( #158127 )
...
05cb5d7f79...25c7e471e2zanderso@users.noreply.github.com Retry mac_unopt one time in presubmit (flutter/engine#56319 )
2024-11-04 jonahwilliams@google.com [Impeller] faster descriptor type mapping. (flutter/engine#56351 )
2024-11-04 skia-flutter-autoroll@skia.org Roll Skia from 75740b68a282 to e2ad60ea8039 (8 revisions) (flutter/engine#56354 )
2024-11-04 109111084+yaakovschectman@users.noreply.github.com Move detection of cutouts in Android engine to `onApplyWindowInsets` (flutter/engine#55992 )
2024-11-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 69cec5dc51f9 to f238183cf168 (1 revision) (flutter/engine#56353 )
2024-11-04 skia-flutter-autoroll@skia.org Roll Skia from bab7d954758b to 75740b68a282 (1 revision) (flutter/engine#56349 )
2024-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 07KmbdEtnhkg_tUhe... to amgHXcqtplha8LuI_... (flutter/engine#56348 )
2024-11-03 skia-flutter-autoroll@skia.org Roll Skia from 6944cd128603 to bab7d954758b (2 revisions) (flutter/engine#56346 )
2024-11-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 61bf0877807e to 69cec5dc51f9 (2 revisions) (flutter/engine#56335 )
2024-11-02 dkwingsmt@users.noreply.github.com Multiple touches of a stylus should be considered from the same device (flutter/engine#56075 )
2024-11-02 skia-flutter-autoroll@skia.org Roll Skia from 89ac72bb4922 to 6944cd128603 (2 revisions) (flutter/engine#56331 )
2024-11-02 tugorez@users.noreply.github.com [web] Transfer focus to view rootElement on blur/remove. (flutter/engine#55045 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 07KmbdEtnhkg to amgHXcqtplha
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-04 20:34:17 +00:00
Loïc Sharma
d939b84350
Remove use_modular_headers! from Swift Podfiles ( #156257 )
...
We added `use_modular_headers!` to our `Podfile`s as we originally planned to phase out `use_frameworks!` (see https://github.com/flutter/flutter/pull/42204 ). However, our plans have now changed and we are instead phasing out CocoaPods entirely in favor of Swift Package Manager.
CocoaPods's `use_frameworks!` and `use_modular_headers!` are two different overlapping options that should not be used together. This change removes the `use_modular_headers!` from the macOS `Podfile` and the iOS Swift `Podfile` (the iOS Objective-C template was recently deprecated https://github.com/flutter/flutter/pull/155867 ).
This change only affects _new_ Flutter apps. This change does not include an automatic migration as that could break existing apps. Instead, users are encouraged to migrate from CocoaPods to Swift Package Manager.
https://github.com/flutter/flutter/issues/156259
2024-11-04 20:32:34 +00:00
Victor Sanni
f19d329ac0
Disable failing native assets test ( #158119 )
...
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-11-04 11:29:26 -08:00
Nate Wilson
9ee00ae168
Fix NestedScrollView inner position logic ( #157756 )
...
closes #40740
<p align="center">
<img
src="https://github.com/user-attachments/assets/8a48abd0-466b-4e06-90f3-dd05869bac27 "
alt="NestedScrollController fix"
height="720px"
/>
</p>
<details> <summary><h4>Demo source code</h4> (click to expand)</summary>
(this is a slightly more concise version of the code sample from #40740 )
```dart
import 'package:flutter/material.dart';
void main() {
runApp(
const MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(body: NewsScreen()),
),
);
}
class NewsScreen extends StatelessWidget {
const NewsScreen({super.key});
static const List<String> _tabs = <String>['Featured', 'Popular', 'Latest'];
static final List<Widget> _tabViews = <Widget>[
for (final String name in _tabs)
SafeArea(
top: false,
bottom: false,
child: Builder(builder: (BuildContext context) {
final handle = NestedScrollView.sliverOverlapAbsorberHandleFor(context);
return NotificationListener<ScrollNotification>(
onNotification: (ScrollNotification notification) => true,
child: CustomScrollView(
key: PageStorageKey<String>(name),
slivers: <Widget>[
SliverOverlapInjector(handle: handle),
SliverPadding(
padding: const EdgeInsets.all(8.0),
sliver: SliverList(
delegate: SliverChildBuilderDelegate(
childCount: 30,
(BuildContext context, int index) => Container(
margin: const EdgeInsets.only(bottom: 8),
width: double.infinity,
height: 150,
color: const Color(0xFFB0A4C8),
alignment: Alignment.center,
child: Text(
'$name $index',
style: const TextStyle(fontWeight: FontWeight.w600),
),
),
),
),
),
],
),
);
}),
),
];
@override
Widget build(BuildContext context) {
return DefaultTabController(
length: _tabs.length,
child: NestedScrollView(
headerSliverBuilder: (BuildContext context, bool innerBoxIsScrolled) => <Widget>[
SliverOverlapAbsorber(
handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
sliver: SliverSafeArea(
top: false,
sliver: SliverAppBar(
title: const Text('Tab Demo'),
floating: true,
pinned: true,
snap: true,
forceElevated: innerBoxIsScrolled,
bottom: TabBar(
tabs: _tabs.map((String name) => Tab(text: name)).toList(),
),
),
),
),
],
body: TabBarView(children: _tabViews),
),
);
}
}
```
<br>
</details>
<br>
This bug can be traced to a return statement inside `_NestedScrollPosition`:
```dart
double applyClampedDragUpdate(double delta) {
// ...
return delta + offset;
}
```
Thanks to some quirks of floating-point arithmetic, `applyClampedDragUpdate` would sometimes return a tiny non-zero value, which ends up ruining one of the scroll coordinator's equality checks.
8990ed6538/packages/flutter/lib/src/widgets/nested_scroll_view.dart (L658-L664)
2024-11-04 16:42:06 +00:00
Jackson Gardner
4a33136db8
Add benchmarks for single-threaded Skwasm. ( #158027 )
...
This adds benchmarks that run on single threaded skwasm.
2024-11-04 16:38:10 +00:00
Valentin Vignal
8591d0c16a
Remove null from flex documentation ( #158086 )
...
Closes https://github.com/flutter/flutter/issues/158085
2024-11-04 12:46:29 +00:00
Valentin Vignal
ed91ba1ba5
Add test for raw_scrollbar.1.dart ( #158069 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/scrollbar/raw_scrollbar.1.dart`
2024-11-04 07:33:22 +00:00
Valentin Vignal
a1fbc839e2
Add test for interactive_viewer.constrained.0.dart ( #158044 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/interactive_viewer/interactive_viewer.constrained.0.dart`
2024-11-04 01:47:30 +00:00
Polina Cherkasova
0505176f1b
Revert "Add and plumb useImplicitPubspecResolution across flutter_tools." ( #158076 )
...
Reverts flutter/flutter#157879 to unblock flutter roll.
Prerequisite reverts:
https://github.com/flutter/flutter/pull/157934
Reason: b/377107864
2024-11-03 17:29:24 +00:00
Polina Cherkasova
f7b24fa525
Revert "Add a warning/additional handlers for parsingsynthetic-package." ( #158078 )
...
Reverts flutter/flutter#157934 to unblock https://github.com/flutter/flutter/pull/158076 and then flutter roll.
Reason: b/377107864
2024-11-03 17:12:20 +00:00
Jiten Patel
a1651c684b
Fixes typos & spelling error in changelog.md file ( #157438 )
...
This PR fixes the typos and spelling error in `CHANGELOG.md` file.
Fixes #157083
2024-11-03 12:19:37 +00:00
Valentin Vignal
574b7e765d
Add test for raw_scrollbar.0.dart ( #157989 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/scrollbar/raw_scrollbar.0.dart`
2024-11-02 03:57:29 +00:00
engine-flutter-autoroll
ced3e85a2a
Roll Flutter Engine from 38b6165f137d to 05cb5d7f7939 (4 revisions) ( #158038 )
...
38b6165f13...05cb5d7f79matanlurey@users.noreply.github.com Refactor `BuildPlan`, better document and explain `--config`. (flutter/engine#56324 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MjcuejuzYvYGobbFM... to 07KmbdEtnhkg_tUhe... (flutter/engine#56322 )
2024-11-01 jonahwilliams@google.com [Impeller] implement external texture gl for embedder. (flutter/engine#56277 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 789763468d6b to 61bf0877807e (2 revisions) (flutter/engine#56323 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from MjcuejuzYvYG to 07KmbdEtnhkg
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-02 02:24:06 +00:00
engine-flutter-autoroll
2068fe78b2
Roll Flutter Engine from 7dfdcacd8ae4 to 38b6165f137d (5 revisions) ( #158034 )
...
7dfdcacd8a...38b6165f13jonahwilliams@google.com [Impeller] fix downsample with decal tile mode. (flutter/engine#56316 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Skia from dfbb0e6bc974 to 89ac72bb4922 (6 revisions) (flutter/engine#56320 )
2024-11-01 jacksongardner@google.com Remove superfluous dart2wasm test suites/bundles. (flutter/engine#56315 )
2024-11-01 jason-simmons@users.noreply.github.com Write run_tests console logs to stdout instead of stderr (flutter/engine#56312 )
2024-11-01 jonahwilliams@google.com [impeller] use greater equal rather than greater depth compare. (flutter/engine#56310 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-02 00:37:35 +00:00
Matan Lurey
8b5ad69ff8
Delete unused references to dev.flutter.plugins.e2e. ( #158031 )
...
Closes https://github.com/flutter/flutter/issues/157826 .
Like @gmackall I could not find any reference to these, and assume they were boilerplate that was never used (or deleted).
2024-11-02 00:22:04 +00:00
engine-flutter-autoroll
9a5e8ce6b5
Roll Flutter Engine from 7b176f4f25da to 7dfdcacd8ae4 (1 revision) ( #158021 )
...
7b176f4f25...7dfdcacd8ajacksongardner@google.com Reland single threaded Skwasm (flutter/engine#56282 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 21:33:22 +00:00
engine-flutter-autoroll
f45e290437
Roll Flutter Engine from 3a090b46dd35 to 7b176f4f25da (2 revisions) ( #158018 )
...
3a090b46dd...7b176f4f25skia-flutter-autoroll@skia.org Roll Skia from 3b50199d27bb to dfbb0e6bc974 (2 revisions) (flutter/engine#56305 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 09c8281e66cc to 789763468d6b (2 revisions) (flutter/engine#56303 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 20:29:46 +00:00
Loïc Sharma
3699474585
Make SwiftPM integration tests even MORE idiomatic ( #158014 )
...
Reach peak idiomacy by replacing `expect(file.existsSync(), isTrue)` with `expect(file, exists)`!
Follow up to: https://github.com/flutter/flutter/pull/157971
2024-11-01 20:00:04 +00:00
Loïc Sharma
84ad67f8c1
Improve consistency of code snippets in basic.dart ( #158015 )
...
Updates `basic.dart` to use consistent doc snippets that follows the style from the [documentation on snippets](https://github.com/flutter/flutter/tree/master/dev/snippets#snippet-tool ).
Follow-up to: https://github.com/flutter/flutter/pull/157227#discussion_r1807499353
2024-11-01 19:38:19 +00:00
Matan Lurey
2ce743d0f0
Remove unnecessary kCliAnimationsFeatureName that is available as .configSetting. ( #158013 )
...
... for consistency with the rest of the file/features.
2024-11-01 19:20:59 +00:00
Loïc Sharma
49ccfb7302
Make the SwiftPM integration tests more idiomatic ( #157971 )
...
I recommend reviewing with [whitespace changes disabled](https://github.com/flutter/flutter/pull/157971/files?diff=split&w=1 ).
Changes:
1. Replaces `expect(string.contains('foo'), isTrue)` with `expect(string, contains('foo'))`
2. Replaces `try/finally` with `addTearDown`
Follow-up to: https://github.com/flutter/flutter/pull/157482#discussion_r1813939657
2024-11-01 18:15:15 +00:00
engine-flutter-autoroll
f86b777215
Roll Packages from 7cc1caa0cc36 to 796afa35071d (15 revisions) ( #158003 )
...
7cc1caa0cc...796afa3507stuartmorgan@google.com [google_maps_flutter] Update Android for non-nullable generics (flutter/packages#7990 )
2024-11-01 stuartmorgan@google.com [various] Minor cleanup in recently imported packages (flutter/packages#7995 )
2024-11-01 stuartmorgan@google.com [go_router] Update example app to Kotlin 1.9.0 (flutter/packages#7997 )
2024-10-31 engine-flutter-autoroll@skia.org Manual roll Flutter from fe71cadf1959 to 0fe615343bd9 (18 revisions) (flutter/packages#7989 )
2024-10-31 kevmoo@users.noreply.github.com [vector_garphics] fix execution on the web with WebAssembly (flutter/packages#7991 )
2024-10-31 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7986 )
2024-10-31 stuartmorgan@google.com [flutter_svg] Initial import (flutter/packages#7944 )
2024-10-31 stuartmorgan@google.com [vector_graphics] Initial import (flutter/packages#7941 )
2024-10-30 stuartmorgan@google.com [ci] Ensure repo tool is autoformatted (flutter/packages#7963 )
2024-10-30 zanderso@users.noreply.github.com Updates path_parsing README.md with a note about Dan (flutter/packages#7949 )
2024-10-30 stuartmorgan@google.com [tool] Support third_party for --current-package (flutter/packages#7967 )
2024-10-30 stuartmorgan@google.com [tool] Fix third_party dependency overrides (flutter/packages#7966 )
2024-10-30 jessiewong401@gmail.com Applied Gradle Plugins Declaratively for `path_provider` (flutter/packages#7822 )
2024-10-30 stuartmorgan@google.com [palette_generator] Remove unmanaged code snippet (flutter/packages#7962 )
2024-10-30 engine-flutter-autoroll@skia.org Roll Flutter from 42132e879b42 to fe71cadf1959 (12 revisions) (flutter/packages#7961 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 17:07:54 +00:00
Flutter GitHub Bot
f159136549
Marks Linux_pixel_7pro service_extensions_test to be flaky ( #157853 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro service_extensions_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/157852
2024-11-01 16:40:20 +00:00
engine-flutter-autoroll
2da2332ad1
Roll Flutter Engine from 0a0d5c9be6ff to 3a090b46dd35 (1 revision) ( #157994 )
...
0a0d5c9be6...3a090b46ddchris@bracken.jp fml: Delete weak_nsobject.h,mm (flutter/engine#56289 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 13:41:22 +00:00
engine-flutter-autoroll
3eb000c522
Roll Flutter Engine from bacc5e1e73b7 to 0a0d5c9be6ff (3 revisions) ( #157991 )
...
bacc5e1e73...0a0d5c9be6skia-flutter-autoroll@skia.org Roll Skia from 6035cb5a879c to 3b50199d27bb (1 revision) (flutter/engine#56300 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Skia from 696528fe7d07 to 6035cb5a879c (1 revision) (flutter/engine#56299 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 32bebf22c765 to 09c8281e66cc (1 revision) (flutter/engine#56298 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 11:33:25 +00:00
Valentin Vignal
fd259714d4
Add test for interactive_viewer.transformation_controller.0.dart ( #157986 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/interactive_viewer/interactive_viewer.transformation_controller.0.dart`
2024-11-01 10:37:59 +00:00
engine-flutter-autoroll
4f8ab5bfe2
Roll Flutter Engine from d7e928911ac2 to bacc5e1e73b7 (1 revision) ( #157982 )
...
d7e928911a...bacc5e1e73skia-flutter-autoroll@skia.org Roll Skia from a5e3b3556739 to 696528fe7d07 (1 revision) (flutter/engine#56296 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 07:45:19 +00:00
Valentin Vignal
43bb6186d2
Add test for notification.0.dart ( #157909 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/notification_listener/notification.0.dart`
2024-11-01 06:41:13 +00:00
Paolo Lammens
d836ca5a68
performance: Override .elementAt in CachingIterable ( #152477 )
...
Add a more efficient override of `Iterable.elementAt` in `CachingIterable`.
Closes #152476
2024-11-01 04:50:17 +00:00
engine-flutter-autoroll
cadac6bca3
Roll Flutter Engine from cd46383cd55e to d7e928911ac2 (4 revisions) ( #157978 )
...
cd46383cd5...d7e928911amatanlurey@users.noreply.github.com Further de-duplicate and refactor `build_plan_test`. (flutter/engine#56284 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from bd93105c4fb6 to 32bebf22c765 (2 revisions) (flutter/engine#56290 )
2024-11-01 jason-simmons@users.noreply.github.com Remove the quiet flag from invocations of run_tests.py on macOS CI builders (flutter/engine#56288 )
2024-11-01 jason-simmons@users.noreply.github.com [Impeller] Fix handling of destination opacity in advanced blends (flutter/engine#56251 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 04:44:32 +00:00
engine-flutter-autoroll
b18d34c574
Roll Flutter Engine from bb77cf867aef to cd46383cd55e (11 revisions) ( #157972 )
...
bb77cf867a...cd46383cd530870216+gaaclarke@users.noreply.github.com reland: Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56286 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Skia from 9168ad248c69 to a5e3b3556739 (1 revision) (flutter/engine#56283 )
2024-10-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Allow BufferViews to have non-owning references to DeviceBuffers (#56224 )" (flutter/engine#56285 )
2024-10-31 chris@bracken.jp macOS: migrate third_party/accessibility to ARC (flutter/engine#56281 )
2024-10-31 30870216+gaaclarke@users.noreply.github.com Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56224 )
2024-10-31 flar@google.com [Impeller] Do not use fast mask blur for stroked shapes (flutter/engine#56247 )
2024-10-31 jonahwilliams@google.com [Impeller] make desktop GL render. (flutter/engine#56274 )
2024-10-31 matanlurey@users.noreply.github.com Vastly rewrite and expand `et/README.md` (flutter/engine#56250 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dDWvmfG4AxSEs0BQA... to MjcuejuzYvYGobbFM... (flutter/engine#56280 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Dart SDK from f3e3dc44b1dc to bd93105c4fb6 (2 revisions) (flutter/engine#56278 )
2024-10-31 chris@bracken.jp Embedder: migrate Metal surfaces to ARC (flutter/engine#56279 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from dDWvmfG4AxSE to MjcuejuzYvYG
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 02:53:17 +00:00
Matan Lurey
d77d7c3f36
Add a warning/additional handlers for parsingsynthetic-package. ( #157934 )
...
Closes https://github.com/flutter/flutter/issues/157928 .
Closes https://github.com/flutter/flutter/issues/157929 .
| Condition | Expectation |
| --------- | ------------ |
| `synthetic-packages: true` && `--implicit-pubpsec-resolution` | Generates `flutter_gen` with warning.
| `<no synthetic-packages key>` && `--implicit-pubspec-resolution` | Generates `flutter_gen` with warning.
| `synthetic-packages: false` && `--implicit-pubpsec-resolution` | Does not generate `flutter_gen`.
| `synthetic-packages: true` && `--no-implicit-pubpsec-resolution` | Error.
| `<no synthetic-packages key>` && `--no-implicit-pubspec-resolution` | Does not generate `flutter_gen`.
| `synthetic-packages: false` && `--no-implicit-pubpsec-resolution` | Generates `flutter_gen` with warning.
2024-11-01 00:45:07 +00:00
engine-flutter-autoroll
088e3577ab
Roll Flutter Engine from f2154ef3e31c to bb77cf867aef (6 revisions) ( #157960 )
...
f2154ef3e3...bb77cf867achris@bracken.jp iOS: migrate Metal testing types to ARC (flutter/engine#56156 )
2024-10-31 chris@bracken.jp iOS,macOS: migrate shell/gpu to ARC (flutter/engine#56157 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Skia from 3c628426f85f to 9168ad248c69 (3 revisions) (flutter/engine#56272 )
2024-10-31 jonahwilliams@google.com [Impeller] Reland: disable AHBs on devices that were upgraded to 29. (flutter/engine#56221 )
2024-10-31 matanlurey@users.noreply.github.com Add `timeout` to `local_engine`. (flutter/engine#56271 )
2024-10-31 matanlurey@users.noreply.github.com Refactor `ArgParser.usage` tests for `BuildPlan` to reduce duplication. (flutter/engine#56254 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 22:53:24 +00:00
Matan Lurey
8d7513efb6
Renames injectBuildTimePluginFilesForWebPlatform and removes unused named parameter. ( #157944 )
...
Closes https://github.com/flutter/flutter/issues/157943 .
---------
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
2024-10-31 15:48:23 -07:00
Jonah Williams
1050959d19
[flutter_driver] use mostly public screenshot API. ( #157888 )
...
Instead of completely private. This has been broken for Impeller for years, which shows how much this method is getting used.
Fixes https://github.com/flutter/flutter/issues/130461
2024-10-31 21:31:07 +00:00
Sarbagya Dhaubanjar
19d8fbc6f4
Made insetPadding configurable for Date Picker Dialog ( #155651 )
...
This PR adds following properties to the **DatePickerDialog**:
- `insetPadding`
2024-10-31 21:07:08 +00:00
