83003 Commits

Author SHA1 Message Date
Bruno Leroux
97ca57cf08
Fix DropdownButtonFormField clips text when large text scale is used (#159975)
## Description

This PR fixes `DropdownButtonFormField` text being clipped when using a
large text scale.

Before:


![image](https://github.com/user-attachments/assets/6c4deed2-eb61-4c0a-912e-dba364013038)

After:


![image](https://github.com/user-attachments/assets/1dee5cda-9885-47c1-92a6-afbbc2312266)


This extend the fix from https://github.com/flutter/flutter/pull/107201
which does not work properly with Material 3 (because of
TextStyle.height being set for M3 default text styles).

## Related Issue

Fixes [DropdownButtonFormField clips text when large text scale is used
and useMaterial3 is
true](https://github.com/flutter/flutter/issues/159971)

## Tests

Adds 1 test.
Updates 1 test.
2025-01-23 05:38:20 +00:00
Matan Lurey
9c960ff7da
Add a better error message when flutter drive --target is used incorrectly. (#162023)
Closes https://github.com/flutter/flutter/issues/62626.
2025-01-23 04:39:13 +00:00
Jason Simmons
1083356201
Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (#161822)
This reverts commit fe598e7d6f22e176499ede063572aafd9a9ef2b9.

This benchmark can be moved back to the Linux devicelab machines now
that https://dart-review.googlesource.com/c/sdk/+/403924 has landed.

Fixes https://github.com/flutter/flutter/issues/161620
2025-01-23 02:42:32 +00:00
Jonah Williams
948e31d19f
[Impeller] adjust coverage origin when rounding out SaveLayer bounds. (#161838)
Fixes https://github.com/flutter/flutter/issues/161374

When we round out the texture size for a saveLayer, also round out the
coverage so that the drawing origin is correct. Otherwise we may
actually cut off the top left edge of rendering.

---------

Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
2025-01-23 00:44:54 +00:00
Gray Mackall
64c808b7c8
Add a README with instructions for editing and running tests for the FGP (#161830)
Add a readme with some info.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
Co-authored-by: Reid Baker <hamilton.reid.baker@gmail.com>
2025-01-23 00:41:08 +00:00
auto-submit[bot]
c75d799dc6
Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (#162046)
<!-- start_original_pr_link -->
Reverts: flutter/flutter#161855
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: harryterkelsen
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: causing test failures on `linux_unopt` shard


https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1044163/infra
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: flar
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jonahwilliams}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Handles the impeller unittests line in
https://github.com/flutter/flutter/issues/161456

This PR is focused on the unit tests in Impeller. There are still some
uses in other non-test areas which will be handled in a separate PR.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-01-23 00:04:48 +00:00
Siva
b2f515f45e
Roll Dart to Version 3.8.0-24.0.dev (#162035)
https://dart.googlesource.com/sdk.git/+log/c390aae86c09552b8a2852e87078f477ad09841b..3fc177bfd7016bcfa2781f43f1aa04d4cbc1351f


[3fc177b](https://dart.googlesource.com/sdk.git/+/3fc177bfd7016bcfa2781f43f1aa04d4cbc1351f)
[Version
3.8.0-24.0.dev](https://dart.googlesource.com/sdk.git/+/3fc177bfd7016bcfa2781f43f1aa04d4cbc1351f)
by Dart CI · 30 minutes ago
[dev](https://dart.googlesource.com/sdk.git/+/refs/heads/dev)
[3.8.0-24.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-24.0.dev)

[bb0cabb](https://dart.googlesource.com/sdk.git/+/bb0cabbc1a99c148b47dbc2e37aa410d293d84a5)
[[element model] migrate
`subtype_test`](https://dart.googlesource.com/sdk.git/+/bb0cabbc1a99c148b47dbc2e37aa410d293d84a5)
by pq · 2 hours ago
[lkgr](https://dart.googlesource.com/sdk.git/+/refs/heads/lkgr)

[26f2206](https://dart.googlesource.com/sdk.git/+/26f220614cf363293934610146cd1529a550a0e6)
[[fix] fix `unnecessary_ignore` eol ignore
corrections](https://dart.googlesource.com/sdk.git/+/26f220614cf363293934610146cd1529a550a0e6)
by pq · 3 hours ago

[d9c7559](https://dart.googlesource.com/sdk.git/+/d9c75594637be616b01880fefa7a48f7b5379547)
[Version
3.8.0-23.0.dev](https://dart.googlesource.com/sdk.git/+/d9c75594637be616b01880fefa7a48f7b5379547)
by Dart CI · 5 hours ago
[3.8.0-23.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-23.0.dev)

[fca0324](https://dart.googlesource.com/sdk.git/+/fca032461a1f13b0313cc72e8c1a78bc421a5c5e)
[[VM/Runtime] Turn on isolate group metrics gathering in product
mode](https://dart.googlesource.com/sdk.git/+/fca032461a1f13b0313cc72e8c1a78bc421a5c5e)
by asiva · 5 hours ago

[ae92595](https://dart.googlesource.com/sdk.git/+/ae92595e134493870d4d709f19cf1b9176ef4563)
[[cfe] MethodEncodingStrategy and
PropertyEncodingStrategy](https://dart.googlesource.com/sdk.git/+/ae92595e134493870d4d709f19cf1b9176ef4563)
by Johnni Winther · 6 hours ago

[b22c5c2](https://dart.googlesource.com/sdk.git/+/b22c5c214717008101a4796a76b2abf9a4144b8f)
[Version
3.8.0-22.0.dev](https://dart.googlesource.com/sdk.git/+/b22c5c214717008101a4796a76b2abf9a4144b8f)
by Dart CI · 9 hours ago
[3.8.0-22.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-22.0.dev)

[ca540d8](https://dart.googlesource.com/sdk.git/+/ca540d8620d078962767b439951a8ea4681f7bcd)
[[CFE] Fix presubmit compile-and-lint when all changed files are
filtered
away](https://dart.googlesource.com/sdk.git/+/ca540d8620d078962767b439951a8ea4681f7bcd)
by Jens Johansen · 11 hours ago

[9233056](https://dart.googlesource.com/sdk.git/+/9233056319e96d0bfb242cebeddc9204f00f5f11)
[[dart2wasm] Move _Utf8Decoder.convertGeneral to JSCM
patch](https://dart.googlesource.com/sdk.git/+/9233056319e96d0bfb242cebeddc9204f00f5f11)
by Ömer Sinan Ağacan · 12 hours ago

[cc5612e](https://dart.googlesource.com/sdk.git/+/cc5612e322674fe96edf65bf7a693a1253022ca7)
[Fix: False Positive
"include_file_not_found"](https://dart.googlesource.com/sdk.git/+/cc5612e322674fe96edf65bf7a693a1253022ca7)
by Rohit · 16 hours ago
[base](https://dart.googlesource.com/sdk.git/+/refs/heads/base)

[5e95423](https://dart.googlesource.com/sdk.git/+/5e95423ddb6f8129ee4031492f713e6e3be71655)
[Version
3.8.0-21.0.dev](https://dart.googlesource.com/sdk.git/+/5e95423ddb6f8129ee4031492f713e6e3be71655)
by Dart CI · 17 hours ago
[3.8.0-21.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-21.0.dev)

[5ec1002](https://dart.googlesource.com/sdk.git/+/5ec1002eff41778ee46a91048f3b131106992215)
[[ddc] Port library show/hide hot reload
tests](https://dart.googlesource.com/sdk.git/+/5ec1002eff41778ee46a91048f3b131106992215)
by Nicholas Shahan · 20 hours ago

[eb3f266](https://dart.googlesource.com/sdk.git/+/eb3f266dc37a303713f1dad358b19c4f27cc0478)
[Version
3.8.0-20.0.dev](https://dart.googlesource.com/sdk.git/+/eb3f266dc37a303713f1dad358b19c4f27cc0478)
by Dart CI · 21 hours ago
[3.8.0-20.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-20.0.dev)

[1a48649](https://dart.googlesource.com/sdk.git/+/1a486499bf73ee5b007abbe522b94869a1f36d02)
[[dartdev] Fix ia32 invocation of dart2js from 'compile js'
command.](https://dart.googlesource.com/sdk.git/+/1a486499bf73ee5b007abbe522b94869a1f36d02)
by asiva · 22 hours ago

[9b7bb9d](https://dart.googlesource.com/sdk.git/+/9b7bb9df90b7bf866fa15f01bf28db0b4a2b303a)
[Fix "the the"
typo](https://dart.googlesource.com/sdk.git/+/9b7bb9df90b7bf866fa15f01bf28db0b4a2b303a)
by Mohamed Abdelaal · 22 hours ago

[e1eade6](https://dart.googlesource.com/sdk.git/+/e1eade612a2e5dea53be0b77d9d970fe1865971b)
[[deps] Roll
dart-lang/native](https://dart.googlesource.com/sdk.git/+/e1eade612a2e5dea53be0b77d9d970fe1865971b)
by Daco Harkes · 23 hours ago

[eba7e49](https://dart.googlesource.com/sdk.git/+/eba7e490316c0199f12663828938e94881a7d123)
[[analyzer] Change VariableElementImpl.type setter to
TypeImpl.](https://dart.googlesource.com/sdk.git/+/eba7e490316c0199f12663828938e94881a7d123)
by Paul Berry · 24 hours ago

[751fe13](https://dart.googlesource.com/sdk.git/+/751fe131e923b55f18e05c003134d9f1c36f2494)
[[analyzer] Use TypeImpl for type annotation
types.](https://dart.googlesource.com/sdk.git/+/751fe131e923b55f18e05c003134d9f1c36f2494)
by Paul Berry · 26 hours ago

[cf09edd](https://dart.googlesource.com/sdk.git/+/cf09edd35e780cdcb38e599327bd9164c87d54a8)
[analyzer_plugin: Bump version to
0.13.0](https://dart.googlesource.com/sdk.git/+/cf09edd35e780cdcb38e599327bd9164c87d54a8)
by Sam Rawlins · 26 hours ago
2025-01-22 22:30:18 +00:00
Nate Wilson
06c3c93d72
const AnimationStyle (#160564)
[**AnimationStyle**](https://main-api.flutter.dev/flutter/animation/AnimationStyle-class.html)
is an
[`@immutable`](https://main-api.flutter.dev/flutter/meta/immutable-constant.html)
class with all `final` fields.

This pull request gives it a `const` constructor.

<br>

related: #160563
2025-01-22 21:52:11 +00:00
Matan Lurey
30f4fecfeb
Add piping and bringup nodes for _vulkan and _opengles suites. (#162020)
Towards https://github.com/flutter/flutter/issues/161333.

This adds the initial `.ci.yaml` configuration (marked `bringup: true`),
without changing the existing shard to avoid the problems we ran into
last time when I renamed the shard atomically, as well as piping for
providing context in which the test will run (Vulkan or OpenGLES), which
can't be introspected in the _running_ app.

In a follow-up PR I'll:

- Edit `AndroidManifest.xml` before the suite, setting `ImpellerBackend`
appropriately
- Move the bringup nodes to presubmit
- Delete the existing (legacy) node
2025-01-22 21:06:10 +00:00
Jim Graham
e0392194d3
[Impeller] Migrate unit tests off of Skia geometry classes (#161855)
Handles the impeller unittests line in
https://github.com/flutter/flutter/issues/161456

This PR is focused on the unit tests in Impeller. There are still some
uses in other non-test areas which will be handled in a separate PR.
2025-01-22 20:27:06 +00:00
Matan Lurey
cc9c13e009
Experiment with a files-changed.json per PR (#161788)
This is an experiment to determine what the wall time of a (minimal)
"upload a JSON file describing files changed".

We are looking for this to take (low) single digit minutes, because if
we use this file (and expand it to become a build plan), it will block
almost _all_ other actions, and will likely get longer as we add more
complex logic and checks. Here's hoping!
2025-01-22 20:22:30 +00:00
Robert Ancell
2d3beadffe
Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (#161925)
There can only be one handler that is shared between the views.

Move event redispatch matcher back into FlKeyboardManager - if a
redispatched event was moved between views due to a focus change it
would not be matched against.
2025-01-22 20:07:11 +00:00
engine-flutter-autoroll
391fecdfac
Roll Packages from e8f1f63bc3b7 to 3d3ab7bcb07e (1 revision) (#162019)
e8f1f63bc3...3d3ab7bcb0

2025-01-21 stuartmorgan@google.com [tool] Allow blank lines in federated
package changes (flutter/packages#8468)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-01-22 20:01:45 +00:00
chunhtai
a0cb28b831
Adds cupertino picker semantics test (#161768)
Adds a test

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-22 19:54:21 +00:00
Mouad Debbar
c289c638fe
[web] Remove deprecated web-only APIs from dart:ui (#161775)
These web-only APIs have been moved to `dart:ui_web` ages ago
(https://github.com/flutter/flutter/issues/126831).

Closes https://github.com/flutter/flutter/issues/127395
2025-01-22 19:51:07 +00:00
Kishan Rathore
a1d02b657e
fix: Add enabled property for search anchor named constructor (#161468)
fix: Add enabled property for search anchor named constructor
Fixes: #161063 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
2025-01-22 19:35:55 +00:00
flutter-pub-roller-bot
ad52a6630d
Roll pub packages (#162015)
This PR was generated by `flutter update-packages --force-upgrade`.
2025-01-22 19:29:14 +00:00
Mouad Debbar
8752f481c9
[web] Remove spam from test output (#161774)
| Before | After |
|-|-|
|
![image](https://github.com/user-attachments/assets/30689c9e-ae99-41ff-bbf6-cb4b0f2c1a6a)
|
![image](https://github.com/user-attachments/assets/a73a7536-cade-475e-9e16-96eda73fc6f5)
|
2025-01-22 19:22:59 +00:00
Chikamatsu Kazuya
c8e34e067c
Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (#161577)
Original PR: #160241 (reverted in #161555 due to regression ), closes
#29068

In addition to the original PR, this includes a fix for the integration
test failure of
[flutter_gallery/transitions_perf_e2e](1b0441c18a/dev/integration_tests/flutter_gallery/test_driver).
Error log is
[here](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8725826401212583777/+/u/run_flutter_gallery__transition_perf_e2e_ios/stdout).
Tested locally on iOS real device and confirmed it passes.

It seems that the next operation of the test was performed before the
page animation was finished because the PR makes the page transition
duration longer.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-22 19:13:01 +00:00
Matan Lurey
dc42bcf2ec
Make font-subset a standalone run_tests.py variant. (#162016)
Closes https://github.com/flutter/flutter/issues/161538.
2025-01-22 19:12:56 +00:00
Krzysztof Czarnota
e33e4f0476
Enabled provisioning updates and device registration during building xcarchive. (#159622)
Provisioning updates and device registration were disabled when
development team was specified in the xcode project. This lead to build
error when provisioning profile was not present. Now provisioning
updates and device registration are enabled when tool builds codesigned
archive. This will allow to build the iOS version of app without
launching xcode in order to enforce provisioning profile updates.

Issues fixed by this PR.
* https://github.com/flutter/flutter/issues/139212
* https://github.com/flutter/flutter/issues/113977
* https://github.com/flutter/flutter/issues/121702 (partly because
author asks for possibility of passing xcode flags like
allowProvisioningUpdates)



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] All existing and new tests are passing.
2025-01-22 18:54:08 +00:00
Mouad Debbar
f2e6dbc567
[web] Remove HTML from bots, test suites and e2e tests (#161537)
- Stop running framework tests in HTML mode in CI.
- Update some READMEs
- Remove HTML-specific integration tests
2025-01-22 18:50:46 +00:00
Matan Lurey
74ab593738
Expand the .ci.yaml and builder.json linter (#161991)
Closes https://github.com/flutter/flutter/issues/161823.

Other than the integration test included, example output looks like
this:

```dart
# Assuming you are in $ENGINE/src/flutter
% dart tools/pkg/engine_build_configs/bin/check.dart --help
-v, --verbose                                  Enable noisier diagnostic output
-h, --help                                     Output usage information.
    --engine-src-path=</path/to/engine/src>    (defaults to "/Users/matanl/Developer/flutter/engine/src")

% dart tools/pkg/engine_build_configs/bin/check.dart       
 Loaded build configs under ci/builders
 .ci.yaml at .ci.yaml is valid
 All configuration files are valid
 All builds within a builder are uniquely named
 All build names must have a conforming prefix
 All builder files conform to release_build standards
```

I allow-listed a single case that needs to be moved, but I think this
provides value already.
2025-01-22 18:41:02 +00:00
Seth Fuller
20b1565e52
Fix incorrect [enabled] documentation (#161650)
This PR updates the documentation to align with the current behavior of
the InputDecorator. When [enabled] is false, [helperText],[errorText],
and [counterText] are actually still displayed. So, this updates the
docs to align with current functionality.

Fixes #161602

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Mitchell Goodwin <58190796+MitchellGoodwin@users.noreply.github.com>
2025-01-22 18:32:24 +00:00
Matan Lurey
23c7ac18e9
Add windows_host_engine_test. (#161992)
Towards https://github.com/flutter/flutter/issues/161990.
2025-01-22 18:14:21 +00:00
Siva
a17128274d
Roll Dart to version Version 3.8.0-19.0.dev (#161989)
https://dart.googlesource.com/sdk.git/+log/f11b24d1c54093830e8ed1a2239504eba775d9da..c390aae86c09552b8a2852e87078f477ad09841b


[c390aae](https://dart.googlesource.com/sdk.git/+/c390aae86c09552b8a2852e87078f477ad09841b)
[Version
3.8.0-19.0.dev](https://dart.googlesource.com/sdk.git/+/c390aae86c09552b8a2852e87078f477ad09841b)
by Dart CI · 5 hours ago
[3.8.0-19.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-19.0.dev)

[6c5fe06](https://dart.googlesource.com/sdk.git/+/6c5fe06d7019dafe5a48b196e24ee625d4c93ed0)
[DAS plugins: Add an SDK constraint to generated
pubspec](https://dart.googlesource.com/sdk.git/+/6c5fe06d7019dafe5a48b196e24ee625d4c93ed0)
by Sam Rawlins · 7 hours ago

[c3dd74b](https://dart.googlesource.com/sdk.git/+/c3dd74ba055bda755450a8812ea15e44443ae715)
[[infra] Split build steps for vm-win-{debug,release}-arm64 to avoid
timeouts.](https://dart.googlesource.com/sdk.git/+/c3dd74ba055bda755450a8812ea15e44443ae715)
by Ryan Macnak · 7 hours ago

[6ce66e0](https://dart.googlesource.com/sdk.git/+/6ce66e07db99d8d3dbc2761848151833c4858ef6)
[Roll Fuchsia Test Scripts from 3SIihrAqX5c1w3ep7... to
gUHjJPMGJW0yseyRp...](https://dart.googlesource.com/sdk.git/+/6ce66e07db99d8d3dbc2761848151833c4858ef6)
by DEPS Autoroller · 7 hours ago

[3c88dc0](https://dart.googlesource.com/sdk.git/+/3c88dc0119147f1fd9288576cfd792575a3e2ee3)
[Version
3.8.0-18.0.dev](https://dart.googlesource.com/sdk.git/+/3c88dc0119147f1fd9288576cfd792575a3e2ee3)
by Dart CI · 9 hours ago
[3.8.0-18.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-18.0.dev)

[74aa17d](https://dart.googlesource.com/sdk.git/+/74aa17dd3eb584f59790d1b07d021f3e04afeb57)
[[dart2wasm] Emit `unreachable` instructions after calls that never
return](https://dart.googlesource.com/sdk.git/+/74aa17dd3eb584f59790d1b07d021f3e04afeb57)
by Martin Kustermann · 11 hours ago

[41a8e81](https://dart.googlesource.com/sdk.git/+/41a8e8147f51c208363dc98c44302d9abd632199)
[[CoreLib]
Iterable.withIterator](https://dart.googlesource.com/sdk.git/+/41a8e8147f51c208363dc98c44302d9abd632199)
by Dhikshith Reddy · 12 hours ago

[57d877f](https://dart.googlesource.com/sdk.git/+/57d877ff2e28bc0bc74a463c7be2ca1e7d178822)
[[dart2wasm] Omit details in TypeErrors in --minify
mode](https://dart.googlesource.com/sdk.git/+/57d877ff2e28bc0bc74a463c7be2ca1e7d178822)
by Martin Kustermann · 12 hours ago

[e93effd](https://dart.googlesource.com/sdk.git/+/e93effd3d28586e196d949cb587b144ea3453370)
[Version
3.8.0-17.0.dev](https://dart.googlesource.com/sdk.git/+/e93effd3d28586e196d949cb587b144ea3453370)
by Dart CI · 13 hours ago
[3.8.0-17.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-17.0.dev)

[358ae88](https://dart.googlesource.com/sdk.git/+/358ae88ba6ae0d0d4f87a640dbc65552f4c5f0f4)
[Move pkg/kernel to language version
3.6](https://dart.googlesource.com/sdk.git/+/358ae88ba6ae0d0d4f87a640dbc65552f4c5f0f4)
by Sigurd Meldgaard · 15 hours ago

[7f46b33](https://dart.googlesource.com/sdk.git/+/7f46b33019323fa903fc551c38e9956fc5a8afaa)
[[_fe_analyzer_shared] Return the shortest
witness](https://dart.googlesource.com/sdk.git/+/7f46b33019323fa903fc551c38e9956fc5a8afaa)
by Johnni Winther · 17 hours ago

[defb4e2](https://dart.googlesource.com/sdk.git/+/defb4e29760762911a144fa313e779032afe9b21)
[Version
3.8.0-16.0.dev](https://dart.googlesource.com/sdk.git/+/defb4e29760762911a144fa313e779032afe9b21)
by Dart CI · 25 hours ago
[3.8.0-16.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-16.0.dev)

[481a7fd](https://dart.googlesource.com/sdk.git/+/481a7fde3706505c0bfed79022c8a75e3e3811f6)
[Version
3.8.0-15.0.dev](https://dart.googlesource.com/sdk.git/+/481a7fde3706505c0bfed79022c8a75e3e3811f6)
by Dart CI · 29 hours ago
[3.8.0-15.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-15.0.dev)

[762a4c7](https://dart.googlesource.com/sdk.git/+/762a4c7e9147c028b28723e8fb2e04a717010c97)
[[deps] Roll
dart-lang/native](https://dart.googlesource.com/sdk.git/+/762a4c7e9147c028b28723e8fb2e04a717010c97)
by Daco Harkes · 31 hours ago

[667730a](https://dart.googlesource.com/sdk.git/+/667730a0b5874760b23fac3c16b6238c1f88ef09)
[[DAS] Fixes import prefix
highlighting](https://dart.googlesource.com/sdk.git/+/667730a0b5874760b23fac3c16b6238c1f88ef09)
by FMorschel · 31 hours ago

[bf1e8ae](https://dart.googlesource.com/sdk.git/+/bf1e8aedb807036c97fac454dc3f10e7757fbeb3)
[Version
3.8.0-14.0.dev](https://dart.googlesource.com/sdk.git/+/bf1e8aedb807036c97fac454dc3f10e7757fbeb3)
by Dart CI · 33 hours ago
[3.8.0-14.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-14.0.dev)

[f2929bf](https://dart.googlesource.com/sdk.git/+/f2929bfd51f9b84cd9ac286ff4ce098a1b848cfe)
[[dartwasm] Do not preserve details for errors in --minify, move
throwing code to (not inlined) slow
path](https://dart.googlesource.com/sdk.git/+/f2929bfd51f9b84cd9ac286ff4ce098a1b848cfe)
by Martin Kustermann · 2 days ago

[2611220](https://dart.googlesource.com/sdk.git/+/261122009647f7aa504371db27b8542b94ce35b8)
[Version
3.8.0-13.0.dev](https://dart.googlesource.com/sdk.git/+/261122009647f7aa504371db27b8542b94ce35b8)
by Dart CI · 2 days ago
[3.8.0-13.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-13.0.dev)

[a565406](https://dart.googlesource.com/sdk.git/+/a565406ecca2fb1be648e5532cd24dcf21d45012)
[[cfe] Implement a formal list helper as an extension
method](https://dart.googlesource.com/sdk.git/+/a565406ecca2fb1be648e5532cd24dcf21d45012)
by Chloe Stefantsova · 2 days ago

[d200098](https://dart.googlesource.com/sdk.git/+/d2000980d4a5508bace7c91e9cc0ec5904e4ec15)
[Bump pub to
710265bae23ad5860f33287fba10b5c369f19a93](https://dart.googlesource.com/sdk.git/+/d2000980d4a5508bace7c91e9cc0ec5904e4ec15)
by Sigurd Meldgaard · 2 days ago

[dcd410e](https://dart.googlesource.com/sdk.git/+/dcd410efd490f90b49bc6768d94104d226154167)
[[analyzer][cfe] Remove TypeStructure variable from shared
classes](https://dart.googlesource.com/sdk.git/+/dcd410efd490f90b49bc6768d94104d226154167)
by Chloe Stefantsova · 2 days ago

[e8fdee8](https://dart.googlesource.com/sdk.git/+/e8fdee8d5b35f2d1ab6ed9b0a85baa2f33280908)
[[cfe] Remove
FieldBuilder](https://dart.googlesource.com/sdk.git/+/e8fdee8d5b35f2d1ab6ed9b0a85baa2f33280908)
by Johnni Winther · 2 days ago

[9b4b369](https://dart.googlesource.com/sdk.git/+/9b4b3693ba36c02c1f0e6d3c5dce6beda8639cb2)
[[tfa] Propagate double
constants](https://dart.googlesource.com/sdk.git/+/9b4b3693ba36c02c1f0e6d3c5dce6beda8639cb2)
by Ömer Sinan Ağacan · 2 days ago

[799dc28](https://dart.googlesource.com/sdk.git/+/799dc2823874079a08cbe514c8062af4d60ecf69)
[[cfe] Create enum values through
SourcePropertyBuilder](https://dart.googlesource.com/sdk.git/+/799dc2823874079a08cbe514c8062af4d60ecf69)
by Johnni Winther · 2 days ago

[8f94144](https://dart.googlesource.com/sdk.git/+/8f941449242fbe20802a6f778013931c65a01c07)
[[tfa] Propagate int and string constants in
conditionals](https://dart.googlesource.com/sdk.git/+/8f941449242fbe20802a6f778013931c65a01c07)
by Ömer Sinan Ağacan · 2 days ago

[655cdcb](https://dart.googlesource.com/sdk.git/+/655cdcb11d1f4d7bfe2f64fedb759a3579ab4b45)
[[cfe] Move formal inference to SourceFunctionBuilderImpl
hierarchy](https://dart.googlesource.com/sdk.git/+/655cdcb11d1f4d7bfe2f64fedb759a3579ab4b45)
by Chloe Stefantsova · 2 days ago

[7d6ba73](https://dart.googlesource.com/sdk.git/+/7d6ba73722451baf23e0b5dccb12dc0c457d5375)
[Version
3.8.0-12.0.dev](https://dart.googlesource.com/sdk.git/+/7d6ba73722451baf23e0b5dccb12dc0c457d5375)
by Dart CI · 2 days ago
[3.8.0-12.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-12.0.dev)

[7198fb9](https://dart.googlesource.com/sdk.git/+/7198fb9bacfbdb2611a75802bf7ef5074539d4b1)
[[analyzer] Use TypeImpl for context
types.](https://dart.googlesource.com/sdk.git/+/7198fb9bacfbdb2611a75802bf7ef5074539d4b1)
by Paul Berry · 2 days ago

[f4543cb](https://dart.googlesource.com/sdk.git/+/f4543cb3a42c7329fa41e7b5f6732c43a7db6ae9)
[Version
3.8.0-11.0.dev](https://dart.googlesource.com/sdk.git/+/f4543cb3a42c7329fa41e7b5f6732c43a7db6ae9)
by Dart CI · 3 days ago
[3.8.0-11.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-11.0.dev)

[eb69196](https://dart.googlesource.com/sdk.git/+/eb691963f0181a694b0e705c7bce159eba75bb84)
[Fix documentation on
`Process.run`](https://dart.googlesource.com/sdk.git/+/eb691963f0181a694b0e705c7bce159eba75bb84)
by Daniel Luz · 3 days ago

[cabf47d](https://dart.googlesource.com/sdk.git/+/cabf47dcf695afc0877c5ea6719b1983ab6666f2)
[Version
3.8.0-10.0.dev](https://dart.googlesource.com/sdk.git/+/cabf47dcf695afc0877c5ea6719b1983ab6666f2)
by Dart CI · 3 days ago
[3.8.0-10.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-10.0.dev)

[dd9a061](https://dart.googlesource.com/sdk.git/+/dd9a061f4e6ca3db3b81b8c274bd50b631045bde)
[[analysis_server] Enable "EditArgument" request to work over the legacy
protocol](https://dart.googlesource.com/sdk.git/+/dd9a061f4e6ca3db3b81b8c274bd50b631045bde)
by Danny Tuppeny · 3 days ago

[b908274](https://dart.googlesource.com/sdk.git/+/b908274b8cab788936c10fa7db78402f169228be)
[[analysis_server] Minor refactors to enable running EditArgument
through legacy
server](https://dart.googlesource.com/sdk.git/+/b908274b8cab788936c10fa7db78402f169228be)
by Danny Tuppeny · 3 days ago

[7dc5a42](https://dart.googlesource.com/sdk.git/+/7dc5a42d5eaf3a2017e030cfca01372c5d832deb)
[[analyzer] Change substitute methods to return
`TypeImpl`.](https://dart.googlesource.com/sdk.git/+/7dc5a42d5eaf3a2017e030cfca01372c5d832deb)
by Paul Berry · 3 days ago

[b069a13](https://dart.googlesource.com/sdk.git/+/b069a139164339a6c78e872e2f454daf81211a25)
[[analyzer] Use `TypeImpl` for expression
types.](https://dart.googlesource.com/sdk.git/+/b069a139164339a6c78e872e2f454daf81211a25)
by Paul Berry · 3 days ago

[3fc19db](https://dart.googlesource.com/sdk.git/+/3fc19db1667817751cbc933630c568689ecbc187)
[Version
3.8.0-9.0.dev](https://dart.googlesource.com/sdk.git/+/3fc19db1667817751cbc933630c568689ecbc187)
by Dart CI · 4 days ago
[3.8.0-9.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-9.0.dev)

[c4c1dae](https://dart.googlesource.com/sdk.git/+/c4c1dae574de82ec5148f1d15a7d58b59e69d2a0)
[Version
3.8.0-8.0.dev](https://dart.googlesource.com/sdk.git/+/c4c1dae574de82ec5148f1d15a7d58b59e69d2a0)
by Dart CI · 4 days ago
[3.8.0-8.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-8.0.dev)

[f61ecec](https://dart.googlesource.com/sdk.git/+/f61ecec6f511c06413e9a4f0cbbe71d13f3df45a)
[[analyzer] Change return type of some TypeSystemImpl
methods.](https://dart.googlesource.com/sdk.git/+/f61ecec6f511c06413e9a4f0cbbe71d13f3df45a)
by Paul Berry · 4 days ago

[54981a4](https://dart.googlesource.com/sdk.git/+/54981a484b5f22df6b11551a758bf3c8c4044779)
[[fix] add `remove_comment` producer and ignore bulk
fixes](https://dart.googlesource.com/sdk.git/+/54981a484b5f22df6b11551a758bf3c8c4044779)
by pq · 4 days ago

[8b824d7](https://dart.googlesource.com/sdk.git/+/8b824d7958c31fc98553b98715230d1917f91e27)
[Version
3.8.0-7.0.dev](https://dart.googlesource.com/sdk.git/+/8b824d7958c31fc98553b98715230d1917f91e27)
by Dart CI · 4 days ago
[3.8.0-7.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-7.0.dev)

[95f0052](https://dart.googlesource.com/sdk.git/+/95f00522676dff03f64fc715cb1835ad451faa4c)
[[analysis_server] Add tests for unversioned documents for
EditableArguments](https://dart.googlesource.com/sdk.git/+/95f00522676dff03f64fc715cb1835ad451faa4c)
by Danny Tuppeny · 4 days ago

[7f5fc25](https://dart.googlesource.com/sdk.git/+/7f5fc253312b0acd2b9ab81c26f1207516cfb444)
[[analyzer] Fix horizontal type inference when there are record
types.](https://dart.googlesource.com/sdk.git/+/7f5fc253312b0acd2b9ab81c26f1207516cfb444)
by Paul Berry · 4 days ago

[da6dc03](https://dart.googlesource.com/sdk.git/+/da6dc03a15822d83d9180bd766c02d11aacdc06b)
[[dartdev] switch the analysis server to use VMInteropHandler instead
of](https://dart.googlesource.com/sdk.git/+/da6dc03a15822d83d9180bd766c02d11aacdc06b)
by asiva · 4 days ago

[3ab2e35](https://dart.googlesource.com/sdk.git/+/3ab2e359883f843d5ce5843efb3b73eb0494dfd1)
[Version
3.8.0-6.0.dev](https://dart.googlesource.com/sdk.git/+/3ab2e359883f843d5ce5843efb3b73eb0494dfd1)
by Dart CI · 4 days ago
[3.8.0-6.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-6.0.dev)

[4dba853](https://dart.googlesource.com/sdk.git/+/4dba853325c8fa3d843eb2ab87a5397d909498cc)
[[vm,compiler] Count DispatchTableCalls in call site count for inlining
heuristics](https://dart.googlesource.com/sdk.git/+/4dba853325c8fa3d843eb2ab87a5397d909498cc)
by Alexander Markov · 4 days ago

[240d87e](https://dart.googlesource.com/sdk.git/+/240d87e142922570eed2b87bcd48384f82c9aafa)
[[_fe_analyzer_shared] Change signature of extension type
constructors.](https://dart.googlesource.com/sdk.git/+/240d87e142922570eed2b87bcd48384f82c9aafa)
by Paul Berry · 4 days ago

[9b7dc37](https://dart.googlesource.com/sdk.git/+/9b7dc37843c8909d97ca30c8be13075177c3da54)
[[deps] Roll
dart-lang/native](https://dart.googlesource.com/sdk.git/+/9b7dc37843c8909d97ca30c8be13075177c3da54)
by Daco Harkes · 4 days ago

[3f90ef6](https://dart.googlesource.com/sdk.git/+/3f90ef63d9e490d593bef19078990b09903feaa9)
[[cfe] Add _ImplicitType to handle field and enum element
inference](https://dart.googlesource.com/sdk.git/+/3f90ef63d9e490d593bef19078990b09903feaa9)
by Johnni Winther · 4 days ago

[39d2653](https://dart.googlesource.com/sdk.git/+/39d2653200b5023334bd8ff8019e32137a35efec)
[[cfe] Provide inferred type context to initializing
formals](https://dart.googlesource.com/sdk.git/+/39d2653200b5023334bd8ff8019e32137a35efec)
by Chloe Stefantsova · 4 days ago

[d2ce8e7](https://dart.googlesource.com/sdk.git/+/d2ce8e71c8a6ae065896efee20b6385c4204d1de)
[[dart2wasm] Remove short input threshold to fall back to native UTF-8
decoder](https://dart.googlesource.com/sdk.git/+/d2ce8e71c8a6ae065896efee20b6385c4204d1de)
by Ömer Sinan Ağacan · 5 days ago

[849d104](https://dart.googlesource.com/sdk.git/+/849d104c032f7a008323d8c4123d07a5249ce21e)
[Version
3.8.0-5.0.dev](https://dart.googlesource.com/sdk.git/+/849d104c032f7a008323d8c4123d07a5249ce21e)
by Dart CI · 5 days ago
[3.8.0-5.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-5.0.dev)

[b93c826](https://dart.googlesource.com/sdk.git/+/b93c82613e4ca8277c1e576e8e4993398dfbcb40)
[[co19] Roll co19 to
e1fd1cf868e6fb778c426058737ad0c02122df33](https://dart.googlesource.com/sdk.git/+/b93c82613e4ca8277c1e576e8e4993398dfbcb40)
by Sergey G. Grekhov · 5 days ago

[8f815ce](https://dart.googlesource.com/sdk.git/+/8f815cec7929772bccb3864817035a49c3cb29bf)
[[docs] Update link to cherry pick issue
template](https://dart.googlesource.com/sdk.git/+/8f815cec7929772bccb3864817035a49c3cb29bf)
by Alexander Thomas · 5 days ago

[009d593](https://dart.googlesource.com/sdk.git/+/009d593b8a219f022b51468d00b822b28cd291e0)
[Version
3.8.0-4.0.dev](https://dart.googlesource.com/sdk.git/+/009d593b8a219f022b51468d00b822b28cd291e0)
by Dart CI · 5 days ago
[3.8.0-4.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-4.0.dev)

[5daaead](https://dart.googlesource.com/sdk.git/+/5daaead4c0c6e7ece70a960520e00d04f80b478c)
[Prepare to publish analyzer 7.2.0 and _fe_analyzer_shared
79.0.0](https://dart.googlesource.com/sdk.git/+/5daaead4c0c6e7ece70a960520e00d04f80b478c)
by Konstantin Shcheglov · 5 days ago

[ff3c2fd](https://dart.googlesource.com/sdk.git/+/ff3c2fd389c44d4f527dc31e9a71d85a30ad8257)
[Version
3.8.0-3.0.dev](https://dart.googlesource.com/sdk.git/+/ff3c2fd389c44d4f527dc31e9a71d85a30ad8257)
by Dart CI · 5 days ago
[3.8.0-3.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-3.0.dev)

[2f7670a](https://dart.googlesource.com/sdk.git/+/2f7670adccb2aeed971aa466b6d0c325443b965e)
[Elements. Use InterfaceElementImpl2 to create
InterfaceTypeImpl.](https://dart.googlesource.com/sdk.git/+/2f7670adccb2aeed971aa466b6d0c325443b965e)
by Konstantin Shcheglov · 5 days ago

[ae8d812](https://dart.googlesource.com/sdk.git/+/ae8d8122a18a343f609e209291fdeba36611e710)
[Version
3.8.0-2.0.dev](https://dart.googlesource.com/sdk.git/+/ae8d8122a18a343f609e209291fdeba36611e710)
by Dart CI · 5 days ago
[3.8.0-2.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-2.0.dev)

[9f465e5](https://dart.googlesource.com/sdk.git/+/9f465e5b6eab0dc3af96140189d4f0190e0ff925)
[[Migrate]
unused_local_elements_verifier.dart](https://dart.googlesource.com/sdk.git/+/9f465e5b6eab0dc3af96140189d4f0190e0ff925)
by Brian Wilkerson · 5 days ago

[f72576a](https://dart.googlesource.com/sdk.git/+/f72576af3be20ee63ce161330255754cc0910d23)
[analyzer_plugin: Introduce messages/types for plugin analysis
status](https://dart.googlesource.com/sdk.git/+/f72576af3be20ee63ce161330255754cc0910d23)
by Sam Rawlins · 5 days ago

[fa2f2dd](https://dart.googlesource.com/sdk.git/+/fa2f2ddf911ca06ed1d2bdf9fca58e4786eec94d)
[[fix] add `remove_ignore` correction
producer](https://dart.googlesource.com/sdk.git/+/fa2f2ddf911ca06ed1d2bdf9fca58e4786eec94d)
by pq · 5 days ago

[b115ec0](https://dart.googlesource.com/sdk.git/+/b115ec0b3446aad9aedc9e9d6b5fa9bc116eafd4)
[Roll BoringSSL from 822902749a59 to 5a2194f43d88 (13
revisions)](https://dart.googlesource.com/sdk.git/+/b115ec0b3446aad9aedc9e9d6b5fa9bc116eafd4)
by Alexander Aprelev · 5 days ago

[b3502f1](https://dart.googlesource.com/sdk.git/+/b3502f17cbd6cb5a35627e290894e82bacc1392b)
[[dart2js] Reduce redundant phis with
refinements](https://dart.googlesource.com/sdk.git/+/b3502f17cbd6cb5a35627e290894e82bacc1392b)
by Stephen Adams · 5 days ago

[de2131c](https://dart.googlesource.com/sdk.git/+/de2131cc4e1402b471d081d1de17d8aae9f3ae90)
[Fix missing `success-responses`
anchor](https://dart.googlesource.com/sdk.git/+/de2131cc4e1402b471d081d1de17d8aae9f3ae90)
by Mohamed Abdelaal · 5 days ago
2025-01-22 15:35:27 +00:00
Taha Tesser
9adbc51a80
Deprecate ThemeData.indicatorColor in favor of TabBarThemeData.indicatorColor (#160024)
Related to [☂️ Material Theme System
Updates](https://github.com/flutter/flutter/issues/91772)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-22 13:45:20 +00:00
Jonah Williams
b4a81cb6da
[Impeller] disable older xclipse gpu driver. (#161981)
Fixes https://github.com/flutter/flutter/issues/161334

The first version of the Xclipse series GPU has reported bugs,
unfortunately all versions of this GPU report the same driver version.
Instead we use the Vulkan version as a proxy, assuming that any newer
devices would not lower the supported Vulkan API level.


https://vulkan.gpuinfo.org/listreports.php?devicename=samsung+SM-S906B&platform=android
2025-01-22 03:55:31 +00:00
Jackson Gardner
299e157227
Merge changelog for 3.27.3 release (#161977)
Co-authored-by: Reid Baker <hamilton.reid.baker@gmail.com>
2025-01-22 01:11:02 +00:00
Robert Ancell
e53bd2a103
Remove FlKeyboardViewDelegate (#161705)
Instead, do the filtering at the point the event is redispatched.
2025-01-21 23:18:20 +00:00
Daniel Luz
d35626d47a
Fix documentation of Flow.clipBehavior (#161863)
The documentation described the default value as `Clip.none`, but both
constructors actually default to `Clip.hardEdge`.

(I considered this to be a trivial documentation change, so no issue was
filed.)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-21 23:08:16 +00:00
Jonah Williams
f5a13cacb0
[impeller] prevent PowerVR from using Vulkan backend. (#161841)
Almost all remaining blackscreen or rendering bugs/crashes are PowerVR
hardware. Based on common knowledge that several large engines prevent
PowerVR completely, we'll also block PowerVR until we have time to
accumulate the necessary workarounds.

---------

Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
2025-01-21 20:37:35 +00:00
gaaclarke
52cfc8b073
[Impeller] backfilling TextContents unit tests (#161625)
issue: https://github.com/flutter/flutter/issues/149652

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-21 20:15:29 +00:00
Jason Simmons
bdecbaec9d
Do not handle Dart isolate messages if the isolate is being shut down (#161824)
This fixes a race that can happen if Dart invokes an isolate's message
handling callback during isolate shutdown. The callback installed by
Tonic will invoke a dispatcher set by the engine's
DartIsolate::SetMessageHandlingTaskRunner, which will queue a message
handling task to the designated task runner.

If the queued task runs after DartIsolate::Shutdown has been called,
then Tonic's DartMessageHandler::OnHandleMessage will fail when it tries
to enter the isolate.

DartIsolate will set a shutdown flag on the DartState when Dart invokes
the isolate's shutdown callback. Tonic can avoid this race by checking
that flag before proceeding with message handling.

Fixes https://github.com/flutter/flutter/issues/160003
2025-01-21 19:10:01 +00:00
Mohellebi abdessalem
5ffb45bf78
fix failing lint : findByPath requires a specific ordering of project evaluation in aar_init_script.gradle (#159301)
android studio linter is prompting this lint: 

![388711888-61ab84da-4941-4aa4-a42e-fac4c140f4bd](https://github.com/user-attachments/assets/e031c231-8a7e-4b3b-a4a1-1aed3d461ac7)


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
2025-01-21 19:05:45 +00:00
Jackson Gardner
eb6af3d029
Get et working for local web engine builds. (#161825)
This PR makes a few different changes to make building the web engine
via `et` a bit smoother:
* Adds a few build steps to `local_engine.json` so that et can build
`wasm_release` and `wasm_debug_unopt` builds on Linux and Mac locally.
* Removed the part of our `generate_builder_json` step which generates
the `linux_web_engine_build.json` file. This previously used to be
generated based off of the contents of `felt_config.yaml` but now it's
just not parameterized at all, so there is no benefit to generating it
and we can just manually maintain the file now.
* Fixed an issue where the skwasm debug build was failing due to a wrong
output file being specified in the gn rule.
2025-01-21 18:15:18 +00:00
Jenn Magder
cfb8522609
Mark Linux_pixel_7pro flavors_test unflaky (#160994)
This should have been marked unflaky when
https://github.com/flutter/flutter/issues/156955 was closed.

Co-authored-by: Reid Baker <reidbaker@google.com>
2025-01-21 13:32:44 +00:00
Flutter GitHub Bot
195e6ff732
Marks Mac_mokey run_debug_test_android to be flaky (#161656)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_mokey run_debug_test_android"
}
-->
Issue link: https://github.com/flutter/flutter/issues/161655
2025-01-21 13:23:25 +00:00
saltedpotatos
cc44dba520
Don't crash flutter tool if Chrome is not available (#154941)
Instead of unawaiting the future, let's ignore it. 

Fixes issue #154940


I am not sure if tests would be required for this change or not.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
Co-authored-by: Ben Konyi <bkonyi@google.com>
2025-01-21 10:47:16 +00:00
Bruno Leroux
539727fb9d
Fix DropdownMenu icon and item icon misalignment (#161717)
## Description

This PR ensures that DropdownMenu icon and items icon are horizontally
aligned.

Before:

The item icon is not aligned with the DropdownMenu leading icon:


![Image](https://github.com/user-attachments/assets/c45b199d-a502-4449-834f-7660af4bb0f0)


After:

The item icon is aligned with the DropdownMenu leading icon:


![Image](https://github.com/user-attachments/assets/22a94cbb-c177-4732-b58d-a3ff8b4ac0cd)



## Related Issue

Fixes [DropdownMenu item icon and DropdownMenu.leadingIcon are not
aligned horizontally](https://github.com/flutter/flutter/issues/161668)

## Tests

Adds 2 tests.
2025-01-21 10:47:13 +00:00
Daco Harkes
da080e6976
[native assets] Cleanup dead code 2 (#161916)
This PR deletes dead code.

The `FlutterNativeAssetsBuildRunnerImpl` has a `PackageConfig` argument,
so the package config file must exist. This means the `hasPackageConfig`
method is meaningless, it will always return `true`.

The only case where it might have returned false was in the unit test
mock. This unit test is now deleted.

(It must be the case that `flutter_tools` internally ensures `pub get`
has been run in the project before it reaches any code paths that try to
build native assets.)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-21 09:03:28 +00:00
Taha Tesser
d0e03173bd
Update ListTile test to prevent log dump and test error message. (#161811)
Fixes [`ListTile` widget tests dump logs in Flutter
CI](https://github.com/flutter/flutter/issues/161810)

### Before

<img width="1341" alt="Screenshot 2025-01-17 at 17 37 30"
src="https://github.com/user-attachments/assets/fa3a6b46-07ae-4f41-9f8c-821943acdd4c"
/>

### After

<img width="1341" alt="Screenshot 2025-01-17 at 17 36 50"
src="https://github.com/user-attachments/assets/6ffd2d19-fa61-4dc5-b5e7-bb0fc8c07008"
/>


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-21 08:41:24 +00:00
flutter-pub-roller-bot
3aa979fde7
Roll pub packages (#161924)
This PR was generated by `flutter update-packages --force-upgrade`.
2025-01-21 04:05:40 +00:00
LongCatIsLooong
4115a78d2c
Make PipelineOwner a base class (#161789)
Such that nobody `implements` it. Currently it has private APIs used by
the `RenderObject` class (e.g., the dirty lists). If someone were to
implement a `PipelineOwner` outside of object.dart, they will get a
runtime `noSuchMethod` crash since they won't be able to provide those
private APIs and RenderObjects actually expect those APIs to exist.

Will be slow to update/respond due to extremely spotty internet :(

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-21 01:46:25 +00:00
Daco Harkes
883ef85413
[native assets] Cleanup dead code (#161913)
This PR deletes dead code.

Testing: No new use cases covered, all existing use cases covered by
existing tests.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-20 23:04:38 +00:00
engine-flutter-autoroll
27f3f9ad2f
Roll Packages from f73cb00e127b to e8f1f63bc3b7 (9 revisions) (#161914)
f73cb00e12...e8f1f63bc3

2025-01-20 mchudy@users.noreply.github.com [in_app_purchase] Update Play
Billing library to 7.1.1 (flutter/packages#8218)
2025-01-20 engine-flutter-autoroll@skia.org Roll Flutter from
5517cc9b3b3b to b9e86a565f92 (22 revisions) (flutter/packages#8458)
2025-01-18 stuartmorgan@google.com [pigeon] Update analyzer and
formatter (flutter/packages#8456)
2025-01-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the gradle-plugin group across 3 directories with 1
update (flutter/packages#8328)
2025-01-17 magder@google.com [local_auth_darwin] Handle when FaceID
hardware is available but permissions have been denied for the app
(flutter/packages#8348)
2025-01-16 engine-flutter-autoroll@skia.org Roll Flutter from
40c2b86fdf65 to 5517cc9b3b3b (28 revisions) (flutter/packages#8441)
2025-01-15 louisehsu@google.com [in_app_purchase_storekit] expose
`jsonRepresentation` for Transactions (flutter/packages#8430)
2025-01-15 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
17025dd88227 to 68415ad1d920 (4 revisions) (flutter/packages#8434)
2025-01-15 30872003+misos1@users.noreply.github.com
[video_player_avfoundation] fix playback speed resetting
(flutter/packages#7657)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-01-20 22:32:26 +00:00
Ben Konyi
3bfc25fb9e
[ flutter_tool ] Fix flakiness in doctor_test.dart (#161917)
This test was merging two ZeroExecutionTimeValidationResults into a new
ValidationResult with an actual execution duration set rather than
Duration.zero.

Fixes https://github.com/flutter/flutter/issues/161918
2025-01-20 21:34:29 +00:00
Robert Ancell
63110570da
Update documentation on what display information is provided. (#161785)
This was fixed in Linux in
https://github.com/flutter/flutter/pull/161359
2025-01-19 23:23:19 +00:00
Loïc Sharma
b9e86a565f
Fix link to Linux custom embedder artifacts (#161699)
This also updates the commit hashes to the latest stable Flutter engine
and addresses content that's outdated due to the monorepo merge.
2025-01-18 02:26:17 +00:00
Matan Lurey
9bf4e898b5
Remove tests, GLFW examples, and non-artifact builds from linux_host_engine. (#161786)
Towards https://github.com/flutter/flutter/issues/161406.

This PR does the following:

- Removes `tests: [ ... ]`
- Removes `--build-embedder-examples`
- Entirely removes `host_profile`, as it did not contribute artifacts
(built on other builders)
- Some light sorting/re-ordering to make it more obvious which GN target
contributed to which include path

The tests for these builds are located in
[`linux_host_engine_test.json`](https://github.com/flutter/flutter/blob/master/engine/src/flutter/ci/builders/linux_host_engine_test.json).
2025-01-18 00:24:21 +00:00