firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
83,003 Commits 1 Branch 0 Tags
Commit Graph

83003 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonah Williams
fe257cbf5a
[Impeller] when mips are disabled, also disable from sampler options. (#161765) 
If we have disabled mipmap generation on a platform due to GPU driver
bugs, make sure that all sampling options used declare that only the
base mip level should be read. Otherwise we can end up sampling from
unpopulated mip levels.
 2025-01-18 00:22:05 +00:00
Luke Pighetti
5e24ac89bc
revert removing Twitter, retain BlueSky (#161803) 
https://github.com/flutter/flutter/blob/master/CODE_OF_CONDUCT.md?plain=1#L11-L13

> The Flutter project expects Flutter's contributors to act
professionally
and respectfully. Flutter contributors are expected to maintain the
**safety
and dignity of Flutter's social environments** (such as GitHub and
Discord).

The Flutter community on X is significant and important. We are the
interface between Flutter and the larger tech community. We have been
disenfranchised by this PR.
https://github.com/flutter/flutter/pull/161778

> * Respect people, their identities, their culture, and their work.
> * Be kind. Be courteous. Be welcoming.
> * Listen. Consider and acknowledge people's points before responding.

This change is not respectful, kind, courteous, or welcoming. There
wasn't an opportunity to listen to or consider the affected people.

> Should you experience anything that makes you feel unwelcome in
Flutter's
community, please contact
[conduct@flutter.dev](mailto:conduct@flutter.dev)
or, if you prefer, directly contact someone on the project, for instance
[Hixie](mailto:ian@hixie.ch).

I feel unwelcome.
 2025-01-18 00:14:20 +00:00
Yegor
78c62b00cc
fix reorderable_list_test.dart (#161836) 
Fix `reorderable_list_test.dart`
 2025-01-17 23:16:16 +00:00
Kevin Chisholm
bb2d34126c
[Release] Update the cherry-pick process. (#161771) 
Updates to the Flutter cherry-pick process to align with our current
practices. This update:
1. Defaults to automated cherry-picks.
2. Removes the need to create cherry-pick issues.
3. Requires cherry-pick authors to update CHANGELOG.md.

---------

Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
 2025-01-17 15:44:31 +00:00
Victor Sanni
3297454732
Reland "#143249 Autocomplete options width" (#161695) 
Original PR: https://github.com/flutter/flutter/pull/143249
Revert PR: https://github.com/flutter/flutter/pull/161666

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-17 06:50:56 +00:00
Siva
f545df54ff
Roll Dart to Version 3.8.0-1.0.dev (#161781) 
Roll Dart to version 3.8.0-1.0.dev


https://dart.googlesource.com/sdk.git/+log/f6ed8d7df6bfdf6fb08b38dd93c2ee1eba476b5a..f11b24d1c54093830e8ed1a2239504eba775d9da


[f11b24d](https://dart.googlesource.com/sdk.git/+/f11b24d1c54093830e8ed1a2239504eba775d9da)
[Version
3.8.0-1.0.dev](https://dart.googlesource.com/sdk.git/+/f11b24d1c54093830e8ed1a2239504eba775d9da)
by Dart CI · 3 hours ago
[dev](https://dart.googlesource.com/sdk.git/+/refs/heads/dev)
[3.8.0-1.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-1.0.dev)

[70c7a05](https://dart.googlesource.com/sdk.git/+/70c7a051d7546bf8fcb0a8303683521b3040dff7)
[Fix typo in Issue
Templates](https://dart.googlesource.com/sdk.git/+/70c7a051d7546bf8fcb0a8303683521b3040dff7)
by Mohamed Abdelaal · 4 hours ago

[49e0514](https://dart.googlesource.com/sdk.git/+/49e051426ae54c05e2ca95133eab3f55ee687df7)
[Update chrome and firefox
versions.](https://dart.googlesource.com/sdk.git/+/49e051426ae54c05e2ca95133eab3f55ee687df7)
by Nate Biggs · 5 hours ago

[7b25ce8](https://dart.googlesource.com/sdk.git/+/7b25ce88d33e4ab1d5522a8b6975432bcbd3b2a1)
[[dartdev] Use VmInteropHandler for invoking sub
commands](https://dart.googlesource.com/sdk.git/+/7b25ce88d33e4ab1d5522a8b6975432bcbd3b2a1)
by asiva · 6 hours ago

[ad99880](https://dart.googlesource.com/sdk.git/+/ad99880d23a78593a1b97a8e50de67223a516681)
[Version
3.8.0-0.0.dev](https://dart.googlesource.com/sdk.git/+/ad99880d23a78593a1b97a8e50de67223a516681)
by Dart CI · 7 hours ago
[3.8.0-0.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-0.0.dev)

[6880ea8](https://dart.googlesource.com/sdk.git/+/6880ea8495145c7b536dfbf581594fe7ce7c1ebd)
[Remove unused variables in Windows
code](https://dart.googlesource.com/sdk.git/+/6880ea8495145c7b536dfbf581594fe7ce7c1ebd)
by Ivan Inozemtsev · 7 hours ago

[afcfe1e](https://dart.googlesource.com/sdk.git/+/afcfe1e133a08a0833ec695308845003c529e2e2)
[dart create: Stop progress before exiting with
error](https://dart.googlesource.com/sdk.git/+/afcfe1e133a08a0833ec695308845003c529e2e2)
by Sigurd Meldgaard · 10 hours ago

[f72b1ae](https://dart.googlesource.com/sdk.git/+/f72b1ae9dd14d4f086c7d212d592b7544ba7ec4a)
[Bump dart_internal to allow Dart
3.8](https://dart.googlesource.com/sdk.git/+/f72b1ae9dd14d4f086c7d212d592b7544ba7ec4a)
by Alexander Thomas · 10 hours ago

[78ce85a](https://dart.googlesource.com/sdk.git/+/78ce85a7fe6f2c0ca80bc6a3073ee9243af11e8a)
[[dart2wasm,tfa] Don't infer class of string values in
comparisons](https://dart.googlesource.com/sdk.git/+/78ce85a7fe6f2c0ca80bc6a3073ee9243af11e8a)
by Ömer Sinan Ağacan · 11 hours ago

[b59c3e2](https://dart.googlesource.com/sdk.git/+/b59c3e22ef586a18259d0b3ae131c7576f5fdf72)
[[release] Bump version on main to
3.8](https://dart.googlesource.com/sdk.git/+/b59c3e22ef586a18259d0b3ae131c7576f5fdf72)
by Alexander Thomas · 12 hours ago

[81b669d](https://dart.googlesource.com/sdk.git/+/81b669dc45e3b040b6080c95688ba2f462b47a84)
[[cfe] Create enum elements through
SourcePropertyBuilder](https://dart.googlesource.com/sdk.git/+/81b669dc45e3b040b6080c95688ba2f462b47a84)
by Johnni Winther · 13 hours ago

[d0b90e5](https://dart.googlesource.com/sdk.git/+/d0b90e5811e65259d8aa449e7625b50a9db8afd9)
[[deps] remove unused deps: yaml_edit, yaml, watcher, term_glyph,
string_scanner, stream_channel, and
stack_trace](https://dart.googlesource.com/sdk.git/+/d0b90e5811e65259d8aa449e7625b50a9db8afd9)
by Devon Carew · 14 hours ago

[99247f1](https://dart.googlesource.com/sdk.git/+/99247f155789107b48e58667ff3a601b95364ec2)
[[analyzer] Change type returned by
TypeImpl.asInstanceOf.](https://dart.googlesource.com/sdk.git/+/99247f155789107b48e58667ff3a601b95364ec2)
by Paul Berry · 24 hours ago
[base](https://dart.googlesource.com/sdk.git/+/refs/heads/base)

[2556d01](https://dart.googlesource.com/sdk.git/+/2556d0155c7f4c539fa9594bd8db6363ede79a99)
[Add documentation for code
completion](https://dart.googlesource.com/sdk.git/+/2556d0155c7f4c539fa9594bd8db6363ede79a99)
by Brian Wilkerson · 24 hours ago

[3b76197](https://dart.googlesource.com/sdk.git/+/3b76197f2e1f66f4822efef117efb25c4986064f)
[Bump github/codeql-action from 3.28.0 to
3.28.1](https://dart.googlesource.com/sdk.git/+/3b76197f2e1f66f4822efef117efb25c4986064f)
by dependabot[bot] · 25 hours ago

[d97d2e5](https://dart.googlesource.com/sdk.git/+/d97d2e5bad25e0cadd8a343d0db644a95f0b99ef)
[Bump actions/upload-artifact from 4.5.0 to
4.6.0](https://dart.googlesource.com/sdk.git/+/d97d2e5bad25e0cadd8a343d0db644a95f0b99ef)
by dependabot[bot] · 25 hours ago

[fa06595](https://dart.googlesource.com/sdk.git/+/fa065954e58adfd63506e93ffc1c00c43ca3a723)
[[lint] new `unnecessary_ignore` error
codes](https://dart.googlesource.com/sdk.git/+/fa065954e58adfd63506e93ffc1c00c43ca3a723)
by pq · 25 hours ago

[b6cc8a7](https://dart.googlesource.com/sdk.git/+/b6cc8a768e9d696ec260d89c7dd8fd9cb877e9da)
[[dart2js] Remove
HInstruction.isControlFlow](https://dart.googlesource.com/sdk.git/+/b6cc8a768e9d696ec260d89c7dd8fd9cb877e9da)
by Stephen Adams · 25 hours ago

[93621cc](https://dart.googlesource.com/sdk.git/+/93621ccfc1a81b3d9848436c5b736553808aa28e)
[[analysis_server] Move all EditableArgument tests to a shared mixin and
run for
legacy](https://dart.googlesource.com/sdk.git/+/93621ccfc1a81b3d9848436c5b736553808aa28e)
by Danny Tuppeny · 26 hours ago

[549a785](https://dart.googlesource.com/sdk.git/+/549a78500a72855412863422b6fae4dc3b6ae3d6)
[[analysis_server] Add a shared test interface to simplify sharing tests
between LSP,
LSP-over-Legacy](https://dart.googlesource.com/sdk.git/+/549a78500a72855412863422b6fae4dc3b6ae3d6)
by Danny Tuppeny · 26 hours ago

[eddf844](https://dart.googlesource.com/sdk.git/+/eddf8443df7b27ff4010dd555ce6329a5265940d)
[[infra] Clean up task killing on
Windows.](https://dart.googlesource.com/sdk.git/+/eddf8443df7b27ff4010dd555ce6329a5265940d)
by Alexander Aprelev · 27 hours ago

[3394fec](https://dart.googlesource.com/sdk.git/+/3394fec2c7dd29a2cd2e31fccf2e0b61ba6e56f0)
[[lint] `unecessary_ignore`: skip generated
files](https://dart.googlesource.com/sdk.git/+/3394fec2c7dd29a2cd2e31fccf2e0b61ba6e56f0)
by pq · 27 hours ago

[2dc6d31](https://dart.googlesource.com/sdk.git/+/2dc6d31f8a6a412f30778755ef296f9dbc36c089)
[[lint] new lint:
`unnecessary_ignore`](https://dart.googlesource.com/sdk.git/+/2dc6d31f8a6a412f30778755ef296f9dbc36c089)
by pq · 28 hours ago

[927769e](https://dart.googlesource.com/sdk.git/+/927769e9f35a9fdf37517fdf3d417f389adfd5e9)
[linter: Simplify lint rule
selection](https://dart.googlesource.com/sdk.git/+/927769e9f35a9fdf37517fdf3d417f389adfd5e9)
by Sam Rawlins · 29 hours ago

[91e7d23](https://dart.googlesource.com/sdk.git/+/91e7d238f641514d99ce3399a39ad6cbdb5b256d)
[analyzer: Modernize and simplify AnalysisOptionsProvider
test](https://dart.googlesource.com/sdk.git/+/91e7d238f641514d99ce3399a39ad6cbdb5b256d)
by Sam Rawlins · 29 hours ago

[749de93](https://dart.googlesource.com/sdk.git/+/749de9387f76346bd728f05ef2bc9f7a93144331)
[[analyzer] Refine types returned by TypeSystemImpl
methods.](https://dart.googlesource.com/sdk.git/+/749de9387f76346bd728f05ef2bc9f7a93144331)
by Paul Berry · 29 hours ago

[3417d1a](https://dart.googlesource.com/sdk.git/+/3417d1a464033465d38e0f25f7698902c20565d5)
[Elements. Fix for lazy loading
methods.](https://dart.googlesource.com/sdk.git/+/3417d1a464033465d38e0f25f7698902c20565d5)
by Konstantin Shcheglov · 30 hours ago

[9e8e8e5](https://dart.googlesource.com/sdk.git/+/9e8e8e5fcad47058d9740c38dfbb69a1148cf8d5)
[[vm,dynamic_modules] Support members which are overridden implictly
(transitively) by a dynamic
module](https://dart.googlesource.com/sdk.git/+/9e8e8e5fcad47058d9740c38dfbb69a1148cf8d5)
by Alexander Markov · 31 hours ago

[493de63](https://dart.googlesource.com/sdk.git/+/493de637f32110b46baf1d029bf04dfc33d6ef6c)
[[analyzer] Remove FormalParameterElementOrMember
class.](https://dart.googlesource.com/sdk.git/+/493de637f32110b46baf1d029bf04dfc33d6ef6c)
by Paul Berry · 31 hours ago

[fb3255d](https://dart.googlesource.com/sdk.git/+/fb3255dd9edd93c64da1353b579640b6531ee211)
[[analysis_server] Add support/tests for reverse-requests for
LSP-over-Legacy](https://dart.googlesource.com/sdk.git/+/fb3255dd9edd93c64da1353b579640b6531ee211)
by Danny Tuppeny · 31 hours ago

[722e4f2c](https://dart.googlesource.com/sdk.git/+/722e4f2ccaee4017fee6f6a3828269f5c9f62c29)
[Update isolate
tests.](https://dart.googlesource.com/sdk.git/+/722e4f2ccaee4017fee6f6a3828269f5c9f62c29)
by Lasse R.H. Nielsen · 33 hours ago

[3f4bf45](https://dart.googlesource.com/sdk.git/+/3f4bf455c0eddd6245665e7c1770234fb5d3d7e6)
[[dart2wasm] Roll binaryen to g3
version](https://dart.googlesource.com/sdk.git/+/3f4bf455c0eddd6245665e7c1770234fb5d3d7e6)
by Martin Kustermann · 2 days ago

[3ffd659](https://dart.googlesource.com/sdk.git/+/3ffd659296e9285ac86a20be8204c8d08ba3e46e)
[[vm_service] Added new tests to the skip list on all
hosts](https://dart.googlesource.com/sdk.git/+/3ffd659296e9285ac86a20be8204c8d08ba3e46e)
by asiva · 2 days ago

[86c3959](https://dart.googlesource.com/sdk.git/+/86c395967982993fb045d34f43df5b3cefbf5366)
[[infra] When killing a process on Windows don't double-check the
name.](https://dart.googlesource.com/sdk.git/+/86c395967982993fb045d34f43df5b3cefbf5366)
by Alexander Aprelev · 2 days ago

[4f5aacf](https://dart.googlesource.com/sdk.git/+/4f5aacfd902ceaf9fe379218cad468b4c3e098f8)
[[CQ] bump `analyzer_cli` to 3.7 and tall-style
re-format](https://dart.googlesource.com/sdk.git/+/4f5aacfd902ceaf9fe379218cad468b4c3e098f8)
by pq · 2 days ago

[e470c55](https://dart.googlesource.com/sdk.git/+/e470c55db7cc3bb9078a825466431609d1294b34)
[[CQ] linter: enable
`unnecessary_underscores`](https://dart.googlesource.com/sdk.git/+/e470c55db7cc3bb9078a825466431609d1294b34)
by pq · 2 days ago

[f157bdc](https://dart.googlesource.com/sdk.git/+/f157bdcf4b6524768c791e6cba7f3faf9711d47c)
[[element model] remove unnecessary `analyzer_use_new_elements`
ignore](https://dart.googlesource.com/sdk.git/+/f157bdcf4b6524768c791e6cba7f3faf9711d47c)
by pq · 2 days ago

[02c7383](https://dart.googlesource.com/sdk.git/+/02c73833baaab5fe9154ecffa29cd0f07df3c415)
[[CQ] cleanup some unnecessary
ignores](https://dart.googlesource.com/sdk.git/+/02c73833baaab5fe9154ecffa29cd0f07df3c415)
by pq · 2 days ago

[bb7106a](https://dart.googlesource.com/sdk.git/+/bb7106ae230eb4373e06d8ebc6ffbbc4f5304931)
[[analyzer] Change DartType to implement
SharedTypeStructure<TypeImpl>.](https://dart.googlesource.com/sdk.git/+/bb7106ae230eb4373e06d8ebc6ffbbc4f5304931)
by Paul Berry · 2 days ago

[dc709bb](https://dart.googlesource.com/sdk.git/+/dc709bb4bf3bf17fd05aafeeae5fc4715ac5c5ab)
[Elements. Migrate
InterfaceLeastUpperBoundHelper.](https://dart.googlesource.com/sdk.git/+/dc709bb4bf3bf17fd05aafeeae5fc4715ac5c5ab)
by Konstantin Shcheglov · 2 days ago

[2527793](https://dart.googlesource.com/sdk.git/+/2527793e7a83376a7c15190fc7ebd9b385720694)
[[fuchsia] Add OWNERS_FUCHSIA to allow fuchsia owners to update the
DEPS](https://dart.googlesource.com/sdk.git/+/2527793e7a83376a7c15190fc7ebd9b385720694)
by Hzj_jie · 2 days ago

[b5232ac](https://dart.googlesource.com/sdk.git/+/b5232ac632e26ffc4b4ca3d20afd51d337dbb39b)
[[ddc] Resolving link-time class members via the
embedder.](https://dart.googlesource.com/sdk.git/+/b5232ac632e26ffc4b4ca3d20afd51d337dbb39b)
by MarkZ · 2 days ago

[330cc91](https://dart.googlesource.com/sdk.git/+/330cc916c6b5ecc76d52dc3daf1aea97184a363b)
[[analyzer] Use Impl types in
ElementsTypesMixin.](https://dart.googlesource.com/sdk.git/+/330cc916c6b5ecc76d52dc3daf1aea97184a363b)
by Paul Berry · 2 days ago

[eafaa11](https://dart.googlesource.com/sdk.git/+/eafaa1173823e238eff5c9508a2e326da604ab7b)
[Elements. Store InterfaceElementImpl2 in
InterfaceTypeImpl.](https://dart.googlesource.com/sdk.git/+/eafaa1173823e238eff5c9508a2e326da604ab7b)
by Konstantin Shcheglov · 2 days ago

[6aeb1bf](https://dart.googlesource.com/sdk.git/+/6aeb1bffc1b3f1bd126d3904a2da7b1bdf42d004)
[[analyzer] Refine some internal getter
types.](https://dart.googlesource.com/sdk.git/+/6aeb1bffc1b3f1bd126d3904a2da7b1bdf42d004)
by Paul Berry · 2 days ago

[52cc629](https://dart.googlesource.com/sdk.git/+/52cc62938cb93ef747c57d66f19db06260145402)
[[build] Don't build the Debian package as an implication of
create_sdk.](https://dart.googlesource.com/sdk.git/+/52cc62938cb93ef747c57d66f19db06260145402)
by Ryan Macnak · 2 days ago

[163539a](https://dart.googlesource.com/sdk.git/+/163539a225d99cb9d4146049fd0ac1157c8a0961)
[Bump tools to
3bdef2043af9244b804adc08896bf96d51bb49ba](https://dart.googlesource.com/sdk.git/+/163539a225d99cb9d4146049fd0ac1157c8a0961)
by Devon Carew · 2 days ago

[a0b6a48](https://dart.googlesource.com/sdk.git/+/a0b6a489f33ece6777af112563d4161f268c9a28)
[[analysis_server] Allow legacy clients to set LSP capabilities in
setClientCapabilities](https://dart.googlesource.com/sdk.git/+/a0b6a489f33ece6777af112563d4161f268c9a28)
by Danny Tuppeny · 2 days ago

[9b71817](https://dart.googlesource.com/sdk.git/+/9b71817072489f0a7a39ae512f8f17e348b9175b)
[[analysis_server] Fix duplicate reporting of some LSP type parsing
errors](https://dart.googlesource.com/sdk.git/+/9b71817072489f0a7a39ae512f8f17e348b9175b)
by Danny Tuppeny · 2 days ago

[c36dac8](https://dart.googlesource.com/sdk.git/+/c36dac8fc9c518dc9334935ee04212342a989991)
[Elements. Migrate
ReplaceTopBottomVisitor.](https://dart.googlesource.com/sdk.git/+/c36dac8fc9c518dc9334935ee04212342a989991)
by Konstantin Shcheglov · 2 days ago

[2dec4fe](https://dart.googlesource.com/sdk.git/+/2dec4fe1eff1efcff5bd589347a4de6c9c5c12fe)
[Elements. Migrate
lib/src/dart/ast/utilities.dart](https://dart.googlesource.com/sdk.git/+/2dec4fe1eff1efcff5bd589347a4de6c9c5c12fe)
by Keerti Parthasarathy · 2 days ago

[e1ba3ea](https://dart.googlesource.com/sdk.git/+/e1ba3ea504fb561cfdc3cdc67c5ae61fe0c19d4a)
[[_fe_analyzer_shared] Move TypeConstraintGatherer to its own
file.](https://dart.googlesource.com/sdk.git/+/e1ba3ea504fb561cfdc3cdc67c5ae61fe0c19d4a)
by Paul Berry · 2 days ago

[61336f3](https://dart.googlesource.com/sdk.git/+/61336f32ab43c11747eb22ff6d1ca91c38b987c6)
[[dart2wasm] Mark timing out test as SkipSlow on all browsers, not just
Chrome](https://dart.googlesource.com/sdk.git/+/61336f32ab43c11747eb22ff6d1ca91c38b987c6)
by Martin Kustermann · 2 days ago

[e13db8b](https://dart.googlesource.com/sdk.git/+/e13db8b7739def53f2c2d1609839c40464fd740e)
[[dart2wasm] Remove --turboshaft-wasm flag (which was removed from D8)
in test
runner](https://dart.googlesource.com/sdk.git/+/e13db8b7739def53f2c2d1609839c40464fd740e)
by Martin Kustermann · 2 days ago

[ac9acf5](https://dart.googlesource.com/sdk.git/+/ac9acf51659ec55d0dc1096305a0c7c7a5aa34dc)
[[deps] Roll
dart-lang/native](https://dart.googlesource.com/sdk.git/+/ac9acf51659ec55d0dc1096305a0c7c7a5aa34dc)
by Daco Harkes · 2 days ago

[6aeb865](https://dart.googlesource.com/sdk.git/+/6aeb8657810ab3dc55b2a60bcd4328be6490dd10)
[[dart2wasm] Workaround bug in JavaScriptCore/WebKit in test
runner](https://dart.googlesource.com/sdk.git/+/6aeb8657810ab3dc55b2a60bcd4328be6490dd10)
by Martin Kustermann · 2 days ago

[45d5b48](https://dart.googlesource.com/sdk.git/+/45d5b483da0fd271cd09430c2375844d39426a2e)
[[dartfuzz] Handle more types in minimized literal
generation.](https://dart.googlesource.com/sdk.git/+/45d5b483da0fd271cd09430c2375844d39426a2e)
by Tess Strickland · 2 days ago

[37e3a7a](https://dart.googlesource.com/sdk.git/+/37e3a7a75ea84238c22b636f3500d549e5a05e08)
[[deps] Roll jsshell & firefox to newer
version](https://dart.googlesource.com/sdk.git/+/37e3a7a75ea84238c22b636f3500d549e5a05e08)
by Martin Kustermann · 3 days ago

[70e7715](https://dart.googlesource.com/sdk.git/+/70e77158e64833997f8de072f0ae6faa80aacfed)
[Elements. Migrate
lib/src/utilities/completion/optype.dart](https://dart.googlesource.com/sdk.git/+/70e77158e64833997f8de072f0ae6faa80aacfed)
by Keerti Parthasarathy · 3 days ago

[34be38d](https://dart.googlesource.com/sdk.git/+/34be38dcce8da65400d671de26a21d11b99a3bef)
[Elements. Migrate
test/src/task/strong/dart2_inference_test.dart](https://dart.googlesource.com/sdk.git/+/34be38dcce8da65400d671de26a21d11b99a3bef)
by Keerti Parthasarathy · 3 days ago

[1f5b904](https://dart.googlesource.com/sdk.git/+/1f5b9042b6a92591d162716d29bb14f1d7d80015)
[Elements. Migrate
test/src/dart/analysis/session_test.dart](https://dart.googlesource.com/sdk.git/+/1f5b9042b6a92591d162716d29bb14f1d7d80015)
by Keerti Parthasarathy · 3 days ago

[50527da](https://dart.googlesource.com/sdk.git/+/50527dafa269f4d20a56d0292ca37b93872da782)
[Elements. Migrate
SubtypeHelper.](https://dart.googlesource.com/sdk.git/+/50527dafa269f4d20a56d0292ca37b93872da782)
by Konstantin Shcheglov · 3 days ago

[d3c7590](https://dart.googlesource.com/sdk.git/+/d3c75903393a6178651199f25b9653c20d23cac7)
[[DEPS] remove no longer referenced
deps](https://dart.googlesource.com/sdk.git/+/d3c75903393a6178651199f25b9653c20d23cac7)
by Devon Carew · 3 days ago

[161b8e9](https://dart.googlesource.com/sdk.git/+/161b8e9cc13a1aa3b50f1b387c564bc27f84e451)
[Bump shelf to
bf799519cda2898a7c5af06dcfdd5fe6443afd79](https://dart.googlesource.com/sdk.git/+/161b8e9cc13a1aa3b50f1b387c564bc27f84e451)
by Devon Carew · 3 days ago

[c988e32](https://dart.googlesource.com/sdk.git/+/c988e32a56dfb1af85d3b7b901906f0b6ba541a6)
[[cq] remove unnecessary
ignores](https://dart.googlesource.com/sdk.git/+/c988e32a56dfb1af85d3b7b901906f0b6ba541a6)
by pq · 3 days ago

[106d3a6](https://dart.googlesource.com/sdk.git/+/106d3a61b877e9291575e829cb75acd8a90c7a3a)
[[DEPS] Restore Firefox/JSC to 133.0 to avoid breaking wasm
tests](https://dart.googlesource.com/sdk.git/+/106d3a61b877e9291575e829cb75acd8a90c7a3a)
by Mayank Patke · 3 days ago

[ad481ff](https://dart.googlesource.com/sdk.git/+/ad481ff4b567dac66c6ae8c0d2967d46c58e1a2a)
[Elements. Add
Element2.fragments](https://dart.googlesource.com/sdk.git/+/ad481ff4b567dac66c6ae8c0d2967d46c58e1a2a)
by Konstantin Shcheglov · 3 days ago

[0836d36](https://dart.googlesource.com/sdk.git/+/0836d36dc7d074cdbfbd5a8795a6ba940c14156b)
[[infra] Adjust build windows-arm64 split to avoid
timeouts.](https://dart.googlesource.com/sdk.git/+/0836d36dc7d074cdbfbd5a8795a6ba940c14156b)
by Alexander Aprelev · 3 days ago

[0248324](https://dart.googlesource.com/sdk.git/+/02483247a724a089e175a7b29125a8e64d743e33)
[[cq] bump linter to 3.7 and tall-style
format](https://dart.googlesource.com/sdk.git/+/02483247a724a089e175a7b29125a8e64d743e33)
by pq · 3 days ago

[238db6e](https://dart.googlesource.com/sdk.git/+/238db6e7017beb64193ffc01b508bd297f3e2f56)
[[ DDS ] Fix package:vm_service constraints before publishing
5.0.0](https://dart.googlesource.com/sdk.git/+/238db6e7017beb64193ffc01b508bd297f3e2f56)
by Ben Konyi · 3 days ago

[8a3b4ab](https://dart.googlesource.com/sdk.git/+/8a3b4ab3181b1d31e4a7440634893bce5412f22d)
[Elements. Restore lazy reading ClassElement
members.](https://dart.googlesource.com/sdk.git/+/8a3b4ab3181b1d31e4a7440634893bce5412f22d)
by Konstantin Shcheglov · 3 days ago

[519e288](https://dart.googlesource.com/sdk.git/+/519e288797517e339f8b8333d045f23b5d98aba2)
[Elements. Migrate
ElementNameUnion.](https://dart.googlesource.com/sdk.git/+/519e288797517e339f8b8333d045f23b5d98aba2)
by Konstantin Shcheglov · 3 days ago

[01f5956](https://dart.googlesource.com/sdk.git/+/01f59564b87f859e229ec7a6f4fa6fe94478c96f)
[Elements. Migrate
NormalizeHelper.](https://dart.googlesource.com/sdk.git/+/01f59564b87f859e229ec7a6f4fa6fe94478c96f)
by Konstantin Shcheglov · 3 days ago

[a5c3b34](https://dart.googlesource.com/sdk.git/+/a5c3b34173f2ac90c5be47e66f86e9d4b3dacf1b)
[Elements. Set element for a synthetic covariant
merge.](https://dart.googlesource.com/sdk.git/+/a5c3b34173f2ac90c5be47e66f86e9d4b3dacf1b)
by Konstantin Shcheglov · 3 days ago

[077a4c3](https://dart.googlesource.com/sdk.git/+/077a4c3545f3c78d9f29da68a6af22e367875a58)
[Elements. Migrate
SinceSdkVersionComputer.](https://dart.googlesource.com/sdk.git/+/077a4c3545f3c78d9f29da68a6af22e367875a58)
by Konstantin Shcheglov · 3 days ago

[22fe194](https://dart.googlesource.com/sdk.git/+/22fe1947d24e51c2c57235a0dc1b60ddb6976221)
[Elements. Migrate ThisLookup and
LexicalLookup.](https://dart.googlesource.com/sdk.git/+/22fe1947d24e51c2c57235a0dc1b60ddb6976221)
by Konstantin Shcheglov · 3 days ago

[0f82db5](https://dart.googlesource.com/sdk.git/+/0f82db5a9ccaaab61a8135367a9120336f7b587f)
[Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to
3SIihrAqX5c1w3ep7...](https://dart.googlesource.com/sdk.git/+/0f82db5a9ccaaab61a8135367a9120336f7b587f)
by DEPS Autoroller · 3 days ago

[cee59be](https://dart.googlesource.com/sdk.git/+/cee59be7560f5906a82dc9330e756dbf1a218340)
[Roll Fuchsia SDK from 26.20241231.3.1 to
26.20250106.5.1](https://dart.googlesource.com/sdk.git/+/cee59be7560f5906a82dc9330e756dbf1a218340)
by DEPS Autoroller · 3 days ago

[efda4af](https://dart.googlesource.com/sdk.git/+/efda4aff7cb5cdca3237a52e5fb6c805f4403c5a)
[Add GN target to build Debian package from regular
output.](https://dart.googlesource.com/sdk.git/+/efda4aff7cb5cdca3237a52e5fb6c805f4403c5a)
by Ryan Macnak · 3 days ago

[0f15e32](https://dart.googlesource.com/sdk.git/+/0f15e32ad3551ca492a5a7c62d9182d1e4fd4627)
[[DEPS] Update web
browsers](https://dart.googlesource.com/sdk.git/+/0f15e32ad3551ca492a5a7c62d9182d1e4fd4627)
by Mayank Patke · 3 days ago

[8d851b1](https://dart.googlesource.com/sdk.git/+/8d851b17c5dcc58f3033831f1fdd5783f125c5d9)
[Bump dartdoc to
e1295863b11c54680bf178ec9c2662a33b0e24be](https://dart.googlesource.com/sdk.git/+/8d851b17c5dcc58f3033831f1fdd5783f125c5d9)
by Devon Carew · 3 days ago

[048df9d](https://dart.googlesource.com/sdk.git/+/048df9d706c37b0fd00a88c65b7ce772ce125b8c)
[[vm] Fix tree-shaking of mixin applications when mixin has a member
with entry point
pragma](https://dart.googlesource.com/sdk.git/+/048df9d706c37b0fd00a88c65b7ce772ce125b8c)
by Alexander Markov · 3 days ago
 2025-01-17 04:46:23 +00:00
Jonah Williams
32ef7f8e2e
[Impeller] use 3 fences to synchronize AHB swapchains (like we do for KHR). (#161767) 
Testing on a newer Adreno, I can still see rendering artifacts. This
change matches the syncrhonization to what we do for KHR, and on the
Adreno I see no more rendering artifacts.
 2025-01-17 02:48:18 +00:00
Jonah Williams
095f46c4a7
[Impeller] remove Adreno denylist entries. (#161740) 
Fixes https://github.com/flutter/flutter/issues/161209

testing on a 540 and everything seems to work now that we have the
Adreno specific workarounds added to the renderer. Its possible there
are some bugs that only exist on the early 600s but I guess we'll find
out.
 2025-01-17 02:44:31 +00:00
Robert Ancell
f2ce662fd2
Refactor event redispatching (#161701) 
Instead of doing the redispatching from inside FlKeyboardManager, return
the event asynchronously to the code that provided the event in the
first case. That code has all the context on how to do the redispatch -
this will be more complicated in a multi-view case.
 2025-01-17 01:01:49 +00:00
Jonah Williams
12518fac13
[Impellerc] correctly pad arrays of vec3s in reflector. (#161697) 
When processing the metadata for a struct with an array, incorporate the
padding into the layout. Previously we would register a vec3[n] array as
being 4*n bytes (including the padding), but when uploading this would
result in us writing data into the padding and then leave the rest
uninitialized. now we correctly insert a padding element between 3 byte
elements.

Fixes https://github.com/flutter/flutter/issues/161645
 2025-01-17 00:48:01 +00:00
Jason Simmons
747f5fff1e
Initialize dartLoader.rootDirectories so the Web stack trace mapper can convert package source paths (#160383) 
See
https://dart.googlesource.com/sdk/+/refs/heads/main/pkg/dev_compiler/web/stack_trace_mapper.dart

Fixes https://github.com/flutter/flutter/issues/158109
 2025-01-17 00:40:52 +00:00
Robert Ancell
a6045c9985
Make fl_keyboard_manager_handle_event async (#161637) 
In this way we can tell when this call completes, which should help
testing and refactoring.
 2025-01-16 23:45:48 +00:00
Kevin Moore
82a58ee499
Update social links in readme (#161778) 2025-01-16 23:16:16 +00:00
Robert Ancell
732e003745
Remove some stray printf debugging (#161706) 2025-01-16 22:47:02 +00:00
Srujan Gaddam
c173e2e29c
Set meta tag in default index (#161493) 
The bootstrapping for the DDC module format and library bundle module
format contained a preamble to dynamically set the meta tag to ensure
the document is parsed as utf-8. This doesn't work as the page has
already been parsed at that point. Instead, it should go in the html
directly.

The meta tag should not affect the AMD module format, as require.js
already ensures any loaded scripts are parsed as utf-8.

This tag in general is needed to parse this string correctly:
https://github.com/dart-lang/sdk/blob/main/sdk/lib/core/uri.dart#L4100

This is a follow-up to PR
https://github.com/flutter/flutter/pull/161276.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
 2025-01-16 22:27:08 +00:00
Andrew Kolos
8ef7b93287
remove usage of Usage from build system (#160663) 
Towards https://github.com/flutter/flutter/issues/150575

This effectively just removes `Usage` as a dependency of `Environment`
(in build_system.dart). All other changes are a direct result of that.


<details>

<summary> Pre-launch checklist </summary> 


- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

</details>

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-16 21:54:58 +00:00
Andrew Kolos
5a3541c40c
route CLI command usage information through the logger instead of using print (#161533) 
Fixes https://github.com/flutter/flutter/issues/158532


<details>

<summary> Pre-launch checklist </summary> 


- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

</details>


<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-16 21:53:58 +00:00
Matan Lurey
cbe269808b
Enable duplicate linux_host_engine_test. (#161613) 
Towards https://github.com/flutter/flutter/issues/161406.

* Enables (on presubmit), and adds a missing GN target.
* Removes tests from the `linux_host_engine` build.
 2025-01-16 21:52:18 +00:00
Mitchell Goodwin
3f2b7d900e
Do not block vertical drag gestures in CupertinoSheetRoute body (#161696) 
Fixes #161623.

Changes how the VerticalGestureRecognizer watches the sheet body. Before
it stacked over the sheet and won all gesture arenas with vertical
drags, so it didn't allow scrolling in the sheet. Now it has the sheet
content as its child, so it will defer to child vertical gestures. This
PR will allow scrolling to work in the sheet, but further work needs to
be done to improve scrolling and drag to dismiss working together, see
#161687.



https://github.com/user-attachments/assets/71bee654-2d0d-499d-9d27-403188138fb5



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-16 21:52:15 +00:00
Jonah Williams
90f926edc1
[Impeller] Update partial repaint to use a fullsize onscreen. (#161626) 
The existing technique of offsetting a smaller texture is very vunerable
to bugs in the renderer. Rather than this approach, we can allocate a
new offscreen that is full sized and then blit a smaller region. To
reduce the allocation costs, we can also set up a transients cache which
will reuse this texture. In total, this should be more performant than
the existing partial repaint (due to lack of continual re-allocation) at
the cost of higher peak memory usage.

Fixes https://github.com/flutter/flutter/issues/140877
Fixes https://github.com/flutter/flutter/issues/160588
Fixes https://github.com/flutter/flutter/issues/156113
 2025-01-16 19:29:36 +00:00
Enguerrand ARMINJON
5517cc9b3b
feat: Change default value of keyboardDismissBehavior (#158580) 
This PR aim to let developer choose the default
ScrollViewKeyboardDismissBehavior value.

I removed all default values of keyboardDismissBehavior and instead use
the one from `ScrollConfiguration`, which use as default value
`ScrollViewKeyboardDismissBehavior.manual`.

This PR try to fix : https://github.com/flutter/flutter/issues/158566

<details/> 

<summary> Code Example </summary>

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      scrollBehavior: const MaterialScrollBehavior().copyWith(
        keyboardDismissBehavior: ScrollViewKeyboardDismissBehavior.onDrag,
      ),
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: TextField(),
      ),
      body: ListView.builder(
        itemCount: 100,
        itemBuilder: (context, index) => ListTile(title: Text('Item $index')),
      ),
    );
  }
}
```

</details>


https://github.com/user-attachments/assets/8341c3da-2685-4f55-b8e9-11d2aae907db



## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
 2025-01-15 21:17:29 +00:00
flutter-pub-roller-bot
36eb78b1b4
Roll pub packages (#161680) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2025-01-15 21:11:26 +00:00
jacobsimionato
010c8a806b
Revert "Autocomplete Options Width" (#161666) 
Reverts flutter/flutter#143249

This broke some Google tests sadly - see b/390128156
 2025-01-15 19:31:59 +00:00
stuartmorgan
fd2b5637b5
Update two_dimensional_scrollables triage routing (#161667) 
`two_dimensional_scrollables` is primarily owned by the framework team
rather than the ecosystem team.
 2025-01-15 19:14:33 +00:00
Jim Graham
a10e25e727
[DisplayList] Migrate from SkRSXform to Impeller RSTransform (#161652) 
Fixes SkRSXform task in https://github.com/flutter/flutter/issues/161456

Removes (nearly) all uses of Skia SkRSXform object from DisplayList and
replaces it with a new Impeller RSTransform geometry object.

There are remaining uses in:
- Skia adapter code which needs to convert them back to SkRSXform when
using the Skia backend
- dl_rendering_tests which is waiting for a major conversion effort
- ?Fuchsia? code has an SkCanvas spy adapter used in its embedder code
(not DisplayList related)
- web_ui/skwasm
 2025-01-15 19:08:38 +00:00
engine-flutter-autoroll
1580a3d3fb
Roll Packages from d1fd6232ec33 to f73cb00e127b (2 revisions) (#161672) 
d1fd6232ec...f73cb00e12

2025-01-14 engine-flutter-autoroll@skia.org Roll Flutter from
72db8f69e339 to 40c2b86fdf65 (33 revisions) (flutter/packages#8428)
2025-01-14 nate.w5687@gmail.com [two_dimensional_scrollables] prepare
for `const AnimationStyle` (flutter/packages#8397)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-01-15 16:31:11 +00:00
Bruno Leroux
44ff2f5977
Fix DropdownMenu isCollapsed decoration does not Reduce height (#161427) 
## Description

This PR fixes DropdownMenu arrow icon position when
`InputDecoration.isCollapsed` is set to true and
`InputDecoration.suffixConstraints` is set to a smaller value than the
min interactive height.

It makes it possible to use collapsed `DropdownMenu` such as:


![image](https://github.com/user-attachments/assets/145c2a0b-a638-4226-ae29-0e21bb9d4bb0)

_____

Before this PR and https://github.com/flutter/flutter/pull/153089,
`InputDecoration.isCollapsed` had no impact on the `DropdownMenu` height
and there was no solution to reduce the height because its minimum
height is enforced by the `IconButton` (arrow down or up) which is part
of the `DropdownMenu`.

Since https://github.com/flutter/flutter/pull/153089, the height can be
reduce with `InputDecoration.suffixIconConstraints` but it results in
the icon being misaligned:


![image](https://github.com/user-attachments/assets/2a4d99bc-c26d-454b-8e62-dd8828789ae5)


After this PR:

When `InputDecoration.suffixIconConstraints` is used the icon is
correctly aligned:


![image](https://github.com/user-attachments/assets/145c2a0b-a638-4226-ae29-0e21bb9d4bb0)


<details><summary>Code sample</summary>

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});
  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return const Scaffold(
      body: Center(
        child: Center(
          child: DropdownMenu<String>(
            dropdownMenuEntries: [
              DropdownMenuEntry(label: 'Item 1', value: '1'),
              DropdownMenuEntry(label: 'Item 2', value: '2'),
            ],
            inputDecorationTheme: InputDecorationTheme(
              contentPadding: EdgeInsets.fromLTRB(5, 0, 5, 0),
              isCollapsed: true,
              // Usable since https://github.com/flutter/flutter/pull/153089.
              suffixIconConstraints: BoxConstraints(minHeight: 24, maxHeight: 24),
              filled: true,
            ),
          ),
        ),
      ),
    );
  }
}

``` 

</details> 

## Related Issue

Fixes [DropdownMenu inputDecoration isCollapsed property does not reduce
vertical spacing](https://github.com/flutter/flutter/issues/138691)

## Tests

Adds 2 tests.
 2025-01-15 15:30:51 +00:00
Jason Simmons
1e79b65ea1
Manual roll of Skia to e7b8d078851f (#161609) 
The Skia->engine roller was disabled for a few weeks during the
migration to the monorepo.
 2025-01-15 15:14:23 +00:00
Taha Tesser
2b34d78c23
Fix TabBar glitchy elastic Tab animation (#161514) 
Fixes [M3 TabBar indicator animation broken both when swiping or
tapping](https://github.com/flutter/flutter/issues/160631)

### Description

This refactors the elastic `Tab` animation. Added additional tests that
follows the elastic animation frame by frame and generates a golden
file.

### Code Sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    // timeDilation = 10;
    return MaterialApp(
      home: ScrollConfiguration(
        behavior: ScrollConfiguration.of(context).copyWith(dragDevices: <PointerDeviceKind>{
          PointerDeviceKind.touch,
          PointerDeviceKind.mouse,
        }),
        child: Directionality(
          textDirection: TextDirection.ltr,
          child: DefaultTabController(
            length: 8,
            child: Scaffold(
              appBar: AppBar(
                bottom: const TabBar(
                  isScrollable: true,
                  tabAlignment: TabAlignment.start,
                  tabs: <Widget>[
                    Tab(text: 'Home'),
                    Tab(text: 'Search'),
                    Tab(text: 'Add'),
                    Tab(text: 'Favorite'),
                    Tab(text: 'The longest text...'),
                    Tab(text: 'Short'),
                    Tab(text: 'Longer text...'),
                    Tab(text: 'Profile'),
                  ],
                ),
              ),
              body: const TabBarView(
                children: <Widget>[
                  Center(child: Text('Page')),
                  Center(child: Text('Page')),
                  Center(child: Text('Page')),
                  Center(child: Text('Page')),
                  Center(child: Text('Page')),
                  Center(child: Text('Page')),
                  Center(child: Text('Page')),
                  Center(child: Text('Page')),
                ],
              ),
            ),
          ),
        ),
      ),
    );
  }
}

```

</details>

### Before (`timeDilation = 10`)


https://github.com/user-attachments/assets/4f69f94b-0bcf-4813-b49f-06ff411435ca


### After (`timeDilation = 10`)


https://github.com/user-attachments/assets/65801c1c-d28f-4b42-870a-7140d5d3c4c3

| Before Test Results | After Test Results |
| --------------- | --------------- |
| <img
src="https://github.com/user-attachments/assets/72ae9fbe-fef9-44a0-9b86-5a4c31fd39cf"
/> | <img
src="https://github.com/user-attachments/assets/2545f35e-ac03-495d-a33b-72b9bc71299b"
/> |

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-15 11:23:41 +00:00
flutter-pub-roller-bot
14d4abbd66
Roll pub packages (#161643) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2025-01-15 06:31:28 +00:00
Matan Lurey
fd1c02d301
Exclude the top-level engine directory from generate_gradle_lockfiles. (#161635) 
For local development workflows, this would find directories we don't
want included in the script.

Added a simple test.
 2025-01-15 03:00:59 +00:00
flutter-pub-roller-bot
97acba4df8
Roll pub packages (#161632) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2025-01-15 01:17:04 +00:00
Matan Lurey
e517ae3457
Refactor android_engine_test, make it easier to debug/deflake locally. (#161534) 
The goal here is to have a great standalone `android_engine_test` suite
that [replaces
`scenario_app/android`](https://github.com/flutter/flutter/pull/160992).

No test is _functionally_ changed in this PR, but overview of changes:
- Finished renaming the suite `android_engine_tests` instead of
`flutter_driver_android`
- Added instructions and an environment variable for local generation of
golden-files (`UPDATE_GOLDENS=1`)
- Added explanations of the individual tests, where they live, and how
to run them locally
- Added a hybrid-composition (HC, not TLHC, which is already tested)
test
- Renamed "other_smiley" to "surface_texture_smiley" (and renamed the
original to "surface_producer_smiley")
- Removed unnecessary ".android" suffix (we will not run this on
anything but Android)
- Added a `tool/deflake.dart` to run a test suite 10x (or custom) times
locally to try and determine flakiness

After this PR, I'll add flags to let you control variants and name the
screenshots accordingly, i.e.:
- API v34 or v35
- OpenGLES or Vulkan (will require an `AndroidManifest.xml` edit during
the test instrumentation)
 2025-01-15 01:05:31 +00:00
Jonah Williams
b515f829af
[Impeller] null check device buffer in image encoding. (#161194) 
Fixes https://github.com/flutter/flutter/issues/160652
 2025-01-15 00:34:53 +00:00
NabilaWorks
e0d7b588b6
Feature/twitter keyboard (#161025) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Fixes https://github.com/flutter/flutter/issues/64801

Example :

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Centered TextField Example',
      theme: ThemeData(primarySwatch: Colors.blue),
      home: CenteredTextFieldScreen(),
    );
  }
}

class CenteredTextFieldScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: Text('Centered TextField')),
      body: Center(
        child: Padding(
          padding: const EdgeInsets.all(16.0),
          child: TextField(
            keyboardType: TextInputType.twitter,
            decoration: InputDecoration(
              border: OutlineInputBorder(),
              hintText: 'Enter some text here',
            ),
          ),
        ),
      ),
    );
  }
}
```


https://github.com/user-attachments/assets/5a2a2a4a-6994-44b1-bb0e-395c24012ef8


https://github.com/user-attachments/assets/aefc7bc5-a997-4e0f-a74e-a39a4517c898

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Jenn Magder <magder@google.com>
 2025-01-15 00:15:15 +00:00
jesswrd
d8322207df
Fixed XiaoMi statusBar Bug (#161271) 
Updated usages of statusBar() to systemBar() to fix XiaoMi statusBar
bug.

Fixes #132831 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-15 00:12:58 +00:00
Michael Goderbauer
a328b36f39
Clean up engine's analysis_options.yaml (#161554) 
Now that we have a monorepo we can vastly simplify the engine's
`analysis_options.yaml` file: It can just import the general rule set
(instead of recreating it) and then we can apply the engine-specific
rules on top of it. This also makes it easier to tell where the engine
rule set differs from the general one.

No more `# DIFFERENT FROM FLUTTER/FLUTTER` comments. 🥳 

Depends on https://github.com/flutter/flutter/pull/161560, which has to
be submitted first.
 2025-01-15 00:08:24 +00:00
Gray Mackall
b3189905ab
Remove gradle_deprecated_settings test app, and remove reference from lockfile exclusion yaml (#161622) 
The test was intentionally broken by
https://github.com/flutter/flutter/pull/160947/. That PR removed the CI
configuration to run the test, but the autoroller (which was previously
turned off) runs a gradle command in all android subdirectories, so the
fact that the directory wasn't deleted is blocking turning the
autoroller back on:


https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8725731612391969937/+/u/run_roll-packages_script/stdout

```
[stderr] * What went wrong:
[stderr] A problem occurred evaluating script.
[stderr] > You are applying Flutter's main Gradle plugin imperatively using the apply script method, which is not possible anymore. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/to/flutter-gradle-plugin-apply
```

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Gray Mackall <mackall@google.com>
 2025-01-14 22:54:07 +00:00
Devon Carew
b53181a01d
[deps] remove no-longer-used repo deps (#161605) 
Remove older repo references; remove older references to `yaml_edit`,
`yaml`, `watcher`, `term_glyph`, `string_scanner`, `stream_channel`,
`stack_trace`, and `watcher`.

Done as part of https://github.com/dart-lang/sdk/issues/56591.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-14 21:50:11 +00:00
Jim Graham
bce2e22231
[DisplayList] remove obsolete use of Skia goemetry objects in DL utils (#161553) 
Accomplishes the `AccumulationRect and MatrixClipTracker` task in
https://github.com/flutter/flutter/issues/161456

Remove legacy Skia geometry APIs from the DisplayList utils classes
(accumulation rect and matrix/clip state tracker) as well as the small
number of remaining uses of them (mostly from their own unit tests).
 2025-01-14 21:25:42 +00:00
Tong Mu
1b7cd83b57
[Engine] Support asymmetrical rounded superellipses (#161409) 
This PR allows rounded superellipses to have asymmetrical and uneven
radii, effectively supporting `BorderRadius` instead of mere `double` as
corner radius. Fixes https://github.com/flutter/flutter/issues/161207.


https://github.com/user-attachments/assets/6293028c-d14b-4ffb-b93e-d0602f5ca0ee

These features exist in SwiftUI: The `RoundedRectangle` class provides
an initializer with a `cornerSize` parameter, allowing different radii
for the horizontal and vertical directions, while the
`UnevenRoundedRectangle` class allows each corner to have a unique
radius. However, SwiftUI does not allow the corners to be asymmetrical
_and_ uneven at the same time, which is supported by this PR.

Additionally, this change allows rounded superellipses to use the same
API as rounded rectangles. This allows RSEs to be added as a style of
`RRect` (just like in SwiftUI), which will use much fewer changes than
adding it as a new shape (>1500 LOC according to my prototype).

This PR also improves performance by removing an intermediate cache for
flipping. Now the point list is only copied once for the triangle strip
rearrangement.

`RoundingRadii` is moved to a separate file, and the code to scale it
based on bounds now its method.

## Pre-launch Checklist


- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-14 21:15:13 +00:00
Loïc Sharma
fa04f4a8d2
[SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (#161464) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

### Background

Flutter generates a `Package.swift` file that contains the plugins that
should be built using SwiftPM.

Since Flutter does not support Swift Package Manager in add-to-app
scenarios yet, Flutter uses CocoaPods to build plugins if you call
`flutter build ios-framework`. To ensure `pod install` is rerun, the
tool deleted the `Package.swift` file.

Unfortunately, deleting the `Package.swift` file causes the Xcode
project to no longer build if it has SwiftPM integration. This caused
the [`build_ios_framework_module_test` to fail when SwiftPM was turned
on by
default](https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20build_ios_framework_module_test/21807/overview).

### Fix

Instead of deleting the `Package.swift` file, we instead generate a
`Package.swift` file with no dependencies. This will invalidate the
fingerprint and cause `pod install` to rerun if the app had plugins that
were previously built using SwiftPM.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-14 21:13:15 +00:00
Harry Terkelsen
e5b1ab040e
[canvaskit] Fix GIF decode failure (#161536) 
Fixes an error when decoding GIFs to check if they are animated. The
decoder needs to be more resilient in the face of Special Purpose blocks
that are in the stream in places not specified in the GIF89a spec.

Fixes https://github.com/flutter/flutter/issues/161376

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-14 21:07:19 +00:00
Jonah Williams
80942d520d
[Impeller] fixes for AHB swapchains. (#161562) 
Fixes for a variety of speculative fixes for AHB swapchain issues.
Details TBD while some tests run...


1. Even If the SurfaceControl API is supported, there is no guarantee
that we can import the AHB as there may be a mismatch in the required
memory properties and what is available. Add a validity check to the
texture pool and bail from the swapchain if any are invalid.

2. Rather than submitting a dummy cmd buffer that does a layout
transition, use the final command buffer signal semaphore.

3. Import the render ready semaphore and use it to block the onscreen
command buffer.
 2025-01-14 20:58:07 +00:00
Michael Goderbauer
3da003c45e
Last Engine<>Framework lint sync (#161560) 
This is the last time we have to do this because in
https://github.com/flutter/flutter/pull/161554 I am refactoring the
engine's analysis_options.yaml to just import the one from the root of
the repository. When that lands, lints only have to be enabled in one
place to apply across framework and engine.

Before we can do that we have to do one last sync to make sure the
engine code base is ready. This PR implements that last sync and fixing
all lints that came up.
 2025-01-14 20:51:42 +00:00
Michael Goderbauer
19a212b5ac
Check that localization files of stocks app are up-to-date (#161608) 
Fixes https://github.com/flutter/flutter/issues/160473
 2025-01-14 20:47:08 +00:00
Camille Simon
818133b8b0
[Android] Actually remove dev dependencies from release builds (#161343) 
Revises https://github.com/flutter/flutter/pull/158026 to fix
https://github.com/flutter/flutter/issues/160407.

Makes a number of fixes:

- Fixes Groovy logic that attempted to remove dev dependencies from
release builds to use `<buildType>Api` versus `api` and loop to
configure the project dependencies per build type
- Adds back dependency on embedding to plugin projects since this is
needed regardless (the plugin may not be included in a particularly
typed build but it still needs it for where it's included)
- Fixes integration test to throw and error upon failure, check right
APK for the release build it's testing, and configure the flag need for
`.flutter-plugin-dependencies` to mark plugins as dev dependencies as
expected
- Uses @matanlurey's
[patch](https://github.com/flutter/flutter/issues/160407#issuecomment-2547546038)
to remove dev dependency from the `GeneratedPluginRegistrant` in release
mode

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-14 19:36:52 +00:00
Ben Konyi
0369b35640
Update package revisions to latest (#161525) 2025-01-14 18:22:42 +00:00
Christopher Fujino
40c2b86fdf
update changelog for 3.27.2 release (#161569) 2025-01-14 17:59:50 +00:00
Taha Tesser
8815d0a536
Fix showLicensePage does not inherit ambient Theme (#161599) 
Fixes [License page colors cannot be changed when wrapped with `Theme`
widget](https://github.com/flutter/flutter/issues/44922)

### Code Sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Sample'),
        ),
        body: Center(
          child: Theme(
            data: ThemeData(colorScheme: ColorScheme.fromSeed(seedColor: Colors.green)),
            child: Column(
              spacing: 20,
              mainAxisAlignment: MainAxisAlignment.center,
              children: <Widget>[
                const AboutListTile(
                  icon: Icon(Icons.info_rounded),
                  applicationIcon: Icon(Icons.info_outline), // Icon for the about dialog
                  applicationName: 'Sample Flutter App', // Name of the app
                  applicationVersion: 'v1.0.0', // Version of the app
                  applicationLegalese: '© 2025 Taha Tesser', // Legal information
                  aboutBoxChildren: <Widget>[
                    Padding(
                      padding: EdgeInsets.only(top: 10),
                      child: Text(
                        'This app is a demonstration of the AboutListTile widget in Flutter.',
                      ),
                    ),
                    Padding(
                      padding: EdgeInsets.only(top: 10),
                      child: Text(
                        'Thank you for using our app!',
                      ),
                    ),
                  ], // Icon for the leading section
                  child: Text('AboutListTile'),
                ),
                Builder(builder: (BuildContext context) {
                  return ElevatedButton(
                      onPressed: () {
                        showAboutDialog(
                          context: context,
                          applicationName: 'Sample Flutter App', // Name of the app
                          applicationVersion: 'v1.0.0', // Version of the app
                          applicationLegalese: '© 2025 Taha Tesser', // Legal information
                          children: <Widget>[
                            const Padding(
                              padding: EdgeInsets.only(top: 10),
                              child: Text(
                                'This app is a demonstration of the AboutListTile widget in Flutter.',
                              ),
                            ),
                            const Padding(
                              padding: EdgeInsets.only(top: 10),
                              child: Text(
                                'Thank you for using our app!',
                              ),
                            ),
                          ],
                        );
                      },
                      child: const Text('showAboutDialog'));
                })
              ],
            ),
          ),
        ),
      ),
    );
  }
}
```

</details>

### Before


https://github.com/user-attachments/assets/a76d19b6-a949-42a1-a349-426ad3058bc6

### After


https://github.com/user-attachments/assets/afb8b519-860e-467f-89bd-6e0a1b7be45c

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-14 17:01:54 +00:00