10351 Commits

Author SHA1 Message Date
P.Y. Laligand
8709e5e71f
[fuchsia] Add explicit sources to a few targets. (#15182) 2018-03-05 18:03:09 -08:00
Yegor
e9c982c39f
[semantics]: minor docs & style clean-up (#15181)
* [semantics]: minor docs & style clean-up

* remove a
2018-03-05 17:01:42 -08:00
Jonah Williams
419fef3f8b
Check that State.initState and State.didUpdateWidget don't return Futures (#15183)
* add a debug check that the returned Type of State.initState and State.didUpdateWidget are not Futures

* add test to verify that async lifecycles throw FlutterErrors

* address some feedback, match implementation of setState check

* address feedback from hixie

* fix odd spacing in test
2018-03-05 15:59:18 -08:00
Sarah Zakarias
f8ac23cd86 Roll engine to a00f8e8bc0f3d08ec0c0ca24b01226441bcaf03a (#15172) 2018-03-05 23:27:57 +01:00
Alexander Aprelev
70f60b17d7
Run dev/bots/test's flutter drive test in preview-dart-2 (#15090)
* Run dev/bots/test's flutter drive test in preview-dart-2

* Fix extension callback type

* More type fixes
2018-03-05 08:55:10 -08:00
Todd Volkert
c885015934
Fix download Dart DK step to work for paths with apostrophes (#15137)
Fixes https://github.com/flutter/flutter/issues/15136
2018-03-04 12:15:22 -08:00
Ian Hickson
fe334e1652
More quoting in Bash (#15087)
Someone ended up with STAMP_PATH containing a blank line.

Also, replace [ with [[.
2018-03-02 17:54:51 -08:00
Hans Muller
6e13128f45
OutlineButton doc fixes (#15092) 2018-03-02 17:43:22 -08:00
Yegor
905f9acf90
[tools] consolidate "preview Dart 2" option in BuildInfo (#15083)
* [tools] consolidate "preview Dart 2" option in BuildInfo

* format BuildInfo constructor
2018-03-02 15:45:55 -08:00
Yegor
973742fe96
[flutter_test] more docs, tests for within; simpler _sizeDistance (#15084)
Document missing value types supported by `within`. Add missing tests. Simplify _sizeDistance implementation.
2018-03-02 15:44:58 -08:00
Siva
beffcf1ba1
Fix incorrect generic type specification, causes a compilation error (#15049)
when a hot reload is done after modifying a component in the flutter
package.
2018-03-02 15:43:40 -08:00
Alexander Aprelev
65731f75bd
Attempt to fix flutter drive --preview-dart-2 errors. (#14897) 2018-03-02 15:16:46 -08:00
Alexander Aprelev
673c5485ae
Generate and use dep-file for --preview-dart-2 (#15077)
* Use depfile in --preview-dart-2 mode.

* Generate and use frontend_server.d to guard against reusing outdated dill files when frontend_server changes.
2018-03-02 11:33:13 -08:00
jcollins-g
bcdbed9628
Add upgrade locking for macs (#15038) 2018-03-02 09:52:14 -08:00
Alexander Aprelev
1a7eeb34da
Roll engine to 97b22348c8d5cba471418dc94f9e384e384e796f. (#15069)
Changes since last roll:
  - Leave only widget creation tracker kernel pass in flutter frontend server. (#4727).
2018-03-02 09:51:48 -08:00
Hans Muller
c4e8438046
Added Material OutlineButton (#14939) 2018-03-02 08:26:23 -08:00
Alexander Aprelev
da24ad0b33
Roll engine to c88ba37c794f57982374bb53a694301198cad593 (#15053)
* Roll engine to c88ba37c794f57982374bb53a694301198cad593.

Changes since last roll:
  - move generated entry points JSON out of flutter_patched_sdk
  - List missing core lib bigint_patch.dart source for new Bigint implementation (#4735)
  - Skip over .emf-files. (#4739)
  - Roll dart to ee15c8eb689791f6777eb3f6b0a1e9c58ff0671b.

* defaultValue -> orElse
2018-03-02 06:23:59 -08:00
Chris Bracken
73a1a74ba1
Eliminate RenderView orientation, timeForRotation (#15044)
Orientation, and by extension time for rotation between orientations,
was aspirational and never used.

While this is technically a breaking change, this code never actually
did anything. If you were setting either orientation or timeForRotation,
simply delete those parameters and the code will continue to behave
identically to how it had been.
2018-03-01 18:34:15 -08:00
Greg Spencer
a1d2443e7b
Fix render problem on Slider (#15039)
Fixes a small rendering problem when dragging the slider, as well as a couple of small bugs (de-duping of value changes, and actually using a parameter passed to _unlerp).
2018-03-01 16:25:21 -08:00
Chris Bracken
b90659cd30
Roll engine to 269bab73b6ad8f0e54fcd2b84f278ba857baf4af (#15036)
Includes:
* Add nil check for country code and language code (flutter/engine#4732)
2018-03-01 15:10:22 -08:00
jcollins-g
050ee9d180
Improve robustness of --version parsing for sdkmanager (#15029) 2018-03-01 14:25:03 -08:00
Greg Spencer
701eff4ac5
Slider Visual Update (#14901)
This implements an update to the look of the Slider widget.

Specifically, it does the following:

* Adds the ability to customize the colors of all components of the slider
* Adds the ability to customize the shape of the slider thumb and value indicator
* Adds the ability to show the value indicator on continuous sliders
* Updates the default value indicator to be a "paddle" shape with new animations.
* Changes the tick marks to be visible all the time on discrete sliders
* Fixes a memory leak of an animation controller.
* Removes "thumbOpenAtMin" flag, which is no longer needed, and can be emulated by the
custom thumb shape support. It was not widely used.
* Adds tests for all of the new features.
2018-03-01 13:03:20 -08:00
Todd Volkert
d2dcec22ce
Provide a more helpful error message when we detect the user is tryin… (#15032)
Fixes https://github.com/flutter/flutter/issues/14950
2018-03-01 12:24:25 -08:00
Todd Volkert
621a963e8b
Fix call to git checkout (#15026)
In the case of "dev", `git checkout dev` could be miconstrued
as checking out the dev _directory_ rather than the branch...

https://github.com/flutter/flutter/issues/14865
2018-03-01 09:28:15 -08:00
Danny Tuppeny
db1a942479
Show 32/64bit in VS Code headings on Windows (#15018)
* Show 32/64bit in VS Code headings on Windows

Fixes #14949.
2018-03-01 17:19:06 +00:00
Alexander Aprelev
d3797628ca
Run flutter tests in preview-dart-2 mode on travis flutter builds. (#14728)
* Run flutter tests in preview-dart-2 mode on travis flutter builds.

* Run dart2 tests on osx. Run dart tests in dart2.

* Fix name camelCase

* Default options to empty array, rather than null

* Troubleshoot failures

* More logging

* Troubleshoot: run single test

* Troubleshoot: run 15 tests

* Troubleshoot: run 15 tests with fix

* Try limit concurrency to 1

* Limit concurrency for preview-dart-2 tests to 4

* Move dart2 tests to allow_failures section

* Reinstate tests_dart_2 shard

* Raise concurrency to 8

* Reuse compiler across multiple test runs

* Allow to switch entry points when recompiling.

Actually use single compiler to incrementally recompile all tests executed by 'flutter test'.

* Remove leftover commented code

* Fix comment

* Lints
2018-03-01 09:04:26 -08:00
Alexander Aprelev
e8d5667a0a
Roll engine to a4b1fccdaa0b2ae8ecaad5f04ae70d2c2403b060. (#15024)
Changes since the last roll:
  - Specify sdkSummary when compiling via frontend server (#4733).
  - Fix traversal order for a11y scrolling (#4726)
2018-03-01 08:06:27 -08:00
Jacob Richman
7dbe9e7bcd
Fix cases where previewDart2 and trackWidgetCreation were (#14994)
accidentally missed due to named parameters being omitted.
2018-03-01 07:19:21 -08:00
Chris Bracken
eaa9848fd4
Improve error message for missing 32-bit libstc++ (#15004)
Adds more actionable error messages for users of the most common Linux
distributions. We could improve this by checking the current
distribution and emitting only the appropriate error message. We could
further improve that by only emitting the install instructions if we
determine the appropriate package is not installed.

See: https://github.com/flutter/flutter/issues/6207
2018-02-28 17:53:38 -08:00
xster
a8e0f76873
Don't push again on beta branch commit (#15001) 2018-02-28 17:06:54 -08:00
Ian Hickson
b9a7f1b915
Add a hasListeners to ChangeNotifier (#14946)
I found that some ValueListeners want to know when they should start
doing work (e.g. if the value comes from polling a network resource).
2018-02-28 16:37:36 -08:00
Alexander Markov
b011c66653
Roll engine to 66072316382837e66aaea518d219192a80839fc3 (#15000)
This roll contains:
* Make deprecated API unavailable (https://github.com/flutter/engine/pull/4722)
* Remove unavailable API in FlutterDartProject.h (https://github.com/flutter/engine/pull/4723)
* remove unavailabe API from FlutterDartProject.mm (https://github.com/flutter/engine/pull/4724)
* Prepare to enable global type flow analysis in AOT (https://github.com/flutter/engine/pull/4725)
2018-02-28 16:34:18 -08:00
xster
265d0d3c29
Add more haptic feedback varieties (#14829)
* Add more haptic feedback varieties

* tests

* un-meta-ify the test
2018-02-28 16:20:27 -08:00
Todd Volkert
ff04e79380
Actually update the docs site (#15003)
Fixes https://github.com/flutter/flutter/issues/15002
2018-02-28 16:12:04 -08:00
Phil Quitslund
a3f520e488
Add ‘name’s to widget location Json. (#14993) 2018-02-28 15:33:56 -08:00
Alexander Aprelev
9a9aed191d
When doing flutter test use batch compiler and link platform in. (#14983)
This is to fix #14931.
2018-02-28 12:54:30 -08:00
Danny Tuppeny
ae9fdefa4f
Fix example code just showing endless spinner when deployed from Windows (#14878)
* If example code is not found, render a message instead of an endless spinner
* Trim codeTags to avoid lookup issues with windows carriage returns
* Trim \r on Windows off the end of code blocks so they're consistently \n
* Add a test to ensure sample code parses if built on Windows
* Add a comment about why we trimRight()

Fixes #14820.
2018-02-28 20:39:48 +00:00
najeira
e0956cbdb7 remove "the" duplications (#14952) 2018-02-28 12:21:13 -08:00
jcollins-g
614df6949c
Android license detector in doctor, take two (#14783)
* Revert "Revert "Add android license verification to doctor and some refactoring" (#14727)"

This reverts commit d26029475222e8b1c7d8b80072c6b6261e2c3551.

* Add tests, fix sdkManagerEnv and use it consistently, and rearrange Status object model

* AnsiSpinner needs to leave the cursor where it found it.

* fix tests

* Const constructor warning only shows up on windows...?

* Avoid crash if we can't find the home directory

* Make pathVarSeparator return a string in the mock

* Implement review comments

* Fix out-of-order problem on stop
2018-02-28 12:09:52 -08:00
Todd Volkert
97091f513a
Fix create template for "package" (#14976)
Fixes https://github.com/flutter/flutter/issues/14975
2018-02-28 11:53:03 -08:00
Siva
fbf68bbc6d
Roll engine to version b05efc204090f430387398d3c35589571a2fe16b (#14969)
* roll engine version in flutter/flutter to b05efc204090f430387398d3c35589571a2fe16b

* Fix analyzer warnings.
2018-02-28 11:00:37 -08:00
Mikkel Nygaard Ravn
465478dac4
Update google repo url (#14958) 2018-02-28 13:34:45 +01:00
amirh
6993b203c0
Allow changing a clipper's type (ShapeBorderClipper,_BottomAppBarClipper). (#14937)
The downcast was crashing when toggling hasNotch for BottomAppBar.
2018-02-27 17:39:49 -08:00
Chris Bracken
ae6ac2ca74
Add .dart_tool to gitignore (#14932)
Dart is migrating to .dart_tool/ as the location for cached artifacts
and other temporary files generated by tooling in the SDK. As part of
this, pub will be migrating from .pub to .dart_tool/pub.

In future, this path will also be used for other tooling, such as package:build.
2018-02-27 15:29:31 -08:00
Victor Choueiri
9c895fabf2 Add intelliJ path to doctor output (#14795) 2018-02-27 15:19:32 -08:00
Todd Volkert
a5d3a9eb4b
Roll engine to e133da723c603eb43c5bf03aeb27e79c06a50e0c (#14924) 2018-02-27 15:16:21 -08:00
jcollins-g
66e3f9d8aa
Upgrade dartdoc to 0.17.0 (#14929) 2018-02-27 14:39:42 -08:00
Greg Spencer
29d59e3cb7
Switch Mac packaging to use .zip files. (#14894)
We can't use .tar.xz on Mac because although it can unpack them on the command line (with tar), the "Archive Utility" that runs when you double-click on them just does some crazy behavior (it
converts it to a compressed cpio archive, and when you double-click on that, it converts it back to .tar.xz, without ever unpacking it!)

So, this changes the script to use .zip for Mac, and the files are about 220MB larger than they need to be.
2018-02-27 13:15:32 -08:00
Todd Volkert
5dca13dea5
Remove flaky marker from android_sample_catalog_generator (#14923) 2018-02-27 10:30:45 -08:00
Alexander Aprelev
3b84503403
Move quotes around to help Powershell 2.0 to substitute variable with value (#14907) 2018-02-26 20:11:11 -08:00