10351 Commits

Author SHA1 Message Date
Mikkel Nygaard Ravn
340c68038a
Make standard codecs extensible (#15414) 2018-03-16 16:17:56 +00:00
Mikkel Nygaard Ravn
2d5ebd2a18
Roll engine to 9671f634591295aca35943df1cc589e9fbf59d14 (#15607) 2018-03-16 15:09:01 +00:00
Mikkel Nygaard Ravn
04de8c0a43
Adjust flaky flags to reality (#15608)
Get to green build.
2018-03-16 11:17:23 +00:00
Nicholas Rebhun
ab56c63971 Update README; beta release (#15098) 2018-03-16 00:29:49 -07:00
Hans Muller
c599662903
Added a Backdrop demo to the Gallery (#15579) 2018-03-15 17:52:09 -07:00
David Shuckerow
dd0acea1ec
Add support for placing the FAB in different positions (#14368)
* Add support to move the fab between positions.

* Motion demo for the FAB works between center and end floating.

* Add a Material curve to the offset animation.

* Move the fab position into an object

* Updates to docs

* Updates to docs

* Fix a lint on the bottom sheet type

* Add a ScaffoldGeometry class

* Improve the documentation

* Improve the documentation

* Add a fab motion animator

* Add position and scale animations

* FAB entrance and motion animations work

* Get started on FAB motion

* Make fab animation work properly.

* Change the fab animator to be stored in the state of the scaffold.

* Add a layout test

* Fix spacing being off

* Fix the entrance/exit animation test.

* Add a textDirection to the layout delegate.

* Fix const constructor lint checks

* Add toStrings for the fab positioner/animator

* Add a toString for CurveTween

* Change the fab motion demo icon to a simple add icon.

* Add tests and a custom fab positioner to the demo.

* Do not start the fab's motion animation when the fab is null.

* Adjust the code to pass the new tests.

* Rename for in response to Hans' comment.

* Revert the tabs fab demo

* Use timeDilation, and clean up the animation code a little.

* Clean up the prelayout geometry docs and ctr order

* Cleanup fab transition widget code

* Clean up comments on Scaffold, add cross-references between the two geometries

* Explain the fab motion animation scheduling better

* Add a const to the fab motion demo

* Make the fab animation never jank by keeping track of where to move the fab to in the future.

* Add a default fab positioner constant

* Add space after comma in the demo

* Add boilerplate dartdoc to all const constructors

* Comment improvement

* Rename 'fabSize' to 'floatingActionButtonSize'

* Rename 'fabSize' to 'floatingActionButtonSize'

* Rename 'fabSize' to 'floatingActionButtonSize'

* Clean up the prelayout geometry object's dartdoc

* Clean up the prelayout geometry object's dartdoc

* Remove extraneous comment

* Change possessive uses of Scaffold's to use dartdoc-compatible [Scaffold]'s

* Rename the horizontalFabPadding to an expansion

* Clean up controller cleanup and setState usage

* Animate instead of lerp

* Make the fab position animation use offsets instead of animations

* Streamline the fab motion demo

* Set up the animator to start from a reasonable place when interrupting animations.

* Doc cleanup on the new animation interruption

* Expand some uses of fab and clean up constants

* Expand remaining public uses of fab to floating action button

* Expand remaining public uses of fab to floating action button

* Expand on the documentation for the fab positioner and animator

* Refactor animations to broadcast the position properly.

* Add the ability to turn on and off the fab to the motion demo.

* Remove unused code

* Change the fab animator to animate even when the fab is exitting.

* Remove extra positioner.

* Apps -> Applications in docs

* Explain the scale animation.

* Name the child parameter in the animated builder

* RTL before LTR

* Wrap the AppBar in the example code

* const the fab motion demo name

* Start a test against animation jumps

* Test for jumps in the fab motion animation

* Dont initialize values to null

* Use constants, fix spacing from some of Hans' comments

* Clarify the relationship between fab positioners and prelayout geometries

* Explain the fab animmator a bit better

* Explain the animation progress in the fab animation

* Explain the animation restart better

* Explain the animation restart better

* Explain the prelayout geometry better

* Explain that height is a vertical distance.

* Explain the horizontal fab padding

* Update the scaffold size description to explain what happens when a wild keyboard appears

* Remove print statements

* Update the scaffold geometry with information about it being available at paint time.

* In one step of a transition

* Explain how the top-start fab positioner works

* Explain how the top-start fab positioner works

* Refactor the scaffold layout to just pass a padding instead of a bottom, top, start and end.

* Refactor the scaffold layout to just pass a padding instead of a bottom, top, start and end.

* Action buttons with with custom positioners.

* Add a rotation animation example.

* Use a swap animation to show swapping between two different animations.

* Use a swap animation to show swapping between two different animations.

* Add an example for the size animations.

* 2018 copyright

* Extra empty line

* Return new Scaffold

* Extra blank line fix

* All its contents have been laid out

* Position the fab

* Explain what the scaffold geometry is for.

* Move asserts to different lines

* The scaffoldsize will not

* Initial rename of FabPositioners to FloatingActionButtonLocation

* Rename comments in example to refer to location instead of positioner.

* Rename fabpositioner to location in tests and in the scaffold field

* Finish removing references to positioner in scaffold code.

* Split the fab location and animation out into a separate file.

* Make things more private

* Import foundation instead of meta

* Const curve instead of final.
2018-03-15 17:04:24 -07:00
Hans Muller
600739d195
Fix "my be entered" should be "may be entered" typo (#15540) 2018-03-15 12:06:37 -07:00
Keerti Parthasarathy
50190d2810
Do not encode the server port in the test file (#15535)
* Do not encode the server port in the test file

* revert formatting

* add back ignore

* add a default value to serverPort

* address comments
2018-03-15 10:56:10 -07:00
Siva
c640b19167
Roll engine to version 520529dbba9b3048f5cc0e0268a274911f3887e6 (#15560)
- picks up dart change to introduce multi root file system for use in
google3 builds
2018-03-15 07:30:32 -07:00
Vyacheslav Egorov
d693d427d8
Upgrade packages to pull in newest petitparser with Dart 2 fixes. (#15558)
* Upgrade packages to pull in newest petitparser with Dart 2 fixes.

* Don't allow Dart 2 failures.

* Address new lints discovered by updated analyzer.
2018-03-15 11:11:13 +01:00
Siva
8c75dcf1bd
Engineroll (#15547)
* iupdate engine version to 141176b9004d7b01325629fd45b2ef61b0d00251

* update engine version to f192c59d76c0afe63f2290c3ed76061f00c77cc7
This rolls dart to version 0175f24b2549732d0010708988fd328440c3f956

* Move dart 2 tests back to optional section to allow debugging of a new
regression in the petitParser package.

* Update
2018-03-15 00:18:34 -07:00
xster
85d42fb396
Wrap route transitions above the transition as well to prevent repaints (#15534) 2018-03-14 18:37:53 -07:00
Marcin Urbański
2609876c8f Fix misspelling in tab description (#15449)
Actual text: "Tab 2 of $3"
Expected text: "Tab 2 of 3"
2018-03-14 16:04:06 -07:00
Conor Dockry
b0f7da9249 Choose default icon color based on theme brightness (#15450)
* Use theme for default icon color

Replaces hard-coded black.

* Better icon defaults for dark/light modes

* Add default case to silence warning
2018-03-14 16:01:38 -07:00
Hans Muller
b6cca3923a
Updated the gallery text fields demo (#15362) 2018-03-14 14:42:45 -07:00
Greg Spencer
c345c1bbea
Fix the remote setup to only change the URL. (#15528)
This changes the packaging tool to only set the remote URL instead of recreating the remote.

Recreating it was removing some metadata that identified the repo as having been cloned from the "real" repo, so flutter --version would report an unknown channel and source. This just sets the URL so that it looks like it came from GitHub.

I also fixed some incorrect comments, and made unzip work on platforms other than Windows (even though we don't really need it there yet).

Fixes #15518
2018-03-14 12:56:44 -07:00
Hans Muller
d671267a20
Increase hint text contrast ratio to 4.5 (#15504) 2018-03-14 12:15:21 -07:00
jcollins-g
e568178de5
Update dartdoc to 0.17.1+1 for flutter (#15522) 2018-03-14 11:50:20 -07:00
Hans Muller
4c7cc73637
Added an additional Material theme to the Gallery (#15492) 2018-03-14 10:52:06 -07:00
Jonah Williams
231170a7c5
Replace child parameter with builder on showDialog (#15303)
* replace child parameter with builder on showDialog

* change builder parameter to WidgetBuilder

* mark child as deprecated and expand documentation to cover this and how builder should be used

* tidy comments and address some feedback

* phrasing

* move space to prev line and add //ignore comments for deprecated member use

* address comments and fix it's its

* update code samples

* adds semicolon to code snippets
2018-03-14 10:40:24 -07:00
Jonah Williams
9a8b460209
change ThemeData.primaryColor to PrimarySwatch instead of PrimarySwatch[500] (#15265)
* change ThemeData.primaryColor to PrimarySwatch instead of PrimarySwatch[500]

* fix mismatched color in stock test case
2018-03-14 10:39:56 -07:00
Hans Muller
9a3b6c3b56
Text form field initial value (#15484) 2018-03-14 10:21:20 -07:00
Alexandre Ardhuin
7667db6362
apply upcomming prefer_const_declarations (#15498) 2018-03-14 06:24:49 +01:00
Alexander Aprelev
7b8c79634d
Move dart2 tests from 'allowed to fail' to 'required to pass' (#15491) 2018-03-13 19:31:31 -07:00
Jason Simmons
5a58b36e36
Roll engine to e61bb9ac3a3fd789754e2e54220bcfc27076a857 (#15495)
This engine has libtxt enabled by default
2018-03-13 13:20:13 -07:00
Jason Simmons
b9bd51cc36
Roll engine to e44cd55fc452ba5524147280c451fb3ace350ec4 (#15494) 2018-03-13 12:42:29 -07:00
Greg Spencer
d28e9aa5c9
Add slider minimum interaction time (#15358)
This change makes the discrete slider show the value indicator for a minimum amount of time for any interaction (tap, drag).
2018-03-13 09:41:49 -07:00
Greg Spencer
fc96326b9c
Add neck stretch (#15445)
During the review, we determined that it would be good for the value indicator to stretch when the text scale was smaller, and the shrink when it was larger, to keep the value visible over the finger at small sizes, and closer to the finger at large sizes. This implements that change.
2018-03-12 20:28:34 -07:00
Chris Bracken
dc03398bc3
Avoid NPE in InkDecoration dispose (#15473)
Avoids a null pointer exception if dispose() is called on an
already-disposed InkDecoration.
2018-03-12 19:05:55 -07:00
Alexander Aprelev
e23a658685
Rev dependencies up and regenerate stock_messages. (#15469)
This fixes https://github.com/flutter/flutter/issues/15458.
2018-03-12 17:46:26 -07:00
Jonah Williams
d682259eab
Use a set to remove duplicate channel names (#15392)
* Use a set to remove duplicate channel names

* Add test for git command
2018-03-12 17:04:02 -07:00
Alexander Aprelev
2f8474f9aa
Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f. (#15444)
* Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f.

Changes since last roll:
```
b6df7a637 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (#4771)
a6764dbd5 Add sources for Fuchsia target. (#4763)
2d5900615 [fuchsia] Remove unused header file. (#4769)
9717063b7 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)" (#4768)
9a9814312 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)
e74e8b35c [async] Update includes of async headers to new path (#4760)
e2c4b2760 Use Dart 2 camel case constants in the engine Dart libraries (#4766)
9c1e48434 Updates for Fuchsia roll. (#4765)
14c940e27 Switch from fxl::Mutex to std::mutex (#4764)
debf82c0b Roll Garnet (#4759)
5bffdefbb Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (#4761)
```
2018-03-12 15:44:25 -07:00
Hans Muller
07eb5ea0be
Added custom selection indicators to the gallery scrollable tabs demo (#15323) 2018-03-12 12:20:33 -07:00
Mikkel Nygaard Ravn
a61592793c Silence broken test (#15446)
* Silence broken test

* Mark test as flaky instead
2018-03-12 12:02:58 -07:00
Jason Simmons
466d15433f
Use Dart 2 camel case constants (#15360) 2018-03-12 11:06:32 -07:00
Hans Muller
33f9afd99c
Updated the BottomNavigationBar class doc (#15347) 2018-03-12 10:27:20 -07:00
Hans Muller
11d81b11d7
Add OutlineButton, Tristate Checkbox to Flutter Gallery (#15312) 2018-03-12 10:21:14 -07:00
Danny Tuppeny
465929f71e Remove flaky flag from all tests that are green for the whole dashboard
Plus run_machine_concurrent_hot_reload which isn't all green, but is
green since the fix was pushed.
2018-03-12 17:03:21 +00:00
Mikkel Nygaard Ravn
658f9e6c83
Make plugins work in Swift projects (#15437) 2018-03-12 17:33:10 +01:00
P.Y. Laligand
c0118ea4b9
Leave source list empty for Fuchsia targets. (#15337) 2018-03-12 15:38:32 +01:00
xster
c8fd99fb33
Add a simple convenience test task runner for VSCode (#15417) 2018-03-12 01:05:23 -07:00
Siva
e5ba3041cd
Update dart-petitparser and dart-xml packages (#15376)
* Update the following packages
- dart-petitparser to 1.7.5
- dart-xml to 3.0.3
- image to 1.1.30
These updates fix some of the strong mode errors we were encountering
while running flutter tests.
2018-03-11 18:57:14 -07:00
Ian Hickson
7865d319ba
Factor out BorderSide creation for dividers (#15403)
This allows other code to get the same style without having to know exactly it is computed.
2018-03-11 13:01:00 -07:00
Ian Hickson
ded3905102
Various documentation improvements. (#15071)
For example, mention the icon used for the drawer menu in the docs (this helps people writing unit tests); add DefaultAssetBundle sample code.
2018-03-11 03:19:18 -07:00
Ian Hickson
48bb5b7926
Include opacity in FadeTransition logging (#15073) 2018-03-09 22:49:19 -08:00
Greg Spencer
984a24c51b
Fix error handling for the packaging script (#15351)
This fixes the error handling for the packaging script so that it will properly report a failure exit code when it can't find the executable that it's looking for.

Added a test too.
2018-03-09 18:58:41 -08:00
Jason Simmons
4b56ba17d5 More fixes for the prefer_const_literals_to_create_immutables analyzer check (#15363)
See 3961306bad
2018-03-09 16:47:56 -08:00
Alexandre Ardhuin
3961306bad enable lints prefer_const_declarations and prefer_const_literals_to_create_immutables (#14848) 2018-03-09 14:37:06 -08:00
Greg Spencer
7fab7f6d02
Adding edge avoidance, painting tests, general cleanup (#15078)
Fixed the real repaint problem the Slider had (missing addListener), and added tests for it.

Added GlobalKey reparenting test.

Added the ability for the value indicator to slide left and right to avoid falling off the edge of the screen.
It only shifts as much as it can without deforming, but even at large text scales, that is enough to keep the text on the screen.

Updated the formatting on theme_data.dart and others to use longer line length.

Also, removed a color tween that faded the value indicator in as it scaled, since that wasn't to spec.
2018-03-09 14:04:58 -08:00
Michael Goderbauer
3a40d0ee4e
Support SemanticsFlag for Header (#15255) 2018-03-09 13:32:01 -08:00