Relands the "Scribble mixin" PR, which was reverted due to breaking a Google test in the last roll.
Breaks the Scribble feature out of TextInputClient in order to avoid breaking changes.
* exclude xcworkspace that begins with a period
* fix if spacing, add comment
* add unit test for when no xcworkspace found
* update to use xcodeWorkspace, make it nullable and refactor
* check if hostAppRoot exists before trying to get xcworkspace
* use local variables to take advantage of type promotion
* only check if not null, don't need to check if exists
* readd exist check for migrate
* readd missing line at end of file
* fix text field hint style overflow not work, keep default ellipsis.
* fix cupertino text field hint style overflow not work, keep default ellipsis.
* add Cupertino placeholder style test.
Increases the minimum macOS deployment target from macOS 10.13 (High Sierra) to 10.14 (Mojave) in the macOS app templates.
Includes:
* Update migration for macOS 10.11 apps to upgrade to 10.14
* Adds migration for macOS 10.13 apps to upgrade to 10.14
* Apply migration to all examples, and integration tests
This does not increase version in the plugin templates since those will need to wait until the 10.14 framework rolls to stable channel, so new plugins can build with apps created with `flutter create` on stable channel.
Issue: https://github.com/flutter/flutter/issues/114445
See RFC: http://flutter.dev/go/flutter-drop-macOS-10.13-2022-q4
See previous patch: https://github.com/flutter/flutter/pull/107689
When testing whether a macOS deployment target version migration is
unnecessary due to already being at the target version, we were
previously checking the iOS deployment target version rather than the
macOS version. This updates it to test MACOSX_DEPLOYMENT_TARGET instead.
These were marked flaky due to a timeout switching between items in the
Studies list at the top of the screen, which had snap-to-item scroll
physics.
The same flake also affected new_gallery_impeller__transition_perf which
was failing with the same flake, though was separately marked flaky due
to a separate (engine crash) flake documented in:
* https://github.com/flutter/flutter/issues/112577
* https://github.com/flutter/flutter/issues/112438
Leaving the latter marked flaky for the time being while that separate
issue is investigated.
Issue: https://github.com/flutter/flutter/issues/114025
* b74471702 Roll Fuchsia Linux SDK from 7e3H7isxOF6vqMDTT... to mDzQK4ZUk_Y4wfZa_... (flutter/engine#37337)
* 2af329fa2 Roll Skia from 7a98accb20d5 to a34882309d04 (7 revisions) (flutter/engine#37334)
* cf56eb556 32 cores (flutter/engine#37339)
* aeae6afb7 Roll Dart SDK from b2aad7caafc9 to d97d5ad98893 (1 revision) (flutter/engine#37333)
* 396be860f [Impeller] Remove cached pipelines when RuntimeStage is hot reloaded (flutter/engine#37307)
* 223a485ce Handle include paths the same way as output paths (flutter/engine#37335)
* 24c3a9f51 fix recursive self calls (flutter/engine#37321)
* 2a1be6d4d Roll Skia from dc49f35e1ac6 to 7a98accb20d5 (6 revisions) (flutter/engine#37328)
* ba390f2a7 [web] Unify JS configuration. Make it available from initEngine. (flutter/engine#37187)
* d413cc511 Add unreachable for vulkan switches (flutter/engine#37324)
* e32bff47e Copy Windows gen_snapshot to a standard location (flutter/engine#37318)
* af1a2da13 Increase Win32 trackpad polling rate, fix repeated swipes issue (flutter/engine#37154)
* 28e1ea0cc Roll Fuchsia Mac SDK from JKfnEvEVIL_Cg3_9f... to jAKH68TYoKUA5HNS2... (flutter/engine#37325)
* cf22fc23f Revert "reland "Migrate darwin common "framework_shared" target to ARC #37049" (#37219)" (flutter/engine#37320)
* 3c5712bef Roll Dart SDK from 35b0cc8ac48b to b2aad7caafc9 (1 revision) (flutter/engine#37322)
* 0933ca485 Revert "Roll Clang from a93d03310e2c to bca75abc01f3 (#37076)" (flutter/engine#37323)
Causes analysis errors:
```
info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:513:5 • always_specify_types
info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:514:10 • always_specify_types
info • Avoid method calls or property accesses on a "dynamic" target • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:515:11 • avoid_dynamic_calls
info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:515:48 • always_specify_types
info • Separate the control structure expression from its statement • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:515:77 • always_put_control_body_on_new_line
info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:516:7 • always_specify_types
info • Avoid method calls or property accesses on a "dynamic" target • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:518:11 • avoid_dynamic_calls
info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:518:51 • always_specify_types
info • Separate the control structure expression from its statement • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:518:77 • always_put_control_body_on_new_line
info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:519:7 • always_specify_types
info • Avoid method calls or property accesses on a "dynamic" target • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:521:11 • avoid_dynamic_calls
info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:522:21 • always_specify_types
info • Separate the control structure expression from its statement • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:522:58 • always_put_control_body_on_new_line
error • The argument type 'dynamic' can't be assigned to the parameter type 'String' • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:524:38 • argument_type_not_assignable
info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:540:5 • always_specify_types
info • Avoid escaping inner quotes by converting surrounding quotes • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:541:14 • avoid_escaping_inner_quotes
info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:542:5 • always_specify_types
error • The argument type 'dynamic' can't be assigned to the parameter type 'List<dynamic>' • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:544:45 • argument_type_not_assignable
info • Remove unnecessary backslashes in strings • packages/fuchsia_remote_debug_protocol/test/fuchsia_remote_connection_test.dart:114:55 • unnecessary_string_escapes
info • Remove unnecessary backslashes in strings • packages/fuchsia_remote_debug_protocol/test/fuchsia_remote_connection_test.dart:204:55 • unnecessary_string_escapes
info • Remove unnecessary backslashes in strings • packages/fuchsia_remote_debug_protocol/test/fuchsia_remote_connection_test.dart:289:55 • unnecessary_string_escapes
```
This reverts commit b187bc474e93aa9b0d58cd194b8d67b2bdf5eeec.
* [fuchsia_remote_debug_protocol] Switch the way we retrieve the vm_service_port from /hub to iquery, on device.
* [fuchsia_remote_debug_protocol] Switch the way we retrieve the vm_service_port from /hub to iquery, on device.
* 9584880f4 Use iOS 16 APIs to rotate orientation (flutter/engine#37302)
* 2ac9c73f6 Move primitive type to pipeline descriptor (flutter/engine#37315)
* 6950689ed Roll Skia from 7a45d3123f8b to dc49f35e1ac6 (6 revisions) (flutter/engine#37319)
* f3d0b6af7 Fix TextField performing both new line and input action (flutter/engine#36893)
* e947833ce Roll Skia from 1272b520c082 to 7a45d3123f8b (4 revisions) (flutter/engine#37316)
* f8122dc89 [ci]Temporarily disable starqlteue on firebase device lab (flutter/plugins#6657)
* 38c93242a [video_player]add integration test for inverted aspect ratio bug (flutter/plugins#6662)
* dd8245e32 Roll Flutter (stable) from 6928314d505d to e99c9c7cd9f6 (2 revisions) (flutter/plugins#6667)
* 8cfa2652c Roll Flutter from 0e98194681fd to e6300da2c39f (46 revisions) (flutter/plugins#6668)
* 897ec59cd [ci] Removes unnecessary overrides. (flutter/plugins#6669)
* a279b9dd8 Roll Flutter from e6300da2c39f to 55e8cd178621 (17 revisions) (flutter/plugins#6670)
