Matan Lurey
71d50a1616
Start using bin/cache/engine.{stamp|realm} instead of bin/internal/engine.{realm|version}. ( #164352 )
...
Towards https://github.com/flutter/flutter/issues/164315 .
See also:
https://github.com/flutter/flutter/blob/master/docs/tool/Engine-artifacts.md .
There are more usages in `flutter/flutter`, but some will require more
specialized review (i.e. from release folks, or the Dart SDK team), so
I'll split those off.
~~Requires https://github.com/flutter/flutter/pull/164317 to merge
first.~~ ✅
2025-03-02 00:54:33 +00:00
Chris Bracken
0c055f2c50
Add macos/android_debug_unopt to local_engine.json ( #164410 )
...
Adds a local build for the 32-bit Android embedder on macOS hosts.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-01 06:48:18 +00:00
Chris Bracken
d6089dde09
Delete unused build archive targets ( #164414 )
...
This migration is incomplete and is no longer planned.
Issue: https://github.com/flutter/flutter/issues/105351
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-01 06:16:04 +00:00
engine-flutter-autoroll
87c87c09af
Roll Fuchsia Linux SDK from QMun2itYrV_zUYrvW... to ln3joxJfRN2XGhvCv... ( #164423 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC matanl@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-01 05:30:25 +00:00
engine-flutter-autoroll
207e1e37bb
Roll Skia from ac14158663ea to ad64415050aa (1 revision) ( #164413 )
...
https://skia.googlesource.com/skia.git/+log/ac14158663ea..ad64415050aa
2025-02-28 kjlubick@google.com More cleanups in blitter code
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-01 01:26:25 +00:00
Eric Seidel
3f2e57906f
Update linux_host_engine.json ci/host_release description ( #164402 )
...
Describe what is actually being produced by this target.
This target was just copy/pasted from the debug target (which does
produce more things), but really what this is doing is
compiling/uploading flutter_patched_sdk_product.zip which is used by
*all* release mode targets.
2025-03-01 00:38:28 +00:00
Jason Simmons
171ba00b58
In update_engine_version_test.dart, do not populate the test environment with the host platform environment ( #164395 )
2025-03-01 00:27:25 +00:00
Matan Lurey
d859e2f43e
Roll-forward #164317 : Use bin/cache/engine.stamp ( #164401 )
...
... and this time, create `bin/cache` before trying to write to it!
(Tests updated to catch this regression)
2025-03-01 00:10:44 +00:00
yim
246d6c6834
Make pressing and moving on CupertinoButton closer to native behavior. ( #161731 )
...
Fixes : #91581
This PR adds an `onTapMove` event to `TapGestureRecognizer`, and then
`CupertinoButton` uses this event to implement the behavior of the
native iOS `UIButton` (as shown in the issue). It is worth noting that
this PR slightly changes the way `CupertinoButton`'s `onPressed` is
triggered. Specifically, it changes from being triggered by
`TapGestureRecognizer`'s `onTap` to checking if the event position is
still above the button in `TapGestureRecognizer`'s `onTapUp`.
Additionally, it removes the previous behavior where the gesture was
canceled if moved beyond `kScaleSlop` (18 logical pixels). Overall,
previously, `onPressed` could not be triggered if the button was pressed
and then moved more than 18 pixels. This PR adjusts it so that
`onPressed` cannot be triggered if the button is pressed and then moved
outside the button.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-28 23:57:35 +00:00
engine-flutter-autoroll
7f23dc7a0d
Roll Skia from 4005ba3ca7b6 to ac14158663ea (7 revisions) ( #164404 )
...
https://skia.googlesource.com/skia.git/+log/4005ba3ca7b6..ac14158663ea
2025-02-28 lukasza@chromium.org [rust png] Refreshing TODO comments to
point to most-recent bugs.
2025-02-28 lokokung@google.com [dawn][headers] Removes ifdefs for
wgpu::Limits.
2025-02-28 kjlubick@google.com Add test for SkBlendARGB32
2025-02-28 kjlubick@google.com Move SkColorData to src/core
2025-02-28 borenet@google.com [infra] Fixes to support iOS devices in
new lab
2025-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 96a1bda4c1b6 to 421109ac5be0 (6 revisions)
2025-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 2f85feff104d to 922ff58ecda3 (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-28 23:05:16 +00:00
Matej Knopp
07503bbc82
[macOS] Prepare FlutterKeyboardManager for multi-view ( #163962 )
...
Notable changes:
- Moved keyboard layout related code from `FlutterViewController` to
`FlutterKeyboardLayout`.
- `FlutterKeyboardManager` is now owned by the engine and shared between
view controllers. The per view controller part, which is associated with
event, has been moved from `FlutterKeyboardManager` delegate to
`FlutterKeyboardManagerEventContext`.
- The `FlutterKeyboardManagerDelegate` is implemented by
`FlutterEngine`.
- Some overall clean-up and dead code removal (i.e. `_NSResponderPtr`
and `NextResponderProvider`)
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-02-28 22:28:25 +00:00
Matej Knopp
b831b269c5
Add PlatformDispatcher.engineId ( #163476 )
...
Fixes https://github.com/flutter/flutter/issues/163430 .
This PR adds `engineId` field to `PlatformDispatcher`. When provided by
the engine, this can be used to retrieve the engine instance from native
code.
Dart code:
```dart
final identifier = PlatformDispatcher.instance.engineId!;
```
macOS, iOS:
```objc
FlutterEngine *engine = [FlutterEngine engineForIdentifier: identifier];
```
Android:
```java
FlutterEngine engine = FlutterEngine.engineForId(identifier);
```
Linux
```cpp
FlEngine *engine = fl_engine_for_id(identifier);
```
Windows
```cpp
FlutterDesktopEngineRef engine = FlutterDesktopEngineForId(identifier);
```
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-28 22:20:11 +00:00
Matan Lurey
600ee30696
Move integration_test.FlutterDeviceScreenshotTest to the framework slow shard ( #164398 )
...
Closes https://github.com/flutter/flutter/issues/164177 .
[Every](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8721680858175088673/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout )
[recent](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8721678607671718689/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout )
[failure](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8721668796723786737/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout )
is `integration_test.FlutterDeviceScreenshotTest`, which is run using
Gradle, and often takes 5m+. This test is already [close to hitting its
threshold of 30m
consistently](https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Windows%20framework_tests_misc ):
I am proposing moving this test to `Linux framework_tests_slow`, it does
not have a lot of value to run on every platform, and is indeed, slow.
2025-02-28 21:54:54 +00:00
Kishan Rathore
1bafd3e0d6
Fix: Update DelegatedTransition animation parameter correctly ( #163853 )
...
Fix: Update DelegatedTransition animation parameter correctly
fixes : #163389
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-28 21:05:26 +00:00
auto-submit[bot]
34a11c405d
Reverts "Write an identical value to bin/cache/engine.stamp to prepare for migration ( #164317 )" ( #164396 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#164317
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: `bin/cache` does not exist on a fresh checkout,
and `echo bin/cache/...` will fail as a result.
This blocked the google3 roll, but would also break new checkouts of
Flutter, for regular users/contributors.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
Towards https://github.com/flutter/flutter/issues/164315 .
This PR just writes `bin/cache/engine.stamp` identically to how
`bin/internal/engine.version` would otherwise be written, with a caveat
that _if_ `engine.version` is tracked, it is now _copied_ to
`bin/cache/engine.stamp`.
After this lands, I'll send PRs to update tooling that looks for
`engine.version` and give a heads up to the larger team (i.e. Dart HH
bot or whomever we will break by doing this).
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-02-28 20:16:36 +00:00
Hannes Hultergård
6958d086bc
Add action for configuring default action of EditableText.onTapUpOutside ( #162575 )
...
This PR adds an `Action` for configuring a default action of
`EditableText.onTapUpOutside`. This is the equivalent to what
https://github.com/flutter/flutter/pull/150125 did for
`EditableText.onTapOutside`.
Fixes https://github.com/flutter/flutter/issues/162212
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-02-28 19:01:33 +00:00
Reid Baker
845c7779b8
Align jvmTarget usages across codebase, while editing build.gradle files align them with android version documentation ( #164200 )
...
Related to #149836
Find all jvmTarget definitions that do not use JavaVersion.* then update
them.
While editing those files align the usages with
docs/contributing/Android-API-And-Related-Versions.md.
Documentation source that this pr follows
https://github.com/flutter/flutter/pull/164198/files#diff-ee6ec18be8d752e2696c8ccc8bec2f202dfc29a43b3b4f9d8041aa6bc3e852a1
This pr is expected to cause no behavioral changes.
This pr makes logical sense after
https://github.com/flutter/flutter/pull/164198 but can be landed in any
order.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-28 17:48:21 +00:00
engine-flutter-autoroll
787adc75ed
Roll Packages from 01d3d5c1dca3 to 70b41e1adff0 (5 revisions) ( #164380 )
...
01d3d5c1dc...70b41e1adfpawel.jakubowski@leancode.pl [camera_avfoundation] Migrate
tests to Swift - part 3 (flutter/packages#8661 )
2025-02-28 matanlurey@users.noreply.github.com Do not update patch
versions for `dependabot/github-actions`. (flutter/packages#8697 )
2025-02-28 reidbaker@google.com [flutter_plugin_android_lifecycle] use
flutter.compileSdkVersion to see what breaks (flutter/packages#8700 )
2025-02-28 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Fixes crash where the native
`AuthenticationChallengeResponse` could not be found for auth requests
(flutter/packages#8707 )
2025-02-27 engine-flutter-autoroll@skia.org Roll Flutter from
16592066d70b to 2e570ca393c8 (75 revisions) (flutter/packages#8731 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-28 16:50:36 +00:00
Mikhail Novoseltsev
b8902e6a17
[tool] Allow using archiveName in android bundle build ( #162390 )
...
fixes #126971
Also, for some reason, fixes #147261 , which shouldn't have been ever
broken since this case tested here:
b007899d3a/packages/flutter_tools/test/general.shard/android/gradle_find_bundle_test.dart (L153-L173)https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Key change here is replacing the optimistic approach of guessing the
filename based on buildInfo parameters with the actual discovery of
built artifacts on the filesystem. This change is needed because there
is no way the build can determine the archiveName from Gradle, which
differentiates this part from other parameters such as buildType and
flavor. Flutter build contains information about them, but not about the
base name.
<img width="673" alt="Screenshot 2025-01-29 at 22 42 29"
src="https://github.com/user-attachments/assets/ab530a00-031f-48e2-962c-ed010b4009c9 "
/>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Reid Baker <hamilton.reid.baker@gmail.com>
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
Co-authored-by: Reid Baker <reidbaker@google.com>
2025-02-28 14:57:20 +00:00
Jonas Uekötter
556ae54358
Fix incorrectly checking for invalid environment variables in the tool ( #164101 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
This PR removes a check that looks for the use of Flutter version
related Dart define keys in the environment variables (not Dart defines)
of the user of the Flutter tool. We don't need to check the environment
variables, we only need to check the user defined Dart defines.
Here's how it currently works:
1. User builds a Flutter app via tool
2. tool checks environment variables for Flutter version related Dart
define keys and throws if it finds and (_and_)
3. tool checks list of user defined Dart defines for Flutter version
related Dart define keys and throws if it finds any
This PR removes the check in step 2, since step 3 is what we actually
care about.
The `FLUTTER_GIT_URL` environment variable is set on forks and the Dart
define is used to make that information available to applications at
runtime. However, environment variables don't propagate to be Dart
defines, thus the above mentioned check is not needed.
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
Fixes #164093
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-28 14:48:15 +00:00
Robert Ancell
933cb5da82
Support forward and back buttons ( #164356 )
...
Based on https://github.com/flutter/flutter/pull/163500 by @2bndy5
2025-02-28 14:28:47 +00:00
Robert Ancell
25b3a4743a
Fix window creation callback for multi-window ( #164353 )
...
The windowing handler wasn't being created early enough and the view
wasn't visibile by default.
2025-02-28 13:41:10 +00:00
Robert Ancell
887d5dd9c2
Fix flutter doctor usage of eglinfo in failure cases. ( #164334 )
...
Ignore return value from eglinfo - it doesn't indicate failure.
Discovered when using an X11 system where Wayland is not available. It
returns 1 in this case, but the output is still valid. Confirmed by
looking at the eglinfo source - we should parse the output regardless of
what it returns.
Catch exception correctly when eglinfo is not installed.
Fixes for https://github.com/flutter/flutter/pull/163980
2025-02-28 13:07:55 +00:00
Sigurd Meldgaard
45b21ec3bb
Refactor writing of package config in tests ( #163734 )
...
Seems like each test had its own way of doing this.
Extracted from https://github.com/flutter/flutter/pull/160443
2025-02-28 08:51:59 +00:00
yim
4da1dec288
Fixed the issue that Slider's secondaryTrackValue is not updated. ( #163996 )
...
Fixes : #163971
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
2025-02-28 05:54:20 +00:00
flutter-pub-roller-bot
e44aa576cb
Roll pub packages ( #164357 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2025-02-28 05:10:25 +00:00
John McDole
0149760734
Remove Mac mac_unopt presubmit retry count ( #164350 )
...
https://github.com/flutter/flutter/issues/157636#issuecomment-2689493410
fyi: @flar
2025-02-28 03:33:38 +00:00
engine-flutter-autoroll
c9d0176a46
Roll Fuchsia Linux SDK from 1elkOxihZuTEiTXzY... to QMun2itYrV_zUYrvW... ( #164351 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC matanl@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-28 03:14:30 +00:00
yim
25a5b2b6cb
Drag handles only need to be tested on mobile platforms. ( #163723 )
...
This PR modifies a test that aims to verify whether the toolbar remains
visible when dragging the end handle. However, on desktop platforms,
there is no end handle.
<img
src="https://github.com/user-attachments/assets/25575f7c-4856-4954-9c59-9cf2e009d63b "
width="300">
This issue was initially introduced here:
https://github.com/flutter/flutter/pull/161731#pullrequestreview-2574978920 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-28 02:30:37 +00:00
Jonah Williams
cd7a24c1b9
[Android] Use java for looking up Android API level. ( #163558 )
...
android_get_device_api_level is an API 24 API, whereas flutter supports
down to API 21. We have other places in the engine that use this API but
they're not on paths that work < 29. Even though the ndk API seems to
work on older devices we should still probably not rely on it...
2025-02-28 01:59:42 +00:00
Matan Lurey
6f71aa9901
Write an identical value to bin/cache/engine.stamp to prepare for migration ( #164317 )
...
Towards https://github.com/flutter/flutter/issues/164315 .
This PR just writes `bin/cache/engine.stamp` identically to how
`bin/internal/engine.version` would otherwise be written, with a caveat
that _if_ `engine.version` is tracked, it is now _copied_ to
`bin/cache/engine.stamp`.
After this lands, I'll send PRs to update tooling that looks for
`engine.version` and give a heads up to the larger team (i.e. Dart HH
bot or whomever we will break by doing this).
2025-02-28 01:52:57 +00:00
chunhtai
37ff5a337a
Wires up expanded state in web engine ( #164048 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
fixes https://github.com/flutter/flutter/issues/162141
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
2025-02-27 23:44:01 +00:00
Matan Lurey
b8f274ddce
Remove Cheserton's File ( #164340 )
...
https://www.youtube.com/watch?v=qPGbl2gxGqI
I don't see this referenced anywhere in the repository, it's probably
pre-monorepo (or something).
2025-02-27 23:38:04 +00:00
Robert Ancell
407065ea20
Replace update semantics handler with signal. ( #163583 )
...
The previous code was built where there was only one view, and this view
provided the callback to the engine.
Now we have multiple views, they all should process the semantics update
and so the callback is replaced with a signal. This is similar to the
signal used for engine restarts.
---------
Co-authored-by: Harlen Batagelo <hbatagelo@gmail.com>
2025-02-27 23:30:53 +00:00
gaaclarke
bffe0ffc50
Split up the conical gradient fragment shader ( #164058 )
...
fixes: https://github.com/flutter/flutter/issues/163580
testing: There are existing tests (AiksTest.CanRenderConicalGradient).
The compilation failure of the nexus 5 cannot be reproduced locally so
we can't assert this fixes the problem in a test.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-27 23:30:53 +00:00
engine-flutter-autoroll
244c61133c
Roll Skia from c16b145749d4 to 4005ba3ca7b6 (3 revisions) ( #164339 )
...
https://skia.googlesource.com/skia.git/+log/c16b145749d4..4005ba3ca7b6
2025-02-27 robertphillips@google.com [graphite] Add Pipeline
serialization to Dawn
2025-02-27 markdavidscott@google.com Adds a method to retrieve JUMBF
metadata.
2025-02-27 jvanverth@google.com [graphite] Append new clip cache entries
to end of list.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-27 23:03:57 +00:00
Matan Lurey
3ab49e7d9a
Delete and update stale documentation regarding engine/engine hash. ( #164324 )
...
This is intended to be merged _after_
https://github.com/flutter/flutter/pull/164317 .
2025-02-27 22:49:58 +00:00
Matan Lurey
a19509c6c3
Document how engine.version (is/will be) computed ( #164335 )
...
Towards https://github.com/flutter/flutter/issues/163896 .
2025-02-27 22:48:48 +00:00
Christopher Fujino
eb66d03350
Update conductor to write engine.version file ( #163350 )
...
This adds a new phase to the conductor after applying cherrypicks, to
update the engine.version file with the revision from the previous
commit. Note, this will produce a different PR, because it has to be in
a different commit after squash & merge.
Automates https://github.com/flutter/flutter/issues/162265
2025-02-27 22:24:40 +00:00
Reid Baker
89f1eba3c8
remove last usages of min/compile/target SdkVersion, align sourceCompatibility across repo and update android version documentation ( #164198 )
...
Related to #149836
- Remove last usages of minSdkVersion/compileSdkVersion/targetSdkVersion
in favor of minSdk/compileSdk/targetSdk. That do not also use
`flutter.minSdkVersion` etc. (that will happen in another pass)
- Update the files that used "SdkVersion" to use equals for setting new
values. [Not yet landed documentation
change](https://github.com/flutter/flutter/pull/164195/files#diff-ee6ec18be8d752e2696c8ccc8bec2f202dfc29a43b3b4f9d8041aa6bc3e852a1 )
- align sourceCompatibility and targetCompatibility across repo to use
JavaVersion.* and update android version documentation.
This pr updates `kotlinOptions jvmTarget` documentation but does not fix
all existing usages.
This pr is expected to cause no behavioral changes.
This pr makes logical sense after
https://github.com/flutter/flutter/pull/164195 but can be landed in any
order.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-27 22:00:49 +00:00
Matan Lurey
fe6c05b778
Update links to the flutter/engine repository for the monorepo. ( #164328 )
...
Just general cleanup while working on other things.
2025-02-27 21:57:59 +00:00
Gray Mackall
c9c3e74747
Add empty io.flutter.app.FlutterApplication to give deprecation notice, and un-break projects that have not migrated ( #164233 )
...
The removal of the v1 embedding missed that this class was not marked as
deprecated, and did not provide a notice in the breaking changes
section. V1 apps that needed the functionality of the old
`FlutterApplication` were all broken in the previous release, but some
V2 apps have been referencing the v1 `FlutterApplication`.
For these apps, this is the same as extending the base
`android.app.Application`. So we can provide an "empty extension" of
that base class, to provide these v2 apps a deprecation notice, and
avoid breaking them without warning (in 3.29.1).
Arbitrarily chose the `spell_checker` integration test to reference this
empty application, let me know if you think I should bring up an
entirely new devicelab test instead.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-02-27 21:47:12 +00:00
Alexander Aprelev
6ec7ae3a1c
Revert dart sdks that were causing dartaotruntime issues in g3 ( #164307 )
...
Revert four collateral rolls, one with offending change
https://dart-review.googlesource.com/c/sdk/+/410921
Revert "Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions)
(#164168 )"
Revert "Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions)
(#164226 )"
Revert "Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions)
(#164260 )"
Revert "Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision)
(#164276 )"
Revert "Roll Dart SDK from fcda71ce147b to d70b123c77d4 (1 revision)
(#164295 )"
2025-02-27 21:06:23 +00:00
Reid Baker
72c2447307
android_host_app_v2_embedding update dependencies and documentation ( #164195 )
...
Related to #149836
Last of the non api 35 references in flutter/flutter for targetSdk and
compileSdk.
`find . -type f -name "build.gradle" | xargs grep -e "targetSdk" | tr -d
'=' | tr -s ' ' | grep -v flutter\.targetSdkVersion | grep -v
engine/src/flutter/third_party/ | grep -v "targetSdk 35"`
`find . -type f -name "build.gradle" | xargs grep -e "compileSdk" | tr
-d '=' | tr -s ' ' | grep -v flutter\.compileSdkVersion | grep -v
engine/src/flutter/third_party/ | grep -v "compileSdk 35"`
rewrite of https://github.com/flutter/flutter/pull/163622 after this
test was updated to run against a newer version of gradle and agp in
https://github.com/flutter/flutter/pull/163849/files#diff-83b6ad7c016bffbb682664eb65c576a7ebf9c312fc60727c0e0e20f5641cbc2aR462
Android-API-And-Related-Versions.md was updated to reflect that after
further investigation that android is using "=" in their documentation
and that the space syntax is discouraged. Equals is setting a property
and space is the equivalent to a function call like `compileSdk(35)` and
assignment is prefered.
The use of equals for proprty assignment also aligns with
https://docs.gradle.org/current/userguide/migrating_from_groovy_to_kotlin_dsl.html#prepare_your_groovy_scripts
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-27 20:31:08 +00:00
flutter-pub-roller-bot
6a073ce605
Roll pub packages ( #164316 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2025-02-27 19:38:00 +00:00
Jay
25f2df623d
Fix korean cupertino datepicker datetime order ( #163850 )
...
Currently, in the Korean locale (`ko`), the `CupertinoDatePicker`
displays the time in the order of `hour : minute : AM/PM`.
However, the correct format for Korean conventions is `AM/PM : hour :
minute`.
This PR modifies the `CupertinoDatePicker` to display the time in the
correct order when the Korean locale is used.
## Changes
- Updated the time display order for the Korean (`ko`) locale in
`CupertinoDatePicker`.
- Previous format: `hour : minute : AM/PM`
- Updated format: `AM/PM : hour : minute`
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-27 19:36:21 +00:00
Kevin Moore
2bc40b39dc
[web_ui] dependency cleanup ( #164256 )
...
Update dependencies across 3 web engine packages
Remove unneeded dependencies
One set of associated code fixes
2025-02-27 19:21:18 +00:00
engine-flutter-autoroll
0c200c7a09
Roll Skia from e5a33102401c to c16b145749d4 (1 revision) ( #164314 )
...
https://skia.googlesource.com/skia.git/+log/e5a33102401c..c16b145749d4
2025-02-27 jamesgk@google.com Reland "[graphite] Require colorspaces for
precomp color xform objects"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com ,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-27 19:16:48 +00:00
Kevin Moore
671bcbe6d6
[web_ui] move several uses of (deprecated) pkg:js to js_interop_unsafe ( #164264 )
2025-02-27 18:46:01 +00:00
dependabot[bot]
1ecd9fcea1
Bump codecov/codecov-action from 5.3.1 to 5.4.0 in the all-github-actions group ( #164306 )
...
Bumps the all-github-actions group with 1 update:
[codecov/codecov-action](https://github.com/codecov/codecov-action ).
Updates `codecov/codecov-action` from 5.3.1 to 5.4.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's
releases</a>.</em></p>
<blockquote>
<h2>v5.4.0</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps): bump github/codeql-action from 3.28.1 to 3.28.5 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1753 ">codecov/codecov-action#1753</a></li>
<li>build(deps): bump github/codeql-action from 3.28.5 to 3.28.8 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1757 ">codecov/codecov-action#1757</a></li>
<li>Fix a typo in the example by <a
href="https://github.com/miranska "><code>@miranska</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1758 ">codecov/codecov-action#1758</a></li>
<li>build(deps): bump github/codeql-action from 3.28.8 to 3.28.9 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1765 ">codecov/codecov-action#1765</a></li>
<li>Fix description for report_type input by <a
href="https://github.com/craigscott-crascit "><code>@craigscott-crascit</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1770 ">codecov/codecov-action#1770</a></li>
<li>Fix use of safe.directory inside containers by <a
href="https://github.com/Flamefire "><code>@Flamefire</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1768 ">codecov/codecov-action#1768</a></li>
<li>Clarify in README that <code>use_pypi</code> bypasses integrity
checks too by <a
href="https://github.com/webknjaz "><code>@webknjaz</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1773 ">codecov/codecov-action#1773</a></li>
<li>build(deps): bump github/codeql-action from 3.28.9 to 3.28.10 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1777 ">codecov/codecov-action#1777</a></li>
<li>build(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1776 ">codecov/codecov-action#1776</a></li>
<li>build(deps): bump actions/upload-artifact from 4.6.0 to 4.6.1 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1775 ">codecov/codecov-action#1775</a></li>
<li>update wrapper submodule to 0.2.0, add recurse_submodules arg by <a
href="https://github.com/matt-codecov "><code>@matt-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1780 ">codecov/codecov-action#1780</a></li>
<li>chore(release): 5.4.0 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1781 ">codecov/codecov-action#1781</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/miranska "><code>@miranska</code></a>
made their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1758 ">codecov/codecov-action#1758</a></li>
<li><a
href="https://github.com/craigscott-crascit "><code>@craigscott-crascit</code></a>
made their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1770 ">codecov/codecov-action#1770</a></li>
<li><a href="https://github.com/Flamefire "><code>@Flamefire</code></a>
made their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1768 ">codecov/codecov-action#1768</a></li>
<li><a
href="https://github.com/matt-codecov "><code>@matt-codecov</code></a>
made their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1780 ">codecov/codecov-action#1780</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.3.1...v5.4.0 ">https://github.com/codecov/codecov-action/compare/v5.3.1...v5.4.0 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md ">codecov/codecov-action's
changelog</a>.</em></p>
<blockquote>
<h2>v5.4.0</h2>
<h3>What's Changed</h3>
<ul>
<li>update wrapper submodule to 0.2.0, add recurse_submodules arg by <a
href="https://github.com/matt-codecov "><code>@matt-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1780 ">codecov/codecov-action#1780</a></li>
<li>build(deps): bump actions/upload-artifact from 4.6.0 to 4.6.1 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1775 ">codecov/codecov-action#1775</a></li>
<li>build(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1776 ">codecov/codecov-action#1776</a></li>
<li>build(deps): bump github/codeql-action from 3.28.9 to 3.28.10 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1777 ">codecov/codecov-action#1777</a></li>
<li>Clarify in README that <code>use_pypi</code> bypasses integrity
checks too by <a
href="https://github.com/webknjaz "><code>@webknjaz</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1773 ">codecov/codecov-action#1773</a></li>
<li>Fix use of safe.directory inside containers by <a
href="https://github.com/Flamefire "><code>@Flamefire</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1768 ">codecov/codecov-action#1768</a></li>
<li>Fix description for report_type input by <a
href="https://github.com/craigscott-crascit "><code>@craigscott-crascit</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1770 ">codecov/codecov-action#1770</a></li>
<li>build(deps): bump github/codeql-action from 3.28.8 to 3.28.9 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1765 ">codecov/codecov-action#1765</a></li>
<li>Fix a typo in the example by <a
href="https://github.com/miranska "><code>@miranska</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1758 ">codecov/codecov-action#1758</a></li>
<li>build(deps): bump github/codeql-action from 3.28.5 to 3.28.8 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1757 ">codecov/codecov-action#1757</a></li>
<li>build(deps): bump github/codeql-action from 3.28.1 to 3.28.5 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1753 ">codecov/codecov-action#1753</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.3.1..v5.4.0 ">https://github.com/codecov/codecov-action/compare/v5.3.1..v5.4.0 </a></p>
<h2>v5.3.1</h2>
<h3>What's Changed</h3>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.3.0..v5.3.1 ">https://github.com/codecov/codecov-action/compare/v5.3.0..v5.3.1 </a></p>
<h2>v5.3.0</h2>
<h3>What's Changed</h3>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.2.0..v5.3.0 ">https://github.com/codecov/codecov-action/compare/v5.2.0..v5.3.0 </a></p>
<h2>v5.2.0</h2>
<h3>What's Changed</h3>
<ul>
<li>Fix typo in README by <a
href="https://github.com/tserg "><code>@tserg</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1747 ">codecov/codecov-action#1747</a></li>
<li>Th/add commands by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1745 ">codecov/codecov-action#1745</a></li>
<li>use correct audience when requesting oidc token by <a
href="https://github.com/juho9000 "><code>@juho9000</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1744 ">codecov/codecov-action#1744</a></li>
<li>build(deps): bump github/codeql-action from 3.27.9 to 3.28.1 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1742 ">codecov/codecov-action#1742</a></li>
<li>build(deps): bump actions/upload-artifact from 4.4.3 to 4.6.0 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1743 ">codecov/codecov-action#1743</a></li>
<li>chore(deps): bump wrapper to 0.0.32 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1740 ">codecov/codecov-action#1740</a></li>
<li>feat: add disable-telem feature by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1739 ">codecov/codecov-action#1739</a></li>
<li>fix: remove erroneous linebreak in readme by <a
href="https://github.com/Vampire "><code>@Vampire</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1734 ">codecov/codecov-action#1734</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.1.2..v5.2.0 ">https://github.com/codecov/codecov-action/compare/v5.1.2..v5.2.0 </a></p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="0565863a31https://redirect.github.com/codecov/codecov-action/issues/1781 ">#1781</a>)</li>
<li><a
href="c545d7bd45https://redirect.github.com/codecov/codecov-action/issues/1780 ">#1780</a>)</li>
<li><a
href="2488e996fahttps://redirect.github.com/codecov/codecov-action/issues/1775 ">#1775</a>)</li>
<li><a
href="a46c158416https://redirect.github.com/codecov/codecov-action/issues/1776 ">#1776</a>)</li>
<li><a
href="062ee7e02ehttps://redirect.github.com/codecov/codecov-action/issues/1777 ">#1777</a>)</li>
<li><a
href="1fecca8ce3https://redirect.github.com/codecov/codecov-action/issues/1773 ">#1773</a>)</li>
<li><a
href="2e6e9c5a74https://redirect.github.com/codecov/codecov-action/issues/1768 ">#1768</a>)</li>
<li><a
href="a5dc5a573ehttps://redirect.github.com/codecov/codecov-action/issues/1770 ">#1770</a>)</li>
<li><a
href="4898080f15https://redirect.github.com/codecov/codecov-action/issues/1765 ">#1765</a>)</li>
<li><a
href="5efa07bc17https://redirect.github.com/codecov/codecov-action/issues/1758 ">#1758</a>)</li>
<li>Additional commits viewable in <a
href="13ce06bfc6...0565863a31https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=5.3.1&new-version=5.4.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-27 18:42:10 +00:00
