firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,392 Commits 1 Branch 0 Tags
Commit Graph

38392 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
gaaclarke
72d1c2fea6 Removes ReactorGLES::Ref (flutter/engine#56981) 
This typedef really wasn't making the codebase any easier to work with.  We don't do this for other std::shared_ptr's

test-exempt: just removes typedef

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-05 21:06:11 +00:00
Jonah Williams
2e80dbea2c [Impeller] create a 300 es variant of all GLES shaders to support UBO binding. (flutter/engine#56960) 
Create a GLES3 "backend" by compiling a second set of GLES shaders to 300 es. This allows the usage of UBOs and SSBOs.
 2024-12-05 20:56:16 +00:00
Tong Mu
f5325bf597 [Impeller] Add rounded superellipse (flutter/engine#56726) 
Support rounded superellipse.

Part of https://github.com/flutter/flutter/issues/139321 and
https://github.com/flutter/flutter/issues/13914, also related to
https://github.com/flutter/flutter/issues/91523.

### Open questions

* Alternative names:
  * Round**ed**Superellipse
  * Squircle
  * ContinuousBorderRectangle (or something like this...)
* I chose rounded superellipse because this name, albeit its length,
precisely describe this shape. "Squircle" is not strictly defined but
generally refers any shape intermediate between a rectangle and a
circle.
* Alternative definition for `corner_radius`:
* Currently the `corner_radius` corresponds to SwiftUI parameters. To
make the shape definition more generalized, we can instead define the
`corner_radius` to be the radius of the corner circles, and make the
framework do a look up table.
* The down side is, not only the work to re-calculate the table, but
also that it doesn't completely eliminates the relationship with
SwiftUI, since currently the degree of the superellipse (`n`) is also
mapped from the SwiftUI `cornerRadius`, which is not necessary for the
shape per se.
* To some extent it boils down to the question of whether we'd like this
shape to support anything beyond SwiftUI.

### Demo


https://github.com/user-attachments/assets/806ac0e9-d62f-4b04-ab6a-83436a11f6f3

Low ratio: (900, 900, 445)

<img width="520" alt="image"
src="https://github.com/user-attachments/assets/54087467-85cd-4021-91cc-a948866ab5a8">

Mid ratio: (900, 650, 180)

<img width="508" alt="image"
src="https://github.com/user-attachments/assets/460a4927-0396-462b-948d-0846a781c92c">

High ratio: (900, 650, 17)

<img width="490" alt="image"
src="https://github.com/user-attachments/assets/8d7f625d-8a3b-4aba-b3f9-f292b874b606">


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-12-05 11:27:20 -08:00
gaaclarke
4931dd81fb Moved gles pipelines to untracked handles. (flutter/engine#56955) 
issue: https://github.com/flutter/flutter/issues/159745

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-05 19:21:18 +00:00
skia-flutter-autoroll
5cb8e71fd5 Roll Dart SDK from a2a9428e761f to 56bbedca60f9 (7 revisions) (flutter/engine#56980) 
https://dart.googlesource.com/sdk.git/+log/a2a9428e761f..56bbedca60f9

2024-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-216.0.dev
2024-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-215.0.dev
2024-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-214.0.dev
2024-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-213.0.dev
2024-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-212.0.dev
2024-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-211.0.dev
2024-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-210.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-05 18:41:21 +00:00
Mouad Debbar
a3ed100995 [web] Use eventTarget when computing pointer offset (flutter/engine#56949) 
These changes are mainly things I missed in https://github.com/flutter/engine/pull/56719

Fixes https://github.com/flutter/flutter/issues/159804
 2024-12-05 18:07:20 +00:00
Brandon DeRosier
ba21393f49 Drop APNG frames that don't fit entirely within the destination surface. (flutter/engine#56928) 
As per the [spec](https://www.w3.org/TR/png/#fcTL-chunk):

> The frame must be rendered within the region defined by x_offset, y_offset, width, and height. This region may not fall outside of the default image; thus x_offset plus width must not be greater than the [IHDR](https://www.w3.org/TR/png/#11IHDR) width; similarly y_offset plus height must not be greater than the [IHDR](https://www.w3.org/TR/png/#11IHDR) height.
 2024-12-05 09:34:32 +00:00
Jonah Williams
7b1b6d13f2 [Impeller] store GLES bindings on render pass w/ offsets instead of per-command. (flutter/engine#56910) 
To reduce heap fragmentation from tons of little vectors.
 2024-12-05 06:13:30 +00:00
Jonah Williams
4453a2b85b [Impeller] avoid re-binding winding order and cull mode. (flutter/engine#56943) 
Winding order and cull mode almost never change, so avoid re-binding them over and over again. Minor performance improvement.
 2024-12-05 03:26:05 +00:00
gaaclarke
8c736f4144 Implements the naming of untracked gles handles (flutter/engine#56948) 
issue: https://github.com/flutter/flutter/issues/159745

https://github.com/flutter/engine/pull/56927 introduced untracked handles, but naming them didn't work.  This adds a test to make sure they work.  I kept naming thread-safe since it isn't happening often anyways.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-05 02:06:44 +00:00
skia-flutter-autoroll
9e25a25686 Roll Fuchsia Test Scripts from VilXq4eGH5A24wRWA... to r9Dc5VRF6sE3pJH20... (flutter/engine#56953) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC bdero@google.com,chrome-fuchsia-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-05 00:12:11 +00:00
Jonah Williams
ae6555d5a9 [Impeller] remove extra validation checks in GLES backend. (flutter/engine#56944) 
We're already doing a check if the pipeline is valid in RenderPass::AddCommand. The index checks are validated during binding, and the check for instancing is unecessary given that we don't expose.

While I'm at it do some minor cleanups.
 2024-12-04 23:24:09 +00:00
Robert Ancell
fd12f3489c Remove LSAN supressions for Linux embedder (flutter/engine#56913) 
Fixes https://github.com/flutter/flutter/issues/90155
 2024-12-05 11:44:08 +13:00
Mouad Debbar
111ba5aae9 [web] Start with a smaller memory allocation for CanvasKit (flutter/engine#56900) 
Confirmed that a sample Flutter app starts with a 32MB memory allocation for CanvasKit instead of 128MB.

| Before | After|
|-|-|
| ![image](https://github.com/user-attachments/assets/5f6f2d4d-9155-499e-b20e-a15e3d8b53ab) | ![image](https://github.com/user-attachments/assets/bf1956c4-2d2a-44a8-b781-b110be93bc6a) |

Fixes https://github.com/flutter/flutter/issues/159499

<hr>

Relevant emscripten settings:
- [`INITIAL_MEMORY`](https://emscripten.org/docs/tools_reference/settings_reference.html#initial-memory)
- [`ALLOW_MEMORY_GROWTH`](https://emscripten.org/docs/tools_reference/settings_reference.html#allow-memory-growth)
- [`MEMORY_GROWTH_GEOMETRIC_STEP`](https://emscripten.org/docs/tools_reference/settings_reference.html#memory-growth-geometric-step)
- [`MEMORY_GROWTH_GEOMETRIC_CAP`](https://emscripten.org/docs/tools_reference/settings_reference.html#memory-growth-geometric-cap)
- [`ABORTING_MALLOC`](https://emscripten.org/docs/tools_reference/settings_reference.html#aborting-malloc)

Relevant emscripten code:
- 58889f9f20/src/library.js (L290)
- Emscripten tries to grow memory by the provided growth factor. If it fails, it tries to grow by 50% of that amount. If it fails, it tries 25%. Then it gives up and fails gracefully.
 2024-12-04 21:41:50 +00:00
skia-flutter-autoroll
f5c2897a70 Manual roll Dart SDK from 470117150f34 to a2a9428e761f (1 revision) (flutter/engine#56939) 
Manual roll requested by kevinjchisholm@google.com

https://dart.googlesource.com/sdk.git/+log/470117150f34..a2a9428e761f

2024-12-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-209.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com,kevinjchisholm@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-04 19:08:21 +00:00
gaaclarke
16f5821cc4 Added the ability to make untracked opengles handles (migrated textures) (flutter/engine#56927) 
issue: https://github.com/flutter/flutter/issues/159745

This tweaks ReactorGLES so that one can easily opt out of it's
mutex/hash map for cases where we can statically reason about the safety
of doing so. The goal here was to make migration of existing code really
easy to do. It may be in the future that everything is an untracked
handle? We can move there in baby steps.

Potential follow up PRs:
- Move `Pipeline` to use untracked handles
- Move `DeviceBufferGLES` to use untracked handles
- Add a new method to synchronously delete untracked handles
- Start storing handles to be deleted in its own vector, so handles_
doesn't need to be used for deleting untracked handles

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/engine/blob/main/docs/testing/Testing-the-engine.md
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
 2024-12-04 10:51:10 -08:00
Jonah Williams
240ce64b1f [Impeller] avoid heap allocation in RenderTarget object. (flutter/engine#56829) 
All render targets created by flutter have a single color attachment. Lets specialize that case in impeller::RenderTarget by creating a field for that attachment description instead of placing it in a hashmap.
 2024-12-04 17:28:13 +00:00
Alexander Aprelev
e05a44277f Manual roll dart to 470117150f34d712ee6d8c4558b3c656d973f656 (flutter/engine#56915) 
Roll dart to 470117150f34d712ee6d8c4558b3c656d973f656

Changes since last roll

```
470117150f3 Version 3.7.0-208.0.dev
10867627709 CHANGELOG: move AOT invocation bits to the end of the 3.7 section
83863711d3b Migrate NotImportedCompletionPass.
e01bbdfd1f4 Deprecate completions from plugins api.
2a2905228fb Add extension on Completer to simplify code.
05696d50ccf Migrate postfix_completion.dart, statement_completion.dart.
ed49d04e2e0 [analysis_server] Extract some shared code from editableArguments to be used by editArgument
c54255fe9db [element model] migrate `prefer_asserts_in_initializer_lists`
eaf3912b5d6 [deps] rev core, ecosystem, glob, http_multi_server, lints, markdown, package_config, pool, protobuf, pub_semver, shelf, source_maps, source_span, stack_trace, stream_channel, string_scanner, sync_http, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, vector_math, watcher, web, web_socket_channel, webdriver, webkit_inspection_protocol, yaml, yaml_edit
11a11259724 Switch boringssl to the pre-generated GN source list.
a635ccf2f57 [analysis_server] Only mark positional arguments as editable if they wouldn't require inserting additional values
619c8511aba [analysis_server] Add tests for formatter language version for legacy protocol
a8f5e64a330 Roll Fuchsia Test Scripts from 6FgM4KTbxxmyYoiOs... to VilXq4eGH5A24wRWA...
623c574b817 [vm] Clean up few isolate fields.
bfb507a3af9 Migrate utilities.dart
06caa3fa11e [DAS] Adds new import with show option
0197beaa8e0 [flow analysis] Remove _typeContains method.
56b6e5b9f60 Json codable no type assumption in custom fromJson
e013a4c9bfa [analysis_server] Add some notes on how to use the CPU Profiler for the analysis server hosted by VS Code
0f723b3ef3c [vm] Fix build on gcc 14.2.0.
```

This is manual roll because dart_boringssl_gen_rev is no longer present
in dart sdk DEPS has to be removed from flutter engine DEPS manually.
 2024-12-04 17:03:02 +00:00
skia-flutter-autoroll
97585bd038 Roll Skia from 4ad05fb042c5 to c9647f13cded (2 revisions) (flutter/engine#56933) 
https://skia.googlesource.com/skia.git/+log/4ad05fb042c5..c9647f13cded

2024-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 667c4e94b4a5 to 2d420a4dcfc4 (3 revisions)
2024-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ecd0b68434f4 to e0d7445de8cd (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jvanverth@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-04 07:45:06 +00:00
skia-flutter-autoroll
d88abcd058 Roll Skia from e02d856f86fb to 4ad05fb042c5 (1 revision) (flutter/engine#56931) 
https://skia.googlesource.com/skia.git/+log/e02d856f86fb..4ad05fb042c5

2024-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6fe136aa8572 to ef19ac786024 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jvanverth@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-04 06:15:07 +00:00
Robert Ancell
4bcd6a93a1 Remove unused constant (flutter/engine#56929) 2024-12-04 15:21:48 +13:00
Gray Mackall
ec896de5c4 [Android] Save back handling state in Activity/Fragment bundle (flutter/engine#56715) 
Fixes https://github.com/flutter/flutter/issues/159158, and fixes b/355556397

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-04 01:07:27 +00:00
Robert Ancell
dcc250c8a5 Split keyevent channel into own class (flutter/engine#56911) 
Split the channel messaging out of the system channels to make them
simpler to understand and refactor.

The new channel classes could be automatically generated in a second
phase, e.g. using Pigeon to reduce code usage.
    
The new classes don't have tests as they will already be covered by the
existing code.
 2024-12-04 11:57:05 +13:00
Robert Ancell
d1777a3abd Add tests for errors encoding message channel request and method calls. (flutter/engine#56914) 
Fix error not being copied in this case.

Follow up to https://github.com/flutter/engine/pull/56856
 2024-12-04 10:39:46 +13:00
skia-flutter-autoroll
ffeb7d4629 Roll Skia from 8dc8bdc364f5 to e02d856f86fb (3 revisions) (flutter/engine#56926) 
https://skia.googlesource.com/skia.git/+log/8dc8bdc364f5..e02d856f86fb

2024-12-03 kjlubick@google.com Reland "Minor cleanups with AutoSTArray and AutoSTMalloc"
2024-12-03 jlavrova@google.com SkFontMgr_Android refactoring
2024-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f7cac0bb8d2f to 7adbb3e81110 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jvanverth@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-03 20:56:06 +00:00
Jonah Williams
7dbe2f50a8 [Impeller] invalidate cached atlas data, take 2. (flutter/engine#56925) 
Fixes https://github.com/flutter/flutter/issues/159704, but for real this time.
 2024-12-03 19:09:53 +00:00
Jason Simmons
6f6e5611c2 Add typeface_proxy dependency to the Skia build script for the Android font manager (flutter/engine#56924) 
This is required by the refactoring in https://skia.googlesource.com/skia/+/eb9fc76e302f873de982cefa7690443e7a2cede5
 2024-12-03 18:58:04 +00:00
skia-flutter-autoroll
4b8d901453 Roll Fuchsia Linux SDK from j424tGVlulTUzBtPj... to CCKZcL47N_2_vxAtS... (flutter/engine#56921) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-03 17:32:36 +00:00
skia-flutter-autoroll
2f7d47b723 Roll Skia from d6d1feba94d9 to 8dc8bdc364f5 (1 revision) (flutter/engine#56918) 
https://skia.googlesource.com/skia.git/+log/d6d1feba94d9..8dc8bdc364f5

2024-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ff00298c3058 to 6fe136aa8572 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jvanverth@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-03 12:27:36 +00:00
skia-flutter-autoroll
32443d0305 Roll Skia from 3db026d62805 to d6d1feba94d9 (2 revisions) (flutter/engine#56917) 
https://skia.googlesource.com/skia.git/+log/3db026d62805..d6d1feba94d9

2024-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 963fb6511438 to 667c4e94b4a5 (4 revisions)
2024-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from dbff5894310b to ecd0b68434f4 (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jvanverth@google.com,kjlubick@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-03 07:07:41 +00:00
gaaclarke
6d390bfaed Moved font glyph atlas to flat_hash_map (flutter/engine#56847) 
In https://github.com/flutter/engine/pull/56844 we saw a 15% increase in performance by switching to absl::flat_hash_map.  I suspect we say see even better results ([source](https://martin.ankerl.com/2022/08/27/hashmap-bench-01)).  The absl guidance is to default to using this.

test exempt: no intentional functional change, just performance

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-03 03:04:17 +00:00
Jonah Williams
52504d1d77 [Impeller] set GLES viewport once, remove extra unbind/validation. (flutter/engine#56902) 
Small cleanups to render_pass_gles to only set the viewport once or when it cahnges, instead of each draw. Removes scissor validation and pipeline unbind (which is slow due to hash table lookup).
 2024-12-03 01:19:18 +00:00
Robert Ancell
14ae687eac Make a mock messenger that can easily mock channels (flutter/engine#56867) 
The previous mock required knowing the specific functions used in the
binary messenger, this method instead allows test code to provide
complete platform channel implementation for testing and make simulated
platform channel calls into embedder code.
 2024-12-03 13:41:33 +13:00
skia-flutter-autoroll
3cb4a84de6 Manual roll Dart SDK from c579d193341d to 61bfa9bbb91d (1 revision) (flutter/engine#56909) 
Manual roll requested by asiva@google.com

https://dart.googlesource.com/sdk.git/+log/c579d193341d..61bfa9bbb91d

2024-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-207.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-03 00:39:26 +00:00
Robert Ancell
983837c311 Fix GTask reference counting (flutter/engine#56866) 
Incorrect reference counting of GTask objects meant platform channel
method calls would leave tasks alive that would leak memory and leave
unclosed references to the binary messenger.
 2024-12-03 13:37:31 +13:00
skia-flutter-autoroll
4c98a1c2cd Roll Skia from ac934b9e9df9 to 3db026d62805 (2 revisions) (flutter/engine#56908) 
https://skia.googlesource.com/skia.git/+log/ac934b9e9df9..3db026d62805

2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from bd94aa86becd to 04ad645c0403
2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e0222e69ea90 to ff00298c3058 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jvanverth@google.com,kjlubick@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-02 22:53:22 +00:00
skia-flutter-autoroll
d5c7efdb64 Roll Dart SDK from 46630dbefbbd to c579d193341d (1 revision) (flutter/engine#56907) 
https://dart.googlesource.com/sdk.git/+log/46630dbefbbd..c579d193341d

2024-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-206.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-02 22:02:19 +00:00
LongCatIsLooong
18cf7ae0a7 Reland "[iOS] Full keyboard access scrolling (#56606)" (flutter/engine#56842) 
Reverts flutter/engine#56802

https://github.com/flutter/flutter/pull/159517 should address the engine roll failure.

I'm not planning to land this until the coming Monday.
 2024-12-02 21:53:21 +00:00
Robert Ancell
aa01970589 Always check for errors when propagating task values. (flutter/engine#56856) 
This could occur if a request is cancelled, without this it might not chain up to the original caller correctly.
 2024-12-02 21:47:06 +00:00
skia-flutter-autoroll
d80c2b1f22 Roll Skia from 2c4ce1d953ba to ac934b9e9df9 (1 revision) (flutter/engine#56904) 
https://skia.googlesource.com/skia.git/+log/2c4ce1d953ba..ac934b9e9df9

2024-12-02 lukasza@chromium.org [rust png] Minimal build and test scaffolding for `SkPngRustEncoder`.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jvanverth@google.com,kjlubick@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-02 21:35:27 +00:00
richardexfo
c62bbc18ad Fix linux on vivante drivers. (flutter/engine#56862) 
The same problem with NVIDIA drivers which causes issue [152099](https://github.com/flutter/flutter/issues/152099) occurs with Vivante Corporation drivers.

Quick fix for issue on Vivante drivers:  
https://github.com/flutter/flutter/issues/152099

- [ x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [ x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [ x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [ x] I listed at least one issue that this PR fixes in the description above.
- [ x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
- [ x] I updated/added relevant documentation (doc comments with `///`).
- [ x] I signed the [CLA].
- [ x] All existing and new tests are passing.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-02 21:16:22 +00:00
skia-flutter-autoroll
a7db4d6b56 Roll Skia from d7751d3d6ff4 to 2c4ce1d953ba (5 revisions) (flutter/engine#56901) 
https://skia.googlesource.com/skia.git/+log/d7751d3d6ff4..2c4ce1d953ba

2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 5a657da0d714 to dbff5894310b (35 revisions)
2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from d4f01d560853 to b2e692629c1f (1 revision)
2024-12-02 jvanverth@google.com [graphite] Missed one WebGPU adapter change
2024-12-02 kjlubick@google.com Revert "Minor cleanups with AutoSTArray and AutoSTMalloc"
2024-12-02 jvanverth@google.com [graphite] Fix issue with combining clips.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jvanverth@google.com,kjlubick@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-02 20:16:08 +00:00
Tristan Ross
3ca2049252 [ci] use env for format and support arm64 hosts (flutter/engine#56268) 
Fixes running x64 binaries on arm64 hosts, this fixes systems like Raspberry Pi's, Apple Silicon, and Ampere.

Before, I would get something like:
```
Checking GN formatting...
Completed checking 0 GN files with no formatting problems.
Checking Java formatting...
No Java files with changes, skipping Java format check.
Checking Python formatting...
All python files formatted correctly.
Checking for trailing whitespace on 1 source file...
No trailing whitespace found.
No header files with changes, skipping header guard check.
Checking C++/ObjC/Shader formatting...
ERROR: Formatter command '/home/ross/flutter-engine/src/flutter/buildtools/linux-x64/clang/bin/clang-format --style=file shell/platform/linux/fl_application_test.cc' failed with exit code 255. Command output follows:

qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory

Completed checking 0 C++/ObjC/Shader files with no formatting problems
```

Now it just works, I also changed the shell script to use env since `/bin/bash` doesn't exist on NixOS so using env is a more portable solution.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-02 19:04:32 +00:00
LN Liberda
9f76c9d47e Replace outdated wiki URLs in pull request template (flutter/engine#56824) 
The wiki hasn't existed for a long time, and the URLs now require manually following through a click to the documents.

*List which issues are fixed by this PR. You must list at least one issue.*
closes https://github.com/flutter/flutter/issues/159514

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-02 18:51:23 +00:00
gaaclarke
e40835cb89 [impeller] makes UniformBindData 15% faster and adds unit test (flutter/engine#56844) 
issue: https://github.com/flutter/flutter/issues/159177

The improvements come from using absl::flat_hash_map.

measurements with std vs absl (`host_profile_arm64`):
```
# Std
0.041124
0.0398002
0.0396546
0.0405552
0.0397742

# Absl
0.0353708
0.0336834
0.0338616
0.033050
0.0331976
```

Benchmark used
```c++
TEST(BufferBindingsGLESTest, BindUniformDataMicro) {
  BufferBindingsGLES bindings;
  absl::flat_hash_map<std::string, GLint> uniform_bindings;
  uniform_bindings["SHADERMETADATA.FOOBAR"] = 1;
  bindings.SetUniformBindings(std::move(uniform_bindings));
  std::shared_ptr<MockGLES> mock_gl = MockGLES::Init();
  MockAllocator allocator;
  Bindings vertex_bindings;

  ShaderMetadata shader_metadata = {
      .name = "shader_metadata",
      .members = {ShaderStructMemberMetadata{.type = ShaderType::kFloat,
                                             .name = "foobar",
                                             .offset = 0,
                                             .size = sizeof(float),
                                             .byte_length = sizeof(float)}}};
  std::shared_ptr<ReactorGLES> reactor;
  std::shared_ptr<Allocation> backing_store = std::make_shared<Allocation>();
  ASSERT_TRUE(backing_store->Truncate(Bytes{sizeof(float)}));
  DeviceBufferGLES device_buffer(DeviceBufferDescriptor{.size = sizeof(float)},
                                 reactor, backing_store);
  BufferView buffer_view(&device_buffer, Range(0, sizeof(float)));
  vertex_bindings.buffers.push_back(BufferAndUniformSlot{
      .slot =
          ShaderUniformSlot{
              .name = "foobar", .ext_res_0 = 0, .set = 0, .binding = 0},
      .view = BufferResource(&shader_metadata, buffer_view)});
  Bindings fragment_bindings;
  int32_t count = 5'000'000;
  auto start = std::chrono::high_resolution_clock::now();
  for (int32_t i = 0; i < count; ++i) {
    bindings.BindUniformData(mock_gl->GetProcTable(), allocator,
                             vertex_bindings, fragment_bindings);
    if (i % 100 == 0) {
      mock_gl->GetCapturedCalls();
    }
  }
  auto end = std::chrono::high_resolution_clock::now();
  auto duration =
      std::chrono::duration_cast<std::chrono::microseconds>(end - start)
          .count();
  std::cout << "Execution time: " << duration / static_cast<double>(count)
            << " microseconds" << std::endl;
}
```

This is one of our hottest symbols on the raster thread:

<img width="1528" alt="Screenshot 2024-11-27 at 2 27 54 PM"
src="https://github.com/user-attachments/assets/a9029d6f-ee96-4612-83f1-6b69f24e6ce8">

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-12-02 10:46:29 -08:00
skia-flutter-autoroll
f92abcbbbe Roll Skia from dd70c8e1c38f to d7751d3d6ff4 (36 revisions) (flutter/engine#56898) 
Roll Skia from dd70c8e1c38f to d7751d3d6ff4 (36 revisions)

https://skia.googlesource.com/skia.git/+log/dd70c8e1c38f..d7751d3d6ff4

2024-12-02 kjlubick@google.com Minor cleanups with AutoSTArray and AutoSTMalloc
2024-12-02 fmalita@google.com Update SkVideoEncoder for new ffmpeg
2024-12-02 jvanverth@google.com [graphite] Update GraphiteDawnTestContext to new Adapter interface
2024-12-02 kjlubick@google.com Add Rust-based PNG decoder tests to CQ
2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a2d76f039918 to f7cac0bb8d2f (6 revisions)
2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 846022101a6f to 963fb6511438 (2 revisions)
2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d897b7ac1f75 to e0222e69ea90 (1 revision)
2024-11-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ef4dc615f82d to d897b7ac1f75 (1 revision)
2024-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2dc072ec71cc to a2d76f039918 (10 revisions)
2024-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dad165201f86 to ef4dc615f82d (3 revisions)
2024-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b24f37dbbe4a to 846022101a6f (2 revisions)
2024-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b7e10ed68dd0 to dad165201f86 (3 revisions)
2024-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2e25ea1e727e to 2dc072ec71cc (8 revisions)
2024-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 594fe3cae8c3 to b24f37dbbe4a (5 revisions)
2024-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 01354c07cdb2 to 5a657da0d714 (18 revisions)
2024-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ecc3cdc4d28b to b7e10ed68dd0 (10 revisions)
2024-11-27 epeev@google.com Reland "Reland "SkCodec: Remove the sysprop guard for SkCrabbyAvifCodec""
2024-11-27 kjlubick@google.com Remove redundant SkDoubleIsNaN function
2024-11-27 kjlubick@google.com Fix SIMD compilation error for GCC 8.x and below
2024-11-27 kjlubick@google.com Make SK_NO_SANITIZE more compatible with GCC
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 2c7a7bff0512 to d4f01d560853 (1 revision)
2024-11-27 kjlubick@google.com Remove sk_path_analyze_verbs() from include/private
2024-11-27 kjlubick@google.com Squelch warning with microhttplib and newer GCC versions
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cecefe53430a to 2e25ea1e727e (8 revisions)
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 08d21277b1a1 to ecc3cdc4d28b (1 revision)
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from dbdf344026c9 to 594fe3cae8c3 (7 revisions)
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 27f9f8696a43 to 01354c07cdb2 (21 revisions)
2024-11-27 briansalomon@gmail.com Enable gpu timer query for Graphite/Dawn
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 52028e548417 to bd94aa86becd
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 7bdb025e3cbb to 9481c3eb25d2
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 99d4627f212e to fb2d48f7af98
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 9e05eb5b9edb to e9a6ea69ff3d
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 915d114daeb2 to 08d21277b1a1 (3 revisions)
2024-11-26 lukasza@chromium.org [rust png] Delete `SkPngRustDecoder.h` from the old location.
2024-11-26 lukasza@chromium.org [rust png] Revert adding `png_codec_base_...` to `skia_codec_rust_png`.
2024-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 10c2dc7a1b4b to cecefe53430a (29 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

...
 2024-12-02 18:39:10 +00:00
skia-flutter-autoroll
0a4305b5d4 Roll Dart SDK from 5785058c9bb1 to 46630dbefbbd (12 revisions) (flutter/engine#56897) 
https://dart.googlesource.com/sdk.git/+log/5785058c9bb1..46630dbefbbd

2024-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-205.0.dev
2024-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-204.0.dev
2024-12-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-203.0.dev
2024-11-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-202.0.dev
2024-11-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-201.0.dev
2024-11-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-200.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-199.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-198.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-197.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-196.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-195.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-194.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-02 17:44:56 +00:00
gaaclarke
6e278bf216 switched reactor to absl::flat_hash_map (flutter/engine#56845) 
We don't need consistent pointers anymore since we are avoiding deleting
objects to minimize time in the writer lock

related pr with benchmarks: https://github.com/flutter/engine/pull/56844

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-12-02 09:41:25 -08:00
gaaclarke
be97fbcf13 Sped up SubpixelGlyph::Equal (flutter/engine#56851) 
This allows a quick out when the simple parameters fail to be equal
without even looking at optional properties. In the case where they both
have properties there is now one less `has_value()`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-12-02 09:40:54 -08:00
Jonah Williams
effea219cb [Impeller] dont cache glyph layout if atlas is invalid. (flutter/engine#56879) 
Fixes https://github.com/flutter/flutter/issues/159578

When the screen is shut off, the atlas context is destroyed but the text frames are not. This can lead to a state where we expect the glyph atlas to be populated but it is not. make sure to check if the atlas itself is valid.
 2024-12-02 17:39:09 +00:00