keyonghan
784ebdf2a3
Run Mac intel only targets on both intel and arm ( #127230 )
...
The slowness issue was resolved with latest xcode: https://github.com/flutter/flutter/issues/119750 , and all these targets should resume on both platforms as before. This will help mitigate high queue time on intel bots.
This PR updates these targets:
- Mac plugin_test_ios: https://github.com/flutter/flutter/issues/119764
- Mac build_tests: https://github.com/flutter/flutter/pull/120620
- Mac plugin_test: https://github.com/flutter/flutter/pull/120714
- Mac plugin_test_macos: https://github.com/flutter/flutter/pull/122212
- Mac framework_tests_misc: https://github.com/flutter/flutter/pull/122618
2023-05-19 23:22:25 +00:00
Loïc Sharma
ce61eda70c
[Windows] Ensure window is shown ( #127046 )
...
## Background
The Windows runner has a race at startup:
1. **Platform thread**: creates a hidden window
2. **Platform thread**: launches the Flutter engine
3. **UI/Raster threads**: renders the first frame
4. **Platform thread**: Registers a callback to show the window once the next frame has been rendered.
Steps 3 and 4 happen in parallel and it is possible for step 3 to complete before step 4 starts. In this scenario, the next frame callback is never called and the window is never shown.
As a result the `windows_startup_test`'s test, which [verifies that the "show window" callback is called](1f09a8662d/dev/integration_tests/windows_startup_test/windows/runner/flutter_window.cpp (L60-L64)https://github.com/flutter/flutter/issues/119415
See this thread for alternatives that were considered: https://github.com/flutter/engine/pull/42061#issuecomment-1550080722
2023-05-19 22:25:55 +00:00
engine-flutter-autoroll
41e4c5867d
Roll Flutter Engine from 3267fa29491a to f0c02aee69db (4 revisions) ( #127233 )
...
3267fa2949...f0c02aee69skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from eal6a4HeaQon_Y4ml... to TWjmvLCOnYAUgAzvT... (flutter/engine#42168 )
2023-05-19 chris@bracken.jp [macOS] Extract PlatformView mutator clip updating (flutter/engine#42164 )
2023-05-19 110993981+htoor3@users.noreply.github.com [web] Fix event offset for transformed widgets (and text input nodes). (flutter/engine#41870 )
2023-05-19 zanderso@users.noreply.github.com Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (flutter/engine#42166 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from eal6a4HeaQon to TWjmvLCOnYAU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 22:25:52 +00:00
engine-flutter-autoroll
7bb60446e2
Roll Flutter Engine from 2b14f8a1f21c to 3267fa29491a (4 revisions) ( #127224 )
...
2b14f8a1f2...3267fa2949bdero@google.com [Impeller] Limit blur kernel to 1000x1000 pixels (flutter/engine#42154 )
2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from IGeTvUK2wkajmQQ2k... to pwdDQgM88sqLmZczj... (flutter/engine#42163 )
2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 0a63dbe8cd15 to 7202b405f061 (1 revision) (flutter/engine#42162 )
2023-05-19 jonahwilliams@google.com [Impeller] Fix 1d threadgroup dispatch size, Implement drawPoint geometry computation with compute, fallback to specialized CPU. (flutter/engine#42060 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from IGeTvUK2wkaj to pwdDQgM88sqL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 21:29:21 +00:00
Phil Quitslund
d0c0439b8d
fixes to anticipate next Dart linter release ( #127211 )
...
The upcoming linter release notices null literals as unnecessary argument values and flags more `type_literal_in_constant_pattern` cases.
See breakages: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8780744067138629361/+/u/analyze_flutter_flutter/stdout
2023-05-19 21:27:24 +00:00
Kate Lovett
e8b7889dfd
Remove deprecated OverscrollIndicatorNotification.disallowGlow ( #127050 )
...
The deprecated OverscrollIndicatorNotification.disallowGlow has expired and is removed in the PR. The replacement is OverscrollIndicatorNotification.disallowIndicator. This deprecation was introduced in https://github.com/flutter/flutter/pull/87839 when the StretchingOverscrollIndicator was added. The name change made it clearer since there is now more than one overscroll indicator.
This change is supported by dart fix. â
Part of https://github.com/flutter/flutter/issues/127042
2023-05-19 19:40:51 +00:00
engine-flutter-autoroll
d211dc141a
Roll Flutter Engine from f471b37a2146 to 2b14f8a1f21c (1 revision) ( #127221 )
...
f471b37a21...2b14f8a1f2jonahwilliams@google.com [Impeller] use host image upload path on simulator (flutter/engine#42161 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 19:16:03 +00:00
Christopher Fujino
e310475fc7
[flutter_tools] only try to take a screenshot from flutter drive if the --screenshot flag is passed ( #127150 )
...
Fixes https://github.com/flutter/flutter/issues/123621
2023-05-19 19:14:17 +00:00
Zachary Anderson
31a16f342e
Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de ( #127218 )
...
goldctl hasn't been updated in about a year, and an update may be needed to reland https://github.com/flutter/flutter/pull/127110 .
2023-05-19 18:52:50 +00:00
engine-flutter-autoroll
c7b898b101
Roll Packages from b31a12861905 to 1e214d716ed4 (3 revisions) ( #127217 )
...
b31a128619...1e214d716eengine-flutter-autoroll@skia.org Roll Flutter from d0d1feb6283f to 5ae64381578c (42 revisions) (flutter/packages#4038 )
2023-05-18 stuartmorgan@google.com [ci] Lower iOS LUCI timeouts (flutter/packages#4035 )
2023-05-18 stuartmorgan@google.com [ci] Increase Android sharding (flutter/packages#4029 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 18:41:47 +00:00
engine-flutter-autoroll
4f6f1887c5
Roll Flutter Engine from a0ea4d2d9ea5 to f471b37a2146 (1 revision) ( #127212 )
...
a0ea4d2d9e...f471b37a2141930132+hellohuanlin@users.noreply.github.com [floating_cursor_selection]add some comments on the tricky part (flutter/engine#42136 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 18:13:57 +00:00
joshualitt
3001d6ab17
Revert "Migrate benchmarks to package:web" ( #127207 )
...
Reverts flutter/flutter#126848
Triggered some kind of measuring discrepancy / performance regression.
2023-05-19 10:20:44 -07:00
Chris Yang
972b447434
[tool] delete xcresult bundle file before each xcode retry. ( #127144 )
...
xcodebuild command generates a xcresult bundle file on each run, however, it doesn't delete the file generated from previous run and will throw an error if the exact file already exists.
In tool, we manually delete the file after each `flutter build` or `flutter run` command. However, there are some internal logic where xcodebuild retries multiple times.
This PR deletes the xcresult bundle file at the start of each retry if it exists.
Fixes https://github.com/flutter/flutter/issues/127119
2023-05-19 17:18:15 +00:00
Victoria Ashworth
b9e8b0a827
[iOS] Dispose of log readers and port forwarders if launch fails ( #127140 )
...
When tests run in our CI using `flutter drive`, if there is a failure it will loop and try again.
434b81f1a5/packages/flutter_tools/lib/src/drive/drive_service.dart (L177-L186)434b81f1a5/packages/flutter_tools/lib/src/ios/ios_deploy.dart (L486-L489)434b81f1a5/packages/flutter_tools/lib/src/ios/devices.dart (L585-L591)434b81f1a5/packages/flutter_tools/lib/src/ios/devices.dart (L627)434b81f1a5/packages/flutter_tools/lib/src/ios/ios_deploy.dart (L563-L576)https://github.com/flutter/flutter/issues/127141
2023-05-19 16:44:58 +00:00
engine-flutter-autoroll
077d644bbc
Roll Flutter Engine from 2e6b1e6c3458 to a0ea4d2d9ea5 (1 revision) ( #127203 )
...
2e6b1e6c34...a0ea4d2d9eskia-flutter-autoroll@skia.org Roll Skia from 9cc604b2c3ed to 0a63dbe8cd15 (1 revision) (flutter/engine#42159 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 16:40:13 +00:00
engine-flutter-autoroll
54ac355dc1
Roll Flutter Engine from e9178e115f14 to 2e6b1e6c3458 (1 revision) ( #127196 )
...
e9178e115f...2e6b1e6c34mdebbar@google.com [web] Cleanup Vector3 (flutter/engine#42096 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 15:42:35 +00:00
Felix Angelov
3af7f9bef5
fix(flutter_tools): findBundleFile w/multiple flavor dimensions ( #127133 )
...
Fixes the `findBundleFile` method in `gradle.dart` to correctly locate app bundles generated from multiple flavor dimensions.
- closes https://github.com/flutter/flutter/issues/92316
- closes https://github.com/flutter/flutter/issues/65264
2023-05-19 15:00:53 +00:00
engine-flutter-autoroll
0d67c7e10c
Roll Flutter Engine from 2e8875870f52 to e9178e115f14 (1 revision) ( #127188 )
...
2e8875870f...e9178e115fskia-flutter-autoroll@skia.org Roll Dart SDK from 4a2e45ecfc50 to f5716102efe8 (2 revisions) (flutter/engine#42156 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 13:43:43 +00:00
engine-flutter-autoroll
3d69e1f33a
Roll Flutter Engine from c7a209cc40c1 to 2e8875870f52 (1 revision) ( #127185 )
...
c7a209cc40...2e8875870fskia-flutter-autoroll@skia.org Roll Skia from aac83f59bbba to 9cc604b2c3ed (1 revision) (flutter/engine#42152 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 12:13:26 +00:00
engine-flutter-autoroll
6456d603c0
Roll Flutter Engine from 5a57ff52f0f7 to c7a209cc40c1 (2 revisions) ( #127175 )
...
5a57ff52f0...c7a209cc40skia-flutter-autoroll@skia.org Roll Skia from 9e38597c3757 to aac83f59bbba (1 revision) (flutter/engine#42150 )
2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zqkH0qb9GQ3jO24Bh... to eal6a4HeaQon_Y4ml... (flutter/engine#42149 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from zqkH0qb9GQ3j to eal6a4HeaQon
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 09:50:25 +00:00
engine-flutter-autoroll
2f299f2aa7
Roll Flutter Engine from bfbd2e1dafb0 to 5a57ff52f0f7 (1 revision) ( #127172 )
...
bfbd2e1daf...5a57ff52f0skia-flutter-autoroll@skia.org Roll Skia from 37e853069c04 to 9e38597c3757 (1 revision) (flutter/engine#42148 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 08:58:38 +00:00
engine-flutter-autoroll
b50ec64bd9
Roll Flutter Engine from e64084596182 to bfbd2e1dafb0 (2 revisions) ( #127167 )
...
e640845961...bfbd2e1dafskia-flutter-autoroll@skia.org Roll Skia from 09d8a47a1f65 to 37e853069c04 (1 revision) (flutter/engine#42147 )
2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Tl371NrGBEHFYPxHQ... to IGeTvUK2wkajmQQ2k... (flutter/engine#42145 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Tl371NrGBEHF to IGeTvUK2wkaj
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 07:06:05 +00:00
engine-flutter-autoroll
47f3532dc2
Roll Flutter Engine from 6bc60c8a9877 to e64084596182 (2 revisions) ( #127163 )
...
6bc60c8a98...e640845961skia-flutter-autoroll@skia.org Roll Dart SDK from 95b96a9f498a to 4a2e45ecfc50 (1 revision) (flutter/engine#42143 )
2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 8931359a74f1 to 09d8a47a1f65 (1 revision) (flutter/engine#42141 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 06:20:26 +00:00
engine-flutter-autoroll
fcba066bea
Roll Flutter Engine from bca11a423f9c to 6bc60c8a9877 (1 revision) ( #127162 )
...
bca11a423f...6bc60c8a98leroux_bruno@yahoo.fr [Android] Fix BasicMessageChannel.resizeChannelBuffer (flutter/engine#41982 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 05:26:16 +00:00
engine-flutter-autoroll
e49d35d3a6
Roll Flutter Engine from 9039c2dfb74c to bca11a423f9c (2 revisions) ( #127156 )
...
9039c2dfb7...bca11a423fyjbanov@google.com [web:a11y] support dialogs described by descendants (flutter/engine#42108 )
2023-05-18 47866232+chunhtai@users.noreply.github.com Makes android embedding to send full uri (flutter/engine#41836 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 02:26:29 +00:00
engine-flutter-autoroll
8135a4beda
Roll Flutter Engine from 3c23ddae1d2a to 9039c2dfb74c (2 revisions) ( #127154 )
...
3c23ddae1d...9039c2dfb7skia-flutter-autoroll@skia.org Roll Skia from 2ffed2e4c6f8 to 8931359a74f1 (4 revisions) (flutter/engine#42139 )
2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7bc022c51215 to 95b96a9f498a (2 revisions) (flutter/engine#42138 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 01:26:30 +00:00
chunhtai
ea5cfe09fd
Properly cleans up routes ( #126453 )
...
fixes https://github.com/flutter/flutter/issues/126100
2023-05-19 00:32:26 +00:00
Qun Cheng
af83c76723
Remove deprecated primaryVariant and secondaryVariant from ColorScheme ( #127124 )
...
This PR is to remove deprecated `primaryVariant` and `secondaryVariant` from framework. These two apis are made obsolete in #93427
Part of https://github.com/flutter/flutter/issues/127042
2023-05-19 00:26:53 +00:00
engine-flutter-autoroll
25d2d4dd28
Roll Flutter Engine from 17227c16ca58 to 3c23ddae1d2a (2 revisions) ( #127147 )
...
17227c16ca...3c23ddae1dskia-flutter-autoroll@skia.org Roll Skia from ac47a05bf253 to 2ffed2e4c6f8 (8 revisions) (flutter/engine#42137 )
2023-05-18 chris@bracken.jp [macOS] Refactor PlatformView mutators (flutter/engine#42130 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-19 00:05:08 +00:00
Qun Cheng
be40991082
Update useMaterial3 api doc ( #127142 )
...
This is to update the components section for `useMaterial3` api doc.
2023-05-18 23:34:07 +00:00
engine-flutter-autoroll
45808c28d9
Roll Flutter Engine from c7c679d6d411 to 17227c16ca58 (1 revision) ( #127143 )
...
c7c679d6d4...17227c16caleroux_bruno@yahoo.fr [Android] Return keyboard pressed state (flutter/engine#41695 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 23:06:15 +00:00
engine-flutter-autoroll
0b8c226aaf
Roll Flutter Engine from 2c77c8011d45 to c7c679d6d411 (1 revision) ( #127139 )
...
2c77c8011d...c7c679d6d447866232+chunhtai@users.noreply.github.com Make iOS embedding to send full uri for deeplinks (flutter/engine#41992 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 22:03:28 +00:00
engine-flutter-autoroll
affba75f2e
Roll Flutter Engine from 5fb3179a19c3 to 2c77c8011d45 (2 revisions) ( #127131 )
...
5fb3179a19...2c77c8011dkevinjchisholm@gmail.com Add configuration for automating release notes (flutter/engine#42132 )
2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from 62841fa33e95 to ac47a05bf253 (9 revisions) (flutter/engine#42131 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 21:20:25 +00:00
joshualitt
4fea3ef588
Migrate benchmarks to package:web ( #126848 )
2023-05-18 14:02:12 -07:00
engine-flutter-autoroll
2d6c67f4a4
Roll Flutter Engine from 237c60185ace to 5fb3179a19c3 (3 revisions) ( #127126 )
...
237c60185a...5fb3179a19skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from jNFpQ1gTCMNbzSZCw... to Tl371NrGBEHFYPxHQ... (flutter/engine#42128 )
2023-05-18 103135467+sealesj@users.noreply.github.com Vuln scan github actions permissions (flutter/engine#42099 )
2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 1991015ad460 to 7bc022c51215 (1 revision) (flutter/engine#42125 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from jNFpQ1gTCMNb to Tl371NrGBEHF
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 19:14:24 +00:00
Mahdi Bagheri
434b81f1a5
Fixing richMessage gesture recognizer in tooltip widget ( #126207 )
...
Fixing #126206 and #113388 issues
*The IgnorePointer is preventing the richMessage touch events being recognized. Just removing that from*
*Solves #126206 and #113388*
2023-05-18 18:32:22 +00:00
engine-flutter-autoroll
682dd3bdc8
Roll Flutter Engine from 843ce0bba356 to 237c60185ace (2 revisions) ( #127122 )
...
843ce0bba3...237c60185askia-flutter-autoroll@skia.org Roll Skia from ad8fa4a38668 to 62841fa33e95 (2 revisions) (flutter/engine#42123 )
2023-05-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SDKw1RvH0dWiJXERo... to zqkH0qb9GQ3jO24Bh... (flutter/engine#42124 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SDKw1RvH0dWi to zqkH0qb9GQ3j
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 18:22:07 +00:00
Michael Goderbauer
5ae6438157
Revert "Handle null return from WillPopCallback" ( #127112 )
...
Reverts flutter/flutter#127039
Google3 has been fixed, so this work around is no longe necessary.
2023-05-18 17:47:54 +00:00
engine-flutter-autoroll
2b95fa67a7
Roll Flutter Engine from a22dd6438335 to 843ce0bba356 (6 revisions) ( #127116 )
...
a22dd64383...843ce0bba3skia-flutter-autoroll@skia.org Roll Skia from a3a9fb5f4a31 to ad8fa4a38668 (1 revision) (flutter/engine#42121 )
2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f6fabbe9fba to 1991015ad460 (4 revisions) (flutter/engine#42120 )
2023-05-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from wNfsef5we4l8hxEII... to jNFpQ1gTCMNbzSZCw... (flutter/engine#42118 )
2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from caff30d16ae7 to a3a9fb5f4a31 (1 revision) (flutter/engine#42117 )
2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from ffa425bacfc4 to caff30d16ae7 (29 revisions) (flutter/engine#42116 )
2023-05-18 chris@bracken.jp [macOS] Clean up PlatformView mutator scaling (flutter/engine#42110 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from wNfsef5we4l8 to jNFpQ1gTCMNb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 17:29:18 +00:00
Christopher Fujino
344c9c6af2
mark windows build tests non-bringup ( #127059 )
...
This is a follow-up to aa0a1a7ae1
2023-05-18 17:08:21 +00:00
engine-flutter-autoroll
4245883c6b
Roll Flutter Engine from d97037077963 to a22dd6438335 (1 revision) ( #127071 )
...
d970370779...a22dd64383xilaizhang@google.com [g3 roll] Revert "add non-rendering
operation culling to DisplayListBuilder" (flutter/engine#42097 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 09:27:52 -07:00
engine-flutter-autoroll
5381e82a0b
Roll Packages from 5c6991400e91 to b31a12861905 (9 revisions) ( #127109 )
...
5c6991400e...b31a128619stuartmorgan@google.com [flutter_plugin_android_lifecycle] Fix lints (flutter/packages#4030 )
2023-05-18 ian@hixie.ch [rfw] Fix a typo in the API documentation (flutter/packages#4023 )
2023-05-18 ditman@gmail.com [ci] Manual flutter roll (flutter/packages#4033 )
2023-05-17 4195507+fmt-Println-MKO@users.noreply.github.com [flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar (flutter/packages#3746 )
2023-05-17 stuartmorgan@google.com [tools] Ignore comments in federated safety check (flutter/packages#4028 )
2023-05-17 reidbaker@google.com Revert "[url_launcher] Set broadcast reciever visability as required by target api 34" (flutter/packages#4027 )
2023-05-17 stuartmorgan@google.com [camera] Fix Java lints in camerax version (flutter/packages#3966 )
2023-05-17 34871572+gmackall@users.noreply.github.com [image_picker] Upgrade androidx.activity to 1.7.0 and add a dependency on kotlin-bom to align kotlin transitive dependencies (flutter/packages#3968 )
2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [espresso]: Bump com.squareup.okhttp3:okhttp from 4.10.0 to 4.11.0 in /packages/espresso/android (flutter/packages#3804 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-18 16:27:11 +00:00
Justin McCandless
6071f149b5
Revert "Remove obsolete drawShadow bounds workaround" ( #127110 )
...
Reverts flutter/flutter#127052 , which seems to be breaking the build
because of a goldens failure.
```
The following TestFailure was thrown running a test:
Expected: one widget whose rasterized image matches golden image "shadow.PhysicalModel.enabled.png"
Actual: _WidgetTypeFinder:<exactly one widget with type "Container" (ignoring offstage widgets):
Container(bg: Color(0xfffff59d), margin: EdgeInsets.all(150.0))>
```
See
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_tests_6/11051/overview
2023-05-18 09:05:07 -07:00
Qun Cheng
f31dae2a80
Clip search view content during animation ( #126975 )
...
Fixes #126590
This PR is to clip the view content when the view size is not big enough, such as during animation.
Also removes some unused properties in `_ViewContent` class: `getRect` and `viewConstraints`
2023-05-18 00:18:51 +00:00
Jim Graham
8089a309a9
Remove obsolete drawShadow bounds workaround ( #127052 )
...
This workaround was created 6 years ago with no links to bug databases to track. As best we can determine, the issue is no longer present in SkPicture or DisplayList and is most likely obsolete. More importantly, though, non-rendering primitives are ignored by the DisplayList construction and so this workaround will just be ignored anyway. If a problem surfaces about this issue that we haven't discovered by a thorough code search of the current code base, then workarounds should be installed within the relevant implementation modules rather than in the framework (and documented with bugs filed in either or both of Flutter's github repos, and/or the Skia issue database).
Workaround originally created in this PR: https://github.com/flutter/flutter/pull/9654
2023-05-18 00:17:33 +00:00
Loïc Sharma
718f444bc3
[Windows] Improve version migration message ( #127048 )
...
This also migrates the platform channel example to stamp version information on Windows.
2023-05-17 23:07:16 +00:00
dependabot[bot]
a3a0ef0393
Bump actions/labeler from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb ( #127056 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb.
<details>
<summary>Commits</summary>
<ul>
<li><a href="6b107e7a7ehttps://redirect.github.com/actions/labeler/issues/565 ">#565</a>)</li>
<li><a href="d93c73a681https://redirect.github.com/actions/labeler/issues/566 ">#566</a>)</li>
<li><a href="b6f708799chttps://redirect.github.com/actions/labeler/issues/559 ">#559</a>)</li>
<li><a href="2d89bd5059https://redirect.github.com/actions/labeler/issues/560 ">#560</a>)</li>
<li><a href="581d1100aahttps://redirect.github.com/actions/labeler/issues/558 ">#558</a>)</li>
<li><a href="8bb4872750https://redirect.github.com/actions/labeler/issues/543 ">#543</a>)</li>
<li><a href="9c4ae1e112https://redirect.github.com/actions/labeler/issues/553 ">#553</a>)</li>
<li><a href="228fdad71dhttps://redirect.github.com/actions/labeler/issues/544 ">#544</a>)</li>
<li><a href="377691d3d6https://redirect.github.com/actions/labeler/issues/554 ">#554</a>)</li>
<li>See full diff in <a href="9471598e3b...6b107e7a7e
2023-05-17 22:57:48 +00:00
Renzo Olivares
d44d657ade
Remove deprecated fixTextFieldOutlineLabel ( #125893 )
...
The deprecation period has elapsed. The method was made obsolete in https://github.com/flutter/flutter/pull/87281 .
2023-05-17 22:56:14 +00:00
engine-flutter-autoroll
45179a62c8
Roll Flutter Engine from 331c5769e291 to d97037077963 (3 revisions) ( #127053 )
...
331c5769e2...d970370779skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YrEDYUB9NKhirgo5s... to SDKw1RvH0dWiJXERo... (flutter/engine#42100 )
2023-05-17 jonahwilliams@google.com [Impelller] fix flickering due to synchronization issues in compute tessellator. (flutter/engine#42076 )
2023-05-17 rmolivares@renzo-olivares.dev [Android] Do not collapse text selection on shift key up (flutter/engine#42075 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from YrEDYUB9NKhi to SDKw1RvH0dWi
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-17 22:52:28 +00:00
Christopher Fujino
aa0a1a7ae1
shard windows build tests 3 -> 4 ( #127057 )
...
Time outs are currently making the tree red.
Fixes https://github.com/flutter/flutter/issues/127004
2023-05-17 15:49:35 -07:00
