Viren Khatri
d5df458684
add tests for dominant bottom sheet in scaffold ( #124472 )
...
while debugging https://github.com/flutter/flutter/issues/123882 found out that below lines were untested. although they'll change due to the issue above, but the tests will remain.
e0045d04f7/packages/flutter/lib/src/material/scaffold.dart (L3169-L3180)
2023-05-05 20:51:14 +00:00
Patrick Lindsay
37f348b006
Added CupertinoDatepicker monthYear mode (flutter#93508) ( #125603 )
...
This PR adds a month and year mode to the CupertinoDatePicker. The monthYear mode is the date mode without the day of the month.
This feature was added at the request of:
[Proposal] CupertinoDatePicker with month and year. #93508
One thing that I was unsure of was the use of the DatePickerDateOrder to determine the monthYear order. It could be considered a workaround since the DatePickerDateOrder is intended to order day, month, and year. This means that a developer could use the DatePickerDateOrder.dmy (day, month, year) or DatePickerDateOrder.mdy (month, day, year) to get the same result.
At first I intended to add a DatePickerMonthYearOrder enum to the localizations, in addition to a new parameter for the CupertinoDatePicker for monthYearOrder, but I ended up reverting these changes (1c61f1084e
2023-05-05 20:49:34 +00:00
Qun Cheng
c1c2513ac9
Add Switch.trackOutlineWidth property ( #125848 )
2023-05-05 13:34:08 -07:00
chunhtai
78ed142f30
Rename iosdeeplinksettings to iosuniversallinksettings ( #126173 )
...
as title
2023-05-05 20:02:27 +00:00
engine-flutter-autoroll
be0aa01b18
Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) ( #126174 )
...
f3efe11f44...6b467df16eskia-flutter-autoroll@skia.org Roll Skia from 1a1c7db436e4 to d6149a13d696 (6 revisions) (flutter/engine#41779 )
2023-05-05 godofredoc@google.com Replace legacy linux unopt with engine v2. (flutter/engine#41757 )
2023-05-05 godofredoc@google.com Allow default out_dir for fuchsia symbols upload. (flutter/engine#41776 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 19:58:24 +00:00
Alberto Azinar
4d4b3cf2f7
improvement : removed required kotlin dependency ( #125002 )
...
This PR removed the non-necessary required Koltin dependency. This is because the Kotlin Gradle adds the dependency on the standard library automatically.
Fixes #98212
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy]. *
2023-05-05 19:47:22 +00:00
ChenRenJie
dbcff31ed0
Fix incorrect assert hint in flutter.groovy ( #125283 )
...
When I include flutter in my exist android project by
`include_flutter.groovy`, it hint me:
```
Project :app doesn't exist. To custom the host app project name, set `org.gradle.project.flutter.hostAppProjectName=<project-name>` in gradle.properties.
```
But set `org.gradle.project.flutter.hostAppProjectName` has no effect,
acutally need to set `flutter.hostAppProjectName`.
This pr is to fix this incorrect hint.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-05 15:34:54 -04:00
Drew Roen
676be36651
Update .cirrus.yml ( #126166 )
...
The previous key expires in 5 days: https://github.com/flutter/flutter/issues/126072
2023-05-05 19:16:55 +00:00
Kevin Moore
f9d455134a
tool: replace top-level functions with enum properties ( #126167 )
2023-05-05 19:10:07 +00:00
Jackson Gardner
201f7311f7
Use direct dart API from dart:ui_web rather than JS shim. ( #123443 )
...
This is based off (and dependent on) these changes in the web engine that expose web-specific APIs: https://github.com/flutter/engine/pull/40608
2023-05-05 18:17:21 +00:00
Istiak Ahmed
042eaf6b90
Add sample code for SliverAppBar ( #125785 )
...
This PR adds an another example for SliverAppBar, showing the use of stretch and onStretchTrigger
https://user-images.githubusercontent.com/68919043/235420973-2bfb9871-9e05-4d87-9538-941d43178c76.mp4
Fixes #125651
### Adds sample code for SliverAppBar [stretch, onStretchTrigger]
This PR adds an another simple and easily understandable example code for SliverAppBar.
2023-05-05 18:09:25 +00:00
engine-flutter-autoroll
f57d38f7f2
Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) ( #126163 )
...
cef0e9d1a9...f3efe11f44skia-flutter-autoroll@skia.org Roll Dart SDK from 07016e96b9ed to bb9f17a8f0c3 (1 revision) (flutter/engine#41773 )
2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from d71ece9f9f1a to 1a1c7db436e4 (1 revision) (flutter/engine#41772 )
2023-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from de2Eqw0IsOzTq15m3... to Z3O1yYOsNgkQ6b0o3... (flutter/engine#41771 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from de2Eqw0IsOzT to Z3O1yYOsNgkQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 17:02:15 +00:00
Bruno Leroux
de2615462c
Add a ReorderableListView example with cards + cleanup existing tests ( #126155 )
...
## Description
This PR adds one `ReorderableListView` example to demonstrate how `proxyDecorator` can be used to animate cards elevation.
https://user-images.githubusercontent.com/840911/236468570-d2b33ab3-6b6d-4f8d-90de-778dcf1ad8ce.mp4
For motivation, see https://github.com/flutter/flutter/issues/124729#issuecomment-1521524190 .
## Related Issue
Fixes https://github.com/flutter/flutter/issues/124729
## Tests
Adds 1 tests.
This PR also moves some misplaced example tests from `examples/api/test/reorderable_list` to `examples/api/test/material/reorderable_list` (and replaces two existing ones).
2023-05-05 16:39:11 +00:00
engine-flutter-autoroll
e24de32760
Roll Packages from 6bd59cdb8fb5 to a0f8fd89af1a (4 revisions) ( #126161 )
...
6bd59cdb8f...a0f8fd89aftarrinneal@gmail.com tree fix (flutter/packages#3910 )
2023-05-05 tarrinneal@gmail.com manual roll and fix (flutter/packages#3903 )
2023-05-04 stuartmorgan@google.com [file_selector] Add `getDirectoryPaths` (flutter/packages#3871 )
2023-05-04 75943909+TheUltimateOptimist@users.noreply.github.com [go_router_builder] fixed typo in README (flutter/packages#3835 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 15:59:07 +00:00
Drew Roen
9de9a81b80
Bring back the failing build_test's ( #126014 )
...
https://github.com/flutter/flutter/issues/125897
The issue has been resolved, so bringing the tests out of bringup
2023-05-05 15:54:43 +00:00
Mouad Debbar
28f3037758
[web] Use plain platform views in benchmarks ( #126080 )
...
Removing the dependency between web benchmarks and `url_launcher`'s `Link` widget.
2023-05-05 14:17:34 +00:00
Taha Tesser
ad009fb7ac
Fix Material 3 tab indicator weight and position ( #125883 )
...
fixes https://github.com/flutter/flutter/issues/123112
### Description
1. Add proper M3 indicator height aka`IndictorWeight` from the M3 specs for the primary tab bar with label indicator size.
db6074ade4/dev/tools/gen_defaults/data/navigation_tab_primary.json (L9)https://github.com/flutter/flutter/issues/123112 .
6. Fix the `startOffset` const value from https://github.com/flutter/flutter/pull/125036 to match docs and move it to a variable.
2023-05-05 14:09:18 +00:00
engine-flutter-autoroll
9d9ad2d52f
Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) ( #126150 )
...
b0f53e7751...cef0e9d1a9skia-flutter-autoroll@skia.org Roll Dart SDK from eff8f62a7bc7 to 07016e96b9ed (1 revision) (flutter/engine#41770 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 13:33:50 +00:00
engine-flutter-autoroll
5120a0df62
Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) ( #126148 )
...
6f26066144...b0f53e7751skia-flutter-autoroll@skia.org Roll Skia from edc4ee2e286e to d71ece9f9f1a (2 revisions) (flutter/engine#41768 )
2023-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m0-fwGyFnoDVAvxgk... to jbpFz7qSikrKiRanC... (flutter/engine#41769 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from m0-fwGyFnoDV to jbpFz7qSikrK
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 11:47:37 +00:00
engine-flutter-autoroll
d3f2fc79d1
Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) ( #126141 )
...
764991e046...6f26066144skia-flutter-autoroll@skia.org Roll Dart SDK from afeed9f8701e to eff8f62a7bc7 (2 revisions) (flutter/engine#41764 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 09:49:01 +00:00
engine-flutter-autoroll
9ddba1be35
Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) ( #126137 )
...
e7cd29153a...764991e046skia-flutter-autoroll@skia.org Roll Skia from bf4217c3f0da to edc4ee2e286e (1 revision) (flutter/engine#41763 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 08:44:25 +00:00
engine-flutter-autoroll
59c1ac4103
Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) ( #126135 )
...
a885ed472e...e7cd29153adkwingsmt@users.noreply.github.com [macOS] Change view ID's type to signed and a typedef (flutter/engine#41653 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 07:55:09 +00:00
engine-flutter-autoroll
9b36fda920
Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) ( #126129 )
...
c97a0deccb...a885ed472eskia-flutter-autoroll@skia.org Roll Skia from 6577130e14b6 to bf4217c3f0da (1 revision) (flutter/engine#41762 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 05:54:23 +00:00
Tirth
91a84dedf5
[NavigationDrawer] adds padding property in NavigationDrawer Widget ( #123961 )
...
Adds `tilePadding` property to `NavigationDrawer` Widget.
Fixes : #121662
| Without adding `tilePadding` in NavigationDrawer | With `tilePadding: EdgeInsets.all(16)` in NavigationDrawer |
| --- | --- |
|  |  |
2023-05-05 05:36:30 +00:00
engine-flutter-autoroll
04e284a49d
Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) ( #126124 )
...
269ce2deeb...c97a0deccb30322203+ksballetba@users.noreply.github.com Close connection on keyboard close (flutter/engine#41500 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 04:31:05 +00:00
engine-flutter-autoroll
e9d486cd48
Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) ( #126115 )
...
4d50706728...269ce2deebskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SD8Q_B7eWZqLgqo0f... to de2Eqw0IsOzTq15m3... (flutter/engine#41755 )
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 00693e987828 to 6577130e14b6 (1 revision) (flutter/engine#41752 )
2023-05-04 jacksongardner@google.com Revert "Skwasm Font Loading" (flutter/engine#41750 )
2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 95e133dbd3a6 to afeed9f8701e (1 revision) (flutter/engine#41749 )
2023-05-04 magder@google.com Fix flaky FlutterChannelsTests, stop mocking `NSObject` (flutter/engine#41747 )
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from a4828415b4af to 00693e987828 (6 revisions) (flutter/engine#41746 )
2023-05-04 godofredoc@google.com Migrate linux unopt to engine_v2. (flutter/engine#41658 )
2023-05-04 jonahwilliams@google.com [Impeller] check if path is Rect/RRect/Oval (flutter/engine#41744 )
2023-05-04 lhkbob@gmail.com Add temporary staging GN arg for Skia roll (flutter/engine#41743 )
2023-05-04 jason-simmons@users.noreply.github.com Roll buildroot to 05ec9f7124191c7ba354521f3ffd34b09af872e7 (flutter/engine#41736 )
2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 7b56aac98a5a to 95e133dbd3a6 (1 revision) (flutter/engine#41741 )
2023-05-04 dnfield@google.com Disable flaky tests on arm64 (flutter/engine#41740 )
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 6950f56ad2ec to a4828415b4af (2 revisions) (flutter/engine#41737 )
2023-05-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LIacrdFhuTuHnYh0B... to m0-fwGyFnoDVAvxgk... (flutter/engine#41738 )
2023-05-04 jacksongardner@google.com Skwasm Font Loading (flutter/engine#41246 )
2023-05-04 godofredoc@google.com Migrate linux_host_engine to engine v2. (flutter/engine#41715 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from LIacrdFhuTuH to m0-fwGyFnoDV
fuchsia/sdk/core/mac-amd64 from SD8Q_B7eWZqL to de2Eqw0IsOzT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-05 02:08:41 +00:00
Ian Hickson
a11da307bf
Minor fixes found while working on blankcanvas ( #125751 )
...
This PR contains a series of minor changes to address issues that I happened to run into:
- Pretty-print errors triggered when handling events that are pending because of having locked event handling. Previously these were just dumped to the console.
- Add more documentation for `debugPaintPadding`.
- Add documentation to `Tween` saying how to implement it.
- Slight formatting changes in the scrollbar code to align some expressions.
- Since we convert ScrollMetricsNotifications to ScrollNotifications in various places, provide an explicit API to do this. This will make the behaviour consistent throughout, and makes the code easier to understand. Added a test for this.
- Clarifications to some of the BindingBase and SchedulerBinding documentation.
- Clarified some documentation in `flutter_test`'s `Finder` class.
2023-05-05 00:34:04 +00:00
Kevin Moore
f22dd30c96
tool-web: use ProcessUtil.run to invoke child processes ( #126109 )
...
All invocations are logged on verbose
Better, more detailed exceptions are thrown on errors
A lot less boilerplate
2023-05-05 00:32:28 +00:00
chunhtai
0b657236ca
Cleans up appbar imply leading logic ( #125315 )
...
fixes https://github.com/flutter/flutter/issues/80256
2023-05-04 22:21:11 +00:00
chunhtai
b00f1c4599
Adding vmservice to get iOS app settings ( #123156 )
...
fixes https://github.com/flutter/flutter/issues/120405
2023-05-04 22:14:11 +00:00
Kevin Moore
529b919f09
tool-web-wasm: make wasm-opt an "option" instead of a "flag" ( #126035 )
...
Allows controlling a broader set of variables than just on/off.
Also make wasm-opt "full" the default
2023-05-04 22:07:12 +00:00
Polina Cherkasova
5a80f8d637
Define testWidgetsWithLeakTracking. ( #125063 )
2023-05-04 12:09:41 -07:00
engine-flutter-autoroll
fde717da53
Roll Packages from 407b7da0079e to 6bd59cdb8fb5 (5 revisions) ( #126078 )
...
407b7da007...6bd59cdb8f41930132+hellohuanlin@users.noreply.github.com [pigeon][reland]enable treat warnings as errors for swift code in unit test (flutter/packages#3901 )
2023-05-04 stuartmorgan@google.com [video_player] Fix Android lints (flutter/packages#3886 )
2023-05-04 stuartmorgan@google.com [quick_actions] Fix Android lint issues (flutter/packages#3885 )
2023-05-03 andrewjohncoutts@gmail.com [camera_platform_interface] [camera] [camera_android] Add NV21 as an image stream format (flutter/packages#3277 )
2023-05-03 stuartmorgan@google.com Revert "[pigeon]enable treat warning as errors for swift code in unit test" (flutter/packages#3898 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 18:34:13 +00:00
Pierre-Louis
8ec5001ac2
Provide default constraints for M3 dialogs ( #120082 )
...
This PR constrains M3 dialogs to 560dp max width and height.
This is not a breaking change per the breaking change policy.
Part of https://github.com/flutter/flutter/issues/118619
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-04 19:27:11 +02:00
engine-flutter-autoroll
c2022aa5b1
Roll Flutter Engine from 31de1c79ad56 to 4d5070672859 (2 revisions) ( #126067 )
...
31de1c79ad...4d50706728skia-flutter-autoroll@skia.org Roll Dart SDK from 47da769ae13a to 7b56aac98a5a (1 revision) (flutter/engine#41731 )
2023-05-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from LCajvqTauUudC-7RW... to SD8Q_B7eWZqLgqo0f... (flutter/engine#41730 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from LCajvqTauUud to SD8Q_B7eWZqL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 15:05:49 +00:00
Yu
ce32282c0c
Fix typo in README.md ( #126053 )
2023-05-04 14:58:17 +02:00
Michael Goderbauer
4bf297ceb2
Fix nullability of ClipRRect.borderRadius ( #125878 )
...
The property was typed as nullable, but the code assumed its always non-null. This makes the property non-nullable as well.
Also refactors CupertinoListSection, which was flagged by the analyzer when borderRadius became non-nullable (no functional change, just cleaning up existing code to avoid the warning).
2023-05-04 12:54:12 +00:00
engine-flutter-autoroll
f53335bff4
Roll Flutter Engine from ee646f9dd4c0 to 31de1c79ad56 (1 revision) ( #126060 )
...
ee646f9dd4...31de1c79adskia-flutter-autoroll@skia.org Roll Skia from 02e4b3087869 to 6950f56ad2ec (1 revision) (flutter/engine#41729 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 12:24:31 +00:00
engine-flutter-autoroll
accc943259
Roll Flutter Engine from a344b0df36f1 to ee646f9dd4c0 (3 revisions) ( #126057 )
...
a344b0df36...ee646f9dd4skia-flutter-autoroll@skia.org Roll Skia from 5c0f4c9bdc35 to 02e4b3087869 (1 revision) (flutter/engine#41728 )
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 9b19c0a0acf0 to 5c0f4c9bdc35 (1 revision) (flutter/engine#41727 )
2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 59787216f670 to 47da769ae13a (2 revisions) (flutter/engine#41726 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 11:31:17 +00:00
engine-flutter-autoroll
dbd1d534c8
Roll Flutter Engine from b764b9cd2c45 to a344b0df36f1 (1 revision) ( #126048 )
...
b764b9cd2c...a344b0df36skia-flutter-autoroll@skia.org Roll Skia from 93c869da03f5 to 9b19c0a0acf0 (14 revisions) (flutter/engine#41725 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 08:42:39 +00:00
Nate Bosch
2089eacc00
Switch imports from test_api to focused libaries ( #125854 )
...
Move imports of API available in `hooks.dart` or `scaffolding.dart` to use those more narrow libraries.
Move imports of APIs from `package:matcher` to import directly. The next major version of `test_api` will remove the exports of `matcher` APIs.
2023-05-04 08:01:12 +00:00
engine-flutter-autoroll
f309eadfa3
Roll Flutter Engine from 4152b851e78e to b764b9cd2c45 (1 revision) ( #126045 )
...
4152b851e7...b764b9cd2cskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from n1UnzmslAzt04yRv6... to LIacrdFhuTuHnYh0B... (flutter/engine#41724 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from n1UnzmslAzt0 to LIacrdFhuTuH
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 07:52:17 +00:00
engine-flutter-autoroll
d51c59c78e
Roll Flutter Engine from da45a21708f2 to 4152b851e78e (1 revision) ( #126042 )
...
da45a21708...4152b851e7jacksongardner@google.com Populate fallback fonts from CIPD in tests (flutter/engine#41656 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 06:57:14 +00:00
engine-flutter-autoroll
ebf3ea1755
Roll Flutter Engine from ee65be7d8fb1 to da45a21708f2 (3 revisions) ( #126037 )
...
ee65be7d8f...da45a21708dnfield@google.com Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib (flutter/engine#41720 )
2023-05-04 bdero@google.com [Impeller] Remove the DrawPaint->Clear optimization (flutter/engine#41711 )
2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 3cfcfb24bc6a to 59787216f670 (2 revisions) (flutter/engine#41718 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 03:25:08 +00:00
engine-flutter-autoroll
15386d9d17
Roll Flutter Engine from 85516ecc0e4c to ee65be7d8fb1 (2 revisions) ( #126032 )
...
85516ecc0e...ee65be7d8fgodofredoc@google.com Add relative path support for malioc_diff. (flutter/engine#41703 )
2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WAfNudyWPOGyWSpZD... to LCajvqTauUudC-7RW... (flutter/engine#41716 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from WAfNudyWPOGy to LCajvqTauUud
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 01:35:35 +00:00
Kevin Moore
5816da8074
[tool] consistently use environment (not globals) in targets/web.dart ( #125937 )
...
Also update the order of args to commands so that testing has less repeated "stuff"
2023-05-04 00:47:06 +00:00
engine-flutter-autoroll
8449623ea5
Roll Flutter Engine from a0906bdfc845 to 85516ecc0e4c (1 revision) ( #126027 )
...
a0906bdfc8...85516ecc0edkwingsmt@users.noreply.github.com [macOS] Remove view ID from public (flutter/engine#41712 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-04 00:26:06 +00:00
Jenn Magder
4f3c989bd3
Remove complex_layout_*__compile benchmarks ( #126023 )
...
Fixes https://github.com/flutter/flutter/issues/126020 .
2023-05-03 23:49:01 +00:00
engine-flutter-autoroll
d6ef15edc1
Roll Flutter Engine from 7d70dc81cfa5 to a0906bdfc845 (8 revisions) ( #126018 )
...
7d70dc81cf...a0906bdfc8bdero@google.com [Impeller] Load instead of restore drawing for non-MSAA passes (flutter/engine#41676 )
2023-05-03 jonahwilliams@google.com Remove physical model layer (flutter/engine#41593 )
2023-05-03 gspencergoog@users.noreply.github.com Reland: "Determine lifecycle by looking at window focus also" (#41094 ) (flutter/engine#41702 )
2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 887e58fff02f to 93c869da03f5 (12 revisions) (flutter/engine#41705 )
2023-05-03 mdebbar@google.com [web] Improve null safety for color->css (flutter/engine#41699 )
2023-05-03 mdebbar@google.com [web] Remove unused function parameter (flutter/engine#41700 )
2023-05-03 godofredoc@google.com Migrate Android Engine Debug to Engine V2. (flutter/engine#41687 )
2023-05-03 kjlubick@users.noreply.github.com Migrate SkSurface::getBackend* methods to static functions (flutter/engine#41693 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-03 22:57:11 +00:00
Kevin Moore
2c56a25da3
[tool] Improve help info with build web --wasm flags ( #125907 )
...
Also fixed some comments
2023-05-03 21:02:07 +00:00
